[GitHub] mgodave commented on issue #1137: Schema registry

[GitBox]

mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-379797837
 
 
   All changes are merged, this tracking ticket can be closed or merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1137: Schema registry

[GitBox]

mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365065103
 
 
   sounds good. I can easily break this apart again.
   
   On Mon, Feb 12, 2018 at 2:07 PM, Ivan Kelly 
   wrote:
   
   > Yes, github really sucks at this. gerrit does it much better.
   >
   > What I do these days is to create a larger WIP patch which has everything
   > and is there for reference. Then I push one patch at a time. The review
   > velocity isn't so high that having multiple patches out for review makes
   > much sense anyhow. Once an out for review patch is merged, I then merge
   > master into my WIP branch, and break off another chunk.
   >
   > ?
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1137: Schema registry

[GitBox]

mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365061364
 
 
   Yeah, I was thinking
   
   1. Proto changes
   2. Schema Registry
   3. Default Implementation
   
   The funny thing is that this is how my branches were originally organized.
   I didn't know how to submit dependent PRs so I merged them all into one
   branch. I'll leave this one here for reference and re-split them up.
   
   -Dave
   
   On Mon, Feb 12, 2018 at 2:02 PM, Ivan Kelly 
   wrote:
   
   > And maybe the bookkeeper schema storage implementation can be a separate
   > patch too?
   >
   > ?
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1137: Schema registry

[GitBox]

mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365060102
 
 
   Noted
   
   On Mon, Feb 12, 2018 at 1:59 PM, Ivan Kelly 
   wrote:
   
   > Even just having the proto (and compiled stuff) separate would make it
   > easier to look at.
   >
   > ?
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1137: Schema registry

[GitBox]

mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059450
 
 
   I tried to do that before and I wasn't happy with how it worked out. I'll
   take another look.
   
   On Mon, Feb 12, 2018 at 1:54 PM, Ivan Kelly 
   wrote:
   
   > Almost 7000 LoCs. Any chance this could be broken into more digestible
   > pieces for review? Like leave this PR here for reference, for example
   > submit proto files first, and then chunk it into patches around 400-500
   > lines long each that can be reviewed in around an hour?
   >
   > ?
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services