[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185673143
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/s3offload/BlockAwareSegmentInputStreamTest.java
##
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.s3offload;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.fail;
+import static org.testng.internal.junit.ArrayAsserts.assertArrayEquals;
+
+import com.google.common.io.ByteStreams;
+import com.google.common.primitives.Ints;
+import com.google.common.primitives.Longs;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import io.netty.util.concurrent.DefaultThreadFactory;
+import java.io.ByteArrayInputStream;
+import java.nio.ByteBuffer;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.Executors;
+import java.util.stream.IntStream;
+import lombok.Data;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.client.api.LastConfirmedAndEntry;
+import org.apache.bookkeeper.client.api.LedgerEntries;
+import org.apache.bookkeeper.client.api.LedgerEntry;
+import org.apache.bookkeeper.client.api.LedgerMetadata;
+import org.apache.bookkeeper.client.api.ReadHandle;
+import org.apache.pulsar.broker.s3offload.DataBlockHeader;
+import
org.apache.pulsar.broker.s3offload.impl.BlockAwareSegmentInputStreamImpl;
+import org.apache.pulsar.broker.s3offload.impl.DataBlockHeaderImpl;
+import org.testng.annotations.Test;
+import org.testng.collections.Lists;
+
+@Slf4j
+public class BlockAwareSegmentInputStreamTest {
+@Data
+class MockLedgerEntry implements LedgerEntry {
+public byte blockPadding = 0xB;
+long ledgerId;
+long entryId;
+long length;
+byte entryBytes[];
+ByteBuf entryBuffer;
+
+MockLedgerEntry(long ledgerId, long entryId, long length) {
+this.ledgerId = ledgerId;
+this.entryId = entryId;
+this.length = length;
+this.entryBytes = new byte[(int)length];
+entryBuffer = Unpooled.wrappedBuffer(entryBytes);
+entryBuffer.writerIndex(0);
+IntStream.range(0, (int)length).forEach(i ->
entryBuffer.writeByte(blockPadding));
+}
+
+@Override
+public ByteBuffer getEntryNioBuffer() {
+return null;
+}
+
+@Override
+public LedgerEntry duplicate() {
+return null;
+}
+
+@Override
+public void close() {
+entryBuffer.release();
+}
+}
+
+@Data
+class MockLedgerEntries implements LedgerEntries {
+int ledgerId;
+int startEntryId;
+int count;
+int entrySize;
+List entries;
+
+MockLedgerEntries(int ledgerId, int startEntryId, int count, int
entrySize) {
+this.ledgerId = ledgerId;
+this.startEntryId = startEntryId;
+this.count = count;
+this.entrySize = entrySize;
+this.entries = Lists.newArrayList(count);
+
+IntStream.range(startEntryId, startEntryId + count).forEach(i ->
+entries.add(new MockLedgerEntry(ledgerId, i, entrySize)));
+}
+
+@Override
+public void close() {
+entries.clear();
+}
+
+@Override
+public LedgerEntry getEntry(long entryId) {
+if (entryId < startEntryId || entryId >= startEntryId + count) {
+return null;
+}
+
+return entries.get(((int)entryId - startEntryId));
+}
+
+@Override
+public Iterator iterator() {
+return entries.iterator();
+}
+}
+
+class MockReadHandle implements ReadHandle {
+int ledgerId;
+int entrySize;
+int lac;
+MockReadHandle(int ledgerId, int entrySize, int lac) {
+this.ledgerId = ledgerId;
+this.entrySize = entrySize;
+this.lac = lac;
+
[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185665085
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStreamImpl.java
##
@@ -0,0 +1,217 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.s3offload.impl;
+
+import static com.google.common.base.Preconditions.checkState;
+
+import com.google.common.collect.Lists;
+import com.google.common.primitives.Ints;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.CompositeByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import org.apache.bookkeeper.client.api.LedgerEntries;
+import org.apache.bookkeeper.client.api.LedgerEntry;
+import org.apache.bookkeeper.client.api.ReadHandle;
+import org.apache.pulsar.broker.s3offload.BlockAwareSegmentInputStream;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * The BlockAwareSegmentInputStreamImpl for each cold storage data block.
+ * It gets data from ledger, and will be read out the content for a data block.
+ * DataBlockHeader + entries(each with format[[entry_size -- int][entry_id --
long][entry_data]]) + padding
+ */
+public class BlockAwareSegmentInputStreamImpl extends InputStream implements
BlockAwareSegmentInputStream {
+private static final Logger log =
LoggerFactory.getLogger(BlockAwareSegmentInputStreamImpl.class);
+
+private static final byte[] BLOCK_END_PADDING =
Ints.toByteArray(0xFEDCDEAD);
+
+private final ReadHandle ledger;
+private final long startEntryId;
+private final int blockSize;
+
+// Number of Message entries that read from ledger and been readout from
this InputStream.
+private int blockEntryCount;
+
+// tracking read status for both header and entries.
+// Bytes that already been read from this InputStream
+private int bytesReadOffset = 0;
+// Byte from this index is all padding byte
+private int dataBlockFullOffset;
+private final InputStream dataBlockHeaderStream;
+
+// how many entries want to read from ReadHandle each time.
+private static final int ENTRIES_PER_READ = 100;
+// buf the entry size and entry id.
+private static final int ENTRY_HEADER_SIZE = 4 /* entry size*/ + 8 /*
entry id */;
+// Keep a list of all entries ByteBuf, each ByteBuf contains 2 buf: entry
header and entry content.
+private List entriesByteBuf = null;
+
+public BlockAwareSegmentInputStreamImpl(ReadHandle ledger, long
startEntryId, int blockSize) {
+this.ledger = ledger;
+this.startEntryId = startEntryId;
+this.blockSize = blockSize;
+this.dataBlockHeaderStream = DataBlockHeaderImpl.of(blockSize,
startEntryId).toStream();
+this.blockEntryCount = 0;
+this.dataBlockFullOffset = blockSize;
+this.entriesByteBuf = Lists.newLinkedList();
+}
+
+// read ledger entries.
+private int readEntries() throws IOException {
+checkState(bytesReadOffset >=
DataBlockHeaderImpl.getDataStartOffset());
+checkState(bytesReadOffset < blockSize);
+
+// once reach the end of entry buffer, start a new read.
+if (bytesReadOffset < dataBlockFullOffset && entriesByteBuf.isEmpty())
{
Review comment:
OK. current code is try to release buffers earlier, and make each call of
`readEntries` do less thing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185533001
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStream.java
##
@@ -90,68 +84,60 @@ private int readEntries() throws IOException {
checkState(bytesReadOffset >=
DataBlockHeaderImpl.getDataStartOffset());
checkState(bytesReadOffset < dataBlockFullOffset);
-try {
-// once reach the end of entry buffer, start a new read.
-if (entriesByteBuf.isEmpty()) {
-readNextEntriesFromLedger();
-log.debug("After readNextEntriesFromLedger: bytesReadOffset:
{}, blockBytesHave: {}",
-bytesReadOffset, blockBytesHave);
-}
-
-// always read from the first ByteBuf in the list, once read all
of its content remove it.
-ByteBuf entryByteBuf = entriesByteBuf.get(0);
-int ret = entryByteBuf.readByte();
-bytesReadOffset ++;
+// once reach the end of entry buffer, start a new read.
+if (entriesByteBuf.isEmpty()) {
+entriesByteBuf = readNextEntriesFromLedger(startEntryId +
blockEntryCount, ENTRIES_PER_READ);
+}
-if (entryByteBuf.readableBytes() == 0) {
-entryByteBuf.release();
-entriesByteBuf.remove(0);
+// always read from the first ByteBuf in the list, once read all of
its content remove it.
+ByteBuf entryByteBuf = entriesByteBuf.get(0);
+int ret = entryByteBuf.readByte();
+bytesReadOffset ++;
+
+if (entryByteBuf.readableBytes() == 0) {
+entryByteBuf.release();
+entriesByteBuf.remove(0);
+blockEntryCount++;
+if ((!entriesByteBuf.isEmpty()) && bytesReadOffset +
entriesByteBuf.get(0).readableBytes() > blockSize) {
Review comment:
Thanks, will change it. This change did not follow the former comments, one
reason is we need to keep dataBlockFullOffset to calculate the accurate bytes
read from ledger, another reason is only when reading a new entry, it need to
do the judgement `(bytesReadOffset + entryByteBuf.bytesAvailable()) >
blockSize`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185509828
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStream.java
##
@@ -90,68 +84,60 @@ private int readEntries() throws IOException {
checkState(bytesReadOffset >=
DataBlockHeaderImpl.getDataStartOffset());
checkState(bytesReadOffset < dataBlockFullOffset);
-try {
-// once reach the end of entry buffer, start a new read.
-if (entriesByteBuf.isEmpty()) {
-readNextEntriesFromLedger();
-log.debug("After readNextEntriesFromLedger: bytesReadOffset:
{}, blockBytesHave: {}",
-bytesReadOffset, blockBytesHave);
-}
-
-// always read from the first ByteBuf in the list, once read all
of its content remove it.
-ByteBuf entryByteBuf = entriesByteBuf.get(0);
-int ret = entryByteBuf.readByte();
-bytesReadOffset ++;
+// once reach the end of entry buffer, start a new read.
+if (entriesByteBuf.isEmpty()) {
+entriesByteBuf = readNextEntriesFromLedger(startEntryId +
blockEntryCount, ENTRIES_PER_READ);
Review comment:
it will return empty list, and line 93 will get IndexOutOfBoundsException.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185492114
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStream.java
##
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.s3offload.impl;
+
+import static com.google.common.base.Preconditions.checkState;
+
+import com.google.common.collect.Lists;
+import com.google.common.primitives.Ints;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.CompositeByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import org.apache.bookkeeper.client.api.LedgerEntries;
+import org.apache.bookkeeper.client.api.LedgerEntry;
+import org.apache.bookkeeper.client.api.ReadHandle;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ *
+ * The BlockAwareSegmentInputStream for each cold storage data block.
+ * It contains a byte buffer, which contains all the content for this data
block.
+ * DataBlockHeader + entries(each with format[[entry_size --
int][entry_id -- long][entry_data]])
+ *
+ */
+public class BlockAwareSegmentInputStream extends InputStream {
Review comment:
thanks, will do it later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185491684
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStream.java
##
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.s3offload.impl;
+
+import static com.google.common.base.Preconditions.checkState;
+
+import com.google.common.collect.Lists;
+import com.google.common.primitives.Ints;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.CompositeByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import org.apache.bookkeeper.client.api.LedgerEntries;
+import org.apache.bookkeeper.client.api.LedgerEntry;
+import org.apache.bookkeeper.client.api.ReadHandle;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ *
+ * The BlockAwareSegmentInputStream for each cold storage data block.
+ * It contains a byte buffer, which contains all the content for this data
block.
+ * DataBlockHeader + entries(each with format[[entry_size --
int][entry_id -- long][entry_data]])
+ *
+ */
+public class BlockAwareSegmentInputStream extends InputStream {
+private static final Logger log =
LoggerFactory.getLogger(BlockAwareSegmentInputStream.class);
+
+private static final byte[] blockEndPadding = Ints.toByteArray(0xFEDCDEAD);
+
+private final ReadHandle ledger;
+private final long startEntryId;
+private final int blockSize;
+
+// Number of Message entries that read from ledger and been readout from
this InputStream.
+private int blockEntryCount;
+// Number of payload Bytes read from ledger, and has been has been kept in
this InputStream.
+private int payloadBytesHave;
+// Number of bytes that has been kept in this InputStream.
+private int blockBytesHave;
+
+// tracking read status for both header and entries.
+// Bytes that already been read from this InputStream
+private int bytesReadOffset = 0;
+// Byte from this index is all padding byte
+private int dataBlockFullOffset;
+private final InputStream dataBlockHeaderStream;
+
+// how many entries want to read from ReadHandle each time.
+private static final int entriesNumberEachRead = 100;
+// buf the entry size and entry id.
+private static final int entryHeaderSize = 4 /* entry size*/ + 8 /* entry
id */;
+// Keep a list of all entries ByteBuf, each element contains 2 buf: entry
header and entry content.
+private List entriesByteBuf = null;
+
+public BlockAwareSegmentInputStream(ReadHandle ledger, long startEntryId,
int blockSize) {
+this.ledger = ledger;
+this.startEntryId = startEntryId;
+this.blockSize = blockSize;
+this.dataBlockHeaderStream = DataBlockHeaderImpl.of(blockSize,
startEntryId).toStream();
+this.blockBytesHave = DataBlockHeaderImpl.getDataStartOffset();
+this.payloadBytesHave = 0;
+this.blockEntryCount = 0;
+this.dataBlockFullOffset = blockSize;
+this.entriesByteBuf = Lists.newLinkedList();
+}
+
+// read ledger entries.
+private int readEntries() throws IOException {
+checkState(bytesReadOffset >=
DataBlockHeaderImpl.getDataStartOffset());
+checkState(bytesReadOffset < dataBlockFullOffset);
+
+try {
+// once reach the end of entry buffer, start a new read.
+if (entriesByteBuf.isEmpty()) {
+readNextEntriesFromLedger();
+log.debug("After readNextEntriesFromLedger: bytesReadOffset:
{}, blockBytesHave: {}",
+bytesReadOffset, blockBytesHave);
+}
+
+// always read from the first ByteBuf in the list, once read all
of its content remove it.
+ByteBuf entryByteBuf = entriesByteBuf.get(0);
+int ret = entryByteBuf.readByte();
+bytesReadOffset ++;
+
+
[GitHub] zhaijack commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test
zhaijack commented on a change in pull request #1678: PIP-17: provide
BlockAwareSegmentInputStream implementation and test
URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185464725
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStream.java
##
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.s3offload.impl;
+
+import static com.google.common.base.Preconditions.checkState;
+
+import com.google.common.collect.Lists;
+import com.google.common.primitives.Ints;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.CompositeByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+import org.apache.bookkeeper.client.api.LedgerEntries;
+import org.apache.bookkeeper.client.api.LedgerEntry;
+import org.apache.bookkeeper.client.api.ReadHandle;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ *
+ * The BlockAwareSegmentInputStream for each cold storage data block.
+ * It contains a byte buffer, which contains all the content for this data
block.
+ * DataBlockHeader + entries(each with format[[entry_size --
int][entry_id -- long][entry_data]])
+ *
+ */
+public class BlockAwareSegmentInputStream extends InputStream {
+private static final Logger log =
LoggerFactory.getLogger(BlockAwareSegmentInputStream.class);
+
+private static final byte[] blockEndPadding = Ints.toByteArray(0xFEDCDEAD);
+
+private final ReadHandle ledger;
+private final long startEntryId;
+private final int blockSize;
+
+// Number of Message entries that read from ledger and been readout from
this InputStream.
+private int blockEntryCount;
+// Number of payload Bytes read from ledger, and has been has been kept in
this InputStream.
+private int payloadBytesHave;
+// Number of bytes that has been kept in this InputStream.
+private int blockBytesHave;
+
+// tracking read status for both header and entries.
+// Bytes that already been read from this InputStream
+private int bytesReadOffset = 0;
+// Byte from this index is all padding byte
+private int dataBlockFullOffset;
+private final InputStream dataBlockHeaderStream;
+
+// how many entries want to read from ReadHandle each time.
+private static final int entriesNumberEachRead = 100;
+// buf the entry size and entry id.
+private static final int entryHeaderSize = 4 /* entry size*/ + 8 /* entry
id */;
+// Keep a list of all entries ByteBuf, each element contains 2 buf: entry
header and entry content.
+private List entriesByteBuf = null;
Review comment:
Thanks, it can be, would like to keep it , or change it to List,
this is more clear for code reader.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
