zhaijack commented on issue #1236: Make TopicsConsumerImpl extends
PartitionedConsumerImpl
URL:
https://github.com/apache/incubator-pulsar/issues/1236#issuecomment-366440758
In the code review, @merlimat mentioned this:
```
I would suggest to just rename PartitionedConsumerImpl, change the
constructor to accept a list of topics (rather than the number of partitions)
and switch to use TopicMessageIdImpl. I don't think that UnAckedMessageTracker
usage would need to be changed.
That would avoid to add a lot of new code and having to merge it later.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services