This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push: new 858648e Misc fixes (#2579) 858648e is described below commit 858648eb24aeba9d95a7e83513830afd40cb21fe Author: Sanjeev Kulkarni <sanjee...@gmail.com> AuthorDate: Fri Sep 14 22:33:03 2018 -0700 Misc fixes (#2579) This pr does a couple of minor nits 1. Add a log statement in Sink to make it consistent with the Source. 2. Added AllArgs/NoArgs constructor for some test related objects --- .../src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java | 2 ++ .../org/apache/pulsar/functions/api/examples/CustomBaseObject.java | 2 ++ .../org/apache/pulsar/functions/api/examples/CustomDerivedObject.java | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java index 835e288..4449045 100644 --- a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java +++ b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java @@ -205,6 +205,8 @@ public class PulsarSink<T> implements Sink<T> { @Override public void open(Map<String, Object> config, SinkContext sinkContext) throws Exception { + log.info("Opening pulsar sink with config: {}", pulsarSinkConfig); + Schema<T> schema = initializeSchema(); FunctionConfig.ProcessingGuarantees processingGuarantees = this.pulsarSinkConfig.getProcessingGuarantees(); diff --git a/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomBaseObject.java b/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomBaseObject.java index 173393b..6102887 100644 --- a/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomBaseObject.java +++ b/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomBaseObject.java @@ -20,11 +20,13 @@ package org.apache.pulsar.functions.api.examples; import lombok.AllArgsConstructor; import lombok.Getter; +import lombok.NoArgsConstructor; import lombok.Setter; @Getter @Setter @AllArgsConstructor +@NoArgsConstructor public class CustomBaseObject { private long baseValue; } diff --git a/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomDerivedObject.java b/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomDerivedObject.java index 464e977..d700231 100644 --- a/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomDerivedObject.java +++ b/pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CustomDerivedObject.java @@ -18,11 +18,15 @@ */ package org.apache.pulsar.functions.api.examples; +import lombok.AllArgsConstructor; import lombok.Getter; +import lombok.NoArgsConstructor; import lombok.Setter; @Getter @Setter +@AllArgsConstructor +@NoArgsConstructor public class CustomDerivedObject extends CustomBaseObject { private int derivedValue; public CustomDerivedObject(long baseValue, int derivedValue) {