[PR] [ISSUE #8203] Adjust the timing of delayed messages to avoid a concentrated distribution [rocketmq]
RapperCL opened a new pull request, #8204: URL: https://github.com/apache/rocketmq/pull/8204 ### Which Issue(s) This PR Fixes Fixes #8203 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Adjust the timing of delayed messages to avoid a concentrated distribution and strive to distribute them evenly. [rocketmq]
RapperCL opened a new issue, #8203: URL: https://github.com/apache/rocketmq/issues/8203 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary org.apache.rocketmq.store.timer.TimerMessageStore#doEnqueue  When the remaining delay time of a message is greater than the time wheel period, the delayTime of such messages is set to the current time plus half a period or the current time plus the full period. However, this approach can result in an excessive concentration of messages with different delay times in the same time period, which should be distributed more evenly. To better handle this scenario, the current delay time should be taken into consideration, while also ensuring enough time for the next roll. Therefore: For messages with a difference of 1 to 4/3 of a period, give them 2/3 of a period to complete the roll. For messages with a difference greater than 4/3 of a period, use 1/10 of a period as the dispersal range. The reason for choosing a fixed increase of time greater than or equal to 9/10 of a period is to avoid too small increments that would increase the number of rolls. ### Motivation To avoid an overly concentrated distribution of delayed messages, ### Describe the Solution You'd Like To better handle this scenario, the current delay time should be taken into consideration, while also ensuring enough time for the next roll. Therefore: For messages with a difference of 1 to 4/3 of a period, give them 2/3 of a period to complete the roll. For messages with a difference greater than 4/3 of a period, use 1/10 of a period as the dispersal range. The reason for choosing a fixed increase of time greater than or equal to 9/10 of a period is to avoid too small increments that would increase the number of rolls. ### Describe Alternatives You've Considered add random time ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-eventbridge): Workflow run "mvn package with test case" failed!
The GitHub Actions job "mvn package with test case" on rocketmq-eventbridge.git has failed. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: e427cbf10f8381facd3c0117ebb5135d9c0911f2 / dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps): bump com.jayway.jsonpath:json-path from 2.4.0 to 2.9.0 Bumps [com.jayway.jsonpath:json-path](https://github.com/jayway/JsonPath) from 2.4.0 to 2.9.0. - [Release notes](https://github.com/jayway/JsonPath/releases) - [Changelog](https://github.com/json-path/JsonPath/blob/master/changelog.md) - [Commits](https://github.com/jayway/JsonPath/compare/json-path-2.4.0...json-path-2.9.0) --- updated-dependencies: - dependency-name: com.jayway.jsonpath:json-path dependency-type: direct:production ... Signed-off-by: dependabot[bot] Report URL: https://github.com/apache/rocketmq-eventbridge/actions/runs/9233102838 With regards, GitHub Actions via GitBox
[PR] build(deps): bump com.jayway.jsonpath:json-path from 2.4.0 to 2.9.0 [rocketmq-eventbridge]
dependabot[bot] opened a new pull request, #176: URL: https://github.com/apache/rocketmq-eventbridge/pull/176 Bumps [com.jayway.jsonpath:json-path](https://github.com/jayway/JsonPath) from 2.4.0 to 2.9.0. Release notes Sourced from https://github.com/jayway/JsonPath/releases;>com.jayway.jsonpath:json-path's releases. json-path-2.9.0 What's Changed Fix for https://github.com/advisories/GHSA-pfh2-hfmq-phg5;>CVE-2023-51074. update dependencies by https://github.com/SingingBush;>@SingingBush in https://redirect.github.com/json-path/JsonPath/pull/965;>json-path/JsonPath#965 JPMS: define Automatic-Module-Name as json.path by https://github.com/SingingBush;>@SingingBush in https://redirect.github.com/json-path/JsonPath/pull/966;>json-path/JsonPath#966 Bump json-smart version from 2.4.10 to 2.5.0 by https://github.com/shoothzj;>@shoothzj in https://redirect.github.com/json-path/JsonPath/pull/945;>json-path/JsonPath#945 Fixed rendering error on $..book[?(@.price = $['expensive'])] in README.md by https://github.com/lulunac27a;>@lulunac27a in https://redirect.github.com/json-path/JsonPath/pull/967;>json-path/JsonPath#967 [build] Remove deprecated gradle convetion usage by https://github.com/shoothzj;>@shoothzj in https://redirect.github.com/json-path/JsonPath/pull/946;>json-path/JsonPath#946 Check for the existence of the next significant bracket by https://github.com/twobiers;>@twobiers in https://redirect.github.com/json-path/JsonPath/pull/985;>json-path/JsonPath#985 Update versions by https://github.com/kallestenflo;>@kallestenflo in https://redirect.github.com/json-path/JsonPath/pull/987;>json-path/JsonPath#987 New Contributors https://github.com/lulunac27a;>@lulunac27a made their first contribution in https://redirect.github.com/json-path/JsonPath/pull/967;>json-path/JsonPath#967 https://github.com/twobiers;>@twobiers made their first contribution in https://redirect.github.com/json-path/JsonPath/pull/985;>json-path/JsonPath#985 Full Changelog: https://github.com/json-path/JsonPath/compare/json-path-2.8.0...json-path-2.9.0;>https://github.com/json-path/JsonPath/compare/json-path-2.8.0...json-path-2.9.0 json-path-2.8.0 Upgrade json-smart to fix https://www.cve.org/CVERecord?id=CVE-2023-1370;>https://www.cve.org/CVERecord?id=CVE-2023-1370 json-path-2.7.0 No release notes provided. json-path-2.6.0 No release notes provided. json-path-2.5.0 No release notes provided. Commits https://github.com/json-path/JsonPath/commit/af7e516c69df680a6584fca7180ef082eb67c96c;>af7e516 Release 2.9.0 https://github.com/json-path/JsonPath/commit/af4dfcc17a9cb69002a5abc6e88a7745aef4c43d;>af4dfcc Make PropertyPathToken public, closes https://redirect.github.com/jayway/JsonPath/issues/955;>#955 https://github.com/json-path/JsonPath/commit/49b1151b11fbb147382c9c0f1c898b1ca0d2d3ec;>49b1151 Update versions (https://redirect.github.com/jayway/JsonPath/issues/987;>#987) https://github.com/json-path/JsonPath/commit/71a09c1193726c010917f1157ecbb069ad6c3e3b;>71a09c1 Check for the existence of the next significant bracket (https://redirect.github.com/jayway/JsonPath/issues/985;>#985) https://github.com/json-path/JsonPath/commit/900ebfe58f4c9e78b209401c642320ef332ba618;>900ebfe Remove deprecated gradle usage (https://redirect.github.com/jayway/JsonPath/issues/946;>#946) https://github.com/json-path/JsonPath/commit/946274d3cb2ee51098bc0d8ba767a01da525218f;>946274d Fixed rendering error on $..book[?(@.price = $['expensive'])] in README.md... https://github.com/json-path/JsonPath/commit/425bcb18a5ffdfafcc60190c892f941ea4117fb7;>425bcb1 Bump json-smart version from 2.4.10 to 2.5.0 (https://redirect.github.com/jayway/JsonPath/issues/945;>#945) https://github.com/json-path/JsonPath/commit/2d57ab361512451fc3352816648357ffbd5c2a13;>2d57ab3 JPMS: define Automatic-Module-Name as json.path (https://redirect.github.com/jayway/JsonPath/issues/966;>#966) https://github.com/json-path/JsonPath/commit/1a57f7800b2c101b6fca218c3f04a8b6adf04122;>1a57f78 update dependencies (https://redirect.github.com/jayway/JsonPath/issues/965;>#965) https://github.com/json-path/JsonPath/commit/21de6207945dfca6b49809fa9dd08c3781b7ab9d;>21de620 Prepare next version Additional commits viewable in https://github.com/jayway/JsonPath/compare/json-path-2.4.0...json-path-2.9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: #
(rocketmq-eventbridge) branch dependabot/maven/com.jayway.jsonpath-json-path-2.9.0 created (now e427cbf)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.jayway.jsonpath-json-path-2.9.0 in repository https://gitbox.apache.org/repos/asf/rocketmq-eventbridge.git at e427cbf build(deps): bump com.jayway.jsonpath:json-path from 2.4.0 to 2.9.0 No new revisions were added by this update.
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 0f74efa1394fb45c637635a9905c51bbfbe74934 / PiteXChen <775523...@qq.com> [ISSUE #8201] Optimization of Splitting TimeRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232525062 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9232540494 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 0f74efa1394fb45c637635a9905c51bbfbe74934 / PiteXChen <775523...@qq.com> [ISSUE #8201] Optimization of Splitting TimeRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232525058 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 0f74efa1394fb45c637635a9905c51bbfbe74934 / PiteXChen <775523...@qq.com> [ISSUE #8201] Optimization of Splitting TimeRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232525048 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 0f74efa1394fb45c637635a9905c51bbfbe74934 / PiteXChen <775523...@qq.com> [ISSUE #8201] Optimization of Splitting TimeRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232525057 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 97b59a0b44324acc49a0d21ae25a922a275547db / PiteXChen <775523...@qq.com> Optimization of Splitting TimerRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232405876 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 97b59a0b44324acc49a0d21ae25a922a275547db / PiteXChen <775523...@qq.com> Optimization of Splitting TimerRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232405877 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 97b59a0b44324acc49a0d21ae25a922a275547db / PiteXChen <775523...@qq.com> Optimization of Splitting TimerRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232405871 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 97b59a0b44324acc49a0d21ae25a922a275547db / PiteXChen <775523...@qq.com> Optimization of Splitting TimerRequest Report URL: https://github.com/apache/rocketmq/actions/runs/9232405873 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RapperCL (triggered by RapperCL). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9232409013 With regards, GitHub Actions via GitBox
[PR] [#ISSUE 8021] Optimization of Splitting TimeRequest [rocketmq]
RapperCL opened a new pull request, #8202: URL: https://github.com/apache/rocketmq/pull/8202 ### Which Issue(s) This PR Fixes Fixes [8201](https://github.com/apache/rocketmq/issues/8201) ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Optimization of Splitting TimeRequest [rocketmq]
RapperCL opened a new issue, #8201: URL: https://github.com/apache/rocketmq/issues/8201 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary path: org.apache.rocketmq.store.timer.TimerMessageStore#splitIntoLists  The splitting strategy mainly considers the dimension of commitLog and ensures that the maximum number of messages does not exceed 2000, but the above implementation is somewhat messy. Optimize: Considering the emptiness, simplifying the logic by splitting it apart ### Motivation 1. By considering scenarios where data is empty, we can reduce ineffective executions. 2. By simplifying the current splitting logic, we can improve readability and maintainability. ### Describe the Solution You'd Like Considering the emptiness, simplifying the logic by splitting it apart ### Describe Alternatives You've Considered no ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9231391570 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Multiple localaddress usage errors, and networkutil code duplication with logical errors [rocketmq]
github-actions[bot] commented on issue #6808: URL: https://github.com/apache/rocketmq/issues/6808#issuecomment-2130534548 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] DefaultLitePullConsumer send trace data failed [rocketmq]
github-actions[bot] commented on issue #6809: URL: https://github.com/apache/rocketmq/issues/6809#issuecomment-2130534527 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: 622b790dfc4e5564e6d2572e431b9114d3c91003 / weihu Optimising NetworkUtil methods Report URL: https://github.com/apache/rocketmq/actions/runs/9223089858 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8199] getLocalAddress Performance Optimisation [rocketmq]
codecov-commenter commented on PR #8200: URL: https://github.com/apache/rocketmq/pull/8200#issuecomment-2129324983 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8200?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `16.7%` with `10 lines` in your changes are missing coverage. Please review. > Project coverage is 42.89%. Comparing base [(`1b42515`)](https://app.codecov.io/gh/apache/rocketmq/commit/1b42515093fb56a2cabfa754564397e343a357be?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`622b790`)](https://app.codecov.io/gh/apache/rocketmq/pull/8200?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 4 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8200?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../org/apache/rocketmq/common/utils/NetworkUtil.java](https://app.codecov.io/gh/apache/rocketmq/pull/8200?src=pr=tree=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fcommon%2Futils%2FNetworkUtil.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvTmV0d29ya1V0aWwuamF2YQ==) | 16.66% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8200 +/- ## = - Coverage 42.90% 42.89% -0.01% + Complexity 1037010367 -3 = Files 1270 1270 Lines 8872188727 +6 Branches 1140511406 +1 = - Hits 3806238057 -5 - Misses 4595445960 +6 - Partials4705 4710 +5 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8200?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9223121344 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: 622b790dfc4e5564e6d2572e431b9114d3c91003 / weihu Optimising NetworkUtil methods Report URL: https://github.com/apache/rocketmq/actions/runs/9223089860 With regards, GitHub Actions via GitBox
(rocketmq-eventbridge) 01/03: [runtime-on-k8s] runtime-on-k8s
This is an automated email from the ASF dual-hosted git repository.
shenlin pushed a commit to branch feat/runtime-manager
in repository https://gitbox.apache.org/repos/asf/rocketmq-eventbridge.git
commit 52f82faf2b1a9efd1e79db6d010737a67bf857a5
Author: wangkai
AuthorDate: Sun May 12 19:40:14 2024 +0800
[runtime-on-k8s] runtime-on-k8s
---
adapter/pom.xml| 1 +
.../repository/WorkerInstanceRepository.java | 10 +-
.../runtime/manager/worker/WorkerResource.java | 4 +-
.../runtime/manager/worker/WorkerStatusEnum.java | 2 +
adapter/runtime-on-k8s/pom.xml | 24 +-
.../manager/k8s/api/BaseK8SApiService.java}| 31 +-
.../manager/k8s/api/K8SConfigMapService.java | 76 +++--
.../manager/k8s/api/K8SCustomResourceService.java | 78 -
.../manager/k8s/api/K8SDeploymentService.java | 144
.../manager/k8s/api/K8SNameSpaceService.java | 17 +
.../runtime/manager/k8s/api/KubectlService.java| 114 ++-
.../runtime/manager/k8s/common/K8SConstants.java | 20 ++
.../manager/k8s/common/WorkerStatusEnum.java | 47 ---
.../manager/k8s/config/DeploySpecTemplateSpec.java | 31 ++
.../runtime/manager/k8s/config/SpecContainer.java | 54 +++
.../k8s/model/K8SCRDConnectTaskSetModel.java | 17 +
.../repository/WorkerInstanceRepositoryOnK8S.java | 361 -
.../WorkerInstanceRepositoryOnK8STest.java | 133 +---
.../src/test/resources/application.properties | 16 +
.../rocketmq/eventbridge/tools/JsonUtil.java | 34 +-
pom.xml| 2 +-
21 files changed, 985 insertions(+), 231 deletions(-)
diff --git a/adapter/pom.xml b/adapter/pom.xml
index 010492c..5afe442 100644
--- a/adapter/pom.xml
+++ b/adapter/pom.xml
@@ -29,6 +29,7 @@
storage
benchmark
runtime-manager
+runtime-on-k8s
\ No newline at end of file
diff --git
a/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/repository/WorkerInstanceRepository.java
b/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/repository/WorkerInstanceRepository.java
index 1c74a3b..c25f5c9 100644
---
a/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/repository/WorkerInstanceRepository.java
+++
b/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/repository/WorkerInstanceRepository.java
@@ -38,17 +38,19 @@ public interface WorkerInstanceRepository {
* Delete the worker
*
* @param name
+ * @param environments
* @return
*/
-boolean deleteWorkerInstance(String name);
+boolean deleteWorkerInstance(String name, Map
environments);
/**
* Get the status of worker
*
* @param name
+ * @param environments
* @return
*/
-WorkerStatusEnum getWorkerInstanceStatus(String name);
+WorkerStatusEnum getWorkerInstanceStatus(String name, Map
environments);
/**
* Apply(Create/Update) the config to the worker instance. It may contains
more than one config in worker instance.
@@ -58,7 +60,7 @@ public interface WorkerInstanceRepository {
* @param config
* @return
*/
-boolean applyWorkerInstanceConfigFile(String name, String filePath, String
config);
+boolean applyWorkerInstanceConfigFile(String name, String filePath, String
config, Map environments);
/**
* Get the config to the worker instance.
@@ -67,5 +69,5 @@ public interface WorkerInstanceRepository {
* @param filePath
* @return
*/
-boolean getWorkerInstanceConfigFile(String name, String filePath);
+String getWorkerInstanceConfigFile(String name, String filePath,
Map environments);
}
\ No newline at end of file
diff --git
a/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/worker/WorkerResource.java
b/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/worker/WorkerResource.java
index 4d48fbf..e2152c4 100644
---
a/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/worker/WorkerResource.java
+++
b/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/worker/WorkerResource.java
@@ -21,6 +21,6 @@ import lombok.Data;
@Data
public class WorkerResource {
-Double cpu;
-Double memory;
+Long cpu;
+Long memory;
}
\ No newline at end of file
diff --git
a/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/worker/WorkerStatusEnum.java
b/adapter/runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/worker/WorkerStatusEnum.java
index 1cc34aa..b483922 100644
---
(rocketmq-eventbridge) branch feat/runtime-manager updated (d7df5cd -> 85b3ea9)
This is an automated email from the ASF dual-hosted git repository.
shenlin pushed a change to branch feat/runtime-manager
in repository https://gitbox.apache.org/repos/asf/rocketmq-eventbridge.git
from d7df5cd feat:add WorkerInstanceRepositoryOnK8STest test case.
new 52f82fa [runtime-on-k8s] runtime-on-k8s
new 8d72ad2 [runtime-on-k8s] runtime-on-k8s
new 85b3ea9 [runtime-on-k8s] runtime-on-k8s
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
adapter/pom.xml| 1 +
.../repository/WorkerInstanceRepository.java | 10 +-
.../runtime/manager/worker/WorkerResource.java | 4 +-
.../runtime/manager/worker/WorkerStatusEnum.java | 2 +
adapter/runtime-on-k8s/pom.xml | 24 +-
.../manager/k8s/api/BaseK8SApiService.java}| 26 +-
.../manager/k8s/api/K8SConfigMapService.java | 76 +++--
.../manager/k8s/api/K8SCustomResourceService.java | 78 -
.../manager/k8s/api/K8SDeploymentService.java | 144
.../manager/k8s/api/K8SNameSpaceService.java | 17 +
.../runtime/manager/k8s/api/KubectlService.java| 114 ++-
.../runtime/manager/k8s/common/K8SConstants.java | 20 ++
.../manager/k8s/common/WorkerStatusEnum.java | 47 ---
.../k8s/config/DeploySpecTemplateSpec.java}| 50 +--
.../runtime/manager/k8s/config/SpecContainer.java | 54 +++
.../k8s/model/K8SCRDConnectTaskSetModel.java | 17 +
.../repository/WorkerInstanceRepositoryOnK8S.java | 361 -
.../WorkerInstanceRepositoryOnK8STest.java | 134 +---
.../src/test/resources/application.properties | 5 +-
.../rocketmq/eventbridge/tools/JsonUtil.java | 34 +-
pom.xml| 2 +-
rocketmq_eventbridge.mv.db | Bin 77824 -> 0 bytes
rocketmq_eventbridge.trace.db | 94 --
23 files changed, 963 insertions(+), 351 deletions(-)
copy
adapter/{runtime-manager/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/dispatch/WorkerRebalance.java
=>
runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/api/BaseK8SApiService.java}
(59%)
delete mode 100644
adapter/runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/common/WorkerStatusEnum.java
copy
adapter/{persistence/src/main/java/org/apache/rocketmq/eventbridge/adapter/persistence/FlywayConfig.java
=>
runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/config/DeploySpecTemplateSpec.java}
(57%)
create mode 100644
adapter/runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/config/SpecContainer.java
copy
infrastructure/src/main/resources/META-INF/services/org.apache.rocketmq.eventbridge.infrastructure.validate.AuthValidation
=> adapter/runtime-on-k8s/src/test/resources/application.properties (90%)
delete mode 100644 rocketmq_eventbridge.mv.db
delete mode 100644 rocketmq_eventbridge.trace.db
(rocketmq-eventbridge) 02/03: [runtime-on-k8s] runtime-on-k8s
This is an automated email from the ASF dual-hosted git repository.
shenlin pushed a commit to branch feat/runtime-manager
in repository https://gitbox.apache.org/repos/asf/rocketmq-eventbridge.git
commit 8d72ad2743e4be8eee4812e50d00548626f9bce3
Author: wangkai
AuthorDate: Mon May 13 10:34:08 2024 +0800
[runtime-on-k8s] runtime-on-k8s
---
.../manager/k8s/config/DeploySpecTemplateSpec.java | 16
.../repository/WorkerInstanceRepositoryOnK8STest.java| 1 +
2 files changed, 17 insertions(+)
diff --git
a/adapter/runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/config/DeploySpecTemplateSpec.java
b/adapter/runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/config/DeploySpecTemplateSpec.java
index fcdc670..50b1431 100644
---
a/adapter/runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/config/DeploySpecTemplateSpec.java
+++
b/adapter/runtime-on-k8s/src/main/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/config/DeploySpecTemplateSpec.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.rocketmq.eventbridge.adapter.runtime.manager.k8s.config;
import lombok.Getter;
diff --git
a/adapter/runtime-on-k8s/src/test/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/repository/WorkerInstanceRepositoryOnK8STest.java
b/adapter/runtime-on-k8s/src/test/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/repository/WorkerInstanceRepositoryOnK8STest.java
index 1c539e2..2259c72 100644
---
a/adapter/runtime-on-k8s/src/test/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/repository/WorkerInstanceRepositoryOnK8STest.java
+++
b/adapter/runtime-on-k8s/src/test/java/org/apache/rocketmq/eventbridge/adapter/runtime/manager/k8s/repository/WorkerInstanceRepositoryOnK8STest.java
@@ -41,6 +41,7 @@ import static org.junit.Assert.assertEquals;
@RunWith(SpringRunner.class)
@SpringBootTest(classes = WorkerInstanceRepositoryOnK8STest.class)
@SpringBootApplication(scanBasePackages =
{"org.apache.rocketmq.eventbridge.adapter.runtime.manager.k8s.*"})
+@Ignore
public class WorkerInstanceRepositoryOnK8STest {
@Autowired
(rocketmq-eventbridge) 03/03: [runtime-on-k8s] runtime-on-k8s
This is an automated email from the ASF dual-hosted git repository.
shenlin pushed a commit to branch feat/runtime-manager
in repository https://gitbox.apache.org/repos/asf/rocketmq-eventbridge.git
commit 85b3ea96f1379ff7d7a7818029ad56478059ab16
Author: wangkai
AuthorDate: Mon May 13 10:42:05 2024 +0800
[runtime-on-k8s] runtime-on-k8s
---
rocketmq_eventbridge.mv.db| Bin 77824 -> 0 bytes
rocketmq_eventbridge.trace.db | 94 --
2 files changed, 94 deletions(-)
diff --git a/rocketmq_eventbridge.mv.db b/rocketmq_eventbridge.mv.db
deleted file mode 100644
index 2e5c25d..000
Binary files a/rocketmq_eventbridge.mv.db and /dev/null differ
diff --git a/rocketmq_eventbridge.trace.db b/rocketmq_eventbridge.trace.db
deleted file mode 100644
index bcce0ee..000
--- a/rocketmq_eventbridge.trace.db
+++ /dev/null
@@ -1,94 +0,0 @@
-2023-11-26 18:41:02 jdbc[3]: exception
-org.h2.jdbc.JdbcSQLException: Table "EVENT_TARGET_RUNNER" not found; SQL
statement:
-SELECT
-
-account_id,bus,rule,target,run_context,gmt_create,gmt_modify
-
-FROM
-
-event_target_runner
-
-WHERE
-id>=0 [42102-197]
-2023-11-26 18:42:05 jdbc[8]: exception
-org.h2.jdbc.JdbcSQLException: Cannot parse "TIMESTAMP" constant ; SQL
statement:
-INSERT INTO
"PUBLIC"."EVENT_CLUSTER"("ID","NAME","RESOURCES","REPLICA","IMAGE","MD5","GMT_CREATE","GMT_MODIFY")VALUES(?,?,?,?,?,?,?,?)
-- (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8) [22007-197]
- at org.h2.message.DbException.getJdbcSQLException(DbException.java:357)
- at org.h2.message.DbException.get(DbException.java:168)
- at org.h2.value.ValueTimestamp.parse(ValueTimestamp.java:147)
- at org.h2.value.Value.convertTo(Value.java:1071)
- at org.h2.table.Column.convert(Column.java:177)
- at org.h2.command.dml.Insert.insertRows(Insert.java:166)
- at org.h2.command.dml.Insert.update(Insert.java:134)
- at org.h2.command.CommandContainer.update(CommandContainer.java:102)
- at org.h2.command.Command.executeUpdate(Command.java:261)
- at
org.h2.jdbc.JdbcPreparedStatement.executeUpdateInternal(JdbcPreparedStatement.java:199)
- at
org.h2.jdbc.JdbcPreparedStatement.executeUpdate(JdbcPreparedStatement.java:153)
- at org.h2.result.UpdatableRow.insertRow(UpdatableRow.java:321)
- at org.h2.jdbc.JdbcResultSet.insertRow(JdbcResultSet.java:2994)
- at org.h2.server.web.WebApp.editResult(WebApp.java:1082)
- at org.h2.server.web.WebApp.process(WebApp.java:227)
- at org.h2.server.web.WebApp.processRequest(WebApp.java:170)
- at org.h2.server.web.WebThread.process(WebThread.java:134)
- at org.h2.server.web.WebThread.run(WebThread.java:90)
- at java.lang.Thread.run(Thread.java:748)
-Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
range: 0
- at java.lang.String.charAt(String.java:658)
- at org.h2.util.DateTimeUtils.parseDateValue(DateTimeUtils.java:337)
- at org.h2.util.DateTimeUtils.parseTimestamp(DateTimeUtils.java:460)
- at org.h2.value.ValueTimestamp.parse(ValueTimestamp.java:145)
- ... 16 more
-2023-11-26 18:42:05 jdbc[8]: exception
-org.h2.jdbc.JdbcSQLException: Cannot parse "TIMESTAMP" constant ; SQL
statement:
-INSERT INTO
"PUBLIC"."EVENT_CLUSTER"("ID","NAME","RESOURCES","REPLICA","IMAGE","MD5","GMT_CREATE","GMT_MODIFY")VALUES(?,?,?,?,?,?,?,?)
-- (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8) [22007-197]
- at org.h2.message.DbException.getJdbcSQLException(DbException.java:357)
- at org.h2.message.DbException.get(DbException.java:168)
- at org.h2.value.ValueTimestamp.parse(ValueTimestamp.java:147)
- at org.h2.value.Value.convertTo(Value.java:1071)
- at org.h2.table.Column.convert(Column.java:177)
- at org.h2.command.dml.Insert.insertRows(Insert.java:166)
- at org.h2.command.dml.Insert.update(Insert.java:134)
- at org.h2.command.CommandContainer.update(CommandContainer.java:102)
- at org.h2.command.Command.executeUpdate(Command.java:261)
- at
org.h2.jdbc.JdbcPreparedStatement.executeUpdateInternal(JdbcPreparedStatement.java:199)
- at
org.h2.jdbc.JdbcPreparedStatement.executeUpdate(JdbcPreparedStatement.java:153)
- at org.h2.result.UpdatableRow.insertRow(UpdatableRow.java:321)
- at org.h2.jdbc.JdbcResultSet.insertRow(JdbcResultSet.java:2994)
- at org.h2.server.web.WebApp.editResult(WebApp.java:1082)
- at org.h2.server.web.WebApp.process(WebApp.java:227)
- at org.h2.server.web.WebApp.processRequest(WebApp.java:170)
- at org.h2.server.web.WebThread.process(WebThread.java:134)
- at org.h2.server.web.WebThread.run(WebThread.java:90)
- at java.lang.Thread.run(Thread.java:748)
-Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
range: 0
- at java.lang.String.charAt(String.java:658)
- at
Re: [PR] [runtime-on-k8s] runtime-on-k8s [rocketmq-eventbridge]
2011shenlin merged PR #173: URL: https://github.com/apache/rocketmq-eventbridge/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] getLocalAddress Performance Optimisation [rocketmq]
weihubeats opened a new issue, #8199: URL: https://github.com/apache/rocketmq/issues/8199 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary 1. `startsWith` is very performance intensive 2. We don't need to use ArrayList for data storage 3. `isLoopbackAddress` has already judged the 127 loopback address judgement 4. The check for private addresses does not cover all private IP ranges, such as [10.0.0.0/8]and [172.16.0.0/12] ### Motivation performance optimisation ### Describe the Solution You'd Like performance optimisation ### Describe Alternatives You've Considered no ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: d1eb4d61e55db5ab747ebb1d3a6c5300e5a559a1 / lizhimins <707364...@qq.com> [ISSUE #8197] Support fast filter message in tiered storage Report URL: https://github.com/apache/rocketmq/actions/runs/9221633934 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: f93fdd518170554ea76c69a699735438b1bd259a / lizhimins <707364...@qq.com> [ISSUE #8197] Support fast filter message by tag in tiered storage Report URL: https://github.com/apache/rocketmq/actions/runs/9221586935 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 2918bf74f6e34d3e3f2f1fca8f7d4ee6f016b60a / lizhimins <707364...@qq.com> [ISSUE #8197] Support fast filter message in tiered storage Report URL: https://github.com/apache/rocketmq/actions/runs/9221596340 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221425152 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 873375237ef3e306f24b37e43f2cfb7ac4d0056e / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9221204272 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221665245 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221629963 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221639619 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221425149 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: d1eb4d61e55db5ab747ebb1d3a6c5300e5a559a1 / lizhimins <707364...@qq.com> [ISSUE #8197] Support fast filter message in tiered storage Report URL: https://github.com/apache/rocketmq/actions/runs/9221633925 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221425158 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 2918bf74f6e34d3e3f2f1fca8f7d4ee6f016b60a / lizhimins <707364...@qq.com> [ISSUE #8197] Support fast filter message in tiered storage Report URL: https://github.com/apache/rocketmq/actions/runs/9221596337 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8197] Support fast filter message by tag in tiered storage [rocketmq]
lizhimins opened a new pull request, #8198: URL: https://github.com/apache/rocketmq/pull/8198 ### Which Issue(s) This PR Fixes Fixes #8197 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 9c8fdb715f774440009b85da2edbd2ab0278831d / Humkum <1109939...@qq.com> [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169) Report URL: https://github.com/apache/rocketmq/actions/runs/9221425146 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #8168] fix: There's no need to retry when async produce already timeout (#8169)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 9c8fdb715f [ISSUE #8168] fix: There's no need to retry when async
produce already timeout (#8169)
9c8fdb715f is described below
commit 9c8fdb715f774440009b85da2edbd2ab0278831d
Author: Humkum <1109939...@qq.com>
AuthorDate: Fri May 24 17:01:41 2024 +0800
[ISSUE #8168] fix: There's no need to retry when async produce already
timeout (#8169)
---
.../main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
index 9b15279cb6..816ae877ac 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
@@ -704,9 +704,10 @@ public class MQClientAPIImpl implements
NameServerUpdateCallback {
onExceptionImpl(brokerName, msg, timeoutMillis - cost,
request, sendCallback, topicPublishInfo, instance,
retryTimesWhenSendFailed, times, ex, context,
true, producer);
} else {
-MQClientException ex = new MQClientException("unknow
reseaon", throwable);
+MQClientException ex = new MQClientException("unknown
reason", throwable);
+boolean needRetry = !(throwable instanceof
RemotingTooMuchRequestException);
onExceptionImpl(brokerName, msg, timeoutMillis - cost,
request, sendCallback, topicPublishInfo, instance,
-retryTimesWhenSendFailed, times, ex, context,
true, producer);
+retryTimesWhenSendFailed, times, ex, context,
needRetry, producer);
}
}
});
Re: [I] [Bug] Produce async no need retry when the request is already timeout. [rocketmq]
lizhimins closed issue #8168: [Bug] Produce async no need retry when the request is already timeout. URL: https://github.com/apache/rocketmq/issues/8168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8168] fix: There's no need to retry when async produce already timeout [rocketmq]
lizhimins merged PR #8169: URL: https://github.com/apache/rocketmq/pull/8169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 873375237ef3e306f24b37e43f2cfb7ac4d0056e / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9221204267 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: bdc7c0ab6cb296c736c2f322b840c6da9613d10e / weihubeats [ISSUE #6873] If dns resolve controller address exception will update controllerAddresses to null (#8180) * Adding null does not update * rolling back * dns resolution failure not updating controllerAddresses Report URL: https://github.com/apache/rocketmq/actions/runs/9221240167 With regards, GitHub Actions via GitBox
[I] [Enhancement] Support fast filter message by tag in tiered storage [rocketmq]
lizhimins opened a new issue, #8197: URL: https://github.com/apache/rocketmq/issues/8197 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary In the tiered storage module, server-side message filtering is supported. There are three opportunities for filtering, which are: 1. When the consume queue (cq) is retrieved but the CommitLog has not been fetched. 2. When fetching data from the cache, similar to local storage, prefetch some data backwards. 3. After fetching data, perform filtering post-retrieval. Unlike the characteristics of local storage, if filtering is done in stage 1, it will result in fragmented IO for data retrieval, which is too inefficient. The current filtering logic is executed in stage 3. However, if the consumer's request contains a large number of tags that do not match, it leads to excessive interactions between the client and server. Therefore, moving the filtering logic to stage 2 can effectively increase the consumption speed of a single queue and reduce the number of RPCs between the client and server. 在分级存储模块中，支持服务端消息过滤。有三个时机可以进行过滤，分别是： 1. 取回 cq 但没有取回 CommitLog 时。 2. 从缓存中取回数据时，和本地存储一样向后预取一些数据。 3. 取回数据后，后置进行过滤。 和本地存储的特性不同，如果在阶段1进行过滤，会导致取回数据的IO是碎片化的，性能太低。当前的过滤逻辑在3执行，假如消费者的请求有大量的 tag 不匹配，导致客户端和服务端的交互次数过多，因此将过滤的逻辑提前到阶段 2 执行，可以有效提升单队列的消费速度，并减少客户端与服务端的 rpc 次数。 ### Motivation Speedup consume in tiered storage ### Describe the Solution You'd Like Moving the filtering logic to stage 2 can effectively increase the consumption speed of a single queue and reduce the number of RPCs between the client and server. ### Describe Alternatives You've Considered Moving the filtering logic to stage 2 can effectively increase the consumption speed of a single queue and reduce the number of RPCs between the client and server. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 不支持5.1版本吧 [rocketmq-exporter]
iamqq23ue commented on issue #164: URL: https://github.com/apache/rocketmq-exporter/issues/164#issuecomment-2129000650 > @iamqq23ue 你编译没有报错吗 编译最新的代码，需要的指标都有了。版本号还是0.0.2但是代码改了。编译报错跳过测试即可，我降了surfire的版本 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 23a3b8a143b20b8b4d6cbe0b76839a6324ede138 / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9220541539 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 873375237ef3e306f24b37e43f2cfb7ac4d0056e / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9221204262 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]
lollipopjin commented on code in PR #8116:
URL: https://github.com/apache/rocketmq/pull/8116#discussion_r1613034293
##
broker/src/main/java/org/apache/rocketmq/broker/subscription/RocksDBSubscriptionGroupManager.java:
##
@@ -16,39 +16,116 @@
*/
package org.apache.rocketmq.broker.subscription;
-import java.io.File;
-
+import com.alibaba.fastjson.JSON;
+import com.alibaba.fastjson.JSONObject;
+import com.alibaba.fastjson.serializer.SerializerFeature;
import org.apache.rocketmq.broker.BrokerController;
-import org.apache.rocketmq.common.config.RocksDBConfigManager;
+import org.apache.rocketmq.broker.RocksDBConfigManager;
+import org.apache.rocketmq.common.UtilAll;
import org.apache.rocketmq.common.utils.DataConverter;
+import org.apache.rocketmq.remoting.protocol.DataVersion;
import
org.apache.rocketmq.remoting.protocol.subscription.SubscriptionGroupConfig;
+import org.rocksdb.RocksIterator;
-import com.alibaba.fastjson.JSON;
-import com.alibaba.fastjson.serializer.SerializerFeature;
+import java.io.File;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.function.BiConsumer;
public class RocksDBSubscriptionGroupManager extends SubscriptionGroupManager {
+protected RocksDBConfigManager rocksDBConfigManager;
+
public RocksDBSubscriptionGroupManager(BrokerController brokerController) {
super(brokerController, false);
-this.rocksDBConfigManager = new
RocksDBConfigManager(brokerController.getMessageStoreConfig().getMemTableFlushIntervalMs());
+this.rocksDBConfigManager = new
RocksDBConfigManager(rocksdbConfigFilePath(),
brokerController.getMessageStoreConfig().getMemTableFlushIntervalMs());
}
@Override
public boolean load() {
-if (!this.rocksDBConfigManager.load(configFilePath(), this::decode0)) {
+if (!rocksDBConfigManager.init()) {
+return false;
+}
+if (!loadDataVersion() || !loadSubscriptionGroupAndForbidden()) {
return false;
}
this.init();
return true;
}
+public boolean loadDataVersion() {
+return this.rocksDBConfigManager.loadDataVersion();
+}
+
+public boolean loadForbidden(BiConsumer biConsumer) {
+try (RocksIterator iterator =
this.rocksDBConfigManager.configRocksDBStorage.forbiddenIterator()) {
+iterator.seekToFirst();
+while (iterator.isValid()) {
+biConsumer.accept(iterator.key(), iterator.value());
+iterator.next();
+}
+}
+return true;
+}
+
+public boolean loadSubscriptionGroupAndForbidden() {
Review Comment:
If you want to do as a pipeline case here , use if-else may be a more
readable way.
##
broker/src/main/java/org/apache/rocketmq/broker/RocksDBConfigManager.java:
##
@@ -14,46 +14,66 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.rocketmq.common.config;
+package org.apache.rocketmq.broker;
+import com.alibaba.fastjson.JSON;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.rocketmq.common.config.ConfigRocksDBStorage;
import org.apache.rocketmq.common.constant.LoggerName;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
+import org.apache.rocketmq.remoting.protocol.DataVersion;
import org.rocksdb.FlushOptions;
import org.rocksdb.RocksIterator;
import org.rocksdb.Statistics;
import org.rocksdb.WriteBatch;
+import java.nio.charset.StandardCharsets;
import java.util.function.BiConsumer;
public class RocksDBConfigManager {
protected static final Logger BROKER_LOG =
LoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME);
-
-protected volatile boolean isStop = false;
-protected ConfigRocksDBStorage configRocksDBStorage = null;
+public volatile boolean isStop = false;
+public ConfigRocksDBStorage configRocksDBStorage = null;
private FlushOptions flushOptions = null;
private volatile long lastFlushMemTableMicroSecond = 0;
+
+private final String filePath;
private final long memTableFlushInterval;
+private DataVersion kvDataVersion = new DataVersion();
+
-public RocksDBConfigManager(long memTableFlushInterval) {
+public RocksDBConfigManager(String filePath, long memTableFlushInterval) {
+this.filePath = filePath;
this.memTableFlushInterval = memTableFlushInterval;
}
-public boolean load(String configFilePath, BiConsumer
biConsumer) {
+public boolean init() {
this.isStop = false;
-this.configRocksDBStorage = new ConfigRocksDBStorage(configFilePath);
-if (!this.configRocksDBStorage.start()) {
-return false;
-}
-RocksIterator iterator =
[I] rocketmclient ：报错event executor terminated [rocketmq]
onejimmyboy opened a new issue, #8196: URL: https://github.com/apache/rocketmq/issues/8196 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos ### RocketMQ version broker：5.1.3 client：4.9.3 ### JDK Version 1.8 ### Describe the Bug [2017-01-15 18:10:41,255]-[nio-worker-3-5] WARN io.netty.channel.AbstractChannelHandlerContext - Failed to submit an exceptionCaught() event. java.util.concurrent.RejectedExecutionException: event executor terminated at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:836) at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:342) at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:335) at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:761) at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:278) at io.netty.channel.AbstractChannelHandlerContext.fireExceptionCaught(AbstractChannelHandlerContext.java:267) at io.netty.channel.ChannelInboundHandlerAdapter.exceptionCaught(ChannelInboundHandlerAdapter.java:131) at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:296) at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:275) at io.netty.channel.AbstractChannelHandlerContext.fireExceptionCaught(AbstractChannelHandlerContext.java:267) at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireExceptionCaught(CombinedChannelDuplexHandler.java:423) at io.netty.channel.ChannelHandlerAdapter.exceptionCaught(ChannelHandlerAdapter.java:78) at io.netty.channel.CombinedChannelDuplexHandler$1.fireExceptionCaught(CombinedChannelDuplexHandler.java:144) at io.netty.channel.ChannelInboundHandlerAdapter.exceptionCaught(ChannelInboundHandlerAdapter.java:131) at io.netty.channel.CombinedChannelDuplexHandler.exceptionCaught(CombinedChannelDuplexHandler.java:230) at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:296) at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:275) at io.netty.channel.AbstractChannelHandlerContext.fireExceptionCaught(AbstractChannelHandlerContext.java:267) at io.netty.channel.DefaultChannelPipeline$HeadContext.exceptionCaught(DefaultChannelPipeline.java:1301) at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:296) at io.netty.channel.AbstractChannelHandlerContext.notifyHandlerException(AbstractChannelHandlerContext.java:861) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelUnregistered(AbstractChannelHandlerContext.java:193) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelUnregistered(AbstractChannelHandlerContext.java:177) at io.netty.channel.DefaultChannelPipeline.fireChannelUnregistered(DefaultChannelPipeline.java:826) at io.netty.channel.AbstractChannel$AbstractUnsafe$7.run(AbstractChannel.java:752) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasksFrom(SingleThreadEventExecutor.java:394) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:369) at io.netty.util.concurrent.SingleThreadEventExecutor.confirmShutdown(SingleThreadEventExecutor.java:693) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:464) at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:873) at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) at java.lang.Thread.run(Thread.java:745) ### Steps to Reproduce 客户端在消费消息的时候 ### What Did You Expect to See? 消费正常 ### What Did You See Instead? 消费失败，客户端打印上面的错误日志 ### Additional Context 消费失败，客户端打印上面的错误日志 -- This is an automated message from the
[I] [Bug] brokcerIP1和brokerIP2在5.X版本中不能使用host替代 [rocketmq]
witt-bit opened a new issue, #8195: URL: https://github.com/apache/rocketmq/issues/8195 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Ubuntu 20.04.6 ### RocketMQ version 5.1.3 ### JDK Version open jdk 1.8.0_372 ### Describe the Bug 我项目所在的环境，网络是隔离的，有三台机器 1.A机器部署java客户端程序，在公网环境下。 2.B机器部署RocketMq Server与C在同一网络环境下，与A通过公网互通，与C通过内网互通。 3.C机器部署Java客户端程序，部署在内网环境，不能访问公网，且与A不互通。 我在B机器上启动RocketMq的Server时，配置了conf文件中`brokcerIP1`的值为`rocketmq-001`，这是一个`/etc/hosts`的hosts配置，我们期望RocketMQ Server在与客户端的通信中使用`hosts`作为地址，在A机器山嗯，会被`/etc/hosts`映射为公网地址与其通信，在C机器上，映射为内网地址与其通信 以上策略在4.X的服务端和客户端中，都是可以正常使用的，但在5.X上，RocketMQ Server在返回时，被替换为了本机的host地址，导致A和C机器不能与Server通信 ### Steps to Reproduce 配置`brokcerIP1`为一个hosts地址 ### What Did You Expect to See? 在5.x客户端，RocketMQ将brokcerIP1交给客户端来解析 ### What Did You See Instead? ```java 2024-05-24 15:45:53.185 ERROR [rm_PRODUCTION_5] [N/A] RocketmqClient#error:190 : sendMessageBack Exception, XXX org.apache.rocketmq.remoting.exception.RemotingConnectException: connect to 10.6.69.195:10911 failed at org.apache.rocketmq.remoting.netty.NettyRemotingClient.invokeSync(NettyRemotingClient.java:473) at org.apache.rocketmq.client.impl.MQClientAPIImpl.consumerSendMessageBack(MQClientAPIImpl.java:1470) at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.sendMessageBack(DefaultMQPushConsumerImpl.java:735) at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.sendMessageBack(DefaultMQPushConsumerImpl.java:722) at org.apache.rocketmq.client.impl.consumer.ConsumeMessageConcurrentlyService.sendMessageBack(ConsumeMessageConcurrentlyService.java:320) at org.apache.rocketmq.client.impl.consumer.ConsumeMessageConcurrentlyService.processConsumeResult(ConsumeMessageConcurrentlyService.java:287) at org.apache.rocketmq.client.impl.consumer.ConsumeMessageConcurrentlyService$ConsumeRequest.run(ConsumeMessageConcurrentlyService.java:455) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ``` `10.6.69.195`是Server的本机地址 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 23a3b8a143b20b8b4d6cbe0b76839a6324ede138 / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9220541536 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: bdc7c0ab6cb296c736c2f322b840c6da9613d10e / weihubeats [ISSUE #6873] If dns resolve controller address exception will update controllerAddresses to null (#8180) * Adding null does not update * rolling back * dns resolution failure not updating controllerAddresses Report URL: https://github.com/apache/rocketmq/actions/runs/9220567424 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 92d68cf5e59b6ed1bc927c40901e265474355b54 / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9219799038 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 23a3b8a143b20b8b4d6cbe0b76839a6324ede138 / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9220541530 With regards, GitHub Actions via GitBox
Re: [I] 一个应用只允许一个gid，但是有好几个消费类（不同业务不同的topic），导致订阅关系不一致 [rocketmq-spring]
drpmma commented on issue #653: URL: https://github.com/apache/rocketmq-spring/issues/653#issuecomment-2128790285 可以将你的代码示例贴出来吗，这样别人碰到相同的问题看到你的issue也就可以解决了； 另外，group确实不应当和应用一对一绑定，可以是一个多对一的关系，从最佳实践来看，变更订阅关系的时候也是建议新建group来启用新的订阅关系 Can you post your code example? This way, others facing the same problem can find a solution when they see your issue. Additionally, it is indeed not advisable to bind a group one-to-one with an application; it can be a many-to-one relationship. From best practices, it is recommended to create a new group when changing subscription relationships to enable the new subscriptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 不支持5.1版本吧 [rocketmq-exporter]
Kammingyeung commented on issue #164: URL: https://github.com/apache/rocketmq-exporter/issues/164#issuecomment-2128780171 @iamqq23ue 你编译没有报错吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 不支持5.1版本吧 [rocketmq-exporter]
Kammingyeung commented on issue #164: URL: https://github.com/apache/rocketmq-exporter/issues/164#issuecomment-2128780373 为什么我报错  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] 编译失败 [rocketmq-exporter]
Kammingyeung opened a new issue, #170: URL: https://github.com/apache/rocketmq-exporter/issues/170  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 92d68cf5e59b6ed1bc927c40901e265474355b54 / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9219799035 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: bdc7c0ab6cb296c736c2f322b840c6da9613d10e / weihubeats [ISSUE #6873] If dns resolve controller address exception will update controllerAddresses to null (#8180) * Adding null does not update * rolling back * dns resolution failure not updating controllerAddresses Report URL: https://github.com/apache/rocketmq/actions/runs/9219822291 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 92d68cf5e59b6ed1bc927c40901e265474355b54 / Hankunming <1109939...@qq.com> fix: message track is not correct caused by master changed Report URL: https://github.com/apache/rocketmq/actions/runs/9219799044 With regards, GitHub Actions via GitBox
[PR] fix: message track is not correct caused by master changed [rocketmq]
humkum opened a new pull request, #8194: URL: https://github.com/apache/rocketmq/pull/8194 ### Which Issue(s) This PR Fixes Fixes #8192 ### Brief Description There's no need to check if the message's store host is equal to broker's master address, because the master role maybe change to another node. ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 一个应用只允许一个gid，但是有好几个消费类（不同业务不同的topic），导致订阅关系不一致 [rocketmq-spring]
hachikozjq commented on issue #653: URL: https://github.com/apache/rocketmq-spring/issues/653#issuecomment-2128665189 > 在rocketmq中，可以通过consumer多次调用subscribe，使得一个consumer能够同时订阅多个topic；阅读了一下rocketmq-spring的代码，org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer，看起来是不支持这种做法的。 > > In RocketMQ, a consumer can subscribe to multiple topics by calling the subscribe method multiple times, allowing a single consumer to simultaneously subscribe to multiple topics. After reviewing the code of rocketmq-spring, specifically org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer, it appears that this approach is not supported. 最后使用RocketMQPushConsumerLifecycleListener实现，写在了一个消费类里，多次subscribe，gid一个应用一个是公司限制，不允许自己创建。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 一个应用只允许一个gid，但是有好几个消费类（不同业务不同的topic），导致订阅关系不一致 [rocketmq-spring]
hachikozjq closed issue #653: 一个应用只允许一个gid，但是有好几个消费类（不同业务不同的topic），导致订阅关系不一致 URL: https://github.com/apache/rocketmq-spring/issues/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user Stephanie0002 (triggered by Stephanie0002). Head commit for run: 9b29684c4b155ab8d7da86e24d20d08f3713c258 / 黄梓淇 Add tow metric createTopicTime and createSubscriptionTime in broker Report URL: https://github.com/apache/rocketmq/actions/runs/9219312623 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user Stephanie0002 (triggered by Stephanie0002). Head commit for run: 9b29684c4b155ab8d7da86e24d20d08f3713c258 / 黄梓淇 Add tow metric createTopicTime and createSubscriptionTime in broker Report URL: https://github.com/apache/rocketmq/actions/runs/9219312620 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user Stephanie0002 (triggered by Stephanie0002). Head commit for run: bdc7c0ab6cb296c736c2f322b840c6da9613d10e / weihubeats [ISSUE #6873] If dns resolve controller address exception will update controllerAddresses to null (#8180) * Adding null does not update * rolling back * dns resolution failure not updating controllerAddresses Report URL: https://github.com/apache/rocketmq/actions/runs/9219331087 With regards, GitHub Actions via GitBox
