[royale-compiler] branch develop updated: sometimes project isn't RoyaleProject
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new b30ef38 sometimes project isn't RoyaleProject
b30ef38 is described below
commit b30ef38ae49c801afc45b5a8f81be546ec46a2f4
Author: Alex Harui
AuthorDate: Tue Feb 20 21:52:33 2018 -0800
sometimes project isn't RoyaleProject
---
.../org/apache/royale/compiler/internal/tree/as/IdentifierNode.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
index f4a3689..7ba01c2 100644
---
a/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
+++
b/compiler/src/main/java/org/apache/royale/compiler/internal/tree/as/IdentifierNode.java
@@ -418,7 +418,7 @@ public class IdentifierNode extends ExpressionNodeBase
implements IIdentifierNod
}
}
-if (((RoyaleProject)project).apiReportFile != null)
+if (project instanceof RoyaleProject &&
((RoyaleProject)project).apiReportFile != null)
{
if (isMemberRef())
{
--
To stop receiving notification emails like this one, please contact
aha...@apache.org.
[royale-compiler] 01/02: in MXML, some public vars have been converted to SyntheticBindings which are not themselves Bindable so check the node metatags for binding
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
commit 5ccaa665be8fcd09a3fa111bf96a4f992f6dec6f
Author: Alex Harui
AuthorDate: Tue Feb 20 18:09:28 2018 -0800
in MXML, some public vars have been converted to SyntheticBindings which
are not themselves Bindable so check the node metatags for binding
---
.../internal/codegen/js/royale/JSRoyaleDocEmitter.java | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
index a4f8d05..362035b 100644
---
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
+++
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
@@ -51,6 +51,8 @@ import org.apache.royale.compiler.tree.as.IExpressionNode;
import org.apache.royale.compiler.tree.as.IFunctionNode;
import org.apache.royale.compiler.tree.as.IParameterNode;
import org.apache.royale.compiler.tree.as.IVariableNode;
+import org.apache.royale.compiler.tree.metadata.IMetaTagNode;
+import org.apache.royale.compiler.tree.metadata.IMetaTagsNode;
public class JSRoyaleDocEmitter extends JSGoogDocEmitter
{
@@ -427,7 +429,15 @@ public class JSRoyaleDocEmitter extends JSGoogDocEmitter
{
RoyaleJSProject fjp = (RoyaleJSProject)project;
boolean warnPublicVars = fjp.config != null &&
fjp.config.getWarnPublicVars();
-if (warnPublicVars && !node.isConst() && !def.isBindable())
+IMetaTagsNode meta = node.getMetaTags();
+boolean bindable = false;
+if (meta != null)
+{
+ IMetaTagNode tag = meta.getTagByName("Bindable");
+ if (tag != null)
+ bindable = true;
+}
+if (warnPublicVars && !node.isConst() && !(def.isBindable() ||
bindable))
{
if (!suppressedWarning(node, fjp))
fjp.getProblems().add(new
PublicVarWarningProblem(node));
--
To stop receiving notification emails like this one, please contact
aha...@apache.org.
[royale-compiler] branch develop updated (eed5882 -> 6163c0d)
This is an automated email from the ASF dual-hosted git repository. aharui pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/royale-compiler.git. from eed5882 add -warn-public-vars option to emit warning on use of public vars since they do not work well when minified and used from MXML. There is an asdoc option @royalesuppresspublicvarwarning that can be used on a declaration or entire class to suppress the warning new 5ccaa66 in MXML, some public vars have been converted to SyntheticBindings which are not themselves Bindable so check the node metatags for binding new 6163c0d first cut at api report The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../royale/compiler/config/Configuration.java | 22 ++ .../codegen/js/royale/JSRoyaleDocEmitter.java | 12 ++- .../org/apache/royale/compiler/clients/MXMLC.java | 3 +- .../compiler/internal/projects/RoyaleProject.java | 87 ++ .../compiler/internal/tree/as/IdentifierNode.java | 39 ++ 5 files changed, 161 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact aha...@apache.org.
[royale-compiler] 02/02: first cut at api report
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
commit 6163c0d4bd0b7afc78f12d4aeec18d4b6412b0ce
Author: Alex Harui
AuthorDate: Tue Feb 20 19:54:42 2018 -0800
first cut at api report
---
.../royale/compiler/config/Configuration.java | 22 ++
.../org/apache/royale/compiler/clients/MXMLC.java | 3 +-
.../compiler/internal/projects/RoyaleProject.java | 87 ++
.../compiler/internal/tree/as/IdentifierNode.java | 39 ++
4 files changed, 150 insertions(+), 1 deletion(-)
diff --git
a/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java
b/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java
index 226b7e6..8c3d8ed 100644
---
a/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java
+++
b/compiler-common/src/main/java/org/apache/royale/compiler/config/Configuration.java
@@ -500,6 +500,28 @@ public class Configuration
this.sizeReportFileName = getOutputPath(cv, filename);
}
+// 'api-report' option
+//
+
+private String apiReportFileName = null;
+
+public File getApiReport()
+{
+return apiReportFileName != null ? new File(apiReportFileName) : null;
+}
+
+/**
+ * Prints api usage information to the specified output file. This file is
an text file that contains every method and property
+ * resolved by the compiler.
+ */
+@Config(advanced = true)
+@Mapping("api-report")
+@Arguments("filename")
+public void setApiReport(ConfigurationValue cv, String filename)
+{
+this.apiReportFileName = getOutputPath(cv, filename);
+}
+
//
// 'load-externs' option
//
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/clients/MXMLC.java
b/compiler/src/main/java/org/apache/royale/compiler/clients/MXMLC.java
index a6f7353..d83792b 100644
--- a/compiler/src/main/java/org/apache/royale/compiler/clients/MXMLC.java
+++ b/compiler/src/main/java/org/apache/royale/compiler/clients/MXMLC.java
@@ -503,6 +503,7 @@ public class MXMLC implements FlexTool
// Get the configuration and configBuffer which are now
initialized.
config = projectConfigurator.getConfiguration();
Messages.setLocale(config.getToolsLocale());
+project.apiReportFile = config.getApiReport();
configBuffer = projectConfigurator.getConfigurationBuffer();
problems.addAll(projectConfigurator.getConfigurationProblems());
@@ -649,7 +650,7 @@ public class MXMLC implements FlexTool
swfOutputMessage =
Messages.getString("MXMLC.bytes_written_to_file_in_seconds_format",
params);
dumpDependencyGraphIfNeeded();
-
+project.generateAPIReport();
compilationSuccess = true;
}
catch (IOException e)
diff --git
a/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
b/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
index d4ea670..2182ecd 100644
---
a/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
+++
b/compiler/src/main/java/org/apache/royale/compiler/internal/projects/RoyaleProject.java
@@ -22,6 +22,8 @@ package org.apache.royale.compiler.internal.projects;
import static com.google.common.collect.Lists.transform;
import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
@@ -1349,7 +1351,11 @@ public class RoyaleProject extends ASProject implements
IRoyaleProject, ICompile
}
}
if (winner != null)
+{
+ if (apiReportFile != null)
+ addToAPIReport(classDefinition, winner);
return winner;
+}
}
}
@@ -1372,7 +1378,11 @@ public class RoyaleProject extends ASProject implements
IRoyaleProject, ICompile
IClassDefinition c = classIterator.next();
IEventDefinition eventDefinition =
c.getEventDefinition(getWorkspace(), eventName);
if (eventDefinition != null)
+{
+ if (apiReportFile != null)
+ addToAPIReport(classDefinition, eventDefinition);
return eventDefinition;
+}
}
return null;
@@ -1396,7 +1406,11 @@ public class RoyaleProject extends ASProject implements
IRoyaleProject, ICompile
IClassDefinition c = classIterator.next();
IStyleDefinition styleDefinition = c.getStyleDefinition(w,
styleName);
if (styleDefinition != null)
+{
+ if (apiReportFi
[royale-asjs] 01/01: Merge branch 'develop' into feature/vivid-ui-set
This is an automated email from the ASF dual-hosted git repository. piotrz pushed a commit to branch feature/vivid-ui-set in repository https://gitbox.apache.org/repos/asf/royale-asjs.git commit d9038f1e64ff257d76a64ff072d8ad5bef1de592 Merge: ecaab75 b4f67a5 Author: Piotr Zarzycki AuthorDate: Tue Feb 20 23:26:17 2018 +0100 Merge branch 'develop' into feature/vivid-ui-set .../src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact pio...@apache.org.
[royale-asjs] branch feature/vivid-ui-set updated (ecaab75 -> d9038f1)
This is an automated email from the ASF dual-hosted git repository. piotrz pushed a change to branch feature/vivid-ui-set in repository https://gitbox.apache.org/repos/asf/royale-asjs.git. from ecaab75 fresh branch with all vivid work, still not work add b4f67a5 Fix failing MDL RestrictTextField in some scenario where strand is not yet setup new d9038f1 Merge branch 'develop' into feature/vivid-ui-set The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact pio...@apache.org.
[royale-asjs] branch develop updated: Fix failing MDL RestrictTextField in some scenario where strand is not yet setup
This is an automated email from the ASF dual-hosted git repository.
piotrz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new b4f67a5 Fix failing MDL RestrictTextField in some scenario where
strand is not yet setup
b4f67a5 is described below
commit b4f67a5667ef78180a46051781ed5218dc016108
Author: Piotr Zarzycki
AuthorDate: Tue Feb 20 22:34:00 2018 +0100
Fix failing MDL RestrictTextField in some scenario where strand is not yet
setup
---
.../src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as
b/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as
index a9bd1a2..836a4ca 100644
---
a/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as
+++
b/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/beads/RestrictTextField.as
@@ -83,7 +83,10 @@ package org.apache.royale.mdl.beads
COMPILE::JS
{
var mdlTi:ITextField = _strand as ITextField;
-mdlTi.input.setAttribute('pattern', pattern);
+ if (mdlTi)
+{
+mdlTi.input.setAttribute('pattern', pattern);
+}
}
}
--
To stop receiving notification emails like this one, please contact
pio...@apache.org.
[royale-asjs] branch feature/vivid-ui-set created (now ecaab75)
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a change to branch feature/vivid-ui-set in repository https://gitbox.apache.org/repos/asf/royale-asjs.git. at ecaab75 fresh branch with all vivid work, still not work This branch includes the following new commits: new ecaab75 fresh branch with all vivid work, still not work The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. -- To stop receiving notification emails like this one, please contact carlosrov...@apache.org.
[royale-asjs] 01/01: fresh branch with all vivid work, still not work
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch feature/vivid-ui-set
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit ecaab7559a945c775b67e767c7ee197838a471bc
Author: Carlos Rovira
AuthorDate: Tue Feb 20 21:04:59 2018 +0100
fresh branch with all vivid work, still not work
---
examples/royale/VividExample/.vscode/launch.json | 21 +++
examples/royale/VividExample/.vscode/settings.json | 3 +
examples/royale/VividExample/.vscode/tasks.json| 8 +
examples/royale/VividExample/README.txt| 26
examples/royale/VividExample/asconfig.json | 31
examples/royale/VividExample/build.xml | 68
examples/royale/VividExample/pom.xml | 83 ++
.../src/main/config/compile-app-config.xml | 28
.../src/main/resources/vivid-example-styles.css| 25 +++
.../royale/VividExample/src/main/royale/App.mxml | 40 +
.../src/main/royale/ButtonPlayGround.mxml | 42 +
.../src/main/royale/TextInputPlayGround.mxml | 28
examples/royale/pom.xml| 1 +
frameworks/projects/Vivid/.vscode/launch.json | 21 +++
frameworks/projects/Vivid/.vscode/settings.json| 3 +
frameworks/projects/Vivid/.vscode/tasks.json | 8 +
frameworks/projects/Vivid/asconfig.json| 34
frameworks/projects/Vivid/build.xml| 130
.../royale => frameworks/projects/Vivid}/pom.xml | 139 ++---
.../Vivid/src/main/config/compile-swf-config.xml | 105 +
.../projects/Vivid/src/main/resources/defaults.css | 86 +++
.../Vivid/src/main/resources/vivid-as-manifest.xml | 25 +++
.../Vivid/src/main/resources/vivid-manifest.xml| 29
.../projects/Vivid/src/main/royale/VividClasses.as | 40 +
.../royale/org/apache/royale/vivid/Application.as | 70 +
.../main/royale/org/apache/royale/vivid/Slider.as | 72 +
.../royale/org/apache/royale/vivid/TextButton.as | 63
.../royale/org/apache/royale/vivid/TextField.as| 115 ++
.../apache/royale/vivid/beads/SliderThumbView.as | 121 +++
.../apache/royale/vivid/beads/SliderTrackView.as | 121 +++
.../org/apache/royale/vivid/beads/SliderView.as| 172 +
.../royale/vivid/supportClasses/ITextField.as | 68
.../royale/vivid/supportClasses/TextFieldBase.as | 154 ++
.../projects/VividBlueTheme/.vscode/launch.json| 21 +++
.../projects/VividBlueTheme/.vscode/settings.json | 3 +
.../projects/VividBlueTheme/.vscode/tasks.json | 8 +
frameworks/projects/VividBlueTheme/asconfig.json | 34
frameworks/projects/VividBlueTheme/build.xml | 133
frameworks/projects/VividBlueTheme/pom.xml | 66
.../src/main/config/compile-swf-config.xml | 91 +++
.../src/main/resources/TextField.css | 75 +
.../VividBlueTheme/src/main/resources/defaults.css | 33
.../src/main/royale/VividBlueThemeClasses.as | 33
frameworks/projects/pom.xml| 2 +
44 files changed, 2388 insertions(+), 91 deletions(-)
diff --git a/examples/royale/VividExample/.vscode/launch.json
b/examples/royale/VividExample/.vscode/launch.json
new file mode 100644
index 000..5dfb672
--- /dev/null
+++ b/examples/royale/VividExample/.vscode/launch.json
@@ -0,0 +1,21 @@
+{
+"version": "0.2.0",
+"configurations": [
+{
+"name": "Launch Chrome against debug.html, with sourcemaps",
+"type": "chrome",
+"request": "launch",
+"file":
"${workspaceRoot}/target/javascript/bin/js-debug/index.html",
+"sourceMaps": true,
+"preLaunchTask": "mvn"
+},
+{
+"name": "Launch Firefox against debug.html, with sourcemaps",
+"type": "firefox",
+"request": "launch",
+"file":
"${workspaceRoot}/target/javascript/bin/js-debug/index.html",
+"sourceMaps": true,
+"preLaunchTask": "mvn"
+}
+]
+}
diff --git a/examples/royale/VividExample/.vscode/settings.json
b/examples/royale/VividExample/.vscode/settings.json
new file mode 100644
index 000..1069e6c
--- /dev/null
+++ b/examples/royale/VividExample/.vscode/settings.json
@@ -0,0 +1,3 @@
+{
+"nextgenas.sdk.framework":
"/Users/carlosrovira/Dev/Royale/Sdks/apache-royale-0.9.1"
+}
\ No newline at end of file
diff --git a/examples/royale/VividExample/.vscode/tasks.json
b/examples/royale/VividExample/.vscode/tasks.json
new file mode 100644
index 000..5d6198d
--- /dev/null
+++ b/examples/royale/VividExample/.vscode/tasks.json
@@ -0,0 +1,8 @@
+{
+ // for the documentation about the tasks.json format
+ "version": "0.1.0",
+ "command": "mvn",
[royale-asjs] branch feature/vivid updated: add vivid example to examples pom
This is an automated email from the ASF dual-hosted git repository. carlosrovira pushed a commit to branch feature/vivid in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/feature/vivid by this push: new 67f3342 add vivid example to examples pom 67f3342 is described below commit 67f3342c2dbcb07d7ea5a96a123874028c9c6b62 Author: Carlos Rovira AuthorDate: Tue Feb 20 20:42:46 2018 +0100 add vivid example to examples pom --- examples/royale/pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/royale/pom.xml b/examples/royale/pom.xml index 441383f..d8bb624 100644 --- a/examples/royale/pom.xml +++ b/examples/royale/pom.xml @@ -71,6 +71,7 @@ DataBindingExampleWithFlexLayout DragAndDropExample AlertExample +VividExample -- To stop receiving notification emails like this one, please contact carlosrov...@apache.org.
[royale-docs] branch develop updated: Update migrate-from-flex.md
This is an automated email from the ASF dual-hosted git repository. andreww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-docs.git The following commit(s) were added to refs/heads/develop by this push: new 07a8bb7 Update migrate-from-flex.md 07a8bb7 is described below commit 07a8bb73ada025f869df746bd2cee4da45c2f757 Author: Andrew Wetmore AuthorDate: Tue Feb 20 13:55:09 2018 -0400 Update migrate-from-flex.md Added a stub on public Vars. --- create-an-application/migrate-an-existing-app/migrate-from-flex.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/create-an-application/migrate-an-existing-app/migrate-from-flex.md b/create-an-application/migrate-an-existing-app/migrate-from-flex.md index 4b2d101..bd58701 100644 --- a/create-an-application/migrate-an-existing-app/migrate-from-flex.md +++ b/create-an-application/migrate-an-existing-app/migrate-from-flex.md @@ -32,10 +32,11 @@ Where most of the changes need to happen is in the MXML files. You built your us One big change you will notice right away is that the default Royale UI components come with a basic set of functions, but not with the full range of behaviors that was loaded into every single Flex UI component whether it needed it or not. To get exactly the behavior your application needs from a data display or an input field, you may need to add "beads" to the basic Royale component. For example, to provide a field where the user can enter a password, you need to take the basic Royale [...] ## Standard runtime problems -*This section will address some issues that may arise for applications migrated from Flex.* +There are some issues that you may run into when you migrate a Flex-built application to Royale. Here are some significant ones: - **Circular dependencies** - This material will be available soon. For now, https://cwiki.apache.org/confluence/display/FLEX/Circular+Dependencies"; target="_blank">this entry on circular dependencies, written while the project was still known as FlexJS, will be useful. - **Renaming of properties** - this material will be available soon. For now, https://cwiki.apache.org/confluence/display/FLEX/Renaming+Variables"; target="_blank">this entry on compiler renaming of properties, written while the project was still known as FlexJS, will be useful. +- **Public variables** - *information on this coming soon.* ## Royale equivalents for Flex components ## Royale is not a one-for-one migration of Flex, for several reasons. A lot of Flex code presumes, and takes advantage of, features available in the Adobe AIR environment or the Flash Player plugin. Other Flex elements are more bulky than they could best be to cover a wide range of possible events and situations, so a great deal of the code in an application may be there "just in case" and never actually used. -- To stop receiving notification emails like this one, please contact andr...@apache.org.
[royale-asjs.wiki] branch master updated: Updated Public Variables (markdown)
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/royale-asjs.wiki.git The following commit(s) were added to refs/heads/master by this push: new c3e86c1 Updated Public Variables (markdown) c3e86c1 is described below commit c3e86c17a8d0fc257b11fa7d8240aff2fb85732f Author: aharui AuthorDate: Tue Feb 20 09:46:18 2018 -0800 Updated Public Variables (markdown) --- Public-Variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Public-Variables.md b/Public-Variables.md index 21c1ec7..23668b1 100644 --- a/Public-Variables.md +++ b/Public-Variables.md @@ -13,7 +13,7 @@ If an application works in js-debug but not js-release, public variables are oft We are still learning more about other scenarios that may fail in js-release due to renaming, so we may find that public variables always have to be rewritten as getter/setter. -The compiler has an option "-warn-public-vars" that is on by default. A warning message will be in the compiler output. The framework code should compile without these warnings. Either convert the var to getter/setter or suppress the warning via the @royalesuppresspublicvarwarning ASDoc directive. The directive can be used on each var or applied to an entire class. +The compiler has an option "-warn-public-vars" that is on by default. A warning message will be in the compiler output. The framework code should compile without these warnings. Either convert the var to getter/setter or suppress the warning via the @royalesuppresspublicvarwarning ASDoc directive. The directive can be used on each var or applied to an entire class. public vars with [Bindable] are exempt and should not cause the output of a warning because [Bindable] instructs the co [...] If a class is found to be at fault in js-release, check to see if @royalesuppresspublicvarwarning is used in the class and consider whether the renaming is at fault. -- To stop receiving notification emails like this one, please contact aha...@apache.org.
[royale-asjs] branch develop updated: sweep of frameworks for public var usage. Suppressed warning at project level for TLF, Text and XML
This is an automated email from the ASF dual-hosted git repository. aharui pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new 1fa0394 sweep of frameworks for public var usage. Suppressed warning at project level for TLF, Text and XML 1fa0394 is described below commit 1fa0394ea765167e9320fb7bc31d8359b57242c5 Author: Alex Harui AuthorDate: Tue Feb 20 09:17:33 2018 -0800 sweep of frameworks for public var usage. Suppressed warning at project level for TLF, Text and XML --- frameworks/js/projects/TLFJS/build.xml | 1 + frameworks/js/projects/TextJS/build.xml| 1 + frameworks/js/projects/XMLJS/build.xml | 1 + .../royale/org/apache/royale/core/Application.as | 19 - .../royale/core/ContainerBaseStrandChildren.as | 2 + .../org/apache/royale/core/HTMLElementWrapper.as | 7 ++ .../main/royale/org/apache/royale/core/UIBase.as | 4 + .../src/main/royale/org/apache/royale/core/View.as | 2 + .../main/royale/org/apache/royale/css2/Cursors.as | 4 + .../org/apache/royale/events/ItemAddedEvent.as | 2 + .../org/apache/royale/events/ItemClickedEvent.as | 2 + .../org/apache/royale/events/ItemRemovedEvent.as | 2 + .../org/apache/royale/events/ItemRendererEvent.as | 2 + .../royale/org/apache/royale/html/Container.as | 2 + .../org/apache/royale/html/DividedContainer.as | 2 + .../main/royale/org/apache/royale/html/Group.as| 2 + .../royale/org/apache/royale/html/MXMLBeadView.as | 4 + .../royale/org/apache/royale/html/RadioButton.as | 5 ++ .../apache/royale/html/beads/DisabledAlphaBead.as | 23 +- .../org/apache/royale/html/beads/ThrottleBead.as | 24 +- .../html/supportClasses/DataGridColumnList.as | 12 +++ .../html/supportClasses/GraphicsItemRenderer.as| 2 + .../royale/html/supportClasses/RadioButtonIcon.as | 5 ++ .../royale/html/supportClasses/TreeListData.as | 2 + .../html/supportClasses/UIItemRendererBase.as | 46 ++- .../org/apache/royale/svg/GraphicContainer.as | 2 + .../org/apache/royale/binding/ChainBinding.as | 26 ++- .../org/apache/royale/binding/GenericBinding.as| 2 + .../royale/binding/ItemRendererSimpleBinding.as| 35 - .../org/apache/royale/binding/PropertyWatcher.as | 2 + .../org/apache/royale/binding/SimpleBinding.as | 12 ++- .../org/apache/royale/binding/WatcherBase.as | 2 + .../org/apache/royale/collections/FlattenedList.as | 2 + .../royale/org/apache/royale/core/AllCSSStyles.as | 6 ++ .../org/apache/royale/core/AllCSSValuesImpl.as | 12 +-- .../apache/royale/core/BrowserResizeListener.as| 22 +- .../royale/org/apache/royale/core/ClassFactory.as | 2 + .../org/apache/royale/core/ElementWrapper.as | 5 ++ .../apache/royale/core/ItemRendererClassFactory.as | 6 ++ .../org/apache/royale/core/MXMLDragInitiator.as| 8 ++ .../org/apache/royale/core/SimpleCSSStyles.as | 6 ++ .../apache/royale/core/SimpleCSSStylesWithFlex.as | 6 ++ .../org/apache/royale/core/SimpleCSSValuesImpl.as | 2 + .../royale/core/SimpleLocalizedValuesImpl.as | 2 + .../org/apache/royale/core/SimpleValuesImpl.as | 2 + .../main/royale/org/apache/royale/core/Strand.as | 2 + .../org/apache/royale/core/WrappedHTMLElement.as | 10 +++ .../royale/org/apache/royale/events/CloseEvent.as | 2 + .../org/apache/royale/events/CollectionEvent.as| 2 + .../royale/org/apache/royale/events/DetailEvent.as | 2 + .../main/royale/org/apache/royale/events/Event.as | 15 .../royale/org/apache/royale/events/MouseEvent.as | 10 +++ .../org/apache/royale/events/ProgressEvent.as | 2 + .../org/apache/royale/events/ValueChangeEvent.as | 2 + .../royale/org/apache/royale/events/ValueEvent.as | 2 + .../main/royale/org/apache/royale/geom/Matrix.as | 10 +++ .../main/royale/org/apache/royale/geom/Point.as| 2 + .../royale/org/apache/royale/geom/Rectangle.as | 2 + .../src/main/royale/org/apache/royale/geom/Size.as | 2 + .../org/apache/royale/promises/vo/Handler.as | 10 +++ .../org/apache/royale/states/SetEventHandler.as| 44 ++- .../royale/org/apache/royale/states/SetProperty.as | 55 +++-- .../main/royale/org/apache/royale/utils/JXON.as| 2 + .../main/royale/org/apache/royale/utils/Timer.as | 11 +++ .../org/apache/royale/createjs/Application.as | 39 +- .../royale/org/apache/royale/createjs/Container.as | 2 + .../org/apache/royale/createjs/core/UIBase.as | 2 + .../royale/org/apache/royale/createjs/core/View.as | 2 + .../org/apache/royale/createjs/tween/Effect.as | 4 + .../org/apache/royale/createjs/tween/Tween.as | 2 + .../royale/org/apache/royale/events/DragEvent.as | 4 + .../org/apache/royale/events/DragEventBase.as | 10 +++ .../html/beads/controllers/
[royale-compiler] branch develop updated: add -warn-public-vars option to emit warning on use of public vars since they do not work well when minified and used from MXML. There is an asdoc option @roy
This is an automated email from the ASF dual-hosted git repository.
aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new eed5882 add -warn-public-vars option to emit warning on use of public
vars since they do not work well when minified and used from MXML. There is an
asdoc option @royalesuppresspublicvarwarning that can be used on a declaration
or entire class to suppress the warning
eed5882 is described below
commit eed5882ba935870a98ba4fe8cbf499e5d8344f60
Author: Alex Harui
AuthorDate: Mon Feb 19 18:32:06 2018 -0800
add -warn-public-vars option to emit warning on use of public vars since
they do not work well when minified and used from MXML. There is an asdoc
option @royalesuppresspublicvarwarning that can be used on a declaration or
entire class to suppress the warning
---
.../compiler/problems/PublicVarWarningProblem.java | 44 ++
.../apache/royale/compiler/clients/MXMLJSC.java| 1 +
.../codegen/js/royale/JSRoyaleDocEmitter.java | 42 +
.../codegen/js/royale/JSRoyaleEmitterTokens.java | 1 +
.../driver/js/goog/JSGoogCompcConfiguration.java | 19 +-
.../driver/js/goog/JSGoogConfiguration.java| 19 ++
6 files changed, 125 insertions(+), 1 deletion(-)
diff --git
a/compiler-common/src/main/java/org/apache/royale/compiler/problems/PublicVarWarningProblem.java
b/compiler-common/src/main/java/org/apache/royale/compiler/problems/PublicVarWarningProblem.java
new file mode 100644
index 000..02fddc8
--- /dev/null
+++
b/compiler-common/src/main/java/org/apache/royale/compiler/problems/PublicVarWarningProblem.java
@@ -0,0 +1,44 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.royale.compiler.problems;
+
+import org.apache.royale.compiler.common.ISourceLocation;
+import org.apache.royale.compiler.problems.annotations.DefaultSeverity;
+
+/**
+ * Public vars don't work well in JS minified output. The minifier
+ * creates a "name" reference then gives the var a new minified name.
+ * If the var is not read-only, the write to the var means the
+ * reference is obsolete. Also, MXML and States access attributes
+ * by name which also breaks the reference. Use getter/setters instead.
+ */
+@DefaultSeverity(CompilerProblemSeverity.WARNING)
+public class PublicVarWarningProblem extends CompilerProblem
+{
+public static final String DESCRIPTION =
+"public var may not work in minified JS output. Use getter/setter
instead.";
+
+public static final int warningCode = 5044;
+
+public PublicVarWarningProblem(ISourceLocation site)
+{
+super(site);
+}
+}
diff --git
a/compiler-jx/src/main/java/org/apache/royale/compiler/clients/MXMLJSC.java
b/compiler-jx/src/main/java/org/apache/royale/compiler/clients/MXMLJSC.java
index d527469..c2f38e2 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/clients/MXMLJSC.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/clients/MXMLJSC.java
@@ -445,6 +445,7 @@ public class MXMLJSC implements JSCompilerEntryPoint,
ProblemQueryProvider,
arg.startsWith("-compiler.js-define") ||
arg.startsWith("-js-output") ||
arg.startsWith("-js-load-config") ||
+ arg.startsWith("-warn-public-vars") ||
arg.startsWith("-source-map")))
list.add(arg);
}
diff --git
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
index 2dd2f74..a4f8d05 100644
---
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
+++
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleDocEmitter.java
@@ -41,8 +41,11 @@ import
org.apache.royale.compiler.internal.codegen.js.goog.
[MAVEN-BUILD] Royale-asjs - Build # 512 - Fixed
The Apache Jenkins build system has built Royale-asjs (build #512) Status: Fixed Check console output at https://builds.apache.org/job/Royale-asjs/512/ to view the results.
[royale-asjs] branch develop updated: Revert "Added .md extension to RELEASE_NOTES"
This is an automated email from the ASF dual-hosted git repository. harbs pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new aa03fac Revert "Added .md extension to RELEASE_NOTES" aa03fac is described below commit aa03fac44b84f7f07a18682cb5bf456f24b7ef05 Author: Harbs AuthorDate: Tue Feb 20 15:06:11 2018 +0200 Revert "Added .md extension to RELEASE_NOTES" This reverts commit bb5499b394cf6c9f36515c3f6883202116d49e3f. It looks like the MAVEN build does not like this name change. I think the maven build should be fixed and we should use the .md extension. --- RELEASE_NOTES.md => RELEASE_NOTES | 0 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES similarity index 100% rename from RELEASE_NOTES.md rename to RELEASE_NOTES -- To stop receiving notification emails like this one, please contact ha...@apache.org.
[MAVEN-BUILD] Royale-asjs - Build # 511 - Failure
The Apache Jenkins build system has built Royale-asjs (build #511) Status: Failure Check console output at https://builds.apache.org/job/Royale-asjs/511/ to view the results.
[MAVEN-BUILD] Royale-asjs - Build # 510 - Fixed
The Apache Jenkins build system has built Royale-asjs (build #510) Status: Fixed Check console output at https://builds.apache.org/job/Royale-asjs/510/ to view the results.
[royale-asjs] branch develop updated: Added .md extension to RELEASE_NOTES
This is an automated email from the ASF dual-hosted git repository. harbs pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new bb5499b Added .md extension to RELEASE_NOTES bb5499b is described below commit bb5499b394cf6c9f36515c3f6883202116d49e3f Author: Harbs AuthorDate: Tue Feb 20 14:55:58 2018 +0200 Added .md extension to RELEASE_NOTES It improves rendering on Github --- RELEASE_NOTES => RELEASE_NOTES.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/RELEASE_NOTES b/RELEASE_NOTES.md similarity index 100% rename from RELEASE_NOTES rename to RELEASE_NOTES.md -- To stop receiving notification emails like this one, please contact ha...@apache.org.
[royale-asjs] branch develop updated: Updated RELEASE_NOTES
This is an automated email from the ASF dual-hosted git repository. harbs pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new f09b73a Updated RELEASE_NOTES f09b73a is described below commit f09b73a2b2dcb5042c3a79d94c0d14bf6abddc4e Author: Harbs AuthorDate: Tue Feb 20 14:55:08 2018 +0200 Updated RELEASE_NOTES --- RELEASE_NOTES | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/RELEASE_NOTES b/RELEASE_NOTES index cae1361..5381d0e 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -1,7 +1,14 @@ -Apache Royale 0.9.1 +Apache Royale 0.9.2 === -Added virtual item renderer management for fixed row height vertical lists. +- Added virtual item renderer management for fixed row height vertical lists. +- Added HScrollViewport +- Added VScrollViewport +- Fixed bugs in XML parsing and converting back to strings + - https://github.com/apache/royale-asjs/issues/120 + - https://github.com/apache/royale-asjs/issues/121 + - https://github.com/apache/royale-asjs/issues/122 + - https://github.com/apache/royale-asjs/issues/123 Updates to the RELEASE_NOTES discovered after this file was packaged into the release artifacts can be found here: @@ -10,7 +17,7 @@ https://github.com/apache/royale-asjs/wiki/Release-Notes-0.9.2 Apache Royale 0.9.1 === -The ASDoc example was upgraded to look better, show events, and provide permalinks. +- The ASDoc example was upgraded to look better, show events, and provide permalinks. Updates to the RELEASE_NOTES discovered after this file was packaged into the release artifacts can be found here: -- To stop receiving notification emails like this one, please contact ha...@apache.org.
[royale-asjs] branch develop updated: Fixed #123
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 33db829 Fixed #123
33db829 is described below
commit 33db8295b8a007118087ee672b093a5c2f0abb26
Author: Harbs
AuthorDate: Tue Feb 20 14:54:29 2018 +0200
Fixed #123
---
frameworks/projects/XML/src/main/royale/XML.as | 8 ++-
manualtests/XMLTest/src/MyInitialView.mxml | 30 ++
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/frameworks/projects/XML/src/main/royale/XML.as
b/frameworks/projects/XML/src/main/royale/XML.as
index b13fada..60b95ae 100644
--- a/frameworks/projects/XML/src/main/royale/XML.as
+++ b/frameworks/projects/XML/src/main/royale/XML.as
@@ -222,7 +222,13 @@ package
var xml:XML;
var i:int;
var data:* = node.nodeValue;
- var qname:QName = getQName(node.nodeName, node.prefix,
node.namespaceURI,false);
+ var localName:String = node.nodeName;
+ var prefix:String = node.prefix;
+ if(prefix && localName.indexOf(prefix + ":") == 0)
+ {
+ localName = localName.substr(prefix.length+1);
+ }
+ var qname:QName = getQName(localName, prefix,
node.namespaceURI,false);
switch(node.nodeType)
{
case 1:
diff --git a/manualtests/XMLTest/src/MyInitialView.mxml
b/manualtests/XMLTest/src/MyInitialView.mxml
index 1e42c42..84042df 100644
--- a/manualtests/XMLTest/src/MyInitialView.mxml
+++ b/manualtests/XMLTest/src/MyInitialView.mxml
@@ -167,6 +167,36 @@ limitations under the License.
var contentStr:String = content.toXMLString();
var correctStr:String = '
[royale-docs] branch develop updated: Update circular-dependencies.md
This is an automated email from the ASF dual-hosted git repository. andreww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-docs.git The following commit(s) were added to refs/heads/develop by this push: new 99e720c Update circular-dependencies.md 99e720c is described below commit 99e720cbeb2a743b3259cbd57fd0023a6714f585 Author: Andrew Wetmore AuthorDate: Tue Feb 20 08:50:33 2018 -0400 Update circular-dependencies.md Not complete yet. --- create-an-application/migrate-an-existing-app/circular-dependencies.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/create-an-application/migrate-an-existing-app/circular-dependencies.md b/create-an-application/migrate-an-existing-app/circular-dependencies.md index 60af9d5..789e6ed 100644 --- a/create-an-application/migrate-an-existing-app/circular-dependencies.md +++ b/create-an-application/migrate-an-existing-app/circular-dependencies.md @@ -45,4 +45,7 @@ In Flash and AIR the runtime constructs both classes before type-checking for pa ## What compiling for JavaScript requires +Royale uses the https://developers.google.com/closure/compiler/"; target="_blank">Google Closure Compiler (GCC) to compile your application into JavaScript that can run on browsers and mobile phones without heavy plugins like Flash. GCC "parses your JavaScript, analyzes it, removes dead code and rewrites and minimizes what's left. It also checks syntax, variable references, and types, and warns about common JavaScript pitfalls." + + *This material will be available soon.* -- To stop receiving notification emails like this one, please contact andr...@apache.org.
[royale-docs] branch develop updated: Update circular-dependencies.md
This is an automated email from the ASF dual-hosted git repository. andreww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-docs.git The following commit(s) were added to refs/heads/develop by this push: new 7715f55 Update circular-dependencies.md 7715f55 is described below commit 7715f55379407d9abc5b64b5378200844d8a84cc Author: Andrew Wetmore AuthorDate: Tue Feb 20 08:41:41 2018 -0400 Update circular-dependencies.md --- create-an-application/migrate-an-existing-app/circular-dependencies.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/create-an-application/migrate-an-existing-app/circular-dependencies.md b/create-an-application/migrate-an-existing-app/circular-dependencies.md index 8f40440..60af9d5 100644 --- a/create-an-application/migrate-an-existing-app/circular-dependencies.md +++ b/create-an-application/migrate-an-existing-app/circular-dependencies.md @@ -28,7 +28,7 @@ public class B extends A ``` Circular dependencies cause a tight coupling of what should be independent modules. This makes it difficult to re-use one module without its partner. When a developer makes a small change in one of the co-dependent modules, there may be unexpected effects on the other module, leading to poor application behavior or compile-time errors. in the worst case, a circular dependency can generate an infinite recursion leading to a crash or hanging the system. -## What Flex allows +## What compiling for Flash allows You can get away with some circular dependencies when developing an application in Flex or Royale that will be compiled for use in Flash or the AIR environment. You can write code like this: -- To stop receiving notification emails like this one, please contact andr...@apache.org.
[royale-asjs] 01/02: Fix valueOf() of empty XML elements
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 5fe8ee8730cc509f6d03b6e756076bed76af6ec4
Author: Harbs
AuthorDate: Tue Feb 20 11:39:18 2018 +0200
Fix valueOf() of empty XML elements
---
frameworks/projects/XML/src/main/royale/XML.as | 2 ++
1 file changed, 2 insertions(+)
diff --git a/frameworks/projects/XML/src/main/royale/XML.as
b/frameworks/projects/XML/src/main/royale/XML.as
index 46cc802..4934521 100644
--- a/frameworks/projects/XML/src/main/royale/XML.as
+++ b/frameworks/projects/XML/src/main/royale/XML.as
@@ -2644,6 +2644,8 @@ package
override public function valueOf():*
{
var str:String = this.toString();
+ if(str == "")
+ return str;
var num:Number = Number(str);
return isNaN(num) ? str : num;
}
--
To stop receiving notification emails like this one, please contact
ha...@apache.org.
[royale-asjs] 02/02: Fixed toXMLString() of CDATA sections
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit aacd60bcb54d989f56fab07517ccfdda3c8831f0
Author: Harbs
AuthorDate: Tue Feb 20 11:39:37 2018 +0200
Fixed toXMLString() of CDATA sections
---
frameworks/projects/XML/src/main/royale/XML.as | 4
manualtests/XMLTest/src/MyInitialView.mxml | 16 +++-
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/frameworks/projects/XML/src/main/royale/XML.as
b/frameworks/projects/XML/src/main/royale/XML.as
index 4934521..b13fada 100644
--- a/frameworks/projects/XML/src/main/royale/XML.as
+++ b/frameworks/projects/XML/src/main/royale/XML.as
@@ -2510,8 +2510,12 @@ package
if(prettyPrinting)
{
var v:String =
trimXMLWhitespace(_value);
+ if(name().localName == "#cdata-section")
+ return indent + v;
return indent + escapeElementValue(v);
}
+ if(name().localName == "#cdata-section")
+ return _value;
return escapeElementValue(_value);
}
if(this.nodeKind() == "attribute")
diff --git a/manualtests/XMLTest/src/MyInitialView.mxml
b/manualtests/XMLTest/src/MyInitialView.mxml
index 72e21a5..1e42c42 100644
--- a/manualtests/XMLTest/src/MyInitialView.mxml
+++ b/manualtests/XMLTest/src/MyInitialView.mxml
@@ -152,7 +152,21 @@ limitations under the License.
childXML =• Some amazing content;
childXMLStr = childXML.text();
trace(childXMLStr + " (should be) \t• Some
amazing content? " + (childXMLStr == "\t• Some amazing content"));
-
+XML.ignoreWhitespace = true;
+XML.prettyPrinting = false;
+var content:XML = new XML(
+'' +
+'
[royale-asjs] branch develop updated (6a039fb -> aacd60b)
This is an automated email from the ASF dual-hosted git repository. harbs pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git. from 6a039fb add license headers to new ASDoc classes to fix maven build new 5fe8ee8 Fix valueOf() of empty XML elements new aacd60b Fixed toXMLString() of CDATA sections The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: frameworks/projects/XML/src/main/royale/XML.as | 6 ++ manualtests/XMLTest/src/MyInitialView.mxml | 16 +++- 2 files changed, 21 insertions(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact ha...@apache.org.
