[jira] [Commented] (SAMZA-1023) ContainerProcessManager spams the job coordinator log with "TaskManager state" messages

2016-09-29 Thread Jake Maes (JIRA) 

[ 
https://issues.apache.org/jira/browse/SAMZA-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532863#comment-15532863
 ] 

Jake Maes commented on SAMZA-1023:
--

+1 
Merged and committed. 

Thanks [~banecogic]!

> ContainerProcessManager spams the job coordinator log with "TaskManager 
> state" messages
> ---
>
> Key: SAMZA-1023
> URL: https://issues.apache.org/jira/browse/SAMZA-1023
> Project: Samza
>  Issue Type: Bug
>Affects Versions: 0.11
>Reporter: Jake Maes
>Assignee: Branislav Cogic
> Attachments: SAMZA-1023_0.patch, SAMZA-1023_1.patch
>
>
> There are 2 problems with the message in the Summary:
> 1. The message is printed every second in the job coordinator log. Do we 
> really want to keep periodically printing that message indefinitely? It would 
> certainly be a departure from our convention thus far.
> 2. Since it starts with "Too many FailedContainers" it gets interpreted as a 
> problem, some reformatting, reordering, or rewording would help. 
> {noformat}
> 2016-09-21 20:10:40.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:41.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:42.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:43.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:44.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:45.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:46.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:47.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:48.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:49.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:50.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:51.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:52.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:53.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:54.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:55.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:56.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:57.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured

[jira] [Commented] (SAMZA-1023) ContainerProcessManager spams the job coordinator log with "TaskManager state" messages

2016-09-29 Thread Nicolas Colomer (JIRA) 

[ 
https://issues.apache.org/jira/browse/SAMZA-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532191#comment-15532191
 ] 

Nicolas Colomer commented on SAMZA-1023:


Upvote for this one :)

> ContainerProcessManager spams the job coordinator log with "TaskManager 
> state" messages
> ---
>
> Key: SAMZA-1023
> URL: https://issues.apache.org/jira/browse/SAMZA-1023
> Project: Samza
>  Issue Type: Bug
>Affects Versions: 0.11
>Reporter: Jake Maes
>Assignee: Branislav Cogic
> Attachments: SAMZA-1023_0.patch, SAMZA-1023_1.patch
>
>
> There are 2 problems with the message in the Summary:
> 1. The message is printed every second in the job coordinator log. Do we 
> really want to keep periodically printing that message indefinitely? It would 
> certainly be a departure from our convention thus far.
> 2. Since it starts with "Too many FailedContainers" it gets interpreted as a 
> problem, some reformatting, reordering, or rewording would help. 
> {noformat}
> 2016-09-21 20:10:40.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:41.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:42.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:43.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:44.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:45.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:46.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:47.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:48.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:49.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:50.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:51.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:52.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:53.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:54.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:55.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:56.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:57.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5

[jira] [Commented] (SAMZA-1023) ContainerProcessManager spams the job coordinator log with "TaskManager state" messages

2016-09-21 Thread Jake Maes (JIRA) 

[ 
https://issues.apache.org/jira/browse/SAMZA-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511575#comment-15511575
 ] 

Jake Maes commented on SAMZA-1023:
--

That should fix the first problem (spamming) but the message should still be 
restructured/reworded so it doesn't read like an error. 

> ContainerProcessManager spams the job coordinator log with "TaskManager 
> state" messages
> ---
>
> Key: SAMZA-1023
> URL: https://issues.apache.org/jira/browse/SAMZA-1023
> Project: Samza
>  Issue Type: Bug
>Affects Versions: 0.11
>Reporter: Jake Maes
>
> There are 2 problems with the message in the Summary:
> 1. The message is printed every second in the job coordinator log. Do we 
> really want to keep periodically printing that message indefinitely? It would 
> certainly be a departure from our convention thus far.
> 2. Since it starts with "Too many FailedContainers" it gets interpreted as a 
> problem, some reformatting, reordering, or rewording would help. 
> {noformat}
> 2016-09-21 20:10:40.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:41.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:42.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:43.837 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:44.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:45.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:46.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:47.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:48.838 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:49.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:50.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:51.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:52.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:53.839 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:54.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:55.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:56.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5 AllocatorThread liveness: true 
> 2016-09-21 20:10:57.840 [main] ContainerProcessManager [INFO]  TaskManager 
> state: Too many FailedContainers: false No. Completed containers: 0 Num 
> Configured containers: 5