[GitHub] asifdxtreme commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430492027 @anvithks please replace favicon.* with ServiceComb icons, you can get it in this [project](https://github.com/apache/incubator-servicecomb-website) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782566
##
File path: saga-web/src/main/resources/saga-frontend/tslint.json
##
@@ -0,0 +1,136 @@
+{
Review comment:
tslint might not be required, please double check
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782019 ## File path: saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/sample/sample.layout.scss ## @@ -0,0 +1,179 @@ +@import '../../styles/themes'; Review comment: are we using sample.layout.scss anywhere? please double check This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782453
##
File path:
saga-web/src/main/resources/saga-frontend/src/assets/data/events.json
##
@@ -0,0 +1,869 @@
+[{
Review comment:
I guess this file doesn't needs to be checked in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782066
##
File path:
saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/sample/sample.layout.ts
##
@@ -0,0 +1,103 @@
+import { Component, OnDestroy } from '@angular/core';
Review comment:
please double check usage of this file
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430489779 ### // TODO (Mandatory before the PR merge) For New dependencies following things should be done - [ ] Add the license copies in this [directory](https://github.com/apache/incubator-servicecomb-saga/tree/master/saga-distribution/src/release/licenses) - [ ] Add the Usage information over [here](https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/NOTICE) - [ ] Add the Usage information with the version number over [here](https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225780290
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git;
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues;
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
+"@agm/core": "1.0.0-beta.2",
+"@angular/animations": "6.0.0",
+"@angular/common": "6.0.0",
+"@angular/compiler": "6.0.0",
+"@angular/core": "6.0.0",
+"@angular/forms": "6.0.0",
+"@angular/http": "6.0.0",
+"@angular/platform-browser": "6.0.0",
+"@angular/platform-browser-dynamic": "6.0.0",
+"@angular/router": "6.0.0",
+"@asymmetrik/ngx-leaflet": "3.0.1",
+"@nebular/auth": "2.0.0-rc.10",
+"@nebular/security": "2.0.0-rc.10",
+"@nebular/theme": "2.0.0-rc.10",
+"@ng-bootstrap/ng-bootstrap": "1.0.0",
+"@swimlane/ngx-charts": "7.0.1",
+"angular-tree-component": "7.2.0",
+"angular2-chartjs": "0.4.1",
+"angular2-toaster": "6.0.0",
+"bootstrap": "4.0.0",
+"chart.js": "2.7.1",
+"ckeditor": "4.7.3",
+"classlist.js": "1.1.20150312",
+"core-js": "2.5.1",
+"echarts": "^4.0.2",
+"intl": "1.2.5",
+"ionicons": "2.0.1",
+"leaflet": "1.2.0",
+"nebular-icons": "1.0.9",
+"ng2-ckeditor": "1.1.13",
+"ng2-completer": "2.0.8",
+"ng2-smart-table": "1.3.5",
+"ngx-echarts": "2.0.1",
+"normalize.css": "6.0.0",
+"pace-js": "1.0.2",
+"roboto-fontface": "0.8.0",
+"rxjs": "^6.1.0",
+"rxjs-compat": "^6.1.0",
+"socicon": "3.0.5",
+"tinymce": "4.5.7",
Review comment:
https://github.com/tinymce/tinymce/blob/master/LICENSE.TXT tinymce is not
compatibel with Apache License, please find an alternative to this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225778980
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git;
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues;
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
+"@agm/core": "1.0.0-beta.2",
+"@angular/animations": "6.0.0",
+"@angular/common": "6.0.0",
+"@angular/compiler": "6.0.0",
+"@angular/core": "6.0.0",
+"@angular/forms": "6.0.0",
+"@angular/http": "6.0.0",
+"@angular/platform-browser": "6.0.0",
+"@angular/platform-browser-dynamic": "6.0.0",
+"@angular/router": "6.0.0",
+"@asymmetrik/ngx-leaflet": "3.0.1",
+"@nebular/auth": "2.0.0-rc.10",
+"@nebular/security": "2.0.0-rc.10",
+"@nebular/theme": "2.0.0-rc.10",
+"@ng-bootstrap/ng-bootstrap": "1.0.0",
+"@swimlane/ngx-charts": "7.0.1",
+"angular-tree-component": "7.2.0",
+"angular2-chartjs": "0.4.1",
+"angular2-toaster": "6.0.0",
+"bootstrap": "4.0.0",
+"chart.js": "2.7.1",
+"ckeditor": "4.7.3",
+"classlist.js": "1.1.20150312",
+"core-js": "2.5.1",
+"echarts": "^4.0.2",
+"intl": "1.2.5",
+"ionicons": "2.0.1",
+"leaflet": "1.2.0",
+"nebular-icons": "1.0.9",
+"ng2-ckeditor": "1.1.13",
+"ng2-completer": "2.0.8",
+"ng2-smart-table": "1.3.5",
+"ngx-echarts": "2.0.1",
+"normalize.css": "6.0.0",
+"pace-js": "1.0.2",
+"roboto-fontface": "0.8.0",
+"rxjs": "^6.1.0",
+"rxjs-compat": "^6.1.0",
+"socicon": "3.0.5",
+"tinymce": "4.5.7",
+"typeface-exo": "0.0.22",
+"underscore": "^1.9.1",
+"web-animations-js": "2.2.5",
+"zone.js": "^0.8.26"
+ },
+ "devDependencies": {
Review comment:
probably we don't need these
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225780098
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git;
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues;
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
+"@agm/core": "1.0.0-beta.2",
+"@angular/animations": "6.0.0",
+"@angular/common": "6.0.0",
+"@angular/compiler": "6.0.0",
+"@angular/core": "6.0.0",
+"@angular/forms": "6.0.0",
+"@angular/http": "6.0.0",
+"@angular/platform-browser": "6.0.0",
+"@angular/platform-browser-dynamic": "6.0.0",
+"@angular/router": "6.0.0",
+"@asymmetrik/ngx-leaflet": "3.0.1",
+"@nebular/auth": "2.0.0-rc.10",
+"@nebular/security": "2.0.0-rc.10",
+"@nebular/theme": "2.0.0-rc.10",
+"@ng-bootstrap/ng-bootstrap": "1.0.0",
+"@swimlane/ngx-charts": "7.0.1",
+"angular-tree-component": "7.2.0",
+"angular2-chartjs": "0.4.1",
+"angular2-toaster": "6.0.0",
+"bootstrap": "4.0.0",
+"chart.js": "2.7.1",
+"ckeditor": "4.7.3",
+"classlist.js": "1.1.20150312",
+"core-js": "2.5.1",
+"echarts": "^4.0.2",
+"intl": "1.2.5",
+"ionicons": "2.0.1",
+"leaflet": "1.2.0",
+"nebular-icons": "1.0.9",
+"ng2-ckeditor": "1.1.13",
+"ng2-completer": "2.0.8",
+"ng2-smart-table": "1.3.5",
+"ngx-echarts": "2.0.1",
+"normalize.css": "6.0.0",
+"pace-js": "1.0.2",
+"roboto-fontface": "0.8.0",
Review comment:
are we using this anywhere in our code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225778878
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git;
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues;
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
Review comment:
probably we don't need these
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225778816
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git;
Review comment:
please update these links
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] fangzuoxian opened a new issue #959: 中文文档有没有?
fangzuoxian opened a new issue #959: 中文文档有没有? URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/959 给外国人用的吧？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225761072
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -48,9 +75,11 @@ public static int getConnectionIdleTimeoutInSeconds() {
}
public static boolean getConnectionKeepAlive() {
-return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true).get();
+return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true)
+.get();
}
+
public static boolean getConnectionCompression() {
return DynamicPropertyFactory.getInstance()
.getBooleanProperty("servicecomb.rest.client.connection.compression",
false)
Review comment:
io.vertx.core.http.HttpClientOptions#DEFAULT_TRY_USE_COMPRESSION
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225760905
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -37,8 +39,33 @@ public static int getThreadCount() {
return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.thread-count",
1).get();
}
+ public static int getHttp2ConnectionMaxPoolSize() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.maxPoolSize",
+HttpClientOptions.DEFAULT_HTTP2_MAX_POOL_SIZE)
+.get();
+ }
+
+ public static int getHttp2MultiplexingLimit() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.multiplexingLimit",
+HttpClientOptions.DEFAULT_HTTP2_MULTIPLEXING_LIMIT)
+.get();
+ }
+
+ public static int getHttp2ConnectionIdleTimeoutInSeconds() {
+return DynamicPropertyFactory.getInstance()
+.getIntProperty("servicecomb.rest.client.http2.idleTimeoutInSeconds",
0)
+.get();
+ }
+
+ public static boolean getUseAlpn() {
+return DynamicPropertyFactory.getInstance()
+.getBooleanProperty("servicecomb.rest.client.http2.useAlpnEnabled",
true)
+.get();
+ }
+
public static int getConnectionMaxPoolSize() {
-return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.connection.maxPoolSize",
5).get();
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.connection.maxPoolSize",
5)
Review comment:
io.vertx.core.http.HttpClientOptions#DEFAULT_MAX_POOL_SIZE
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225760967
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -48,9 +75,11 @@ public static int getConnectionIdleTimeoutInSeconds() {
}
public static boolean getConnectionKeepAlive() {
-return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true).get();
+return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true)
Review comment:
io.vertx.core.http.HttpClientOptions#DEFAULT_KEEP_ALIVE
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225760102
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -37,8 +39,33 @@ public static int getThreadCount() {
return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.thread-count",
1).get();
}
+ public static int getHttp2ConnectionMaxPoolSize() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.maxPoolSize",
+HttpClientOptions.DEFAULT_HTTP2_MAX_POOL_SIZE)
+.get();
+ }
+
+ public static int getHttp2MultiplexingLimit() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.multiplexingLimit",
+HttpClientOptions.DEFAULT_HTTP2_MULTIPLEXING_LIMIT)
+.get();
+ }
+
+ public static int getHttp2ConnectionIdleTimeoutInSeconds() {
+return DynamicPropertyFactory.getInstance()
+.getIntProperty("servicecomb.rest.client.http2.idleTimeoutInSeconds",
0)
Review comment:
io.vertx.core.net.TCPSSLOptions#DEFAULT_IDLE_TIMEOUT
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225759853
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
##
@@ -133,7 +139,24 @@ public void disconnected(Object webSocketMetric) {
@Override
public DefaultHttpSocketMetric connected(SocketAddress remoteAddress, String
remoteName) {
-return new DefaultHttpSocketMetric(null);
+// when host of createEndpoint is not ip but a hostName
+// get from remoteAddress will return null
+// in this time need to try again with remoteName
+// connected is a low frequency method, this try logic will not cause
performance problem
+
+DefaultClientEndpointMetric clientEndpointMetric =
this.clientEndpointMetricManager
+.getClientEndpointMetric(remoteAddress);
+if (clientEndpointMetric == null) {
+ LOGGER.warn("can not find endpointMetric directly by remoteAddress {},
try again with remoteName {}",
Review comment:
line from 142 to 145 explain when will get a null result.
but i think the warn log is not necessary, it's a normal status, no need to
warn
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225759652
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##
@@ -87,6 +85,21 @@ private static HttpClientOptions createHttpClientOptions() {
return httpClientOptions;
}
+ private static HttpClientOptions createHttp2ClientOptions() {
+HttpClientOptions httpClientOptions = new HttpClientOptions();
+
httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
+.setUseAlpn(TransportClientConfig.getUseAlpn())
+.setHttp2ClearTextUpgrade(false)
Review comment:
last developer said that must set to false
but he did not make http2 production ready
so we better to confirm this again:
producer a is h2
producer b is h2c
one consumer can invoke both a and b
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #958: [SCB-964] Fix setting MediaType problem
coveralls commented on issue #958: [SCB-964] Fix setting MediaType problem URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/958#issuecomment-430434078 [](https://coveralls.io/builds/19550189) Coverage increased (+0.01%) to 86.346% when pulling **d726523e361f557c39de33f33e5eed5ff6541c15 on yhs0092:fix_setting_consumes_problem_UnsupportedOperationException** into **abdb21adee72717f8fadd6f5fa2a89ebe4e00920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls edited a comment on issue #937: [SCB-718]If auto discovery failed, will cause a dead cycle
coveralls edited a comment on issue #937: [SCB-718]If auto discovery failed, will cause a dead cycle URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/937#issuecomment-425730811 [](https://coveralls.io/builds/19541694) Coverage increased (+0.1%) to 86.337% when pulling **06472d01a03c117ec910c9a180bced96e33f001b on laijianbin:cache** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls edited a comment on issue #937: [SCB-718]If auto discovery failed, will cause a dead cycle
coveralls edited a comment on issue #937: [SCB-718]If auto discovery failed, will cause a dead cycle URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/937#issuecomment-425730811 [](https://coveralls.io/builds/19541679) Coverage increased (+0.1%) to 86.337% when pulling **06472d01a03c117ec910c9a180bced96e33f001b on laijianbin:cache** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #957: [SCB-961]provide a way to isolate for at least a moment
coveralls commented on issue #957: [SCB-961]provide a way to isolate for at least a moment URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/957#issuecomment-430415856 [](https://coveralls.io/builds/19541087) Coverage decreased (-0.0009%) to 86.331% when pulling **c62833443b8fdbae147f8579074dbedee83293e1 on liubao68:isolation-rev** into **abdb21adee72717f8fadd6f5fa2a89ebe4e00920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #956: [SCB*675] Gen proto from swagger
coveralls commented on issue #956: [SCB*675] Gen proto from swagger URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/956#issuecomment-430413641 [](https://coveralls.io/builds/19539932) Coverage increased (+0.06%) to 86.395% when pulling **f25f7355a86af4a0627e65e6ccc50a32a0410f01 on wujimin:gen-proto-from-swagger** into **abdb21adee72717f8fadd6f5fa2a89ebe4e00920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center
codecov-io commented on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == + Coverage 60.18% 60.19% +<.01% == Files 156 156 Lines 1341113411 == + Hits 8072 8073 +1 Misses 4760 4760 + Partials 579 578 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=footer). Last update [8ddbc2f...bc24da1](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yhs0092 opened a new pull request #958: [SCB-964] Fix setting MediaType problem
yhs0092 opened a new pull request #958: [SCB-964] Fix setting MediaType problem URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/958 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] little-cui opened a new pull request #458: SCB-953 Support sync distinct Kubernetes service types to service-center
little-cui opened a new pull request #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anvithks commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
anvithks commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430188706 > BTW, we can need to create a module of UI first, then put the compiled js into the static resource directory of the saga-web. I will write an install script for the UI. This script will compile the UI from the source and copy the contents of the dist/ folder in to the static/ folder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cherrylzhao commented on issue #316: compensationMethod spring transaction didn't take effect
cherrylzhao commented on issue #316: compensationMethod spring transaction didn't take effect URL: https://github.com/apache/incubator-servicecomb-saga/issues/316#issuecomment-430188530 @minlywang I have reproduce this problem in my machine. we should cached the transaction proxy bean in callback context instead of raw bean. I'll try to fix this bug. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anvithks commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit
anvithks commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430188343 > @anvithks After went through the PR, I found you may just copy https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if it's best way to do it, but need to make sure it works with Apache License first. @WillemJiang sorry for the delayed response. I was on planned vacation and could not check on this. Yes, you are right we can use the starter kit but it does not have many of the UI components that we have used in the UI. I will check if I can start with the starter-kit and add our modules. Let me get back to you on that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-servicecomb-saga] branch master updated: Publish the snapshot without running test
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-saga.git
The following commit(s) were added to refs/heads/master by this push:
new 42cadd8 Publish the snapshot without running test
42cadd8 is described below
commit 42cadd845c62b9f35922061e483202f51d416db4
Author: Willem Jiang
AuthorDate: Tue Oct 16 18:01:19 2018 +0800
Publish the snapshot without running test
---
.travis.yml| 6 +-
.travis.yml => scripts/test.sh | 30 +++---
2 files changed, 8 insertions(+), 28 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 9d86375..813141d 100755
--- a/.travis.yml
+++ b/.travis.yml
@@ -30,10 +30,6 @@ env:
- SPRING_BOOT_PROFILE=spring-boot-1
# use spring-boot-2 profile
- SPRING_BOOT_PROFILE=spring-boot-2
-script:
-- set -e
-- mvn clean install -Pjacoco -Pdocker -P${SPRING_BOOT_PROFILE} coveralls:report
-- mvn clean verify -f saga-demo -Pdemo -Pdocker -P${SPRING_BOOT_PROFILE}
-Ddocker.useColor=false -Ddocker.showLogs
-- mvn clean verify -f acceptance-tests -Pdemo -Pdocker
-P${SPRING_BOOT_PROFILE} -Ddocker.useColor=false -Ddocker.showLogs
+script: ./scripts/test.sh
after_success:
- if [ "$TRAVIS_EVENT_TYPE" == "cron" ] && [ "$SPRING_BOOT_PROFILE" ==
"spring-boot-1" ]; then bash -x scripts/deploy.sh ; fi
diff --git a/.travis.yml b/scripts/test.sh
similarity index 64%
copy from .travis.yml
copy to scripts/test.sh
index 9d86375..fda9dbd 100755
--- a/.travis.yml
+++ b/scripts/test.sh
@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
## ---
## Licensed to the Apache Software Foundation (ASF) under one or more
## contributor license agreements. See the NOTICE file distributed with
@@ -14,26 +15,9 @@
## See the License for the specific language governing permissions and
## limitations under the License.
## ---
-
-sudo: required
-
-cache:
- directories:
- - "$HOME/.m2"
-language: java
-
-install: true
-jdk:
-- oraclejdk8
-env:
- # dummy profile
- - SPRING_BOOT_PROFILE=spring-boot-1
- # use spring-boot-2 profile
- - SPRING_BOOT_PROFILE=spring-boot-2
-script:
-- set -e
-- mvn clean install -Pjacoco -Pdocker -P${SPRING_BOOT_PROFILE} coveralls:report
-- mvn clean verify -f saga-demo -Pdemo -Pdocker -P${SPRING_BOOT_PROFILE}
-Ddocker.useColor=false -Ddocker.showLogs
-- mvn clean verify -f acceptance-tests -Pdemo -Pdocker
-P${SPRING_BOOT_PROFILE} -Ddocker.useColor=false -Ddocker.showLogs
-after_success:
-- if [ "$TRAVIS_EVENT_TYPE" == "cron" ] && [ "$SPRING_BOOT_PROFILE" ==
"spring-boot-1" ]; then bash -x scripts/deploy.sh ; fi
+#bin/sh
+if ["$TRAVIS_EVENT_TYPE" != "cron" ]; then
+ mvn clean install -Pjacoco -Pdocker -P${SPRING_BOOT_PROFILE} coveralls:report
+ mvn clean verify -f saga-demo -Pdemo -Pdocker -P${SPRING_BOOT_PROFILE}
-Ddocker.useColor=false -Ddocker.showLogs
+ mvn clean verify -f acceptance-tests -Pdemo -Pdocker
-P${SPRING_BOOT_PROFILE} -Ddocker.useColor=false -Ddocker.showLogs
+fi
[GitHub] liubao68 commented on issue #957: [SCB-961]provide a way to isolate for at least a moment
liubao68 commented on issue #957: [SCB-961]provide a way to isolate for at least a moment URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/957#issuecomment-430120415 Integration tests provided in this project: https://github.com/huaweicse/cse-java-chassis-samples/tree/master/isolation-performance This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liubao68 opened a new pull request #957: [SCB-961]provide a way to isolate for at least a moment
liubao68 opened a new pull request #957: [SCB-961]provide a way to isolate for at least a moment URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/957 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
