[GitHub] coveralls commented on issue #341: SCB-1039 Add a check for the compensable retries setting
coveralls commented on issue #341: SCB-1039 Add a check for the compensable retries setting URL: https://github.com/apache/servicecomb-saga/pull/341#issuecomment-441172554 [](https://coveralls.io/builds/20255578) Coverage decreased (-0.2%) to 91.762% when pulling **7c417100449653535a982072ee1336d0a8cb53af on SCB-1036** into **76956e4c2308723ed98af706ec6b1b7119ce7870 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理
WillemJiang commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理 URL: https://github.com/apache/servicecomb-saga/issues/340#issuecomment-441170560 @zhfeng I updated the Compensable retries comments on this [PR 341](https://github.com/apache/servicecomb-saga/pull/341) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-saga] 01/01: SCB-1039 Add a check for the compensable retires setting
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a commit to branch SCB-1036
in repository https://gitbox.apache.org/repos/asf/servicecomb-saga.git
commit 7c417100449653535a982072ee1336d0a8cb53af
Author: Willem Jiang
AuthorDate: Fri Nov 23 15:17:07 2018 +0800
SCB-1039 Add a check for the compensable retires setting
---
.../spring/CompensableMethodCheckingCallback.java | 7 ++-
.../spring/CompensableAnnotationCheckingTest.java | 14 ++
.../spring/MisconfiguredRetriesService.java}| 21 +++--
.../omega/transaction/annotations/Compensable.java | 10 ++
4 files changed, 37 insertions(+), 15 deletions(-)
diff --git
a/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
b/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
index e3f4907..bf2b5ce 100644
---
a/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
+++
b/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
@@ -32,7 +32,12 @@ class CompensableMethodCheckingCallback extends
MethodCheckingCallback {
if (!method.isAnnotationPresent(Compensable.class)) {
return;
}
-String compensationMethod =
method.getAnnotation(Compensable.class).compensationMethod();
+Compensable compensable = method.getAnnotation(Compensable.class);
+String compensationMethod = compensable.compensationMethod();
+// we don't support the retries number below -1.
+if (compensable.retries() < -1) {
+ throw new IllegalArgumentException(String.format("Compensable %s of
method %s, the retries should not below -1.", compensable, method.getName()));
+}
loadMethodContext(method, compensationMethod);
}
}
diff --git
a/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableAnnotationCheckingTest.java
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableAnnotationCheckingTest.java
index 0bf6dce..6cbf8f9 100644
---
a/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableAnnotationCheckingTest.java
+++
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableAnnotationCheckingTest.java
@@ -18,6 +18,7 @@
package org.apache.servicecomb.saga.omega.transaction.spring;
import static com.seanyinx.github.unit.scaffolding.AssertUtils.expectFailing;
+import static org.hamcrest.CoreMatchers.endsWith;
import static org.hamcrest.CoreMatchers.startsWith;
import static org.hamcrest.core.Is.is;
import static org.junit.Assert.assertThat;
@@ -42,6 +43,19 @@ public class CompensableAnnotationCheckingTest {
}
@Test
+ public void blowsUpWhenCompensateRetriesIsBelowNegativeOne() throws
Exception {
+try {
+ try (ConfigurableApplicationContext ignored = new
SpringApplicationBuilder(TransactionTestMain.class)
+ .profiles("annotation-retries-checking")
+ .run()) {
+expectFailing(BeanCreationException.class);
+ }
+} catch (BeanCreationException e) {
+ assertThat(e.getCause().getMessage(), endsWith("the retries should not
below -1."));
+}
+ }
+
+ @Test
public void blowsUpWhenAnnotationOnWrongType() throws Exception {
try {
try (ConfigurableApplicationContext ignored = new
SpringApplicationBuilder(TransactionTestMain.class)
diff --git
a/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/MisconfiguredRetriesService.java
similarity index 60%
copy from
omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
copy to
omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/MisconfiguredRetriesService.java
index e3f4907..e68c99c 100644
---
a/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/CompensableMethodCheckingCallback.java
+++
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/MisconfiguredRetriesService.java
@@ -17,22 +17,15 @@
package org.apache.servicecomb.saga.omega.transaction.spring;
-import java.lang.reflect.Method;
-import org.apache.servicecomb.saga.omega.context.CallbackContext;
import org.apache.servicecomb.saga.omega.transaction.annotations.Compensable;
+import org.springframework.context.annotation.Profile;
+import org.springframework.stereotype.Component;
-class CompensableMethodCheckingCallback extends MethodCheckingCallback
[GitHub] WillemJiang edited a comment on issue #338: Updated the retry rule
WillemJiang edited a comment on issue #338: Updated the retry rule URL: https://github.com/apache/servicecomb-saga/pull/338#issuecomment-441168530 I just created a JIRA [SCB-1036](https://issues.apache.org/jira/browse/SCB-1036) for the issue. I will commit a quick fix for it shortly. Do you mind close the issue once you verify the patch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on issue #338: Updated the retry rule
WillemJiang commented on issue #338: Updated the retry rule URL: https://github.com/apache/servicecomb-saga/pull/338#issuecomment-441168530 I just fill a [JIRA](https://issues.apache.org/jira/browse/SCB-1036) for the issue. I will commit a quick fix for it shortly. Do you mind close the issue once you verify the patch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired
coveralls commented on issue #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004#issuecomment-441166462 [](https://coveralls.io/builds/20255253) Coverage decreased (-0.1%) to 86.592% when pulling **bda9dc87e5d907e995cb9fe76189d089d3d20e2a on weichao666:defaultvaluenew** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Fangfeikun commented on issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息
Fangfeikun commented on issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息 URL: https://github.com/apache/servicecomb-java-chassis/issues/1003#issuecomment-441166388  服务被删除之后，静态信息是不存在的，如果排除是注册中心的异常，那么只有一种情况，就是用户手动删除了该服务，因此，这种情况下，不应该再刷新该服务的注册信息。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weichao666 opened a new pull request #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired
weichao666 opened a new pull request #1004: [SCB-925] Springmvc, when have defaultValue, required should be false, when param not exist, should check isRequired URL: https://github.com/apache/servicecomb-java-chassis/pull/1004 … Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Fangfeikun commented on issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息
Fangfeikun commented on issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息 URL: https://github.com/apache/servicecomb-java-chassis/issues/1003#issuecomment-441162991 应该要有移除机制，一是，减少性能损坏，再者，不会出现大量的异常信息 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yangbor commented on issue #495: [SCB-1033] Update third party licenses
yangbor commented on issue #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#issuecomment-441162696 Closing this PR for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Fangfeikun opened a new issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息
Fangfeikun opened a new issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息 URL: https://github.com/apache/servicecomb-java-chassis/issues/1003  注册中心的服务被删除后，或者服务多久没有被访问，sdk应该移除该服务的注册信息，不再周期获取该服务的信息，下一次再次被访问时，再重新获取该服务的注册信息 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Fangfeikun commented on issue #1003: 服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息
Fangfeikun commented on issue #1003:
服务删除后，ServiceRegistryClient还一直从注册中心周期获取服务信息，导致大量异常信息
URL:
https://github.com/apache/servicecomb-java-chassis/issues/1003#issuecomment-441162605
`2018-11-23 00:36:11.179 ERROR 1 --- [erListUpdater-1]
o.a.s.s.r.AbstractServiceRegistry: Can not find any instances from
service center due to previous errors.
service=default/e0c4472f-9598-42cf-948b-069f35030c1a/0.0.0+
2018-11-23 00:36:11.179 INFO 1 --- [erListUpdater-1]
o.a.s.s.c.MicroserviceVersions : create MicroserviceVersionRule,
appId=default, microserviceName=e0c4472f-9598-42cf-948b-069f35030c1a,
versionRule=0.0.0+.
2018-11-23 00:36:11.179 INFO 1 --- [erListUpdater-1]
o.a.s.s.c.MicroserviceVersions : create MicroserviceVersions,
appId=default, microserviceName=0e736c27-c6ce-4690-b78b-4bb663a3aabb.
2018-11-23 00:36:11.180 WARN 1 --- [ntloop-thread-0]
o.a.s.s.c.h.ServiceRegistryClientImpl:
{"errorCode":"400012","errorMessage":"Micro-service does not
exist","detail":"provider does not exist, consumer
6848338eedfc11e89c1f0255ac109680 find service
/default/d4f3f776-3b6b-4603-ab93-720e7fd7f67f/0.0.0+"}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asifdxtreme commented on a change in pull request #495: [SCB-1033] Update third party licenses
asifdxtreme commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235852180 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: go mod is not updated and it uses lot of redudant repo which is actually not used by Service-Center and that's the whole reason why the are not included in the license, so for this release we prefer giving with glide.yaml and there is definitely some amount of work needed to update the go mod file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #338: Updated the retry rule
WillemJiang commented on a change in pull request #338: Updated the retry rule
URL: https://github.com/apache/servicecomb-saga/pull/338#discussion_r235839258
##
File path:
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/ForwardRecovery.java
##
@@ -52,8 +53,9 @@ public Object apply(ProceedingJoinPoint joinPoint,
Compensable compensable, Comp
throw throwable;
}
- remains = remains == -1 ? -1 : remains - 1;
- if (remains == 0) {
+ if (remains > 0) {
+remains--;
+ } else if (remains == 0 ) {
Review comment:
现在我们修复这个问题需要做的是当remains小于-1的时候抛异常，而不是把参数范围修改成支持小于-1的设置。还有就是之前我已经说了你的PR有一些副作用，导致单元测试失败。
我在review日志里面已经提到了。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Gannalyo commented on a change in pull request #338: Updated the retry rule
Gannalyo commented on a change in pull request #338: Updated the retry rule
URL: https://github.com/apache/servicecomb-saga/pull/338#discussion_r235838931
##
File path:
omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/ForwardRecovery.java
##
@@ -52,8 +53,9 @@ public Object apply(ProceedingJoinPoint joinPoint,
Compensable compensable, Comp
throw throwable;
}
- remains = remains == -1 ? -1 : remains - 1;
- if (remains == 0) {
+ if (remains > 0) {
+remains--;
+ } else if (remains == 0 ) {
Review comment:
希望你们仔细看下此处程序逻辑，我们这面测试测出来的问题。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[servicecomb-website] branch master updated: additional content for opensource-project-is-not-so-far-away.md
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git The following commit(s) were added to refs/heads/master by this push: new 45fe565 additional content for opensource-project-is-not-so-far-away.md 45fe565 is described below commit 45fe565f62ebb83dcfff6fe8580f69c83248ce7d Author: yaohaishi AuthorDate: Thu Nov 22 14:18:54 2018 +0800 additional content for opensource-project-is-not-so-far-away.md --- _posts/cn/2018-11-20-opensource-project-is-not-so-far-away.md | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/_posts/cn/2018-11-20-opensource-project-is-not-so-far-away.md b/_posts/cn/2018-11-20-opensource-project-is-not-so-far-away.md index f8ad02c..ca7aafe 100644 --- a/_posts/cn/2018-11-20-opensource-project-is-not-so-far-away.md +++ b/_posts/cn/2018-11-20-opensource-project-is-not-so-far-away.md @@ -33,7 +33,10 @@ redirect_from: ### 给有意者的一些建议 -参与一个开源项目，对于自己阅读文档、分析源码、开发和沟通的能力都有很大的益处。这和开发一个业务系统是两种完全不同的体验，对于拓展个人的视野和经验很有帮助，我想大家应该从各种文章里了解很多了，我在这里就不多讲了 : ) +参与一个开源项目，对于自己阅读文档、分析源码、开发和沟通的能力都有很大的益处。这和开发一个业务系统是两种完全不同的体验，对于拓展个人的视野和经验很有帮助。如果进一步成为Apache committer，还有一些额外的福利哦，例如： +- 合入PR的权限：普通的贡献者只能等待其他committer来检视代码和帮你合入PR。如果你自己就是一名committer的话，那么你就有了合入PR的权限了；而且在你提交PR的时候，不用再像以前一样被动等待其他人来检视，你可以在Github的PR页面主动选择要求其他committer帮你检视代码，被你at到的committer会收到提醒检视的邮件，这样更快捷。 +- JetBrains开源license：如果你是一名Java开发人员，相信你应该听说过JetBrains的Intellij IDEA吧？IDEA有社区版和商业版之分，商业版的功能更丰富，不过需要付费使用。如果你成为了一个Apache项目的committer，那么你就可以申请Open Source License，免费使用商业版的IDEA，或者其他工具（如Goland）了。 +- 技术水平的认可：成为Apache Committer本身就是一件可以证明你的技术能力的事情。在[Apache Committer 列表][ApacheIDList]页面，你可以看到所有的Apache Committer，表格的第三列显示了各个committer所参与的项目。当你参与的项目足够多时，还能成为Apache member，帮助大家孵化开源项目，这个层次相当于比普通committer更进一步了。 如果想要参与到一个开源项目中，可以首先了解一下如何使用这个项目。给开源社区做贡献的方式不仅仅限于提交代码，[修复文档问题][ServiceComb-docs]可能是一个更好的切入点。通过阅读和修复文档问题，我们可以了解到一个项目的主要特性，这对于我们进一步了解项目源码也是很有帮助的。 @@ -53,7 +56,7 @@ redirect_from: 在成为committer之前，你需要先确保自己已经[签署iCLA][ContributorLicenseAgreements]。如果没有的话，可以先去[下载一份iCLA pdf文件][下载ICLA文件]，注意`(optional) Public name`一栏填写自己的github id。注意这份PDF文件需要签名，签名内容是`Full Name`那一栏的你填的内容。 将签署好了的iCLA文件按照[iCLA文件提交说明]发送给`secret...@apache.org`，等待回信即可完成签署流程。 2. 回复PMC的邀请邮件 -完成iCLA的签署后，就可以在Apache PMC的邀请邮件上回复了，回复邮件发给`priv...@servicecomb.apache.org`，你需要说明自己接受邀请，并且告诉PMC你所想要使用的Apache id。已经被人申请了的Apache ID在[这里][ApacheID]都可以查到，选择的时候需要选一个还没有被人使用的id。 +完成iCLA的签署后，就可以在Apache PMC的邀请邮件上回复了，回复邮件发给`priv...@servicecomb.apache.org`，你需要说明自己接受邀请，并且告诉PMC你所想要使用的Apache id。已经被人申请了的Apache ID在[这里][ApacheIDList]都可以查到，选择的时候需要选一个还没有被人使用的id。 3. 初始化Apache帐户密码 当收到Apache帐户创建成功的邮件（标题为`Welcome to the Apache Software Foundation (ASF)!`）时，你的Apache帐号就创建成功了，记得按照邮件中的提示，去设置一下自己的密码。重置密码的过程中需要使用你在签署iCLA时填写的邮箱地址。 4. 设置committer权限
[servicecomb-website] branch asf-site updated: Publish the website
This is an automated email from the ASF dual-hosted git repository.
ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new e7b10d3 Publish the website
e7b10d3 is described below
commit e7b10d3fbc459eab2581131f4af9a8c76b9fd6dc
Author: Willem Jiang
AuthorDate: Thu Nov 22 15:15:11 2018 +0800
Publish the website
---
.../cn/docs/opensource-project-is-not-so-far-away/index.html | 9 +++--
content/feed.xml | 11 ---
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/content/cn/docs/opensource-project-is-not-so-far-away/index.html
b/content/cn/docs/opensource-project-is-not-so-far-away/index.html
index 4cdf771..ad457b6 100644
--- a/content/cn/docs/opensource-project-is-not-so-far-away/index.html
+++ b/content/cn/docs/opensource-project-is-not-so-far-away/index.html
@@ -411,7 +411,12 @@
给有意者的一些建议
-参与一个开源项目，对于自己阅读文档、分析源码、开发和沟通的能力都有很大的益处。这和开发一个业务系统是两种完全不同的体验，对于拓展个人的视野和经验很有帮助，我想大家应该从各种文章里了解很多了，我在这里就不多讲了
: )
+参与一个开源项目，对于自己阅读文档、分析源码、开发和沟通的能力都有很大的益处。这和开发一个业务系统是两种完全不同的体验，对于拓展个人的视野和经验很有帮助。如果进一步成为Apache
committer，还有一些额外的福利哦，例如：
+
+
合入PR的权限：普通的贡献者只能等待其他committer来检视代码和帮你合入PR。如果你自己就是一名committer的话，那么你就有了合入PR的权限了；而且在你提交PR的时候，不用再像以前一样被动等待其他人来检视，你可以在Github的PR页面主动选择要求其他committer帮你检视代码，被你at到的committer会收到提醒检视的邮件，这样更快捷。
+ JetBrains开源license：如果你是一名Java开发人员，相信你应该听说过JetBrains的Intellij
IDEA吧？IDEA有社区版和商业版之分，商业版的功能更丰富，不过需要付费使用。如果你成为了一个Apache项目的committer，那么你就可以申请Open
Source License，免费使用商业版的IDEA，或者其他工具（如Goland）了。
+ 技术水平的认可：成为Apache Committer本身就是一件可以证明你的技术能力的事情。在http://people.apache.org/committer-index.html; title="Apache committer
index">Apache Committer 列表页面，你可以看到所有的Apache
Committer，表格的第三列显示了各个committer所参与的项目。当你参与的项目足够多时，还能成为Apache
member，帮助大家孵化开源项目，这个层次相当于比普通committer更进一步了。
+
如果想要参与到一个开源项目中，可以首先了解一下如何使用这个项目。给开源社区做贡献的方式不仅仅限于提交代码，https://github.com/apache/servicecomb-docs;
title="ServiceComb文档项目">修复文档问题可能是一个更好的切入点。通过阅读和修复文档问题，我们可以了解到一个项目的主要特性，这对于我们进一步了解项目源码也是很有帮助的。
@@ -434,7 +439,7 @@
在成为committer之前，你需要先确保自己已经http://www.apache.org/licenses/#clas;
title="Contributor License Agreements">签署iCLA。如果没有的话，可以先去http://www.apache.org/licenses/icla.pdf; title="下载ICLA文件">下载一份iCLA
pdf文件，注意(optional) Public
name一栏填写自己的github id。注意这份PDF文件需要签名，签名内容是Full Name那一栏的你填的内容。
将签署好了的iCLA文件按照http://www.apache.org/licenses/#submitting;
title="提交iCLA文件">iCLA文件提交说明发送给secret...@apache.org，等待回信即可完成签署流程。
回复PMC的邀请邮件
-完成iCLA的签署后，就可以在Apache PMC的邀请邮件上回复了，回复邮件发给priv...@servicecomb.apache.org，你需要说明自己接受邀请，并且告诉PMC你所想要使用的Apache
id。已经被人申请了的Apache ID在[这里][ApacheID]都可以查到，选择的时候需要选一个还没有被人使用的id。
+完成iCLA的签署后，就可以在Apache PMC的邀请邮件上回复了，回复邮件发给priv...@servicecomb.apache.org，你需要说明自己接受邀请，并且告诉PMC你所想要使用的Apache
id。已经被人申请了的Apache ID在http://people.apache.org/committer-index.html;
title="Apache committer index">这里都可以查到，选择的时候需要选一个还没有被人使用的id。
初始化Apache帐户密码
当收到Apache帐户创建成功的邮件（标题为Welcome to the Apache
Software Foundation
(ASF)!）时，你的Apache帐号就创建成功了，记得按照邮件中的提示，去设置一下自己的密码。重置密码的过程中需要使用你在签署iCLA时填写的邮箱地址。
设置committer权限
diff --git a/content/feed.xml b/content/feed.xml
index 93e7a1a..2a746b3 100644
--- a/content/feed.xml
+++ b/content/feed.xml
@@ -1,4 +1,4 @@
-http://www.w3.org/2005/Atom; >https://jekyllrb.com/;
version="3.4.3">Jekyll2018-11-22T09:36:52+08:00/Apache ServiceCombThe homepage of
ServiceComb{name=nil,
avatar=/assets [...]
+http://www.w3.org/2005/Atom; >https://jekyllrb.com/;
version="3.4.3">Jekyll2018-11-22T15:14:36+08:00/Apache ServiceCombThe homepage of
ServiceComb{name=nil,
avatar=/assets [...]
blockquote
p前几天收到了Apache ServiceComb PMC的邀请邮件，这意味着我成为了一名Apache
ServiceComb项目的Committer。喜悦之余，我想留下一篇博客作为自己工作的一个阶段性总结，同时也希望这篇文章能够给其他想要加入到开源社区的同学一点参考。/p
@@ -22,7 +22,12 @@
h3 id=给有意者的一些建议给有意者的一些建议/h3
-p参与一个开源项目，对于自己阅读文档、分析源码、开发和沟通的能力都有很大的益处。这和开发一个业务系统是两种完全不同的体验，对于拓展个人的视野和经验很有帮助，我想大家应该从各种文章里了解很多了，我在这里就不多讲了
: )/p
+p参与一个开源项目，对于自己阅读文档、分析源码、开发和沟通的能力都有很大的益处。这和开发一个业务系统是两种完全不同的体验，对于拓展个人的视野和经验很有帮助。如果进一步成为Apache
committer，还有一些额外的福利哦，例如：/p
+ul
+
li合入PR的权限：普通的贡献者只能等待其他committer来检视代码和帮你合入PR。如果你自己就是一名committer的话，那么你就有了合入PR的权限了；而且在你提交PR的时候，不用再像以前一样被动等待其他人来检视，你可以在Github的PR页面主动选择要求其他committer帮你检视代码，被你at到的committer会收到提醒检视的邮件，这样更快捷。/li
+ liJetBrains开源license：如果你是一名Java开发人员，相信你应该听说过JetBrains的Intellij
IDEA吧？IDEA有社区版和商业版之分，商业版的功能更丰富，不过需要付费使用。如果你成为了一个Apache项目的committer，那么你就可以申请Open
Source License，免费使用商业版的IDEA，或者其他工具（如Goland）了。/li
+ li技术水平的认可：成为Apache Committer本身就是一件可以证明你的技术能力的事情。在a
href=http://people.apache.org/committer-index.html;
title=Apache committer indexApache Committer
列表/a页面，你可以看到所有的Apache
Committer，表格的第三列显示了各个committer所参与的项目。当你参与的项目足够多时，还能成为Apache
member，帮助大家孵化开源项目，这个层次相当于比普通committer更进一步了。/li
+/ul
p如果想要参与到一个开源项目中，可以首先了解一下如何使用这个项目。给开源社区做贡献的方式不仅仅限于提交代码，a
href=https://github.com/apache/servicecomb-docs;
title=ServiceComb文档项目修复文档问题/a可能是一个更好的切入点。通过阅读和修复文档问题，我们可以了解到一个项目的主要特性，这对于我们进一步了解项目源码也是很有帮助的。/p
@@ -45,7 +50,7 @@
[GitHub] yangbor commented on a change in pull request #495: [SCB-1033] Update third party licenses
yangbor commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235835381 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: How about update the building scripts and use go mode (go 1.11) for this release. If we are going to migrate to go mod anyway, why not do it in this release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yangbor commented on a change in pull request #495: [SCB-1033] Update third party licenses
yangbor commented on a change in pull request #495: [SCB-1033] Update third party licenses URL: https://github.com/apache/servicecomb-service-center/pull/495#discussion_r235835381 ## File path: scripts/release/LICENSE ## @@ -214,39 +214,40 @@ The following components are provided under the Apache License Version 2.0. See the respective project link for details. github.com/apache/thrift/lib/go/thrift (3d556248a8b97310da49939195330691dfe9d9ad) Review comment: How about update the building scripts and use go 1.11 for this release. If we are going to migrate to go mod anyway, why not do it in this release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on a change in pull request #999: [SCB-1031] resolve @ApiOperator @Response override wrong, if the prev…
wujimin commented on a change in pull request #999: [SCB-1031] resolve
@ApiOperator @Response override wrong, if the prev…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/999#discussion_r235788636
##
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/processor/annotation/AnnotationUtils.java
##
@@ -127,7 +127,35 @@ public static void addResponse(Swagger swagger,
ApiResponse apiResponse) {
public static void addResponse(Swagger swagger, Operation operation,
ApiResponse apiResponse) {
ResponseConfig responseConfig = convert(apiResponse);
generateResponse(swagger, responseConfig);
-operation.response(responseConfig.getCode(), responseConfig.getResponse());
+mergeResponse(operation, responseConfig);
+ }
+
+ private static void mergeResponse(Operation operation, ResponseConfig
responseConfig) {
+if (operation.getResponses() == null) {
+ operation.response(responseConfig.getCode(),
responseConfig.getResponse());
+ return;
+}
+Response response =
operation.getResponses().get(String.valueOf(responseConfig.getCode()));
+if (response != null) {
+ Response targetResp = responseConfig.getResponse();
Review comment:
1.targetResp is source, right?
2.logic for (response == null) is simpler, better to process first and then
return, and no need write "else"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1001: [SCB-968]968 http2 do not support pump download
coveralls commented on issue #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001#issuecomment-441018970 [](https://coveralls.io/builds/20243795) Coverage decreased (-0.05%) to 86.668% when pulling **1ce3de7ccabdaaca17bec97cb61df400475372b4 on heyile:h2PumpDownload** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heyile opened a new pull request #1001: [SCB-968]968 http2 do not support pump download
heyile opened a new pull request #1001: [SCB-968]968 http2 do not support pump download URL: https://github.com/apache/servicecomb-java-chassis/pull/1001 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhfeng commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理
zhfeng commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理 URL: https://github.com/apache/servicecomb-saga/issues/340#issuecomment-440968995 sorry, @WillemJiang you are right and I just check the ForwardRecovery and this retries attribute is used to reinvoke the method. Can we make this attribute much clear in the annotation desc ? Thanks ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhfeng commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理
zhfeng commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理 URL: https://github.com/apache/servicecomb-saga/issues/340#issuecomment-440967383 @WillemJiang do you mean set the retries attribute in the Compensable annotation ? I think this is retrying for invoking the compensation method ? correct me if I am wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理
WillemJiang commented on issue #340: Saga嵌套事务支持，及如何实现前向恢复（重试）的处理 URL: https://github.com/apache/servicecomb-saga/issues/340#issuecomment-440965974 For the second question: For the forward recovery, Omega just call the transaction method again if it gets the exception. You can configure it from the [Compensable](https://github.com/apache/servicecomb-saga/blob/master/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/annotations/Compensable.java) annotation; for the backward recovery, Omega just call the compensation method for you., you can configure it on the [Compensable](https://github.com/apache/servicecomb-saga/blob/master/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/annotations/Compensable.java) annotation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
