[GitHub] coveralls commented on issue #1102: change name of spring cloud starter in serviceComb

2019-02-22 Thread GitBox 
coveralls commented on issue #1102: change name of spring cloud starter in 
serviceComb
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1102#issuecomment-466618662
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/21781728/badge)](https://coveralls.io/builds/21781728)
   
   Coverage decreased (-0.006%) to 85.431% when pulling 
**d1299e92d17df894f14f21d9e2b0524d76fa02df on yangshaoqin1:starter-rename** 
into **f3ec3889cedbb3c55be2d1dd60bf646da26ff3a5 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls edited a comment on issue #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
coveralls edited a comment on issue #537: SCB-1059 Add grpc keepalive time
URL: 
https://github.com/apache/servicecomb-service-center/pull/537#issuecomment-466321202
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/21804818/badge)](https://coveralls.io/builds/21804818)
   
   Coverage decreased (-0.05%) to 60.318% when pulling 
**88893364f78cba56c8fb02f147121fa9d4c51b74 on little-cui:etcd** into 
**e1c525cccfa020c9e65212326c76fc20df348cd6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io edited a comment on issue #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
codecov-io edited a comment on issue #537: SCB-1059 Add grpc keepalive time
URL: 
https://github.com/apache/servicecomb-service-center/pull/537#issuecomment-466320036
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=h1)
 Report
   > Merging 
[#537](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/e1c525cccfa020c9e65212326c76fc20df348cd6?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #537  +/-   ##
   ==
   + Coverage   57.99%   58.01%   +0.01% 
   ==
 Files 185  185  
 Lines   1478214784   +2 
   ==
   + Hits 8573 8577   +4 
 Misses   5613 5613  
   + Partials  596  594   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv)
 | `86.3% <100%> (+0.04%)` | :arrow_up: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `46.87% <0%> (-1.57%)` | :arrow_down: |
   | 
[server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv)
 | `53.47% <0%> (+0.26%)` | :arrow_up: |
   | 
[...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv)
 | `64.07% <0%> (+0.97%)` | :arrow_up: |
   | 
[server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv)
 | `90% <0%> (+10%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=footer).
 Last update 
[e1c525c...8889336](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls edited a comment on issue #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
coveralls edited a comment on issue #537: SCB-1059 Add grpc keepalive time
URL: 
https://github.com/apache/servicecomb-service-center/pull/537#issuecomment-466321202
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/21804235/badge)](https://coveralls.io/builds/21804235)
   
   Coverage increased (+0.04%) to 60.404% when pulling 
**f52f05c53a2844e494ddc86715a5412ec4b1a8f3 on little-cui:etcd** into 
**e1c525cccfa020c9e65212326c76fc20df348cd6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io edited a comment on issue #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
codecov-io edited a comment on issue #537: SCB-1059 Add grpc keepalive time
URL: 
https://github.com/apache/servicecomb-service-center/pull/537#issuecomment-466320036
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=h1)
 Report
   > Merging 
[#537](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/e1c525cccfa020c9e65212326c76fc20df348cd6?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#537  +/-   ##
   =
   + Coverage   57.99% 58%   +<.01% 
   =
 Files 185 185  
 Lines   14782   14784   +2 
   =
   + Hits 85738575   +2 
 Misses   56135613  
 Partials  596 596
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv)
 | `86.48% <100%> (+0.22%)` | :arrow_up: |
   | 
[server/notify/stream.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL25vdGlmeS9zdHJlYW0uZ28=)
 | `67.64% <0%> (-2.95%)` | :arrow_down: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `46.87% <0%> (-1.57%)` | :arrow_down: |
   | 
[server/service/util/domain\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==)
 | `61.19% <0%> (+1.49%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=footer).
 Last update 
[e1c525c...f52f05c](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1105: [SCB-1165] skip bridge method when generate operation swagger

2019-02-22 Thread GitBox 
wujimin commented on issue #1105: [SCB-1165] skip bridge method when generate 
operation swagger
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1105#issuecomment-466598405
 
 
   do you have a jira account?
   i will set "Assignee" to you, and close the task.
   
   https://issues.apache.org/jira/browse/SCB-1165


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin merged pull request #1105: [SCB-1165] skip bridge method when generate operation swagger

2019-02-22 Thread GitBox 
wujimin merged pull request #1105: [SCB-1165] skip bridge method when generate 
operation swagger
URL: https://github.com/apache/servicecomb-java-chassis/pull/1105
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-java-chassis] branch master updated: skip bridge method when generate operation swagger

2019-02-22 Thread wujimin 
This is an automated email from the ASF dual-hosted git repository.

wujimin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
 new 9b4580f  skip bridge method when generate operation swagger
9b4580f is described below

commit 9b4580fc1842cf217db1e57e2e387eba39901c38
Author: w00403123 
AuthorDate: Fri Feb 22 23:41:54 2019 +0800

skip bridge method when generate operation swagger

fix issus #1104
---
 .../apache/servicecomb/swagger/generator/core/SwaggerGenerator.java   | 4 
 1 file changed, 4 insertions(+)

diff --git 
a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/SwaggerGenerator.java
 
b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/SwaggerGenerator.java
index 919711e..f8178b6 100644
--- 
a/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/SwaggerGenerator.java
+++ 
b/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/SwaggerGenerator.java
@@ -249,6 +249,10 @@ public class SwaggerGenerator {
 if (Modifier.isStatic(modifiers)) {
   return true;
 }
+// skip bridge method
+if (method.isBridge()) {
+return true;
+}
 
 ApiOperation apiOperation = method.getAnnotation(ApiOperation.class);
 if (apiOperation != null && apiOperation.hidden()) {

[GitHub] wujimin commented on issue #1105: [SCB-1165] skip bridge method when generate operation swagger

2019-02-22 Thread GitBox 
wujimin commented on issue #1105: [SCB-1165] skip bridge method when generate 
operation swagger
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1105#issuecomment-466596228
 
 
   thanks for your PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] demonbug opened a new pull request #1105: [SCB-1165] skip bridge method when generate operation swagger

2019-02-22 Thread GitBox 
demonbug opened a new pull request #1105: [SCB-1165] skip bridge method when 
generate operation swagger
URL: https://github.com/apache/servicecomb-java-chassis/pull/1105
 
 
   fix issus #1104 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法

2019-02-22 Thread GitBox 
wujimin commented on issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1104#issuecomment-466430060
 
 
   https://issues.apache.org/jira/browse/SCB-1165


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1100: Rest over Servlet多profile情况下出现端口占用(Address already in use: JVM_Bind)

2019-02-22 Thread GitBox 
wujimin commented on issue #1100: Rest over Servlet多profile情况下出现端口占用(Address 
already in use: JVM_Bind)
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1100#issuecomment-466428817
 
 
   https://issues.apache.org/jira/browse/SCB-1164


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1100: Rest over Servlet多profile情况下出现端口占用(Address already in use: JVM_Bind)

2019-02-22 Thread GitBox 
wujimin commented on issue #1100: Rest over Servlet多profile情况下出现端口占用(Address 
already in use: JVM_Bind)
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1100#issuecomment-466420557
 
 
   port conflict is not a problem of ServiceComb
   
https://stackoverflow.com/questions/42249791/resolving-port-already-in-use-in-a-spring-boot-test-defined-port
   
   but after resolve this problem, a new problem is caused by ServiceComb:
   previous test case shutdown applicationContext and ServiceComb, but some 
resources in ServiceComb is static, will not init again, eg: 
org.apache.servicecomb.serviceregistry.client.http.HttpClientPool
   
   we will fix it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] myVictor closed issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。

2019-02-22 Thread GitBox 
myVictor closed issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。  
URL: https://github.com/apache/servicecomb-java-chassis/issues/1103
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] myVictor commented on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。

2019-02-22 Thread GitBox 
myVictor commented on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。  
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1103#issuecomment-466401963
 
 
   > you declare tracing-provider for Consumer, but it should be 
"tracing-consumer"
   谢了哈，是这个原因。
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法

2019-02-22 Thread GitBox 
wujimin commented on issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1104#issuecomment-466399605
 
 
   do you mind submit a PR for this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法

2019-02-22 Thread GitBox 
wujimin commented on issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1104#issuecomment-466398232
 
 
   yes, should filter such methods


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin edited a comment on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。

2019-02-22 Thread GitBox 
wujimin edited a comment on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。  
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1103#issuecomment-466391957
 
 
   i try this right now, there is no problem.
   
![image](https://user-images.githubusercontent.com/16874843/53244635-7122e100-36e6-11e9-9ddf-397d826e5621.png)
   
   
   maybe you missed declare zipkin in microservice.yaml, need to declare in all 
microservice.yaml?
   ```
 handler: 
   chain: 
 Consumer: 
   default: tracing-consumer,loadbalance
 Provider: 
   default: tracing-provider
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。

2019-02-22 Thread GitBox 
wujimin commented on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。  
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1103#issuecomment-466391957
 
 
   i try this right now, there is no problem.
   
![image](https://user-images.githubusercontent.com/16874843/53244635-7122e100-36e6-11e9-9ddf-397d826e5621.png)
   
   
   maybe you missed declare zipkin in microservice.yaml?
   ```
 handler: 
   chain: 
 Consumer: 
   default: tracing-consumer,loadbalance
 Provider: 
   default: tracing-provider
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] myVictor commented on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。

2019-02-22 Thread GitBox 
myVictor commented on issue #1103: 【求助】使用Edge Service在zipkin无法显示依赖关系。  
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1103#issuecomment-466374579
 
 
   
不好意思，我也是刚刚接触这个框架。我开始按照快速入门通过跑了demo程序（体质指数），然后通过zipkin监控页面查看依赖能显示一个依赖关系图。然后按照用户操作自己做了个Edge
 Service边缘服务，测试调用功能是没问题的。再看依赖关系没有关系图，但是通过查找可以发现有两个服务。
   
   另外所有的操作都是按照用户手册做的，我应该用的是handler-tracing对接zipkin的。下图是的边缘服务器配置。
   
![image](https://user-images.githubusercontent.com/7285684/53241566-f903ed80-36dc-11e9-9104-b7c841b87ac1.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
coveralls commented on issue #537: SCB-1059 Add grpc keepalive time
URL: 
https://github.com/apache/servicecomb-service-center/pull/537#issuecomment-466321202
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/21785083/badge)](https://coveralls.io/builds/21785083)
   
   Coverage decreased (-0.1%) to 60.234% when pulling 
**88cafd734ffc2ba9f4022399b513558b54a7313b on little-cui:etcd** into 
**e1c525cccfa020c9e65212326c76fc20df348cd6 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
codecov-io commented on issue #537: SCB-1059 Add grpc keepalive time
URL: 
https://github.com/apache/servicecomb-service-center/pull/537#issuecomment-466320036
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=h1)
 Report
   > Merging 
[#537](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/e1c525cccfa020c9e65212326c76fc20df348cd6?src=pr=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #537  +/-   ##
   ==
   - Coverage   57.99%   57.94%   -0.05% 
   ==
 Files 185  185  
 Lines   1478214784   +2 
   ==
   - Hits 8573 8567   -6 
   - Misses   5613 5620   +7 
   - Partials  596  597   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv)
 | `86.3% <100%> (+0.04%)` | :arrow_up: |
   | 
[server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==)
 | `69.44% <0%> (-9.73%)` | :arrow_down: |
   | 
[server/notify/stream.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL25vdGlmeS9zdHJlYW0uZ28=)
 | `67.64% <0%> (-2.95%)` | :arrow_down: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `46.87% <0%> (-1.57%)` | :arrow_down: |
   | 
[server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/537/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv)
 | `57.94% <0%> (+0.15%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=footer).
 Last update 
[e1c525c...88cafd7](https://codecov.io/gh/apache/servicecomb-service-center/pull/537?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] demonbug opened a new issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法

2019-02-22 Thread GitBox 
demonbug opened a new issue #1104: 生成契约时没有考虑继承泛型接口时生成的桥方法
URL: https://github.com/apache/servicecomb-java-chassis/issues/1104
 
 
   
https://github.com/apache/servicecomb-java-chassis/blob/f3ec3889cedbb3c55be2d1dd60bf646da26ff3a5/swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/SwaggerGenerator.java#L263
   
   public interface A extends B
   会生成
   A.xxx(C)和A.xxx(Object)两个方法，导致契约注册冲突


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] little-cui opened a new pull request #537: SCB-1059 Add grpc keepalive time

2019-02-22 Thread GitBox 
little-cui opened a new pull request #537: SCB-1059 Add grpc keepalive time
URL: https://github.com/apache/servicecomb-service-center/pull/537
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services