[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #432: [SCB-836] Update to support the nested SagaStart
zhfeng commented on a change in pull request #432: [SCB-836] Update to support
the nested SagaStart
URL: https://github.com/apache/servicecomb-pack/pull/432#discussion_r273769718
##
File path:
omega/omega-transaction/src/main/java/org/apache/servicecomb/pack/omega/transaction/SagaStartAspect.java
##
@@ -69,6 +69,9 @@ Object advise(ProceedingJoinPoint joinPoint, SagaStart
sagaStart) throws Throwab
}
private void initializeOmegaContext() {
+if (context.globalTxId() != null) {
+ context.setParentTxId(context.globalTxId());
+}
Review comment:
The other case is when parent saga is cancelled, it should cancel the nested
saga whenever it close before or not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #432: [SCB-836] Update to support the nested SagaStart
zhfeng commented on a change in pull request #432: [SCB-836] Update to support
the nested SagaStart
URL: https://github.com/apache/servicecomb-pack/pull/432#discussion_r273769481
##
File path:
omega/omega-transaction/src/main/java/org/apache/servicecomb/pack/omega/transaction/SagaStartAspect.java
##
@@ -69,6 +69,9 @@ Object advise(ProceedingJoinPoint joinPoint, SagaStart
sagaStart) throws Throwab
}
private void initializeOmegaContext() {
+if (context.globalTxId() != null) {
+ context.setParentTxId(context.globalTxId());
+}
Review comment:
No, I don't think so. The nested saga could be cancelled individually that
means it should have the different the globalTxId.
```
SagaStart (globalTxId = 1, localTxId = 1, parentTxId = null)
Nested SagaStart (globalTxId = 2, localTxId = 1, parentTxId = 1)
Cancel Nested Saga ( this could rollback the globalTxId = 2)
Close Saga ( this could close the globalTxId = 1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] coveralls commented on issue #452: [SCB-1247] Set default value in alpha.cluster.address on omega side
coveralls commented on issue #452: [SCB-1247] Set default value in alpha.cluster.address on omega side URL: https://github.com/apache/servicecomb-pack/pull/452#issuecomment-481504644 [](https://coveralls.io/builds/22709765) Coverage remained the same at 90.244% when pulling **a413f5eb10226a2e7fec7a97004631e8070af2ac on coolbeevip:SCB-1247** into **2e74500c34b0a7ba6e618a0a82a180d13674f2c4 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #1171: [SCB-1228][WIP][WEAK] swagger generator springmvc not depend on dynamic class
wujimin opened a new pull request #1171: [SCB-1228][WIP][WEAK] swagger generator springmvc not depend on dynamic class URL: https://github.com/apache/servicecomb-java-chassis/pull/1171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #1170: [SCB-1227][WIP][WEAK] swagger generator jar not depend on dynamic class
wujimin opened a new pull request #1170: [SCB-1227][WIP][WEAK] swagger generator jar not depend on dynamic class URL: https://github.com/apache/servicecomb-java-chassis/pull/1170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #452: [SCB-1247] Set default value in alpha.cluster.address on omega side
coolbeevip opened a new pull request #452: [SCB-1247] Set default value in alpha.cluster.address on omega side URL: https://github.com/apache/servicecomb-pack/pull/452 When no alpha.cluster.address is configured on the omega side, the default value is 0.0.0.0:8080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #1169: [SCB-1242][WIP][WEAK] spring data plugin
wujimin opened a new pull request #1169: [SCB-1242][WIP][WEAK] spring data plugin URL: https://github.com/apache/servicecomb-java-chassis/pull/1169 support generate model from Page interface and deserialize to page This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-java-chassis] branch weak-contract-type updated (af7cecf -> 3c8e66d)
This is an automated email from the ASF dual-hosted git repository. wujimin pushed a change to branch weak-contract-type in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git. discard af7cecf [SCB-1225][WIP][WEAK] fix by review comments discard 4e6edc6 [SCB-1225][WIP][WEAK] remove unnecessary dependency of spring discard 0e0c40e [SCB-1225][WIP][WEAK] update unit test cases discard c5b6ef1 [SCB-1225][WIP][WEAK] SPI definition switch to new mechanism discard a1bb656 [SCB-1225][WIP][WEAK] delete useless files discard c4be3d5 [SCB-1225][WIP][WEAK] create abstract rest mode generator discard b97d61a [SCB-1225][WIP][WEAK] create pojo mode generator discard acff5b3 [SCB-1225][WIP][WEAK] unit test utils switch to new mechanism discard 48c8c5b [SCB-1225][WIP][WEAK] response generator switch to new mechanism discard 3eb5d01 [SCB-1225][WIP][WEAK] parameter generator switch to new mechanism discard b22419c [SCB-1225][WIP][WEAK] class and method annotation switch to new mechanism discard a3d5542 [SCB-1225][WIP][WEAK] create basic generator implementation discard b3c95c1 [SCB-1225][WIP][WEAK] define new generator interfaces discard 060f2b1 [SCB-1225][WIP][WEAK] delete swagger to class logic discard a7770bf [SCB-1213][WIP][WEAK] swagger generator placeholder resolver not depend on spring discard b18fa3a [SC-1214][WIP][WEAK] change weak-contract-type branch version to weak-contract-type-SNAPSHOT new 72caa21 [SCB-1222] change groupId of "hibernate-validator" from "org.hibernate" to "org.hibernate.validator" to avoid dependency warning new 002ee16 Upgrade the maven license plugin version to fix the class not found exception new 680934e [SCB-1224] az affinity is conflict with empty instance protection new 9ad8150 [SCB-1224] az affinity is conflict with empty instance protection: fix as reviewed new 6878d34 [SCB-1230] avoid throw exception in httpClientResponse.exceptionHandler new 6188790 [SCB-1231] create endpoint metrics as early as possible new b4d355a [SCB-1231] add queue meter of http client connection pool new a81c092 [SCB-1231] publish queue meter of http client connection pool to log new 6d53ef2 [SCB-1226] there are problems when request rejected by thread pool queue full new 89c0628 [SCB-1232] make GroupExecutor configuration compatible to old version new 09eac45 Updated the year information of the NOTICE files new c92469a [SCB-1236] bugfix: BufferInputStream#read return value range should be -1~255, not the current -128-127 new c017ec9 [SCB-1236] code reivew change! new 576dd76 SCB-1218 Clean up the license of java-chassis new ec6a436 SCB-1218 Added the reactive-stream new a8345e9 SCB-1218 Try to fix the CI build error new 117e633 [SCB-1237] rollback compatible thread pool configuration logic new 9211e7b [SCB-1237] enhance jdk thread pool new e538f04 [SCB-1237] switch thread pool to new mechanism new 00de293 [SCB-1237] add thread pool reject metrics new 7c48e33 [SCB-1239] close thread after finish unit test case at once. new 7cd450b [SCB-1240] allowed one prometheus cluster support multiple apps new 286707c [SC-1214][WIP][WEAK] change weak-contract-type branch version to weak-contract-type-SNAPSHOT new 1dc3761 [SCB-1213][WIP][WEAK] swagger generator placeholder resolver not depend on spring new bb27a63 [SCB-1225][WIP][WEAK] delete swagger to class logic new 15c2199 [SCB-1225][WIP][WEAK] define new generator interfaces new 464a0ba [SCB-1225][WIP][WEAK] create basic generator implementation new f3a14bc [SCB-1225][WIP][WEAK] class and method annotation switch to new mechanism new 99330cf [SCB-1225][WIP][WEAK] parameter generator switch to new mechanism new aa26c03 [SCB-1225][WIP][WEAK] response generator switch to new mechanism new 5b79df1 [SCB-1225][WIP][WEAK] unit test utils switch to new mechanism new aa41582 [SCB-1225][WIP][WEAK] create pojo mode generator new beaafea [SCB-1225][WIP][WEAK] create abstract rest mode generator new 6cff5d3 [SCB-1225][WIP][WEAK] delete useless files new cbebf48 [SCB-1225][WIP][WEAK] SPI definition switch to new mechanism new 4d4b4ff [SCB-1225][WIP][WEAK] update unit test cases new 505eb6b [SCB-1225][WIP][WEAK] remove unnecessary dependency of spring new 3c8e66d [SCB-1225][WIP][WEAK] fix by review comments This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (af7cecf) \ N -- N -- N refs/heads/weak-contract-type (3c8e66d) You should already have received notification emails for all of the O
[servicecomb-java-chassis] branch weak-contract-type updated (a7770bf -> af7cecf)
This is an automated email from the ASF dual-hosted git repository.
liubao pushed a change to branch weak-contract-type
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git.
from a7770bf [SCB-1213][WIP][WEAK] swagger generator placeholder resolver
not depend on spring
new 060f2b1 [SCB-1225][WIP][WEAK] delete swagger to class logic
new b3c95c1 [SCB-1225][WIP][WEAK] define new generator interfaces
new a3d5542 [SCB-1225][WIP][WEAK] create basic generator implementation
new b22419c [SCB-1225][WIP][WEAK] class and method annotation switch to
new mechanism
new 3eb5d01 [SCB-1225][WIP][WEAK] parameter generator switch to new
mechanism
new 48c8c5b [SCB-1225][WIP][WEAK] response generator switch to new
mechanism
new acff5b3 [SCB-1225][WIP][WEAK] unit test utils switch to new mechanism
new b97d61a [SCB-1225][WIP][WEAK] create pojo mode generator
new c4be3d5 [SCB-1225][WIP][WEAK] create abstract rest mode generator
new a1bb656 [SCB-1225][WIP][WEAK] delete useless files
new c5b6ef1 [SCB-1225][WIP][WEAK] SPI definition switch to new mechanism
new 0e0c40e [SCB-1225][WIP][WEAK] update unit test cases
new 4e6edc6 [SCB-1225][WIP][WEAK] remove unnecessary dependency of spring
new af7cecf [SCB-1225][WIP][WEAK] fix by review comments
The 2190 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../config/inject/PlaceholderResolver.java | 9 +
.../apache/servicecomb/swagger/SwaggerUtils.java | 241 +-
.../swagger/converter/AbstractConverter.java | 46 --
.../servicecomb/swagger/converter/Converter.java | 26 --
.../swagger/converter/ConverterMgr.java| 191
.../swagger/converter/SwaggerToClassGenerator.java | 287
.../converter/model/AbstractModelConverter.java| 30 --
.../converter/model/ArrayModelConverter.java | 39 --
.../converter/model/ModelImplConverter.java| 108 -
.../swagger/converter/model/RefModelConverter.java | 31 --
.../AbstractSerializableParameterConverter.java| 52 ---
.../parameter/BodyParameterConverter.java | 34 --
.../converter/property/ArrayPropertyConverter.java | 51 ---
.../converter/property/MapPropertyConverter.java | 44 --
.../property/ObjectPropertyConverter.java | 30 --
.../converter/property/RefPropertyConverter.java | 31 --
.../property/StringPropertyConverter.java | 63 ---
.../property/SwaggerParamCollectionFormat.java | 102 -
.../swagger/extend/ModelResolverExt.java | 15 +-
.../extend/annotations/RawJsonRequestBody.java | 6 +-
.../introspector/JsonPropertyIntrospector.java | 2 +-
.../swagger/extend/parameter/ContextParameter.java | 26 --
.../extend/parameter/HttpRequestParameter.java | 23 -
...rocessor.java => ClassAnnotationProcessor.java} | 12 +-
...ocessor.java => MethodAnnotationProcessor.java} | 12 +-
.../OperationGenerator.java} | 18 +-
.../swagger/generator/ParameterGenerator.java | 112 +
.../swagger/generator/ParameterProcessor.java} | 34 +-
.../{core => }/ResponseTypeProcessor.java | 7 +-
.../swagger/generator/{core => }/SwaggerConst.java | 2 +-
.../swagger/generator/SwaggerContextRegister.java | 9 +-
.../swagger/generator/SwaggerGenerator.java| 69 +++
.../swagger/generator/SwaggerGeneratorFactory.java | 9 +-
.../swagger/generator/SwaggerGeneratorFeature.java | 62 +++
.../swagger/generator/SwaggerGeneratorUtils.java | 241 ++
.../generator/core/AbstractOperationGenerator.java | 493 +
...enerator.java => AbstractSwaggerGenerator.java} | 220 +
.../core/AbstractSwaggerGeneratorContext.java | 175
.../generator/core/AnnotationProcessorManager.java | 46 --
.../generator/core/ClassAnnotationProcessor.java | 22 -
.../core/CompositeSwaggerGeneratorContext.java | 54 ---
.../generator/core/DefaultParameterProcessor.java | 27 --
.../generator/core/MethodAnnotationProcessor.java | 22 -
.../swagger/generator/core/OperationGenerator.java | 453 ---
.../core/ParameterAnnotationProcessor.java | 23 -
.../generator/core/ParameterTypeProcessor.java | 22 -
.../generator/core/SwaggerGeneratorContext.java| 51 ---
.../generator/core/model/HttpParameterType.java| 27 +-
.../generator/core/model/SwaggerOperation.java | 42 +-
.../generator/core/model/SwaggerOperations.java| 72 +++
.../swagger/generator/core/package-info.java | 22 -
.../core/processor/annotation/AnnotationUtils.java | 136 +-
.../annotation/ApiImplicitParamClassProcessor.java | 34 --
.../ApiImplicitParamMethodProcessor.java | 34
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1157: [SCB-1225][WIP][WEAK] swagger generator core not depend on dynamic class
liubao68 merged pull request #1157: [SCB-1225][WIP][WEAK] swagger generator core not depend on dynamic class URL: https://github.com/apache/servicecomb-java-chassis/pull/1157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] wujimin commented on issue #1157: [SCB-1225][WIP][WEAK] swagger generator core not depend on dynamic class
wujimin commented on issue #1157: [SCB-1225][WIP][WEAK] swagger generator core not depend on dynamic class URL: https://github.com/apache/servicecomb-java-chassis/pull/1157#issuecomment-481488402 > What's the status of this PR? I see some compile errors and imcomplete code. all PR about "[WEAK]" is a new branch will can not compile for a long time, because core mechanism changed, need modify one by one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-pack] loveoobaby commented on issue #451: when use eureka, the ${alpha.cluster.address} must be set and can be arbitrary
loveoobaby commented on issue #451: when use eureka, the
${alpha.cluster.address} must be set and can be arbitrary
URL:
https://github.com/apache/servicecomb-pack/issues/451#issuecomment-481298810
I try to use pack through eureka and modified the booking project.
In the spring-booking project:
1. change the pom.xml, add omega-spring-cloud-eureka-starter dependency
2. change application.yaml config:
```
spring:
application:
name: booking
server:
port: 8081
alpha:
cluster:
#address: alpha-server.servicecomb.io:8080
register:
type: eureka
eureka:
client:
service-url:
defaultZone: http://127.0.0.1:8761/eureka
instance:
prefer-ip-address: true
```
I found the application can not be started where the config
${alpha.cluster.address} is deleted, and the value can be arbitrary value.
```
***
APPLICATION FAILED TO START
***
Description:
Parameter 0 of method compensableAnnotationProcessor in
org.apache.servicecomb.pack.omega.transaction.spring.TransactionAspectConfig
required a bean of type
'org.apache.servicecomb.pack.omega.context.OmegaContext' that could not be
found.
The following candidates were found but could not be injected:
- Bean method 'omegaContext' in 'OmegaSpringConfig' not loaded because
@ConditionalOnProperty (alpha.cluster.address) did not find property
'alpha.cluster.address'
```
the reason is that the bean OmegaSpringConfig need the key
${alpha.cluster.address} to be triggered, but the value is useless.And I
think in any mode(default, eureka, consul) this bean need to be created, and in
eureka, consul model this key is not need to be set, the value can be get from
registry center.
so, @ConditionalOnProperty(value = {"alpha.cluster.address"}) can be
deleted !
```
@Configuration
@ConditionalOnProperty(value = {"alpha.cluster.address"})
class OmegaSpringConfig {
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-pack] loveoobaby opened a new issue #451: when use eureka, the ${alpha.cluster.address} must be set and can be arbitrary
loveoobaby opened a new issue #451: when use eureka, the
${alpha.cluster.address} must be set and can be arbitrary
URL: https://github.com/apache/servicecomb-pack/issues/451
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1157: [SCB-1225][WIP][WEAK] swagger generator core not depend on dynamic class
liubao68 commented on issue #1157: [SCB-1225][WIP][WEAK] swagger generator core not depend on dynamic class URL: https://github.com/apache/servicecomb-java-chassis/pull/1157#issuecomment-481286684 What's the status of this PR? I see some compile errors and imcomplete code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch master updated: Update the src link for source release of SC (#168)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git The following commit(s) were added to refs/heads/master by this push: new 304af25 Update the src link for source release of SC (#168) 304af25 is described below commit 304af25e98737adac9b15480922ab7d7aab43f63 Author: Mohammad Asif Siddiqui AuthorDate: Tue Apr 9 14:39:44 2019 +0530 Update the src link for source release of SC (#168) --- _release/cn/service_center_downloads.md | 4 ++-- _release/service_center_downloads.md| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_release/cn/service_center_downloads.md b/_release/cn/service_center_downloads.md index 2ce418a..b6024f4 100644 --- a/_release/cn/service_center_downloads.md +++ b/_release/cn/service_center_downloads.md @@ -11,8 +11,8 @@ last_modified_at: 2019-04-06T00:50:43-55:00 | 版本号 | 源码| Windows版本 | Linux版本 | Darwin版本 | 与之兼容的Java-Chassis版本 | | -- | - | - | - | - |- | -| **Apache ServiceComb Service-Center 1.2.0 (LATEST)** |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz.sha512) | [[Binary]](https://a [...] -| Apache ServiceComb Service-Center 1.1.0 |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip.sha512) | [[Binary]](htt [...] +| **Apache ServiceComb Service-Center 1.2.0 (LATEST)** |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz.sha512) | [[Binary [...] +| Apache ServiceComb Service-Center 1.1.0 |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz.sha512) | [[Bin [...] | Apache ServiceComb (incubating) Service-Center 1.0.0 | [[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0/apache-servicecomb-incubating-service-center-1.0.0-src.zip) [[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0/apache-servicecomb-incubating-service-center-1.0.0-src.zip.asc) [[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-cen [...] | Apache ServiceComb (incubating) Service-Center 1.0.0-m2| [[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m2/apache-servicecomb-incubating-service-center-1.0.0-m2-src.zip) [[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m2/apache-servicecomb-incubating-service-center-1.0.0-m2-src.zip.asc) [[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb [...] | Apache ServiceComb (incubating) Service-Center 1.0.0-m1| [[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/apache-servicecomb-incubating-service-center-1.0.0-m1-src.zip) [[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/apache-servicecomb-incubating-service-center-1.0.0-m1-src.zip.asc) [[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb [...] diff --git a/_release/service_center_downloads.md b/_release/service_center_downloads.md index
[servicecomb-website] branch asf-site updated: Publish the website
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a12589a Publish the website a12589a is described below commit a12589ae78aca25b902a208d14b526f9262de9ae Author: Willem Jiang AuthorDate: Tue Apr 9 17:17:33 2019 +0800 Publish the website --- content/cn/release/service-center-downloads/index.html | 4 ++-- content/feed.xml | 2 +- content/release/service-center-downloads/index.html| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/content/cn/release/service-center-downloads/index.html b/content/cn/release/service-center-downloads/index.html index dd31344..ddb5716 100644 --- a/content/cn/release/service-center-downloads/index.html +++ b/content/cn/release/service-center-downloads/index.html @@ -439,7 +439,7 @@ Apache ServiceComb Service-Center 1.2.0 (LATEST) - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz;>[src] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz.sha512;>[sha512] + https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz;>[src] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz.sha512;>[sha512] https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-windows-amd64.tar.gz;>[Binary] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-windows-amd64.tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-windows-amd64.tar.gz.sha512;>[sha512] https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-linux-amd64.tar.gz;>[Binary] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-linux-amd64.tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-linux-amd64.tar.gz.sha512;>[sha512] https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-darwin-amd64.tar.gz;>[Binary] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-darwin-amd64.tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-darwin-amd64.tar.gz.sha512;>[sha512] @@ -447,7 +447,7 @@ Apache ServiceComb Service-Center 1.1.0 - https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip;>[src] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip.sha512;>[sha512] + https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz;>[src] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz.sha512;>[sha512] https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-windows-amd64.tar.gz;>[Binary] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-windows-amd64.tar.gz.asc;>[asc] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-windows-amd64.tar.gz.sha512;>[sha512] https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-linux-amd64.tar.gz;>[Binary] https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-linux-amd64.tar.gz.asc;>[asc]
[GitHub] [servicecomb-website] WillemJiang merged pull request #168: Update the src link for source release of SC
WillemJiang merged pull request #168: Update the src link for source release of SC URL: https://github.com/apache/servicecomb-website/pull/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[servicecomb-website] branch asf-site updated: Update the src link for source release of SC (#168)
This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5202596 Update the src link for source release of SC (#168) 5202596 is described below commit 52025966b22ba4f66b115f802d00455dd457aced Author: Mohammad Asif Siddiqui AuthorDate: Tue Apr 9 14:39:44 2019 +0530 Update the src link for source release of SC (#168) --- _release/cn/service_center_downloads.md | 4 ++-- _release/service_center_downloads.md| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_release/cn/service_center_downloads.md b/_release/cn/service_center_downloads.md index 2ce418a..b6024f4 100644 --- a/_release/cn/service_center_downloads.md +++ b/_release/cn/service_center_downloads.md @@ -11,8 +11,8 @@ last_modified_at: 2019-04-06T00:50:43-55:00 | 版本号 | 源码| Windows版本 | Linux版本 | Darwin版本 | 与之兼容的Java-Chassis版本 | | -- | - | - | - | - |- | -| **Apache ServiceComb Service-Center 1.2.0 (LATEST)** |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-tar.gz.sha512) | [[Binary]](https://a [...] -| Apache ServiceComb Service-Center 1.1.0 |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.zip.sha512) | [[Binary]](htt [...] +| **Apache ServiceComb Service-Center 1.2.0 (LATEST)** |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.2.0/apache-servicecomb-service-center-1.2.0-src.tar.gz.sha512) | [[Binary [...] +| Apache ServiceComb Service-Center 1.1.0 |[[src]](https://apache.org/dyn/closer.cgi/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz) [[asc]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz.asc) [[sha512]](https://www.apache.org/dist/servicecomb/servicecomb-service-center/1.1.0/apache-servicecomb-service-center-1.1.0-src.tar.gz.sha512) | [[Bin [...] | Apache ServiceComb (incubating) Service-Center 1.0.0 | [[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0/apache-servicecomb-incubating-service-center-1.0.0-src.zip) [[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0/apache-servicecomb-incubating-service-center-1.0.0-src.zip.asc) [[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-cen [...] | Apache ServiceComb (incubating) Service-Center 1.0.0-m2| [[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m2/apache-servicecomb-incubating-service-center-1.0.0-m2-src.zip) [[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m2/apache-servicecomb-incubating-service-center-1.0.0-m2-src.zip.asc) [[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb [...] | Apache ServiceComb (incubating) Service-Center 1.0.0-m1| [[src]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/apache-servicecomb-incubating-service-center-1.0.0-m1-src.zip) [[asc]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/apache-servicecomb-incubating-service-center-1.0.0-m1-src.zip.asc) [[sha512]](http://archive.apache.org/dist/incubator/servicecomb/incubator-servicecomb [...] diff --git a/_release/service_center_downloads.md b/_release/service_center_downloads.md index
[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1158: [SCB-1229] update the version of dependency
coveralls edited a comment on issue #1158: [SCB-1229] update the version of dependency URL: https://github.com/apache/servicecomb-java-chassis/pull/1158#issuecomment-478223001 [](https://coveralls.io/builds/22689312) Coverage decreased (-0.005%) to 85.671% when pulling **ba658841f81e3c38817aaf99ccd11565e937a334 on heyile:updateDependency** into **7cd450b87e77d438a23a7c1e603ae660991ad48a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-website] asifdxtreme opened a new pull request #168: Update the src link for source release of SC
asifdxtreme opened a new pull request #168: Update the src link for source release of SC URL: https://github.com/apache/servicecomb-website/pull/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile closed pull request #1158: [SCB-1229] update the version of dependency
heyile closed pull request #1158: [SCB-1229] update the version of dependency URL: https://github.com/apache/servicecomb-java-chassis/pull/1158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile opened a new pull request #1158: [SCB-1229] update the version of dependency
heyile opened a new pull request #1158: [SCB-1229] update the version of dependency URL: https://github.com/apache/servicecomb-java-chassis/pull/1158 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [servicecomb-java-chassis] heyile commented on a change in pull request #1158: [SCB-1229] update the version of dependency
heyile commented on a change in pull request #1158: [SCB-1229] update the version of dependency URL: https://github.com/apache/servicecomb-java-chassis/pull/1158#discussion_r273345916 ## File path: foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/http/TestReadStreamPart.java ## @@ -186,7 +187,7 @@ public void saveToFile() throws InterruptedException, ExecutionException, IOExce part.saveToFile(file.getAbsolutePath()).get(); -Assert.assertEquals(src, FileUtils.readFileToString(file)); +Assert.assertEquals(src, FileUtils.readFileToString(file, Charset.defaultCharset())); Review comment: done. replace all defaultCharset with UTF_8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
