[GitHub] [servicecomb-pack] coveralls commented on issue #566: [SCB-1502] Code Cleanup

2019-10-01 Thread GitBox
coveralls commented on issue #566: [SCB-1502] Code Cleanup
URL: https://github.com/apache/servicecomb-pack/pull/566#issuecomment-537346020
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/26057903/badge)](https://coveralls.io/builds/26057903)
   
   Coverage increased (+0.09%) to 80.819% when pulling 
**0f404d3e063eebcccec2fa3bc3ddce1e1c6abd70 on coolbeevip:SCB-1502** into 
**ecc48a18b68be644b97d394130277eda862d0b35 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #566: [SCB-1502] Code Cleanup

2019-10-01 Thread GitBox
coolbeevip opened a new pull request #566: [SCB-1502] Code Cleanup
URL: https://github.com/apache/servicecomb-pack/pull/566
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[servicecomb-pack] branch master updated: [SCB-1501] Improvement UnitTest for Travis CI (#565)

2019-10-01 Thread ningjiang
This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git


The following commit(s) were added to refs/heads/master by this push:
 new ecc48a1  [SCB-1501] Improvement UnitTest for Travis CI (#565)
ecc48a1 is described below

commit ecc48a18b68be644b97d394130277eda862d0b35
Author: Lei Zhang 
AuthorDate: Tue Oct 1 22:35:11 2019 +0800

[SCB-1501] Improvement UnitTest for Travis CI (#565)

* SCB-1439 Modify batchSize default value is 1000

* SCB-1501 Improvement UnitTest for Travis CI
---
 .../apache/servicecomb/pack/integration/tests/PackIT.java| 12 ++--
 .../pack/integration/tests/TxEventEnvelopeRepository.java|  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/PackIT.java
 
b/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/PackIT.java
index 4b89439..dd5fe08 100644
--- 
a/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/PackIT.java
+++ 
b/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/PackIT.java
@@ -21,7 +21,7 @@ import static java.util.concurrent.TimeUnit.SECONDS;
 import static org.awaitility.Awaitility.await;
 import static org.hamcrest.CoreMatchers.notNullValue;
 import static org.hamcrest.CoreMatchers.nullValue;
-import static org.hamcrest.Matchers.contains;
+import static org.hamcrest.Matchers.greaterThanOrEqualTo;
 import static org.hamcrest.core.Is.is;
 import static org.junit.Assert.assertThat;
 import static org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR;
@@ -85,7 +85,7 @@ public class PackIT {
 assertThat(entity.getBody(), is("Greetings, mike; Bonjour, mike"));
 
 List distinctGlobalTxIds = eventRepo.findDistinctGlobalTxId();
-assertThat(distinctGlobalTxIds.size(), is(1));
+assertThat(distinctGlobalTxIds.size(), greaterThanOrEqualTo(1));
 
 String globalTxId = distinctGlobalTxIds.get(0);
 List events = 
eventRepo.findByGlobalTxIdOrderByCreationTime(globalTxId);
@@ -148,7 +148,7 @@ public class PackIT {
 await().atMost(2, SECONDS).until(() -> eventRepo.count() == 7);
 
 List distinctGlobalTxIds = eventRepo.findDistinctGlobalTxId();
-assertThat(distinctGlobalTxIds.size(), is(1));
+assertThat(distinctGlobalTxIds.size(), greaterThanOrEqualTo(1));
 
 String globalTxId = distinctGlobalTxIds.get(0);
 List events = 
eventRepo.findByGlobalTxIdOrderByCreationTime(globalTxId);
@@ -213,7 +213,7 @@ public class PackIT {
 assertThat(entity.getBody(), is("Good morning, Bonjour, mike"));
 
 List distinctGlobalTxIds = eventRepo.findDistinctGlobalTxId();
-assertThat(distinctGlobalTxIds.size(), is(1));
+assertThat(distinctGlobalTxIds.size(), greaterThanOrEqualTo(1));
 
 String globalTxId = distinctGlobalTxIds.get(0);
 List events = 
eventRepo.findByGlobalTxIdOrderByCreationTime(globalTxId);
@@ -262,7 +262,7 @@ public class PackIT {
 await().atMost(5, SECONDS).until(() -> eventRepo.count() == 8);
 
 List distinctGlobalTxIds = eventRepo.findDistinctGlobalTxId();
-assertThat(distinctGlobalTxIds.size(), is(1));
+assertThat(distinctGlobalTxIds.size(), greaterThanOrEqualTo(1));
 
 String globalTxId = distinctGlobalTxIds.get(0);
 List events = 
eventRepo.findByGlobalTxIdOrderByCreationTime(globalTxId);
@@ -293,7 +293,7 @@ public class PackIT {
 await().atMost(10, SECONDS).until(() -> eventRepo.count() == 11);
 
 List distinctGlobalTxIds = eventRepo.findDistinctGlobalTxId();
-assertThat(distinctGlobalTxIds.size(), is(1));
+assertThat(distinctGlobalTxIds.size(), greaterThanOrEqualTo(1));
 
 String globalTxId = distinctGlobalTxIds.get(0);
 List events = 
eventRepo.findByGlobalTxIdOrderByCreationTime(globalTxId);
diff --git 
a/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/TxEventEnvelopeRepository.java
 
b/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/TxEventEnvelopeRepository.java
index 6484e2f..b09ee24 100644
--- 
a/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/TxEventEnvelopeRepository.java
+++ 
b/integration-tests/pack-tests/src/test/java/org/apache/servicecomb/pack/integration/tests/TxEventEnvelopeRepository.java
@@ -26,6 +26,6 @@ import org.springframework.data.repository.CrudRepository;
 interface TxEventEnvelopeRepository extends CrudRepository {
   List findByGlobalTxIdOrderByCreationTime(String globalTxId);
 
-  @Query("SELECT DISTINCT(e.globalTxId) from TxEvent e")
+  @Query("SELECT DISTINCT(e.globalTxId) from TxEvent e order by e.creationTime 
desc")
   List findDistinctGlobalTxId();
 }



[GitHub] [servicecomb-pack] WillemJiang merged pull request #565: [SCB-1501] Improvement UnitTest for Travis CI

2019-10-01 Thread GitBox
WillemJiang merged pull request #565: [SCB-1501] Improvement UnitTest for 
Travis CI
URL: https://github.com/apache/servicecomb-pack/pull/565
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services