date:20200317

[GitHub] [servicecomb-java-chassis] WillemJiang commented on issue #1641: [SCB-1805]clear some unused 3rd party software

2020-03-17 Thread GitBox

WillemJiang commented on issue #1641: [SCB-1805]clear some unused 3rd party 
software
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1641#issuecomment-600425436
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

coveralls edited a comment on issue #1638: [SCB-1803] kie support long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#issuecomment-600400558
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/29434080/badge)](https://coveralls.io/builds/29434080)
   
   Coverage increased (+0.004%) to 84.771% when pulling 
**edb82d2b1565bcd366d9901ff017f2def82abf4c on GuoYL123:kie-l** into 
**192e4acde4554e7faaf2cf1273a5e6aa8a549e38 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

coveralls edited a comment on issue #1638: [SCB-1803] kie support long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#issuecomment-600400558
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/29434041/badge)](https://coveralls.io/builds/29434041)
   
   Coverage increased (+0.001%) to 84.769% when pulling 
**edb82d2b1565bcd366d9901ff017f2def82abf4c on GuoYL123:kie-l** into 
**192e4acde4554e7faaf2cf1273a5e6aa8a549e38 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

coveralls commented on issue #1638: [SCB-1803] kie support long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#issuecomment-600400558
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/29434017/badge)](https://coveralls.io/builds/29434017)
   
   Coverage increased (+0.006%) to 84.774% when pulling 
**edb82d2b1565bcd366d9901ff017f2def82abf4c on GuoYL123:kie-l** into 
**192e4acde4554e7faaf2cf1273a5e6aa8a549e38 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

GuoYL123 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r394077504
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -140,23 +160,23 @@ void refreshConfig() {
 e.getMessage());
   }
 });
-// latch.countDown();
   } else if (rsp.statusCode() == HttpStatus.SC_NOT_FOUND) {
 EventManager.post(new ConnSuccEvent());
-//latch.countDown();
   } else {
 EventManager.post(new ConnFailEvent("fetch config fail"));
 LOGGER.error("Config update from {} failed. Error message is 
[{}].",
 serviceUri,
 rsp.statusMessage());
   }
+  if (enableLongPolling) {
 
 Review comment:
   first time also need this code 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

GuoYL123 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r394077313
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -114,17 +129,22 @@ public void run() {
   }
 }
 
-//todo : latch down
 @SuppressWarnings("deprecation")
 void refreshConfig() {
   String path = "/v1/"
   + KieConfig.INSTANCE.getDomainName()
   + "/kie/kv?label=app:"
   + KieConfig.INSTANCE.getAppName();
+  if (!IS_FIRST_PULL.get()) {
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

GuoYL123 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r394077261
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -48,16 +49,27 @@
 
   private static final Logger LOGGER = 
LoggerFactory.getLogger(KieClient.class);
 
-  private ScheduledExecutorService EXECUTOR = 
Executors.newScheduledThreadPool(1);
+  private ScheduledExecutorService EXECUTOR = 
Executors.newScheduledThreadPool(1, (r) -> {
+Thread thread = new Thread(r);
+thread.setName("org.apache.servicecomb.config.kie");
+thread.setDaemon(true);
+return thread;
+  });
 
   private static final long TIME_OUT = 1;
 
+  private static AtomicBoolean IS_FIRST_PULL = new AtomicBoolean(true);
+
+  private static final int LONG_POLLING_WAIT_TIME = 30;
 
 Review comment:
   After checking , vert.x default strategy is never timeout. I set the idle 
timeout 50s.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1628: [SCB-1796] support client outlog

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1628: [SCB-1796] support client 
outlog
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1628#discussion_r394069263
 
 

 ##
 File path: 
foundations/foundation-log/src/main/java/org/apache/servicecomb/foundation/log/core/element/LogItem.java
 ##
 @@ -15,17 +15,22 @@
  * limitations under the License.
  */
 
-package org.apache.servicecomb.transport.rest.vertx.accesslog.element;
+package org.apache.servicecomb.foundation.log.core.element;
 
-import org.apache.servicecomb.transport.rest.vertx.accesslog.AccessLogParam;
+import org.apache.servicecomb.core.event.InvocationFinishEvent;
+import org.apache.servicecomb.core.event.ServerAccessLogEvent;
 
 /*
  * Access log item represents the items supported in access log printing.
  * It generate the segment of access log according to {@link AccessLogParam}
  */
-public interface AccessLogItem {
+public interface LogItem {
 
 Review comment:
   Server access log and request log can both called AccessLog. Log is a 
general name may be confusing with any application trace. I'd prefer using 
AccessLogItem. And 'servicecomb.assesslog.request` as the configuration. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1628: [SCB-1796] support client outlog

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1628: [SCB-1796] support client 
outlog
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1628#discussion_r394068663
 
 

 ##
 File path: 
foundations/foundation-log/src/main/java/org/apache/servicecomb/foundation/log/LogConfig.java
 ##
 @@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.foundation.log;
+
+import com.netflix.config.DynamicPropertyFactory;
+
+public class LogConfig {
+
+private static final String SERVER_BASE = "servicecomb.accesslog.";
+
+private static final String CLIENT_BASE = "servicecomb.outlog.";
 
 Review comment:
   `servervicomb.request.log`  or `servicecomb.accesslog.request` is better, 
see 
'https://sling.apache.org/documentation/development/client-request-logging.html'
 for reference. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1628: [SCB-1796] support client outlog

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1628: [SCB-1796] support client 
outlog
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1628#discussion_r394067836
 
 

 ##
 File path: foundations/foundation-log/pom.xml
 ##
 @@ -0,0 +1,41 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  
+foundations
+org.apache.servicecomb
+2.0.1-SNAPSHOT
+  
+  4.0.0
+
+  foundation-log
+  Java Chassis::Foundations::Log
+
+  
 
 Review comment:
   It's better to create a module `common-access-log` in common folder. Because 
the dependency is core <- common <- foundation. Foundation can not dependent on 
common. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on a change in pull request #1623: [SCB-1795] when use query object, sdk don't support fluent setter

2020-03-17 Thread GitBox

heyile commented on a change in pull request #1623: [SCB-1795] when use query 
object, sdk don't support fluent setter
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1623#discussion_r394065466
 
 

 ##
 File path: integration-tests/it-edge/src/main/resources/microservice.yaml
 ##
 @@ -128,6 +136,8 @@ servicecomb:
   transport: rest
   paramCodecRestOnly:
 transport: rest
+  SpringMVCObjectParamTypeSchema:
 
 Review comment:
   quryObjectTest in  Spring MVC doesn't support highway


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile edited a comment on issue #1635: ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题

2020-03-17 Thread GitBox

heyile edited a comment on issue #1635: 
ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1635#issuecomment-600375696
 
 
   这个我在本地试了一把. 启动没问题.. 没复现你的效果, 你手写的契约是不是 **写错了** ...
   
   ```java
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Person(), HttpStatus.OK);
   return response;
 }
   
   ```
   
   **swagger 契约**
   
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   $ref: "#/definitions/Person"
   
   ```
   
   java 如下:
   
   ```
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Object(), HttpStatus.OK);
   return response;
 }
   ```
   swagger 契约
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   type: "object"
   
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile edited a comment on issue #1635: ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题

2020-03-17 Thread GitBox

heyile edited a comment on issue #1635: 
ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1635#issuecomment-600375696
 
 
   这个我在本地试了一把. 启动没问题.. 没复现你的效果.
   
   ```java
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Person(), HttpStatus.OK);
   return response;
 }
   
   ```
   
   **swagger 契约**
   
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   $ref: "#/definitions/Person"
   
   ```
   
   java 如下:
   
   ```
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Object(), HttpStatus.OK);
   return response;
 }
   ```
   swagger 契约
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   type: "object"
   
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile edited a comment on issue #1635: ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题

2020-03-17 Thread GitBox

heyile edited a comment on issue #1635: 
ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1635#issuecomment-600375696
 
 
   这个我在本地试了一把. 启动没问题.. 没复现你的效果.
   
   ```java
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Person(), HttpStatus.OK);
   return response;
 }
   
   ```
   
   **swagger 契约**
   
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   $ref: "#/definitions/Person"
   
   ```
   
   java 如下:
   
   ```
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Person(), HttpStatus.OK);
   return response;
 }
   ```
   swagger 契约
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   type: "object"
   
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on issue #1635: ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题

2020-03-17 Thread GitBox

heyile commented on issue #1635: ConvertCommon转换微服务接口的返回值时失败，使用ConvertSame无此问题
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1635#issuecomment-600375696
 
 
   这个我在本地试了一把. 启动没问题.. 没复现你的效果.
   
   ```java
   
 @RequestMapping(value = "/v2/ping", method = RequestMethod.POST, produces 
= "application/json")
 public ResponseEntity ping(@RequestHeader(name = "sess") String 
sessionId) {
   
   ResponseEntity response =
   new ResponseEntity(new Person(), HttpStatus.OK);
   return response;
 }
   
   ```
   
   **swagger 契约**
   
   ```
 /v2/ping:
   post:
 operationId: "ping"
 produces:
 - "application/json"
 parameters:
 - name: "sess"
   in: "header"
   required: true
   type: "string"
 responses:
   "200":
 description: "response of 200"
 schema:
   $ref: "#/definitions/Person"
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1628: [SCB-1796] support client outlog

2020-03-17 Thread GitBox

coveralls edited a comment on issue #1628: [SCB-1796] support client outlog
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1628#issuecomment-600116037
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/29420988/badge)](https://coveralls.io/builds/29420988)
   
   Coverage decreased (-0.08%) to 84.683% when pulling 
**62b72298c23a81bb70d6ffb3f49e5da34182814f on heyile:scb-1796** into 
**192e4acde4554e7faaf2cf1273a5e6aa8a549e38 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1628: [SCB-1796] support client outlog

2020-03-17 Thread GitBox

coveralls commented on issue #1628: [SCB-1796] support client outlog
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1628#issuecomment-600116037
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/29420328/badge)](https://coveralls.io/builds/29420328)
   
   Coverage decreased (-0.08%) to 84.683% when pulling 
**62b72298c23a81bb70d6ffb3f49e5da34182814f on heyile:scb-1796** into 
**192e4acde4554e7faaf2cf1273a5e6aa8a549e38 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2

2020-03-17 Thread GitBox

liubao68 commented on issue #1632:  [SCB-1797] Fix marker leak problem when 
using slf4j1.8 or higher with log4j2
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-600060422
 
 
   > I am not familiar with higher version of JDK, do you mean better solution 
that not using reflection?
   
   Yes. I am thinking some others ways to adress this problem tomorrow.  The 
recent PR has removed log4j2 fixs to a seperate module. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1641: [SCB-1805]clear some unused 3rd party software

2020-03-17 Thread GitBox

liubao68 opened a new pull request #1641: [SCB-1805]clear some unused 3rd party 
software
URL: https://github.com/apache/servicecomb-java-chassis/pull/1641
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-java-chassis] 01/02: [SCB-1804]anylyse updating commons-configuration and archairus

2020-03-17 Thread liubao

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git

commit c4e16a1af3474ec1ffbb1194dcd8d5e712fa54ed
Author: liubao 
AuthorDate: Tue Mar 17 15:44:31 2020 +0800

[SCB-1804]anylyse updating commons-configuration and archairus
---
 dependencies/default/pom.xml | 2 +-
 distribution/src/release/LICENSE | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dependencies/default/pom.xml b/dependencies/default/pom.xml
index 6149017..7976bb1 100644
--- a/dependencies/default/pom.xml
+++ b/dependencies/default/pom.xml
@@ -32,7 +32,7 @@
 
   
 
-0.7.6
+0.7.7
 1.6.2
 1.9.3
 3.0.0
diff --git a/distribution/src/release/LICENSE b/distribution/src/release/LICENSE
index 36ca61f..c6dcba6 100644
--- a/distribution/src/release/LICENSE
+++ b/distribution/src/release/LICENSE
@@ -473,7 +473,7 @@ For details, see their respective project links.
 * Apache Log4j API (org.apache.logging.log4j:log4j-api:2.11.2 - 
https://logging.apache.org/log4j/2.x/log4j-api/)
 * Apache Log4j Core (org.apache.logging.log4j:log4j-core:2.11.2 - 
https://logging.apache.org/log4j/2.x/log4j-core/)
 * Apache Log4j SLF4J Binding (org.apache.logging.log4j:log4j-slf4j-impl:2.11.2 
- https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/)
-* archaius-core (com.netflix.archaius:archaius-core:0.7.6 - 
https://github.com/Netflix/archaius)
+* archaius-core (com.netflix.archaius:archaius-core:0.7.7 - 
https://github.com/Netflix/archaius)
 * asciidoctorj (org.asciidoctor:asciidoctorj:1.6.2 - 
https://github.com/asciidoctor/asciidoctorj)
 * asciidoctorj-api (org.asciidoctor:asciidoctorj-api:1.6.2 - 
https://github.com/asciidoctor/asciidoctorj)
 * Awaitility (org.awaitility:awaitility:3.0.0 - http://awaitility.org)
@@ -611,7 +611,6 @@ For details, see their respective project links.
 * Spring Cloud Netflix Core 
(org.springframework.cloud:spring-cloud-netflix-core:2.1.0.RELEASE - 
https://spring.io/spring-cloud/spring-cloud-netflix/spring-cloud-netflix-core)
 * spring-cloud-starter 
(org.springframework.cloud:spring-cloud-starter:2.1.0.RELEASE - 
https://projects.spring.io/spring-cloud)
 * spring-cloud-starter-gateway 
(org.springframework.cloud:spring-cloud-starter-gateway:2.1.0.RELEASE - 
https://projects.spring.io/spring-cloud)
-* Spring Cloud Starter Netflix Archaius 
(org.springframework.cloud:spring-cloud-starter-netflix-archaius:2.1.0.RELEASE 
- https://projects.spring.io/spring-cloud)
 * Spring Cloud Starter Netflix Hystrix 
(org.springframework.cloud:spring-cloud-starter-netflix-hystrix:2.1.0.RELEASE - 
https://projects.spring.io/spring-cloud)
 * Spring Cloud Starter Netflix Ribbon 
(org.springframework.cloud:spring-cloud-starter-netflix-ribbon:2.1.0.RELEASE - 
https://projects.spring.io/spring-cloud)
 * Spring Cloud Starter Netflix Zuul 
(org.springframework.cloud:spring-cloud-starter-netflix-zuul:2.1.0.RELEASE - 
https://projects.spring.io/spring-cloud)

[servicecomb-java-chassis] branch master updated (5c102a8 -> 192e4ac)

2020-03-17 Thread liubao

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git.


from 5c102a8  [SCB-1800]log4j is deprecated package, make log4j 
implementaions optional
 new c4e16a1  [SCB-1804]anylyse updating commons-configuration and archairus
 new 192e4ac  [SCB-1804] fix random fail test case

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 dependencies/default/pom.xml   |  2 +-
 distribution/src/release/LICENSE   |  3 +--
 .../client/http/TestServiceRegistryClientImpl.java | 14 +-
 3 files changed, 15 insertions(+), 4 deletions(-)

[servicecomb-java-chassis] 02/02: [SCB-1804] fix random fail test case

2020-03-17 Thread liubao

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git

commit 192e4acde4554e7faaf2cf1273a5e6aa8a549e38
Author: liubao 
AuthorDate: Tue Mar 17 16:54:56 2020 +0800

[SCB-1804] fix random fail test case
---
 .../client/http/TestServiceRegistryClientImpl.java | 14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git 
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestServiceRegistryClientImpl.java
 
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestServiceRegistryClientImpl.java
index 61c179d..5c6384c 100644
--- 
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestServiceRegistryClientImpl.java
+++ 
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestServiceRegistryClientImpl.java
@@ -147,7 +147,11 @@ public class TestServiceRegistryClientImpl {
   }.getMockInstance();
   rootLogger.addAppender(appender);
 
-  doRun(events);
+  try {
+doRun(events);
+  } catch (Throwable e) {
+e.printStackTrace();
+  }
 
   rootLogger.removeAppender(appender);
 }
@@ -175,6 +179,14 @@ public class TestServiceRegistryClientImpl {
 
   @Test
   public void testRegisterSchemaException() {
+new MockUp() {
+  @Mock
+  void put(IpPort ipPort, String uri, RequestParam requestParam,
+  Handler responseHandler) {
+// do nothing to mock null response
+  }
+};
+
 InterruptedException e = new InterruptedException();
 new MockUp() {
   @Mock

[servicecomb-java-chassis] branch master updated (6f566b5 -> 5c102a8)

2020-03-17 Thread liubao

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git.


from 6f566b5  [SCB-1799]add back 
servicecomb.service.registry.registerUrlPrefix
 add 5c102a8  [SCB-1800]log4j is deprecated package, make log4j 
implementaions optional

No new revisions were added by this update.

Summary of changes:
 .../org/apache/servicecomb/core/SCBEngine.java |  4 ---
 demo/demo-crossapp/pom.xml |  6 
 demo/demo-edge/pom.xml |  8 ++
 demo/demo-jaxrs/pom.xml|  7 -
 demo/demo-multiple/pom.xml |  4 +++
 demo/demo-pojo/pom.xml |  7 -
 .../springboot/jaxrs/client/JaxrsClient.java   |  2 --
 .../springboot/jaxrs/server/JaxrsServer.java   |  2 --
 .../springmvc/client/SpringmvcClient.java  |  2 --
 .../springmvc/server/SpringmvcServer.java  |  1 -
 .../springboot/pojo/client/PojoClient.java |  2 --
 .../springboot/pojo/server/PojoServer.java |  2 --
 demo/demo-springmvc/pom.xml|  7 -
 dependencies/default/pom.xml   | 10 +++
 distribution/pom.xml   |  8 ++
 .../edge/core/TestURLMappedEdgeDispatcher.java |  2 --
 foundations/foundation-common/pom.xml  | 23 ++--
 .../foundation-log4j}/pom.xml  | 20 +-
 .../foundation/common/utils/Log4jUtils.java|  0
 .../common/utils/RollingFileAppenderExt.java   |  0
 .../foundation/common/utils/Log4jUtilsTest.java|  0
 .../common/utils/TestRollingFileAppenderExt.java   |  0
 .../foundation-log4j2}/pom.xml | 15 +-
 .../common/log/LogMarkerLeakFixUtils.java  |  0
 .../foundation/common/log/NoCacheLog4j2Marker.java |  0
 .../common/log/NoCacheLog4jMarkerFactory.java  |  0
 .../common/log/TestLogMarkerLeakFixUtils.java  | 25 -
 .../common/log/TestNoCacheLog4jMarkerFactory.java  |  0
 foundations/pom.xml|  2 ++
 integration-tests/dynamic-config-tests/pom.xml |  4 +++
 integration-tests/jaxrs-tests/pom.xml  |  4 +++
 integration-tests/pojo-test/pom.xml|  4 +++
 integration-tests/springmvc-tests/pom.xml  |  4 +++
 .../client/ServiceRegistryDemo.java| 32 --
 .../rest/servlet/RestServletContextListener.java   | 11 
 35 files changed, 96 insertions(+), 122 deletions(-)
 copy {common/common-javassist => foundations/foundation-log4j}/pom.xml (84%)
 rename foundations/{foundation-common => 
foundation-log4j}/src/main/java/org/apache/servicecomb/foundation/common/utils/Log4jUtils.java
 (100%)
 rename foundations/{foundation-common => 
foundation-log4j}/src/main/java/org/apache/servicecomb/foundation/common/utils/RollingFileAppenderExt.java
 (100%)
 rename foundations/{foundation-common => 
foundation-log4j}/src/test/java/org/apache/servicecomb/foundation/common/utils/Log4jUtilsTest.java
 (100%)
 rename foundations/{foundation-common => 
foundation-log4j}/src/test/java/org/apache/servicecomb/foundation/common/utils/TestRollingFileAppenderExt.java
 (100%)
 copy {demo/demo-edge/authentication => foundations/foundation-log4j2}/pom.xml 
(79%)
 rename foundations/{foundation-common => 
foundation-log4j2}/src/main/java/org/apache/servicecomb/foundation/common/log/LogMarkerLeakFixUtils.java
 (100%)
 rename foundations/{foundation-common => 
foundation-log4j2}/src/main/java/org/apache/servicecomb/foundation/common/log/NoCacheLog4j2Marker.java
 (100%)
 rename foundations/{foundation-common => 
foundation-log4j2}/src/main/java/org/apache/servicecomb/foundation/common/log/NoCacheLog4jMarkerFactory.java
 (100%)
 rename foundations/{foundation-common => 
foundation-log4j2}/src/test/java/org/apache/servicecomb/foundation/common/log/TestLogMarkerLeakFixUtils.java
 (68%)
 rename foundations/{foundation-common => 
foundation-log4j2}/src/test/java/org/apache/servicecomb/foundation/common/log/TestNoCacheLog4jMarkerFactory.java
 (100%)
 delete mode 100644 
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/ServiceRegistryDemo.java

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1636: [SCB-1800]log4j is deprecated package, make log4j implementaions opti…

2020-03-17 Thread GitBox

liubao68 merged pull request #1636: [SCB-1800]log4j is deprecated package, make 
log4j implementaions opti…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1636
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1640: [SCB-1804]anylyse updating commons-configuration and archairus

2020-03-17 Thread GitBox

liubao68 merged pull request #1640: [SCB-1804]anylyse updating 
commons-configuration and archairus
URL: https://github.com/apache/servicecomb-java-chassis/pull/1640
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1636: [SCB-1800]log4j is deprecated package, make log4j implementaions opti…

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1636: [SCB-1800]log4j is 
deprecated package, make log4j implementaions opti…
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1636#discussion_r393583538
 
 

 ##
 File path: 
transports/transport-rest/transport-rest-servlet/src/main/java/org/apache/servicecomb/transport/rest/servlet/RestServletContextListener.java
 ##
 @@ -31,20 +28,12 @@
   @Override
   public void contextInitialized(ServletContextEvent sce) {
 try {
-  initLog(sce);
 
 Review comment:
   added a subtask for this deletion


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1636: [SCB-1800]log4j is deprecated package, make log4j implementaions opti…

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1636: [SCB-1800]log4j is 
deprecated package, make log4j implementaions opti…
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1636#discussion_r393582778
 
 

 ##
 File path: core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
 ##
 @@ -130,9 +129,6 @@
   protected SCBEngine() {
 eventBus = EventManager.getEventBus();
 
-// see SCB-1266, fix Log4j2 leak marker problem
-LogMarkerLeakFixUtils.fix();
 
 Review comment:
   Added a subtask for this deletion. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r393557608
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -140,23 +160,23 @@ void refreshConfig() {
 e.getMessage());
   }
 });
-// latch.countDown();
   } else if (rsp.statusCode() == HttpStatus.SC_NOT_FOUND) {
 EventManager.post(new ConnSuccEvent());
-//latch.countDown();
   } else {
 EventManager.post(new ConnFailEvent("fetch config fail"));
 LOGGER.error("Config update from {} failed. Error message is 
[{}].",
 serviceUri,
 rsp.statusMessage());
   }
+  if (enableLongPolling) {
 
 Review comment:
   Maybe need check if first call?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r393557036
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -114,17 +129,22 @@ public void run() {
   }
 }
 
-//todo : latch down
 @SuppressWarnings("deprecation")
 void refreshConfig() {
   String path = "/v1/"
   + KieConfig.INSTANCE.getDomainName()
   + "/kie/kv?label=app:"
   + KieConfig.INSTANCE.getAppName();
+  if (!IS_FIRST_PULL.get()) {
 
 Review comment:
   Maybe need check enableLongPolling?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r393554469
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -48,16 +49,27 @@
 
   private static final Logger LOGGER = 
LoggerFactory.getLogger(KieClient.class);
 
-  private ScheduledExecutorService EXECUTOR = 
Executors.newScheduledThreadPool(1);
+  private ScheduledExecutorService EXECUTOR = 
Executors.newScheduledThreadPool(1, (r) -> {
+Thread thread = new Thread(r);
+thread.setName("org.apache.servicecomb.config.kie");
+thread.setDaemon(true);
+return thread;
+  });
 
   private static final long TIME_OUT = 1;
 
+  private static AtomicBoolean IS_FIRST_PULL = new AtomicBoolean(true);
+
+  private static final int LONG_POLLING_WAIT_TIME = 30;
 
 Review comment:
   long polling timeout is less than client request timeout, will this cause 
client timeout frequently?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

liubao68 commented on a change in pull request #1638: [SCB-1803] kie support 
long polling
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r393554469
 
 

 ##
 File path: 
dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##
 @@ -48,16 +49,27 @@
 
   private static final Logger LOGGER = 
LoggerFactory.getLogger(KieClient.class);
 
-  private ScheduledExecutorService EXECUTOR = 
Executors.newScheduledThreadPool(1);
+  private ScheduledExecutorService EXECUTOR = 
Executors.newScheduledThreadPool(1, (r) -> {
+Thread thread = new Thread(r);
+thread.setName("org.apache.servicecomb.config.kie");
+thread.setDaemon(true);
+return thread;
+  });
 
   private static final long TIME_OUT = 1;
 
+  private static AtomicBoolean IS_FIRST_PULL = new AtomicBoolean(true);
+
+  private static final int LONG_POLLING_WAIT_TIME = 30;
 
 Review comment:
   long polling timeout is equals to client request timeout, will this cause 
client timeout frequently?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1633: [SCB-1799]add back servicecomb.service.registry.registerUrlPrefix

2020-03-17 Thread GitBox

liubao68 merged pull request #1633: [SCB-1799]add back 
servicecomb.service.registry.registerUrlPrefix
URL: https://github.com/apache/servicecomb-java-chassis/pull/1633
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-java-chassis] branch master updated: [SCB-1799]add back servicecomb.service.registry.registerUrlPrefix

2020-03-17 Thread liubao

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
 new 6f566b5  [SCB-1799]add back 
servicecomb.service.registry.registerUrlPrefix
6f566b5 is described below

commit 6f566b5ba3781ca1ee9fefb0bd12cd754e4248c2
Author: liubao 
AuthorDate: Mon Mar 16 16:51:42 2020 +0800

[SCB-1799]add back servicecomb.service.registry.registerUrlPrefix
---
 .../provider/producer/ProducerProviderManager.java |  18 
 .../demo-register-url-prefix-client/pom.xml|  79 
 .../servicecomb/demo/prefix/Application.java   |  44 +
 .../src/main/resources/application.yml |  34 +++
 .../demo/prefix/RegisterUrlPrefixIT.java   |  42 +
 .../demo-register-url-prefix-server/pom.xml| 100 +
 .../servicecomb/demo/prefix/PrefixApplication.java |  31 +++
 .../demo/prefix/RegisterUrlPrefixEndpoint.java |  34 +++
 .../src/main/resources/application.yml |  36 
 demo/demo-register-url-prefix/pom.xml  |  52 +++
 demo/pom.xml   |   1 +
 11 files changed, 471 insertions(+)

diff --git 
a/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
 
b/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
index 7976baf..3cb7c8c 100644
--- 
a/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
+++ 
b/core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java
@@ -22,6 +22,7 @@ import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.Executor;
 
+import org.apache.commons.lang3.StringUtils;
 import org.apache.servicecomb.core.ProducerProvider;
 import org.apache.servicecomb.core.SCBEngine;
 import org.apache.servicecomb.core.definition.CoreMetaUtils;
@@ -30,11 +31,14 @@ import org.apache.servicecomb.core.definition.OperationMeta;
 import org.apache.servicecomb.core.definition.SchemaMeta;
 import org.apache.servicecomb.core.executor.ExecutorManager;
 import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils;
+import org.apache.servicecomb.serviceregistry.api.Const;
 import org.apache.servicecomb.swagger.engine.SwaggerProducer;
 import org.apache.servicecomb.swagger.engine.SwaggerProducerOperation;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.netflix.config.DynamicPropertyFactory;
+
 import io.swagger.models.Swagger;
 
 public class ProducerProviderManager {
@@ -92,6 +96,7 @@ public class ProducerProviderManager {
 SwaggerProducer swaggerProducer = scbEngine.getSwaggerEnvironment()
 .createProducer(instance, swagger);
 swagger = swaggerProducer.getSwagger();
+registerUrlPrefixToSwagger(swagger);
 
 SchemaMeta schemaMeta = 
producerMicroserviceMeta.registerSchemaMeta(schemaId, swagger);
 schemaMeta.putExtData(CoreMetaUtils.SWAGGER_PRODUCER, swaggerProducer);
@@ -107,4 +112,17 @@ public class ProducerProviderManager {
 
 return schemaMeta;
   }
+
+  // This is special requirement by users: When service deployed in 
tomcat,user want to use RestTemplate to
+  // call REST service by the full url. e.g. 
restTemplate.getForObejct("cse://serviceName/root/prefix/health")
+  // By default, user's do not need context prefix, e.g. 
restTemplate.getForObejct("cse://serviceName/health")
+  private void registerUrlPrefixToSwagger( Swagger swagger) {
+String urlPrefix = System.getProperty(Const.URL_PREFIX);
+if (!StringUtils.isEmpty(urlPrefix) && 
!swagger.getBasePath().startsWith(urlPrefix)
+&& DynamicPropertyFactory.getInstance()
+.getBooleanProperty(Const.REGISTER_URL_PREFIX, false).get()) {
+  LOGGER.info("Add swagger base path prefix for {} with {}", 
swagger.getBasePath(), urlPrefix);
+  swagger.setBasePath(urlPrefix + swagger.getBasePath());
+}
+  }
 }
\ No newline at end of file
diff --git 
a/demo/demo-register-url-prefix/demo-register-url-prefix-client/pom.xml 
b/demo/demo-register-url-prefix/demo-register-url-prefix-client/pom.xml
new file mode 100644
index 000..aab5a6c
--- /dev/null
+++ b/demo/demo-register-url-prefix/demo-register-url-prefix-client/pom.xml
@@ -0,0 +1,79 @@
+
+
+
+http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;
+  xmlns="http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;>
+  4.0.0
+  demo-register-url-prefix-client
+  Java Chassis::Demo::Spring Boot::Transport::Register URL Prefix 
client
+  
+org.apache.servicecomb.demo
+demo-register-url-prefix
+2.0.1-SNAPSHOT
+  
+
+  
+org.apache.servicecomb.demo.prefix.Application
+  
+  
+
+  org.apache.servicecomb
+

[GitHub] [servicecomb-java-chassis] walker-dead-cave commented on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法

2020-03-17 Thread GitBox

walker-dead-cave commented on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1637#issuecomment-599934884
 
 
   多谢，知道结论了，建议后续可以考虑加上：发布地址都可以，监听地址也支持，达到统一性


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] Fang57 commented on issue #1639: SpringCloud项目改造为Springboot项目时，generate operation swagger failed

2020-03-17 Thread GitBox

Fang57 commented on issue #1639: SpringCloud项目改造为Springboot项目时，generate 
operation swagger failed
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1639#issuecomment-599932273
 
 
   接口改造时发现有有接口用到了Errors类进行异常处理，所以想确认下


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] Fang57 closed issue #1639: SpringCloud项目改造为Springboot项目时，generate operation swagger failed

2020-03-17 Thread GitBox

Fang57 closed issue #1639: SpringCloud项目改造为Springboot项目时，generate operation 
swagger failed
URL: https://github.com/apache/servicecomb-java-chassis/issues/1639
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile removed a comment on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法

2020-03-17 Thread GitBox

heyile removed a comment on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1637#issuecomment-599928157
 
 
   版本号 和  你的 microservice.yaml 给下


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法

2020-03-17 Thread GitBox

heyile commented on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1637#issuecomment-599928157
 
 
   版本号 和  你的 microservice.yaml 给下


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法

2020-03-17 Thread GitBox

liubao68 commented on issue #1637: rest.addres:0.0.0.0，有改为自动获取虚机ip的方法
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1637#issuecomment-599927983
 
 
   
可以看看[这里的说明](https://docs.servicecomb.io/java-chassis/zh_CN/build-provider/listen-address-and-publish-address/)，
 目前只能支持配置实际IP地址。 监听地址不支持使用网卡名称。 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on issue #1639: SpringCloud项目改造为Springboot项目时，generate operation swagger failed

2020-03-17 Thread GitBox

heyile commented on issue #1639: SpringCloud项目改造为Springboot项目时，generate 
operation swagger failed
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1639#issuecomment-599925525
 
 
   把问题场景和背景说下吧. 为啥要用Errors. 然后给一个可用的 demo


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1639: SpringCloud项目改造为Springboot项目时，generate operation swagger failed

2020-03-17 Thread GitBox

liubao68 commented on issue #1639: SpringCloud项目改造为Springboot项目时，generate 
operation swagger failed
URL: 
https://github.com/apache/servicecomb-java-chassis/issues/1639#issuecomment-599925080
 
 
   能否打开Errors类详细看下， 
[类型约束参考](https://docs.servicecomb.io/java-chassis/zh_CN/build-provider/interface-constraints/)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1640: [SCB-1804]anylyse updating commons-configuration and archairus

2020-03-17 Thread GitBox

liubao68 opened a new pull request #1640: [SCB-1804]anylyse updating 
commons-configuration and archairus
URL: https://github.com/apache/servicecomb-java-chassis/pull/1640
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] Fang57 opened a new issue #1639: SpringCloud项目改造为Springboot项目时，generate operation swagger failed

2020-03-17 Thread GitBox

Fang57 opened a new issue #1639: SpringCloud项目改造为Springboot项目时，generate 
operation swagger failed
URL: https://github.com/apache/servicecomb-java-chassis/issues/1639
 
 
   在文档上看到接口参数不支持HttpServletResponse ，请问异常类Errors也不支持吗
   
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
   import org.springframework.validation.Errors;
   
   @RequestMapping(value = "/demo/v1/hello", produces = 
"application/json;charset=UTF-8", method = RequestMethod.GET)
   public String queryConfig(@PathVariable(value = "id") Integer id,
   @Valid @RequestBody NodeInfo nodeInfo,
   Errors errors,
   HttpServletRequest request,
   HttpServletResponse response) {
   return HttpStatus.OK.toString();
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] Nick-The-Uncharted commented on issue #1632: [SCB-1797] Fix marker leak problem when using slf4j1.8 or higher with log4j2

2020-03-17 Thread GitBox

Nick-The-Uncharted commented on issue #1632:  [SCB-1797] Fix marker leak 
problem when using slf4j1.8 or higher with log4j2
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1632#issuecomment-599910479
 
 
   I am not familiar with higher version of JDK, do you mean better solution 
that not using reflection?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 opened a new pull request #1638: [SCB-1803] kie support long polling

2020-03-17 Thread GitBox

GuoYL123 opened a new pull request #1638: [SCB-1803] kie support long polling
URL: https://github.com/apache/servicecomb-java-chassis/pull/1638
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-website] 02/02: Update becomming-a-committer.md

2020-03-17 Thread ningjiang

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git

commit 6b2dc41ff3b59fd985110392c518dbad10c9e0ad
Author: HweiH 
AuthorDate: Tue Mar 17 10:13:00 2020 +0800

Update becomming-a-committer.md
---
 _developers/cn/becomming-a-committer.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/_developers/cn/becomming-a-committer.md 
b/_developers/cn/becomming-a-committer.md
index 5490304..bfeed77 100755
--- a/_developers/cn/becomming-a-committer.md
+++ b/_developers/cn/becomming-a-committer.md
@@ -7,7 +7,7 @@ excerpt: "成为committer"
 last_modified_at: 2018-06-19T09:46:01+08:00
 ---
 
-ServiceComb 是按照Apache的做事方式来构建社区的，任何人只要他为社区做出了足够的贡献争获取到足够的信任就可以成为代码提交者。
+ServiceComb 是按照Apache的做事方式来构建社区的，任何人只要他为社区做出了足够的贡献并获取到足够的信任就可以成为代码提交者。
 
 ## 参与社区贡献
 
@@ -26,6 +26,6 @@ ServiceComb采用了与Apache基金会相同的精英治理模式。 一旦您
 
ServiceComb社区参照Apache[发展新提交者流程](http://community.apache.org/newcommitter.html)来发展新的提交者。
 
 * 在 @private 中进行投票.
-* 如果投票通过，项目管理委员会将向新发展的代码提交这发送邀请邮件，邮件同时抄送 @private。
+* 如果投票通过，项目管理委员会将向新发展的代码提交者发送邀请邮件，邮件同时抄送 @private。
 * 将代码提交者信息刷新到[开发团队](/developers/team)
 * [设置提交权限信息](/developers/setup-committer-rights/)

[servicecomb-website] branch asf-site updated: Publish the website

2020-03-17 Thread ningjiang

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new b47ef20  Publish the website
b47ef20 is described below

commit b47ef20cbf3fcb2aabaf07e1f1a8f10198c1dd2d
Author: Willem Jiang 
AuthorDate: Tue Mar 17 14:18:31 2020 +0800

Publish the website
---
 content/cn/developers/becomming-a-commiter.html   | 4 ++--
 content/cn/developers/release-validation-guide/index.html | 6 +++---
 content/feed.xml  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/content/cn/developers/becomming-a-commiter.html 
b/content/cn/developers/becomming-a-commiter.html
index 527a5d3..a4315d2 100644
--- a/content/cn/developers/becomming-a-commiter.html
+++ b/content/cn/developers/becomming-a-commiter.html
@@ -465,7 +465,7 @@
   
 
   
-ServiceComb 
是按照Apache的做事方式来构建社区的，任何人只要他为社区做出了足够的贡献争获取到足够的信任就可以成为代码提交者。
+ServiceComb 
是按照Apache的做事方式来构建社区的，任何人只要他为社区做出了足够的贡献并获取到足够的信任就可以成为代码提交者。
 
 参与社区贡献
 
@@ -487,7 +487,7 @@
 
 
   在 @private 中进行投票.
-  如果投票通过，项目管理委员会将向新发展的代码提交这发送邀请邮件，邮件同时抄送 @private。
+  如果投票通过，项目管理委员会将向新发展的代码提交者发送邀请邮件，邮件同时抄送 @private。
   将代码提交者信息刷新到开发团队
   设置提交权限信息
 
diff --git a/content/cn/developers/release-validation-guide/index.html 
b/content/cn/developers/release-validation-guide/index.html
index a866bc8..468e25d 100644
--- a/content/cn/developers/release-validation-guide/index.html
+++ b/content/cn/developers/release-validation-guide/index.html
@@ -550,7 +550,7 @@
 
 
 
-  提示：如果如果验证环境操作系统是Windows：
+  提示：如果验证环境操作系统是Windows：
   mvn clean install -Pdocker -Pit -Pdocker-machine -Pdemo-run-release
   
 
@@ -609,7 +609,7 @@
 
 
 
-  提示：如果如果验证环境操作系统是Windows：
+  提示：如果验证环境操作系统是Windows：
   mvn clean install -Pdocker -Pstaging -Pdocker-machine  -Pit -Pdemo-run-release
   
 
@@ -641,7 +641,7 @@ git checkout 1.x
 
 
 
-  提示：如果如果验证环境操作系统是Windows：
+  提示：如果验证环境操作系统是Windows：
   mvn clean verify -Pdocker -Pstaging -Pdocker-machine
   
 
diff --git a/content/feed.xml b/content/feed.xml
index 7507fe4..d7b5c1d 100644
--- a/content/feed.xml
+++ b/content/feed.xml
@@ -1,4 +1,4 @@
-http://www.w3.org/2005/Atom; >https://jekyllrb.com/; 
version="3.8.5">Jekyll2020-02-22T17:15:48+08:00/feed.xmlApache ServiceCombThe homepage of 
ServiceComb{name=nil, 
avatar= [...]
+http://www.w3.org/2005/Atom; >https://jekyllrb.com/; 
version="3.8.5">Jekyll2020-03-17T14:17:31+08:00/feed.xmlApache ServiceCombThe homepage of 
ServiceComb{name=nil, 
avatar= [...]
 
 
p本次讲座得到广东工业大学计算机院学生会同学们的鼎力支持和参与。报名通道开放后，报名人数迅速达到150+，活动放在学校报告厅举办。即便在周日，同学们的热情仍然很高，给广东工业大学的同学们点赞。/p

[servicecomb-website] branch master updated (75d0dbf -> 6b2dc41)

2020-03-17 Thread ningjiang

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git.


from 75d0dbf  [SCB-1778] add notes to delete temporary artifacts
 new 8d98012  Update release_validation_guide.md
 new 6b2dc41  Update becomming-a-committer.md

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 _developers/cn/becomming-a-committer.md| 4 ++--
 _developers/cn/release_validation_guide.md | 8 
 2 files changed, 6 insertions(+), 6 deletions(-)

[servicecomb-website] 01/02: Update release_validation_guide.md

2020-03-17 Thread ningjiang

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git

commit 8d98012cd41f964f98264f56f6aacb335e44db8b
Author: HweiH 
AuthorDate: Tue Mar 17 10:58:59 2020 +0800

Update release_validation_guide.md
---
 _developers/cn/release_validation_guide.md | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/_developers/cn/release_validation_guide.md 
b/_developers/cn/release_validation_guide.md
index 158430a..8863ee9 100644
--- a/_developers/cn/release_validation_guide.md
+++ b/_developers/cn/release_validation_guide.md
@@ -77,7 +77,7 @@ unzip xxx-src.zip
 mvn clean install -Pdocker -Pit -Pdemo-run-release
 ```
 
->提示：如果如果验证环境操作系统是Windows：
+>提示：如果验证环境操作系统是Windows：
 >```bash
 >mvn clean install -Pdocker -Pit -Pdocker-machine -Pdemo-run-release
 >```
@@ -137,7 +137,7 @@ Staging Repository : 
https://repository.apache.org/content/repositories/orgapach
 mvn clean install -Pdocker -Pstaging -Pit -Pdemo-run-release
 ```
 
->提示：如果如果验证环境操作系统是Windows：
+>提示：如果验证环境操作系统是Windows：
 >```bash
 >mvn clean install -Pdocker -Pstaging -Pdocker-machine  -Pit -Pdemo-run-release
 >```
@@ -172,7 +172,7 @@ git checkout 1.x
 mvn clean verify -Pdocker -Pstaging
 ```
 
->提示：如果如果验证环境操作系统是Windows：
+>提示：如果验证环境操作系统是Windows：
 >```bash
 >mvn clean verify -Pdocker -Pstaging -Pdocker-machine
 >```
@@ -183,4 +183,4 @@ mvn clean verify -Pdocker -Pstaging
 
 下载 [samples 代码](https://github.com/apache/servicecomb-samples)， 由于 samples 较多， 
可以选择部分
 进行验证， 详细参考每一个 sample 提供的 README 文件。
- 
\ No newline at end of file
+

[servicecomb-website] branch asf-site updated: Update becomming-a-committer.md

2020-03-17 Thread ningjiang

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new b91c1d5  Update becomming-a-committer.md
b91c1d5 is described below

commit b91c1d5fb8eb9fa17022cd13b730b95cbfc52523
Author: HweiH 
AuthorDate: Tue Mar 17 10:13:00 2020 +0800

Update becomming-a-committer.md
---
 _developers/cn/becomming-a-committer.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/_developers/cn/becomming-a-committer.md 
b/_developers/cn/becomming-a-committer.md
index 5490304..bfeed77 100755
--- a/_developers/cn/becomming-a-committer.md
+++ b/_developers/cn/becomming-a-committer.md
@@ -7,7 +7,7 @@ excerpt: "成为committer"
 last_modified_at: 2018-06-19T09:46:01+08:00
 ---
 
-ServiceComb 是按照Apache的做事方式来构建社区的，任何人只要他为社区做出了足够的贡献争获取到足够的信任就可以成为代码提交者。
+ServiceComb 是按照Apache的做事方式来构建社区的，任何人只要他为社区做出了足够的贡献并获取到足够的信任就可以成为代码提交者。
 
 ## 参与社区贡献
 
@@ -26,6 +26,6 @@ ServiceComb采用了与Apache基金会相同的精英治理模式。 一旦您
 
ServiceComb社区参照Apache[发展新提交者流程](http://community.apache.org/newcommitter.html)来发展新的提交者。
 
 * 在 @private 中进行投票.
-* 如果投票通过，项目管理委员会将向新发展的代码提交这发送邀请邮件，邮件同时抄送 @private。
+* 如果投票通过，项目管理委员会将向新发展的代码提交者发送邀请邮件，邮件同时抄送 @private。
 * 将代码提交者信息刷新到[开发团队](/developers/team)
 * [设置提交权限信息](/developers/setup-committer-rights/)

[GitHub] [servicecomb-website] WillemJiang merged pull request #243: Update becomming-a-committer.md

2020-03-17 Thread GitBox

WillemJiang merged pull request #243: Update becomming-a-committer.md
URL: https://github.com/apache/servicecomb-website/pull/243
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-website] WillemJiang merged pull request #244: Update release_validation_guide.md

2020-03-17 Thread GitBox

WillemJiang merged pull request #244: Update release_validation_guide.md
URL: https://github.com/apache/servicecomb-website/pull/244
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[servicecomb-website] branch asf-site updated: Update release_validation_guide.md

2020-03-17 Thread ningjiang

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/servicecomb-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new c4f54b1  Update release_validation_guide.md
c4f54b1 is described below

commit c4f54b1b1a24dce3fcc1c4e101623b72d69b33f9
Author: HweiH 
AuthorDate: Tue Mar 17 10:58:59 2020 +0800

Update release_validation_guide.md
---
 _developers/cn/release_validation_guide.md | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/_developers/cn/release_validation_guide.md 
b/_developers/cn/release_validation_guide.md
index 158430a..8863ee9 100644
--- a/_developers/cn/release_validation_guide.md
+++ b/_developers/cn/release_validation_guide.md
@@ -77,7 +77,7 @@ unzip xxx-src.zip
 mvn clean install -Pdocker -Pit -Pdemo-run-release
 ```
 
->提示：如果如果验证环境操作系统是Windows：
+>提示：如果验证环境操作系统是Windows：
 >```bash
 >mvn clean install -Pdocker -Pit -Pdocker-machine -Pdemo-run-release
 >```
@@ -137,7 +137,7 @@ Staging Repository : 
https://repository.apache.org/content/repositories/orgapach
 mvn clean install -Pdocker -Pstaging -Pit -Pdemo-run-release
 ```
 
->提示：如果如果验证环境操作系统是Windows：
+>提示：如果验证环境操作系统是Windows：
 >```bash
 >mvn clean install -Pdocker -Pstaging -Pdocker-machine  -Pit -Pdemo-run-release
 >```
@@ -172,7 +172,7 @@ git checkout 1.x
 mvn clean verify -Pdocker -Pstaging
 ```
 
->提示：如果如果验证环境操作系统是Windows：
+>提示：如果验证环境操作系统是Windows：
 >```bash
 >mvn clean verify -Pdocker -Pstaging -Pdocker-machine
 >```
@@ -183,4 +183,4 @@ mvn clean verify -Pdocker -Pstaging
 
 下载 [samples 代码](https://github.com/apache/servicecomb-samples)， 由于 samples 较多， 
可以选择部分
 进行验证， 详细参考每一个 sample 提供的 README 文件。
- 
\ No newline at end of file
+

53 matches

Mail list logo