Shoothzj commented on code in PR #3242:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/3242#discussion_r933913741


##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filterext/IsolationDiscoveryFilter.java:
##########
@@ -44,7 +44,7 @@ public class IsolationDiscoveryFilter implements 
ServerListFilterExt {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(IsolationDiscoveryFilter.class);
 
   private final DynamicBooleanProperty emptyProtection = 
DynamicPropertyFactory.getInstance()
-      .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, false);
+      .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, true);

Review Comment:
   does this is a default value change? should we put it in the upgrade guide?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to