[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1794: [SCB-1947] define Filter and filter chain
liubao68 commented on a change in pull request #1794:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1794#discussion_r432327367
##
File path: core/src/main/java/org/apache/servicecomb/core/filter/FilterNode.java
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.core.filter;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.foundation.common.utils.AsyncUtils;
+import org.apache.servicecomb.swagger.invocation.Response;
+
+public class FilterNode {
+ public static FilterNode buildChain(Filter... filters) {
+return buildChain(Arrays.asList(filters));
+ }
+
+ public static FilterNode buildChain(List filters) {
+List filterNodes = filters.stream()
+.map(FilterNode::new)
+.collect(Collectors.toList());
+
+for (int idx = 0; idx < filterNodes.size() - 1; idx++) {
+ filterNodes.get(idx).setNextNode(filterNodes.get(idx + 1));
+}
+
+return filterNodes.get(0);
+ }
+
+ private final Filter filter;
+
+ private FilterNode nextNode;
+
+ public FilterNode(Filter filter) {
+this.filter = filter;
+ }
+
+ public void setNextNode(FilterNode nextNode) {
Review comment:
It's better to be private.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1794: [SCB-1947] define Filter and filter chain
liubao68 commented on a change in pull request #1794:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1794#discussion_r432324830
##
File path:
core/src/test/java/org/apache/servicecomb/core/filter/SimpleRetryFilter.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.core.filter;
+
+import java.io.IOException;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.exception.Exceptions;
+import org.apache.servicecomb.swagger.invocation.Response;
+
+@FilterMeta(name = "simple-retry")
+public class SimpleRetryFilter implements Filter {
+ protected int maxRetry = 3;
+
+ public SimpleRetryFilter setMaxRetry(int maxRetry) {
+this.maxRetry = maxRetry;
+return this;
+ }
+
+ @Override
+ public CompletableFuture onFilter(Invocation invocation,
FilterNode nextNode) {
+return new RetrySession(invocation, nextNode).run();
+ }
+
+ protected Throwable unwrapException(Throwable throwable) {
+return Exceptions.unwrapIncludeInvocationException(throwable);
+ }
+
+ protected boolean isRetryException(Throwable throwable) {
+return !(throwable instanceof IOException);
Review comment:
How do you judge which is retryable？ This is different than current
DefaultRetryExtensionsFactory.isRetriableException implementation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1794: [SCB-1947] define Filter and filter chain
liubao68 commented on a change in pull request #1794:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1794#discussion_r432324830
##
File path:
core/src/test/java/org/apache/servicecomb/core/filter/SimpleRetryFilter.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.core.filter;
+
+import java.io.IOException;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.exception.Exceptions;
+import org.apache.servicecomb.swagger.invocation.Response;
+
+@FilterMeta(name = "simple-retry")
+public class SimpleRetryFilter implements Filter {
+ protected int maxRetry = 3;
+
+ public SimpleRetryFilter setMaxRetry(int maxRetry) {
+this.maxRetry = maxRetry;
+return this;
+ }
+
+ @Override
+ public CompletableFuture onFilter(Invocation invocation,
FilterNode nextNode) {
+return new RetrySession(invocation, nextNode).run();
+ }
+
+ protected Throwable unwrapException(Throwable throwable) {
+return Exceptions.unwrapIncludeInvocationException(throwable);
+ }
+
+ protected boolean isRetryException(Throwable throwable) {
+return !(throwable instanceof IOException);
Review comment:
How do you judge which is reatrable？ This is different than current
DefaultRetryExtensionsFactory.isRetriableException implementation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
