[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem

[GitBox]

liubao68 commented on code in PR #3238:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r933916932


##
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##
@@ -95,7 +100,8 @@ public List createProperties(Object 
instance, String prefi
 continue;
   }
 
-  Setter setter = createObjectSetter(propertyDefinition);
+  Setter setter = 
beanDescriptionCache.computeIfAbsent(propertyDefinition,
+  LambdaMetafactoryUtils::createObjectSetter);

Review Comment:
   import static 
org.apache.servicecomb.foundation.common.utils.LambdaMetafactoryUtils.createObjectSetter
  can be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem

[GitBox]

liubao68 commented on code in PR #3238:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r933916518


##
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##
@@ -205,7 +211,7 @@ private PriorityProperty createIntProperty(Field field, 
String[] keys, Intege
 
   private String[] collectPropertyKeys(Field field, String prefix, Map parameters) {
 String propertyPrefix = prefix;
-String[] keys = new String[] {field.getName()};
+String[] keys = new String[]{field.getName()};

Review Comment:
   use formatter in etc foler and then format code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org