WillemJiang commented on a change in pull request #454: fix when server.port=0, health check fail and also fix lose consul metadata, such as 'secure=false' URL: https://github.com/apache/servicecomb-pack/pull/454#discussion_r277125643
########## File path: alpha/alpha-spring-cloud-starter-consul/src/main/java/org/apache/servicecomb/pack/alpha/server/discovery/consul/AlphaConsulAutoConfiguration.java ########## @@ -114,7 +114,11 @@ public void listenInstanceRegisteredEvent(InstanceRegisteredEvent instanceRegist NewService newservice = new NewService(); newservice.setName(service.getServiceName()); newservice.setId(service.getServiceId()); - List<String> tags = consulDiscoveryProperties.getTags(); + newservice.setAddress(service.getAddress()); + newservice.setPort(service.getServicePort()); + newservice.setMeta(service.getServiceMeta()); Review comment: @fengbaicanhe Thanks for the PR. When building with Spring-Boot 1.5.x, the CI got below error. /home/travis/build/apache/servicecomb-pack/alpha/alpha-spring-cloud-starter-consul/src/main/java/org/apache/servicecomb/pack/alpha/server/discovery/consul/AlphaConsulAutoConfiguration.java:[119,39] cannot find symbol symbol: method getServiceMeta() location: variable service of type com.ecwid.consul.v1.catalog.model.CatalogService @coolbeevip Could you take a look at this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services