[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #619: SCB-1712 Reset kv cache periodically

2020-01-10 Thread GitBox
codecov-io edited a comment on issue #619: SCB-1712 Reset kv cache periodically
URL: 
https://github.com/apache/servicecomb-service-center/pull/619#issuecomment-572892791
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=h1)
 Report
   > Merging 
[#619](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fc3f5a0e7109ffb163fd01b1e4020559b07c9b2e?src=pr=desc)
 will **decrease** coverage by `0.2%`.
   > The diff coverage is `28.72%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #619  +/-   ##
   ==
   - Coverage   57.61%   57.41%   -0.21% 
   ==
 Files 205  205  
 Lines   1577615857  +81 
   ==
   + Hits 9090 9104  +14 
   - Misses   6040 6099  +59 
   - Partials  646  654   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==)
 | `7.27% <ø> (ø)` | :arrow_up: |
   | 
[pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...rver/service/event/schema\_summary\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2NoZW1hX3N1bW1hcnlfZXZlbnRfaGFuZGxlci5nbw==)
 | `25% <ø> (ø)` | :arrow_up: |
   | 
[server/core/proto/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vdHlwZXMuZ28=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[server/plugin/pkg/quota/counter/event.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvY291bnRlci9ldmVudC5nbw==)
 | `69.04% <ø> (ø)` | :arrow_up: |
   | 
[...ver/service/event/dependency\_rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ydWxlX2V2ZW50X2hhbmRsZXIuZ28=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==)
 | `88.23% <ø> (ø)` | :arrow_up: |
   | 
[server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv)
 | `11.76% <ø> (ø)` | :arrow_up: |
   | 
[server/service/event/domain\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZG9tYWluX2V2ZW50X2hhbmRsZXIuZ28=)
 | `36.36% <ø> (ø)` | :arrow_up: |
   | 
[server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv)
 | `8.16% <ø> (ø)` | :arrow_up: |
   | ... and [15 
more](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=footer).
 Last update 
[fc3f5a0...4c3fcde](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #619: SCB-1712 Reset kv cache periodically

2020-01-10 Thread GitBox
codecov-io edited a comment on issue #619: SCB-1712 Reset kv cache periodically
URL: 
https://github.com/apache/servicecomb-service-center/pull/619#issuecomment-572892791
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=h1)
 Report
   > Merging 
[#619](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fc3f5a0e7109ffb163fd01b1e4020559b07c9b2e?src=pr=desc)
 will **decrease** coverage by `0.2%`.
   > The diff coverage is `28.72%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #619  +/-   ##
   ==
   - Coverage   57.61%   57.41%   -0.21% 
   ==
 Files 205  205  
 Lines   1577615857  +81 
   ==
   + Hits 9090 9104  +14 
   - Misses   6040 6099  +59 
   - Partials  646  654   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==)
 | `7.27% <ø> (ø)` | :arrow_up: |
   | 
[pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...rver/service/event/schema\_summary\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2NoZW1hX3N1bW1hcnlfZXZlbnRfaGFuZGxlci5nbw==)
 | `25% <ø> (ø)` | :arrow_up: |
   | 
[server/core/proto/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vdHlwZXMuZ28=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[server/plugin/pkg/quota/counter/event.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvY291bnRlci9ldmVudC5nbw==)
 | `69.04% <ø> (ø)` | :arrow_up: |
   | 
[...ver/service/event/dependency\_rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ydWxlX2V2ZW50X2hhbmRsZXIuZ28=)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==)
 | `88.23% <ø> (ø)` | :arrow_up: |
   | 
[server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv)
 | `11.76% <ø> (ø)` | :arrow_up: |
   | 
[server/service/event/domain\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZG9tYWluX2V2ZW50X2hhbmRsZXIuZ28=)
 | `36.36% <ø> (ø)` | :arrow_up: |
   | 
[server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv)
 | `8.16% <ø> (ø)` | :arrow_up: |
   | ... and [15 
more](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=footer).
 Last update 
[fc3f5a0...4c3fcde](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #619: SCB-1712 Reset kv cache periodically

2020-01-09 Thread GitBox
codecov-io edited a comment on issue #619: SCB-1712 Reset kv cache periodically
URL: 
https://github.com/apache/servicecomb-service-center/pull/619#issuecomment-572892791
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=h1)
 Report
   > Merging 
[#619](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fc3f5a0e7109ffb163fd01b1e4020559b07c9b2e?src=pr=desc)
 will **decrease** coverage by `0.24%`.
   > The diff coverage is `29.26%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/graphs/tree.svg?width=650=GAaF7zrg8R=150=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #619  +/-   ##
   ==
   - Coverage   57.61%   57.37%   -0.25% 
   ==
 Files 205  205  
 Lines   1577615847  +71 
   ==
   + Hits 9090 9092   +2 
   - Misses   6040 6105  +65 
   - Partials  646  650   +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[server/core/proto/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vdHlwZXMuZ28=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[server/core/backend/discovery.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kaXNjb3ZlcnkuZ28=)
 | `38.33% <0%> (-5.9%)` | :arrow_down: |
   | 
[server/service/util/microservice\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==)
 | `63.18% <0%> (+0.68%)` | :arrow_up: |
   | 
[server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==)
 | `80.8% <0%> (-5.22%)` | :arrow_down: |
   | 
[server/plugin/pkg/discovery/cache\_null.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX251bGwuZ28=)
 | `75% <0%> (-25%)` | :arrow_down: |
   | 
[server/core/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvY29uZmlnLmdv)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[server/plugin/pkg/discovery/cache\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX2t2Lmdv)
 | `86.53% <23.07%> (-9.26%)` | :arrow_down: |
   | 
[server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv)
 | `63.29% <33.33%> (-3.13%)` | :arrow_down: |
   | 
[server/core/proto/parser.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vcGFyc2VyLmdv)
 | `95.23% <92.85%> (-1.2%)` | :arrow_down: |
   | ... and [10 
more](https://codecov.io/gh/apache/servicecomb-service-center/pull/619/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=footer).
 Last update 
[fc3f5a0...df52fdd](https://codecov.io/gh/apache/servicecomb-service-center/pull/619?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services