[GitHub] codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16
codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/355#issuecomment-391280202 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=h1) Report > Merging [#355](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/b87ea66f7834d893aab7aa864df272e1c5ad9106?src=pr=desc) will **increase** coverage by `2.12%`. > The diff coverage is `94.96%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) ```diff @@Coverage Diff @@ ## master #355 +/- ## == + Coverage 69.33% 71.46% +2.12% == Files 18 25 +7 Lines3437 3690 +253 == + Hits 2383 2637 +254 + Misses885 884 -1 Partials 169 169 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZS5nbw==) | `100% <ø> (ø)` | | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `74.52% <100%> (-2.3%)` | :arrow_down: | | [server/service/dependency\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZGVwZW5kZW5jeV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.37% <100%> (ø)` | | | [server/service/util/versionrule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC92ZXJzaW9ucnVsZS5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/rule\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | [server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | | | [server/service/schema\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/tag\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <100%> (ø)` | :arrow_up: | | ... and [16 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=footer). Last update [b87ea66...4c503c3](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16
codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/355#issuecomment-391280202 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=h1) Report > Merging [#355](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8bdf68d7da553efb6c61fc41209b0a66d50da9fb?src=pr=desc) will **increase** coverage by `2.17%`. > The diff coverage is `94.64%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) ```diff @@Coverage Diff @@ ## master #355 +/- ## == + Coverage 68.83% 71.01% +2.17% == Files 18 25 +7 Lines3437 3685 +248 == + Hits 2366 2617 +251 + Misses902 896 -6 - Partials 169 172 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZS5nbw==) | `100% <ø> (ø)` | | | [server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `74.52% <100%> (-2.3%)` | :arrow_down: | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `75.44% <100%> (+0.6%)` | :arrow_up: | | [server/service/dependency\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZGVwZW5kZW5jeV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | [server/service/schema\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.37% <100%> (ø)` | | | [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `74.55% <100%> (ø)` | | | [server/service/microservice\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <100%> (ø)` | :arrow_up: | | ... and [17 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=footer). Last update [8bdf68d...5fc9c25](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16
codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/355#issuecomment-391280202 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=h1) Report > Merging [#355](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8bdf68d7da553efb6c61fc41209b0a66d50da9fb?src=pr=desc) will **increase** coverage by `2.17%`. > The diff coverage is `95.15%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) ```diff @@Coverage Diff @@ ## master #355 +/- ## == + Coverage 68.83% 71.01% +2.17% == Files 18 25 +7 Lines3437 3685 +248 == + Hits 2366 2617 +251 + Misses902 896 -6 - Partials 169 172 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZS5nbw==) | `100% <ø> (ø)` | | | [server/service/dependency\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZGVwZW5kZW5jeV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | [server/service/tag\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/microservice\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | | | [server/service/util/versionrule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC92ZXJzaW9ucnVsZS5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.37% <100%> (ø)` | | | [server/service/rule\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | [server/service/schema\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `56.17% <100%> (+1.98%)` | :arrow_up: | | ... and [17 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=footer). Last update [8bdf68d...1fc6d84](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16
codecov-io commented on issue #355: SCB-600 Support the max major/minor/patch version is MaxInt16 URL: https://github.com/apache/incubator-servicecomb-service-center/pull/355#issuecomment-391280202 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=h1) Report > Merging [#355](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8bdf68d7da553efb6c61fc41209b0a66d50da9fb?src=pr=desc) will **increase** coverage by `2.33%`. > The diff coverage is `95.14%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) ```diff @@Coverage Diff @@ ## master #355 +/- ## == + Coverage 68.83% 71.17% +2.33% == Files 18 25 +7 Lines3437 3705 +268 == + Hits 2366 2637 +271 + Misses902 896 -6 - Partials 169 172 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZS5nbw==) | `100% <ø> (ø)` | | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <100%> (ø)` | :arrow_up: | | [server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | | | [server/service/rule\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `75.44% <100%> (+0.6%)` | :arrow_up: | | [server/service/util/versionrule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC92ZXJzaW9ucnVsZS5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/tag\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `74.55% <100%> (ø)` | | | [server/service/schema\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hX3ZhbGlkYXRvci5nbw==) | `100% <100%> (ø)` | | | [server/service/dependency\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvZGVwZW5kZW5jeV92YWxpZGF0b3IuZ28=) | `100% <100%> (ø)` | | | ... and [17 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=footer). Last update [8bdf68d...9239ddb](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/355?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
