[GitHub] liubao68 commented on a change in pull request #983: [SCB-979] add reminder log on the selection of SwaggerGeneratorContext

2018-11-06 Thread GitBox 
liubao68 commented on a change in pull request #983: [SCB-979] add reminder log 
on the selection of SwaggerGeneratorContext
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/983#discussion_r231392835
 
 

 ##
 File path: 
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/pojo/PojoSwaggerGeneratorContext.java
 ##
 @@ -47,6 +53,16 @@ public int getOrder() {
 
   @Override
   public boolean canProcess(Class cls) {
+for (Annotation annotation : cls.getAnnotations()) {
+  // we check the annotations by class name to avoid importing extra 
dependencies in this module
+  if 
("javax.ws.rs.Path".equals(annotation.annotationType().getCanonicalName())
 
 Review comment:
   RestController maybe scaned for some scenario. But I think it is fine for 
this implementation, since it's only a info message 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #983: [SCB-979] add reminder log on the selection of SwaggerGeneratorContext

2018-11-06 Thread GitBox 
liubao68 commented on a change in pull request #983: [SCB-979] add reminder log 
on the selection of SwaggerGeneratorContext
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/983#discussion_r231392835
 
 

 ##
 File path: 
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/pojo/PojoSwaggerGeneratorContext.java
 ##
 @@ -47,6 +53,16 @@ public int getOrder() {
 
   @Override
   public boolean canProcess(Class cls) {
+for (Annotation annotation : cls.getAnnotations()) {
+  // we check the annotations by class name to avoid importing extra 
dependencies in this module
+  if 
("javax.ws.rs.Path".equals(annotation.annotationType().getCanonicalName())
 
 Review comment:
   RestController maybe scaned for some scenario. But I think it is fine for 
this implementation. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services