[GitHub] wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to servicecomb

2018-07-02 Thread GitBox 
wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to 
servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/787#discussion_r199660158
 
 

 ##
 File path: 
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
 ##
 @@ -38,14 +40,13 @@
   private static final String DEFAULT_CONFIG_FILE_NAME = "microservice.yaml";
 
   public MicroserviceConfigLoader() {
-setOrderKey("cse-config-order");
   }
 
   public void loadAndSort() {
 try {
   String configFileFromClasspath =
-  System.getProperty("cse.configurationSource.defaultFileName") == 
null ? DEFAULT_CONFIG_FILE_NAME
-  : System.getProperty("cse.configurationSource.defaultFileName");
+  System.getProperty(DEFAULT_FILE_NAME) == null ? 
DEFAULT_CONFIG_FILE_NAME
 
 Review comment:
   yes, nobody use this feature, we can changed it directly


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to servicecomb

2018-07-02 Thread GitBox 
wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to 
servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/787#discussion_r199660196
 
 

 ##
 File path: 
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
 ##
 @@ -28,7 +28,9 @@
 public class MicroserviceConfigLoader extends YAMLConfigLoader {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(MicroserviceConfigLoader.class);
 
-  private static final String ADDITIONAL_CONFIG_URL = 
"cse.configurationSource.additionalUrls";
+  private static final String ADDITIONAL_CONFIG_URL = 
"servicecomb.configurationSource.additionalUrls";
 
 Review comment:
   i remember someone already used this feature


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to servicecomb

2018-07-02 Thread GitBox 
wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to 
servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/787#discussion_r199502896
 
 

 ##
 File path: 
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
 ##
 @@ -28,7 +28,9 @@
 public class MicroserviceConfigLoader extends YAMLConfigLoader {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(MicroserviceConfigLoader.class);
 
-  private static final String ADDITIONAL_CONFIG_URL = 
"cse.configurationSource.additionalUrls";
+  private static final String ADDITIONAL_CONFIG_URL = 
"servicecomb.configurationSource.additionalUrls";
 
 Review comment:
   not compatible?
   because we only copy config items in configuration source, not in 
system.property?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to servicecomb

2018-07-02 Thread GitBox 
wujimin commented on a change in pull request #787: [SCB-671]duplicate cse to 
servicecomb
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/787#discussion_r199501521
 
 

 ##
 File path: 
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/MicroserviceConfigLoader.java
 ##
 @@ -38,14 +40,13 @@
   private static final String DEFAULT_CONFIG_FILE_NAME = "microservice.yaml";
 
   public MicroserviceConfigLoader() {
-setOrderKey("cse-config-order");
   }
 
   public void loadAndSort() {
 try {
   String configFileFromClasspath =
-  System.getProperty("cse.configurationSource.defaultFileName") == 
null ? DEFAULT_CONFIG_FILE_NAME
-  : System.getProperty("cse.configurationSource.defaultFileName");
+  System.getProperty(DEFAULT_FILE_NAME) == null ? 
DEFAULT_CONFIG_FILE_NAME
 
 Review comment:
   not compatible?
   because we only copy config items in configuration source, not in 
system.property?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services