Re: [PR] [SCB-2855]make ExceptionToProducerResponseConverters extensible [servicecomb-java-chassis]
liubao68 merged PR #4206: URL: https://github.com/apache/servicecomb-java-chassis/pull/4206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SCB-2855]make ExceptionToProducerResponseConverters extensible [servicecomb-java-chassis]
codecov-commenter commented on PR #4206: URL: https://github.com/apache/servicecomb-java-chassis/pull/4206#issuecomment-1912900674 ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4206?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `4 lines` in your changes are missing coverage. Please review. > Comparison is base [(`e003e62`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/e003e626c2effd32b54dcae0b1386e3f195911a4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 74.26% compared to head [(`9433e40`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4206?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 74.26%. > :exclamation: Current head 9433e40 differs from pull request most recent head f9b61c5. Consider uploading reports for the commit f9b61c5 to get more accurate results | [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4206?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../DefaultExceptionToProducerResponseConverters.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4206?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3dhZ2dlci9zd2FnZ2VyLWludm9jYXRpb24vaW52b2NhdGlvbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zd2FnZ2VyL2ludm9jYXRpb24vZXhjZXB0aW9uL0RlZmF1bHRFeGNlcHRpb25Ub1Byb2R1Y2VyUmVzcG9uc2VDb252ZXJ0ZXJzLmphdmE=) | 84.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4206?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## 2.8.x#4206 +/- ## = Coverage 74.26% 74.26% Complexity 711 711 = Files 1597 1598+1 Lines 4026040262+2 Branches 3677 3677 = + Hits 2989929902+3 + Misses 8866 8864-2 - Partials 1495 1496+1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4206?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SCB-2855]make ExceptionToProducerResponseConverters extensible [servicecomb-java-chassis]
liubao68 opened a new pull request, #4206: URL: https://github.com/apache/servicecomb-java-chassis/pull/4206 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SCB-2855]make ExceptionToProducerResponseConverters extensible [servicecomb-java-chassis]
liubao68 merged PR #4204: URL: https://github.com/apache/servicecomb-java-chassis/pull/4204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SCB-2855]make ExceptionToProducerResponseConverters extensible [servicecomb-java-chassis]
codecov-commenter commented on PR #4204: URL: https://github.com/apache/servicecomb-java-chassis/pull/4204#issuecomment-1911573422 ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4204?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `15 lines` in your changes are missing coverage. Please review. > Comparison is base [(`c31ad5d`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/c31ad5d3e364fc42bc6078ce993fc8ca039e52f7?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.71% compared to head [(`56c79c7`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4204?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.73%. > :exclamation: Current head 56c79c7 differs from pull request most recent head d8372f3. Consider uploading reports for the commit d8372f3 to get more accurate results | [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4204?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../DefaultExceptionToProducerResponseConverters.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4204?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3dhZ2dlci9zd2FnZ2VyLWludm9jYXRpb24vaW52b2NhdGlvbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zd2FnZ2VyL2ludm9jYXRpb24vZXhjZXB0aW9uL0RlZmF1bHRFeGNlcHRpb25Ub1Byb2R1Y2VyUmVzcG9uc2VDb252ZXJ0ZXJzLmphdmE=) | 40.00% | [14 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4204?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#4204 +/- ## + Coverage 44.71% 44.73% +0.01% - Complexity 5436 5438 +2 Files 1384 1384 Lines 3437934380 +1 Branches 3326 3326 + Hits 1537315380 +7 + Misses1776117755 -6 Partials 1245 1245 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4204?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SCB-2855]make ExceptionToProducerResponseConverters extensible [servicecomb-java-chassis]
liubao68 opened a new pull request, #4204: URL: https://github.com/apache/servicecomb-java-chassis/pull/4204 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
