Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
HyukjinKwon closed pull request #489: Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. URL: https://github.com/apache/spark-website/pull/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
HyukjinKwon commented on PR #489: URL: https://github.com/apache/spark-website/pull/489#issuecomment-1797096255 Merged to asf-site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
HyukjinKwon commented on code in PR #489: URL: https://github.com/apache/spark-website/pull/489#discussion_r1383786195 ## site/developer-tools.html: ## @@ -146,21 +146,36 @@ Test coverage GitHub Action https://github.com/apache/spark/actions;>GitHub Action provides the following on Ubuntu 22.04. + +Spark 4.x Review Comment: I would say just sth like "Apache Spark 4 and above" or just "Apache Spark 4" or mention that latest dev branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
HyukjinKwon commented on code in PR #489: URL: https://github.com/apache/spark-website/pull/489#discussion_r1383786195 ## site/developer-tools.html: ## @@ -146,21 +146,36 @@ Test coverage GitHub Action https://github.com/apache/spark/actions;>GitHub Action provides the following on Ubuntu 22.04. + +Spark 4.x Review Comment: I would say just sth like "Apache Spark 3 and above" or just "Apache Spark 3" ## site/developer-tools.html: ## @@ -146,21 +146,36 @@ Test coverage GitHub Action https://github.com/apache/spark/actions;>GitHub Action provides the following on Ubuntu 22.04. + +Spark 4.x + - Scala 2.12/2.13 SBT build with Java 8 - Scala 2.12 Maven build with Java 11/17 - Java/Scala/Python/R unit tests with Java 8/Scala 2.12/SBT + Scala 2.13 SBT build with Java 17 + Scala 2.13 Maven build with Java 17/21 + Java/Scala/Python/R unit tests with Java 17/Scala 2.13/SBT TPC-DS benchmark with scale factor 1 JDBC Docker integration tests Kubernetes integration tests - Daily Java/Scala/Python/R unit tests with Java 11/17 and Scala 2.12/SBT + Daily Java/Scala/Python/R unit tests with Java 21 and Scala 2.13/SBT + + +Spark 3.x Review Comment: ditto ## site/developer-tools.html: ## @@ -146,21 +146,36 @@ Test coverage GitHub Action https://github.com/apache/spark/actions;>GitHub Action provides the following on Ubuntu 22.04. + +Spark 4.x Review Comment: I would say just sth like "Apache Spark 4 and above" or just "Apache Spark 4" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
dongjoon-hyun commented on code in PR #489: URL: https://github.com/apache/spark-website/pull/489#discussion_r1383701599 ## developer-tools.md: ## @@ -14,18 +14,31 @@ Apache Spark community uses various resources to maintain the community test cov GitHub Action [GitHub Action](https://github.com/apache/spark/actions) provides the following on Ubuntu 22.04. -- Scala 2.12/2.13 SBT build with Java 8 -- Scala 2.12 Maven build with Java 11/17 -- Java/Scala/Python/R unit tests with Java 8/Scala 2.12/SBT + +Spark 4.x + +- Scala 2.13 SBT build with Java 17 +- Scala 2.13 Maven build with Java 17/21 +- Java/Scala/Python/R unit tests with Java 17/Scala 2.13/SBT - TPC-DS benchmark with scale factor 1 - JDBC Docker integration tests - Kubernetes integration tests -- Daily Java/Scala/Python/R unit tests with Java 11/17 and Scala 2.12/SBT +- Daily Java/Scala/Python/R unit tests with Java 21 and Scala 2.13/SBT + +Spark 3.x Review Comment: After Apache Spark 3.3 reaches the EOL on December 15th, let's remove this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
LuciferYang commented on PR #489: URL: https://github.com/apache/spark-website/pull/489#issuecomment-1794954645 I have chosen to list them separately so that the parts of Spark 3. x can be deleted at once later. Additionally, it seems that branch-3.x will no longer trigger `AppVeyor`: https://github.com/apache/spark/pull/43676 so there is no longer a distinction between Spark 3. x and good 4. x for AppVeyor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
srowen commented on PR #489: URL: https://github.com/apache/spark-website/pull/489#issuecomment-1794910675 Yep that works. If you think it's simpler you can also just mention these differences inline in the bullet points that changed. IT all works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
LuciferYang commented on PR #489: URL: https://github.com/apache/spark-website/pull/489#issuecomment-1794890660 like https://github.com/apache/spark-website/assets/1475305/0fd3dcdd-bd6c-4ebb-98f6-7f2d3acc0d9c;> ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
srowen commented on PR #489: URL: https://github.com/apache/spark-website/pull/489#issuecomment-1794834215 Looks fine, only issue is that these docs are meant to be for all current versions, and this info is for 4.0, which isn't released yet. We can do this, but, could also write the docs to have different info for 3.x and 4.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
LuciferYang commented on code in PR #489: URL: https://github.com/apache/spark-website/pull/489#discussion_r1382941341 ## developer-tools.md: ## @@ -14,18 +14,18 @@ Apache Spark community uses various resources to maintain the community test cov GitHub Action [GitHub Action](https://github.com/apache/spark/actions) provides the following on Ubuntu 22.04. -- Scala 2.12/2.13 SBT build with Java 8 -- Scala 2.12 Maven build with Java 11/17 -- Java/Scala/Python/R unit tests with Java 8/Scala 2.12/SBT +- Scala 2.13 SBT build with Java 17 Review Comment: cc @wangyum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
[PR] Update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. [spark-website]
LuciferYang opened a new pull request, #489: URL: https://github.com/apache/spark-website/pull/489 This pr update the `GitHub Action` and `AppVeyor` entries on the `developer-tools` page to match the current test content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
