This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new c326928edde [SPARK-45296][INFRA][BUILD] Comment out unused JDK 11 related in dev/run-tests.py c326928edde is described below commit c326928edde319c0d8ff3ff723c7711f8596ca3f Author: Hyukjin Kwon <gurwls...@apache.org> AuthorDate: Mon Sep 25 20:27:36 2023 +0900 [SPARK-45296][INFRA][BUILD] Comment out unused JDK 11 related in dev/run-tests.py ### What changes were proposed in this pull request? This PR proposes to comment unused JDK 11 related in `dev/run-tests.py`. ### Why are the changes needed? For readability, and commenting out unused code. I added some explanation inlined. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? No. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #43081 from HyukjinKwon/SPARK-45296. Authored-by: Hyukjin Kwon <gurwls...@apache.org> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- dev/run-tests.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/dev/run-tests.py b/dev/run-tests.py index 57fe1de811d..cf0db66fba1 100755 --- a/dev/run-tests.py +++ b/dev/run-tests.py @@ -361,12 +361,13 @@ def run_scala_tests(build_tool, extra_profiles, test_modules, excluded_tags, inc if excluded_tags: test_profiles += ["-Dtest.exclude.tags=" + ",".join(excluded_tags)] - # set up java11 env if this is a pull request build with 'test-java11' in the title - if "ghprbPullTitle" in os.environ: - if "test-java11" in os.environ["ghprbPullTitle"].lower(): - os.environ["JAVA_HOME"] = "/usr/java/jdk-11.0.1" - os.environ["PATH"] = "%s/bin:%s" % (os.environ["JAVA_HOME"], os.environ["PATH"]) - test_profiles += ["-Djava.version=11"] + # SPARK-45296: legacy code for Jenkins. If we move to Jenkins, we should + # revive this logic with a different combination of JDK. + # if "ghprbPullTitle" in os.environ: + # if "test-java11" in os.environ["ghprbPullTitle"].lower(): + # os.environ["JAVA_HOME"] = "/usr/java/jdk-11.0.1" + # os.environ["PATH"] = "%s/bin:%s" % (os.environ["JAVA_HOME"], os.environ["PATH"]) + # test_profiles += ["-Djava.version=11"] if build_tool == "maven": run_scala_tests_maven(test_profiles) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org