spark git commit: [SPARK-16084][SQL] Minor comments update for "DESCRIBE" table
Repository: spark Updated Branches: refs/heads/branch-2.0 0499ed961 -> 34a8e23c7 [SPARK-16084][SQL] Minor comments update for "DESCRIBE" table ## What changes were proposed in this pull request? 1. FORMATTED is actually supported, but partition is not supported; 2. Remove parenthesis as it is not necessary just like anywhere else. ## How was this patch tested? Minor issue. I do not think it needs a test case! Author: bomeng Closes #13791 from bomeng/SPARK-16084. (cherry picked from commit f3a768b7b96f00f33d2fe4e6c0bf4acf373ad4f4) Signed-off-by: Sean Owen Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/34a8e23c Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/34a8e23c Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/34a8e23c Branch: refs/heads/branch-2.0 Commit: 34a8e23c739532cd2cb059d9d4e785368d6d0a98 Parents: 0499ed9 Author: bomeng Authored: Tue Jun 21 08:51:43 2016 +0100 Committer: Sean Owen Committed: Tue Jun 21 08:51:57 2016 +0100 -- .../scala/org/apache/spark/sql/execution/SparkSqlParser.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/spark/blob/34a8e23c/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala -- diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala index 154c25a..2ae8380 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala @@ -279,15 +279,15 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder { * Create a [[DescribeTableCommand]] logical plan. */ override def visitDescribeTable(ctx: DescribeTableContext): LogicalPlan = withOrigin(ctx) { -// FORMATTED and columns are not supported. Return null and let the parser decide what to do -// with this (create an exception or pass it on to a different system). +// Describe partition and column are not supported yet. Return null and let the parser decide +// what to do with this (create an exception or pass it on to a different system). if (ctx.describeColName != null || ctx.partitionSpec != null) { null } else { DescribeTableCommand( visitTableIdentifier(ctx.tableIdentifier), ctx.EXTENDED != null, -ctx.FORMATTED() != null) +ctx.FORMATTED != null) } } - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
spark git commit: [SPARK-16084][SQL] Minor comments update for "DESCRIBE" table
Repository: spark Updated Branches: refs/heads/master a58f40239 -> f3a768b7b [SPARK-16084][SQL] Minor comments update for "DESCRIBE" table ## What changes were proposed in this pull request? 1. FORMATTED is actually supported, but partition is not supported; 2. Remove parenthesis as it is not necessary just like anywhere else. ## How was this patch tested? Minor issue. I do not think it needs a test case! Author: bomeng Closes #13791 from bomeng/SPARK-16084. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f3a768b7 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f3a768b7 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f3a768b7 Branch: refs/heads/master Commit: f3a768b7b96f00f33d2fe4e6c0bf4acf373ad4f4 Parents: a58f402 Author: bomeng Authored: Tue Jun 21 08:51:43 2016 +0100 Committer: Sean Owen Committed: Tue Jun 21 08:51:43 2016 +0100 -- .../scala/org/apache/spark/sql/execution/SparkSqlParser.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- http://git-wip-us.apache.org/repos/asf/spark/blob/f3a768b7/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala -- diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala index 154c25a..2ae8380 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala @@ -279,15 +279,15 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder { * Create a [[DescribeTableCommand]] logical plan. */ override def visitDescribeTable(ctx: DescribeTableContext): LogicalPlan = withOrigin(ctx) { -// FORMATTED and columns are not supported. Return null and let the parser decide what to do -// with this (create an exception or pass it on to a different system). +// Describe partition and column are not supported yet. Return null and let the parser decide +// what to do with this (create an exception or pass it on to a different system). if (ctx.describeColName != null || ctx.partitionSpec != null) { null } else { DescribeTableCommand( visitTableIdentifier(ctx.tableIdentifier), ctx.EXTENDED != null, -ctx.FORMATTED() != null) +ctx.FORMATTED != null) } } - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org