spark git commit: [SPARK-18816][WEB UI] Executors Logs column only ran visibility check on initial table load

2016-12-13 Thread srowen 
Repository: spark
Updated Branches:
  refs/heads/branch-2.1 d5c4a5d06 -> 292a37f24


[SPARK-18816][WEB UI] Executors Logs column only ran visibility check on 
initial table load

## What changes were proposed in this pull request?

When I added a visibility check for the logs column on the executors page in 
#14382 the method I used only ran the check on the initial DataTable creation 
and not subsequent page loads. I moved the check out of the table definition 
and instead it runs on each page load. The jQuery DataTable functionality used 
is the same.

## How was this patch tested?

Tested Manually

No visible UI changes to screenshot.

Author: Alex Bozarth 

Closes #16256 from ajbozarth/spark18816.

(cherry picked from commit aebf44e50b6b04b848829adbbe08b0f74f31eb32)
Signed-off-by: Sean Owen 


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/292a37f2
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/292a37f2
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/292a37f2

Branch: refs/heads/branch-2.1
Commit: 292a37f2455b12ef8dfbdaf5b905a69b8b5e3728
Parents: d5c4a5d
Author: Alex Bozarth 
Authored: Tue Dec 13 21:37:46 2016 +
Committer: Sean Owen 
Committed: Tue Dec 13 21:38:04 2016 +

--
 .../resources/org/apache/spark/ui/static/executorspage.js | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/spark/blob/292a37f2/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
--
diff --git 
a/core/src/main/resources/org/apache/spark/ui/static/executorspage.js 
b/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
index 1df6733..fe5db6a 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
@@ -412,10 +412,6 @@ $(document).ready(function () {
 ],
 "columnDefs": [
 {
-"targets": [ 15 ],
-"visible": logsExist(response)
-},
-{
 "targets": [ 16 ],
 "visible": getThreadDumpEnabled()
 }
@@ -423,7 +419,8 @@ $(document).ready(function () {
 "order": [[0, "asc"]]
 };
 
-$(selector).DataTable(conf);
+var dt = $(selector).DataTable(conf);
+dt.column(15).visible(logsExist(response));
 $('#active-executors [data-toggle="tooltip"]').tooltip();
 
 var sumSelector = "#summary-execs-table";


-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

spark git commit: [SPARK-18816][WEB UI] Executors Logs column only ran visibility check on initial table load

2016-12-13 Thread srowen 
Repository: spark
Updated Branches:
  refs/heads/master 9e8a9d7c6 -> aebf44e50


[SPARK-18816][WEB UI] Executors Logs column only ran visibility check on 
initial table load

## What changes were proposed in this pull request?

When I added a visibility check for the logs column on the executors page in 
#14382 the method I used only ran the check on the initial DataTable creation 
and not subsequent page loads. I moved the check out of the table definition 
and instead it runs on each page load. The jQuery DataTable functionality used 
is the same.

## How was this patch tested?

Tested Manually

No visible UI changes to screenshot.

Author: Alex Bozarth 

Closes #16256 from ajbozarth/spark18816.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/aebf44e5
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/aebf44e5
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/aebf44e5

Branch: refs/heads/master
Commit: aebf44e50b6b04b848829adbbe08b0f74f31eb32
Parents: 9e8a9d7
Author: Alex Bozarth 
Authored: Tue Dec 13 21:37:46 2016 +
Committer: Sean Owen 
Committed: Tue Dec 13 21:37:46 2016 +

--
 .../resources/org/apache/spark/ui/static/executorspage.js | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/spark/blob/aebf44e5/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
--
diff --git 
a/core/src/main/resources/org/apache/spark/ui/static/executorspage.js 
b/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
index 1df6733..fe5db6a 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
+++ b/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
@@ -412,10 +412,6 @@ $(document).ready(function () {
 ],
 "columnDefs": [
 {
-"targets": [ 15 ],
-"visible": logsExist(response)
-},
-{
 "targets": [ 16 ],
 "visible": getThreadDumpEnabled()
 }
@@ -423,7 +419,8 @@ $(document).ready(function () {
 "order": [[0, "asc"]]
 };
 
-$(selector).DataTable(conf);
+var dt = $(selector).DataTable(conf);
+dt.column(15).visible(logsExist(response));
 $('#active-executors [data-toggle="tooltip"]').tooltip();
 
 var sumSelector = "#summary-execs-table";


-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org