Re: svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2022-01-10 Thread Nathan Hartman 
On Mon, Jan 10, 2022 at 6:44 AM  wrote:
>
> Author: stsp
> Date: Mon Jan 10 11:44:46 2022
> New Revision: 1896877
>
> URL: http://svn.apache.org/viewvc?rev=1896877&view=rev
> Log:
> Fix misleading -r option documentation for some svnadmin subcommands.
>
> The commands delrevprop, lstxns, rev-size, and setrevprop accept only
> a single revision number. However, the -r option help text implied
> that a revision range was accepted. Correct the -r option help text
> of aforementioned commands.

The log message contains an error: the corrected commands are:
delrevprop, rev-size, setlog, setrevprop

The help text of 'svnadmin lstxns' is correct and is unchanged.

Cheers,
Nathan

Re: svn commit: r1896898 - /subversion/branches/1.14.x/STATUS

2022-01-10 Thread Nathan Hartman 
On Mon, Jan 10, 2022 at 4:51 PM Daniel Sahlberg
 wrote:
>
> Den mån 10 jan. 2022 kl 22:45 skrev :
>>
>> Author: dsahlberg
>> Date: Mon Jan 10 21:45:27 2022
>> New Revision: 1896898
>>
>> URL: http://svn.apache.org/viewvc?rev=1896898&view=rev
>> Log:
>> * STATUS: Vote for r1896877
(snip)
> As far as I understand it, this change require three (or two, for a non-LTS) 
> votes, even though this is only a documentation fix, right?

Yes that's correct. It's in core code and a LTS release... I added the
3rd vote, approving, in r1896905.

Thanks,
Nathan

svn commit: r1896905 - /subversion/branches/1.14.x/STATUS

2022-01-10 Thread hartmannathan 
Author: hartmannathan
Date: Tue Jan 11 05:03:24 2022
New Revision: 1896905

URL: http://svn.apache.org/viewvc?rev=1896905&view=rev
Log:
* 1.14.x/STATUS: Vote for r1896877, approving.

Modified:
subversion/branches/1.14.x/STATUS

Modified: subversion/branches/1.14.x/STATUS
URL: 
http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1896905&r1=1896904&r2=1896905&view=diff
==
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Tue Jan 11 05:03:24 2022
@@ -115,13 +115,6 @@ Candidate changes:
 Votes:
   +1: stsp
 
-  * r1896877
-Fix misleading -r option documentation for some svnadmin subcommands.
-Justification:
-  Documentation should be correct.
-Votes:
-  +1: stsp, dsahlberg
-
 Veto-blocked changes:
 =
 
@@ -138,3 +131,10 @@ Veto-blocked changes:
 
 Approved changes:
 =
+
+  * r1896877
+Fix misleading -r option documentation for some svnadmin subcommands.
+Justification:
+  Documentation should be correct.
+Votes:
+  +1: stsp, dsahlberg, hartmannathan

Re: svn commit: r1896898 - /subversion/branches/1.14.x/STATUS

2022-01-10 Thread Daniel Sahlberg 
Den mån 10 jan. 2022 kl 22:45 skrev :

> Author: dsahlberg
> Date: Mon Jan 10 21:45:27 2022
> New Revision: 1896898
>
> URL: http://svn.apache.org/viewvc?rev=1896898&view=rev
> Log:
> * STATUS: Vote for r1896877
>
>
> Modified:
> subversion/branches/1.14.x/STATUS
>
> Modified: subversion/branches/1.14.x/STATUS
> URL:
> http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1896898&r1=1896897&r2=1896898&view=diff
>
> ==
> --- subversion/branches/1.14.x/STATUS (original)
> +++ subversion/branches/1.14.x/STATUS Mon Jan 10 21:45:27 2022
> @@ -120,7 +120,7 @@ Candidate changes:
>  Justification:
>Documentation should be correct.
>  Votes:
> -  +1: stsp
> +  +1: stsp, dsahlberg
>
>  Veto-blocked changes:
>  =
>
>
>
As far as I understand it, this change require three (or two, for a
non-LTS) votes, even though this is only a documentation fix, right?

/Daniel

svn commit: r1896898 - /subversion/branches/1.14.x/STATUS

2022-01-10 Thread dsahlberg 
Author: dsahlberg
Date: Mon Jan 10 21:45:27 2022
New Revision: 1896898

URL: http://svn.apache.org/viewvc?rev=1896898&view=rev
Log:
* STATUS: Vote for r1896877


Modified:
subversion/branches/1.14.x/STATUS

Modified: subversion/branches/1.14.x/STATUS
URL: 
http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1896898&r1=1896897&r2=1896898&view=diff
==
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Mon Jan 10 21:45:27 2022
@@ -120,7 +120,7 @@ Candidate changes:
 Justification:
   Documentation should be correct.
 Votes:
-  +1: stsp
+  +1: stsp, dsahlberg
 
 Veto-blocked changes:
 =

svn commit: r1896878 - /subversion/branches/1.14.x/STATUS

2022-01-10 Thread stsp 
Author: stsp
Date: Mon Jan 10 11:46:01 2022
New Revision: 1896878

URL: http://svn.apache.org/viewvc?rev=1896878&view=rev
Log:
* STATUS: Nominate r1896877.

Modified:
subversion/branches/1.14.x/STATUS

Modified: subversion/branches/1.14.x/STATUS
URL: 
http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1896878&r1=1896877&r2=1896878&view=diff
==
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Mon Jan 10 11:46:01 2022
@@ -115,6 +115,13 @@ Candidate changes:
 Votes:
   +1: stsp
 
+  * r1896877
+Fix misleading -r option documentation for some svnadmin subcommands.
+Justification:
+  Documentation should be correct.
+Votes:
+  +1: stsp
+
 Veto-blocked changes:
 =

svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2022-01-10 Thread stsp 
Author: stsp
Date: Mon Jan 10 11:44:46 2022
New Revision: 1896877

URL: http://svn.apache.org/viewvc?rev=1896877&view=rev
Log:
Fix misleading -r option documentation for some svnadmin subcommands.

The commands delrevprop, lstxns, rev-size, and setrevprop accept only
a single revision number. However, the -r option help text implied
that a revision range was accepted. Correct the -r option help text
of aforementioned commands.

The old text was:
  -r [--revision] ARG  : specify revision number ARG (or X:Y range)
The new text omits the reference to a revision range:
  -r [--revision] ARG  : specify revision number ARG

* subversion/svnadmin/svnadmin.c
  (cmd_table): Override -r option description for the devrevprop, lsxtns,
  rev-size, and setrevprop commands.

Modified:
subversion/trunk/subversion/svnadmin/svnadmin.c

Modified: subversion/trunk/subversion/svnadmin/svnadmin.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svnadmin/svnadmin.c?rev=1896877&r1=1896876&r2=1896877&view=diff
==
--- subversion/trunk/subversion/svnadmin/svnadmin.c (original)
+++ subversion/trunk/subversion/svnadmin/svnadmin.c Mon Jan 10 11:44:46 2022
@@ -352,7 +352,8 @@ static const svn_opt_subcommand_desc3_t
 "2. Delete the property NAME on transaction TXN.\n"
)},
{'r', 't', svnadmin__use_pre_revprop_change_hook,
-svnadmin__use_post_revprop_change_hook} },
+svnadmin__use_post_revprop_change_hook},
+   { {'r', "specify revision number ARG"} } },
 
   {"deltify", subcommand_deltify, {0}, {N_(
 "usage: svnadmin deltify [-r LOWER[:UPPER]] REPOS_PATH\n"
@@ -541,7 +542,8 @@ static const svn_opt_subcommand_desc3_t
 "The size includes revision properties and excludes FSFS indexes.\n"
)},
{'r', 'q', 'M'},
-   { {'q', "print only the size and a newline"} } },
+   { {'r', "specify revision number ARG"},
+ {'q', "print only the size and a newline"} }, },
 
   {"rmlocks", subcommand_rmlocks, {0}, {N_(
 "usage: svnadmin rmlocks REPOS_PATH LOCKED_PATH...\n"
@@ -570,7 +572,8 @@ static const svn_opt_subcommand_desc3_t
 "NOTE: Revision properties are not versioned, so this command will\n"
 "overwrite the previous log message.\n"
)},
-   {'r', svnadmin__bypass_hooks} },
+   {'r', svnadmin__bypass_hooks},
+   { {'r', "specify revision number ARG"} }, }, 
 
   {"setrevprop", subcommand_setrevprop, {0}, {N_(
 "usage: 1. svnadmin setrevprop REPOS_PATH -r REVISION NAME FILE\n"
@@ -588,7 +591,8 @@ static const svn_opt_subcommand_desc3_t
 "2. Set the property NAME on transaction TXN to the contents of FILE.\n"
)},
{'r', 't', svnadmin__use_pre_revprop_change_hook,
-svnadmin__use_post_revprop_change_hook} },
+svnadmin__use_post_revprop_change_hook},
+   { {'r', "specify revision number ARG"} }, }, 
 
   {"setuuid", subcommand_setuuid, {0}, {N_(
 "usage: svnadmin setuuid REPOS_PATH [NEW_UUID]\n"