Re: svn commit: r1869981 - /subversion/trunk/tools/dist/release.py

2019-11-19 Thread Daniel Shahaf
julianf...@apache.org wrote on Mon, 18 Nov 2019 16:31 +00:00:
> Author: julianfoad
> Date: Mon Nov 18 16:31:45 2019
> New Revision: 1869981
> 
> URL: http://svn.apache.org/viewvc?rev=1869981&view=rev
> Log:
> * tools/dist/release.py (recommended_release): Remove TODO: didn't make sense.

The point of that TODO is that instead of hardcoding
«recommended_release» in the source code, we can derive it from the version 
number being
rolled and the version numbers currently available for download.  This way, we 
won't have to
manually update «recommended_release» as part of the release process.

> +++ subversion/trunk/tools/dist/release.py Mon Nov 18 16:31:45 2019
> @@ -102,7 +102,6 @@ tool_versions['1.13'] = tool_versions['1
>  # The version that is our current recommended release
> -# ### TODO: derive this from svn_version.h; see ../../build/getversion.py
>  recommended_release = '1.13'
>  # For clean-dist, a whitelist of artifacts to keep, by version.
>  supported_release_lines = frozenset({"1.9", "1.10", "1.13"})


svn commit: r1869981 - /subversion/trunk/tools/dist/release.py

2019-11-18 Thread julianfoad
Author: julianfoad
Date: Mon Nov 18 16:31:45 2019
New Revision: 1869981

URL: http://svn.apache.org/viewvc?rev=1869981&view=rev
Log:
* tools/dist/release.py (recommended_release): Remove TODO: didn't make sense.

Modified:
subversion/trunk/tools/dist/release.py

Modified: subversion/trunk/tools/dist/release.py
URL: 
http://svn.apache.org/viewvc/subversion/trunk/tools/dist/release.py?rev=1869981&r1=1869980&r2=1869981&view=diff
==
--- subversion/trunk/tools/dist/release.py (original)
+++ subversion/trunk/tools/dist/release.py Mon Nov 18 16:31:45 2019
@@ -102,7 +102,6 @@ tool_versions['1.13'] = tool_versions['1
 tool_versions['trunk'] = tool_versions['1.10']
 
 # The version that is our current recommended release
-# ### TODO: derive this from svn_version.h; see ../../build/getversion.py
 recommended_release = '1.13'
 # For clean-dist, a whitelist of artifacts to keep, by version.
 supported_release_lines = frozenset({"1.9", "1.10", "1.13"})