svn commit: r1162126 - /tapestry/tapestry5/tags/5.3-beta-1/

2011-08-26 Thread hlship
Author: hlship
Date: Fri Aug 26 14:30:57 2011
New Revision: 1162126

URL: http://svn.apache.org/viewvc?rev=1162126view=rev
Log:
Tag 5.3-beta-1 after generating a release

Added:
tapestry/tapestry5/tags/5.3-beta-1/   (props changed)
  - copied from r1162125, tapestry/tapestry5/trunk/

Propchange: tapestry/tapestry5/tags/5.3-beta-1/
--
--- svn:ignore (added)
+++ svn:ignore Fri Aug 26 14:30:57 2011
@@ -0,0 +1,20 @@
+*.idea
+*.iml
+*.ipr
+*.iws
+.classpath
+.externalToolBuilders
+.gradle
+.project
+.settings
+bin
+bin-test
+build
+conf
+db
+hooks
+locks
+out
+target
+temp-testng-customsuite.xml
+test-output

Propchange: tapestry/tapestry5/tags/5.3-beta-1/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Fri Aug 26 14:30:57 2011
@@ -0,0 +1,4 @@
+/tapestry/tapestry5/branches/5.0:717929-719744,723395-728733
+/tapestry/tapestry5/branches/hlship-5.0-perf:726734-728728
+/tapestry/tapestry5/tags/releases/5.0.17:719745
+/tapestry/tapestry5/tags/releases/hlship-5.0-perf:726733




[jira] [Created] (TAP5-1620) Tml parsing expression error

2011-08-26 Thread Denis Stepanov (JIRA)
Tml parsing expression error


 Key: TAP5-1620
 URL: https://issues.apache.org/jira/browse/TAP5-1620
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.3
Reporter: Denis Stepanov


script
jQuery(function(){  
registerAutorefresh(${refresh});
});
/script


Caused by: java.lang.RuntimeException: Error parsing property expression 
'refresh});': Unable to parse input at character position 10.
at 
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.parse(PropertyConduitSourceImpl.java:1441)
 ~[tapestry-core-5.3-alpha-13.jar:na]
at 
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1309)
 ~[tapestry-core-5.3-alpha-13.jar:na]
at 
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1274)
 ~[tapestry-core-5.3-alpha-13.jar:na]
at $PropertyConduitSource_123d98bd5e9eaa20.create(Unknown Source) 
~[na:na]
at 
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
 ~[tapestry-core-5.3-alpha-13.jar:na]
at $BindingFactory_123d98bd5e9eaa21.newBinding(Unknown Source) ~[na:na]
at $BindingFactory_123d98bd5e9eaa18.newBinding(Unknown Source) ~[na:na]
at 
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:78)
 ~[tapestry-core-5.3-alpha-13.jar:na]
... 94 common frames omitted
Caused by: java.lang.RuntimeException: Unable to parse input at character 
position 10
at 
org.apache.tapestry5.internal.antlr.BaseLexer.reportError(BaseLexer.java:50) 
~[tapestry-core-5.3-alpha-13.jar:na]
at org.antlr.runtime.Lexer.nextToken(Lexer.java:94) ~[antlr.jar:na]
at 
org.antlr.runtime.CommonTokenStream.fillBuffer(CommonTokenStream.java:119) 
~[antlr.jar:na]
at org.antlr.runtime.CommonTokenStream.LT(CommonTokenStream.java:238) 
~[antlr.jar:na]
at 
org.apache.tapestry5.internal.antlr.PropertyExpressionParser.start(PropertyExpressionParser.java:98)
 ~[tapestry-core-5.3-alpha-13.jar:na]
at 
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.parse(PropertyConduitSourceImpl.java:1437)
 ~[tapestry-core-5.3-alpha-13.jar:na]
... 101 common frames omitted
Caused by: org.antlr.runtime.NoViableAltException: null
at org.antlr.runtime.DFA.noViableAlt(DFA.java:158) ~[antlr.jar:na]
at org.antlr.runtime.DFA.predict(DFA.java:116) ~[antlr.jar:na]
at 
org.apache.tapestry5.internal.antlr.PropertyExpressionLexer.mTokens(PropertyExpressionLexer.java:1273)
 ~[tapestry-core-5.3-alpha-13.jar:na]
at org.antlr.runtime.Lexer.nextToken(Lexer.java:84) ~[antlr.jar:na]
... 105 common frames omitted

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (TAP5-1621) TypeCoercer currently uses Object - String and String - Boolean, there should be a direct coercion from Object - Boolean for t:if/ performance.

2011-08-26 Thread Josh Canfield (JIRA)
TypeCoercer currently uses Object - String and String - Boolean, there should 
be a direct coercion from Object - Boolean for t:if/ performance.


 Key: TAP5-1621
 URL: https://issues.apache.org/jira/browse/TAP5-1621
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.3
Reporter: Josh Canfield


An issue was raised in this thread:
http://tapestry.1045711.n5.nabble.com/Null-check-property-expression-syntax-td4726386.html

Describing the problem where:

t:if test=MyObject

causes MyObject to be coerced to a String before being coerced to a Boolean. 
For some objects this may be an expensive operation, and the common case (how 
often is the Entity you are editing on a page actually null?)

Adding an explicit Object - Boolean coercion will remove the need for the 
Object - String coercion.

A Number - Boolean coercion is also required to prevent Integer - Boolean 
from choosing the Object - Boolean as a match (currently it goes Integer - 
Long - Boolean)

At this point the only known issue is that any POJO that depends on the fact 
that returning false from toString will cause the Object - String - Boolean 
to return false will be broken. This seems like an unlikely case and can be 
worked around by providing a specific TypeCoercion for that object.




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (TAP5-1621) TypeCoercer currently uses Object - String and String - Boolean, there should be a direct coercion from Object - Boolean for t:if/ performance.

2011-08-26 Thread Josh Canfield (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091870#comment-13091870
 ] 

Josh Canfield commented on TAP5-1621:
-

A workaround is to add the following coercions to your AppModule. 

public static void contributeTypeCoercer(ConfigurationCoercionTuple 
configuration) {
/**
 * Prevent toString() conversion to get to boolean
 */
configuration.add(CoercionTuple.create(Object.class, Boolean.class,
new CoercionObject, Boolean() {
public Boolean coerce(Object input) {
return input != null;
}
}));
/**
 * Number - Boolean - make sure that Object - Boolean isn't used!
 */
configuration.add(CoercionTuple.create(Number.class, Boolean.class,
new CoercionNumber, Boolean() {
public Boolean coerce(Number input) {
return input.byteValue() != 0;
}
}));
}

 TypeCoercer currently uses Object - String and String - Boolean, there 
 should be a direct coercion from Object - Boolean for t:if/ performance.
 

 Key: TAP5-1621
 URL: https://issues.apache.org/jira/browse/TAP5-1621
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.3
Reporter: Josh Canfield

 An issue was raised in this thread:
 http://tapestry.1045711.n5.nabble.com/Null-check-property-expression-syntax-td4726386.html
 Describing the problem where:
 t:if test=MyObject
 causes MyObject to be coerced to a String before being coerced to a Boolean. 
 For some objects this may be an expensive operation, and the common case (how 
 often is the Entity you are editing on a page actually null?)
 Adding an explicit Object - Boolean coercion will remove the need for the 
 Object - String coercion.
 A Number - Boolean coercion is also required to prevent Integer - Boolean 
 from choosing the Object - Boolean as a match (currently it goes Integer - 
 Long - Boolean)
 At this point the only known issue is that any POJO that depends on the fact 
 that returning false from toString will cause the Object - String - 
 Boolean to return false will be broken. This seems like an unlikely case and 
 can be worked around by providing a specific TypeCoercion for that object.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Assigned] (TAP5-1620) Tml parsing expression error

2011-08-26 Thread Robert Zeigler (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Zeigler reassigned TAP5-1620:


Assignee: Robert Zeigler

 Tml parsing expression error
 

 Key: TAP5-1620
 URL: https://issues.apache.org/jira/browse/TAP5-1620
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.3
Reporter: Denis Stepanov
Assignee: Robert Zeigler

 script
   jQuery(function(){  
   registerAutorefresh(${refresh});
   });
   /script
 Caused by: java.lang.RuntimeException: Error parsing property expression 
 'refresh});': Unable to parse input at character position 10.
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.parse(PropertyConduitSourceImpl.java:1441)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1309)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1274)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at $PropertyConduitSource_123d98bd5e9eaa20.create(Unknown Source) 
 ~[na:na]
   at 
 org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at $BindingFactory_123d98bd5e9eaa21.newBinding(Unknown Source) ~[na:na]
   at $BindingFactory_123d98bd5e9eaa18.newBinding(Unknown Source) ~[na:na]
   at 
 org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:78)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   ... 94 common frames omitted
 Caused by: java.lang.RuntimeException: Unable to parse input at character 
 position 10
   at 
 org.apache.tapestry5.internal.antlr.BaseLexer.reportError(BaseLexer.java:50) 
 ~[tapestry-core-5.3-alpha-13.jar:na]
   at org.antlr.runtime.Lexer.nextToken(Lexer.java:94) ~[antlr.jar:na]
   at 
 org.antlr.runtime.CommonTokenStream.fillBuffer(CommonTokenStream.java:119) 
 ~[antlr.jar:na]
   at org.antlr.runtime.CommonTokenStream.LT(CommonTokenStream.java:238) 
 ~[antlr.jar:na]
   at 
 org.apache.tapestry5.internal.antlr.PropertyExpressionParser.start(PropertyExpressionParser.java:98)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.parse(PropertyConduitSourceImpl.java:1437)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   ... 101 common frames omitted
 Caused by: org.antlr.runtime.NoViableAltException: null
   at org.antlr.runtime.DFA.noViableAlt(DFA.java:158) ~[antlr.jar:na]
   at org.antlr.runtime.DFA.predict(DFA.java:116) ~[antlr.jar:na]
   at 
 org.apache.tapestry5.internal.antlr.PropertyExpressionLexer.mTokens(PropertyExpressionLexer.java:1273)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at org.antlr.runtime.Lexer.nextToken(Lexer.java:84) ~[antlr.jar:na]
   ... 105 common frames omitted

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (TAP5-1620) Tml parsing expression error

2011-08-26 Thread Robert Zeigler (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092060#comment-13092060
 ] 

Robert Zeigler commented on TAP5-1620:
--

Looks like my fix for maps in template expressions is a little too greedy. 

 Tml parsing expression error
 

 Key: TAP5-1620
 URL: https://issues.apache.org/jira/browse/TAP5-1620
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.3
Reporter: Denis Stepanov
Assignee: Robert Zeigler

 script
   jQuery(function(){  
   registerAutorefresh(${refresh});
   });
   /script
 Caused by: java.lang.RuntimeException: Error parsing property expression 
 'refresh});': Unable to parse input at character position 10.
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.parse(PropertyConduitSourceImpl.java:1441)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1309)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1274)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at $PropertyConduitSource_123d98bd5e9eaa20.create(Unknown Source) 
 ~[na:na]
   at 
 org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at $BindingFactory_123d98bd5e9eaa21.newBinding(Unknown Source) ~[na:na]
   at $BindingFactory_123d98bd5e9eaa18.newBinding(Unknown Source) ~[na:na]
   at 
 org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:78)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   ... 94 common frames omitted
 Caused by: java.lang.RuntimeException: Unable to parse input at character 
 position 10
   at 
 org.apache.tapestry5.internal.antlr.BaseLexer.reportError(BaseLexer.java:50) 
 ~[tapestry-core-5.3-alpha-13.jar:na]
   at org.antlr.runtime.Lexer.nextToken(Lexer.java:94) ~[antlr.jar:na]
   at 
 org.antlr.runtime.CommonTokenStream.fillBuffer(CommonTokenStream.java:119) 
 ~[antlr.jar:na]
   at org.antlr.runtime.CommonTokenStream.LT(CommonTokenStream.java:238) 
 ~[antlr.jar:na]
   at 
 org.apache.tapestry5.internal.antlr.PropertyExpressionParser.start(PropertyExpressionParser.java:98)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at 
 org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.parse(PropertyConduitSourceImpl.java:1437)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   ... 101 common frames omitted
 Caused by: org.antlr.runtime.NoViableAltException: null
   at org.antlr.runtime.DFA.noViableAlt(DFA.java:158) ~[antlr.jar:na]
   at org.antlr.runtime.DFA.predict(DFA.java:116) ~[antlr.jar:na]
   at 
 org.apache.tapestry5.internal.antlr.PropertyExpressionLexer.mTokens(PropertyExpressionLexer.java:1273)
  ~[tapestry-core-5.3-alpha-13.jar:na]
   at org.antlr.runtime.Lexer.nextToken(Lexer.java:84) ~[antlr.jar:na]
   ... 105 common frames omitted

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira