[jira] [Commented] (TAP5-2244) T5.4 tapestry-core integration test app3/renderpagedemo exhibits shady requirejs behavior
[ https://issues.apache.org/jira/browse/TAP5-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014532#comment-14014532 ] Hudson commented on TAP5-2244: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1228 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1228/]) TAP5-2244 (thiagohp: rev edb93e7da346d07dbb22bf2610a89808dc802ddd) * tapestry-core/src/test/app3/RenderPageDemo.tml > T5.4 tapestry-core integration test app3/renderpagedemo exhibits shady > requirejs behavior > - > > Key: TAP5-2244 > URL: https://issues.apache.org/jira/browse/TAP5-2244 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Chris Poulsen > > The error can be seen by firing up the app3 from an editor and visiting > /renderpagedemo - The console error is: "TypeError: require is not a > function". > From the page source it seems that all the javascript for requirejs > configuration/initialization is included twice in the page. > This error can also be reproduced using the adjustments from TAP5-2239 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2259) Select should allow secure="never", but requires secure="literal:never"
[ https://issues.apache.org/jira/browse/TAP5-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014531#comment-14014531 ] Hudson commented on TAP5-2259: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1228 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1228/]) TAP5-2259 : Select should allow secure=never, but requires secure=literal:never (thiagohp: rev 05be6ec9b6262c0fbe1fd38814667954a72cf7d5) * tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java > Select should allow secure="never", but requires secure="literal:never" > --- > > Key: TAP5-2259 > URL: https://issues.apache.org/jira/browse/TAP5-2259 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Geoff Callender >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: month-of-tapestry > > Select's secure parameter is new to 5.4 and it would be nice to change this > before the first release. > Select should allow secure="never" instead of secure="literal:never". > Currently the default is PROP, but I'm hard-pressed to think of a case where > you'd want to set it with a property. > Some useful precedents: > - Select allows blankoption="always". > - TextField allows nulls="zero". > - Any AbstractField allows disabled="true". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014533#comment-14014533 ] Hudson commented on TAP5-2330: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1228 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1228/]) TAP5-2330 : NullPointerException when updating a Zone with no clientId (thiagohp: rev 01a1439c4a520cf5425415e0ed6a9fa51d386df1) * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java * tapestry-json/src/main/java/org/apache/tapestry5/json/JSONObject.java * tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java * tapestry-core/src/test/app1/nested/ZoneDemo.tml > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (TAP5-2232) Element#addClassName can create an additional new 'class' attribute
[
https://issues.apache.org/jira/browse/TAP5-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo reassigned TAP5-2232:
---
Assignee: Thiago H. de Paula Figueiredo
> Element#addClassName can create an additional new 'class' attribute
> ---
>
> Key: TAP5-2232
> URL: https://issues.apache.org/jira/browse/TAP5-2232
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.3.7
>Reporter: Matej Krchniak
>Assignee: Thiago H. de Paula Figueiredo
>
> When using Element#addClassName (in mixing enhancing component class), I
> noticed that I was getting two 'class' attributes in my element - rather than
> the one I was expecting. First I bumped into TAP5-708 and TAP5-804, which
> seem to fix only some part of the problem.
> Code in TAP5-804 will produce correct result and even the tests. But there is
> stil one situation, where there are two class attributes generated. Consider
> this code:
> Navbar.tml:
>
> ...
>
> Code from mixin:
> element.addClassName("navbar-fixed-top")
> Produces this output:
>
> Problem is that SaxTemplateParser provides "" namespace and
> Element.addClassName will use null namespace, so another class attribute is
> added. Tests will pass, because Element.attribute provides null namespace.
> But I want to add another class name to one present in template.
> Interesting part of TAP5-708 is that supplied patch changed default namespace
> in Element.attribute and in Element.forceAttributes from null to "". So
> states event this comment:
> https://issues.apache.org/jira/browse/TAP5-708?focusedCommentId=12773672&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12773672.
> But this change is not present in source code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (TAP5-2263) IOC decorator matching bug
[
https://issues.apache.org/jira/browse/TAP5-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo reassigned TAP5-2263:
---
Assignee: Thiago H. de Paula Figueiredo
> IOC decorator matching bug
> --
>
> Key: TAP5-2263
> URL: https://issues.apache.org/jira/browse/TAP5-2263
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.4
>Reporter: Adriaan Joubert
>Assignee: Thiago H. de Paula Figueiredo
> Labels: easyfix
>
> In our implementation we have a factory service CacheFactory, with markers,
> that is injected into a Cache service with the same markers (say @MarkerA).
> In tests, I wish to replace the CacheFactory with
> @Decorate
> @MarkerA
> public CacheFactory decorate(...) {}
> However I get an error that the decorate method returns the wrong type.
> The cause is that the matching of the decorators in the module implementation
> does not match on ServiceDef and markers. Specifically in
> ModuleImpl.findMatchingDecoratorDefs there is a condition
> if (def.matches(serviceDef) || markerMatched(serviceDef,
> InternalUtils.toDecoratorDef2(def)))
> result.add(def);
> which needs to be
> if (def.matches(serviceDef) && markerMatched(serviceDef,
> InternalUtils.toDecoratorDef2(def)))
> result.add(def);
> to fix the problem. With the || it matches unrelated service definitions with
> the same markers.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (TAP5-2259) Select should allow secure="never", but requires secure="literal:never"
[ https://issues.apache.org/jira/browse/TAP5-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-2259. - Resolution: Fixed > Select should allow secure="never", but requires secure="literal:never" > --- > > Key: TAP5-2259 > URL: https://issues.apache.org/jira/browse/TAP5-2259 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Geoff Callender >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: month-of-tapestry > > Select's secure parameter is new to 5.4 and it would be nice to change this > before the first release. > Select should allow secure="never" instead of secure="literal:never". > Currently the default is PROP, but I'm hard-pressed to think of a case where > you'd want to set it with a property. > Some useful precedents: > - Select allows blankoption="always". > - TextField allows nulls="zero". > - Any AbstractField allows disabled="true". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2259) Select should allow secure="never", but requires secure="literal:never"
[ https://issues.apache.org/jira/browse/TAP5-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2259: Assignee: Thiago H. de Paula Figueiredo (was: Bob Harner) Labels: month-of-tapestry (was: ) > Select should allow secure="never", but requires secure="literal:never" > --- > > Key: TAP5-2259 > URL: https://issues.apache.org/jira/browse/TAP5-2259 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Geoff Callender >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: month-of-tapestry > > Select's secure parameter is new to 5.4 and it would be nice to change this > before the first release. > Select should allow secure="never" instead of secure="literal:never". > Currently the default is PROP, but I'm hard-pressed to think of a case where > you'd want to set it with a property. > Some useful precedents: > - Select allows blankoption="always". > - TextField allows nulls="zero". > - Any AbstractField allows disabled="true". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2259) Select should allow secure="never", but requires secure="literal:never"
[ https://issues.apache.org/jira/browse/TAP5-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014503#comment-14014503 ] ASF subversion and git services commented on TAP5-2259: --- Commit 05be6ec9b6262c0fbe1fd38814667954a72cf7d5 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=05be6ec ] TAP5-2259 : Select should allow secure=never, but requires secure=literal:never > Select should allow secure="never", but requires secure="literal:never" > --- > > Key: TAP5-2259 > URL: https://issues.apache.org/jira/browse/TAP5-2259 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Geoff Callender >Assignee: Bob Harner >Priority: Minor > > Select's secure parameter is new to 5.4 and it would be nice to change this > before the first release. > Select should allow secure="never" instead of secure="literal:never". > Currently the default is PROP, but I'm hard-pressed to think of a case where > you'd want to set it with a property. > Some useful precedents: > - Select allows blankoption="always". > - TextField allows nulls="zero". > - Any AbstractField allows disabled="true". -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2259 : Select should allow secure=never, but requires secure=literal:never
Repository: tapestry-5 Updated Branches: refs/heads/master edb93e7da -> 05be6ec9b TAP5-2259 : Select should allow secure=never, but requires secure=literal:never Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/05be6ec9 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/05be6ec9 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/05be6ec9 Branch: refs/heads/master Commit: 05be6ec9b6262c0fbe1fd38814667954a72cf7d5 Parents: edb93e7 Author: Thiago H. de Paula Figueiredo Authored: Sat May 31 01:07:41 2014 -0300 Committer: Thiago H. de Paula Figueiredo Committed: Sat May 31 01:07:41 2014 -0300 -- .../main/java/org/apache/tapestry5/corelib/components/Select.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/05be6ec9/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java -- diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java index cbc2993..7c13a46 100644 --- a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java +++ b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java @@ -90,7 +90,7 @@ public class Select extends AbstractField * * @since 5.4 */ -@Parameter(value = BindingConstants.SYMBOL + ":" + ComponentParameterConstants.VALIDATE_WITH_MODEL) +@Parameter(value = BindingConstants.SYMBOL + ":" + ComponentParameterConstants.VALIDATE_WITH_MODEL, defaultPrefix = BindingConstants.LITERAL) private SecureOption secure; /**
[jira] [Commented] (TAP5-2255) Form and BeanEditForm differ in JSR-303 detection
[
https://issues.apache.org/jira/browse/TAP5-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014502#comment-14014502
]
Thiago H. de Paula Figueiredo commented on TAP5-2255:
-
Geoff, could you please test this again? There was a fix in
tapestry-beanvalidator that may have fixed this issue.
> Form and BeanEditForm differ in JSR-303 detection
> -
>
> Key: TAP5-2255
> URL: https://issues.apache.org/jira/browse/TAP5-2255
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-beanvalidator, tapestry-core
>Affects Versions: 5.4
>Reporter: Geoff Callender
>
> I have an entity field that the getter and setter convert between types
> (field is Date, getter and setter convert from/to JodaTime's DateMidnight).
> Form detects @NotNull on the field, but BeanEditForm doesn't. BeanEditForm
> detects @NotNull on the getter, but Form doesn't. So I have to provide
> @NotNull on the field AND the getter. Shouldn't Form and BeanEditForm behave
> the same?
> For example, a snippet from an entity:
> @Entity
> public class DatesExample implements Serializable {
> // This JSR-303 validation will be picked up by Form.
> @NotNull
> private java.sql.Date aDateMidnight;
> // This JSR-303 validation will be picked up by BeanEditForm.
> @NotNull
> public DateMidnight getADateMidnight() {
> return JodaTimeUtil.toDateMidnight(aDateMidnight);
> }
> public void setADateMidnight(DateMidnight dm) {
> this.aDateMidnight = JodaTimeUtil.toSQLDate(dm);
> }
> }
> I've contributed type coercers in AppModule:
> public static void contributeTypeCoercer(Configuration
> configuration) {
>// From java.util.Date to DateMidnight
> Coercion toDateMidnight = new
> Coercion() {
> public DateMidnight coerce(java.util.Date input) {
> // TODO - confirm this conversion always works, esp. across
> timezones
> return JodaTimeUtil.toDateMidnight(input);
> }
> };
> configuration.add(new CoercionTuple<>(java.util.Date.class,
> DateMidnight.class, toDateMidnight));
> // From DateMidnight to java.util.Date
> Coercion fromDateMidnight = new
> Coercion() {
> public java.util.Date coerce(DateMidnight input) {
> // TODO - confirm this conversion always works, esp. across
> timezones
> return JodaTimeUtil.toJavaDate(input);
> }
> };
> configuration.add(new CoercionTuple<>(DateMidnight.class,
> java.util.Date.class, fromDateMidnight));
> }
> and I've contributed an editor:
> public static void
> contributeBeanBlockSource(Configuration configuration)
> {
> configuration.add(new EditBlockContribution("dateMidnight",
> "infra/AppPropertyEditBlocks", "dateMidnight"));
> }
> Here is the editor:
> xmlns:t="http://tapestry.apache.org/schema/tapestry_5_4.xsd";>
>
>
> value="context.propertyValue" label="prop:context.label"
> format="prop:dateInputFormat"
> translate="prop:dateMidnightTranslator" validate="prop:dateMidnightValidator"
> clientId="prop:context.propertyId" annotationProvider="context"/>
>
>
> public class AppPropertyEditBlocks {
> @Property
> @Environmental
> private PropertyEditContext context;
> @Component
> private DateField dateMidnight;
> @Component
> private DateField localDate;
>
> public DateFormat getDateInputFormat() {
> return new SimpleDateFormat("dd ");
> }
>
> public FieldTranslator getDateMidnightTranslator() {
> return context.getTranslator(dateMidnight);
> }
>
> public FieldValidator getDateMidnightValidator() {
> return context.getValidator(dateMidnight);
> }
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TAP5-2245) select component: selected option is not listed in the model.
[
https://issues.apache.org/jira/browse/TAP5-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014501#comment-14014501
]
Thiago H. de Paula Figueiredo commented on TAP5-2245:
-
So do you guys think this is a bug in Java or in Sven's code? If the latter,
I'd like to close the ticket.
> select component: selected option is not listed in the model.
> -
>
> Key: TAP5-2245
> URL: https://issues.apache.org/jira/browse/TAP5-2245
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Sven Homburg
> Labels: regression
> Attachments: ScreenDump.pdf
>
>
> @Component
> private Zone previewZone;
> @Component(parameters = {"value=previewMonth", "model=[1,3,6]",
> "zone=previewZone"})
> private Select previewSelect;
> @OnEvent(component = "previewSelect", value = EventConstants.VALUE_CHANGED)
> void onValueChangedFromPreviewSelect(long result)
> {
> if (selectedDate == null)
> selectedDate = LocalDate.now();
> selectedDate = selectedDate.plusMonths((int) (result - 1));
> ajaxResponseRenderer.addRender("previewZone", previewZone);
> }
> After selecting a value in select component the following error message
> occoures:
> "Selected option is not listed in the model."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (TAP5-2244) T5.4 tapestry-core integration test app3/renderpagedemo exhibits shady requirejs behavior
[
https://issues.apache.org/jira/browse/TAP5-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo closed TAP5-2244.
---
Resolution: Not a Problem
This is not actually a problem. As Jochen said, the rendered page ends up
having two pieces of page JS initialization because a whole page is included
inside the other. That page is just to show what can be done with
PageDocumentGenerator and easily see that it renders a whole page to a Document
and from it to a String. Anyway, I've changed the page inclusion from OutputRaw
(unfiltered) to ${} expansion (filtered), which avoids any JS exceptions.
> T5.4 tapestry-core integration test app3/renderpagedemo exhibits shady
> requirejs behavior
> -
>
> Key: TAP5-2244
> URL: https://issues.apache.org/jira/browse/TAP5-2244
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Chris Poulsen
>
> The error can be seen by firing up the app3 from an editor and visiting
> /renderpagedemo - The console error is: "TypeError: require is not a
> function".
> From the page source it seems that all the javascript for requirejs
> configuration/initialization is included twice in the page.
> This error can also be reproduced using the adjustments from TAP5-2239
--
This message was sent by Atlassian JIRA
(v6.2#6252)
git commit: TAP5-2244
Repository: tapestry-5
Updated Branches:
refs/heads/master 01a1439c4 -> edb93e7da
TAP5-2244
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/edb93e7d
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/edb93e7d
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/edb93e7d
Branch: refs/heads/master
Commit: edb93e7da346d07dbb22bf2610a89808dc802ddd
Parents: 01a1439
Author: Thiago H. de Paula Figueiredo
Authored: Sat May 31 00:57:22 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Sat May 31 00:57:22 2014 -0300
--
tapestry-core/src/test/app3/RenderPageDemo.tml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/edb93e7d/tapestry-core/src/test/app3/RenderPageDemo.tml
--
diff --git a/tapestry-core/src/test/app3/RenderPageDemo.tml
b/tapestry-core/src/test/app3/RenderPageDemo.tml
index 422653c..d1302fd 100644
--- a/tapestry-core/src/test/app3/RenderPageDemo.tml
+++ b/tapestry-core/src/test/app3/RenderPageDemo.tml
@@ -9,7 +9,7 @@
-
+${pageContent}
[jira] [Commented] (TAP5-2244) T5.4 tapestry-core integration test app3/renderpagedemo exhibits shady requirejs behavior
[ https://issues.apache.org/jira/browse/TAP5-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014500#comment-14014500 ] ASF subversion and git services commented on TAP5-2244: --- Commit edb93e7da346d07dbb22bf2610a89808dc802ddd in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=edb93e7 ] TAP5-2244 > T5.4 tapestry-core integration test app3/renderpagedemo exhibits shady > requirejs behavior > - > > Key: TAP5-2244 > URL: https://issues.apache.org/jira/browse/TAP5-2244 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Chris Poulsen > > The error can be seen by firing up the app3 from an editor and visiting > /renderpagedemo - The console error is: "TypeError: require is not a > function". > From the page source it seems that all the javascript for requirejs > configuration/initialization is included twice in the page. > This error can also be reproduced using the adjustments from TAP5-2239 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-2320) Tapestry 5.3.7 does not run with Java 8
[ https://issues.apache.org/jira/browse/TAP5-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-2320. - Resolution: Fixed > Tapestry 5.3.7 does not run with Java 8 > --- > > Key: TAP5-2320 > URL: https://issues.apache.org/jira/browse/TAP5-2320 > Project: Tapestry 5 > Issue Type: Bug > Components: plastic >Affects Versions: 5.3.7 >Reporter: Lenny Primak >Priority: Critical > > Tapestry 5.3.7 does not run on Java 8 due to ASM issues. > The same fix applied to Tapestry 5.4 should be applied to Tapestry 5.3 > and 5.3.8 should be release. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2290) Support for assets from WebJars
[
https://issues.apache.org/jira/browse/TAP5-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo updated TAP5-2290:
Priority: Minor (was: Major)
> Support for assets from WebJars
> ---
>
> Key: TAP5-2290
> URL: https://issues.apache.org/jira/browse/TAP5-2290
> Project: Tapestry 5
> Issue Type: Wish
>Affects Versions: 5.4
>Reporter: Jochen Kemnade
>Priority: Minor
>
> from webjars.org: "WebJars are client-side web libraries (e.g. jQuery &
> Bootstrap) packaged into JAR (Java Archive) files."
> They are available from Maven Central and you can include them as regular
> dependencies in your builds, as in {{dependencies.compile
> 'org.webjars:jquery:2.1.0-2'}}.
> There should be custom asset prefix and a corresponding {{AssetFactory}} that
> can create assets from those WebJars ({e.g. {asset:webjars:jquery.js}}).
> I have an implementation as a separate module that I could contribute.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-2325) Minification cache warming
[ https://issues.apache.org/jira/browse/TAP5-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2325: Priority: Minor (was: Major) > Minification cache warming > -- > > Key: TAP5-2325 > URL: https://issues.apache.org/jira/browse/TAP5-2325 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Priority: Minor > > It should be possible to configure that certain resources that should be > minified during the application startup, the rationale being that it can take > some time to minify large assets and that can lead to timeouts in requirejs > when the resource is requested for the first time. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-2342) NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950)
[ https://issues.apache.org/jira/browse/TAP5-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-2342. - Resolution: Fixed Fix Version/s: 5.4 Thanks for reporting and the patch, Basile! I ended up not using your patch because it also changes unrelated files and my fix had a different approach. > NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > --- > > Key: TAP5-2342 > URL: https://issues.apache.org/jira/browse/TAP5-2342 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-json >Affects Versions: 5.4 >Reporter: Basile Chandesris >Assignee: Thiago H. de Paula Figueiredo > Labels: js, json, null, select > Fix For: 5.4 > > Attachments: JSONObject_printValue_NPE_fix2.patch > > > Caused by: java.lang.NullPointerException: null > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONArray.print(JSONArray.java:464) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:922) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONArray.print(JSONArray.java:464) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:922) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.print(JSONObject.java:893) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:916) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.print(JSONObject.java:893) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONCollection.print(JSONCollection.java:96) > ~[tapestry-json-5.4-beta-5.jar:na] > at > org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl$1.perform(AjaxPartialResponseRendererImpl.java:92) > ~[tapestry-core-5.4-beta-5.jar:na] > at > org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl$1.perform(AjaxPartialResponseRendererImpl.java:73) > ~[tapestry-core-5.4-beta-5.jar:na] > at > org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:107) > ~[tapestry-ioc-5.4-beta-5.jar:na] > ... 72 common frames omitted > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Tapestry-5-3-6-JSONObject-No-null-checking-leads-to-NPE-in-Palette-component-td5723454.html > http://markmail.org/message/cbtowahbstccc5vv > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/svn-commit-r944571-in-tapestry-tapestry5-trunk-tapestry-core-src-main-java-org-apache-tapestry5-main-td2469979.html > http://mail-archives.apache.org/mod_mbox/tapestry-users/201310.mbox/%3ccan7z0vscl9+sz11h3bpovu8j2erq6oaclv4xebxijskpt7k...@mail.gmail.com%3E > http://web.archiveorange.com/archive/v/IKzu7D6rCfDUfiEiOl2K -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (TAP5-2342) NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950)
[ https://issues.apache.org/jira/browse/TAP5-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo reassigned TAP5-2342: --- Assignee: Thiago H. de Paula Figueiredo > NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > --- > > Key: TAP5-2342 > URL: https://issues.apache.org/jira/browse/TAP5-2342 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-json >Affects Versions: 5.4 >Reporter: Basile Chandesris >Assignee: Thiago H. de Paula Figueiredo > Labels: js, json, null, select > Attachments: JSONObject_printValue_NPE_fix2.patch > > > Caused by: java.lang.NullPointerException: null > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONArray.print(JSONArray.java:464) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:922) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONArray.print(JSONArray.java:464) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:922) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.print(JSONObject.java:893) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:916) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.print(JSONObject.java:893) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONCollection.print(JSONCollection.java:96) > ~[tapestry-json-5.4-beta-5.jar:na] > at > org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl$1.perform(AjaxPartialResponseRendererImpl.java:92) > ~[tapestry-core-5.4-beta-5.jar:na] > at > org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl$1.perform(AjaxPartialResponseRendererImpl.java:73) > ~[tapestry-core-5.4-beta-5.jar:na] > at > org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:107) > ~[tapestry-ioc-5.4-beta-5.jar:na] > ... 72 common frames omitted > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Tapestry-5-3-6-JSONObject-No-null-checking-leads-to-NPE-in-Palette-component-td5723454.html > http://markmail.org/message/cbtowahbstccc5vv > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/svn-commit-r944571-in-tapestry-tapestry5-trunk-tapestry-core-src-main-java-org-apache-tapestry5-main-td2469979.html > http://mail-archives.apache.org/mod_mbox/tapestry-users/201310.mbox/%3ccan7z0vscl9+sz11h3bpovu8j2erq6oaclv4xebxijskpt7k...@mail.gmail.com%3E > http://web.archiveorange.com/archive/v/IKzu7D6rCfDUfiEiOl2K -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-2330. - Resolution: Fixed I know this fix won't work with a Zone with no given clientId and that was already rendered via AJAX inside an outer Zone, but it's still better than nothing. At least it fixes the most common cases. > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2330: Fix Version/s: 5.4 Labels: month-of-tapestry (was: ) > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo reassigned TAP5-2330: --- Assignee: Thiago H. de Paula Figueiredo > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014489#comment-14014489 ] Thiago H. de Paula Figueiredo commented on TAP5-2330: - Thanks for the test, Jochen! I've used it in this fix. :-) > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Priority: Critical > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2342) NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950)
[ https://issues.apache.org/jira/browse/TAP5-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014487#comment-14014487 ] ASF subversion and git services commented on TAP5-2342: --- Commit 01a1439c4a520cf5425415e0ed6a9fa51d386df1 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=01a1439 ] TAP5-2330 : NullPointerException when updating a Zone with no clientId TAP5-2342 : NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > --- > > Key: TAP5-2342 > URL: https://issues.apache.org/jira/browse/TAP5-2342 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-json >Affects Versions: 5.4 >Reporter: Basile Chandesris > Labels: js, json, null, select > Attachments: JSONObject_printValue_NPE_fix2.patch > > > Caused by: java.lang.NullPointerException: null > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONArray.print(JSONArray.java:464) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:922) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONArray.print(JSONArray.java:464) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:922) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.print(JSONObject.java:893) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:916) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONObject.print(JSONObject.java:893) > ~[tapestry-json-5.4-beta-5.jar:na] > at org.apache.tapestry5.json.JSONCollection.print(JSONCollection.java:96) > ~[tapestry-json-5.4-beta-5.jar:na] > at > org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl$1.perform(AjaxPartialResponseRendererImpl.java:92) > ~[tapestry-core-5.4-beta-5.jar:na] > at > org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl$1.perform(AjaxPartialResponseRendererImpl.java:73) > ~[tapestry-core-5.4-beta-5.jar:na] > at > org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:107) > ~[tapestry-ioc-5.4-beta-5.jar:na] > ... 72 common frames omitted > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Tapestry-5-3-6-JSONObject-No-null-checking-leads-to-NPE-in-Palette-component-td5723454.html > http://markmail.org/message/cbtowahbstccc5vv > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/svn-commit-r944571-in-tapestry-tapestry5-trunk-tapestry-core-src-main-java-org-apache-tapestry5-main-td2469979.html > http://mail-archives.apache.org/mod_mbox/tapestry-users/201310.mbox/%3ccan7z0vscl9+sz11h3bpovu8j2erq6oaclv4xebxijskpt7k...@mail.gmail.com%3E > http://web.archiveorange.com/archive/v/IKzu7D6rCfDUfiEiOl2K -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014486#comment-14014486 ] ASF subversion and git services commented on TAP5-2330: --- Commit 01a1439c4a520cf5425415e0ed6a9fa51d386df1 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=01a1439 ] TAP5-2330 : NullPointerException when updating a Zone with no clientId TAP5-2342 : NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Priority: Critical > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2330 : NullPointerException when updating a Zone with no clientId TAP5-2342 : NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950)
Repository: tapestry-5
Updated Branches:
refs/heads/master d96b5534f -> 01a1439c4
TAP5-2330 : NullPointerException when updating a Zone with no clientId
TAP5-2342 : NPE on
org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950)
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/01a1439c
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/01a1439c
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/01a1439c
Branch: refs/heads/master
Commit: 01a1439c4a520cf5425415e0ed6a9fa51d386df1
Parents: d96b553
Author: Thiago H. de Paula Figueiredo
Authored: Sat May 31 00:07:47 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Sat May 31 00:07:47 2014 -0300
--
.../tapestry5/corelib/components/Zone.java | 6 ++
tapestry-core/src/test/app1/nested/ZoneDemo.tml | 1 +
.../tapestry5/integration/app1/ZoneTests.java | 20
.../integration/app1/pages/nested/ZoneDemo.java | 6 ++
.../org/apache/tapestry5/json/JSONObject.java | 6 ++
5 files changed, 39 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/01a1439c/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java
index f79b286..a04524a 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java
@@ -250,6 +250,12 @@ public class Zone implements ClientBodyElement
{
if (resources.isBound("id"))
return idParameter;
+
+// TAP4-2342. I know this won't work with a Zone with no given
clientId and that was already
+// via AJAX inside an outer Zone, but it's still better than nothing.
+if (clientId == null) {
+clientId = resources.getId();
+}
return clientId;
}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/01a1439c/tapestry-core/src/test/app1/nested/ZoneDemo.tml
--
diff --git a/tapestry-core/src/test/app1/nested/ZoneDemo.tml
b/tapestry-core/src/test/app1/nested/ZoneDemo.tml
index 049cb69..cd4beaf 100644
--- a/tapestry-core/src/test/app1/nested/ZoneDemo.tml
+++ b/tapestry-core/src/test/app1/nested/ZoneDemo.tml
@@ -87,6 +87,7 @@
MultiZone update with id of non-Zone
element
+Update via AjaxResponseRenderer
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/01a1439c/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
index 1ec0c75..77acefe 100644
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
@@ -323,4 +323,24 @@ public class ZoneTests extends App1TestCase
assertText("zone-update-message", "Zone updated.");
}
+/**
+ * TAP5-2330
+ */
+@Test
+public void update_zone_with_no_clientid()
+{
+openLinks("Zone Demo");
+
+assertText("zone-update-message", "");
+
+click("link=Update via AjaxResponseRenderer");
+
+waitForAjaxRequestsToComplete();
+
+assertText("zone-update-message", "Zone updated.");
+
+assertEquals("Selected: AjaxResponseRenderer", getText("output"));
+
+}
+
}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/01a1439c/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
index 4e2ad9e..e13ed76 100644
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
@@ -222,4 +222,10 @@ public class ZoneDemo
{
return new MultiZoneUpdate("notAZone", forNotAZone);
}
+
+void onActionFromUpdateViaAjaxResponseRenderer()
+{
+name = "AjaxResponseRenderer";
+ajaxResponseRende
[jira] [Commented] (TAP5-582) Translation for Slovenian language
[ https://issues.apache.org/jira/browse/TAP5-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014478#comment-14014478 ] Hudson commented on TAP5-582: - FAILURE: Integrated in tapestry-trunk-freestyle #1227 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1227/]) TAP5-582 : Translation for Slovenian language (thiagohp: rev d96b5534fc02d8d12b75eafae18c276d2ddf11f4) * tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridPager_sl_SI.properties * tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/BeanEditForm_sl_SI.properties * tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridColumns_sl_SI.properties * tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_sl_SI.properties * tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Palette_sl_SI.properties * tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Errors_sl_SI.properties > Translation for Slovenian language > -- > > Key: TAP5-582 > URL: https://issues.apache.org/jira/browse/TAP5-582 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Borut Bolcina >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: patch_sl_SI.txt > > > I am attaching a patch in utf-8 for sl_SI locale. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-146) Provide some way to get the component that fired an event
[ https://issues.apache.org/jira/browse/TAP5-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo closed TAP5-146. -- Resolution: Won't Fix I didn't had any need for this in the last years, so I'll close it. > Provide some way to get the component that fired an event > - > > Key: TAP5-146 > URL: https://issues.apache.org/jira/browse/TAP5-146 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 >Reporter: Thiago H. de Paula Figueiredo > Labels: bulk-close-candidate > > It would be very nice to have event handler methods know what component fired > that event, specially for mixins. > There's a discussion in the mailing list: > http://www.nabble.com/forum/ViewPost.jtp?post=18157269&framed=y. > Howard said: > We could change Event to expose the source > Component ... we could also change the EventWorker logic to see if the > sole parameter to an event handler method is of type ComponentEvent > and pass the event directly to the event handler method. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-582) Translation for Slovenian language
[ https://issues.apache.org/jira/browse/TAP5-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-582. Resolution: Fixed Fix Version/s: 5.4 Thanks Borut for the translation! > Translation for Slovenian language > -- > > Key: TAP5-582 > URL: https://issues.apache.org/jira/browse/TAP5-582 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Borut Bolcina >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: patch_sl_SI.txt > > > I am attaching a patch in utf-8 for sl_SI locale. -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-582 : Translation for Slovenian language
Repository: tapestry-5 Updated Branches: refs/heads/master ce6e66ea3 -> d96b5534f TAP5-582 : Translation for Slovenian language Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d96b5534 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d96b5534 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d96b5534 Branch: refs/heads/master Commit: d96b5534fc02d8d12b75eafae18c276d2ddf11f4 Parents: ce6e66e Author: Thiago H. de Paula Figueiredo Authored: Fri May 30 22:54:12 2014 -0300 Committer: Thiago H. de Paula Figueiredo Committed: Fri May 30 22:54:12 2014 -0300 -- .../components/BeanEditForm_sl_SI.properties| 15 + .../corelib/components/Errors_sl_SI.properties | 15 + .../components/GridColumns_sl_SI.properties | 17 +++ .../components/GridPager_sl_SI.properties | 15 + .../corelib/components/Palette_sl_SI.properties | 21 + .../ValidationMessages_sl_SI.properties | 32 6 files changed, 115 insertions(+) -- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d96b5534/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/BeanEditForm_sl_SI.properties -- diff --git a/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/BeanEditForm_sl_SI.properties b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/BeanEditForm_sl_SI.properties new file mode 100644 index 000..8e8ebe3 --- /dev/null +++ b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/BeanEditForm_sl_SI.properties @@ -0,0 +1,15 @@ +# Copyright 2007 The Apache Software Foundation +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +submit-label=Kreiraj/Posodobi http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d96b5534/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Errors_sl_SI.properties -- diff --git a/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Errors_sl_SI.properties b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Errors_sl_SI.properties new file mode 100644 index 000..e3d605b --- /dev/null +++ b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Errors_sl_SI.properties @@ -0,0 +1,15 @@ +# Copyright 2006 The Apache Software Foundation +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +default-banner=Pred nadaljevanjem morate popraviti sledeÄe napake. http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d96b5534/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridColumns_sl_SI.properties -- diff --git a/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridColumns_sl_SI.properties b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridColumns_sl_SI.properties new file mode 100644 index 000..9661381 --- /dev/null +++ b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridColumns_sl_SI.properties @@ -0,0 +1,17 @@ +# Copyright 2007 The Apache Software Foundation +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the Li
[jira] [Updated] (TAP5-582) Translation for Slovenian language
[ https://issues.apache.org/jira/browse/TAP5-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-582: --- Labels: month-of-tapestry (was: tapestry5-review-for-closing) > Translation for Slovenian language > -- > > Key: TAP5-582 > URL: https://issues.apache.org/jira/browse/TAP5-582 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Borut Bolcina >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Attachments: patch_sl_SI.txt > > > I am attaching a patch in utf-8 for sl_SI locale. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (TAP5-582) Translation for Slovenian language
[ https://issues.apache.org/jira/browse/TAP5-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo reassigned TAP5-582: -- Assignee: Thiago H. de Paula Figueiredo > Translation for Slovenian language > -- > > Key: TAP5-582 > URL: https://issues.apache.org/jira/browse/TAP5-582 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Borut Bolcina >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Attachments: patch_sl_SI.txt > > > I am attaching a patch in utf-8 for sl_SI locale. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-582) Translation for Slovenian language
[ https://issues.apache.org/jira/browse/TAP5-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014461#comment-14014461 ] ASF subversion and git services commented on TAP5-582: -- Commit d96b5534fc02d8d12b75eafae18c276d2ddf11f4 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=d96b553 ] TAP5-582 : Translation for Slovenian language > Translation for Slovenian language > -- > > Key: TAP5-582 > URL: https://issues.apache.org/jira/browse/TAP5-582 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Borut Bolcina >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Attachments: patch_sl_SI.txt > > > I am attaching a patch in utf-8 for sl_SI locale. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014427#comment-14014427 ] Hudson commented on TAP5-2187: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1226 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1226/]) TAP5-2187 : CSS relative URL rewriting isn't lenient enough (thiagohp: rev 5b311716e65e5fde43cf925c0728b52e4e63cf32) * tapestry-core/src/main/java/org/apache/tapestry5/modules/AssetsModule.java * tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java * tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy * tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java * tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
[3/3] git commit: Integrate an exception reporting service that will write exception report text files to the file system
Integrate an exception reporting service that will write exception report text
files to the file system
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/ce6e66ea
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/ce6e66ea
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/ce6e66ea
Branch: refs/heads/master
Commit: ce6e66ea388455fea5363b718d8323299a601854
Parents: 511813f
Author: Howard M. Lewis Ship
Authored: Fri May 30 16:57:31 2014 -0700
Committer: Howard M. Lewis Ship
Committed: Fri May 30 16:57:31 2014 -0700
--
.../src/main/java/org/apache/tapestry5/SymbolConstants.java| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ce6e66ea/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
b/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
index 6ab3759..4208479 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
@@ -488,12 +488,12 @@ public class SymbolConstants
* @see org.apache.tapestry5.services.exceptions.ExceptionReporter
* @since 5.4
*/
-
+
public static final String EXCEPTION_REPORTS_DIR =
"tapestry.exception-reports-dir";
/**
- * Defines whether {@link CSSURLRewriter} will throw an exception when a
CSS file
+ * Defines whether {@link
org.apache.tapestry5.internal.services.assets.CSSURLRewriter} will throw an
exception when a CSS file
* references an URL which doesn't exist. The default value is
false.
- *
+ *
* @since 5.4
*/
public static final String STRICT_CSS_URL_REWRITING =
"tapestry.strict-css-url-rewriting";
[1/3] git commit: Include a list of threads in the default exception report page
Repository: tapestry-5
Updated Branches:
refs/heads/master 5b311716e -> ce6e66ea3
Include a list of threads in the default exception report page
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/08807a12
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/08807a12
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/08807a12
Branch: refs/heads/master
Commit: 08807a1266b49cc5d76ac38705ab7fe31e893b6e
Parents: 5b31171
Author: Howard M. Lewis Ship
Authored: Fri May 30 16:05:33 2014 -0700
Committer: Howard M. Lewis Ship
Committed: Fri May 30 16:55:24 2014 -0700
--
54_RELEASE_NOTES.md | 4 +
.../corelib/pages/ExceptionReport.java | 100 ++-
.../META-INF/assets/core/ExceptionReport.css| 13 +++
.../tapestry5/corelib/pages/ExceptionReport.tml | 21
4 files changed, 135 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/08807a12/54_RELEASE_NOTES.md
--
diff --git a/54_RELEASE_NOTES.md b/54_RELEASE_NOTES.md
index 8044c85..23fc912 100644
--- a/54_RELEASE_NOTES.md
+++ b/54_RELEASE_NOTES.md
@@ -155,6 +155,10 @@ The FormFragment component's visibleBound parameter is no
longer supported; it w
far up the DOM above the FormFragment's client-side element should be searched
when determining visibility. This may
resurface in the future as a CSS expression, but is currently not supported.
+## ExceptionReport Page
+
+The default exception report page has been modified to display a list of
threads.
+
## Symbol tapestry.asset-path-prefix
The definition of the symbol 'tapestry.asset-path-prefix' has changed; it no
longer includes the leading and trailing
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/08807a12/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
index e6db1ed..1ca7e25 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
@@ -21,16 +21,20 @@ import org.apache.tapestry5.annotations.ContentType;
import org.apache.tapestry5.annotations.Import;
import org.apache.tapestry5.annotations.Property;
import org.apache.tapestry5.annotations.UnknownActivationContextCheck;
+import org.apache.tapestry5.func.F;
+import org.apache.tapestry5.func.Mapper;
import org.apache.tapestry5.internal.InternalConstants;
import org.apache.tapestry5.internal.services.PageActivationContextCollector;
import org.apache.tapestry5.internal.services.ReloadHelper;
import org.apache.tapestry5.ioc.annotations.Inject;
import org.apache.tapestry5.ioc.annotations.Symbol;
+import org.apache.tapestry5.ioc.internal.util.CollectionFactory;
import org.apache.tapestry5.ioc.internal.util.InternalUtils;
import org.apache.tapestry5.services.*;
import java.net.MalformedURLException;
import java.net.URL;
+import java.util.Arrays;
import java.util.List;
import java.util.regex.Pattern;
@@ -99,17 +103,42 @@ public class ExceptionReport implements ExceptionReporter
@Inject
private ReloadHelper reloadHelper;
-
+
@Inject
private URLEncoder urlEncoder;
@Property
private String rootURL;
+@Property
+private ThreadInfo thread;
+
+public class ThreadInfo implements Comparable
+{
+public final String className, name, flags;
+
+public final ThreadGroup group;
+
+public ThreadInfo(String className, String name, String flags,
ThreadGroup group)
+{
+this.className = className;
+this.name = name;
+this.flags = flags;
+this.group = group;
+}
+
+@Override
+public int compareTo(ThreadInfo o)
+{
+return name.compareTo(o.name);
+}
+}
+
private final String pathSeparator =
System.getProperty(PATH_SEPARATOR_PROPERTY);
-public boolean isShowActions() {
-return failurePage != null && ! request.isXHR();
+public boolean isShowActions()
+{
+return failurePage != null && !request.isXHR();
}
public void reportException(Throwable exception)
@@ -182,4 +211,69 @@ public class ExceptionReport implements ExceptionReporter
return getPropertyValue().split(pathSeparator);
}
+
+private Thread[] assembleThreads()
+{
+ThreadGroup rootGroup = Thread.currentThread().getThreadGroup();
[2/3] git commit: Integrate an exception reporting service that will write exception report text files to the file system
Integrate an exception reporting service that will write exception report text
files to the file system
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/511813f3
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/511813f3
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/511813f3
Branch: refs/heads/master
Commit: 511813f381c7724024cc818977e9a85f7eade22a
Parents: 08807a1
Author: Howard M. Lewis Ship
Authored: Fri May 30 16:55:07 2014 -0700
Committer: Howard M. Lewis Ship
Committed: Fri May 30 16:57:01 2014 -0700
--
54_RELEASE_NOTES.md | 4 +
.../org/apache/tapestry5/SymbolConstants.java | 14 +-
.../corelib/pages/ExceptionReport.java | 42 +--
.../internal/TapestryInternalUtils.java | 31 +-
.../DefaultRequestExceptionHandler.java | 56 +--
.../exceptions/ExceptionReporterImpl.java | 340 +++
.../tapestry5/modules/TapestryModule.java | 3 +
.../services/exceptions/ExceptionReporter.java | 33 ++
.../services/exceptions/package-info.java | 4 +
.../tapestry5/corelib/pages/ExceptionReport.tml | 4 +-
.../DefaultRequestExceptionHandlerTest.java | 117 ---
11 files changed, 535 insertions(+), 113 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/511813f3/54_RELEASE_NOTES.md
--
diff --git a/54_RELEASE_NOTES.md b/54_RELEASE_NOTES.md
index 23fc912..eda173b 100644
--- a/54_RELEASE_NOTES.md
+++ b/54_RELEASE_NOTES.md
@@ -159,6 +159,10 @@ resurface in the future as a CSS expression, but is
currently not supported.
The default exception report page has been modified to display a list of
threads.
+## ExceptionReporter Service
+
+A new service, `ExceptionReporter`, will now create a text file on the file
system for each runtime request processing exception.
+
## Symbol tapestry.asset-path-prefix
The definition of the symbol 'tapestry.asset-path-prefix' has changed; it no
longer includes the leading and trailing
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/511813f3/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
b/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
index d2526ae..6ab3759 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
@@ -1,5 +1,3 @@
-// Copyright 2008-2014 The Apache Software Foundation
-//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
@@ -474,15 +472,25 @@ public class SymbolConstants
* @since 5.4
*/
public static final String FORM_FIELD_CSS_CLASS =
"tapestry.form-field-css-class";
-
+
/**
* Defines whether {@link java.text.DateFormat} instances created by
Tapestry should be
* lenient or not by default. The default value is false.
+ *
* @since 5.4
*/
public static final String LENIENT_DATE_FORMAT =
"tapestry.lenient-date-format";
/**
+ * The directory to which exception report files should be written. The
default is appropriate
+ * for development: {@code build/exceptions}, and should be changed for
production.
+ *
+ * @see org.apache.tapestry5.services.exceptions.ExceptionReporter
+ * @since 5.4
+ */
+
+public static final String EXCEPTION_REPORTS_DIR =
"tapestry.exception-reports-dir";
+/**
* Defines whether {@link CSSURLRewriter} will throw an exception when a
CSS file
* references an URL which doesn't exist. The default value is
false.
*
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/511813f3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
index 1ca7e25..bdc853a 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java
@@ -1,5 +1,3 @@
-// Copyright 2006-2013 The Apache Software Foundation
-//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy
[jira] [Commented] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014374#comment-14014374 ] Hudson commented on TAP5-2187: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1225 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1225/]) TAP5-2187 : CSS relative URL rewriting isn't lenient enough (thiagohp: rev 23330e4bf581d00196f372a97685a0a27ff09b2e) * tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy * tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014373#comment-14014373 ] Thiago H. de Paula Figueiredo commented on TAP5-2187: - A new configuration symbol, SymbolConstants.STRICT_CSS_URL_REWRITING (tapestry.strict-css-url-rewriting), was created to control whether to throw an exception (true) or log a warning (false). The default is false. > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014372#comment-14014372 ] ASF subversion and git services commented on TAP5-2187: --- Commit 5b311716e65e5fde43cf925c0728b52e4e63cf32 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=5b31171 ] TAP5-2187 : CSS relative URL rewriting isn't lenient enough > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2187 : CSS relative URL rewriting isn't lenient enough
Repository: tapestry-5
Updated Branches:
refs/heads/master 23330e4bf -> 5b311716e
TAP5-2187 : CSS relative URL rewriting isn't lenient enough
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/5b311716
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/5b311716
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/5b311716
Branch: refs/heads/master
Commit: 5b311716e65e5fde43cf925c0728b52e4e63cf32
Parents: 23330e4
Author: Thiago H. de Paula Figueiredo
Authored: Fri May 30 20:41:57 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Fri May 30 20:41:57 2014 -0300
--
.../org/apache/tapestry5/SymbolConstants.java | 8 +++
.../services/assets/CSSURLRewriter.java | 24 -
.../apache/tapestry5/modules/AssetsModule.java | 5 +-
.../tapestry5/modules/TapestryModule.java | 3 ++
.../services/assets/CSSURLRewriterTests.groovy | 52 +++-
5 files changed, 76 insertions(+), 16 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/5b311716/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
b/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
index 83e6f9c..d2526ae 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
@@ -482,4 +482,12 @@ public class SymbolConstants
*/
public static final String LENIENT_DATE_FORMAT =
"tapestry.lenient-date-format";
+/**
+ * Defines whether {@link CSSURLRewriter} will throw an exception when a
CSS file
+ * references an URL which doesn't exist. The default value is
false.
+ *
+ * @since 5.4
+ */
+public static final String STRICT_CSS_URL_REWRITING =
"tapestry.strict-css-url-rewriting";
+
}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/5b311716/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
index ae6c3b5..d5053f5 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
@@ -15,11 +15,14 @@
package org.apache.tapestry5.internal.services.assets;
import org.apache.tapestry5.Asset;
+import org.apache.tapestry5.SymbolConstants;
import org.apache.tapestry5.ioc.IOOperation;
import org.apache.tapestry5.ioc.OperationTracker;
import org.apache.tapestry5.ioc.Resource;
import org.apache.tapestry5.services.AssetSource;
import org.apache.tapestry5.services.assets.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.io.InputStream;
@@ -39,6 +42,7 @@ import java.util.regex.Pattern;
* somewhat banking on the fact that referenced resources are non-compressable
images.
*
* @since 5.4
+ * @see SymbolConstants#STRICT_CSS_URL_REWRITING
*/
public class CSSURLRewriter extends DelegatingSRS
{
@@ -64,13 +68,19 @@ public class CSSURLRewriter extends DelegatingSRS
private final AssetSource assetSource;
private final AssetChecksumGenerator checksumGenerator;
+
+private final Logger logger =
LoggerFactory.getLogger(CSSURLRewriter.class);
+
+private final boolean strictCssUrlRewriting;
-public CSSURLRewriter(StreamableResourceSource delegate, OperationTracker
tracker, AssetSource assetSource, AssetChecksumGenerator checksumGenerator)
+public CSSURLRewriter(StreamableResourceSource delegate, OperationTracker
tracker, AssetSource assetSource,
+AssetChecksumGenerator checksumGenerator, boolean
strictCssUrlRewriting)
{
super(delegate);
this.tracker = tracker;
this.assetSource = assetSource;
this.checksumGenerator = checksumGenerator;
+this.strictCssUrlRewriting = strictCssUrlRewriting;
}
@Override
@@ -169,6 +179,18 @@ public class CSSURLRewriter extends DelegatingSRS
didReplace = true;
}
+else
+{
+final String message = String.format("URL %s, referenced in
file %s, doesn't exist.", url, baseResource.toURL(), baseResource);
+if (strictCssUrlRewriting)
+{
+throw new RuntimeEx
[jira] [Closed] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo closed TAP5-2187. --- Resolution: Fixed Fix Version/s: 5.4 Now Tapestry accept referenced URLs which don't exist in CSS files without throwing an exception. These broken URLs will remain unchanged. > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2187: Labels: month-of-tapestry (was: ) > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014329#comment-14014329 ] ASF subversion and git services commented on TAP5-2187: --- Commit 23330e4bf581d00196f372a97685a0a27ff09b2e in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=23330e4 ] TAP5-2187 : CSS relative URL rewriting isn't lenient enough > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2187 : CSS relative URL rewriting isn't lenient enough
Repository: tapestry-5
Updated Branches:
refs/heads/master e6eb63c57 -> 23330e4bf
TAP5-2187 : CSS relative URL rewriting isn't lenient enough
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/23330e4b
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/23330e4b
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/23330e4b
Branch: refs/heads/master
Commit: 23330e4bf581d00196f372a97685a0a27ff09b2e
Parents: e6eb63c
Author: Thiago H. de Paula Figueiredo
Authored: Fri May 30 19:55:15 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Fri May 30 19:55:15 2014 -0300
--
.../services/assets/CSSURLRewriter.java | 21 +
.../services/assets/CSSURLRewriterTests.groovy | 46
2 files changed, 59 insertions(+), 8 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/23330e4b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
index 95ba2ba..ae6c3b5 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/CSSURLRewriter.java
@@ -154,17 +154,22 @@ public class CSSURLRewriter extends DelegatingSRS
Asset asset = assetSource.getAsset(baseResource, url, null);
-String assetURL = asset.toClientURL();
-
-String queryParameters = matcher.group(3);
-if (queryParameters != null)
+if (asset != null)
{
-assetURL += queryParameters;
-}
+String assetURL = asset.toClientURL();
+
+String queryParameters = matcher.group(3);
+if (queryParameters != null)
+{
+assetURL += queryParameters;
+}
-appendReplacement(matcher, output, assetURL);
+appendReplacement(matcher, output, assetURL);
-didReplace = true;
+didReplace = true;
+
+}
+
}
if (!didReplace)
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/23330e4b/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy
b/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy
index 6286a83..d491d64 100644
---
a/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/services/assets/CSSURLRewriterTests.groovy
@@ -284,4 +284,50 @@ div.busy {
}
+// See TAP5-2187
+@Test
+void dont_fail_when_rewritten_url_is_not_found() {
+def input = '''
+body {
+ background: white url("images/back.png") attach-x;
+}
+h1 {
+ background: white url("images/i_dont_exist.png") attach-x;
+}
+'''
+
+def assetSource = newMock AssetSource
+def resource = newMock Resource
+def asset = newMock Asset
+
+expect(
+assetSource.getAsset(resource, "images/back.png", null)
+).andReturn asset
+
+expect(asset.toClientURL()).andReturn "/ctx/images/back.png"
+
+expect(
+assetSource.getAsset(resource, "images/i_dont_exist.png", null)
+).andReturn null
+
+replay()
+
+
+def rewriter = new CSSURLRewriter(null, null, assetSource, null)
+
+def output = rewriter.replaceURLs input, resource
+
+assertEquals output, '''
+body {
+ background: white url("/ctx/images/back.png") attach-x;
+}
+h1 {
+ background: white url("images/i_dont_exist.png") attach-x;
+}
+'''
+
+verify()
+
+}
+
}
[jira] [Assigned] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
[ https://issues.apache.org/jira/browse/TAP5-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo reassigned TAP5-2187: --- Assignee: Thiago H. de Paula Figueiredo > CSS relative URL rewriting isn't lenient enough > --- > > Key: TAP5-2187 > URL: https://issues.apache.org/jira/browse/TAP5-2187 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > > I am trying to integrate an existing GWT framework as tapestry components. > One of the .css files its trying to load references an non-existent .png file. > Instead of just ignoring it, Tapestry produces a 500 error loading the .css > file, > which I don't believe there is a workaround for. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-1658) Submit context does not work inside Grid
[ https://issues.apache.org/jira/browse/TAP5-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014310#comment-14014310 ] Thiago H. de Paula Figueiredo commented on TAP5-1658: - I haven't really investigated the ticket yet, but I think the only solution for when Submit is inside any kind of loop is to store its context in a hidden field and read it back when triggering the event, sort of like form fields do. > Submit context does not work inside Grid > > > Key: TAP5-1658 > URL: https://issues.apache.org/jira/browse/TAP5-1658 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3.7, 5.4, 5.2 >Reporter: Stephan Windmüller >Assignee: Jochen Kemnade > Attachments: TestGrid.tar.gz > > > About a year ago, bug #TAP-5-869 was about the usage of submit buttons with > context in loops. The bug was closed because using the defer parameter of the > submit button fixed the problem. > Now I have the same problem, but this time in a Grid rather than a loop > component. Defer is set to false but every time I click on a button, only the > context of the last one is used. > I created a small example demonstrating the problem, I will attach it to this > bugreport. Try clicking on every user and watch the console output: Always > the last user is printed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2331) Can't stop tapestry generating clientId for fields
[
https://issues.apache.org/jira/browse/TAP5-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014300#comment-14014300
]
Hudson commented on TAP5-2331:
--
SUCCESS: Integrated in tapestry-trunk-freestyle #1224 (See
[https://builds.apache.org/job/tapestry-trunk-freestyle/1224/])
Fixes tests broken by the original implementation of TAP5-2331 (thiagohp: rev
c24580586ce521e5bcbe09e7fba27e16f15cce9a)
* tapestry-core/src/main/java/org/apache/tapestry5/modules/InternalModule.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PreSelectedFormNamesService.java
*
tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PropertyEditBlocks.java
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
*
tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PreSelectedFormNamesServiceImpl.java
*
tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
> Can't stop tapestry generating clientId for fields
> --
>
> Key: TAP5-2331
> URL: https://issues.apache.org/jira/browse/TAP5-2331
> Project: Tapestry 5
> Issue Type: Bug
>Reporter: Lance
>Assignee: Thiago H. de Paula Figueiredo
> Labels: month-of-tapestry
> Fix For: 5.4
>
>
> I want to be able to specify a clientId so that tapestry doesn't
> auto-generate one for me. This works on many core tapestry components when I
> specify an "id" because the following code is present:
> {code}
> clientId = resources.isBound("id") ? idParameter :
> renderSupport.allocateClientId(resources);
> {code}
> But in AbstractField, this logic is different
> {code}
> @Parameter(value = "prop:componentResources.id", defaultPrefix =
> BindingConstants.LITERAL)
> private String clientId;
> final void setup() {
>String id = clientId;
>...
>assignedClientId = jsSupport.allocateClientId(id);
> }
> public final String getClientId() {
>return assignedClientId;
> }
> {code}
> This means that tapestry will generate id's like "foo_af42a49d19a" after zone
> updates when I set clientId to "foo". This makes it impossible to attach
> clientside behaviour by field id selectors.
> As a workaround, I add "data-" attributes to my fields and select by them
> instead. I assume this has worse performance than id based selectors.
> Forum thread
> [here|http://tapestry.markmail.org/search/?q=list%3Aorg.apache.tapestry.users#query:list%3Aorg.apache.tapestry.users+page:1+mid:ccqjgtopya3xdgrd+state:results]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-2211) Replace DatePicker with Bootstrap or JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2211: Assignee: (was: Thiago H. de Paula Figueiredo) > Replace DatePicker with Bootstrap or JQueryUI DatePicker > > > Key: TAP5-2211 > URL: https://issues.apache.org/jira/browse/TAP5-2211 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak > Labels: datefield, datepicker > > The current 3rd party datepicker used by Tapestry is very old, > and isn't very good. It's time to update it to one of > the better currently-available datepickers. > There are about 15 unresolved issues opened against Datepicker that can all > be solved by just replacing it. > I suggest JQueryUI datepicker (if JQuery is included as the default stack) > The current datepicker can be left alone is prototype is chosen. > By default, JQueryUI datepicker should be used with the button-to-activate > option so that it looks similar to the current datepicker. > It should also work properly in BeanEditor and friends and even look good > with form-horizontal version of BeanEditor > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2331) Can't stop tapestry generating clientId for fields
[
https://issues.apache.org/jira/browse/TAP5-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014290#comment-14014290
]
ASF subversion and git services commented on TAP5-2331:
---
Commit c24580586ce521e5bcbe09e7fba27e16f15cce9a in tapestry-5's branch
refs/heads/master from [~thiagohp]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=c245805 ]
Fixes tests broken by the original implementation of TAP5-2331
> Can't stop tapestry generating clientId for fields
> --
>
> Key: TAP5-2331
> URL: https://issues.apache.org/jira/browse/TAP5-2331
> Project: Tapestry 5
> Issue Type: Bug
>Reporter: Lance
>Assignee: Thiago H. de Paula Figueiredo
> Labels: month-of-tapestry
> Fix For: 5.4
>
>
> I want to be able to specify a clientId so that tapestry doesn't
> auto-generate one for me. This works on many core tapestry components when I
> specify an "id" because the following code is present:
> {code}
> clientId = resources.isBound("id") ? idParameter :
> renderSupport.allocateClientId(resources);
> {code}
> But in AbstractField, this logic is different
> {code}
> @Parameter(value = "prop:componentResources.id", defaultPrefix =
> BindingConstants.LITERAL)
> private String clientId;
> final void setup() {
>String id = clientId;
>...
>assignedClientId = jsSupport.allocateClientId(id);
> }
> public final String getClientId() {
>return assignedClientId;
> }
> {code}
> This means that tapestry will generate id's like "foo_af42a49d19a" after zone
> updates when I set clientId to "foo". This makes it impossible to attach
> clientside behaviour by field id selectors.
> As a workaround, I add "data-" attributes to my fields and select by them
> instead. I assume this has worse performance than id based selectors.
> Forum thread
> [here|http://tapestry.markmail.org/search/?q=list%3Aorg.apache.tapestry.users#query:list%3Aorg.apache.tapestry.users+page:1+mid:ccqjgtopya3xdgrd+state:results]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[1/2] git commit: Fixes tests broken by the original implementation of TAP5-2331
Repository: tapestry-5
Updated Branches:
refs/heads/master e294e9958 -> e6eb63c57
Fixes tests broken by the original implementation of TAP5-2331
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/c2458058
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/c2458058
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/c2458058
Branch: refs/heads/master
Commit: c24580586ce521e5bcbe09e7fba27e16f15cce9a
Parents: b4fd568
Author: Thiago H. de Paula Figueiredo
Authored: Fri May 30 19:11:31 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Fri May 30 19:11:31 2014 -0300
--
.../tapestry5/corelib/base/AbstractField.java | 66 +---
.../tapestry5/corelib/components/Form.java | 6 +-
.../corelib/pages/PropertyEditBlocks.java | 18 +++---
.../services/PreSelectedFormNamesService.java | 41
.../PreSelectedFormNamesServiceImpl.java| 47 ++
.../tapestry5/modules/InternalModule.java | 3 +
.../tapestry5/integration/app1/ZoneTests.java | 4 +-
7 files changed, 162 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/c2458058/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
index 2c9fa9d..dc400d2 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
@@ -14,12 +14,29 @@
package org.apache.tapestry5.corelib.base;
-import org.apache.tapestry5.*;
-import org.apache.tapestry5.annotations.*;
+import java.io.Serializable;
+
+import org.apache.tapestry5.BindingConstants;
+import org.apache.tapestry5.ComponentAction;
+import org.apache.tapestry5.ComponentResources;
+import org.apache.tapestry5.Field;
+import org.apache.tapestry5.FieldValidationSupport;
+import org.apache.tapestry5.SymbolConstants;
+import org.apache.tapestry5.ValidationDecorator;
+import org.apache.tapestry5.ValidationTracker;
+import org.apache.tapestry5.Validator;
+import org.apache.tapestry5.annotations.AfterRender;
+import org.apache.tapestry5.annotations.BeginRender;
+import org.apache.tapestry5.annotations.Environmental;
+import org.apache.tapestry5.annotations.Mixin;
+import org.apache.tapestry5.annotations.Parameter;
+import org.apache.tapestry5.annotations.SetupRender;
+import org.apache.tapestry5.annotations.SupportsInformalParameters;
import org.apache.tapestry5.corelib.mixins.DiscardBody;
import org.apache.tapestry5.corelib.mixins.RenderInformals;
import org.apache.tapestry5.internal.BeanValidationContext;
import org.apache.tapestry5.internal.InternalComponentResources;
+import org.apache.tapestry5.internal.services.PreSelectedFormNamesService;
import org.apache.tapestry5.ioc.annotations.Inject;
import org.apache.tapestry5.ioc.annotations.Symbol;
import org.apache.tapestry5.services.ComponentDefaultProvider;
@@ -28,8 +45,6 @@ import org.apache.tapestry5.services.FormSupport;
import org.apache.tapestry5.services.Request;
import org.apache.tapestry5.services.javascript.JavaScriptSupport;
-import java.io.Serializable;
-
/**
* Provides initialization of the clientId and elementName properties. In
addition, adds the {@link RenderInformals},
* and {@link DiscardBody} mixins.
@@ -115,15 +130,37 @@ public abstract class AbstractField implements Field
private static final ProcessSubmission PROCESS_SUBMISSION_ACTION = new
ProcessSubmission();
/**
- * The id used to generate a page-unique client-side identifier for the
component. If this parameter is not bound
- * and a component renders multiple times, a suffix will be appended to
the to id to ensure uniqueness. Either way,
+ * The id used to generate a page-unique client-side identifier for the
component.
+ * If this parameter is not bound and this component is rendered multiple
times in a request
+ * and forceClientAllocation is false (the default),
+ * a suffix will be appended to the to id to ensure uniqueness. Either
way,
* its value may be accessed via the {@link #getClientId() clientId
property}.
* When this parameter is bound, Tapestry considers the user (developer)
is taking care of
* providing unique client-side identifiers. Special care should be taken
when the
* field is inside a Zone.
+ *
+ * Default value: the component's t:id.
+ *
+ * This parameter will be ignored if it receives any of these
values:
+ *
+ * reset
[2/2] git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tapestry-5
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tapestry-5 Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/e6eb63c5 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/e6eb63c5 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/e6eb63c5 Branch: refs/heads/master Commit: e6eb63c571b22a5967157009bd6b9051f0145931 Parents: c245805 e294e99 Author: Thiago H. de Paula Figueiredo Authored: Fri May 30 19:12:12 2014 -0300 Committer: Thiago H. de Paula Figueiredo Committed: Fri May 30 19:12:12 2014 -0300 -- build.gradle| 2 +- .../webresources/LessResourceTransformer.java | 92 +++ .../webresources/ResourceLessSource.java| 97 3 files changed, 112 insertions(+), 79 deletions(-) --
git commit: Advance version number to 5.4-beta-8
Repository: tapestry-5
Updated Branches:
refs/heads/master 814fdb509 -> e294e9958
Advance version number to 5.4-beta-8
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/e294e995
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/e294e995
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/e294e995
Branch: refs/heads/master
Commit: e294e99582da1798b5c13ebb7b23bfaa131e5a06
Parents: 814fdb5
Author: Howard M. Lewis Ship
Authored: Fri May 30 15:03:04 2014 -0700
Committer: Howard M. Lewis Ship
Committed: Fri May 30 15:03:04 2014 -0700
--
build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/e294e995/build.gradle
--
diff --git a/build.gradle b/build.gradle
index b349e74..1ad0100 100755
--- a/build.gradle
+++ b/build.gradle
@@ -36,7 +36,7 @@ project.version = tapestryVersion()
def tapestryVersion() {
def major = "5.4"
-def minor = "-beta-7"
+def minor = "-beta-8"
// When building on the CI server, make sure -SNAPSHOT is appended, as it
is a nightly build.
// When building normally, or for a release, no suffix is desired.
git commit: Make LessResourceTransformer easier to subclass and extend
Repository: tapestry-5
Updated Branches:
refs/heads/master 323cb8c34 -> 814fdb509
Make LessResourceTransformer easier to subclass and extend
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/814fdb50
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/814fdb50
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/814fdb50
Branch: refs/heads/master
Commit: 814fdb509f712052d38b324caeadbcb2c0df180d
Parents: 323cb8c
Author: Howard M. Lewis Ship
Authored: Fri May 30 13:33:30 2014 -0700
Committer: Howard M. Lewis Ship
Committed: Fri May 30 15:02:32 2014 -0700
--
.../webresources/LessResourceTransformer.java | 95 ---
.../webresources/ResourceLessSource.java| 97
2 files changed, 114 insertions(+), 78 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/814fdb50/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
--
diff --git
a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
index 6ed705f..ebaf35d 100644
---
a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
+++
b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
@@ -1,3 +1,5 @@
+// Copyright 2013-2014 The Apache Software Foundation
+//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
@@ -16,14 +18,14 @@ import com.github.sommeri.less4j.Less4jException;
import com.github.sommeri.less4j.LessCompiler;
import com.github.sommeri.less4j.LessSource;
import com.github.sommeri.less4j.core.DefaultLessCompiler;
-import org.apache.commons.io.IOUtils;
import org.apache.tapestry5.internal.services.assets.BytestreamCache;
import org.apache.tapestry5.ioc.Resource;
-import org.apache.tapestry5.ioc.internal.util.InternalUtils;
import org.apache.tapestry5.services.assets.ResourceDependencies;
import org.apache.tapestry5.services.assets.ResourceTransformer;
-import java.io.*;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.UnsupportedEncodingException;
/**
* Direct wrapper around the LessCompiler, so that Less source files may use
{@code @import}, which isn't
@@ -39,79 +41,6 @@ public class LessResourceTransformer implements
ResourceTransformer
return "text/css";
}
-protected class ResourceLessSource extends LessSource
-{
-private final Resource resource;
-
-private final ResourceDependencies dependencies;
-
-protected ResourceLessSource(Resource resource, ResourceDependencies
dependencies)
-{
-this.resource = resource;
-this.dependencies = dependencies;
-}
-
-@Override
-public LessSource relativeSource(String filename) throws FileNotFound,
CannotReadFile, StringSourceException
-{
-Resource relative = resource.forFile(filename);
-
-if (!relative.exists())
-{
-throw new FileNotFound();
-}
-
-dependencies.addDependency(relative);
-
-return new ResourceLessSource(relative, dependencies);
-}
-
-@Override
-public String getContent() throws FileNotFound, CannotReadFile
-{
-// Adapted from Less's URLSource
-Reader input = null;
-try
-{
-input = new InputStreamReader(resource.openStream());
-String content = IOUtils.toString(input).replace("\r\n", "\n");
-
-return content;
-} catch (FileNotFoundException ex)
-{
-throw new FileNotFound();
-} catch (IOException ex)
-{
-throw new CannotReadFile();
-} finally
-{
-InternalUtils.close(input);
-}
-}
-
-@Override
-public byte[] getBytes() throws FileNotFound, CannotReadFile
-{
-Reader input = null;
-try
-{
-input = new InputStreamReader(resource.openStream());
-
-return IOUtils.toByteArray(input);
-} catch (FileNotFoundException ex)
-{
-throw new FileNotFound();
-} catch (IOException ex)
-{
-throw new CannotReadFile();
-} f
Git Push Summary
Repository: tapestry-5 Updated Tags: refs/tags/5.4-beta-7 [created] ac670be39
git commit: Make LessResourceTransformer easier to subclass and extend
Repository: tapestry-5
Updated Branches:
refs/heads/master b4fd56869 -> 323cb8c34
Make LessResourceTransformer easier to subclass and extend
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/323cb8c3
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/323cb8c3
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/323cb8c3
Branch: refs/heads/master
Commit: 323cb8c340bdf7ead1b0ba2d5d442efc2a1a6476
Parents: b4fd568
Author: Howard M. Lewis Ship
Authored: Fri May 30 13:33:30 2014 -0700
Committer: Howard M. Lewis Ship
Committed: Fri May 30 13:33:44 2014 -0700
--
.../internal/webresources/LessResourceTransformer.java | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/323cb8c3/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
--
diff --git
a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
index 1c88958..6ed705f 100644
---
a/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
+++
b/tapestry-webresources/src/main/java/org/apache/tapestry5/internal/webresources/LessResourceTransformer.java
@@ -1,5 +1,3 @@
-// Copyright 2013-2014 The Apache Software Foundation
-//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
@@ -41,14 +39,13 @@ public class LessResourceTransformer implements
ResourceTransformer
return "text/css";
}
-class ResourceLessSource extends LessSource
+protected class ResourceLessSource extends LessSource
{
private final Resource resource;
private final ResourceDependencies dependencies;
-
-ResourceLessSource(Resource resource, ResourceDependencies
dependencies)
+protected ResourceLessSource(Resource resource, ResourceDependencies
dependencies)
{
this.resource = resource;
this.dependencies = dependencies;
@@ -124,7 +121,7 @@ public class LessResourceTransformer implements
ResourceTransformer
return compiled.openStream();
}
-private BytestreamCache invokeLessCompiler(Resource source,
ResourceDependencies dependencies) throws IOException
+protected BytestreamCache invokeLessCompiler(Resource source,
ResourceDependencies dependencies) throws IOException
{
try
{
svn commit: r910592 - in /websites/production/tapestry/content: cache/main.pageCache index.html news.html
Author: buildbot
Date: Fri May 30 16:19:34 2014
New Revision: 910592
Log:
Production update by buildbot for tapestry
Modified:
websites/production/tapestry/content/cache/main.pageCache
websites/production/tapestry/content/index.html
websites/production/tapestry/content/news.html
Modified: websites/production/tapestry/content/cache/main.pageCache
==
Binary files - no diff available.
Modified: websites/production/tapestry/content/index.html
==
--- websites/production/tapestry/content/index.html (original)
+++ websites/production/tapestry/content/index.html Fri May 30 16:19:34 2014
@@ -177,19 +177,22 @@ a.blogHeading {
-
- https://cwiki.apache.org/confluence/images/icons/profilepics/default.png";
alt="User icon: bobharner" title="bobharner">
+
+ https://cwiki.apache.org/confluence/images/icons/profilepics/default.png";
alt="User icon: hlship" title="hlship">
-Tapestry
5.4-beta-3 preview now available
-Bob Harner posted on Mar 07, 2014
+Tapestry 5.4-beta-6
+Howard M. Lewis Ship posted on May 29, 2014
-The 3rd beta preview release of Tapestry 5.4 is now available.
-While not an actual release candidate, beta previews like this one are
high-quality builds that pass all of Tapestry's extensive automated tests. You
are encouraged to try out this beta preview and let us know how it's working.
-If you're using Maven (or Gradle or Ivy, etc),…
+
+The latest beta preview release of Tapestry 5.4 is now available.
+The release numbers are not consecutive because not every beta release is
voted for wider release. This one has.
+Tapestry 5.4-beta-6 contains a significant number of bug fixes and minor
improvements. Dependencies on third party libraries have been updated.
+This release is available from the Maven Central Repository, or as a direct
download.
+While not an actual release candidate,…
@@ -203,13 +206,15 @@ If you're using Maven (or Gradle or Ivy,
https://cwiki.apache.org/confluence/images/icons/profilepics/default.png";
alt="User icon: bobharner" title="bobharner">
-Tapestry
5.4-beta-3 preview release vote underway
-Bob Harner posted on Feb 23, 2014
+Tapestry
5.4-beta-3 preview now available
+Bob Harner posted on Mar 07, 2014
-A vote is underway for the 3rd beta preview release of Tapestry 5.4.
This follows 2 other betas and 29 alphas for the work on version 5.4 that began
over two years ago.
+The 3rd beta preview release of Tapestry 5.4 is now available.
+While not an actual release candidate, beta previews like this one are
high-quality builds that pass all of Tapestry's extensive automated tests. You
are encouraged to try out this beta preview and let us know how it's working.
+If you're using Maven (or Gradle or Ivy, etc),…
@@ -219,17 +224,17 @@ If you're using Maven (or Gradle or Ivy,
-
- https://cwiki.apache.org/confluence/images/icons/profilepics/default.png";
alt="User icon: mlusetti" title="mlusetti">
+
+ https://cwiki.apache.org/confluence/images/icons/profilepics/default.png";
alt="User icon: bobharner" title="bobharner">
-Announcing Tapestry 5.3.7
-Massimo Lusetti posted on Apr 29, 2013
+Tapestry
5.4-beta-3 preview release vote underway
+Bob Harner posted on Feb 23, 2014
-Apache Tapestry 5.3.7: improves security and stability.
+A vote is underway for the 3rd beta preview release of Tapestry 5.4.
This follows 2 other betas and 29 alphas for the work on version 5.4 that began
over two years ago.
Modified: websites/production/tapestry/content/news.html
==
--- websites/production/tapestry/content/news.html (original)
+++ websites/production/tapestry/content/news.html Fri May 30 16:19:34 2014
@@ -61,7 +61,7 @@
- We think you will love
Tapestry! Give us 20 minutes and follow our
tutorial. News https://cwiki.apache.org/confluence/createrssfeed.action?types=blogpost&spaces=TAPESTRY&title=Apache+Tapestry+News+RSS+Feed&labelString%3D&sort=created&maxResults=10&timeSpan=12&confirm=Create&showContent=true&showDiff=false";>https://cwiki.apache.org/confluence/download/attachments/24185588/Feed-icon.gif?version=1&modification
[CONF] Apache Tapestry > Index
Howard M. Lewis Ship edited the page:
Index
HTML
.big-col {
margin-right: 310px !important;
}
#content {
height : 1080px;
}
#col {
width : 250px;
}
DIV.left-column {
float: left;
width: 48%;
}
DIV.right-column {
float: right;
width: 48%;
}
.blogSurtitle {
background: none repeat scroll 0 0 #569D2F;
border: 2px solid #DD;
color: #FF;
margin: 1px 1px 10px;
padding: 3px;
}
a.blogDate {
color: #FF;
}
a.blogHeading {
color: #569D2F;
font-size: 14px;
}
#col p {
text-align : justify;
font-size : 11px;
line-height : 1.2 !important
}
.feature {
#height: 150px;
}
...
View Online · Like · View Changes
Stop watching space · Manage Notifications
This message was sent by Atlassian Confluence 5.0.3, Team Collaboration Software
[CONF] Apache Tapestry > News
Howard M. Lewis Ship edited the page:
News
Wiki Markup
{htmlcomment}Force Update:
...
10{htmlcomment}
HTML
We think you will love Tapestry! Give us 20 minutes and follow our tutorial.
...
View Online · Like · View Changes
Stop watching space · Manage Notifications
This message was sent by Atlassian Confluence 5.0.3, Team Collaboration Software
[jira] [Updated] (TAP5-2344) Asset/module responses are sent without charset
[ https://issues.apache.org/jira/browse/TAP5-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-2344: - Affects Version/s: 5.4 > Asset/module responses are sent without charset > --- > > Key: TAP5-2344 > URL: https://issues.apache.org/jira/browse/TAP5-2344 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade > Labels: encoding > > The Content-Type header sent for asset and module responses does not contain > a charset specification. When they are loaded from within a page, browsers > seem to assume that they have the same charset as the page, so as long as > SymbolConstants.CHARSET is utf-8, everything works fine. Changing the symbol > value will probably cause responses to be read with the wrong charset. > When requesting the module/asset in a separate browser tab, is is interpreted > as ISO-5559-1 (HTTP 1.1 default charset). That can be seen when starting the > tapestry-core/app1 test app and navigating to > http://localhost:8080/tapestry-core/modules/moment.js. All the special > characters in the i18n section are broken. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-1325) Provide improvements on Element for better lookup of containing elements
[ https://issues.apache.org/jira/browse/TAP5-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-1325. - Resolution: Won't Fix The Tapestry-XPath project implements full XPath over Tapestry DOM elements. > Provide improvements on Element for better lookup of containing elements > > > Key: TAP5-1325 > URL: https://issues.apache.org/jira/browse/TAP5-1325 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Igor Drobiazko >Priority: Minor > > Beside getElementById(String) method there should be a generic methods > getElementByAttributeValue(String, String). > Also improvments of XPATH-based search would be useful -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (TAP5-2344) Asset/module responses are sent without charset
Jochen Kemnade created TAP5-2344: Summary: Asset/module responses are sent without charset Key: TAP5-2344 URL: https://issues.apache.org/jira/browse/TAP5-2344 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Jochen Kemnade The Content-Type header sent for asset and module responses does not contain a charset specification. When they are loaded from within a page, browsers seem to assume that they have the same charset as the page, so as long as SymbolConstants.CHARSET is utf-8, everything works fine. Changing the symbol value will probably cause responses to be read with the wrong charset. When requesting the module/asset in a separate browser tab, is is interpreted as ISO-5559-1 (HTTP 1.1 default charset). That can be seen when starting the tapestry-core/app1 test app and navigating to http://localhost:8080/tapestry-core/modules/moment.js. All the special characters in the i18n section are broken. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-1321) Add getService(Class serviceInterface, Class... markers) to ObjectLocator interface
[ https://issues.apache.org/jira/browse/TAP5-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-1321. Resolution: Not a Problem > Add getService(Class serviceInterface, Class... markers) to ObjectLocator > interface > --- > > Key: TAP5-1321 > URL: https://issues.apache.org/jira/browse/TAP5-1321 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-ioc >Reporter: Tom van Dijk >Assignee: Igor Drobiazko > Attachments: > 0001-TAP5-1321-Add-getService-with-markers-to-ObjectLocat.patch > > > It is useful to be able to get a service using just the interface class and > the markers. > Attached patch will add the method " T getService(Class interface, > Class... markers)" to the ObjectLocator interface. In order to allow using > the "@Local" marker, callers can also use the module builder class (e.g. > MyModule.class") as a marker. > The patch also adds the method " T getService(Class interface, Module > localModule, Class... markers)" to the InternalRegistry interface, which is > used by ObjectLocatorImpl (it has access to the internal Module object) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-1313) Configuration groups to easily allow multiple services with same implementation, allowing handling multiple hibernate databases
[ https://issues.apache.org/jira/browse/TAP5-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-1313. Resolution: Not a Problem > Configuration groups to easily allow multiple services with same > implementation, allowing handling multiple hibernate databases > --- > > Key: TAP5-1313 > URL: https://issues.apache.org/jira/browse/TAP5-1313 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-hibernate, tapestry-ioc >Reporter: Tom van Dijk > Attachments: > Multiple-databases-support-using-configuration-group.patch > > > Contribution groups allow service implementations that are closely linked > together, to be created multiple times (using markers to identify them) with > automatic dependency resolution. > e.g. service implementations OneImpl (implements One) and TwoImpl (implements > Two) use eachother, then with markers red and blue, we get One@Red and > One@Blue and Two@Red and Two@Blue. They will each have their own > configurations (unmarked contributions go to both Red and Blue, but > contributions marked Red will go to the One@Red and Two@Red services, etc.) > This is applied to the hibernate and hibernate-core services, allowing > multiple databases to be used without having to use spring services. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-1313) Configuration groups to easily allow multiple services with same implementation, allowing handling multiple hibernate databases
[ https://issues.apache.org/jira/browse/TAP5-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013582#comment-14013582 ] Tom van Dijk commented on TAP5-1313: I am no longer maintaining my fork of Tapestry and am no longer interested in this patch. Sorry. On Fri, May 30, 2014 at 1:35 PM, Jochen Kemnade (JIRA) > Configuration groups to easily allow multiple services with same > implementation, allowing handling multiple hibernate databases > --- > > Key: TAP5-1313 > URL: https://issues.apache.org/jira/browse/TAP5-1313 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-hibernate, tapestry-ioc >Reporter: Tom van Dijk > Attachments: > Multiple-databases-support-using-configuration-group.patch > > > Contribution groups allow service implementations that are closely linked > together, to be created multiple times (using markers to identify them) with > automatic dependency resolution. > e.g. service implementations OneImpl (implements One) and TwoImpl (implements > Two) use eachother, then with markers red and blue, we get One@Red and > One@Blue and Two@Red and Two@Blue. They will each have their own > configurations (unmarked contributions go to both Red and Blue, but > contributions marked Red will go to the One@Red and Two@Red services, etc.) > This is applied to the hibernate and hibernate-core services, allowing > multiple databases to be used without having to use spring services. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-1321) Add getService(Class serviceInterface, Class... markers) to ObjectLocator interface
[ https://issues.apache.org/jira/browse/TAP5-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013583#comment-14013583 ] Tom van Dijk commented on TAP5-1321: I am no longer contributing. Sorry. On Fri, May 30, 2014 at 1:35 PM, Jochen Kemnade (JIRA) > Add getService(Class serviceInterface, Class... markers) to ObjectLocator > interface > --- > > Key: TAP5-1321 > URL: https://issues.apache.org/jira/browse/TAP5-1321 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-ioc >Reporter: Tom van Dijk >Assignee: Igor Drobiazko > Attachments: > 0001-TAP5-1321-Add-getService-with-markers-to-ObjectLocat.patch > > > It is useful to be able to get a service using just the interface class and > the markers. > Attached patch will add the method " T getService(Class interface, > Class... markers)" to the ObjectLocator interface. In order to allow using > the "@Local" marker, callers can also use the module builder class (e.g. > MyModule.class") as a marker. > The patch also adds the method " T getService(Class interface, Module > localModule, Class... markers)" to the InternalRegistry interface, which is > used by ObjectLocatorImpl (it has access to the internal Module object) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1313) Configuration groups to easily allow multiple services with same implementation, allowing handling multiple hibernate databases
[ https://issues.apache.org/jira/browse/TAP5-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1313: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Configuration groups to easily allow multiple services with same > implementation, allowing handling multiple hibernate databases > --- > > Key: TAP5-1313 > URL: https://issues.apache.org/jira/browse/TAP5-1313 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-hibernate, tapestry-ioc >Reporter: Tom van Dijk > Attachments: > Multiple-databases-support-using-configuration-group.patch > > > Contribution groups allow service implementations that are closely linked > together, to be created multiple times (using markers to identify them) with > automatic dependency resolution. > e.g. service implementations OneImpl (implements One) and TwoImpl (implements > Two) use eachother, then with markers red and blue, we get One@Red and > One@Blue and Two@Red and Two@Blue. They will each have their own > configurations (unmarked contributions go to both Red and Blue, but > contributions marked Red will go to the One@Red and Two@Red services, etc.) > This is applied to the hibernate and hibernate-core services, allowing > multiple databases to be used without having to use spring services. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1337) Forward Thinking Form Validation (HTML5 input fields)
[ https://issues.apache.org/jira/browse/TAP5-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1337: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Forward Thinking Form Validation (HTML5 input fields) > - > > Key: TAP5-1337 > URL: https://issues.apache.org/jira/browse/TAP5-1337 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-beanvalidator, tapestry-core >Reporter: Christian Köberl >Priority: Minor > > Change the rendering of form fields to use forward thinking form validation > as described in > http://www.alistapart.com/articles/forward-thinking-form-validation/ > This enables better usability of users with modern (HTML5 compatible) > browsers. > The required meta-data can be extracted out of the data type of the field and > the validation annotations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1855) JavaScript callback on grid inplace update
[
https://issues.apache.org/jira/browse/TAP5-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Kemnade updated TAP5-1855:
-
This issue has been last updated about 1.5 years ago and has no information
about the versions that are affected. That makes it hard to determine whether
it is still relevant.
If the issue still persists with the current stable version (5.3.7) or the most
recent development preview of Tapestry (5.4-beta-6), both of which are
available from Maven Central, please update it as soon as possible, adding the
respective version(s) to the issue's "Affects Version/s".
> JavaScript callback on grid inplace update
> --
>
> Key: TAP5-1855
> URL: https://issues.apache.org/jira/browse/TAP5-1855
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Mihail Slobodyanuk
>Priority: Minor
> Labels: AJAX, Grid, javascript
>
> It's no direct way to call JS function from InplaceUpdate event handler
> Not in this case:
> void onInplaceUpdateFromGrid(String zone){
> ajaxResponseRenderer.addCallback(new JavaScriptCallback() {
> public void run(JavaScriptSupport javascriptSupport) {
> javascriptSupport.addInitializerCall("updateGrid","");
> }
> });
> }
> neither in this case:
> void onInplaceUpdateFromGrid(String zone) {
> javascriptSupport.addScript("Tapestry.Initializer.updateGrid()");
> }
> function's call don't posted in update zone AJAX response to client.
> It should be to reinitialize styles in updated part.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-245) Better documentation on development environment.
[ https://issues.apache.org/jira/browse/TAP5-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-245: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Better documentation on development environment. > > > Key: TAP5-245 > URL: https://issues.apache.org/jira/browse/TAP5-245 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Reporter: Borut Bolcina > Labels: tapestry5-review-for-closing > > I am just copying the email discussion post: > Luther, > it is true - you can work with WTP and Tomcat 6, but that is like driving the > BMW M5 without the M button being pressed. > Try running the quick start T5 application with mvn jetty:run and with > WTP/Tomcat. Try changing Start.java and then clicking the refresh button in > the browser. Even in this one page web application with 2 java files it takes > 10-times longer with WTP/Tomcat combo to display the changed Start page. I > can imagine it gets worse with larger apps. > And here is my point - if one of the main strengths of Tapestry 5 is live > class reloading, then it is of paramount value to tell developers how can > they harness the power in different development environments. This is where > the documentation fails. I also own the Alexander's book and as much as the > book is welcomed, it is outdated and the information given on page 43 is not > true (at least in present moment): > "You will see that the change you have made is not reflected by the running > application, because you have changed an HTML file, and not Java code. Smilar > to NetBeans, Eclipse doesn't care about changes in HTML files. One way to > update the application in such case is to follow the advice given for > NetBeans - make change, even if it is an insignificant one, to some Java > file, and save the file. The application will then be reloaded automatically." > This is so not T5-ish. > If there are many ways to develop T5 web apps, then some of this cases should > be explained clearly as this is IMHO one of the barriers many new tapestry > users are hitting at the very beginning. Of course some cases can be > published on wiki, but the most common two or three must be on main T5 page - > this is where most users start. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-798) AjaxFormLoop - Add new rows before or after desired row, not top or bottom
[ https://issues.apache.org/jira/browse/TAP5-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-798: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > AjaxFormLoop - Add new rows before or after desired row, not top or bottom > -- > > Key: TAP5-798 > URL: https://issues.apache.org/jira/browse/TAP5-798 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Dustin Digmann >Priority: Minor > > I am using an AjaxFormLoop. Currently, I am required to add new rows at the > very top or very bottom. I would like to be able to add rows before or > after any specific row as well. > For now I will be making my own process, but find it more desirable if T5 > built this in. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-637) There should be a javascript counterpart for the URLEncoder service
[ https://issues.apache.org/jira/browse/TAP5-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-637: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > There should be a javascript counterpart for the URLEncoder service > --- > > Key: TAP5-637 > URL: https://issues.apache.org/jira/browse/TAP5-637 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Reporter: Hugo Palma >Priority: Minor > Labels: tapestry5-review-for-closing > Attachments: url-encoder.js > > > This is very useful if you want to build event urls in javascript. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-918) Add mocks to registry with lifecycle for testing
[ https://issues.apache.org/jira/browse/TAP5-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-918: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Add mocks to registry with lifecycle for testing > > > Key: TAP5-918 > URL: https://issues.apache.org/jira/browse/TAP5-918 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Reporter: Adriaan Joubert > > For tests that use the IoC registry it would be nice to be able to override > an existing binding so that the registry will return a Mock object from a > test. > This also requires a lifecycle that can deal with objects being recreated for > successive tests for both singleton and per-thread services. This will > presumably require overriding the scope on an existing service binding. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1248) Additional maven info on quickstart page
[ https://issues.apache.org/jira/browse/TAP5-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1248: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Additional maven info on quickstart page > > > Key: TAP5-1248 > URL: https://issues.apache.org/jira/browse/TAP5-1248 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Reporter: Tobias Marx >Priority: Minor > > Would be nice to add some more info on the quickstart page to make it easier > to get it running for newbees. > 1. Info about settings.xml - for example location, how to add a proxy for > firewalls > 2. list of mirrors to add to make sure the command works for most users, i.e. > how to add them in global maven file > 3. what to do if maven build fails (e.g. try to change the tapestry version > in the last line of the pom.xml to a previous/next version or by removing > snapshot version) > 4. maven version used /tested with > The detailled info is on the maven page of course - but a few a couple of > line to the most common problems would be nice. > I think many try and don't bother again if it fails -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-981) Provide new mojo for generation of of symbols documentation
[ https://issues.apache.org/jira/browse/TAP5-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-981: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Provide new mojo for generation of of symbols documentation > > > Key: TAP5-981 > URL: https://issues.apache.org/jira/browse/TAP5-981 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-component-report >Reporter: Igor Drobiazko >Priority: Minor > > The documentation of symbols is always outdated. This process should be > automatized. Add a new mojo for generation of symbol documentation. This mojo > should analize public static fields of configured classes and gererate an > ouput like this one: > http://tapestry.apache.org/tapestry5/guide/conf.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1515) Support for external assets
[
https://issues.apache.org/jira/browse/TAP5-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Kemnade updated TAP5-1515:
-
This issue has been last updated about 1.5 years ago and has no information
about the versions that are affected. That makes it hard to determine whether
it is still relevant.
If the issue still persists with the current stable version (5.3.7) or the most
recent development preview of Tapestry (5.4-beta-6), both of which are
available from Maven Central, please update it as soon as possible, adding the
respective version(s) to the issue's "Affects Version/s".
> Support for external assets
> ---
>
> Key: TAP5-1515
> URL: https://issues.apache.org/jira/browse/TAP5-1515
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
>Reporter: Hugo Palma
>
> It would be great if an external asset (url based) could be referenced from
> Tapestry. For example, i may want to include a CDN asset in an Import
> annotation in a component.
> One resolution suggestion would be to introduce an "uri" prefix, something
> like:
> @Import(library = {
> "uri:https://ajax.googleapis.com/ajax/libs/jquery/1.5.2/jquery.min.js"; })
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-1102) Customization of invocations / callbacks on the rowinjector trigger
[ https://issues.apache.org/jira/browse/TAP5-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1102: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Customization of invocations / callbacks on the rowinjector trigger > > > Key: TAP5-1102 > URL: https://issues.apache.org/jira/browse/TAP5-1102 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Peter Stavrinides >Priority: Minor > > It could be made easier to customize invocations on the rowinjector trigger > using JavaScript, at the moment its harder than it should be and limited to > the click event. > Robert Zeigler Wrote: > It might be a nifty change to enable a second form of the "addAddRowTrigger" > that takes, say, a js callback name as a 2nd argument. Or perhaps some flag > triggering whether the first argument is an id or a callback. In any event, > the initializer could then check for the appropriate condition, and if the > condition is met, the initializer would delegate the setup to the callback, > passing in the row injector, rather than assuming a click. If there's > enough interest in something like this, I would be willing to do the work to > add it to the framework (the exact api would need to be worked out, though). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-771) allow to add a .html to page render requests
[ https://issues.apache.org/jira/browse/TAP5-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-771: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > allow to add a .html to page render requests > > > Key: TAP5-771 > URL: https://issues.apache.org/jira/browse/TAP5-771 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Andy Pahne >Priority: Minor > > A common request is to allow a .html extension for page render requests. It > would be nice when Tapestry also could be configured to add the desired > extension to generated URLs. > For backwards compatibility this behaviour could be turned off by default. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-638) Support for uploading files using AJAX
[ https://issues.apache.org/jira/browse/TAP5-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-638: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Support for uploading files using AJAX > -- > > Key: TAP5-638 > URL: https://issues.apache.org/jira/browse/TAP5-638 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-upload >Reporter: Hugo Palma >Assignee: Massimo Lusetti > > If the upload component is included on a form that does a partial update(has > the zone parameter set) the value property isn't updated with the > UploadedFile instance. > So it seems that this component upload doesn't support ajax. It would be > great if it was possible to upload a file using AJAX. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-558) Create modal dialog component
[ https://issues.apache.org/jira/browse/TAP5-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-558: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Create modal dialog component > - > > Key: TAP5-558 > URL: https://issues.apache.org/jira/browse/TAP5-558 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Reporter: Ville Virtanen >Assignee: Ulrich Stärk > Attachments: Dialog-Mixin-src.tar.gz, tawus-addons.tar.gz > > > Tapestry's AJAX support is missing one important component, modal (or > non-modal) dialog. Dialog could be created with > http://www.wildbit.com/labs/modalbox/ or http://roland.devarea.nl/dialog/ or > http://github.com/robhurring/prototype-dialog/ or > http://livepipe.net/control/window > After quick look first one looks like most professional. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1982) Additional @Symbol example for documentation
[
https://issues.apache.org/jira/browse/TAP5-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Kemnade updated TAP5-1982:
-
This issue has been last updated about 1.5 years ago and has no information
about the versions that are affected. That makes it hard to determine whether
it is still relevant.
If the issue still persists with the current stable version (5.3.7) or the most
recent development preview of Tapestry (5.4-beta-6), both of which are
available from Maven Central, please update it as soon as possible, adding the
respective version(s) to the issue's "Affects Version/s".
> Additional @Symbol example for documentation
>
>
> Key: TAP5-1982
> URL: https://issues.apache.org/jira/browse/TAP5-1982
> Project: Tapestry 5
> Issue Type: Improvement
>Reporter: Chris Mylonas
>Priority: Trivial
> Labels: documentation
>
> Taha replied to an email with a solution to a simple @Symbol that a noob
> could easily try out that is a more complete example than currently in docs.
> With @Symbol you must use @Inject too
> @Proeprty
> @Inject
> @Symbol(SymbolConstants.PRODUCTION_MODE)
> private boolean productionMode
> BTW you can also use :-
>
> ${symbol:tapestry.production-mode}
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-1012) BeanEditForm should use form id for search for label messages
[ https://issues.apache.org/jira/browse/TAP5-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1012: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > BeanEditForm should use form id for search for label messages > - > > Key: TAP5-1012 > URL: https://issues.apache.org/jira/browse/TAP5-1012 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Reporter: Andreas Pardeike >Priority: Minor > > BeanEditForm should use form_id-field_id- prefix to look up label names but > currently does not. However, for regexp definitions, it already does so. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1552) Ajax and Zones documentation should explain zones in loops using id attribute
[ https://issues.apache.org/jira/browse/TAP5-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1552: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Ajax and Zones documentation should explain zones in loops using id attribute > - > > Key: TAP5-1552 > URL: https://issues.apache.org/jira/browse/TAP5-1552 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Reporter: Josh Canfield > > http://tapestry.apache.org/ajax-and-zones.html > In Zone Limitations says: > Unlike many other situations, Tapestry relies on you to specify useful and > unique ids to Zone components, then reference those ids inside EventLink (or > ActionLink, or Form) components. Using Zone components inside any kind of > loop may cause additional problems, as Tapestry will uniqueify the client id > you specify (appending an index number). > Using a generated "id" attribute allows you to control the id of the zone in > the page. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1400) Change AbstractLink (and its subclasses) to optionally surround rendered text with a tag (e.g. span) when disabled
[ https://issues.apache.org/jira/browse/TAP5-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1400: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Change AbstractLink (and its subclasses) to optionally surround rendered text > with a tag (e.g. span) when disabled > -- > > Key: TAP5-1400 > URL: https://issues.apache.org/jira/browse/TAP5-1400 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: nillehammer >Priority: Minor > > I frequently use Tapetry's Link components (PageLink, EventLink, ActionLink) > to build up vertical menus. I like to style the rendered a-Tags with > "display:block" by assigning an appropriate css-Class. This expands the area > where the link is clickeable and makes a line break after the rendered link. > The latter spares me from surrounding the a-Tags with an additional div. When > using the disabled-Parameter of the Link compontents the text in the body is > rendered as is, leaving me without any tags to apply styles to. So to ensure > the line break I would have to insert tags myself into the template. > I was wondering, if it were possible to add an optional parameter to the Link > compontents to make them render a tag around the text and apply the informal > parameters "style" and "class" to them. I can think of a boolean value or a > String value > /** > * When set to true, this parameter causes Link to render a a span-Tag > around the text that is rendered when link is disabled. When set to false > (default), the text will be rendered as is. > **/ > @Parameter(defaultPrefix = BindingConstants.LITERAL, required = false, > allowNull = true) > private boolean renderSpan; > Or second alternative > /** > * When set to a non null value, the provided string will be used as a tag > that is rendered around the text that is rendered when link is disabled. When > set to null (default) or empty String, the text will be rendered as is. > **/ > @Parameter(defaultPrefix = BindingConstants.LITERAL, required = false, > allowNull = true) > private String disabledTag; > This way the change would be backwards compatible. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-886) BeanEditor/PropertyEditor refactor for easy customization/extension
[ https://issues.apache.org/jira/browse/TAP5-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-886: This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > BeanEditor/PropertyEditor refactor for easy customization/extension > --- > > Key: TAP5-886 > URL: https://issues.apache.org/jira/browse/TAP5-886 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Giulio Micali >Priority: Minor > > Problem Description: > This post is derived from my wish to write a custom improved BeanEditor > component, extending its behaviour to manage read-only properties, excluding > all attributes of one or more parent classes of my bean, ecc... > I tried to write that component, but I found that I should override(alias > duplicating) too many components/services involved in the process: > A) the BeanModelSource service: > I had overridden the createEditModel() in order to call create(beanClass, > false, messages); to view the read-only properties. > B) the BeanBlockSource service: > the "edit blocks" contains the editor, but also the label: the worst problem > stays here, forcing the layout of the container(BeanEditor or MyBeanEditor) > in a too much restricted way. > C) the propertyEditor: > this component gets the model from BeanModelSource and the (default)block to > render from BeanBlockSource: > - it doesn't know if a property is "read only", so if I override the > BeanModelSource to get read only properties, it cannot discriminate them and > render always a form control. > - the Block interface does not expose it's children list, so I cannot use a > dirty-workaround to remove the "label" component at rendering time > D) MyBeanEditor (obviously): > here I will rewrite the template, extend the original POJO with custom > modifications, ecc... > but to do so, I have to do the overrides described above. > Too many things to override. > Suggested Solution: > 1) the BeanModelSource service > - the returned PropertyModel must have a boolean "writable" property, taken > from PropertyAdapter.isUpdate(). > - the createEditModel() method is no longer useful, beanEditor must call > directly BeanModelSource.create(model, !BeanEditor.displayReadOnly, messages). > 2) the BeanBlockSource service > - the "label" component must be detached from the "editor" block and should > have it's own block "Label" (like the grid component header) with > default value > With that change, we can use propertyEditor inside other components(like grid > or custom components) > 3) the propertyEditor: > - if a property is read-only, the editor (default)block will be taken from > the BeanDisplay-related blocks. > - (optional) can have a parameter "disabled" (tipically the BeanEditor can > pass it's own value): the value will "mark" at runtime the property as > read-only, overriding the value from BeanModel. > 4) BeanEditor > the BeanEditor must: > - add a boolean parameter "displayReadOnly", which affects the call to > BeanModelSource.create(model, !displayReadOnly, messages); > - provide by itself the "label block" just like the BeanDisplay component(a > base class for that will be the best) getting it from the BeanBlockSource > service. > - if a property is read-only, the label block will be taken from the > BeanDisplay-related block. > - both label and editor block will be overridable just with the "overrides" > behaviour. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1602) Add Zone parameter to Checkbox component
[ https://issues.apache.org/jira/browse/TAP5-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1602: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Add Zone parameter to Checkbox component > > > Key: TAP5-1602 > URL: https://issues.apache.org/jira/browse/TAP5-1602 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Reporter: Denis Stepanov >Assignee: Andreas Andreou > Attachments: checkboxZonePatch.patch > > > Sometimes it's better to use zone update rather than formfragment trigger. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1179) Exclude non-autowire candidate beans from being injected when using @Inject
[ https://issues.apache.org/jira/browse/TAP5-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1179: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Exclude non-autowire candidate beans from being injected when using @Inject > --- > > Key: TAP5-1179 > URL: https://issues.apache.org/jira/browse/TAP5-1179 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-spring >Reporter: Dustin Woods >Priority: Minor > > It would be nice for Tapestry-Spring to follow the same behavior as Spring > when injecting beans based on type. > Spring JIRA Issue > http://jira.springframework.org/browse/SPR-7120?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel > Spring JIRA Issue Fix > https://fisheye.springsource.org/browse/spring-framework/trunk/org.springframework.beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java?r1=3287&r2= -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1872) DateField component should support pick time as well as date
[ https://issues.apache.org/jira/browse/TAP5-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1872: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > DateField component should support pick time as well as date > > > Key: TAP5-1872 > URL: https://issues.apache.org/jira/browse/TAP5-1872 > Project: Tapestry 5 > Issue Type: Bug >Reporter: alberto >Priority: Minor > Labels: datefield, datetime, tapestry5 > > With t:datefield a calendar is showed to pick in the day I want to choose but > It's no possible something similar for time > If I add the parameter editTime, then when I pick in the calendar, hour and > minutes are showed in the field, but I didn't choose them in the pop-up > calendar, where I only can choose the date -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1321) Add getService(Class serviceInterface, Class... markers) to ObjectLocator interface
[ https://issues.apache.org/jira/browse/TAP5-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1321: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Add getService(Class serviceInterface, Class... markers) to ObjectLocator > interface > --- > > Key: TAP5-1321 > URL: https://issues.apache.org/jira/browse/TAP5-1321 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-ioc >Reporter: Tom van Dijk >Assignee: Igor Drobiazko > Attachments: > 0001-TAP5-1321-Add-getService-with-markers-to-ObjectLocat.patch > > > It is useful to be able to get a service using just the interface class and > the markers. > Attached patch will add the method " T getService(Class interface, > Class... markers)" to the ObjectLocator interface. In order to allow using > the "@Local" marker, callers can also use the module builder class (e.g. > MyModule.class") as a marker. > The patch also adds the method " T getService(Class interface, Module > localModule, Class... markers)" to the InternalRegistry interface, which is > used by ObjectLocatorImpl (it has access to the internal Module object) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1325) Provide improvements on Element for better lookup of containing elements
[ https://issues.apache.org/jira/browse/TAP5-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1325: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Provide improvements on Element for better lookup of containing elements > > > Key: TAP5-1325 > URL: https://issues.apache.org/jira/browse/TAP5-1325 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Igor Drobiazko >Priority: Minor > > Beside getElementById(String) method there should be a generic methods > getElementByAttributeValue(String, String). > Also improvments of XPATH-based search would be useful -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1615) Add not null check expression syntax
[ https://issues.apache.org/jira/browse/TAP5-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1615: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Add not null check expression syntax > > > Key: TAP5-1615 > URL: https://issues.apache.org/jira/browse/TAP5-1615 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Reporter: Denis Stepanov >Priority: Minor > Attachments: tapestry-notnull.patch > > > New sytax will allow to check if expression result is not null > value="prop?" - returns true if "prop" is not null > value="prop.a.b.c?" returns true if "c" is not null > value="prop?.a?.b?.c?" returns true if "c" is not null > value="m()?" returns true if result of the method "m" is not null -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1143) Grid should allow empty "include" parameter
[ https://issues.apache.org/jira/browse/TAP5-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1143: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Grid should allow empty "include" parameter > --- > > Key: TAP5-1143 > URL: https://issues.apache.org/jira/browse/TAP5-1143 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Geoff Callender > > I wanted to create a grid with only one column which is a synthetic property, > so I specified include="" add="syntheticProperty", but the include parameter > cannot be null. > Instead, I had to exclude all of the source's properties, eg. > exclude="propertyA, propertyB, propertyC" add="syntheticProperty", which is > brittle because it will misbehave if the source is given any new properties. > Here's a live example: > http://jumpstart.doublenegative.com.au/jumpstart/examples/onepagecrud -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1285) Allow GET method in form component
[ https://issues.apache.org/jira/browse/TAP5-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1285: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Allow GET method in form component > -- > > Key: TAP5-1285 > URL: https://issues.apache.org/jira/browse/TAP5-1285 > Project: Tapestry 5 > Issue Type: Wish > Components: tapestry-core >Reporter: Lutz Hühnken >Priority: Minor > > The Tapestry form component is currently only supporting the "POST" method. > The POST method is usually associated with changing the "model" on the server > side, e.g. in REST applications, POST indicates that a resource is modified, > if I am not mistaken. > The lack of GET support makes it necessary to use POST also for simple > queries, such as a search field, where the model is not modified. > This is a) semantically irritating, since for example a search query will not > modify state and > b) requires extra "work", for example a redirect-after-post, where it should > not be necessary. > Since Tapestry aspires to make the simple things easy, the difficult things > possible, I think it should provide first-class support for the GET method. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1003) Make Label try -label and for translation text
[ https://issues.apache.org/jira/browse/TAP5-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1003: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Make Label try -label and for translation text > --- > > Key: TAP5-1003 > URL: https://issues.apache.org/jira/browse/TAP5-1003 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Christoph Jäger >Priority: Minor > > A Label currently queries the Messages instance for a translation with key > "-label". It would be nice if also "" (without the "-label" suffix) > was tried if no translation was found for key "-label". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1757) Grid does not fully adhere to volatile="true"
[ https://issues.apache.org/jira/browse/TAP5-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1757: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Grid does not fully adhere to volatile="true" > - > > Key: TAP5-1757 > URL: https://issues.apache.org/jira/browse/TAP5-1757 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Reporter: Ville Virtanen > Attachments: grid_volatile.patch > > > Tapestry omits the state saving of the grid if volatile parameter is set to > true. However, grid still invokes the setupdatasource during form postback > even though it is (when volatile is true) unneccassary. It also prevents us > from using grid under some ajax circumstances with form. > The proposed patch simply changes the parameter "volatile" of gridrows to be > promoted as grid's parameter, and the gridrows inherits it. Now that Grid has > the knowledge of the parameter it is trivial to add it to the if that checks > whether the grid is inside form or not (when adding the setupdatasourceevent > to formsupport). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1212) Warn message on onValidate message without parameters
[ https://issues.apache.org/jira/browse/TAP5-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1212: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Warn message on onValidate message without parameters > - > > Key: TAP5-1212 > URL: https://issues.apache.org/jira/browse/TAP5-1212 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Michal Gruca >Priority: Trivial > > Idea come up during discussion in this thread > http://tapestry-users.832.n2.nabble.com/Validation-in-component-using-onValidate-method-td5315887.html#a5315887 > Tapestry could log message on warn level if user provided onValidate() method > without any parameter. This method does nothing and warn would help developer > to solve problem in a proper way. Maybe if Tapestry module is configured to > be in development mode, then some exception could be thrown, but that could > be to excessive. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1506) Add ability to assemble pages and components at startup
[ https://issues.apache.org/jira/browse/TAP5-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1506: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Add ability to assemble pages and components at startup > --- > > Key: TAP5-1506 > URL: https://issues.apache.org/jira/browse/TAP5-1506 > Project: Tapestry 5 > Issue Type: New Feature >Reporter: Denis Stepanov > > Users are experiencing slowness after application deployment. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1842) @Startup should support id and constraints
[ https://issues.apache.org/jira/browse/TAP5-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1842: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > @Startup should support id and constraints > -- > > Key: TAP5-1842 > URL: https://issues.apache.org/jira/browse/TAP5-1842 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-ioc >Reporter: Denis Stepanov > Attachments: 0001-TAP5-1842.patch > > > It would be nice to have something like: > @Startup(id = "DBInit", constraints = "before:*") -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1526) Tapestry5 plugin for roo
[ https://issues.apache.org/jira/browse/TAP5-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1526: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Tapestry5 plugin for roo > > > Key: TAP5-1526 > URL: https://issues.apache.org/jira/browse/TAP5-1526 > Project: Tapestry 5 > Issue Type: Wish >Reporter: Toby > > There should be a Tapestry5 plugin for Roo (http://www.springsource.org/roo). > As probably every Tapestry5 developer is also using Spring, it would be good > if Tapestry5 and Roo joined forces > Things like: > - command line tools > - plugins (spring-security, selenium) > - eclipse tools > could be shared. > Both the pure Java approach and the Tapestry approach have their > advantages/disadvantages, depending on the scenerio. > So control interfaces or ajax/comet/atmosphere kind of application are often > better off to be developed using Roo+Vaadin - and as an alternative for web > applications where seo/urls and templates matter, > Roo+Tapestry5 is the best choice (e.g. when ready-made HTML templates are > delivered and need to be implemented). > Roo seems to focus more on the first approach, but a kind of plugin (e.g. for > Tapestry5), to offer the second approach to Roo developers would be extremely > helpful. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1986) Progressive display ignores application defaults for zone update effect
[ https://issues.apache.org/jira/browse/TAP5-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1986: - This issue has been last updated about 1.5 years ago and has no information about the versions that are affected. That makes it hard to determine whether it is still relevant. If the issue still persists with the current stable version (5.3.7) or the most recent development preview of Tapestry (5.4-beta-6), both of which are available from Maven Central, please update it as soon as possible, adding the respective version(s) to the issue's "Affects Version/s". > Progressive display ignores application defaults for zone update effect > --- > > Key: TAP5-1986 > URL: https://issues.apache.org/jira/browse/TAP5-1986 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Christoph Stichlberger >Priority: Minor > > The progressive display has no global default for the "update" parameter that > is used for zone updates. > Because of this, the zone update of progressive displays can't be customized > using the application defaults, and has to be specified in every place it's > used. > It probably should use the same default as the zone for its update parameter: > value = BindingConstants.SYMBOL + ":" + > ComponentParameterConstants.ZONE_UPDATE_METHOD -- This message was sent by Atlassian JIRA (v6.2#6252)
