[jira] [Commented] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050846#comment-14050846 ] Hudson commented on TAP5-2351: -- FAILURE: Integrated in tapestry-trunk-freestyle #1275 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1275/]) TAP5-2351 : Missing Bootstrap CSS Source Map (actually, removing the (thiagohp: rev db3a7a6847c79358835ac00ac6bbe1e2f7b0c954) * tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css * tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: bootstrap, month-of-tapestry > Fix For: 5.4 > > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-2351. - Resolution: Fixed Fix Version/s: 5.4 > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: bootstrap, month-of-tapestry > Fix For: 5.4 > > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2351: Labels: bootstrap month-of-tapestry (was: bootstrap) > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: bootstrap, month-of-tapestry > Fix For: 5.4 > > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050770#comment-14050770 ] ASF subversion and git services commented on TAP5-2351: --- Commit db3a7a6847c79358835ac00ac6bbe1e2f7b0c954 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=db3a7a6 ] TAP5-2351 : Missing Bootstrap CSS Source Map (actually, removing the reference from the CSS files) > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: bootstrap > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2351 : Missing Bootstrap CSS Source Map (actually, removing the reference from the CSS files)
Repository: tapestry-5
Updated Branches:
refs/heads/master 2e11d5dd3 -> db3a7a684
TAP5-2351 : Missing Bootstrap CSS Source Map (actually, removing the
reference from the CSS files)
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/db3a7a68
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/db3a7a68
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/db3a7a68
Branch: refs/heads/master
Commit: db3a7a6847c79358835ac00ac6bbe1e2f7b0c954
Parents: 2e11d5d
Author: Thiago H. de Paula Figueiredo
Authored: Wed Jul 2 18:56:30 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Wed Jul 2 18:56:30 2014 -0300
--
.../META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css | 1 -
.../resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css | 1 -
2 files changed, 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/db3a7a68/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css
--
diff --git
a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css
b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css
index f860bbc..dff87f6 100644
---
a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css
+++
b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap-theme.css
@@ -439,4 +439,3 @@
-webkit-box-shadow: inset 0 1px 3px rgba(0, 0, 0, .05), 0 1px 0 rgba(255,
255, 255, .1);
box-shadow: inset 0 1px 3px rgba(0, 0, 0, .05), 0 1px 0 rgba(255,
255, 255, .1);
}
-/*# sourceMappingURL=bootstrap-theme.css.map */
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/db3a7a68/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css
--
diff --git
a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css
b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css
index 037dd05..88123dc 100644
---
a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css
+++
b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap/css/bootstrap.css
@@ -6200,4 +6200,3 @@ button.close {
display: none !important;
}
}
-/*# sourceMappingURL=bootstrap.css.map */
[jira] [Assigned] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo reassigned TAP5-2351: --- Assignee: Thiago H. de Paula Figueiredo (was: Jochen Kemnade) > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Thiago H. de Paula Figueiredo >Priority: Minor > Labels: bootstrap > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2192) Add support for distributed documentation
[ https://issues.apache.org/jira/browse/TAP5-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2192: Labels: documentation month-of-tapestry (was: docuentation) > Add support for distributed documentation > - > > Key: TAP5-2192 > URL: https://issues.apache.org/jira/browse/TAP5-2192 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.4 >Reporter: Barry Books >Assignee: Thiago H. de Paula Figueiredo > Labels: documentation, month-of-tapestry > > Please add support for a distributed documentation system. The basic > requirements are: > 1. Access to a list of Pages/Compoents/Mixins. (ComponentClassResolver > supports pages) > 2. Access to a Map of all Configurations. The map would have the > configuration class as the Key and contain an object such a list or map that > contains the configuration. > 3. Access to a list of configured services. > From this it should be possible to build documentation of a running system. > Thanks > Barry -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-1501) Asset Inheritance
[
https://issues.apache.org/jira/browse/TAP5-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo resolved TAP5-1501.
-
Resolution: Duplicate
Fix Version/s: 5.4
> Asset Inheritance
> -
>
> Key: TAP5-1501
> URL: https://issues.apache.org/jira/browse/TAP5-1501
> Project: Tapestry 5
> Issue Type: Wish
> Components: tapestry-core
>Affects Versions: 5.2
>Reporter: Alex Lumpov
>Assignee: Howard M. Lewis Ship
> Fix For: 5.4
>
>
> Suppose there is a component that uses a certain asset (for example
> DateField). I want to extend it.
> For example:
> package mypackage.testapp.components;
> import org.apache.tapestry5.corelib.components.DateField;
> public class MyDateField extends DateField {
> }
> If i change the asset and put it in a new classpath, then everything is fine.
> But if i want to override only a class and use the already existing asset,
> then i get the error:
> Unable to locate asset 'classpath:mypackage/testapp/components/datefield.gif'
> (the file does not exist).
> Hide uninteresting stack frames Stack trace
> Unable to locate asset 'classpath:mypackage/testapp/components/datefield.gif'
> (the file does not exist).
> Stack trace:
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getLocalizedAssetFromResource(AssetSourceImpl.java:135)
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getAssetInLocale(AssetSourceImpl.java:105)
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getAsset(AssetSourceImpl.java:85)
> * $AssetSource_12f2703a8d2.getAsset($AssetSource_12f2703a8d2.java)
> *
> org.apache.tapestry5.internal.bindings.AssetBindingFactory.newBinding(AssetBindingFactory.java:45)
> *
> $BindingFactory_12f2703a9a5.newBinding($BindingFactory_12f2703a9a5.java)
> *
> org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:78)
> *
> org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:41)
>
> ...
> It seems to me it would be nice if the classpath assets could be inheritable
> like templates.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-1501) Asset Inheritance
[
https://issues.apache.org/jira/browse/TAP5-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo updated TAP5-1501:
Labels: (was: bulk-close-candidate)
> Asset Inheritance
> -
>
> Key: TAP5-1501
> URL: https://issues.apache.org/jira/browse/TAP5-1501
> Project: Tapestry 5
> Issue Type: Wish
> Components: tapestry-core
>Affects Versions: 5.2
>Reporter: Alex Lumpov
>Assignee: Thiago H. de Paula Figueiredo
> Fix For: 5.4
>
>
> Suppose there is a component that uses a certain asset (for example
> DateField). I want to extend it.
> For example:
> package mypackage.testapp.components;
> import org.apache.tapestry5.corelib.components.DateField;
> public class MyDateField extends DateField {
> }
> If i change the asset and put it in a new classpath, then everything is fine.
> But if i want to override only a class and use the already existing asset,
> then i get the error:
> Unable to locate asset 'classpath:mypackage/testapp/components/datefield.gif'
> (the file does not exist).
> Hide uninteresting stack frames Stack trace
> Unable to locate asset 'classpath:mypackage/testapp/components/datefield.gif'
> (the file does not exist).
> Stack trace:
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getLocalizedAssetFromResource(AssetSourceImpl.java:135)
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getAssetInLocale(AssetSourceImpl.java:105)
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getAsset(AssetSourceImpl.java:85)
> * $AssetSource_12f2703a8d2.getAsset($AssetSource_12f2703a8d2.java)
> *
> org.apache.tapestry5.internal.bindings.AssetBindingFactory.newBinding(AssetBindingFactory.java:45)
> *
> $BindingFactory_12f2703a9a5.newBinding($BindingFactory_12f2703a9a5.java)
> *
> org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:78)
> *
> org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:41)
>
> ...
> It seems to me it would be nice if the classpath assets could be inheritable
> like templates.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-1501) Asset Inheritance
[
https://issues.apache.org/jira/browse/TAP5-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiago H. de Paula Figueiredo updated TAP5-1501:
Assignee: Howard M. Lewis Ship (was: Thiago H. de Paula Figueiredo)
> Asset Inheritance
> -
>
> Key: TAP5-1501
> URL: https://issues.apache.org/jira/browse/TAP5-1501
> Project: Tapestry 5
> Issue Type: Wish
> Components: tapestry-core
>Affects Versions: 5.2
>Reporter: Alex Lumpov
>Assignee: Howard M. Lewis Ship
> Fix For: 5.4
>
>
> Suppose there is a component that uses a certain asset (for example
> DateField). I want to extend it.
> For example:
> package mypackage.testapp.components;
> import org.apache.tapestry5.corelib.components.DateField;
> public class MyDateField extends DateField {
> }
> If i change the asset and put it in a new classpath, then everything is fine.
> But if i want to override only a class and use the already existing asset,
> then i get the error:
> Unable to locate asset 'classpath:mypackage/testapp/components/datefield.gif'
> (the file does not exist).
> Hide uninteresting stack frames Stack trace
> Unable to locate asset 'classpath:mypackage/testapp/components/datefield.gif'
> (the file does not exist).
> Stack trace:
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getLocalizedAssetFromResource(AssetSourceImpl.java:135)
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getAssetInLocale(AssetSourceImpl.java:105)
> *
> org.apache.tapestry5.internal.services.AssetSourceImpl.getAsset(AssetSourceImpl.java:85)
> * $AssetSource_12f2703a8d2.getAsset($AssetSource_12f2703a8d2.java)
> *
> org.apache.tapestry5.internal.bindings.AssetBindingFactory.newBinding(AssetBindingFactory.java:45)
> *
> $BindingFactory_12f2703a9a5.newBinding($BindingFactory_12f2703a9a5.java)
> *
> org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:78)
> *
> org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:41)
>
> ...
> It seems to me it would be nice if the classpath assets could be inheritable
> like templates.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050673#comment-14050673 ] Howard M. Lewis Ship commented on TAP5-2351: I think you are right on the money, Thiago. > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Jochen Kemnade >Priority: Minor > Labels: bootstrap > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2351) Missing Bootstrap CSS Source Map
[ https://issues.apache.org/jira/browse/TAP5-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050560#comment-14050560 ] Thiago H. de Paula Figueiredo commented on TAP5-2351: - I vote for removing the source map file reference from the files. It doesn't make much sense to see the source map of a file we're not editing. > Missing Bootstrap CSS Source Map > > > Key: TAP5-2351 > URL: https://issues.apache.org/jira/browse/TAP5-2351 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Thilo Tanner >Assignee: Jochen Kemnade >Priority: Minor > Labels: bootstrap > > The source map file (boostrap.css.map) for bootstrap.css is missing in the > core stack. It could either be shipped with Tapestry or the reference at the > end of bootstrap.css could be removed: > /*# sourceMappingURL=bootstrap.css.map */ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2185) Problem with the asset checksums and relative paths based on them
[ https://issues.apache.org/jira/browse/TAP5-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050305#comment-14050305 ] Hudson commented on TAP5-2185: -- FAILURE: Integrated in tapestry-trunk-freestyle #1274 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1274/]) TAP5-2185 (thiagohp: rev 2e11d5dd3d9fdb48d47ed3ba8559b506e32c4486) * tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/nested/AssetDemo.tml * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AssetTests.java * tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java * tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/nested/AssetWithWrongChecksum.js * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/AssetDemo.java > Problem with the asset checksums and relative paths based on them > - > > Key: TAP5-2185 > URL: https://issues.apache.org/jira/browse/TAP5-2185 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > When JavaScript modules reference other (non-tapestry) JS code via relative > paths, > or absolute paths that have to be configured, the checksum is preventing > the other resources from being accessed properly > Discussion regarding this can be found here: > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Re-5-4-Problems-with-the-asset-checksums-and-relative-paths-based-on-them-td5723366.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2185) Problem with the asset checksums and relative paths based on them
[ https://issues.apache.org/jira/browse/TAP5-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2185: Labels: month-of-tapestry (was: ) > Problem with the asset checksums and relative paths based on them > - > > Key: TAP5-2185 > URL: https://issues.apache.org/jira/browse/TAP5-2185 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > When JavaScript modules reference other (non-tapestry) JS code via relative > paths, > or absolute paths that have to be configured, the checksum is preventing > the other resources from being accessed properly > Discussion regarding this can be found here: > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Re-5-4-Problems-with-the-asset-checksums-and-relative-paths-based-on-them-td5723366.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (TAP5-2185) Problem with the asset checksums and relative paths based on them
[ https://issues.apache.org/jira/browse/TAP5-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo resolved TAP5-2185. - Resolution: Fixed Fix Version/s: 5.4 Solved by trying to find the asset in the classpath and in the context and, if found, redirect to its correct URL (the one with the correct checksum). > Problem with the asset checksums and relative paths based on them > - > > Key: TAP5-2185 > URL: https://issues.apache.org/jira/browse/TAP5-2185 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > Labels: month-of-tapestry > Fix For: 5.4 > > > When JavaScript modules reference other (non-tapestry) JS code via relative > paths, > or absolute paths that have to be configured, the checksum is preventing > the other resources from being accessed properly > Discussion regarding this can be found here: > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Re-5-4-Problems-with-the-asset-checksums-and-relative-paths-based-on-them-td5723366.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2185) Problem with the asset checksums and relative paths based on them
[ https://issues.apache.org/jira/browse/TAP5-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050060#comment-14050060 ] ASF subversion and git services commented on TAP5-2185: --- Commit 2e11d5dd3d9fdb48d47ed3ba8559b506e32c4486 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=2e11d5d ] TAP5-2185 > Problem with the asset checksums and relative paths based on them > - > > Key: TAP5-2185 > URL: https://issues.apache.org/jira/browse/TAP5-2185 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Lenny Primak >Assignee: Thiago H. de Paula Figueiredo > > When JavaScript modules reference other (non-tapestry) JS code via relative > paths, > or absolute paths that have to be configured, the checksum is preventing > the other resources from being accessed properly > Discussion regarding this can be found here: > http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Re-5-4-Problems-with-the-asset-checksums-and-relative-paths-based-on-them-td5723366.html -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2185
Repository: tapestry-5
Updated Branches:
refs/heads/master 23f491d55 -> 2e11d5dd3
TAP5-2185
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2e11d5dd
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2e11d5dd
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2e11d5dd
Branch: refs/heads/master
Commit: 2e11d5dd3d9fdb48d47ed3ba8559b506e32c4486
Parents: 23f491d
Author: Thiago H. de Paula Figueiredo
Authored: Wed Jul 2 12:42:38 2014 -0300
Committer: Thiago H. de Paula Figueiredo
Committed: Wed Jul 2 12:42:38 2014 -0300
--
.../internal/services/ResourceStreamerImpl.java | 79 +++-
.../tapestry5/integration/app1/AssetTests.java | 12 +++
.../app1/pages/nested/AssetDemo.java| 19 +
.../integration/app1/pages/nested/AssetDemo.tml | 6 +-
.../app1/pages/nested/AssetWithWrongChecksum.js | 1 +
5 files changed, 113 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2e11d5dd/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java
index d5e6024..ce3d1ae 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ResourceStreamerImpl.java
@@ -12,13 +12,16 @@
package org.apache.tapestry5.internal.services;
+import org.apache.tapestry5.Asset;
import org.apache.tapestry5.SymbolConstants;
import org.apache.tapestry5.internal.InternalConstants;
import org.apache.tapestry5.internal.services.assets.ResourceChangeTracker;
import org.apache.tapestry5.ioc.IOOperation;
import org.apache.tapestry5.ioc.OperationTracker;
import org.apache.tapestry5.ioc.Resource;
+import org.apache.tapestry5.ioc.annotations.InjectService;
import org.apache.tapestry5.ioc.annotations.Symbol;
+import org.apache.tapestry5.services.AssetFactory;
import org.apache.tapestry5.services.Request;
import org.apache.tapestry5.services.Response;
import org.apache.tapestry5.services.assets.*;
@@ -47,6 +50,10 @@ public class ResourceStreamerImpl implements ResourceStreamer
private final ResourceChangeTracker resourceChangeTracker;
private final String omitExpirationCacheControlHeader;
+
+private final AssetFactory classpathAssetFactory;
+
+private final AssetFactory contextAssetFactory;
public ResourceStreamerImpl(Request request,
@@ -62,7 +69,13 @@ public class ResourceStreamerImpl implements ResourceStreamer
ResourceChangeTracker resourceChangeTracker,
@Symbol(SymbolConstants.OMIT_EXPIRATION_CACHE_CONTROL_HEADER)
-String omitExpirationCacheControlHeader)
+String omitExpirationCacheControlHeader,
+
+@InjectService("ClasspathAssetFactory")
+AssetFactory classpathAssetFactory,
+
+@InjectService("ContextAssetFactory")
+AssetFactory contextAssetFactory)
{
this.request = request;
this.response = response;
@@ -72,6 +85,9 @@ public class ResourceStreamerImpl implements ResourceStreamer
this.productionMode = productionMode;
this.resourceChangeTracker = resourceChangeTracker;
this.omitExpirationCacheControlHeader =
omitExpirationCacheControlHeader;
+
+this.classpathAssetFactory = classpathAssetFactory;
+this.contextAssetFactory = contextAssetFactory;
}
public boolean streamResource(final Resource resource, final String
providedChecksum, final Set options) throws IOException
@@ -87,7 +103,7 @@ public class ResourceStreamerImpl implements ResourceStreamer
final boolean compress = providedChecksum.startsWith("z");
-return tracker.perform(String.format("Streaming %s%s", resource,
compress ? " (compressed)" : ""), new IOOperation()
+return tracker.perform("Streaming " + resource + (compress ? "
(compressed)" : ""), new IOOperation()
{
public Boolean perform() throws IOException
{
@@ -97,13 +113,18 @@ public class ResourceStreamerImpl implements
ResourceStreamer
StreamableResource streamable =
streamableResourceSource.getStreamableResource(resource, processing,
resourceChangeTracker);
-
