[jira] [Commented] (TAP5-2428) Move Java sources from tapestry-core src/test/groovy to src/test/java
[ https://issues.apache.org/jira/browse/TAP5-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258487#comment-14258487 ] Hudson commented on TAP5-2428: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1362 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1362/]) Revert "TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java" (hlship: rev d165b9c06250fac29d643636bcac4d1a931e5619) * tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java * tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java * tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java (hlship: rev 2cc30a6bd2efb2382b57cedd32e9eadcc000e274) * tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java * tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java * tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java * tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.groovy > Move Java sources from tapestry-core src/test/groovy to src/test/java > - > > Key: TAP5-2428 > URL: https://issues.apache.org/jira/browse/TAP5-2428 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Felix Scheffer >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.4 > > > /tapestry-core/src/test/groovy contains LogoSubclass.java which causes errors > in Eclipse (when the groovy extension is not installed). I think it's bad > practice to place java files in the groovy package. > In the same package, there's also PageTesterTest.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TAP5-2428) Move Java sources from tapestry-core src/test/groovy to src/test/java
[ https://issues.apache.org/jira/browse/TAP5-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258463#comment-14258463 ] ASF subversion and git services commented on TAP5-2428: --- Commit 2cc30a6bd2efb2382b57cedd32e9eadcc000e274 in tapestry-5's branch refs/heads/master from [~hlship] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=2cc30a6 ] TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java > Move Java sources from tapestry-core src/test/groovy to src/test/java > - > > Key: TAP5-2428 > URL: https://issues.apache.org/jira/browse/TAP5-2428 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Felix Scheffer >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.4 > > > /tapestry-core/src/test/groovy contains LogoSubclass.java which causes errors > in Eclipse (when the groovy extension is not installed). I think it's bad > practice to place java files in the groovy package. > In the same package, there's also PageTesterTest.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TAP5-2428) Move Java sources from tapestry-core src/test/groovy to src/test/java
[ https://issues.apache.org/jira/browse/TAP5-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258462#comment-14258462 ] ASF subversion and git services commented on TAP5-2428: --- Commit d165b9c06250fac29d643636bcac4d1a931e5619 in tapestry-5's branch refs/heads/master from [~hlship] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=d165b9c ] Revert "TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java" This reverts commit b62ddffd51179469505eedde97977c2731153623. > Move Java sources from tapestry-core src/test/groovy to src/test/java > - > > Key: TAP5-2428 > URL: https://issues.apache.org/jira/browse/TAP5-2428 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Felix Scheffer >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.4 > > > /tapestry-core/src/test/groovy contains LogoSubclass.java which causes errors > in Eclipse (when the groovy extension is not installed). I think it's bad > practice to place java files in the groovy package. > In the same package, there's also PageTesterTest.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/2] tapestry-5 git commit: Revert "TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java"
Repository: tapestry-5
Updated Branches:
refs/heads/master e5afaa0e1 -> 2cc30a6bd
Revert "TAP5-2428: Move Java sources from tapestry-core src/test/groovy to
src/test/java"
This reverts commit b62ddffd51179469505eedde97977c2731153623.
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d165b9c0
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d165b9c0
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d165b9c0
Branch: refs/heads/master
Commit: d165b9c06250fac29d643636bcac4d1a931e5619
Parents: e5afaa0
Author: Howard M. Lewis Ship
Authored: Wed Dec 24 10:40:07 2014 -0800
Committer: Howard M. Lewis Ship
Committed: Wed Dec 24 10:40:07 2014 -0800
--
.../integration/app1/pages/LogoSubclass.java| 7 +
.../tapestry5/pagetester/PageTesterTest.java| 31
.../integration/app1/pages/LogoSubclass.java| 7 -
.../tapestry5/pagetester/PageTesterTest.java| 29 --
4 files changed, 38 insertions(+), 36 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d165b9c0/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
new file mode 100644
index 000..96e3345
--- /dev/null
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
@@ -0,0 +1,7 @@
+package org.apache.tapestry5.integration.app1.pages;
+
+import org.apache.tapestry5.integration.locallib.alpha.pages.Logo;
+
+public class LogoSubclass extends Logo
+{
+}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d165b9c0/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
b/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
new file mode 100644
index 000..68bcda7
--- /dev/null
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
@@ -0,0 +1,31 @@
+// Copyright 2012 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package org.apache.tapestry5.pagetester;
+
+import org.apache.tapestry5.test.PageTester;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+public class PageTesterTest extends Assert
+{
+
+@Test
+public void setupRequestFromURI_accepts_query_strings()
+{
+PageTester pageTester = new PageTester("org.example.app1", "app1");
+
+pageTester.setupRequestFromURI("/foo/somePage?param=value");
+}
+
+}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d165b9c0/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
deleted file mode 100644
index 96e3345..000
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
+++ /dev/null
@@ -1,7 +0,0 @@
-package org.apache.tapestry5.integration.app1.pages;
-
-import org.apache.tapestry5.integration.locallib.alpha.pages.Logo;
-
-public class LogoSubclass extends Logo
-{
-}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d165b9c0/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
b/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
deleted file mode 100644
index c580c91..000
---
a/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
+++ /dev/null
@@ -1,29 +0,0 @@
-// Licensed under the Apache License, Versio
[2/2] tapestry-5 git commit: TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java
TAP5-2428: Move Java sources from tapestry-core src/test/groovy to src/test/java
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2cc30a6b
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2cc30a6b
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2cc30a6b
Branch: refs/heads/master
Commit: 2cc30a6bd2efb2382b57cedd32e9eadcc000e274
Parents: d165b9c
Author: Howard M. Lewis Ship
Authored: Wed Dec 24 11:18:36 2014 -0800
Committer: Howard M. Lewis Ship
Committed: Wed Dec 24 11:18:36 2014 -0800
--
.../integration/app1/pages/LogoSubclass.groovy | 7 +
.../integration/app1/pages/LogoSubclass.java| 7 -
.../tapestry5/pagetester/PageTesterTest.java| 31
.../tapestry5/pagetester/PageTesterTest.java| 31
4 files changed, 38 insertions(+), 38 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2cc30a6b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.groovy
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.groovy
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.groovy
new file mode 100644
index 000..1ac22a7
--- /dev/null
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.groovy
@@ -0,0 +1,7 @@
+package org.apache.tapestry5.integration.app1.pages;
+
+import org.apache.tapestry5.integration.locallib.alpha.pages.Logo;
+
+class LogoSubclass extends Logo
+{
+}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2cc30a6b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
deleted file mode 100644
index 96e3345..000
---
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/pages/LogoSubclass.java
+++ /dev/null
@@ -1,7 +0,0 @@
-package org.apache.tapestry5.integration.app1.pages;
-
-import org.apache.tapestry5.integration.locallib.alpha.pages.Logo;
-
-public class LogoSubclass extends Logo
-{
-}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2cc30a6b/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
b/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
deleted file mode 100644
index 68bcda7..000
---
a/tapestry-core/src/test/groovy/org/apache/tapestry5/pagetester/PageTesterTest.java
+++ /dev/null
@@ -1,31 +0,0 @@
-// Copyright 2012 The Apache Software Foundation
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-package org.apache.tapestry5.pagetester;
-
-import org.apache.tapestry5.test.PageTester;
-import org.testng.Assert;
-import org.testng.annotations.Test;
-
-public class PageTesterTest extends Assert
-{
-
-@Test
-public void setupRequestFromURI_accepts_query_strings()
-{
-PageTester pageTester = new PageTester("org.example.app1", "app1");
-
-pageTester.setupRequestFromURI("/foo/somePage?param=value");
-}
-
-}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2cc30a6b/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
b/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
new file mode 100644
index 000..68bcda7
--- /dev/null
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/pagetester/PageTesterTest.java
@@ -0,0 +1,31 @@
+// Copyright 2012 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+/
[jira] [Commented] (TAP5-1854) AjaxComponentEventRequestHandler doesn't handle the case where a response has already be returned, and may append an empty JSON Object to the response
[
https://issues.apache.org/jira/browse/TAP5-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258329#comment-14258329
]
khalil haddad commented on TAP5-1854:
-
Hello,
I think this issue has to be reopened. I'm running on this configuration :
- Tapestry 5.3.7
- Tapestry5-jQuery 3.3.7
- WAS 8.5
- IBM J9 VM (build 2.6, JRE 1.7.0 AIX ppc64-64 Compressed References
20141013_217026)
When I try to access to a page which includes a jQuery datatable, I have
systematically the same error :
"DataTables warning: JSON data from server could not be parsed. This is caused
by a JSON formatting error."
If I inspect the JSON data received from the server, I notice that an empty
JSON {} is added at the end of the data like in the issue #TAPESTRY-2619 .
The same application works fine on Tomcat 7.
> AjaxComponentEventRequestHandler doesn't handle the case where a response has
> already be returned, and may append an empty JSON Object to the response
> --
>
> Key: TAP5-1854
> URL: https://issues.apache.org/jira/browse/TAP5-1854
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Environment: WebSphere on linux, and Jetty on osx
>Reporter: Kai Lilleby
>Assignee: Howard M. Lewis Ship
>Priority: Blocker
> Fix For: 5.3.3, 5.4
>
>
> In committ 1155178 the removal of "if (resultProcessorInvoked.get()) return"
> seems to have reintroduced an old issue (#TAPESTRY-2619).
> When running on a Servlet engine that does not honor
> HttpResponse.getOutputStream().close() - i.e. subsequent writing to the
> responses outputstream will be written to the client - which is true for
> WebSphere but not for Jetty, the final line in
> AjaxComponentEventRequestHandler will write an new jsonobject to the
> response, resulting in an invalid json structure.
> My guess would be that the following block of code:
> -
> if ((!resultProcessorInvoked.get()) &&
> queue.isPartialRenderInitialized())
> {
> partialRenderer.renderPartialPageMarkup();
> return;
> }
> // Send an empty JSON reply if no value was returned from the
> component event handler method.
> // This is the typical behavior when an Ajax component event handler
> returns null.
> JSONObject reply = new JSONObject();
> resultProcessor.processResultValue(reply);
> }
> ---
> should be replaced with:
> ---
>if ((!resultProcessorInvoked.get()) &&
> queue.isPartialRenderInitialized())
> {
> partialRenderer.renderPartialPageMarkup();
> return;
> }
>// If the result processor was passed a value, then it will already
> have rendered, and there is nothing more to do.
>if (resultProcessorInvoked.get()) return;
>
> // Send an empty JSON reply if no value was returned from the
> component event handler method.
> // This is the typical behavior when an Ajax component event handler
> returns null.
> JSONObject reply = new JSONObject();
> resultProcessor.processResultValue(reply);
> }
> --
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
