[jira] [Updated] (TAP5-2391) Field-specific error not shown when AJAX used
[ https://issues.apache.org/jira/browse/TAP5-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoff Callender updated TAP5-2391: -- Description: Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in 5.4-beta-6. When an error is recorded with Form.recordError(Field field, String errorMessage) or ValidationTracker.recordError(Field field, String errorMessage) it normally is shown in the UI by decorating the field in error and displaying the errorMessage below it. In 5.4-beta-6 and every release ever before that, that was the behaviour regardless of whether the request is non-AJAX or AJAX. In 5.4-beta-22, the behaviour changes when the request is AJAX: the field does not display an error. That is, the field is *not* decorated and the errorMessage is *not* shown with it. If your Errors component has globalOnly="true", which is the norm these days, then you won't even see the error message there! If you set globalOnly="false" then the message *is* shown, but who would want to set globalOnly="false"??? Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an extra entry in the inits, like this: ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First Name must not be Acme."] was: Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in 5.4-beta-6. When an error is recorded with Form.recordError(Field field, String errorMessage) or ValidationTracker.recordError(Field field, String errorMessage) it normally is shown in the UI by decorating the field in error and displaying the errorMessage below it. In 5.4-beta-6, that was the behaviour even when the request was AJAX. In 5.4-beta-22, the behaviour changes if the request is AJAX: the field is *not* decorated and the errorMessage is *not* shown with it. If your Errors component has globalOnly="true", which is the norm these days, then you won't see any error message at all! If you set globalOnly="false" then the message *is* shown, but who would want to set globalOnly="false"??? Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an extra entry in the inits, like this: ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First Name must not be Acme."] > Field-specific error not shown when AJAX used > - > > Key: TAP5-2391 > URL: https://issues.apache.org/jira/browse/TAP5-2391 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Geoff Callender >Assignee: Howard M. Lewis Ship >Priority: Critical > > Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in > 5.4-beta-6. > When an error is recorded with Form.recordError(Field field, String > errorMessage) or ValidationTracker.recordError(Field field, String > errorMessage) it normally is shown in the UI by decorating the field in error > and displaying the errorMessage below it. > In 5.4-beta-6 and every release ever before that, that was the behaviour > regardless of whether the request is non-AJAX or AJAX. > In 5.4-beta-22, the behaviour changes when the request is AJAX: the field > does not display an error. That is, the field is *not* decorated and the > errorMessage is *not* shown with it. If your Errors component has > globalOnly="true", which is the norm these days, then you won't even see the > error message there! If you set globalOnly="false" then the message *is* > shown, but who would want to set globalOnly="false"??? > Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an > extra entry in the inits, like this: > ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First > Name must not be Acme."] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TAP5-2391) Field-specific error not shown when AJAX used
[ https://issues.apache.org/jira/browse/TAP5-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoff Callender updated TAP5-2391: -- Description: Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in 5.4-beta-6. When an error is recorded with Form.recordError(Field field, String errorMessage) or ValidationTracker.recordError(Field field, String errorMessage) it normally is shown in the UI by decorating the field in error and displaying the errorMessage below it. In 5.4-beta-6, that was the behaviour even when the request was AJAX. In 5.4-beta-22, the behaviour changes if the request is AJAX: the field is *not* decorated and the errorMessage is *not* shown with it. If your Errors component has globalOnly="true", which is the norm these days, then you won't see any error message at all! If you set globalOnly="false" then the message *is* shown, but who would want to set globalOnly="false"??? Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an extra entry in the inits, like this: ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First Name must not be Acme."] was: Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in 5.4-beta-6. When an error is recorded with Form.recordError(Field field, String errorMessage) or ValidationTracker.recordError(Field field, String errorMessage) it normally is shown in the UI by decorating the field in error and displaying the errorMessage below it. However, when the request is AJAX, the field is no longer being decorated and the errorMessage isn't shown with it. I have verified that the client knows about the error, because will show it. Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 has an extra entry in the inits, like this: ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First Name must not be Acme."] > Field-specific error not shown when AJAX used > - > > Key: TAP5-2391 > URL: https://issues.apache.org/jira/browse/TAP5-2391 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Geoff Callender >Assignee: Howard M. Lewis Ship >Priority: Critical > > Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in > 5.4-beta-6. > When an error is recorded with Form.recordError(Field field, String > errorMessage) or ValidationTracker.recordError(Field field, String > errorMessage) it normally is shown in the UI by decorating the field in error > and displaying the errorMessage below it. > In 5.4-beta-6, that was the behaviour even when the request was AJAX. > In 5.4-beta-22, the behaviour changes if the request is AJAX: the field is > *not* decorated and the errorMessage is *not* shown with it. If your Errors > component has globalOnly="true", which is the norm these days, then you won't > see any error message at all! If you set globalOnly="false" then the message > *is* shown, but who would want to set globalOnly="false"??? > Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an > extra entry in the inits, like this: > ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First > Name must not be Acme."] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
tapestry-5 git commit: Advance version number to 5.4-beta-26
Repository: tapestry-5
Updated Branches:
refs/heads/master 7a9b2e81d -> 030899832
Advance version number to 5.4-beta-26
Really feeling close to a RC!
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/03089983
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/03089983
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/03089983
Branch: refs/heads/master
Commit: 030899832df14c5d526d494b92ea347138f7596e
Parents: 7a9b2e8
Author: Howard M. Lewis Ship
Authored: Tue Dec 30 17:29:58 2014 -0800
Committer: Howard M. Lewis Ship
Committed: Tue Dec 30 17:29:58 2014 -0800
--
build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/03089983/build.gradle
--
diff --git a/build.gradle b/build.gradle
index 1d97274..e878569 100755
--- a/build.gradle
+++ b/build.gradle
@@ -36,7 +36,7 @@ project.version = tapestryVersion()
def tapestryVersion() {
def major = "5.4"
-def minor = "-beta-25"
+def minor = "-beta-26"
// When building on the CI server, make sure -SNAPSHOT is appended, as it
is a nightly build.
// When building normally, or for a release, no suffix is desired.
Git Push Summary
Repository: tapestry-5 Updated Tags: refs/tags/5.4-beta-25 [created] 7a9b2e81d
[jira] [Commented] (TAP5-2435) Tapestry's internal pages should always use the packaged version of bootstrap, not any applicaton override
[ https://issues.apache.org/jira/browse/TAP5-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261759#comment-14261759 ] ASF subversion and git services commented on TAP5-2435: --- Commit d025536f5af206c10744c884fde41b87ae37fc7f in tapestry-5's branch refs/heads/master from [~hlship] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=d025536 ] Allow the component's render phase methods to execute before the advice provided by the ImportWorker This is the last piece necessary for TAP5-2435 (the rest was implemented previously). > Tapestry's internal pages should always use the packaged version of > bootstrap, not any applicaton override > -- > > Key: TAP5-2435 > URL: https://issues.apache.org/jira/browse/TAP5-2435 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Howard M. Lewis Ship >Assignee: Howard M. Lewis Ship > Fix For: 5.4 > > > When Tapestry renders the T5Dashboard, or the ExceptionReport pages (internal > pages) it should not include the core stack automatically. Instead, these > pages should render with the internal stack and not the core stack. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (TAP5-2435) Tapestry's internal pages should always use the packaged version of bootstrap, not any applicaton override
[ https://issues.apache.org/jira/browse/TAP5-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-2435. -- Resolution: Fixed Fix Version/s: 5.4 > Tapestry's internal pages should always use the packaged version of > bootstrap, not any applicaton override > -- > > Key: TAP5-2435 > URL: https://issues.apache.org/jira/browse/TAP5-2435 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Howard M. Lewis Ship >Assignee: Howard M. Lewis Ship > Fix For: 5.4 > > > When Tapestry renders the T5Dashboard, or the ExceptionReport pages (internal > pages) it should not include the core stack automatically. Instead, these > pages should render with the internal stack and not the core stack. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/2] tapestry-5 git commit: Improve the Javadoc
Improve the Javadoc
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/7a9b2e81
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/7a9b2e81
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/7a9b2e81
Branch: refs/heads/master
Commit: 7a9b2e81d8984e8d538bd2eb4ed7c398c3176e7d
Parents: d025536
Author: Howard M. Lewis Ship
Authored: Tue Dec 30 17:11:29 2014 -0800
Committer: Howard M. Lewis Ship
Committed: Tue Dec 30 17:11:29 2014 -0800
--
.../java/org/apache/tapestry5/modules/TapestryModule.java| 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/7a9b2e81/tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java
b/tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java
index 8a72a4d..d215095 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java
@@ -99,7 +99,6 @@ import org.slf4j.Logger;
import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-
import java.io.IOException;
import java.io.InputStream;
import java.lang.annotation.Annotation;
@@ -1706,8 +1705,13 @@ public final class TapestryModule
* PageNameMeta (since 5.4)
* Renders a {@code } tag describing the active page name
(development mode only)
* ImportCoreStack (since 5.4)
- * Imports to "core" stack (necessary to get the Bootstrap CSS, if
nothing else).
+ * Imports the "core" stack (necessary to get the Bootstrap CSS, if
nothing else).
*
+ *
+ * @see org.apache.tapestry5.SymbolConstants#OMIT_GENERATOR_META
+ * @see org.apache.tapestry5.SymbolConstants#PRODUCTION_MODE
+ * @see org.apache.tapestry5.SymbolConstants#INCLUDE_CORE_STACK
+ * @see org.apache.tapestry5.SymbolConstants#ENABLE_PAGELOADING_MASK
*/
public void
contributeMarkupRenderer(OrderedConfiguration
configuration,
[1/2] tapestry-5 git commit: Allow the component's render phase methods to execute before the advice provided by the ImportWorker
Repository: tapestry-5
Updated Branches:
refs/heads/master 687abdf28 -> 7a9b2e81d
Allow the component's render phase methods to execute before the advice
provided by the ImportWorker
This is the last piece necessary for TAP5-2435 (the rest was implemented
previously).
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d025536f
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d025536f
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d025536f
Branch: refs/heads/master
Commit: d025536f5af206c10744c884fde41b87ae37fc7f
Parents: 687abdf
Author: Howard M. Lewis Ship
Authored: Tue Dec 30 17:11:16 2014 -0800
Committer: Howard M. Lewis Ship
Committed: Tue Dec 30 17:11:16 2014 -0800
--
.../org/apache/tapestry5/internal/transform/ImportWorker.java| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d025536f/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ImportWorker.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ImportWorker.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ImportWorker.java
index 17bddc4..a3801a6 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ImportWorker.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ImportWorker.java
@@ -268,11 +268,11 @@ public class ImportWorker implements
ComponentClassTransformWorker2
{
public void advise(MethodInvocation invocation)
{
+invocation.proceed();
+
Asset[] assets = (Asset[])
access.get(invocation.getInstance());
F.flow(assets).each(operation);
-
-invocation.proceed();
}
});
}
[jira] [Commented] (TAP5-2435) Tapestry's internal pages should always use the packaged version of bootstrap, not any applicaton override
[ https://issues.apache.org/jira/browse/TAP5-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261705#comment-14261705 ] Howard M. Lewis Ship commented on TAP5-2435: Much of the support for this is already present ... but the timing isn't working. AbstractInternalPage.setupRender() is getting invoked after the @Import attached to ExceptionReport has already forced the core stack into the page. > Tapestry's internal pages should always use the packaged version of > bootstrap, not any applicaton override > -- > > Key: TAP5-2435 > URL: https://issues.apache.org/jira/browse/TAP5-2435 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Howard M. Lewis Ship >Assignee: Howard M. Lewis Ship > > When Tapestry renders the T5Dashboard, or the ExceptionReport pages (internal > pages) it should not include the core stack automatically. Instead, these > pages should render with the internal stack and not the core stack. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TAP5-2435) Tapestry's internal pages should always use the packaged version of bootstrap, not any applicaton override
[ https://issues.apache.org/jira/browse/TAP5-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-2435: -- Assignee: Howard M. Lewis Ship > Tapestry's internal pages should always use the packaged version of > bootstrap, not any applicaton override > -- > > Key: TAP5-2435 > URL: https://issues.apache.org/jira/browse/TAP5-2435 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Howard M. Lewis Ship >Assignee: Howard M. Lewis Ship > > When Tapestry renders the T5Dashboard, or the ExceptionReport pages (internal > pages) it should not include the core stack automatically. Instead, these > pages should render with the internal stack and not the core stack. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TAP5-2435) Tapestry's internal pages should always use the packaged version of bootstrap, not any applicaton override
Howard M. Lewis Ship created TAP5-2435: -- Summary: Tapestry's internal pages should always use the packaged version of bootstrap, not any applicaton override Key: TAP5-2435 URL: https://issues.apache.org/jira/browse/TAP5-2435 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.4 Reporter: Howard M. Lewis Ship When Tapestry renders the T5Dashboard, or the ExceptionReport pages (internal pages) it should not include the core stack automatically. Instead, these pages should render with the internal stack and not the core stack. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
svn commit: r934458 - in /websites/production/tapestry/content: cache/main.pageCache injection-in-detail.html
Author: buildbot
Date: Tue Dec 30 19:20:20 2014
New Revision: 934458
Log:
Production update by buildbot for tapestry
Modified:
websites/production/tapestry/content/cache/main.pageCache
websites/production/tapestry/content/injection-in-detail.html
Modified: websites/production/tapestry/content/cache/main.pageCache
==
Binary files - no diff available.
Modified: websites/production/tapestry/content/injection-in-detail.html
==
--- websites/production/tapestry/content/injection-in-detail.html (original)
+++ websites/production/tapestry/content/injection-in-detail.html Tue Dec 30
19:20:20 2014
@@ -74,11 +74,7 @@ table.ScrollbarTable td.ScrollbarParent
table.ScrollbarTable td.ScrollbarNextName {text-align: right;border: none;}
table.ScrollbarTable td.ScrollbarNextIcon {text-align: center;width:
16px;border: none;}
-/*]]>*/https://cwiki.apache.org/confluence/images/icons/back_16.gif"; width="16"
height="16">StrategyBuilder
Service https://cwiki.apache.org/confluence/images/icons/up_16.gif"; width="8"
height="8">IoC Object Providershttps://cwiki.apache.org/confluence/images/icons/forwd_16.gif";
width="16" height="16">
-
-Injection in Detail
-
-
+/*]]>*/https://cwiki.apache.org/confluence/images/icons/back_16.gif"; width="16"
height="16">StrategyBuilder
Service https://cwiki.apache.org/confluence/images/icons/up_16.gif"; width="8"
height="8">IoC Object Providershttps://cwiki.apache.org/confluence/images/icons/forwd_16.gif";
width="16" height="16">Injection in Detail
Related Articles
@@ -94,7 +90,7 @@ table.ScrollbarTable td.ScrollbarNextIco
Page:
-Injection in Detail
+Injection FAQ
@@ -103,177 +99,37 @@ table.ScrollbarTable td.ScrollbarNextIco
Page:
-Injection FAQ
+Injection in Detail
-
-
-Injection in Tapestry IoC can be a complicated subject for a number of
reasons:
-
-Injection can occur in many places: on fields, and on parameters to
methods and constructors of certain objects.Parts of Injection are
themselves defined in terms of Tapestry IoC services, many of which are
extensible.
-
-
-Despite this, injection generally Just Works: most of the time,
you want Tapestry to inject a service, and only a single service implements the
service interface.
-
-This document discusses what to do when you hit a case that doesn't Just
Work, or when you want to extend the injection logic in some way.
-
-Some aspects of this discussion reflect Tapestry IoC used within a Tapestry
web application: the tapestry-core module makes some extensions to
injection.
-
-Injection Triggers
-
-Injection is triggered in a number of ways:
-
-A field in a component class, autobuilt object, or service
implementation class the @http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/ioc/annotations/Inject.html";>Inject
annotation.A method parameter to a service builder method, a
decorator method, or a contribute method (in a Tapestry IoC module
class).A constructor parameter to an autobuilt object, or a service
implementation class.Any of the above with an @http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/ioc/annotations/InjectService.html";>InjectService
annotation.
-
-
-Injection also covers a related matter: providing special resources to a
service or component. For a service, the service's id (as a string) or
extensible configuration (as a Collection, List or Map) may be provided. For a
component, the component's id, locale, message catalog, or component resources
may be provided.
-
-Standard Injection
Processing
-
-This section describes standard injection, which applies at the IoC layer:
autobuild objects and service implementations. The steps for injection into
Tapestry components are slightly different and are covered later.
-
-So a the point of injection, Tapestry has identified a field or parameter
that should be injected. At this point, Tapestry knows the following:
-
-The field name (if field injection). The parameter name is not
available.The field or parameter type, as a Java class. In many cases,
this will be enough to identify what object shall be injected.Any
additional annotations on the field or parameter.
-
-
-Tapestry proceeds with this information.
-
-Check for @InjectService
-
-Tapestry checks first for the @InjectService annotation. The value of this
annotation is the service id to inject. When @InjectService is present at the
point of injection, that process is done, though it can fail if the service id
indicated does not ex
tapestry-5 git commit: Change the deployment script to work with Apache svnpubsub system
Repository: tapestry-5
Updated Branches:
refs/heads/master f88ed9a30 -> 687abdf28
Change the deployment script to work with Apache svnpubsub system
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/687abdf2
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/687abdf2
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/687abdf2
Branch: refs/heads/master
Commit: 687abdf28c5422c2ec130f4422259f685673d868
Parents: f88ed9a
Author: Howard M. Lewis Ship
Authored: Tue Dec 30 09:40:01 2014 -0800
Committer: Howard M. Lewis Ship
Committed: Tue Dec 30 10:04:58 2014 -0800
--
build.gradle | 42 ++
1 file changed, 26 insertions(+), 16 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/687abdf2/build.gradle
--
diff --git a/build.gradle b/build.gradle
index 20f00f4..1d97274 100755
--- a/build.gradle
+++ b/build.gradle
@@ -62,10 +62,15 @@ project.ext {
deployUsernameProperty = isSnapshot() ? "snapshotDeployUserName" :
"apacheDeployUserName"
deployPasswordProperty = isSnapshot() ? "snapshotDeployPassword" :
"apacheDeployPassword"
-canDeploy = [deployUsernameProperty, deployPasswordProperty].every {
project.hasProperty(it) }
+canDeploy = [deployUsernameProperty, deployPasswordProperty,
"apacheArchivesFolder"].every { project.hasProperty(it) }
+// These are all deferred inside closures, to allow people without the
necessary values in their
+// gradle.properties to build locally, just not deploy. getProperty()
throws an exception if the property
+// is not present.
deployUsername = { getProperty(deployUsernameProperty) }
deployPassword = { getProperty(deployPasswordProperty) }
+
+archiveDeployFolder = { getProperty("apacheArchivesFolder") }
}
sonar {
@@ -512,29 +517,34 @@ if (canDeploy) {
}
}
-task uploadArtifacts(type: Scp) {
-group "Release artifact"
-description "Uploads top-level artifacts to people.apache.org, along
with MD5 checksums and PGP signatures (if signing is enabled)"
+// This requires that you have the apacheArchivesFolder property
configured in your
+// ~/.gradle/gradle.properties. The folder should be a Subversion
workspace for
+// https://dist.apache.org/repos/dist/dev/tapestry
+// after the build, you must manually add the new files to the workspace
(using "svn add")
+// then commit ("svn commit").
+
+// The files will be visible in
https://dist.apache.org/repos/dist/dev/tapestry/, allowing
+// committers to download and verify them.
-source files(generateMD5Checksums,
configurations.uploads.allArtifacts.files)
+// After a successful release vote, the files can be moved to a second
Subversion workspace
+// for https://dist.apache.org/repos/dist/release/tapestry. Adding the
files and committing
+// there will publish them to http://www.apache.org/dist/tapestry ... and
from there
+// to all Apache mirrors (after about a 24 hour delay).
-host "people.apache.org"
-userName deployUsername()
-password deployPassword()
+task copyArchives(type: Copy) {
+group "Release artifact"
+description "Copies build archives (source, bin, docs) to a configured
deployment folder, along with MD5 checksums and PGP signatures (if signing is
enabled)"
-// The destination folder at people.apache.org needs to already exist.
-destination "public_html/tapestry-releases"
+destinationDir file(archiveDeployFolder())
-doFirst {
-logger.info "Uploading the following files to people.apache.org
(as user '${userName}'):"
-source.files.each { logger.info " $it" }
-}
+from generateMD5Checksums
+from configurations.uploads.allArtifacts.files
}
task generateRelease {
-dependsOn "quickstart:clean", continuousIntegration,
subprojects.uploadPublished, uploadArtifacts
+dependsOn "quickstart:clean", continuousIntegration,
subprojects.uploadPublished, copyArchives
group "Release artifact"
-description "Generates and uploads a final release to Apache Nexus"
+description "Generates and uploads a final release to Apache Nexus and
copies archives for deployment"
}
}
[jira] [Created] (TAP5-2434) Add ability to set Autocomplete features.
George Christman created TAP5-2434: -- Summary: Add ability to set Autocomplete features. Key: TAP5-2434 URL: https://issues.apache.org/jira/browse/TAP5-2434 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: George Christman Typeahead.js suggestions has the ability to hightlight and provide hints to the user. Tapestry currently has no way to set these values. I'm suggesting we provide away to pass in json (future accommodations) or provide a couple parameters, hint / highlight to the autocomplete component. Example autocomplete.coffee $field.typeahead minLength: spec.minChars hint: spec.hint, highlight: spec.highlight dataset -- This message was sent by Atlassian JIRA (v6.3.4#6332)
