[jira] [Commented] (TAP5-2339) Ajax exception frame complains about "Function expected" in IE8

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482081#comment-14482081
 ] 

Howard M. Lewis Ship commented on TAP5-2339:


If it's not reproducible, I really want to close this.

> Ajax exception frame complains about "Function expected" in IE8
> ---
>
> Key: TAP5-2339
> URL: https://issues.apache.org/jira/browse/TAP5-2339
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Chris Poulsen
>  Labels: 54_release_prerequisite
> Attachments: 
> 0001-cause-require-is-not-a-function-error-on-index-page.patch
>
>
> It is the following code that fails: 
> require(["t5/core/pageinit"], function(pi) { 
> pi([], ["bootstrap/collapse","t5/core/zone"]); });
> Apparently "require" is the object it is instantiated to be (init config), 
> not the product of require.js being loaded.
> To reproduce create a T5.4 quickstart app and throw a RuntimeException in 
> void onAjax() (Index.java).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


svn commit: r946581 - in /websites/production/tapestry/content: cache/main.pageCache index.html

2015-04-06 Thread buildbot
Author: buildbot
Date: Mon Apr  6 22:19:34 2015
New Revision: 946581

Log:
Production update by buildbot for tapestry

Modified:
websites/production/tapestry/content/cache/main.pageCache
websites/production/tapestry/content/index.html

Modified: websites/production/tapestry/content/cache/main.pageCache
==
Binary files - no diff available.

Modified: websites/production/tapestry/content/index.html
==
--- websites/production/tapestry/content/index.html (original)
+++ websites/production/tapestry/content/index.html Mon Apr  6 22:19:34 2015
@@ -95,6 +95,7 @@ a.blogHeading {
 
 
 
+http://platform.twitter.com/widgets.js";>
 
  
 
@@ -129,41 +130,8 @@ a.blogHeading {
 Simple POJO classes, streamlined templates, live class reloading, 
state-of-the-art exception reporting, first-class Ajax support, and a big 
library of built-in components: Tapestry is designed from the ground up to give 
you great productivity.
 
 
-We think you will 
love Tapestry! Give us 20 minutes and follow our quickstart 
guide.
-.widget-link {
-min-width: 64px;
-background-image: 
url("/confluence/download/resources/com.atlassian.confluence.extra.widgetconnector:widget/widget.png");
-background-repeat: no-repeat;
-background-position: 50% 0;
-text-align: center;
-padding-top: 65px;
-text-decoration: none;
-color: #CCC;
-font-weight: bold;
-display: inline-block;
-font-size: .8em;
-text-decoration: none;
-}
-.widget-link:hover {
-color: #868686;
-}
-
-
-
-search.twitter.com
-
-
-#twtr-widget-1 .twtr-doc, #twtr-widget-1 .twtr-hd a, #twtr-widget-1 h3, 
#twtr-widget-1 h4, #twtr-widget-1 .twtr-popular {
-background-color: #569D2F !important;
-color: #FF !important;
-}
-
-#twtr-widget-1 .twtr-tweet a {
-color: #569D2F !important;
-}
-
-
-Latest news https://cwiki.apache.org/confluence/createrssfeed.action?types=blogpost&spaces=TAPESTRY&title=Apache+Tapestry+News+RSS+Feed&labelString%3D&sort=created&maxResults=10&timeSpan=12&confirm=Create&showContent=true&showDiff=false";>

+We think you will 
love Tapestry! Give us 20 minutes and follow our quickstart 
guide.https://twitter.com/hashtag/tapestry5"; 
data-widget-id="585196873335574528">#tapestry5 Tweets
+ Latest 
news https://cwiki.apache.org/confluence/createrssfeed.action?types=blogpost&spaces=TAPESTRY&title=Apache+Tapestry+News+RSS+Feed&labelString%3D&sort=created&maxResults=10&timeSpan=12&confirm=Create&showContent=true&showDiff=false";>

 
 
 




[2/2] tapestry-5 git commit: Advance version number for 5.4-beta-30

2015-04-06 Thread hlship
Advance version number for 5.4-beta-30


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/faaf0b02
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/faaf0b02
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/faaf0b02

Branch: refs/heads/master
Commit: faaf0b025aea1443ac5be9c0cdb17bf43c413ea3
Parents: 9aac4fa
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 14:43:39 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 14:43:39 2015 -0700

--
 build.gradle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/faaf0b02/build.gradle
--
diff --git a/build.gradle b/build.gradle
index e1cc52a..10f944a 100755
--- a/build.gradle
+++ b/build.gradle
@@ -34,7 +34,7 @@ project.version = tapestryVersion()
 def tapestryVersion() {
 
 def major = "5.4"
-def minor = "-beta-29"
+def minor = "-beta-30"
 
 // When building on the CI server, make sure -SNAPSHOT is appended, as it 
is a nightly build.
 // When building normally, or for a release, no suffix is desired.



[1/2] tapestry-5 git commit: Remove from JavaDoc

2015-04-06 Thread hlship
Repository: tapestry-5
Updated Branches:
  refs/heads/master ee6b0cade -> faaf0b025
Updated Tags:  refs/tags/5.4-beta-29 [created] 9aac4fa3b


Remove  from JavaDoc

Turns out, I had an IntelliJ setting providing these; turned off now.


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/9aac4fa3
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/9aac4fa3
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/9aac4fa3

Branch: refs/heads/master
Commit: 9aac4fa3b05df5a33611355b4a20e1c9a5d09851
Parents: ee6b0ca
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 14:24:27 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 14:24:27 2015 -0700

--
 .../java/org/apache/tapestry5/corelib/components/DateField.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/9aac4fa3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
index 94a9a1f..0e23ba2 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
@@ -36,11 +36,11 @@ import java.util.Locale;
 /**
  * A component used to collect a provided date from the user using a 
client-side JavaScript calendar. Non-JavaScript
  * clients can simply type into a text field.
- * 
+ *
  * One aspect here is that, because client-side JavaScript formatting and 
parsing is so limited, we (currently)
  * use Ajax to send the user's input to the server for parsing (before raising 
the popup) and formatting (after closing
  * the popup). Weird and inefficient, but easier than writing client-side 
JavaScript for that purpose.
- * 
+ *
  * Tapestry's DateField component is a wrapper around http://webfx.eae.net/dhtml/datepicker/datepicker.html";>WebFX 
DatePicker.
  *



[1/7] tapestry-5 git commit: Upgrade RequireJS to version 2.1.17

2015-04-06 Thread hlship
Repository: tapestry-5
Updated Branches:
  refs/heads/master dcd31d68a -> ee6b0cade


Upgrade RequireJS to version 2.1.17


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/b21c7b3a
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/b21c7b3a
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/b21c7b3a

Branch: refs/heads/master
Commit: b21c7b3a9a137b8f05008dbcf7a0948db933ed19
Parents: dcd31d6
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 13:13:27 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 13:13:27 2015 -0700

--
 .../src/main/resources/META-INF/assets/tapestry5/require.js| 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b21c7b3a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/require.js
--
diff --git 
a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/require.js 
b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/require.js
index bc43457..babfa9a 100644
--- a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/require.js
+++ b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/require.js
@@ -1,5 +1,5 @@
 /** vim: et:ts=4:sw=4:sts=4
- * @license RequireJS 2.1.16 Copyright (c) 2010-2015, The Dojo Foundation All 
Rights Reserved.
+ * @license RequireJS 2.1.17 Copyright (c) 2010-2015, The Dojo Foundation All 
Rights Reserved.
  * Available via the MIT or new BSD license.
  * see: http://github.com/jrburke/requirejs for details
  */
@@ -12,7 +12,7 @@ var requirejs, require, define;
 (function (global) {
 var req, s, head, baseElement, dataMain, src,
 interactiveScript, currentlyAddingScript, mainScript, subPath,
-version = '2.1.16',
+version = '2.1.17',
 commentRegExp = /(\/\*([\s\S]*?)\*\/|([^:]|^)\/\/(.*)$)/mg,
 cjsRequireRegExp = /[^.]\s*require\s*\(\s*["']([^'"\s]+)["']\s*\)/g,
 jsSuffixRegExp = /\.js$/,
@@ -244,7 +244,7 @@ var requirejs, require, define;
 // still work when converted to a path, even though
 // as an ID it is less than ideal. In larger point
 // releases, may be better to just kick out an error.
-if (i === 0 || (i == 1 && ary[2] === '..') || ary[i - 1] 
=== '..') {
+if (i === 0 || (i === 1 && ary[2] === '..') || ary[i - 1] 
=== '..') {
 continue;
 } else if (i > 0) {
 ary.splice(i - 1, 2);



[3/7] tapestry-5 git commit: Simplify & streamline the quickstart archetype

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.ttf
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.ttf
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.ttf
new file mode 100644
index 000..1413fc6
Binary files /dev/null and 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.ttf
 differ

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff
new file mode 100644
index 000..9e61285
Binary files /dev/null and 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff
 differ

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff2
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff2
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff2
new file mode 100644
index 000..64539b5
Binary files /dev/null and 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff2
 differ

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings-white.png
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings-white.png
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings-white.png
deleted file mode 100644
index 3bf6484..000
Binary files 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings-white.png
 and /dev/null differ

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings.png
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings.png
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings.png
deleted file mode 100644
index a996999..000
Binary files 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/img/glyphicons-halflings.png
 and /dev/null differ

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/affix.js
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/affix.js
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/affix.js
new file mode 100644
index 000..9819764
--- /dev/null
+++ 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/affix.js
@@ -0,0 +1,162 @@
+/* 
+ * Bootstrap: affix.js v3.3.4
+ * http://getbootstrap.com/javascript/#affix
+ * 
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
+ *  */
+
+
++function ($) {
+  'use strict';
+
+  // AFFIX CLASS DEFINITION
+  // ==
+
+  var Affix = function (element, options) {
+this.options = $.extend({}, Affix.DEFAULTS, options)
+
+this.$target = $(this.options.target)
+  .on('scroll.bs.affix.data-api', $.proxy(this.checkPosition, this))
+  .on('click.bs.affix.data-api',  $.proxy(this.checkPositionWithEventLoop, 
this))
+
+this.$element = $(element)
+this.affixed  = null
+this.unp

[7/7] tapestry-5 git commit: Simplify & streamline the quickstart archetype

2015-04-06 Thread hlship
Simplify & streamline the quickstart archetype

- Improve most formatting / identation
- The "mybootstrap" override is now based on Bootstrap 3.3.4
- Upgrade templates to 5.4 DTD


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/ee6b0cad
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/ee6b0cad
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/ee6b0cad

Branch: refs/heads/master
Commit: ee6b0cade768bee12f0f5793db40491acc8ae39d
Parents: b21c7b3
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 14:03:37 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 14:03:37 2015 -0700

--
 .../filtered/archetype-resources/build.gradle   |23 +-
 quickstart/filtered/archetype-resources/pom.xml |18 +-
 .../src/main/java/components/Layout.java|60 +-
 .../src/main/java/pages/About.java  |16 +-
 .../src/main/java/pages/Index.java  |78 +-
 .../src/main/java/pages/Login.java  |69 +-
 .../src/main/java/services/AppModule.java   |48 +-
 .../src/main/resources/components/Layout.tml|16 +-
 .../src/main/resources/pages/About.tml  | 2 +-
 .../src/main/resources/pages/Contact.tml| 2 +-
 .../src/main/resources/pages/Error404.tml   | 2 +-
 .../src/main/resources/pages/Index.tml  | 8 +-
 .../src/main/resources/pages/Login.tml  |10 +-
 .../mybootstrap/css/bootstrap-responsive.css|  1109 --
 .../webapp/mybootstrap/css/bootstrap-theme.css  |   476 +
 .../main/webapp/mybootstrap/css/bootstrap.css   | 11735 -
 .../fonts/glyphicons-halflings-regular.eot  |   Bin 0 -> 20127 bytes
 .../fonts/glyphicons-halflings-regular.svg  |   288 +
 .../fonts/glyphicons-halflings-regular.ttf  |   Bin 0 -> 45404 bytes
 .../fonts/glyphicons-halflings-regular.woff |   Bin 0 -> 23424 bytes
 .../fonts/glyphicons-halflings-regular.woff2|   Bin 0 -> 18028 bytes
 .../img/glyphicons-halflings-white.png  |   Bin 8777 -> 0 bytes
 .../mybootstrap/img/glyphicons-halflings.png|   Bin 12799 -> 0 bytes
 .../src/main/webapp/mybootstrap/js/affix.js |   162 +
 .../src/main/webapp/mybootstrap/js/alert.js |94 +
 .../src/main/webapp/mybootstrap/js/bootstrap.js |  2280 
 .../src/main/webapp/mybootstrap/js/button.js|   116 +
 .../src/main/webapp/mybootstrap/js/carousel.js  |   237 +
 .../src/main/webapp/mybootstrap/js/collapse.js  |   211 +
 .../src/main/webapp/mybootstrap/js/dropdown.js  |   161 +
 .../src/main/webapp/mybootstrap/js/modal.js |   339 +
 .../src/main/webapp/mybootstrap/js/popover.js   |   108 +
 .../src/main/webapp/mybootstrap/js/scrollspy.js |   172 +
 .../src/main/webapp/mybootstrap/js/tab.js   |   153 +
 .../src/main/webapp/mybootstrap/js/tooltip.js   |   476 +
 .../main/webapp/mybootstrap/js/transition.js|59 +
 36 files changed, 8946 insertions(+), 9582 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/filtered/archetype-resources/build.gradle
--
diff --git a/quickstart/filtered/archetype-resources/build.gradle 
b/quickstart/filtered/archetype-resources/build.gradle
index 3df6f01..44ff71a 100644
--- a/quickstart/filtered/archetype-resources/build.gradle
+++ b/quickstart/filtered/archetype-resources/build.gradle
@@ -20,19 +20,8 @@ repositories {
 name "JBoss"
 url "http://repository.jboss.org/nexus/content/groups/public/";
 }
-
-// For stable versions of the tapx libraries
-maven {
-name "HLS"
-url "http://howardlewisship.com/repository/";
-}
-
-// For non-stable versions of the tapx libraries
-maven {
-name "HLS Snapshots"
-url "http://howardlewisship.com/snapshot-repository/";
-}
-
+
+
 // For access to Apache Staging (Preview) packages
 maven {
 name "Apache Staging"
@@ -67,8 +56,10 @@ dependencies {
 // Uncomment this to add support for file uploads:
 // compile "org.apache.tapestry:tapestry-upload:@tapestryReleaseVersion@"
 
-// Uncomment this to add support resource minification and runtime 
compilation:
-// compile "org.apache.tapestry:tapestry-wro4j:@tapestryReleaseVersion@"
+// CoffeeScript & Less support, plus resource minification:
+compile 
"org.apache.tapestry:tapestry-webresources:@tapestryReleaseVersion@"
+
+test "org.apache.tapestry:tapestry-test:@tapestryReleaseVersion@"
 
 // Log implementation choose one:
 // Log4j 1.x
@@ -96,7 +87,7 @@ test {
 }
 
 task wrapper(type: Wrapper) {
-gradleVersion = '1.6'
+gradleVersion = '2.3'
 }
 
 // TODO: Configure execution mode for jettyRun task

http://git-wip-us.apache.org/

[5/7] tapestry-5 git commit: Simplify & streamline the quickstart archetype

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.eot
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.eot
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.eot
new file mode 100644
index 000..b93a495
Binary files /dev/null and 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.eot
 differ



[6/7] tapestry-5 git commit: Simplify & streamline the quickstart archetype

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/css/bootstrap.css
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/css/bootstrap.css
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/css/bootstrap.css
index 3ee1744..057ff46 100644
--- 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/css/bootstrap.css
+++ 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/css/bootstrap.css
@@ -1,47 +1,18 @@
-@import 
url("http://fonts.googleapis.com/css?family=Lato:400,700,900,400italic";);
-
 /*!
- * Bootstrap v2.3.2
- *
- * Copyright 2012 Twitter, Inc
- * Licensed under the Apache License v2.0
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Designed and built with all the love in the world @twitter by @mdo and @fat.
+ * Bootstrap v3.3.4 (http://getbootstrap.com)
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
  */
 
-.clearfix {
-*zoom: 1;
-}
-
-.clearfix:before,
-.clearfix:after {
-display: table;
-line-height: 0;
-content: "";
-}
-
-.clearfix:after {
-clear: both;
-}
-
-.hide-text {
-font: 0/0 a;
-color: transparent;
-text-shadow: none;
-background-color: transparent;
-border: 0;
+/*! normalize.css v3.0.2 | MIT License | git.io/normalize */
+html {
+  font-family: sans-serif;
+  -webkit-text-size-adjust: 100%;
+  -ms-text-size-adjust: 100%;
 }
-
-.input-block-level {
-display: block;
-width: 100%;
-min-height: 30px;
--webkit-box-sizing: border-box;
--moz-box-sizing: border-box;
-box-sizing: border-box;
+body {
+  margin: 0;
 }
-
 article,
 aside,
 details,
@@ -50,6802 +21,6568 @@ figure,
 footer,
 header,
 hgroup,
+main,
+menu,
 nav,
-section {
-display: block;
+section,
+summary {
+  display: block;
 }
-
 audio,
 canvas,
+progress,
 video {
-display: inline-block;
-*display: inline;
-*zoom: 1;
+  display: inline-block;
+  vertical-align: baseline;
 }
-
 audio:not([controls]) {
-display: none;
+  display: none;
+  height: 0;
 }
-
-html {
-font-size: 100%;
--webkit-text-size-adjust: 100%;
--ms-text-size-adjust: 100%;
+[hidden],
+template {
+  display: none;
 }
-
-a:focus {
-outline: thin dotted #333;
-outline: 5px auto -webkit-focus-ring-color;
-outline-offset: -2px;
+a {
+  background-color: transparent;
 }
-
-a:hover,
-a:active {
-outline: 0;
+a:active,
+a:hover {
+  outline: 0;
+}
+abbr[title] {
+  border-bottom: 1px dotted;
+}
+b,
+strong {
+  font-weight: bold;
+}
+dfn {
+  font-style: italic;
+}
+h1 {
+  margin: .67em 0;
+  font-size: 2em;
+}
+mark {
+  color: #000;
+  background: #ff0;
+}
+small {
+  font-size: 80%;
 }
-
 sub,
 sup {
-position: relative;
-font-size: 75%;
-line-height: 0;
-vertical-align: baseline;
+  position: relative;
+  font-size: 75%;
+  line-height: 0;
+  vertical-align: baseline;
 }
-
 sup {
-top: -0.5em;
+  top: -.5em;
 }
-
 sub {
-bottom: -0.25em;
+  bottom: -.25em;
 }
-
 img {
-width: auto\9;
-height: auto;
-max-width: 100%;
-vertical-align: middle;
-border: 0;
--ms-interpolation-mode: bicubic;
+  border: 0;
 }
-
-#map_canvas img,
-.google-maps img {
-max-width: none;
+svg:not(:root) {
+  overflow: hidden;
+}
+figure {
+  margin: 1em 40px;
+}
+hr {
+  height: 0;
+  -webkit-box-sizing: content-box;
+ -moz-box-sizing: content-box;
+  box-sizing: content-box;
+}
+pre {
+  overflow: auto;
+}
+code,
+kbd,
+pre,
+samp {
+  font-family: monospace, monospace;
+  font-size: 1em;
 }
-
 button,
 input,
+optgroup,
 select,
 textarea {
-margin: 0;
-font-size: 100%;
-vertical-align: middle;
+  margin: 0;
+  font: inherit;
+  color: inherit;
 }
-
-button,
-input {
-*overflow: visible;
-line-height: normal;
+button {
+  overflow: visible;
 }
-
-button::-moz-focus-inner,
-input::-moz-focus-inner {
-padding: 0;
-border: 0;
+button,
+select {
+  text-transform: none;
 }
-
 button,
 html input[type="button"],
 input[type="reset"],
 input[type="submit"] {
-cursor: pointer;
--webkit-appearance: button;
+  -webkit-appearance: button;
+  cursor: pointer;
 }
-
-label,
-select,
-button,
-input[type="button"],
-input[type="reset"],
-input[type="submit"],
-input[type="radio"],
-input[type="checkbox"] {
-cursor: pointer;
+button[disabled],
+html input[disabled] {
+  cursor: default;
+}
+button::-moz-focus-inner,
+input::-moz-focus-inner {
+  padding: 0;
+  border: 0;
+}
+input {
+  line-height: normal;
+}
+input[type="checkbox"],
+input[type="radio"] {
+  -webkit-box-sizing: border-box;
+ -moz-box-sizing: border-box;
+  box-sizing: border-box;
+  padding: 0;
+}
+input[type="number"]::-webkit-inner-spin-button,
+input[t

[4/7] tapestry-5 git commit: Simplify & streamline the quickstart archetype

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.svg
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.svg
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.svg
new file mode 100644
index 000..94fb549
--- /dev/null
+++ 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.svg
@@ -0,0 +1,288 @@
+
+http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"; >
+http://www.w3.org/2000/svg";>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

[2/7] tapestry-5 git commit: Simplify & streamline the quickstart archetype

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/ee6b0cad/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/collapse.js
--
diff --git 
a/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/collapse.js
 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/collapse.js
new file mode 100644
index 000..954513c
--- /dev/null
+++ 
b/quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/collapse.js
@@ -0,0 +1,211 @@
+/* 
+ * Bootstrap: collapse.js v3.3.4
+ * http://getbootstrap.com/javascript/#collapse
+ * 
+ * Copyright 2011-2015 Twitter, Inc.
+ * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
+ *  */
+
+
++function ($) {
+  'use strict';
+
+  // COLLAPSE PUBLIC CLASS DEFINITION
+  // 
+
+  var Collapse = function (element, options) {
+this.$element  = $(element)
+this.options   = $.extend({}, Collapse.DEFAULTS, options)
+this.$trigger  = $('[data-toggle="collapse"][href="#' + element.id + 
'"],' +
+   '[data-toggle="collapse"][data-target="#' + 
element.id + '"]')
+this.transitioning = null
+
+if (this.options.parent) {
+  this.$parent = this.getParent()
+} else {
+  this.addAriaAndCollapsedClass(this.$element, this.$trigger)
+}
+
+if (this.options.toggle) this.toggle()
+  }
+
+  Collapse.VERSION  = '3.3.4'
+
+  Collapse.TRANSITION_DURATION = 350
+
+  Collapse.DEFAULTS = {
+toggle: true
+  }
+
+  Collapse.prototype.dimension = function () {
+var hasWidth = this.$element.hasClass('width')
+return hasWidth ? 'width' : 'height'
+  }
+
+  Collapse.prototype.show = function () {
+if (this.transitioning || this.$element.hasClass('in')) return
+
+var activesData
+var actives = this.$parent && 
this.$parent.children('.panel').children('.in, .collapsing')
+
+if (actives && actives.length) {
+  activesData = actives.data('bs.collapse')
+  if (activesData && activesData.transitioning) return
+}
+
+var startEvent = $.Event('show.bs.collapse')
+this.$element.trigger(startEvent)
+if (startEvent.isDefaultPrevented()) return
+
+if (actives && actives.length) {
+  Plugin.call(actives, 'hide')
+  activesData || actives.data('bs.collapse', null)
+}
+
+var dimension = this.dimension()
+
+this.$element
+  .removeClass('collapse')
+  .addClass('collapsing')[dimension](0)
+  .attr('aria-expanded', true)
+
+this.$trigger
+  .removeClass('collapsed')
+  .attr('aria-expanded', true)
+
+this.transitioning = 1
+
+var complete = function () {
+  this.$element
+.removeClass('collapsing')
+.addClass('collapse in')[dimension]('')
+  this.transitioning = 0
+  this.$element
+.trigger('shown.bs.collapse')
+}
+
+if (!$.support.transition) return complete.call(this)
+
+var scrollSize = $.camelCase(['scroll', dimension].join('-'))
+
+this.$element
+  .one('bsTransitionEnd', $.proxy(complete, this))
+  
.emulateTransitionEnd(Collapse.TRANSITION_DURATION)[dimension](this.$element[0][scrollSize])
+  }
+
+  Collapse.prototype.hide = function () {
+if (this.transitioning || !this.$element.hasClass('in')) return
+
+var startEvent = $.Event('hide.bs.collapse')
+this.$element.trigger(startEvent)
+if (startEvent.isDefaultPrevented()) return
+
+var dimension = this.dimension()
+
+this.$element[dimension](this.$element[dimension]())[0].offsetHeight
+
+this.$element
+  .addClass('collapsing')
+  .removeClass('collapse in')
+  .attr('aria-expanded', false)
+
+this.$trigger
+  .addClass('collapsed')
+  .attr('aria-expanded', false)
+
+this.transitioning = 1
+
+var complete = function () {
+  this.transitioning = 0
+  this.$element
+.removeClass('collapsing')
+.addClass('collapse')
+.trigger('hidden.bs.collapse')
+}
+
+if (!$.support.transition) return complete.call(this)
+
+this.$element
+  [dimension](0)
+  .one('bsTransitionEnd', $.proxy(complete, this))
+  .emulateTransitionEnd(Collapse.TRANSITION_DURATION)
+  }
+
+  Collapse.prototype.toggle = function () {
+this[this.$element.hasClass('in') ? 'hide' : 'show']()
+  }
+
+  Collapse.prototype.getParent = function () {
+return $(this.options.parent)
+  .find('[data-toggle="collapse"][data-parent="' + this.options.parent + 
'"]')
+  .each($.proxy(function (i, element) {
+var $element = $(element)
+this.addAriaAndCollapsedClass(getTargetFromTrigger($element), $elemen

[jira] [Closed] (TAP5-2441) PageRenderLinkSource fails in cron job

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2441.
--
Resolution: Won't Fix

Fixing this would likely break other things; there are work-arounds, such as 
the mock Request object mentioned in the comments.

> PageRenderLinkSource fails in cron job
> --
>
> Key: TAP5-2441
> URL: https://issues.apache.org/jira/browse/TAP5-2441
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: George Christman
>
> While trying to use PageRenderLinkSource in a cron job failure occurs. It 
> appears as if it doesn't use the base url configurations from the AppModule, 
> but rather the request. The request throws a null pointer. 
> How to reproduce. 
> AppModule Config.
> public static void
> contributeApplicationDefaults(MappedConfiguration
> configuration) {
> // The factory default is true but during the early stages of
> an application
> // overriding to false is a good idea. In addition, this is
> often overridden
> // on the command line as -Dtapestry.production-mode=false
> configuration.add(SymbolConstants.PRODUCTION_MODE, "false");
> configuration.add(SymbolConstants.HOSTNAME, "localhost");
> configuration.add(SymbolConstants.HOSTPORT, "8080");
> configuration.add(SymbolConstants.HOSTPORT_SECURE, "8443");
> }
> AppModule.class
> @Startup
> public static void initApplication(ScheduleJobs scheduleJobs) {
>scheduleJobs.startJobs();
> }
> ScheduleJobsImpl.class
> @Inject
> private PageRenderLinkSource linkSource;
> public void startJobs() {
> periodicExecutor.addJob(new IntervalSchedule(3000),
> "Link Test", new Runnable() {
> @Override
> public void run() {
> System.out.println("Start Link Test");
> try {
> Link link = linkSource.createPageRenderLink(Index.class);
> System.out.println(link.toAbsoluteURI());
> } catch (Exception ex) {
> System.out.println("ex " + ex.getMessage());
> }
> }
> });
> }
> Exception
> ex java.lang.NullPointerException: Unable to delegate method
> invocation to property 'request' of  RequestGlobals(org.apache.tapestry5.services.RequestGlobals)>, because
> the property is null.
> at $Request_1a34deec12ab7.readProperty(Unknown Source)
> at $Request_1a34deec12ab7.isSecure(Unknown Source)
> at $Request_1a34deec12a4e.isSecure(Unknown Source)
> at 
> org.apache.tapestry5.internal.services.RequestSecurityManagerImpl.checkPageSecurity(RequestSecurityManagerImpl.java:112)
> at $RequestSecurityManager_1a34deec12aae.checkPageSecurity(Unknown Source)
> at 
> org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl.createPageRenderLink(ComponentEventLinkEncoderImpl.java:111)
> at 
> org.apache.tapestry5.internal.services.linktransform.LinkTransformerInterceptor.createPageRenderLink(LinkTransformerInterceptor.java:50)
> at $ComponentEventLinkEncoder_1a34deec12a6d.createPageRenderLink(Unknown
> Source)
> at 
> org.healthresearch.etss.services.scheduler.impl.ScheduleJobsImpl$1.run(ScheduleJobsImpl.java:155)
> at 
> org.apache.tapestry5.ioc.internal.services.cron.PeriodicExecutorImpl$Job.invoke(PeriodicExecutorImpl.java:225)
> at 
> org.apache.tapestry5.ioc.internal.services.cron.PeriodicExecutorImpl$Job.invoke(PeriodicExecutorImpl.java:49)
> at 
> org.apache.tapestry5.ioc.internal.services.ParallelExecutorImpl$1.call(ParallelExecutorImpl.java:60)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:722)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TAP5-2423) Wrong component id check for inherited pages/components

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2423.
--
Resolution: Invalid

As Joachen pointed out, templates are not overridden, they entirely replace. 
(well, unless you use the extensible template support, which you are not 
doing). This alone is a great reason to avoid component inheritance wherever 
possible.

> Wrong component id check for inherited pages/components
> ---
>
> Key: TAP5-2423
> URL: https://issues.apache.org/jira/browse/TAP5-2423
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Nourredine K.
>  Labels: easytest
> Attachments: sample.zip
>
>
> When page B inherits page A (providing its own template) and A implements 
> some event handler methods on some components, displaying page B throws an 
> TapestryException that claims page B does not contain those components in its 
> template.
> I think the pb occurs in the 
> [ComponentIdValidator#validate(ComponentResources)|https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java;h=c640158666493ebc669ff561de25b62a9236f54a;hb=HEAD#l91]
>  method because, we only check in the current ComponentResource and never in 
> its parents if they exist.
> Remarks : 
> - Occurs with tapestry 5.4-beta-22
> - Symbol tapestry.compatibility.unknown-component-id-check-enabled can't be 
> used (no more used in 5.4-beta-22)
> Regards,
> Nourredine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TAP5-2448) Asset.getClientURL() throws NPE if the Asset is a Folder within a SubModule JAR file

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2448.
--
Resolution: Invalid

Exposing a folder as an asset is not supported ... what would the fingerprint 
hash be, since there's no real content?  Relative URis from the folder URI 
would all have incorrect fingerprints, etc., etc.

Ideally this would be checked for and reported with a better error message, but 
the APIs provided by the JDK for this are quite poor.

> Asset.getClientURL() throws NPE if the Asset is a Folder within a SubModule 
> JAR file
> 
>
> Key: TAP5-2448
> URL: https://issues.apache.org/jira/browse/TAP5-2448
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Martin Papy
> Attachments: NPE_Stack_Trace.txt, folder.zip
>
>
> If you inject in a Field an Asset and if this Asset is actually a Folder that 
> is embedded into a JAR SubModule used by the main Tapestry WebApp then the 
> method toClientURL() returns a NPE.
> The issue does not happen when the SubModule is not yet a JAR file. Exemple : 
> when you are running Tomcat from Eclipse and let Eclipse manage the 
> dependency ( I am using the Sysdeo plugin to add dependencies to the source 
> folders of the SubModule instead of the JAR file. ).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TAP5-2456) Make URL generation of ZoneRefresh configurable concerning relative vs. absolute URLs

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2456.
--
Resolution: Invalid

The BaseURLSource, and its related configuration symbols, exists to ensure that 
fully qualified (e.g., including scheme and hostname) URIs are correct, 
overriding the HttpServletRequest in terms of hostname, etc.

> Make URL generation of ZoneRefresh configurable concerning relative vs. 
> absolute URLs
> -
>
> Key: TAP5-2456
> URL: https://issues.apache.org/jira/browse/TAP5-2456
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.8
>Reporter: Daniel Hiller
>
> *As* ZoneRefresh mixin user
> *I want to* have an optional boolean parameter {{createRelativeURI}}
> *to* be able to make ZoneRefresh generate a relative event link URI
> *Problem*
> When the web application is behind a proxy, i.e. Firefox prevents zone 
> reloads from {{ZoneRefresh}} mixin because the Javascript-generated URI 
> differs from the proxy URI. 
> *Error message*
> Firefox error message from developer console (Firefox Version 35.0.1 /Ubuntu 
> LTS 14.01):
> {quote}
> Cross-Origin Request Blocked: The Same Origin Policy disallows reading the 
> remote resource at http://*absolute-non-proxy-uri* . This can be fixed by 
> moving the resource to the same domain or enabling CORS.
> {quote}
> *Quick fix*
> Use {{link.toURI()}} instead of {{link.toAbsoluteURI()}} in Line 94 of method 
> {{ZoneRefresh.createEventLink()}} mixin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TAP5-1862) DateField component: allow 'type' attribute to be specified

2015-04-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481730#comment-14481730
 ] 

ASF subversion and git services commented on TAP5-1862:
---

Commit dcd31d68a7bf755fe0e5a8bf922646a4f86553f5 in tapestry-5's branch 
refs/heads/master from [~hlship]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=dcd31d6 ]

TAP5-1862: DateField component: allow 'type' attribute to be specified


> DateField component: allow 'type' attribute to be specified
> ---
>
> Key: TAP5-1862
> URL: https://issues.apache.org/jira/browse/TAP5-1862
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2
>Reporter: Paul Stanton
>  Labels: datefield, html5, type
> Fix For: 5.4
>
>
> just as textfield allows you to override the default value for 'type', 
> datefield should do the same.
> this would allow you to specify "date" or "datetime" as per the html5 spec.
> The only consideration for implementation is the integration of the 
> 'hideTextField' attribute, but this could be mapped to a style declaration  
> (style="display:none;") instead of changing the input type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TAP5-1862) DateField component: allow 'type' attribute to be specified

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship updated TAP5-1862:
---
Summary: DateField component: allow 'type' attribute to be specified  (was: 
datefield: allow 'type' attribute to be specified)

> DateField component: allow 'type' attribute to be specified
> ---
>
> Key: TAP5-1862
> URL: https://issues.apache.org/jira/browse/TAP5-1862
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2
>Reporter: Paul Stanton
>  Labels: datefield, html5, type
> Fix For: 5.4
>
>
> just as textfield allows you to override the default value for 'type', 
> datefield should do the same.
> this would allow you to specify "date" or "datetime" as per the html5 spec.
> The only consideration for implementation is the integration of the 
> 'hideTextField' attribute, but this could be mapped to a style declaration  
> (style="display:none;") instead of changing the input type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TAP5-1862) DateField component: allow 'type' attribute to be specified

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-1862.
--
   Resolution: Fixed
Fix Version/s: 5.4
 Assignee: Howard M. Lewis Ship

> DateField component: allow 'type' attribute to be specified
> ---
>
> Key: TAP5-1862
> URL: https://issues.apache.org/jira/browse/TAP5-1862
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2
>Reporter: Paul Stanton
>Assignee: Howard M. Lewis Ship
>  Labels: datefield, html5, type
> Fix For: 5.4
>
>
> just as textfield allows you to override the default value for 'type', 
> datefield should do the same.
> this would allow you to specify "date" or "datetime" as per the html5 spec.
> The only consideration for implementation is the integration of the 
> 'hideTextField' attribute, but this could be mapped to a style declaration  
> (style="display:none;") instead of changing the input type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


tapestry-5 git commit: TAP5-1862: DateField component: allow 'type' attribute to be specified

2015-04-06 Thread hlship
Repository: tapestry-5
Updated Branches:
  refs/heads/master 840533975 -> dcd31d68a


TAP5-1862: DateField component: allow 'type' attribute to be specified


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/dcd31d68
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/dcd31d68
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/dcd31d68

Branch: refs/heads/master
Commit: dcd31d68a7bf755fe0e5a8bf922646a4f86553f5
Parents: 8405339
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 12:50:54 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 12:50:54 2015 -0700

--
 .../tapestry5/corelib/components/DateField.java | 37 ++--
 1 file changed, 27 insertions(+), 10 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/dcd31d68/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
index 2e47739..94a9a1f 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
@@ -18,6 +18,7 @@ import org.apache.tapestry5.annotations.Import;
 import org.apache.tapestry5.annotations.Parameter;
 import org.apache.tapestry5.annotations.RequestParameter;
 import org.apache.tapestry5.corelib.base.AbstractField;
+import org.apache.tapestry5.dom.Element;
 import org.apache.tapestry5.ioc.Messages;
 import org.apache.tapestry5.ioc.annotations.Inject;
 import org.apache.tapestry5.ioc.annotations.Symbol;
@@ -35,11 +36,11 @@ import java.util.Locale;
 /**
  * A component used to collect a provided date from the user using a 
client-side JavaScript calendar. Non-JavaScript
  * clients can simply type into a text field.
- *
+ * 
  * One aspect here is that, because client-side JavaScript formatting and 
parsing is so limited, we (currently)
  * use Ajax to send the user's input to the server for parsing (before raising 
the popup) and formatting (after closing
  * the popup). Weird and inefficient, but easier than writing client-side 
JavaScript for that purpose.
- *
+ * 
  * Tapestry's DateField component is a wrapper around http://webfx.eae.net/dhtml/datepicker/datepicker.html";>WebFX 
DatePicker.
  *
@@ -66,12 +67,22 @@ public class DateField extends AbstractField
  */
 @Parameter(required = true, allowNull = false, defaultPrefix = 
BindingConstants.LITERAL)
 private DateFormat format;
-
+
+/**
+ * Allows the type of field to be output; normally this is "text", but can 
be updated to "date" or "datetime"
+ * as per the HTML 5 specification.
+ *
+ * @since 5.4
+ */
+@Parameter(allowNull = false, defaultPrefix = BindingConstants.LITERAL, 
value = "text")
+private String type;
+
 /**
  * When the format parameter isn't used, this parameter 
defines whether the
  * DateFormat created by this component will be lenient or 
not.
  * The default value of this parameter is the value of the {@link 
SymbolConstants#LENIENT_DATE_FORMAT}
  * symbol.
+ *
  * @see DateFormat#setLenient(boolean)
  * @see SymbolConstants#LENIENT_DATE_FORMAT
  * @since 5.4
@@ -93,7 +104,7 @@ public class DateField extends AbstractField
 @Parameter(defaultPrefix = BindingConstants.VALIDATE)
 @SuppressWarnings("unchecked")
 private FieldValidator validate;
-
+
 /**
  * Icon used for the date field trigger button. This was used in Tapestry 
5.3 and earlier and is now ignored.
  *
@@ -116,7 +127,7 @@ public class DateField extends AbstractField
 
 @Inject
 private DeprecationWarning deprecationWarning;
-
+
 @Inject
 @Symbol(SymbolConstants.LENIENT_DATE_FORMAT)
 private boolean lenientDateFormatSymbolValue;
@@ -142,7 +153,7 @@ public class DateField extends AbstractField
 String pattern = simpleDateFormat.toPattern();
 
 String revised = pattern.replaceAll("([^y])yy$", "$1");
-
+
 final SimpleDateFormat revisedDateFormat = new 
SimpleDateFormat(revised);
 revisedDateFormat.setLenient(lenient);
 return revisedDateFormat;
@@ -158,8 +169,9 @@ public class DateField extends AbstractField
 {
 return defaultProvider.defaultValidatorBinding("value", resources);
 }
-
-final boolean defaultLenient() {
+
+final boolean defaultLenient()
+{
 return lenientDateFormatSymbolValue;
 }
 
@@ -233,9 +245,9 @@ public class DateField extends AbstractField
 writ

[jira] [Updated] (TAP5-2456) Make URL generation of ZoneRefresh configurable concerning relative vs. absolute URLs

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship updated TAP5-2456:
---
Fix Version/s: (was: 5.4)

> Make URL generation of ZoneRefresh configurable concerning relative vs. 
> absolute URLs
> -
>
> Key: TAP5-2456
> URL: https://issues.apache.org/jira/browse/TAP5-2456
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.8
>Reporter: Daniel Hiller
>
> *As* ZoneRefresh mixin user
> *I want to* have an optional boolean parameter {{createRelativeURI}}
> *to* be able to make ZoneRefresh generate a relative event link URI
> *Problem*
> When the web application is behind a proxy, i.e. Firefox prevents zone 
> reloads from {{ZoneRefresh}} mixin because the Javascript-generated URI 
> differs from the proxy URI. 
> *Error message*
> Firefox error message from developer console (Firefox Version 35.0.1 /Ubuntu 
> LTS 14.01):
> {quote}
> Cross-Origin Request Blocked: The Same Origin Policy disallows reading the 
> remote resource at http://*absolute-non-proxy-uri* . This can be fixed by 
> moving the resource to the same domain or enabling CORS.
> {quote}
> *Quick fix*
> Use {{link.toURI()}} instead of {{link.toAbsoluteURI()}} in Line 94 of method 
> {{ZoneRefresh.createEventLink()}} mixin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TAP5-2391) Field-specific error not shown when AJAX used

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481688#comment-14481688
 ] 

Howard M. Lewis Ship commented on TAP5-2391:


That sounds like a promising approach.

> Field-specific error not shown when AJAX used
> -
>
> Key: TAP5-2391
> URL: https://issues.apache.org/jira/browse/TAP5-2391
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Geoff Callender
>Assignee: Howard M. Lewis Ship
>Priority: Blocker
>  Labels: 54_release_prerequisite
>
> Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in 
> 5.4-beta-6.
> When an error is recorded with Form.recordError(Field field, String 
> errorMessage) or ValidationTracker.recordError(Field field, String 
> errorMessage) it normally is shown in the UI by decorating the field in error 
> and displaying the errorMessage below it.
> In 5.4-beta-6 and every release ever before that, that was the behaviour 
> regardless of whether the request is non-AJAX or AJAX.  
> In 5.4-beta-22, the behaviour changes when the request is AJAX: the field 
> does not display an error. That is, the field is *not* decorated and the 
> errorMessage is *not* shown with it. If your Errors component has 
> globalOnly="true", which is the norm these days, then you won't even see the 
> error message there! If you set globalOnly="false" then the message *is* 
> shown, but who would want to set globalOnly="false"???  
> Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an 
> extra entry in the inits, like this:  
> ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First 
> Name must not be Acme."]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TAP5-2333) Decrease number of ThreadLocal.get calls

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2333.
--
   Resolution: Won't Fix
Fix Version/s: (was: 5.4)

> Decrease number of ThreadLocal.get calls
> 
>
> Key: TAP5-2333
> URL: https://issues.apache.org/jira/browse/TAP5-2333
> Project: Tapestry 5
>  Issue Type: Improvement
>Reporter: Michael Mikhulya
>Assignee: Howard M. Lewis Ship
>  Labels: performance
> Attachments: 
> 0001-TAP5-2333-Decrease-number-of-ThreadLocal.get-calls.patch, 
> 0002-TAP5-2333-Decrease-number-of-ThreadLocal.get-calls.patch, 
> 0003-TAP5-2333-Decrease-number-of-ThreadLocal.get-calls.patch
>
>
> During profiling I found that ThreadLocal.get is a very hot method call.
> Most frequently it is called from PerThreadOperationTracker.
> PerThreadOperationTracker can be replaced with SimpleOperationTracker which I 
> introduced in a patch.
> SimpleOperationTracker only prints exception without "operations trace".
> "Operations trace" can be useful during debug. So in my patch 
> PerThreadOperationTracker is used in debug mode, but otherwise 
> SimpleOperationTracker is used.
> Please check whether this decision is good for most cases.
> Performance gains are very serious. 
> Time per request decreased on 11ms (23% of overall time).
> All measurements are done with apache benchmark after warm up phase.
> Currently my patch breaks two tests:
> CoreBehaviorsTests. event_handler_return_types
> MiscTests. operation_tracking_via_annotation
> Both tests are broken because tests depend on 'Operation description' which 
> is ignored by SimpleOperationTracker.
> The simplest way to fix tests is to enforce using PerThreadOperationTracker 
> for these tests.
> I'm not sure whether 'Operation description' is definitely useful especially 
> taking into account that only 2 tests become broken. We use 
> SimpleOperationTracker on production for several months already and nobody 
> notice that 'Operation descriptions' are absent. In all cases (for us) it was 
> enough to see a stack trace of exception in logs.
> See TAP5-2332. There is a huge amount of String.format required to track such 
> 'operation descriptions'. By removing calculation of such 'operation 
> descriptions' Tapestry can be made much faster.
> If 'Operation descriptions' is required for some cases than we can introduce 
> some option to enable/disable this feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (TAP5-2391) Field-specific error not shown when AJAX used

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship updated TAP5-2391:
---
Fix Version/s: (was: 5.4)

> Field-specific error not shown when AJAX used
> -
>
> Key: TAP5-2391
> URL: https://issues.apache.org/jira/browse/TAP5-2391
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Geoff Callender
>Assignee: Howard M. Lewis Ship
>Priority: Blocker
>  Labels: 54_release_prerequisite
>
> Found this bug in 5.4-beta-22. I've confirmed that the bug was not present in 
> 5.4-beta-6.
> When an error is recorded with Form.recordError(Field field, String 
> errorMessage) or ValidationTracker.recordError(Field field, String 
> errorMessage) it normally is shown in the UI by decorating the field in error 
> and displaying the errorMessage below it.
> In 5.4-beta-6 and every release ever before that, that was the behaviour 
> regardless of whether the request is non-AJAX or AJAX.  
> In 5.4-beta-22, the behaviour changes when the request is AJAX: the field 
> does not display an error. That is, the field is *not* decorated and the 
> errorMessage is *not* shown with it. If your Errors component has 
> globalOnly="true", which is the norm these days, then you won't even see the 
> error message there! If you set globalOnly="false" then the message *is* 
> shown, but who would want to set globalOnly="false"???  
> Comparing the HTTP responses of beta-22 with beta-6, I see that beta-6 had an 
> extra entry in the inits, like this:  
> ["t5/core/fields:showValidationError", "firstName_8cf3108fe0ece9", "First 
> Name must not be Acme."]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TAP5-2460) deadlock found when start ioc registry

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2460.
--
Resolution: Cannot Reproduce

You have not provided nearly enough information to track this down. Some 
details about your IoC container configuration would be useful. Can you reduce 
this to simple example or test case?  If so, attach and reopen this issue.



> deadlock found when start ioc registry
> --
>
> Key: TAP5-2460
> URL: https://issues.apache.org/jira/browse/TAP5-2460
> Project: Tapestry 5
>  Issue Type: Bug
>Affects Versions: 5.3.8
>Reporter: Jun Tsai
>Priority: Blocker
> Attachments: deadlock.txt
>
>
> {noformat}
> Found one Java-level deadlock:
> =
> "Tapestry PeriodicExecutor":
>   waiting for ownable synchronizer 0x0007aeb9e660, (a 
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
>   which is held by "main"
> "main":
>   waiting to lock monitor 0x7f988c803658 (object 0x0007acb51028, a 
> org.apache.tapestry5.ioc.internal.services.cron.PeriodicExecutorImpl),
>   which is held by "Tapestry PeriodicExecutor"
> Java stack information for the threads listed above:
> ===
> "Tapestry PeriodicExecutor":
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x0007aeb9e660> (a 
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:964)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1282)
>   at 
> java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:731)
>   at 
> org.apache.tapestry5.ioc.internal.util.ConcurrentBarrier.withRead(ConcurrentBarrier.java:75)
>   at 
> org.apache.tapestry5.ioc.internal.ModuleImpl.findOrCreate(ModuleImpl.java:213)
>   at 
> org.apache.tapestry5.ioc.internal.ModuleImpl.getService(ModuleImpl.java:109)
>   at 
> org.apache.tapestry5.ioc.internal.RegistryImpl.getService(RegistryImpl.java:421)
>   at 
> org.apache.tapestry5.ioc.internal.RegistryImpl.getObject(RegistryImpl.java:868)
>   at 
> org.apache.tapestry5.ioc.internal.ObjectLocatorImpl.getObject(ObjectLocatorImpl.java:57)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils.calculateInjection(InternalUtils.java:257)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils.access$000(InternalUtils.java:50)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils$4.invoke(InternalUtils.java:289)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils$4.invoke(InternalUtils.java:287)
>   at 
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74)
>   at 
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:87)
>   at 
> org.apache.tapestry5.ioc.internal.RegistryImpl.invoke(RegistryImpl.java:1124)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils.calculateParameters(InternalUtils.java:293)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils.calculateParametersForMethod(InternalUtils.java:264)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils$28.invoke(InternalUtils.java:1679)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils$28.invoke(InternalUtils.java:1677)
>   at 
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74)
>   at 
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:87)
>   at 
> org.apache.tapestry5.ioc.internal.RegistryImpl.invoke(RegistryImpl.java:1124)
>   at 
> org.apache.tapestry5.ioc.internal.util.InternalUtils.createMethodInvocationPlan(InternalUtils.java:1675)
>   at 
> org.apache.tapestry5.ioc.internal.ServiceBuilderMethodInvoker.getPlan(ServiceBuilderMethodInvoker.java:49)
>   at 
> org.apache.tapestry5.ioc.internal.ServiceBuilderMethodInvoker.createObject(ServiceBuilderMethodInvoker.java:60)
>   at 
> org.apache.tapestry5.ioc.internal.OperationTrackingObjectCreator$1.invoke(OperationTrackingObjectCreator.java:45)
>   at 
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74)
>   at 
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:87)
>   at 
> org.apache.tapestry5.i

[jira] [Closed] (TAP5-2457) DatePicker and async loaded form

2015-04-06 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-2457.
--
Resolution: Invalid

> DatePicker and async loaded form
> 
>
> Key: TAP5-2457
> URL: https://issues.apache.org/jira/browse/TAP5-2457
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Charles Capon
>  Labels: datefield, datepicker
>
> I load a form in a modal asynchronously several time on a single page and the 
> datepicker is only working the first time.
> I investigate for a bit and it appears that it is because of requirejs that 
> load and run only once the datefield module (which make sense). 
> The problem is that on other datefield async loading, the datepicker is not 
> initialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[6/9] tapestry-5 git commit: Clean up markup inside JavaDoc to confirm to JDK 1.8's stricter rules

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Autocomplete.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Autocomplete.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Autocomplete.java
index 03a96da..1dfcd3d 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Autocomplete.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Autocomplete.java
@@ -28,11 +28,11 @@ import java.util.List;
 /**
  * A mixin for a text field that allows for autocompletion of text fields. 
This is based on
  * Twttter http://twitter.github.io/typeahead.js/";>typeahead.js 
version 0.10.5.
- * 
+ * 
  * The container is responsible for providing an event handler for event 
"providecompletions". The context will be the
  * partial input string sent from the client. The return value should be an 
array or list of completions, in
  * presentation order. e.g.
- * 
+ * 
  * 
  * String[] onProvideCompletionsFromMyField(String input)
  * {

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Confirm.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Confirm.java 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Confirm.java
index 1464129..0a746ef 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Confirm.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/Confirm.java
@@ -22,7 +22,7 @@ import 
org.apache.tapestry5.services.javascript.JavaScriptSupport;
 /**
  * A mixin that can be placed on a clickable component, such as {@link 
org.apache.tapestry5.corelib.components.LinkSubmit},
  * and will raise a confirmation dialog when the element is clicked.
- * 
+ * 
  * Due to conflicts between jQuery (as used by Bootstrap's JavaScript library) 
and Prototype, this mixin does not operate
  * when the {@linkplain 
org.apache.tapestry5.SymbolConstants#JAVASCRIPT_INFRASTRUCTURE_PROVIDER 
JavaScript infrastructure provider}
  * is "prototype".

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java
index 82e2aaf..9fcc124 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java
@@ -1,5 +1,3 @@
-// Copyright (c) 2011. The Apache Software Foundation
-//
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -15,7 +13,6 @@
 package org.apache.tapestry5.corelib.mixins;
 
 import org.apache.tapestry5.BindingConstants;
-import org.apache.tapestry5.ClientElement;
 import org.apache.tapestry5.Field;
 import org.apache.tapestry5.FieldFocusPriority;
 import org.apache.tapestry5.annotations.AfterRender;
@@ -30,7 +27,7 @@ import org.slf4j.Logger;
 /**
  * A mixin that instruments the outer {@link 
org.apache.tapestry5.corelib.components.Form} on which
  * component the focus should be activated.
- * 
+ * 
  * This is meant to be used only with {@link 
org.apache.tapestry5.corelib.components.Form} component.
  *
  * @since 5.3

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormGroup.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormGroup.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormGroup.java
index 424fc5a..f90bcc5 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormGroup.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormGroup.java
@@ -1,5 +1,3 @@
-// Copyright 2013 The Apache Software Foundation
-//
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -26,7 +24,7 @@ import org.apache.tapestry5.ioc.annotations.Inject;
 import org.apache.tapestry5.ioc.annotations.Symbol;
 
 /**
- * Applied to a {@link org.apache.tapestry5.Field}, this provides the outer 
layers of markup to correctly
+ * Applied to a {@link org.apache.tapestry5.Field}, this provides the outer 

[2/9] tapestry-5 git commit: Update JavaDoc template selection to work under JDK 1.8 (and later)

2015-04-06 Thread hlship
Update JavaDoc template selection to work under JDK 1.8 (and later)


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/99600b97
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/99600b97
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/99600b97

Branch: refs/heads/master
Commit: 99600b97fa6a35fd506b3bff83f1f6b748617822
Parents: df55ff6
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 09:48:28 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 09:48:28 2015 -0700

--
 build.gradle | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/99600b97/build.gradle
--
diff --git a/build.gradle b/build.gradle
index 696465d..e1cc52a 100755
--- a/build.gradle
+++ b/build.gradle
@@ -319,7 +319,7 @@ task aggregateJavadoc(type: Javadoc) {
 maxMemory "512m"
 destinationDir file("$buildDir/documentation/javadocs")
 
-def tapestryStylesheet = isJDK7() ? file("src/javadoc/stylesheet7.css") : 
file("src/javadoc/stylesheet.css");
+def tapestryStylesheet = isJDKAfter6() ? 
file("src/javadoc/stylesheet7.css") : file("src/javadoc/stylesheet.css");
 
 configure(options) {
 splitIndex true
@@ -579,8 +579,8 @@ boolean isWindows() {
 System.properties['os.name'].toLowerCase().contains('windows')
 }
 
-boolean isJDK7() {
-System.properties['java.version'].startsWith("1.7.")
+boolean isJDKAfter6() {
+! System.properties['java.version'].matches('1\\.[5|6]\\..*')
 }
 
 // Check JDK version to prevent VU#225657 see:



[5/9] tapestry-5 git commit: Clean up markup inside JavaDoc to confirm to JDK 1.8's stricter rules

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetFactory.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetFactory.java 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetFactory.java
index a06dc5a..faf8f35 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetFactory.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetFactory.java
@@ -1,5 +1,3 @@
-// Copyright 2006, 2007, 2008, 2013 The Apache Software Foundation
-//
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -19,16 +17,16 @@ import org.apache.tapestry5.ioc.Resource;
 
 /**
  * Used by {@link AssetSource} to create new {@link Asset}s as needed.
- * 
+ *
  * Starting in Tapestry 5.4, the built-in implementations of this interface 
(for context assets, and for classpath assets)
  * were changed so that when underlying resources changed, the client URLs for 
Assets are discarded; this is necessitated by two factors:
- * 1) the {@linkplain org.apache.tapestry5.Asset#toClientURL() client URL}
+ * 1) the {@linkplain org.apache.tapestry5.Asset#toClientURL() client URL}
  * for an Asset now includes a checksum based on the content of the underlying 
resource, so a change to resource content
  * (during development) results in a change to the URL.
- * 2) {@link org.apache.tapestry5.services.javascript.JavaScriptStack} 
(especially the {@link 
org.apache.tapestry5.services.javascript.ExtensibleJavaScriptStack} 
implementation)
+ * 2) {@link org.apache.tapestry5.services.javascript.JavaScriptStack} 
(especially the {@link 
org.apache.tapestry5.services.javascript.ExtensibleJavaScriptStack} 
implementation)
  * made no provision for rebuilding the Assets post-construction, and there is 
no backwards compatible way to
  * introduce this concept (and JavaScriptStacks are something many 
applications and third-party libraries make use of).
- * So, starting in Tapestry 5.4, the implementations of {@link Asset} 
should be
+ * So, starting in Tapestry 5.4, the implementations of {@link Asset} should be
  *
  * @see org.apache.tapestry5.services.AssetSource
  */

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetPathConverter.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetPathConverter.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetPathConverter.java
index 6fbb3e6..8040612 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetPathConverter.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetPathConverter.java
@@ -1,5 +1,3 @@
-// Copyright 2009, 2013 The Apache Software Foundation
-//
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -18,7 +16,7 @@ package org.apache.tapestry5.services;
  * Converts the {@linkplain org.apache.tapestry5.Asset#toClientURL() path (or 
URI) of an asset} into a new format. This
  * is the hook needed to make use of a http://en.wikipedia.org/wiki/Content_Delivery_Network";>Content
  * Delivery Network.
- * 
+ *
  * The default implementation of this is identity, the URI is passed 
through unchanged. Using a contribution to
  * the {@link org.apache.tapestry5.ioc.services.ServiceOverride} service, you 
may override the default implementation.
  *

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetSource.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetSource.java 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetSource.java
index 111b2f9..df82262 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetSource.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/services/AssetSource.java
@@ -23,11 +23,11 @@ import java.util.Locale;
 
 /**
  * Used to find or create an {@link org.apache.tapestry5.Asset} with a given 
path.
- * 
+ *
  * Assets are defined with a domain, and the domain is indicated by a prefix. 
The two builtin domains are "context:"
  * (for files inside the web application context) and "classpath:" for files 
stored on the classpath (typically, inside
  * a JAR, such as a component library). Other domains can be defined via 
contributions to the AssetSource service.
- * 
+ *
  * Since 5.1.0.0, is is preferred that
  * {@link 
org.apache.tapestry5.services.Ass

[9/9] tapestry-5 git commit: Clean up markup inside JavaDoc to confirm to JDK 1.8's stricter rules

2015-04-06 Thread hlship
Clean up markup inside JavaDoc to confirm to JDK 1.8's stricter rules


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/84053397
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/84053397
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/84053397

Branch: refs/heads/master
Commit: 840533975a33d9094789bc09e40557a5c3ec7ba8
Parents: 99600b9
Author: Howard M. Lewis Ship 
Authored: Mon Apr 6 12:18:21 2015 -0700
Committer: Howard M. Lewis Ship 
Committed: Mon Apr 6 12:18:25 2015 -0700

--
 .../apache/tapestry5/beaneditor/BeanModel.java  |  8 +--
 .../beaneditor/BeanModelSourceBuilder.java  | 16 ++---
 .../tapestry5/beaneditor/PropertyModel.java |  6 +-
 .../tapestry5/services/BeanModelSource.java |  6 +-
 .../services/PropertyConduitSource.java |  4 +-
 .../org/apache/tapestry5/ioc/Configuration.java |  8 +--
 .../tapestry5/ioc/MappedConfiguration.java  |  6 +-
 .../org/apache/tapestry5/ioc/ObjectLocator.java | 13 ++--
 .../tapestry5/ioc/OrderedConfiguration.java | 10 ++-
 .../java/org/apache/tapestry5/ioc/Resource.java | 10 +--
 .../ioc/internal/services/TypeCoercerImpl.java  |  8 +--
 .../ioc/internal/util/CollectionFactory.java| 10 ++-
 .../ioc/internal/util/GenericsUtils.java| 28 
 .../ioc/internal/util/InheritanceSearch.java| 14 ++--
 .../ioc/services/ClassPropertyAdapter.java  |  6 +-
 .../tapestry5/ioc/services/PropertyAccess.java  |  6 +-
 .../tapestry5/ioc/services/PropertyAdapter.java |  4 +-
 .../tapestry5/ioc/services/TypeCoercer.java |  6 +-
 .../apache/tapestry5/ioc/util/TimeInterval.java | 14 ++--
 .../tapestry5/services/DataTypeAnalyzer.java|  8 +--
 .../services/InvalidationEventHub.java  |  4 +-
 .../tapestry5/util/StringToEnumCoercion.java|  8 +--
 .../internal/plastic/asm/MethodWriter.java  |  4 +-
 .../plastic/asm/commons/AdviceAdapter.java  | 10 +--
 .../internal/plastic/asm/util/ASMifier.java | 12 +---
 .../plastic/asm/util/CheckClassAdapter.java | 32 +++---
 .../internal/plastic/asm/util/Textifier.java| 15 ++---
 .../plastic/asm/util/TraceClassVisitor.java | 16 ++---
 .../internal/plastic/asm/xml/Processor.java | 48 +-
 .../internal/plastic/PlasticInternalUtils.java  | 38 +++
 .../apache/tapestry5/plastic/FieldConduit.java  |  6 +-
 .../tapestry5/plastic/InstructionBuilder.java   |  8 +--
 .../tapestry5/plastic/MethodDescription.java| 12 ++--
 .../tapestry5/plastic/MethodInvocation.java |  4 +-
 .../apache/tapestry5/plastic/PlasticClass.java  | 16 ++---
 .../plastic/PlasticClassTransformation.java |  4 +-
 .../apache/tapestry5/plastic/PlasticField.java  |  6 +-
 .../tapestry5/plastic/PlasticManager.java   | 12 ++--
 .../apache/tapestry5/plastic/PlasticMethod.java | 10 +--
 .../apache/tapestry5/plastic/PlasticUtils.java  |  4 +-
 .../apache/tapestry5/plastic/TryCatchBlock.java |  4 +-
 .../src/main/java/services/AppModule.java   |  8 +--
 .../ClientConstraintDescriptor.java |  4 +-
 .../main/java/org/apache/tapestry5/Asset.java   | 12 ++--
 .../BaseOptimizedSessionPersistedObject.java|  6 +-
 .../main/java/org/apache/tapestry5/Binding.java |  4 +-
 .../main/java/org/apache/tapestry5/Block.java   |  4 +-
 .../org/apache/tapestry5/ClientElement.java |  4 +-
 .../org/apache/tapestry5/ComponentAction.java   |  6 +-
 .../tapestry5/ComponentEventCallback.java   |  4 +-
 .../apache/tapestry5/ComponentResources.java|  4 +-
 .../tapestry5/ComponentResourcesCommon.java |  4 +-
 .../java/org/apache/tapestry5/ContentType.java  |  2 +-
 .../main/java/org/apache/tapestry5/Field.java   |  4 +-
 .../main/java/org/apache/tapestry5/Field2.java  |  8 +--
 .../main/java/org/apache/tapestry5/Link.java| 14 ++--
 .../java/org/apache/tapestry5/MarkupWriter.java |  4 +-
 .../OptimizedSessionPersistedObject.java|  4 +-
 .../java/org/apache/tapestry5/PageCallback.java |  8 +--
 .../java/org/apache/tapestry5/SelectModel.java  |  4 +-
 .../org/apache/tapestry5/SymbolConstants.java   | 38 +--
 .../org/apache/tapestry5/TapestryConstants.java |  4 +-
 .../org/apache/tapestry5/TapestryFilter.java|  8 +--
 .../TrackableComponentEventCallback.java|  8 +--
 .../apache/tapestry5/ValidationDecorator.java   |  6 +-
 .../org/apache/tapestry5/ValidationTracker.java | 10 ++-
 .../java/org/apache/tapestry5/Validator.java|  4 +-
 .../java/org/apache/tapestry5/ValueEncoder.java | 10 ++-
 .../java/org/apache/tapestry5/VersionUtils.java |  4 +-
 .../apache/tapestry5/ajax/MultiZoneUpdate.java  |  4 +-
 .../annotations/ActivationRequestParameter.java | 24 +++
 .../tapestry5/annotations/BeforeRenderBody.java | 13 ++--
 .../tapestry5/annotations/BeginRender.java  | 13 ++--
 .../tapestry5/annotations/BindParameter.java| 12 ++--
 .../apache/tapestry5

[4/9] tapestry-5 git commit: Clean up markup inside JavaDoc to confirm to JDK 1.8's stricter rules

2015-04-06 Thread hlship
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
index b9f55d9..777c7a1 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptStack.java
@@ -26,17 +26,17 @@ import java.util.List;
  * and the may be no libraries in the core stack by Tapestry 5.5). Other 
component libraries may
  * define additional stacks for related sets of resources, for example, to 
bundle together some portion
  * of the ExtJS or YUI libraries.
- * 
+ *
  * The JavaScript assets of a stack may (when {@linkplain 
SymbolConstants#COMBINE_SCRIPTS enabled}) be exposed to the
  * client as a single URL (identifying the stack by name). The individual 
JavaScript  assets are combined into a single virtual
  * asset, which is then streamed to the client. The individual JavaScript 
libraries, or the combined virtual library,
  * may be {@linkplain SymbolConstants#MINIFICATION_ENABLED minimized} and the 
content (both compressed and
  * uncompressed) cached.
- * 
+ *
  * Implementations may need to inject the {@link ThreadLocale} service in 
order to determine the current locale (if any
  * of the JavaScript library or stylesheet assets are localized). They will 
generally need to inject the
  * {@link AssetSource} service as well.
- * 
+ *
  * The {@link ExtensibleJavaScriptStack} is the best way to create new stacks.
  *
  * @see ThreadLocale

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/84053397/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
--
diff --git 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
index 3ea1bee..526144d 100644
--- 
a/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
+++ 
b/tapestry-core/src/main/java/org/apache/tapestry5/services/javascript/JavaScriptSupport.java
@@ -1,5 +1,3 @@
-// Copyright 2010-2013 The Apache Software Foundation
-//
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -28,17 +26,17 @@ import 
org.apache.tapestry5.services.EnvironmentalShadowBuilder;
  * The JavaScriptSupport environmental is very stateful, accumulating 
JavaScript stacks, libraries and initialization
  * code until the end of the main page render; it then updates the rendered 
DOM (adding