[1/2] tapestry-5 git commit: TAP5-1886: fix indexOf call

2016-02-11 Thread jkemnade 
Repository: tapestry-5
Updated Branches:
  refs/heads/master c7df1c517 -> 2dd5bb525


TAP5-1886: fix indexOf call


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/a0a3c068
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/a0a3c068
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/a0a3c068

Branch: refs/heads/master
Commit: a0a3c068c99d9584ddb30b77306f7b54b5409a18
Parents: c7df1c5
Author: Jochen Kemnade 
Authored: Thu Feb 11 11:39:53 2016 +0100
Committer: Jochen Kemnade 
Committed: Thu Feb 11 11:39:53 2016 +0100

--
 .../main/coffeescript/META-INF/modules/t5/core/datefield.coffee| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/a0a3c068/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
--
diff --git 
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee 
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
index 50cc947..0c0aa6d 100644
--- 
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
+++ 
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
@@ -34,7 +34,7 @@ define ["./dom", "./events", "./messages", "./ajax", 
"underscore", "./datepicker
 monthsLabels = (messages "date-symbols.months").split ","
 abbreviateWeekDay = (name) -> name.substr(0, 1).toLowerCase()
 locale = (document.documentElement.getAttribute("data-locale")) || "en"
-if locale.indexOf 'zh' is 0
+if (locale.indexOf 'zh') is 0
   # TAP5-1886, Chinese weekdays cannot be abbreviated using the first 
character
   abbreviateWeekDay = (name) -> name.substr(name.length-1)
 daysLabels = (abbreviateWeekDay name for name in days)

[jira] [Commented] (TAP5-1886) DateField is not localized correctly

2016-02-11 Thread Aurelien Rouby (JIRA) 

[ 
https://issues.apache.org/jira/browse/TAP5-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142522#comment-15142522
 ] 

Aurelien Rouby commented on TAP5-1886:
--

There is a problem with the code added in commit 
b57f85559a380e393ba6478bcca542e7abdfd1.

The resulting js code is the following (note the indexOf() function) :
{code:title=datefield.js|javascript|borderStyle=solid}
if (locale.indexOf('zh' === 0)) {
  abbreviateWeekDay = function(name) {
return name.substr(name.length - 1);
  };
}
{code}

It causes the new chinese abbreviation logic to be applied to all locales.
For example, the french week days are displayed as "i, i, i..." instead of 
"lundi, mardi, mercredi..."

> DateField is not localized correctly
> 
>
> Key: TAP5-1886
> URL: https://issues.apache.org/jira/browse/TAP5-1886
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Rural Hunter
>Assignee: Jochen Kemnade
>  Labels: datefield
> Fix For: 5.4
>
>
> My locale is Chinese. The DateField component displays badly with Chinese. 
> 1. The weekday is cut wrongly
> in Chinese, weekday has 3 characters, such as '星期一', '星期二', '星期三'. the 
> difference is on the 3rd character. But DateField just cut the first 
> character to display. it means all weekdays in Chinese are displayed as '星'.
> 2. The 'Today' and 'None' buttons are fix-labeled and not translated.
> I hope DateField will have a language properties file to localize those text.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (TAP5-1886) DateField is not localized correctly

2016-02-11 Thread Jochen Kemnade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TAP5-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jochen Kemnade closed TAP5-1886.

Resolution: Fixed

> DateField is not localized correctly
> 
>
> Key: TAP5-1886
> URL: https://issues.apache.org/jira/browse/TAP5-1886
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Rural Hunter
>Assignee: Jochen Kemnade
>  Labels: datefield
> Fix For: 5.4.1
>
>
> My locale is Chinese. The DateField component displays badly with Chinese. 
> 1. The weekday is cut wrongly
> in Chinese, weekday has 3 characters, such as '星期一', '星期二', '星期三'. the 
> difference is on the 3rd character. But DateField just cut the first 
> character to display. it means all weekdays in Chinese are displayed as '星'.
> 2. The 'Today' and 'None' buttons are fix-labeled and not translated.
> I hope DateField will have a language properties file to localize those text.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TAP5-1886) DateField is not localized correctly

2016-02-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/TAP5-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142543#comment-15142543
 ] 

ASF subversion and git services commented on TAP5-1886:
---

Commit a0a3c068c99d9584ddb30b77306f7b54b5409a18 in tapestry-5's branch 
refs/heads/master from [~jkemnade]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=a0a3c06 ]

TAP5-1886: fix indexOf call


> DateField is not localized correctly
> 
>
> Key: TAP5-1886
> URL: https://issues.apache.org/jira/browse/TAP5-1886
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Rural Hunter
>Assignee: Jochen Kemnade
>  Labels: datefield
> Fix For: 5.4.1
>
>
> My locale is Chinese. The DateField component displays badly with Chinese. 
> 1. The weekday is cut wrongly
> in Chinese, weekday has 3 characters, such as '星期一', '星期二', '星期三'. the 
> difference is on the 3rd character. But DateField just cut the first 
> character to display. it means all weekdays in Chinese are displayed as '星'.
> 2. The 'Today' and 'None' buttons are fix-labeled and not translated.
> I hope DateField will have a language properties file to localize those text.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[2/2] tapestry-5 git commit: upgrade Gradle wrapper

2016-02-11 Thread jkemnade 
upgrade Gradle wrapper


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2dd5bb52
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2dd5bb52
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2dd5bb52

Branch: refs/heads/master
Commit: 2dd5bb5256c1b3dbd08a71d48538f4e764a38ee1
Parents: a0a3c06
Author: Jochen Kemnade 
Authored: Thu Feb 11 11:40:43 2016 +0100
Committer: Jochen Kemnade 
Committed: Thu Feb 11 11:40:43 2016 +0100

--
 build.gradle |   2 +-
 gradle/wrapper/gradle-wrapper.jar| Bin 53636 -> 53638 bytes
 gradle/wrapper/gradle-wrapper.properties |   4 ++--
 gradlew.bat  |   2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2dd5bb52/build.gradle
--
diff --git a/build.gradle b/build.gradle
index 4f39370..78762f4 100755
--- a/build.gradle
+++ b/build.gradle
@@ -455,7 +455,7 @@ task continuousIntegration {
 }
 
 task wrapper(type: Wrapper) {
-gradleVersion = '2.10'
+gradleVersion = '2.11'
 description "Regenerates the Gradle Wrapper files"
 }
 

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2dd5bb52/gradle/wrapper/gradle-wrapper.jar
--
diff --git a/gradle/wrapper/gradle-wrapper.jar 
b/gradle/wrapper/gradle-wrapper.jar
index 13372ae..5ccda13 100644
Binary files a/gradle/wrapper/gradle-wrapper.jar and 
b/gradle/wrapper/gradle-wrapper.jar differ

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2dd5bb52/gradle/wrapper/gradle-wrapper.properties
--
diff --git a/gradle/wrapper/gradle-wrapper.properties 
b/gradle/wrapper/gradle-wrapper.properties
index cd319fe..e1aba6f 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
-#Tue Dec 29 15:25:29 CET 2015
+#Thu Feb 11 11:40:38 CET 2016
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-2.11-bin.zip

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2dd5bb52/gradlew.bat
--
diff --git a/gradlew.bat b/gradlew.bat
index aec9973..72d362d 100644
--- a/gradlew.bat
+++ b/gradlew.bat
@@ -46,7 +46,7 @@ echo location of your Java installation.
 goto fail
 
 :init
-@rem Get command-line arguments, handling Windowz variants
+@rem Get command-line arguments, handling Windows variants
 
 if not "%OS%" == "Windows_NT" goto win9xME_args
 if "%@eval[2+2]" == "4" goto 4NT_args

[jira] [Updated] (TAP5-1886) DateField is not localized correctly

2016-02-11 Thread Jochen Kemnade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TAP5-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jochen Kemnade updated TAP5-1886:
-
Fix Version/s: (was: 5.4)
   5.4.1

> DateField is not localized correctly
> 
>
> Key: TAP5-1886
> URL: https://issues.apache.org/jira/browse/TAP5-1886
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Rural Hunter
>Assignee: Jochen Kemnade
>  Labels: datefield
> Fix For: 5.4.1
>
>
> My locale is Chinese. The DateField component displays badly with Chinese. 
> 1. The weekday is cut wrongly
> in Chinese, weekday has 3 characters, such as '星期一', '星期二', '星期三'. the 
> difference is on the 3rd character. But DateField just cut the first 
> character to display. it means all weekdays in Chinese are displayed as '星'.
> 2. The 'Today' and 'None' buttons are fix-labeled and not translated.
> I hope DateField will have a language properties file to localize those text.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (TAP5-1886) DateField is not localized correctly

2016-02-11 Thread Jochen Kemnade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TAP5-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jochen Kemnade reopened TAP5-1886:
--

You're right, the parentheses are wrong.

> DateField is not localized correctly
> 
>
> Key: TAP5-1886
> URL: https://issues.apache.org/jira/browse/TAP5-1886
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Rural Hunter
>Assignee: Jochen Kemnade
>  Labels: datefield
> Fix For: 5.4
>
>
> My locale is Chinese. The DateField component displays badly with Chinese. 
> 1. The weekday is cut wrongly
> in Chinese, weekday has 3 characters, such as '星期一', '星期二', '星期三'. the 
> difference is on the 3rd character. But DateField just cut the first 
> character to display. it means all weekdays in Chinese are displayed as '星'.
> 2. The 'Today' and 'None' buttons are fix-labeled and not translated.
> I hope DateField will have a language properties file to localize those text.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TAP5-1886) DateField is not localized correctly

2016-02-11 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/TAP5-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142643#comment-15142643
 ] 

Hudson commented on TAP5-1886:
--

FAILURE: Integrated in tapestry-trunk-freestyle #1555 (See 
[https://builds.apache.org/job/tapestry-trunk-freestyle/1555/])
TAP5-1886: fix indexOf call (jochen.kemnade: rev 
a0a3c068c99d9584ddb30b77306f7b54b5409a18)
* tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee


> DateField is not localized correctly
> 
>
> Key: TAP5-1886
> URL: https://issues.apache.org/jira/browse/TAP5-1886
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Rural Hunter
>Assignee: Jochen Kemnade
>  Labels: datefield
> Fix For: 5.4.1
>
>
> My locale is Chinese. The DateField component displays badly with Chinese. 
> 1. The weekday is cut wrongly
> in Chinese, weekday has 3 characters, such as '星期一', '星期二', '星期三'. the 
> difference is on the 3rd character. But DateField just cut the first 
> character to display. it means all weekdays in Chinese are displayed as '星'.
> 2. The 'Today' and 'None' buttons are fix-labeled and not translated.
> I hope DateField will have a language properties file to localize those text.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)