buildbot success in on tapestry-site-production
The Buildbot has detected a restored build on builder tapestry-site-production while building . Full details are available at: https://ci.apache.org/builders/tapestry-site-production/builds/14827 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb-cms-slave Build Reason: The Nightly scheduler named 'tapestry-site-production' triggered this build Build Source Stamp: [branch tapestry/tapestry-site] HEAD Blamelist: Build succeeded! Sincerely, -The Buildbot
buildbot failure in on tapestry-site-production
The Buildbot has detected a new failure on builder tapestry-site-production while building . Full details are available at: https://ci.apache.org/builders/tapestry-site-production/builds/14826 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb-cms-slave Build Reason: The Nightly scheduler named 'tapestry-site-production' triggered this build Build Source Stamp: [branch tapestry/tapestry-site] HEAD Blamelist: BUILD FAILED: failed compile Sincerely, -The Buildbot
[jira] [Updated] (TAP5-2575) Replace json.org-licensed classes with Apache-compatible versions
[ https://issues.apache.org/jira/browse/TAP5-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-2575: - Attachment: 0001-TAP5-2575-rewrite-some-of-tapestry-json-based-upon-c.patch New patch, I tried to maintain full compatibility including all error messages, at least the ones that are part of the test suite. I'd appreciate every additional pair of eyes. > Replace json.org-licensed classes with Apache-compatible versions > - > > Key: TAP5-2575 > URL: https://issues.apache.org/jira/browse/TAP5-2575 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-json >Affects Versions: 5.3.8, 5.4.1 >Reporter: Bob Harner > Attachments: 0001-TAP5-2575-base-tapestry-json-on-Jackson.patch, > 0001-TAP5-2575-rewrite-some-of-tapestry-json-based-upon-c.patch > > > Because of [license issues|https://www.apache.org/legal/resolved#json], we > need to replace all json.org-licensed classes with alternative classes having > an Apache-approved license. Apache legal has imposed a deadline of April 30, > 2017. > Tapestry apparently includes 3 classes that are, starting in version 5.2, > "repackaged, improved (and tested) version of code originally from json.org." > These 3 all include D. Crockford's "The Software shall be used for Good, not > Evil" statement in the JSON license at the top. > The 3 classes are: > * JSONArray.java > * JSONTokener.java > * JSONObject.java > Other Apache projects (including Wicket) have successfully switched to > https://github.com/tdunning/open-json, which contains versions of the above 3 > classes that are purported to be mostly compatible with the current versions > from json.org. However, there have been changes to Tapestry's own version > since the original copy was made (May 2008 or possibly earlier), and those > changes would need to be re-applied. Some examples: > * TAP5-1153: When in development mode, Tapestry should pretty-print JSON > content > * TAP5-2209 Make JSONObject and JSONArray implement Serializable > * Make JSONArray.from() not care about what values are stored in Iterable > * Add a new constructor to JSONObject to make it easier to initalize a > JSONObjects key/value pairs (if all strings) > * Change generics signature for JSONArray.putAll() and JSONObject.putAll() > * TAP5-2098: Maintain JSONObject keys & values in the order they were added > * Add a copy() method to JSONObject > * Add JSONArray.toList() > * Add JSONArray.putAll() > * Added remove(int index) to JSONArray > * TAP5-1970: Make it easier to create JSONObject and JSONArray instances > * Add JSONObject.toMap() > * Add JSONObject.in(String) to create (if needed) and return a nested > JSONObject > There are 116 unit tests for the JSON module. A starting point would be to > overlay the open-json classes and see what tests fail. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TAP5-2575) Replace json.org-licensed classes with Apache-compatible versions
[ https://issues.apache.org/jira/browse/TAP5-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901031#comment-15901031 ] Bob Harner commented on TAP5-2575: -- Yes, my original thought was just to copy those 3 classes from open-json, changing the package name. It does seem simpler and less bug-prone than writing adapter code, even though your patch does seem pretty far along. > Replace json.org-licensed classes with Apache-compatible versions > - > > Key: TAP5-2575 > URL: https://issues.apache.org/jira/browse/TAP5-2575 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-json >Affects Versions: 5.3.8, 5.4.1 >Reporter: Bob Harner > Attachments: 0001-TAP5-2575-base-tapestry-json-on-Jackson.patch > > > Because of [license issues|https://www.apache.org/legal/resolved#json], we > need to replace all json.org-licensed classes with alternative classes having > an Apache-approved license. Apache legal has imposed a deadline of April 30, > 2017. > Tapestry apparently includes 3 classes that are, starting in version 5.2, > "repackaged, improved (and tested) version of code originally from json.org." > These 3 all include D. Crockford's "The Software shall be used for Good, not > Evil" statement in the JSON license at the top. > The 3 classes are: > * JSONArray.java > * JSONTokener.java > * JSONObject.java > Other Apache projects (including Wicket) have successfully switched to > https://github.com/tdunning/open-json, which contains versions of the above 3 > classes that are purported to be mostly compatible with the current versions > from json.org. However, there have been changes to Tapestry's own version > since the original copy was made (May 2008 or possibly earlier), and those > changes would need to be re-applied. Some examples: > * TAP5-1153: When in development mode, Tapestry should pretty-print JSON > content > * TAP5-2209 Make JSONObject and JSONArray implement Serializable > * Make JSONArray.from() not care about what values are stored in Iterable > * Add a new constructor to JSONObject to make it easier to initalize a > JSONObjects key/value pairs (if all strings) > * Change generics signature for JSONArray.putAll() and JSONObject.putAll() > * TAP5-2098: Maintain JSONObject keys & values in the order they were added > * Add a copy() method to JSONObject > * Add JSONArray.toList() > * Add JSONArray.putAll() > * Added remove(int index) to JSONArray > * TAP5-1970: Make it easier to create JSONObject and JSONArray instances > * Add JSONObject.toMap() > * Add JSONObject.in(String) to create (if needed) and return a nested > JSONObject > There are 116 unit tests for the JSON module. A starting point would be to > overlay the open-json classes and see what tests fail. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TAP5-2575) Replace json.org-licensed classes with Apache-compatible versions
[ https://issues.apache.org/jira/browse/TAP5-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901001#comment-15901001 ] Jochen Kemnade commented on TAP5-2575: -- Oh, we could of course just copy the code from open-json and adapt it to our needs. I only ever thought of pulling it in as a dependency. > Replace json.org-licensed classes with Apache-compatible versions > - > > Key: TAP5-2575 > URL: https://issues.apache.org/jira/browse/TAP5-2575 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-json >Affects Versions: 5.3.8, 5.4.1 >Reporter: Bob Harner > Attachments: 0001-TAP5-2575-base-tapestry-json-on-Jackson.patch > > > Because of [license issues|https://www.apache.org/legal/resolved#json], we > need to replace all json.org-licensed classes with alternative classes having > an Apache-approved license. Apache legal has imposed a deadline of April 30, > 2017. > Tapestry apparently includes 3 classes that are, starting in version 5.2, > "repackaged, improved (and tested) version of code originally from json.org." > These 3 all include D. Crockford's "The Software shall be used for Good, not > Evil" statement in the JSON license at the top. > The 3 classes are: > * JSONArray.java > * JSONTokener.java > * JSONObject.java > Other Apache projects (including Wicket) have successfully switched to > https://github.com/tdunning/open-json, which contains versions of the above 3 > classes that are purported to be mostly compatible with the current versions > from json.org. However, there have been changes to Tapestry's own version > since the original copy was made (May 2008 or possibly earlier), and those > changes would need to be re-applied. Some examples: > * TAP5-1153: When in development mode, Tapestry should pretty-print JSON > content > * TAP5-2209 Make JSONObject and JSONArray implement Serializable > * Make JSONArray.from() not care about what values are stored in Iterable > * Add a new constructor to JSONObject to make it easier to initalize a > JSONObjects key/value pairs (if all strings) > * Change generics signature for JSONArray.putAll() and JSONObject.putAll() > * TAP5-2098: Maintain JSONObject keys & values in the order they were added > * Add a copy() method to JSONObject > * Add JSONArray.toList() > * Add JSONArray.putAll() > * Added remove(int index) to JSONArray > * TAP5-1970: Make it easier to create JSONObject and JSONArray instances > * Add JSONObject.toMap() > * Add JSONObject.in(String) to create (if needed) and return a nested > JSONObject > There are 116 unit tests for the JSON module. A starting point would be to > overlay the open-json classes and see what tests fail. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (TAP5-2574) No match on Locale nb
[
https://issues.apache.org/jira/browse/TAP5-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900875#comment-15900875
]
Svein edited comment on TAP5-2574 at 3/8/17 8:04 AM:
-
I agree!
no=nb=no_NB. "nn" people will have no problem reading "no".
If "nn" is present in SymbolConstants.SUPPORTED_LOCALES "nn" should not try to
read "no" properties files.
was (Author: svein):
I agree!
no=nb=no_NB. nn people will have no problem reading no.
If "nn" is present in SymbolConstants.SUPPORTED_LOCALES "nn" should not try to
read "no" properties files.
> No match on Locale nb
> --
>
> Key: TAP5-2574
> URL: https://issues.apache.org/jira/browse/TAP5-2574
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4.1
>Reporter: Svein
>
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES, "no_NB,en");{code}
> {code}org.apache.tapestry5.internal.services.Request.getLocale() for returns
> "nb" for Norwegian{code}
> No *_no_NB.properties or *_no.properties are used. I think A way to alias
> locale is needed. E.g:
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES,
> "no_NB{nb},en);{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
