[jira] [Commented] (TAP5-2779) Tapestry 5.8.3 to 5.8.7 issues caused by the multiple classloader feature
[ https://issues.apache.org/jira/browse/TAP5-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847273#comment-17847273 ] ASF subversion and git services commented on TAP5-2779: --- Commit 70438950cf5c4aee41dfc6cdc9e1e7851df18520 in tapestry-5's branch refs/heads/javax from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=70438950c ] TAP5-2779: multiple classloader fixes > Tapestry 5.8.3 to 5.8.7 issues caused by the multiple classloader feature > - > > Key: TAP5-2779 > URL: https://issues.apache.org/jira/browse/TAP5-2779 > Project: Tapestry 5 > Issue Type: Bug > Components: plastic, tapestry-core >Affects Versions: 5.8.3, 5.8.4, 5.8.6, 5.8.7 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Major > > TAP5-2742 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2779) Tapestry 5.8.3 to 5.8.7 issues caused by the multiple classloader feature
[ https://issues.apache.org/jira/browse/TAP5-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847271#comment-17847271 ] ASF subversion and git services commented on TAP5-2779: --- Commit 199795a8d326fc13562f7d4d74e8ebdbc163bf00 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=199795a8d ] TAP5-2779: multiple classloader fixes > Tapestry 5.8.3 to 5.8.7 issues caused by the multiple classloader feature > - > > Key: TAP5-2779 > URL: https://issues.apache.org/jira/browse/TAP5-2779 > Project: Tapestry 5 > Issue Type: Bug > Components: plastic, tapestry-core >Affects Versions: 5.8.3, 5.8.4, 5.8.6, 5.8.7 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Major > > TAP5-2742 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2777) Update the closure compiler for better support of modern JavaScript
[
https://issues.apache.org/jira/browse/TAP5-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845592#comment-17845592
]
ASF subversion and git services commented on TAP5-2777:
---
Commit 19732165c42a7df9a111c6ad13c2b01258bac366 in tapestry-5's branch
refs/heads/javax from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=19732165c ]
TAP5-2777: upgrade google closure compiler to v20220502
> Update the closure compiler for better support of modern JavaScript
> ---
>
> Key: TAP5-2777
> URL: https://issues.apache.org/jira/browse/TAP5-2777
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-webresources
>Affects Versions: 5.8.6
>Reporter: Chris Poulsen
>Assignee: Ben Weidig
>Priority: Minor
>
> A couple of years ago we encountered errors related to the closure compiler
> not understanding certain modern JavaScript constructs.
> The details are sort of hazy, but IIRC the newest version(s) of the compiler
> were not just drop-in upgrades (primo 2022). We ended up with "v20210505"
> back then, it allowed our JavaScript to pass through and was still just a
> drop-in upgrade.
> We have been running the following config in production for 2 years (on a
> bunch of installations) without issues, so maybe more people would benefit
> from this upgrade.
> {code:java}
> runtimeOnly("org.apache.tapestry:tapestry-webresources:$tapestryVersion") {
> exclude group: 'com.google.javascript'
> }
> runtimeOnly("com.google.javascript:closure-compiler-unshaded:v20210505")
> runtimeOnly("com.google.javascript:closure-compiler-externs:v20210505")
> {code}
> Ideally the compiler support would be updated to the newest version and kept
> up-to-date, but for a low hanging fruit, this one should be a simple step.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2605) JS minimizer regression bug in 5.5.0-beta-1
[
https://issues.apache.org/jira/browse/TAP5-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845593#comment-17845593
]
ASF subversion and git services commented on TAP5-2605:
---
Commit b1e144c74129ff7da0998eee9f9e3e6b7163b9d9 in tapestry-5's branch
refs/heads/javax from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=b1e144c74 ]
TAP5-2605: google closure compiler use generic filename
> JS minimizer regression bug in 5.5.0-beta-1
> ---
>
> Key: TAP5-2605
> URL: https://issues.apache.org/jira/browse/TAP5-2605
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-webresources
>Affects Versions: 5.5.0
>Reporter: Balázs Palcsó
>Assignee: Ben Weidig
>Priority: Major
> Labels: regression
> Attachments: clipboard-polyfill.promise.js
>
>
> After upgrading from 5.4.4 to 5.5.0-beta-1 I am getting the following error
> for the attached [^clipboard-polyfill.promise.js]
>
> {code:java}
> 20190105 22:07:58.126 [http-nio-8080-exec-5] ERROR
> org.apache.tapestry5.ioc.Registry - Illegal char <<> at index 18:
> StreamableResource classpath:META-INF/assets/js/3rd-party/clipboard-polyfill.promise.js
> COMPRESSABLE lastModified: Sat Jan 05 22:07:25 CET 2019 size: 24061>
> 20190105 22:07:58.126 [http-nio-8080-exec-5] ERROR
> org.apache.tapestry5.ioc.Registry - Operations trace:
> 20190105 22:07:58.126 [http-nio-8080-exec-5] ERROR
> org.apache.tapestry5.ioc.Registry - [ 1] Streaming compressed module clipboard
> 20190105 22:07:58.126 [http-nio-8080-exec-5] ERROR
> org.apache.tapestry5.ioc.Registry - [ 2] Streaming
> classpath:META-INF/assets/js/3rd-party/clipboard-polyfill.promise.js
> (compressed)
> 20190105 22:07:58.126 [http-nio-8080-exec-5] ERROR
> org.apache.tapestry5.ioc.Registry - [ 3] Minimizing
> StreamableResource classpath:META-INF/assets/js/3rd-party/clipboard-polyfill.promise.js
> COMPRESSABLE lastModified: Sat Jan 05 22:07:25 CET 2019 size: 24061>
> 20190105 22:07:58.246 [http-nio-8080-exec-5] ERROR
> o.a.t.m.T.RequestExceptionHandler - Processing of request failed with
> uncaught exception: {}
> org.apache.tapestry5.ioc.internal.OperationException: Illegal char <<> at
> index 18: StreamableResource classpath:META-INF/assets/js/3rd-party/clipboard-polyfill.promise.js
> COMPRESSABLE lastModified: Sat Jan 05 22:07:25 CET 2019 size: 24061>
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:186)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:118)
> at
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.perform(PerThreadOperationTracker.java:84)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.perform(RegistryImpl.java:1266)
> at
> org.apache.tapestry5.internal.webresources.AbstractMinimizer.minimize(AbstractMinimizer.java:67)
> at
> org.apache.tapestry5.internal.services.assets.MasterResourceMinimizer.minimize(MasterResourceMinimizer.java:42)
> at $ResourceMinimizer_2469ff1505ff6.minimize(Unknown Source)
> at
> org.apache.tapestry5.internal.services.assets.SRSMinimizingInterceptor.getStreamableResource(SRSMinimizingInterceptor.java:42)
> at
> org.apache.tapestry5.internal.services.assets.JavaScriptStackMinimizeDisabler.getStreamableResource(JavaScriptStackMinimizeDisabler.java:61)
> at
> org.apache.tapestry5.internal.services.assets.UTF8ForTextAssets.getStreamableResource(UTF8ForTextAssets.java:40)
> at
> org.apache.tapestry5.internal.services.assets.SRSCachingInterceptor.getStreamableResource(SRSCachingInterceptor.java:55)
> at
> org.apache.tapestry5.internal.services.assets.SRSCompressingInterceptor.getStreamableResource(SRSCompressingInterceptor.java:38)
> at
> org.apache.tapestry5.internal.services.assets.SRSCachingInterceptor.getStreamableResource(SRSCachingInterceptor.java:55)
> at $StreamableResourceSource_2469ff1505e6a.getStreamableResource(Unknown
> Source)
> at
> org.apache.tapestry5.internal.services.ResourceStreamerImpl$1.perform(ResourceStreamerImpl.java:114)
> at
> org.apache.tapestry5.internal.services.ResourceStreamerImpl$1.perform(ResourceStreamerImpl.java:107)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.perform(OperationTrackerImpl.java:110)
> at
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.perform(PerThreadOperationTracker.java:84)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.perform(RegistryImpl.java:1266)
> at
> org.apache.tapestry5.internal.services.ResourceStreamerImpl.streamResource(ResourceStreamerImpl.java:106)
> at $ResourceStreamer_2469ff1505e97.streamResource(Unknown Source)
> at
> org.apache.tapestry5.internal.services.javascript.ModuleDispatcher$1.perform(ModuleDispatcher.java:167)
> at
>
[jira] [Commented] (TAP5-2778) JUnit upgrade to support Eclipse 2023-09+
[
https://issues.apache.org/jira/browse/TAP5-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844890#comment-17844890
]
ASF subversion and git services commented on TAP5-2778:
---
Commit 9090b8d0b149cb376be21971b04a919a7023b469 in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=9090b8d0b ]
TAP5-2778: upgrade junit to 5.10.2
> JUnit upgrade to support Eclipse 2023-09+
> -
>
> Key: TAP5-2778
> URL: https://issues.apache.org/jira/browse/TAP5-2778
> Project: Tapestry 5
> Issue Type: Task
>Affects Versions: 5.8.6
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Major
>
> JUnit tests fail to run with a version < 5.10.0 in Eclipse 2023-09 and later.
>
> Related GitHub issue: [https://github.com/eclipse/buildship/issues/1265]
>
> Possible solutions:
> - Add {{testImplementation
> 'org.junit.platform:junit-platform-launcher:1.9.3'}} to all {{build.gradle}}
> files that use JUnit
> - Update {{org.junit.jupiter:junit-jupiter}} from 5.8.2 to 5.10.2
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2778) JUnit upgrade to support Eclipse 2023-09+
[
https://issues.apache.org/jira/browse/TAP5-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844885#comment-17844885
]
ASF subversion and git services commented on TAP5-2778:
---
Commit dd6398e381fe6922b3c3b71435c22a9ea534d6be in tapestry-5's branch
refs/heads/javax from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=dd6398e38 ]
TAP5-2778: upgrade junit to 5.10.2
> JUnit upgrade to support Eclipse 2023-09+
> -
>
> Key: TAP5-2778
> URL: https://issues.apache.org/jira/browse/TAP5-2778
> Project: Tapestry 5
> Issue Type: Task
>Affects Versions: 5.8.6
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Major
>
> JUnit tests fail to run with a version < 5.10.0 in Eclipse 2023-09 and later.
>
> Related GitHub issue: [https://github.com/eclipse/buildship/issues/1265]
>
> Possible solutions:
> - Add {{testImplementation
> 'org.junit.platform:junit-platform-launcher:1.9.3'}} to all {{build.gradle}}
> files that use JUnit
> - Update {{org.junit.jupiter:junit-jupiter}} from 5.8.2 to 5.10.2
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2775) ClassNotFoundException when in production mode and parameter type is array
[
https://issues.apache.org/jira/browse/TAP5-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839232#comment-17839232
]
ASF subversion and git services commented on TAP5-2775:
---
Commit bbfd4336f300772b07ccde98a98998cb5f9cca90 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=bbfd4336f ]
TAP5-2775: exception in production mode and array parameter
> ClassNotFoundException when in production mode and parameter type is array
> --
>
> Key: TAP5-2775
> URL: https://issues.apache.org/jira/browse/TAP5-2775
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.6
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> {code:java}
> public class TestComponent {
> @Parameter
> private Zone[] zones_;
> }
> {code}
> Exception:
> {code:java}
> by: java.lang.ClassNotFoundException:
> org.apache.tapestry5.corelib.components.Zone[]
> at java.base/java.lang.ClassLoader.findClass(ClassLoader.java:718)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassLoader.loadClass(PlasticClassLoader.java:68)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
> at
> org.apache.tapestry5.services.pageload.PageClassLoaderContextManagerImpl.loadClass(PageClassLoaderContextManagerImpl.java:352)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2775) ClassNotFoundException when in production mode and parameter type is array
[
https://issues.apache.org/jira/browse/TAP5-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839231#comment-17839231
]
ASF subversion and git services commented on TAP5-2775:
---
Commit 3ac943a1b374cef0fa15bb9bd638da68a340c3e8 in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=3ac943a1b ]
TAP5-2775: exception in production mode and array parameter
> ClassNotFoundException when in production mode and parameter type is array
> --
>
> Key: TAP5-2775
> URL: https://issues.apache.org/jira/browse/TAP5-2775
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.6
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> {code:java}
> public class TestComponent {
> @Parameter
> private Zone[] zones_;
> }
> {code}
> Exception:
> {code:java}
> by: java.lang.ClassNotFoundException:
> org.apache.tapestry5.corelib.components.Zone[]
> at java.base/java.lang.ClassLoader.findClass(ClassLoader.java:718)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassLoader.loadClass(PlasticClassLoader.java:68)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
> at
> org.apache.tapestry5.services.pageload.PageClassLoaderContextManagerImpl.loadClass(PageClassLoaderContextManagerImpl.java:352)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2773) NullPointerException in 5.8.5 when in production mode and template extension points
[
https://issues.apache.org/jira/browse/TAP5-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835110#comment-17835110
]
ASF subversion and git services commented on TAP5-2773:
---
Commit 9af6eb9eb5c889768162112ddae7d86fa7b51963 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=9af6eb9eb ]
TAP5-2773: avoiding an infinite recursion loop
> NullPointerException in 5.8.5 when in production mode and template extension
> points
> ---
>
> Key: TAP5-2773
> URL: https://issues.apache.org/jira/browse/TAP5-2773
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.5
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.6
>
>
> Caused by: org.apache.tapestry5.commons.internal.util.TapestryException:
> Failure creating embedded component 'componentB' of de
> ui.components.Index: org.apache.tapestry5.ioc.internal.OperationException [at
> classpath:de/.../ui/components/index.tml, line 6]
> at
> org.apache.tapestry5.internal.pageload.ComponentAssemblerImpl.createEmbeddedAssembler(ComponentAssemblerImpl.java:333)
> at
> org.apache.tapestry5.internal.pageload.PageLoaderImpl.startComponent(PageLoaderImpl.java:819)
> Caused by: org.apache.tapestry5.ioc.internal.OperationException
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:196)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.handleRuntimeException(OperationTrackerImpl.java:138)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:90)
> Caused by: java.lang.NullPointerException
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createTransformation(PlasticClassPool.java:532)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.getPlasticClassTransformation(PlasticClassPool.java:492)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.loadAndTransformClass(PlasticClassPool.java:399)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassLoader.loadClass(PlasticClassLoader.java:59)
> public class ComponentA extends CompentB { ... }
> public class abstract ComponentB { ... }
> ComponentA.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> xxx
>
> ComponentB.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> ...
>
> ...
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2773) NullPointerException in 5.8.5 when in production mode and template extension points
[
https://issues.apache.org/jira/browse/TAP5-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835108#comment-17835108
]
ASF subversion and git services commented on TAP5-2773:
---
Commit 7871208a5720b2a80990eb56024d96573df9f349 in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=7871208a5 ]
TAP5-2773: avoiding an infinite recursion loop
> NullPointerException in 5.8.5 when in production mode and template extension
> points
> ---
>
> Key: TAP5-2773
> URL: https://issues.apache.org/jira/browse/TAP5-2773
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.5
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.6
>
>
> Caused by: org.apache.tapestry5.commons.internal.util.TapestryException:
> Failure creating embedded component 'componentB' of de
> ui.components.Index: org.apache.tapestry5.ioc.internal.OperationException [at
> classpath:de/.../ui/components/index.tml, line 6]
> at
> org.apache.tapestry5.internal.pageload.ComponentAssemblerImpl.createEmbeddedAssembler(ComponentAssemblerImpl.java:333)
> at
> org.apache.tapestry5.internal.pageload.PageLoaderImpl.startComponent(PageLoaderImpl.java:819)
> Caused by: org.apache.tapestry5.ioc.internal.OperationException
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:196)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.handleRuntimeException(OperationTrackerImpl.java:138)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:90)
> Caused by: java.lang.NullPointerException
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createTransformation(PlasticClassPool.java:532)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.getPlasticClassTransformation(PlasticClassPool.java:492)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.loadAndTransformClass(PlasticClassPool.java:399)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassLoader.loadClass(PlasticClassLoader.java:59)
> public class ComponentA extends CompentB { ... }
> public class abstract ComponentB { ... }
> ComponentA.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> xxx
>
> ComponentB.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> ...
>
> ...
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2773) NullPointerException in 5.8.5 when in production mode and template extension points
[
https://issues.apache.org/jira/browse/TAP5-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834551#comment-17834551
]
ASF subversion and git services commented on TAP5-2773:
---
Commit 19bbf35c3fac3358ba1703227fa6023766904eec in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=19bbf35c3 ]
TAP5-2773: NPE when production mode on and template overrides
> NullPointerException in 5.8.5 when in production mode and template extension
> points
> ---
>
> Key: TAP5-2773
> URL: https://issues.apache.org/jira/browse/TAP5-2773
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.5
>Reporter: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> Caused by: org.apache.tapestry5.commons.internal.util.TapestryException:
> Failure creating embedded component 'componentB' of de
> ui.components.Index: org.apache.tapestry5.ioc.internal.OperationException [at
> classpath:de/.../ui/components/index.tml, line 6]
> at
> org.apache.tapestry5.internal.pageload.ComponentAssemblerImpl.createEmbeddedAssembler(ComponentAssemblerImpl.java:333)
> at
> org.apache.tapestry5.internal.pageload.PageLoaderImpl.startComponent(PageLoaderImpl.java:819)
> Caused by: org.apache.tapestry5.ioc.internal.OperationException
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:196)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.handleRuntimeException(OperationTrackerImpl.java:138)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:90)
> Caused by: java.lang.NullPointerException
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createTransformation(PlasticClassPool.java:532)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.getPlasticClassTransformation(PlasticClassPool.java:492)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.loadAndTransformClass(PlasticClassPool.java:399)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassLoader.loadClass(PlasticClassLoader.java:59)
> public class ComponentA extends CompentB { ... }
> public class abstract ComponentB { ... }
> ComponentA.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> xxx
>
> ComponentB.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> ...
>
> ...
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2773) NullPointerException in 5.8.5 when in production mode and template extension points
[
https://issues.apache.org/jira/browse/TAP5-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834552#comment-17834552
]
ASF subversion and git services commented on TAP5-2773:
---
Commit 834c1ab0ba8a3309b5753ee2529774a04e6397d2 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=834c1ab0b ]
TAP5-2773: NPE when production mode on and template overrides
> NullPointerException in 5.8.5 when in production mode and template extension
> points
> ---
>
> Key: TAP5-2773
> URL: https://issues.apache.org/jira/browse/TAP5-2773
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.5
>Reporter: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> Caused by: org.apache.tapestry5.commons.internal.util.TapestryException:
> Failure creating embedded component 'componentB' of de
> ui.components.Index: org.apache.tapestry5.ioc.internal.OperationException [at
> classpath:de/.../ui/components/index.tml, line 6]
> at
> org.apache.tapestry5.internal.pageload.ComponentAssemblerImpl.createEmbeddedAssembler(ComponentAssemblerImpl.java:333)
> at
> org.apache.tapestry5.internal.pageload.PageLoaderImpl.startComponent(PageLoaderImpl.java:819)
> Caused by: org.apache.tapestry5.ioc.internal.OperationException
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:196)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.handleRuntimeException(OperationTrackerImpl.java:138)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:90)
> Caused by: java.lang.NullPointerException
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.createTransformation(PlasticClassPool.java:532)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.getPlasticClassTransformation(PlasticClassPool.java:492)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassPool.loadAndTransformClass(PlasticClassPool.java:399)
> at
> org.apache.tapestry5.internal.plastic.PlasticClassLoader.loadClass(PlasticClassLoader.java:59)
> public class ComponentA extends CompentB { ... }
> public class abstract ComponentB { ... }
> ComponentA.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> xxx
>
> ComponentB.tml
>
> http://tapestry.apache.org/schema/tapestry_5_4.xsd;
> xmlns:p="tapestry:parameter">
> ...
>
> ...
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2771) Upgrade to Spock 2.3
[ https://issues.apache.org/jira/browse/TAP5-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830319#comment-17830319 ] ASF subversion and git services commented on TAP5-2771: --- Commit 3e751953f26552497017f8113076e6039116b6cd in tapestry-5's branch refs/heads/javax from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=3e751953f ] TAP5-2771: Upgrade to Spock 2.3 (#47) > Upgrade to Spock 2.3 > > > Key: TAP5-2771 > URL: https://issues.apache.org/jira/browse/TAP5-2771 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-spock >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2772) ClassCastException happening in some cases in production mode
[ https://issues.apache.org/jira/browse/TAP5-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830315#comment-17830315 ] ASF subversion and git services commented on TAP5-2772: --- Commit 5c719e3f05dc3a206516658d4ad6781902b3aa98 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=5c719e3f0 ] TAP5-2772: ClassCastException sometimes when in production mode > ClassCastException happening in some cases in production mode > - > > Key: TAP5-2772 > URL: https://issues.apache.org/jira/browse/TAP5-2772 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.8.3, 5.8.4 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Major > > In some cases, which we didn't discover which ones yet, you can have a > ClassCastException like this: > java.lang.ClassCastException: class ccom.example.pages.SomePage cannot be > cast to class com.example.pages.SomePage (com.example.pages.SomePage is in > unnamed module of loader com.example.pages.SomePage @35a6e774; > com.example.pages.SomePage is in unnamed module of loader > org.apache.tapestry5.internal.plastic.PlasticClassLoader @2743de59) at > $InternalPropertyConduit_abf7e72af968f.getRoot(Unknown Source) at > $InternalPropertyConduit_abf7e72af968f.get(Unknown Source) at > org.apache.tapestry5.internal.bindings.PropBinding.get(PropBinding.java:63) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2772) ClassCastException happening in some cases in production mode
[ https://issues.apache.org/jira/browse/TAP5-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830316#comment-17830316 ] ASF subversion and git services commented on TAP5-2772: --- Commit 2081603eb695b35eec1a55fffa48d3ae9a881657 in tapestry-5's branch refs/heads/javax from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2081603eb ] TAP5-2772: ClassCastException sometimes when in production mode > ClassCastException happening in some cases in production mode > - > > Key: TAP5-2772 > URL: https://issues.apache.org/jira/browse/TAP5-2772 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.8.3, 5.8.4 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Major > Fix For: 5.8.5 > > > In some cases, which we didn't discover which ones yet, you can have a > ClassCastException like this: > java.lang.ClassCastException: class ccom.example.pages.SomePage cannot be > cast to class com.example.pages.SomePage (com.example.pages.SomePage is in > unnamed module of loader com.example.pages.SomePage @35a6e774; > com.example.pages.SomePage is in unnamed module of loader > org.apache.tapestry5.internal.plastic.PlasticClassLoader @2743de59) at > $InternalPropertyConduit_abf7e72af968f.getRoot(Unknown Source) at > $InternalPropertyConduit_abf7e72af968f.get(Unknown Source) at > org.apache.tapestry5.internal.bindings.PropBinding.get(PropBinding.java:63) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2771) Upgrade to Spock 2.3
[ https://issues.apache.org/jira/browse/TAP5-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827378#comment-17827378 ] ASF subversion and git services commented on TAP5-2771: --- Commit 6637b7ea056dd5ff9d03447294c74ed60949f6e1 in tapestry-5's branch refs/heads/master from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=6637b7ea0 ] TAP5-2771: Upgrade to Spock 2.3 (#47) * TAP5-2771: Upgrade to Spock 2.3 * Removed Java 8 from setup. > Upgrade to Spock 2.3 > > > Key: TAP5-2771 > URL: https://issues.apache.org/jira/browse/TAP5-2771 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-spock >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825495#comment-17825495
]
ASF subversion and git services commented on TAP5-2770:
---
Commit f58f36a99fb0600f91880a3e136ba4e98963da26 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=f58f36a99 ]
TAP5-2770: trying to recover when a ClassCastException happens
by clearing the generated classes caches and trying to handle the
request again
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825494#comment-17825494
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 2b9cf7dae05c8f8dbb10aa7afda496b4969bdfd7 in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2b9cf7dae ]
TAP5-2770: trying to recover when a ClassCastException happens
by clearing the generated classes caches and trying to handle the
request again
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825060#comment-17825060
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 4a226d063914bdcce39d92ae64b7d33c783009ab in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=4a226d063 ]
TAP5-2770: avoiding using FieldHandle when in multiple classloader mode
Now, in CachedWorker too.
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825059#comment-17825059
]
ASF subversion and git services commented on TAP5-2770:
---
Commit e8564a9ff715d8a21c38b4f3b50cdb93293f126a in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=e8564a9ff ]
TAP5-2770: avoiding using FieldHandle when in multiple classloader mode
For now, just in ImportWorker.
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825058#comment-17825058
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 27664ce465deb817ce06b2a278312b7cf74e577a in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=27664ce46 ]
TAP5-2770: fixing regression
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825061#comment-17825061
]
ASF subversion and git services commented on TAP5-2770:
---
Commit b632f5e0a75d1b1f49aadb3746c261bf4b1d872a in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=b632f5e0a ]
TAP5-2770: fixing JavaDoc errors
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825062#comment-17825062
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 5da802b1e4b3a2ffd83064de83e86f1302ff6ace in tapestry-5's branch
refs/heads/javax from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=5da802b1e ]
TAP5-2770: fixing regression
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825057#comment-17825057
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 3e667bda1d5a912a4b6b59f20ab8c3617877ebd1 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=3e667bda1 ]
TAP5-2770: fixing JavaDoc errors
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825055#comment-17825055
]
ASF subversion and git services commented on TAP5-2770:
---
Commit c6aac55764f4910a5f8d3c3a1beb247650445c99 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=c6aac5576 ]
TAP5-2770: avoiding using FieldHandle when in multiple classloader mode
For now, just in ImportWorker.
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825056#comment-17825056
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 4fbf66de750918a5fc97235f69447fd57e961493 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=4fbf66de7 ]
TAP5-2770: avoiding using FieldHandle when in multiple classloader mode
Now, in CachedWorker too.
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.5
>
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825053#comment-17825053 ] ASF subversion and git services commented on TAP5-2741: --- Commit 3156924c1d8eae9a2da20f17fc6684656eacc7f9 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=3156924c1 ] Revert "TAP5-2741: downgrading Tomcat to 10.0.27 so it can run on Java 8" This reverts commit 5baf3f32e5ba1faf19c55c57c38ffe858dd62c62. > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2771) Upgrade to Spock 2.3
[ https://issues.apache.org/jira/browse/TAP5-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824859#comment-17824859 ] ASF subversion and git services commented on TAP5-2771: --- Commit 28dd6cc83c3f9044faf2802721cfb30022f4 in tapestry-5's branch refs/heads/TAP5-2771 from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=28dd6cc83 ] TAP5-2771: Upgrade to Spock 2.3 > Upgrade to Spock 2.3 > > > Key: TAP5-2771 > URL: https://issues.apache.org/jira/browse/TAP5-2771 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-spock >Reporter: Volker Lamp >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822839#comment-17822839 ] ASF subversion and git services commented on TAP5-2741: --- Commit 5baf3f32e5ba1faf19c55c57c38ffe858dd62c62 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=5baf3f32e ] TAP5-2741: downgrading Tomcat to 10.0.27 so it can run on Java 8 > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822838#comment-17822838 ] ASF subversion and git services commented on TAP5-2741: --- Commit b7429c11dcf2f306fc3361e3ad6ea9717cc87a4e in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=b7429c11d ] TAP5-2741: exclude tapestry-spring from pre-Java 17 builds > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822826#comment-17822826 ] ASF subversion and git services commented on TAP5-2741: --- Commit fe3fabc6e1814b958a8bf1b675907504be2c2ddb in tapestry-5's branch refs/heads/master from Christian Köberl [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=fe3fabc6e ] TAP5-2741: switch to Jakarta EE (#43) Things changed: - Switch all Java EE to Jakarta EE APIs - Update references in JavaDoc for Jakarta EE - Switch to Spring 6 (Jakarta EE, Java 17) - Switch to Jetty 11 and Tomcat 10.1 (for support of Jakarta EE) > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813007#comment-17813007
]
ASF subversion and git services commented on TAP5-2769:
---
Commit fa1b44e79b23c5774eb800976996ffa36ac3c06a in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=fa1b44e79 ]
TAP5-2769: fixing hardcoded references to ASM packages
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812530#comment-17812530
]
ASF subversion and git services commented on TAP5-2769:
---
Commit e383f1a33779dc9d696a626bb25cf77db61d7aab in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=e383f1a33 ]
TAP5-2769: Upgrade ASM to 9.6 to support Java 21
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812529#comment-17812529
]
ASF subversion and git services commented on TAP5-2769:
---
Commit c9fb4e97b01170c92a04c7ab8e1c61778d483427 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=c9fb4e97b ]
TAP5-2769: revert ASM shadowing
due to side effects we couldn't solve.
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811613#comment-17811613
]
ASF subversion and git services commented on TAP5-2769:
---
Commit cac6ead3aa7a43467f082da25c8e3c0ee8cdcf6a in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=cac6ead3a ]
TAP5-2769: more build fixes
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811538#comment-17811538
]
ASF subversion and git services commented on TAP5-2769:
---
Commit 6f8bf2f54909ef0a6b3d72f379685d93a10bf98b in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=6f8bf2f54 ]
TAP5-2769: fixing release build and changing shadow ASM package name
to avoid having packages in more than one JAR, something
Java modules forbid
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799224#comment-17799224
]
ASF subversion and git services commented on TAP5-2770:
---
Commit a7b7c10a11009bbe007c71eebb337bac7b2ee8e0 in tapestry-5's branch
refs/heads/TAP5-2770 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=a7b7c10a1 ]
TAP5-2770: fixing regression
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799219#comment-17799219
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 7875dfa945124e24238664e6e0fca73b0c143778 in tapestry-5's branch
refs/heads/TAP5-2770 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=7875dfa94 ]
TAP5-2770: fixing JavaDoc errors
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799213#comment-17799213
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 23c760a26307089fbc96e5a56feb1960b88d9265 in tapestry-5's branch
refs/heads/TAP5-2770 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=23c760a26 ]
TAP5-2770: avoiding using FieldHandle when in multiple classloader mode
For now, just in ImportWorker.
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799214#comment-17799214
]
ASF subversion and git services commented on TAP5-2770:
---
Commit f002ed100e9004bd21fa15faa7103bee01f8cca2 in tapestry-5's branch
refs/heads/TAP5-2770 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=f002ed100 ]
TAP5-2770: avoiding using FieldHandle when in multiple classloader mode
Now, in CachedWorker too.
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2769) Upgrade ASM to 9.6 to allow running on Java 21
[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792284#comment-17792284
]
ASF subversion and git services commented on TAP5-2769:
---
Commit ecb81b84719ffe72d4832075c4147f70476c8cd2 in tapestry-5's branch
refs/heads/master from chrispoulsen
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=ecb81b847 ]
TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21 (#46)
* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21
- Remove the copy of ASM
- Add project 'plastic-asm' to be the shadowed version of ASM 9.6
- Add a version property for ASM in the build
* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21
- Inject a Tapestry specific TapestryAnnotationNode into ASM to get access to
the static helper instead of relying on reflection
-
Co-authored-by: Chris Poulsen
> Upgrade ASM to 9.6 to allow running on Java 21
> --
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
>Affects Versions: 5.8.3
>Reporter: Chris Poulsen
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2770) With multiple classloader mode on, ClassCastException when component and superclass both have @Import
[
https://issues.apache.org/jira/browse/TAP5-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789717#comment-17789717
]
ASF subversion and git services commented on TAP5-2770:
---
Commit 0a621b6423cd0b4e0935ca5764452903c7f7c189 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0a621b642 ]
TAP5-2770: component dependencies missing superclass in
PageClassLoaderContextManagerImpl
> With multiple classloader mode on, ClassCastException when component and
> superclass both have @Import
> -
>
> Key: TAP5-2770
> URL: https://issues.apache.org/jira/browse/TAP5-2770
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> For example:
> {code:java}
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> @Import(stylesheet = "context:css/ie-only.css")
> public class SubclassWithImport extends SuperclassWithImport {
> }
> {code}
> Exception:
> java.lang.ClassCastException
> class org.apache.tapestry5.integration.app1.components.SubclassWithImport
> cannot be cast to class
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport
> (org.apache.tapestry5.integration.app1.components.SubclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @105b693d;
> org.apache.tapestry5.integration.app1.components.SuperclassWithImport is in
> unnamed module of loader
> org.apache.tapestry5.internal.plastic.PlasticClassLoader @37fdfb05)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2767) Upgrade the build from Gradle 7 to 8
[ https://issues.apache.org/jira/browse/TAP5-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787532#comment-17787532 ] ASF subversion and git services commented on TAP5-2767: --- Commit a629daec91b2a67589c18bc8a2e1fae2a7c43a66 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=a629daec9 ] TAP5-2767: ugprade build from Gradle 7 to 8 > Upgrade the build from Gradle 7 to 8 > > > Key: TAP5-2767 > URL: https://issues.apache.org/jira/browse/TAP5-2767 > Project: Tapestry 5 > Issue Type: Task >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Major > > This is needed for running test builds on Java 19+. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2768) DefaultRequestExceptionHandler shouldn't send Exception message in production
[
https://issues.apache.org/jira/browse/TAP5-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784309#comment-17784309
]
ASF subversion and git services commented on TAP5-2768:
---
Commit 2c61207ce41150b16cb4dd4ca96efd06c60cf1e9 in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2c61207ce ]
TAP5-2768: DefaultRequestExceptionHandler doesn't leak error msg if prod
> DefaultRequestExceptionHandler shouldn't send Exception message in production
> -
>
> Key: TAP5-2768
> URL: https://issues.apache.org/jira/browse/TAP5-2768
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Minor
>
> The {{DefaultRequestExceptionHandler}} shouldn't write the actual Exception
> message to the Request header {{X-Tapestry-ErrorMessage}} in production mode.
> Instead, a generic "An error occurred." should be used, as the message
> exposes app internals.
> The client-side code in {{ajax.coffee}} only uses the header detecting if an
> error occurred and logging it to {{console.error}}, so its actual value is
> irrelevant.
> Omitting the header completely would mean reworking {{ajax.coffee}}, as the
> header indicates that the response might contain HTML content for the
> exception frame.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2766) Configure GitHub via .asf.yaml
[
https://issues.apache.org/jira/browse/TAP5-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779089#comment-17779089
]
ASF subversion and git services commented on TAP5-2766:
---
Commit 7b91b36cb0644a6d83919cd47d7dba380d8622ec in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=7b91b36cb ]
TAP5-2766: add .asf.yaml
> Configure GitHub via .asf.yaml
> --
>
> Key: TAP5-2766
> URL: https://issues.apache.org/jira/browse/TAP5-2766
> Project: Tapestry 5
> Issue Type: Task
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Trivial
>
> Apache support configuring GitHub via an .asf.yaml file:
> [https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features]
> The minimal config should be:
> * Project metadata
> * Disable all unused GH features (wiki, issues, projects)
> * Auto-Link Jira issues from project TAP5
> * Disable force-push on master
> There are additional settings, especially for PRs, like forced reviews, needs
> to be up-to-date, etc.
> But for now, the minimal config should be sufficient.
> {code:java}
> github:
> description: "A component-oriented framework for creating highly scalable
> web applications in Java."
> homepage: "https://tapestry.apache.org;
> labels:
> - java
> - apache
> features:
> wiki: false
> issues: false
> projects: false
> autolink_jira:
> - TAP5
> protected_branches:
> # no force push to master
> master: {}
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2765) Update Underscore.js
[ https://issues.apache.org/jira/browse/TAP5-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778111#comment-17778111 ] ASF subversion and git services commented on TAP5-2765: --- Commit 9c2209b2f15681e8b46996d67c76dfc6ae2435bd in tapestry-5's branch refs/heads/master from Olli [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=9c2209b2f ] TAP5-2765: Upgrade Underscore.js to version 1.13.6 (#45) Co-authored-by: Oliver Hanraths > Update Underscore.js > > > Key: TAP5-2765 > URL: https://issues.apache.org/jira/browse/TAP5-2765 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Major > > Underscore.js should be upgraded to the current version due to > [CVE-2021-23358|https://nvd.nist.gov/vuln/detail/CVE-2021-23358] > Originated in[ GitHub PR #45|https://github.com/apache/tapestry-5/pull/45] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2764) JSONArray improvements
[
https://issues.apache.org/jira/browse/TAP5-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772981#comment-17772981
]
ASF subversion and git services commented on TAP5-2764:
---
Commit 0da3aaa27e404c7d3dc85898cfaa79180241b9aa in tapestry-5's branch
refs/heads/TAP5-2764 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0da3aaa27 ]
TAP5-2764: static JSONArray#empty() added
> JSONArray improvements
> --
>
> Key: TAP5-2764
> URL: https://issues.apache.org/jira/browse/TAP5-2764
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-json
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Minor
>
> The following improvements should be added to JSONArray:
> *Implement {{List}}*
> Right now, the type implements {{Collection}} but it could bei a
> {{List}} instead.
> As it's a thin wrapper arround {{ArrayList}} anyway, using a more
> feature-packed interface makes sense, as there's almost no additional cost to
> it.
> *Fix {{Object remove(int)}} contract*
> Index-based removal is a {{{}List{}}}-related method with a certain contract,
> like throwing an Exception on invalid index arguments.
> Event hough it _should be_ expected behavior on any {{{}List{}}}-like data
> structures, it's going to be a breaking change here.
> *Add {{static JSONArray empty()}}*
> Similar to {{{}Collections.emptyList(){}}}, a convenience method for creating
> an empty and immutable instance should be added to reduce object creation /
> memory requirements, as an {{ArrayList}} will always needs some memory, even
> if empty.
> Implementation-wise, it would require a new (private) constructor that allows
> setting the underlying data structure.
> Then, {{empty()}} could simply use {{{}Collections.emptyList(){}}}.
> {color:#FF}As the changes contain a breaking change, it should be
> released in a minor-release, not patch.{color}
> Related mailing list thread:
> [https://lists.apache.org/thread/pf7hwy2tp5x7ktbzq9w2btwdd1xkyod2]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2763) @RequestParameter improved blank handling
[
https://issues.apache.org/jira/browse/TAP5-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768363#comment-17768363
]
ASF subversion and git services commented on TAP5-2763:
---
Commit c55d039af792c7b2052473d3219f3acd71888c1a in tapestry-5's branch
refs/heads/TAP5-2763 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=c55d039af ]
TAP5-2763: improve @RequestParameter blank handling
@RequestParamter now also has "boolean treatBlankAsNull() default false" to
better handl blank values.
A value might be blank, even if it's supposed to be a null coming from the
client, as any parameter in a request set to null will end up as blank on the
server side.
This might lead to coercion problems if no sensible coercer from blank to the
target type exists.
To keep the handling as close to the original, an additional annotation
parameter made more sense than changing the overall handling.
> @RequestParameter improved blank handling
> -
>
> Key: TAP5-2763
> URL: https://issues.apache.org/jira/browse/TAP5-2763
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Minor
>
> As ValueEncoders are used to convert a parameter value to its actual type,
> only Boolean and Number-based types result directly in {{null}} for a blank
> value.
> All other types use their TypeCoercer-based ValueEncoder, which not
> necessarily work.
> However, I believe that if {{allowBlank = true}} is set, then a blank
> parameter should be able to lead to a {{null}} value.
> Three possible changes come to mind to support blank --> null:
> * Always treat blank as {{null}} before passing it the ValueEncoder
> * Add {{boolean treatBlankAsNull() default false;}} to {{@RequestParameter,
> or}}
> * {{adding String blankValue() String default ""; to @RequestParameter that
> is used instead of the parameter value if blank}}
> Personally, I'd prefer the first option.
> The {{TypeCoercedValueEncoderFactory}} would handle
> {{{}Boolean{}}}/{{{}Number{}}} just like before, but @RequestParamter
> wouldn't crash anymore if no valid coercion is possible for an empty String.
> My proof-of-concept works and I might provide a feature branch soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2762) New symbol for defining the path to the component dependencies file
[
https://issues.apache.org/jira/browse/TAP5-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763370#comment-17763370
]
ASF subversion and git services commented on TAP5-2762:
---
Commit 358d14d379cf37defcb74f8554404cbf00e35827 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=358d14d37 ]
TAP5-2762: symbol for path to the component dependencies file
> New symbol for defining the path to the component dependencies file
> ---
>
> Key: TAP5-2762
> URL: https://issues.apache.org/jira/browse/TAP5-2762
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Thiago Henrique De Paula Figueiredo
>Priority: Major
>
> When first implemented in 5.8.3, the file was hardwired to
> {{tapestryComponentDependencies.json}} in the folder where the JVM is ran.
> This can be a limitation if you're running more than webapp in the same
> servlet container and, of course, it's nice to have it configurable.
> This ticket introduces a new configuration symbol,
> {{tapestry.component-dependency-file}}
> ({{SymbolConstants.COMPONENT_DEPENDENCY_FILE}}, with a default value of
> {{tapestryComponentDependencies.json}} to keep the existing behavior, which
> accepts a path that can be either absolute or relative to the folder where
> the JVM is running.
> In addition, this ticket adds logging about reading and writing the component
> dependency file and tweaks {{PageCatalog}} a bit regarding what to show when
> production mode is off.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2761) ResourceStreamer#streamResource(Resource, String, Set) throws NPE if providedChecksum is null
[
https://issues.apache.org/jira/browse/TAP5-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761461#comment-17761461
]
ASF subversion and git services commented on TAP5-2761:
---
Commit ca1c40375658a4da36a7792ae5c6778f6d275e12 in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=ca1c40375 ]
TAP5-2761: ResourceStreamer#streamResource documentation clarified and NPE fixed
> ResourceStreamer#streamResource(Resource, String, Set) throws NPE if
> providedChecksum is null
> -
>
> Key: TAP5-2761
> URL: https://issues.apache.org/jira/browse/TAP5-2761
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.3
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Minor
>
> The documentation of
> {{org.apache.tapestry5.internal.services.ResourceStreamer.streamResource(Resource,
> String, Set)}} states it accepts {{null}} for its second argument
> ({{providedChecksum}}, but it doesn't.
> The
> {{org.apache.tapestry5.internal.services.ResourceStreamerImpl.streamResource(StreamableResource,
> String, Set)}}, however, states that {{providedChecksum}} is
> allowed to be blank.
> The term "blank" can be understood in different ways:
> * Tools like Apache StringUtils interpret blank as "null or whitespace only"
> * Java's {{String}} class has a {{isBlank()}}, which obviously requires the
> instance to exist
> To make the behavior more obvious, the documentation should state "null or
> blank", and the underlying code should handle it accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2759) JSONObect getLongOrDefault wrong defaultValue type
[
https://issues.apache.org/jira/browse/TAP5-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761448#comment-17761448
]
ASF subversion and git services commented on TAP5-2759:
---
Commit 4ecadd1f5b762e663544c2206640640af5cd3aca in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=4ecadd1f5 ]
TAP5-2759: JSONObject#getLongOrDefault argument type fixed
> JSONObect getLongOrDefault wrong defaultValue type
> --
>
> Key: TAP5-2759
> URL: https://issues.apache.org/jira/browse/TAP5-2759
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-json
>Affects Versions: 5.8.3
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Trivial
> Fix For: 5.8.4
>
>
> The method {{public long getLongOrDefault(String name, int defaultValue)}} on
> {{org.apache.tapestry5.json.JSONObject}} should use {{long}} instead of
> {{int}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2758) Constructor/Builder injection should support @Symbol for List/Collection/Map even without @Inject
[
https://issues.apache.org/jira/browse/TAP5-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746043#comment-17746043
]
ASF subversion and git services commented on TAP5-2758:
---
Commit ae22eba41176babd78f3b6915f4f07a1eeecddd1 in tapestry-5's branch
refs/heads/TAP5-2758 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=ae22eba41 ]
TAP5-2758: Treat @Symbol as an explicit signal for injection calculation
> Constructor/Builder injection should support @Symbol for List/Collection/Map
> even without @Inject
> -
>
> Key: TAP5-2758
> URL: https://issues.apache.org/jira/browse/TAP5-2758
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
>Affects Versions: 5.8.3
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Minor
>
> If a constructor/builder method for a Service that has any type of
> configuration has also another {{{}List{}}}/{{{}Collection{}}}/{{{}Map{}}}, a
> {{RuntimeException}} gets thrown
> ({{{}org.apache.tapestry5.ioc.internal.AbstractServiceCreator{}}}:95)
> Adding @Symbol to the arguments doesn't help, it also requires {{@Inject}} to
> work.
> This behavior stems from
> {{org.apache.tapestry5.ioc.internal.util.InternalUtils.calculateInjection(Class,
> Type, Annotation[], ObjectLocator, InjectionResources)}} which analyzes
> parameters and decides "how" to inject the value.
> Symbols work because no other injection variant is found first.
> However, if the parameter is a {{{}List{}}}/{{{}Collection{}}}/{{{}Map{}}},
> it's always treated as a configuration, unless an {{@Inject}} is present.
> In my opinion, this is not the best way to handle this.
> {{@Symbol}} should be as significant as other annotations, as a symbol can't
> be target of a configuration.
> To not rely on the fallback, I propose adding a check for {{{}@Symbol{}}}.
> My local proof of concept works but also highlighted the lack of tests for
> the edge case of duplicate possible configuration parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-1733) Throw bespoke exceptions so they may be more easily identified by Error Handlers
[
https://issues.apache.org/jira/browse/TAP5-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742577#comment-17742577
]
ASF subversion and git services commented on TAP5-1733:
---
Commit 86415dac51d6082f37520dd3ab218951792c8023 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=86415dac5 ]
TAP5-1733: fixing JavaDoc
> Throw bespoke exceptions so they may be more easily identified by Error
> Handlers
>
>
> Key: TAP5-1733
> URL: https://issues.apache.org/jira/browse/TAP5-1733
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Steve Eynon
>Assignee: Volker Lamp
>Priority: Minor
> Labels: bulk-close-candidate
> Fix For: 5.8.3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Two exceptions in particular tend to be thrown prolifically by live sites
> when they are crawled by robots. They are:
> - java.lang.RuntimeException: Forms require that the request method be POST
> and that the t:formdata query parameter have values.
> - java.lang.IllegalArgumentException: Input string 'XXX' is not valid; the
> character 'X' at position X is not valid.
> To save needless reporting of benign errors (and to prevent the error logs
> from filling up) these exceptions are usually ignored by implementing Error
> Handlers. But the ErrorHandler has to currently check the exception message:
> if (e.getMessage().contains("Forms require that the request method be POST"))
> {
> doIgnore();
> }
> which is both brittle and nasty. Instead it'd be great if Tapestry could
> throw some bespoke exceptions so the above could be re-written as:
> if (e instanceof FormsRequirePostException) {
> doIngore();
> }
> Email thread below:
> http://tapestry.1045711.n5.nabble.com/Safari-for-example-browser-history-and-form-exception-td4942074.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-1733) Throw bespoke exceptions so they may be more easily identified by Error Handlers
[
https://issues.apache.org/jira/browse/TAP5-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742568#comment-17742568
]
ASF subversion and git services commented on TAP5-1733:
---
Commit 06e1c00dc7dbb35dd055d9c495ccea63904aab0d in tapestry-5's branch
refs/heads/master from Volker Lamp
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=06e1c00dc ]
TAP5-1733: Gracefully deal with FormsRequirePostException in prod mode.
> Throw bespoke exceptions so they may be more easily identified by Error
> Handlers
>
>
> Key: TAP5-1733
> URL: https://issues.apache.org/jira/browse/TAP5-1733
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Steve Eynon
>Assignee: Volker Lamp
>Priority: Minor
> Labels: bulk-close-candidate
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Two exceptions in particular tend to be thrown prolifically by live sites
> when they are crawled by robots. They are:
> - java.lang.RuntimeException: Forms require that the request method be POST
> and that the t:formdata query parameter have values.
> - java.lang.IllegalArgumentException: Input string 'XXX' is not valid; the
> character 'X' at position X is not valid.
> To save needless reporting of benign errors (and to prevent the error logs
> from filling up) these exceptions are usually ignored by implementing Error
> Handlers. But the ErrorHandler has to currently check the exception message:
> if (e.getMessage().contains("Forms require that the request method be POST"))
> {
> doIgnore();
> }
> which is both brittle and nasty. Instead it'd be great if Tapestry could
> throw some bespoke exceptions so the above could be re-written as:
> if (e instanceof FormsRequirePostException) {
> doIngore();
> }
> Email thread below:
> http://tapestry.1045711.n5.nabble.com/Safari-for-example-browser-history-and-form-exception-td4942074.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-1733) Throw bespoke exceptions so they may be more easily identified by Error Handlers
[
https://issues.apache.org/jira/browse/TAP5-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742569#comment-17742569
]
ASF subversion and git services commented on TAP5-1733:
---
Commit 166ade9bcf0bbc231c1c8b080167483f4e323047 in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=166ade9bc ]
TAP5-1733: some adjustments to avoid tapestry-core stuff in tapestry-ioc
> Throw bespoke exceptions so they may be more easily identified by Error
> Handlers
>
>
> Key: TAP5-1733
> URL: https://issues.apache.org/jira/browse/TAP5-1733
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Steve Eynon
>Assignee: Volker Lamp
>Priority: Minor
> Labels: bulk-close-candidate
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Two exceptions in particular tend to be thrown prolifically by live sites
> when they are crawled by robots. They are:
> - java.lang.RuntimeException: Forms require that the request method be POST
> and that the t:formdata query parameter have values.
> - java.lang.IllegalArgumentException: Input string 'XXX' is not valid; the
> character 'X' at position X is not valid.
> To save needless reporting of benign errors (and to prevent the error logs
> from filling up) these exceptions are usually ignored by implementing Error
> Handlers. But the ErrorHandler has to currently check the exception message:
> if (e.getMessage().contains("Forms require that the request method be POST"))
> {
> doIgnore();
> }
> which is both brittle and nasty. Instead it'd be great if Tapestry could
> throw some bespoke exceptions so the above could be re-written as:
> if (e instanceof FormsRequirePostException) {
> doIngore();
> }
> Email thread below:
> http://tapestry.1045711.n5.nabble.com/Safari-for-example-browser-history-and-form-exception-td4942074.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-1733) Throw bespoke exceptions so they may be more easily identified by Error Handlers
[
https://issues.apache.org/jira/browse/TAP5-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742567#comment-17742567
]
ASF subversion and git services commented on TAP5-1733:
---
Commit 003c5dc784c7a2e1cd7cef682bc0b9042015fc67 in tapestry-5's branch
refs/heads/TAP5-1733 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=003c5dc78 ]
TAP5-1733: some adjustments to avoid tapestry-core stuff in tapestry-ioc
> Throw bespoke exceptions so they may be more easily identified by Error
> Handlers
>
>
> Key: TAP5-1733
> URL: https://issues.apache.org/jira/browse/TAP5-1733
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Steve Eynon
>Assignee: Volker Lamp
>Priority: Minor
> Labels: bulk-close-candidate
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two exceptions in particular tend to be thrown prolifically by live sites
> when they are crawled by robots. They are:
> - java.lang.RuntimeException: Forms require that the request method be POST
> and that the t:formdata query parameter have values.
> - java.lang.IllegalArgumentException: Input string 'XXX' is not valid; the
> character 'X' at position X is not valid.
> To save needless reporting of benign errors (and to prevent the error logs
> from filling up) these exceptions are usually ignored by implementing Error
> Handlers. But the ErrorHandler has to currently check the exception message:
> if (e.getMessage().contains("Forms require that the request method be POST"))
> {
> doIgnore();
> }
> which is both brittle and nasty. Instead it'd be great if Tapestry could
> throw some bespoke exceptions so the above could be re-written as:
> if (e instanceof FormsRequirePostException) {
> doIngore();
> }
> Email thread below:
> http://tapestry.1045711.n5.nabble.com/Safari-for-example-browser-history-and-form-exception-td4942074.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2742) Smarter page cache invalidation
[ https://issues.apache.org/jira/browse/TAP5-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742240#comment-17742240 ] ASF subversion and git services commented on TAP5-2742: --- Commit 50eef37fa00fe3d159300df4a7ac0d57091b792a in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=50eef37fa ] TAP5-2742: fixing ComponentDependencyGraphvizGeneratorImpl and some Graphviz's Javadoc > Smarter page cache invalidation > --- > > Key: TAP5-2742 > URL: https://issues.apache.org/jira/browse/TAP5-2742 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Major > Fix For: 5.8.3 > > > Since Tapestry 5's inception, it throws the whole set of assembled page > instances when anything related is changed, be it the class itself, its > template and maybe also associated messages and assets. In very large > projects with large pages, this can reach a point it slows down the user > (programmer) productivity, forced to wait for unchanged pages to be > reassambled. > Tapestry should provide some way for users to segment page, component, mixin > and base classes to separate regions, one for each classloader, to avoid > clearing out cached page instances that don't have themselves or the classes > they use changed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2756) Allow developers define whether a page should be cached as a soft reference or not
[
https://issues.apache.org/jira/browse/TAP5-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742239#comment-17742239
]
ASF subversion and git services commented on TAP5-2756:
---
Commit d6c4324215337b3bfb9ed8e62dd7174e0427410d in tapestry-5's branch
refs/heads/master from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=d6c432421 ]
TAP5-2756: adding ReferenceType.forPages(String...)
> Allow developers define whether a page should be cached as a soft reference
> or not
> --
>
> Key: TAP5-2756
> URL: https://issues.apache.org/jira/browse/TAP5-2756
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Minor
> Fix For: 5.8.3
>
>
> This ticket is the result of a discussion on the Tapestry mailing list about
> the consequences of caching page instances using soft references instead of
> regular ones:
> https://lists.apache.org/thread/5qbyg0mfscg9qj6jho9899rh4r0kz97z. The goal
> here is to allow the developer to define which pages should be cached as soft
> references (the default) or regular ones.
> Usage example
> public static void contributePageCachingReferenceTypeService(
> OrderedConfiguration configuration) {
> configuration.add("VeryLarge", p -> p.equals("VeryLarge") ?
> ReferenceType.STRONG : null);
> }
> This would cause the page named VeryLarge to be cached using a
> regular, strong, non-garbage-collectable reference while leaving all
> other pages cached with a soft, garbage-collectable reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2729) Improve javadoc of ServiceBinder.bind(Class)
[ https://issues.apache.org/jira/browse/TAP5-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741763#comment-17741763 ] ASF subversion and git services commented on TAP5-2729: --- Commit 453aea8f0ba46a19ef1263f72fdf7bf209049fdd in tapestry-5's branch refs/heads/master from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=453aea8f0 ] TAP5-2729: Improve javadoc of ServiceBinder.bind(Class) > Improve javadoc of ServiceBinder.bind(Class) > > > Key: TAP5-2729 > URL: https://issues.apache.org/jira/browse/TAP5-2729 > Project: Tapestry 5 > Issue Type: Documentation > Components: tapestry-ioc >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > > What‘s missing is a description of how an interface is implicitly bound to an > implementation class if it is named …Impl.java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2708) CssCompressor update/optimizations
[ https://issues.apache.org/jira/browse/TAP5-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740910#comment-17740910 ] ASF subversion and git services commented on TAP5-2708: --- Commit 14098e6f772fd211a590247b6c8a9af8b622fc7d in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14098e6f7 ] TAP5-2708: simplified CssCompressorSpec, added test for TAP5-2600 > CssCompressor update/optimizations > -- > > Key: TAP5-2708 > URL: https://issues.apache.org/jira/browse/TAP5-2708 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-webresources >Affects Versions: 5.8.0 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > Fix For: 5.8.3 > > Time Spent: 20m > Remaining Estimate: 0h > > CssCompressor used by Tapestry is a copy of the YUI Compresser for CSS. > Minification breaks/outputs wrong content for some edge cases, and the code > in general code be optimized, like pre-compiled Patterns. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2745) Tree component with empty list of root nodes causes NullPointerException
[
https://issues.apache.org/jira/browse/TAP5-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740914#comment-17740914
]
ASF subversion and git services commented on TAP5-2745:
---
Commit 0124d8c0493c4458bad307d0c37418613d5e0397 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0124d8c04 ]
Merge branch 'TAP5-2745'
> Tree component with empty list of root nodes causes NullPointerException
>
>
> Key: TAP5-2745
> URL: https://issues.apache.org/jira/browse/TAP5-2745
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.2
>Reporter: Robert Hailey
>Assignee: Ben Weidig
>Priority: Major
> Labels: patch
> Fix For: 5.8.3
>
> Attachments: TAP5-2745-suggested-fix.patch
>
>
> An edge case, perhaps, but it seems as though attempting to create a Tree
> component with no root nodes does not produce an empty list, but throws a
> null pointer exception.
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.tapestry5.tree.TreeNode.getValue()" because "this.val$node" is
> null
> at org.apache.tapestry5.corelib.components.Tree$4.render(Tree.java:169)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:79)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:121)
> ~[tapestry-core-5.8.2.jar:?]
> {noformat}
> To the best of my understanding, the fix is straight forward:
> {noformat}
> ---
> a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> +++
> b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> @@ -265,7 +265,12 @@ public class Tree
> writer.element("ul");
> queue.push(RENDER_CLOSE_TAG);
>
> - queue.push(toRenderCommand(nodes.first(), true));
> + TreeNode first = nodes.first();
> +
> + if (first != null)
> + {
> + queue.push(toRenderCommand(first, true));
> + }
>
> nodes.rest().each(new Worker()
> {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2756) Allow developers define whether a page should be cached as a soft reference or not
[
https://issues.apache.org/jira/browse/TAP5-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740908#comment-17740908
]
ASF subversion and git services commented on TAP5-2756:
---
Commit 2c75fdbf2cb07ca926144541a41e572a48bc878c in tapestry-5's branch
refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2c75fdbf2 ]
TAP5-2756: allow non-soft references in the page cache
> Allow developers define whether a page should be cached as a soft reference
> or not
> --
>
> Key: TAP5-2756
> URL: https://issues.apache.org/jira/browse/TAP5-2756
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Minor
> Fix For: 5.8.3
>
>
> This ticket is the result of a discussion on the Tapestry mailing list about
> the consequences of caching page instances using soft references instead of
> regular ones:
> https://lists.apache.org/thread/5qbyg0mfscg9qj6jho9899rh4r0kz97z. The goal
> here is to allow the developer to define which pages should be cached as soft
> references (the default) or regular ones.
> Usage example
> public static void contributePageCachingReferenceTypeService(
> OrderedConfiguration configuration) {
> configuration.add("VeryLarge", p -> p.equals("VeryLarge") ?
> ReferenceType.STRONG : null);
> }
> This would cause the page named VeryLarge to be cached using a
> regular, strong, non-garbage-collectable reference while leaving all
> other pages cached with a soft, garbage-collectable reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740918#comment-17740918 ] ASF subversion and git services commented on TAP5-2741: --- Commit aa4a57a57c866a54902345d095157fc6d79a6de2 in tapestry-5's branch refs/heads/TAP5-2741 from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=aa4a57a57 ] TAP5-2741: First progress towards a more flexible build setup. > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740919#comment-17740919 ] ASF subversion and git services commented on TAP5-2741: --- Commit a98ba7e6ced9c20a304e4d5e77b8fc44c1d9c4b5 in tapestry-5's branch refs/heads/TAP5-2741 from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=a98ba7e6c ] Merge branch 'TAP5-2741' of g...@github.com:apache/tapestry-5.git into TAP5-2741 > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2730) Misspelt ‘ComnpressedModules’ object id
[ https://issues.apache.org/jira/browse/TAP5-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740915#comment-17740915 ] ASF subversion and git services commented on TAP5-2730: --- Commit d9ceb10d2f0618d818831a5d220a777d91939059 in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=d9ceb10d2 ] TAP5-2730: Contribution id 'ComnpressedModules' fixed > Misspelt ‘ComnpressedModules’ object id > --- > > Key: TAP5-2730 > URL: https://issues.apache.org/jira/browse/TAP5-2730 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Volker Lamp >Assignee: Ben Weidig >Priority: Trivial > > in JavaScriptModule.java:289 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2708) CssCompressor update/optimizations
[ https://issues.apache.org/jira/browse/TAP5-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740909#comment-17740909 ] ASF subversion and git services commented on TAP5-2708: --- Commit 4ffc309fc6c0b7f5c16235b2aa5a8aa1aeaada93 in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=4ffc309fc ] TAP5-2708/2753: CssCompressor updates and CSS variable fixes (#40) The CssCompressor in tapestry-webresources is now based on the latest YUI commit cf0497e. To make the original code work it needed some error fixing: - Duplicate variable declaration of "oldCss" - Faulty non-escaped regex - zeros.css test failed I'm not 100% sure the CssCompressor behaves 100% as before, but it's a necessary trade-off so it can be improved further, as the original YUI project is dead. All the pre-existing tests from YUI are now run directly in Tapestry, and we can add our own tests easily. Furthermore, the code was cleaned up with pre-compiled Patterns, and no longer converting between Strings/Readers/Writers. Co-authored-by: Volker Lamp > CssCompressor update/optimizations > -- > > Key: TAP5-2708 > URL: https://issues.apache.org/jira/browse/TAP5-2708 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-webresources >Affects Versions: 5.8.0 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > Fix For: 5.8.3 > > Time Spent: 20m > Remaining Estimate: 0h > > CssCompressor used by Tapestry is a copy of the YUI Compresser for CSS. > Minification breaks/outputs wrong content for some edge cases, and the code > in general code be optimized, like pre-compiled Patterns. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2743) PerThreadValue should provide more convenience methods
[
https://issues.apache.org/jira/browse/TAP5-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740902#comment-17740902
]
ASF subversion and git services commented on TAP5-2743:
---
Commit 9501c0fe2b983ed20de2dcd6e1dd9b612af9f877 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=9501c0fe2 ]
TAP5-2743: PerThreadValue convenience methods
> PerThreadValue should provide more convenience methods
> -
>
> Key: TAP5-2743
> URL: https://issues.apache.org/jira/browse/TAP5-2743
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Trivial
> Fix For: 5.8.3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The type org.apache.tapestry5.ioc.services.PerThreadValue should provide
> more convenience methods like Map does, e. g.:
> * {{T computeIfAbsent(Supplier fn)}}
> * {{T }}{{computeIfPresent(Function fn)}}
> * {{{}T compute{}}}{{{}(Function fn){}}}{{{}{}}}
> I believe these methods would simplify using PerThreadValue and they should
> be implementable with default methods directly on the interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2600) CSS minification breaks transition statement
[
https://issues.apache.org/jira/browse/TAP5-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740911#comment-17740911
]
ASF subversion and git services commented on TAP5-2600:
---
Commit 14098e6f772fd211a590247b6c8a9af8b622fc7d in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14098e6f7 ]
TAP5-2708: simplified CssCompressorSpec, added test for TAP5-2600
> CSS minification breaks transition statement
>
>
> Key: TAP5-2600
> URL: https://issues.apache.org/jira/browse/TAP5-2600
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-webresources
>Affects Versions: 5.4.3
>Reporter: Svein
>Assignee: Ben Weidig
>Priority: Major
> Fix For: 5.8.3
>
>
> {code:java}
> transition: all 500ms ease 0s;
> {code}
> is turned into
>
> {code:java}
> transition: all 500ms ease 0;
> {code}
> This does work in Chrome, Firefox...
>
>
> I think "transition:" need to be excluded in:
> CssCompressor:328
>
> {code:java}
> css =
> css.replaceAll("(?i)(^|[^0-9])(?:0?\\.)?0(?:px|em|in|cm|mm|pc|pt|ex|deg|g?rad|m?s|k?hz)",
> "$10");
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2739) Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and org.apache.tapestry5.ioc.internal.util.DummyLock
[ https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740916#comment-17740916 ] ASF subversion and git services commented on TAP5-2739: --- Commit 14864a28b20542e2b57d74e226919a0f66ed3092 in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14864a28b ] TAP5-2739: tapestry-ioc JDKUtils and DummyLock removed Both classes are special considerations for Java 1.5 which isn't supported since Tapestry 5.3+. Even if someone still uses the internal JDKUtils to create a lock for ThreadLocal creation, it makes sense to remove it as the DummyLock does actually nothing. > Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and > org.apache.tapestry5.ioc.internal.util.DummyLock > --- > > Key: TAP5-2739 > URL: https://issues.apache.org/jira/browse/TAP5-2739 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-ioc >Affects Versions: 5.8.2 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > > The class is a remnant from 5.3->5.4 / Java 5->6 transition. > Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is > outdated und Java 1.6 is required for Tapestry 5.4+. > In relatity, Java 8 is needed, so it makes no longer sense to have the check. > > The other method of the class, > createLockForThreadLocalCreation()), isnt used at all in Tapestry itself. > The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is > deprecated since 5.4 > > Both classes should be removed, because they don't serve any purpose. > Being in an internal package should make the removal not an issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[ https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740903#comment-17740903 ] ASF subversion and git services commented on TAP5-2749: --- Commit dca4fd046fc222ed27af9f599c8149908c9f7657 in tapestry-5's branch refs/heads/TAP5-2741 from Vladimir V. Bychkov [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=dca4fd046 ] TAP5-2749: Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy (#36) * TAP5-2749: fixing incorrect behavior of getIfExists in subclasses of SessionApplicationStatePersistenceStrategy * TAP5-2749: add integration test * TAP5-2749: use existing test aplication instead of creating new one * TAP5-2749: Simplified test. * TAP5-2749: Removed obsolete runTestApp7 task. - Co-authored-by: Volker Lamp > Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy > -- > > Key: TAP5-2749 > URL: https://issues.apache.org/jira/browse/TAP5-2749 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-jpa >Affects Versions: 5.5.0, 5.8.2 >Reporter: Vladimir V. Bychkov >Assignee: Volker Lamp >Priority: Major > Fix For: 5.8.3 > > Time Spent: 40m > Remaining Estimate: 0h > > +Error description+ > Test [project > demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error > which was added during optimization TAP5-2478. > Methods > [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57] > and > [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67] > in ApplicationStateManager work different for JPA-Entities: first works > correct, second gives ClassCastException. > +Reason+ > By invoking > [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87] > method EntityApplicationStatePersistenceStrategy.set is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70] > instanceof Entity-class to instance of PersistedEntity Class. > By Invoking ApplicationStateManager.get method > EntityApplicationStatePersistenceStrategy.get is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44] > instanceof PersistedEntity Class back to Entity-class. Therefore [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14] > works correct. > By Invoking ApplicationStateManager.getIfExists method > SessionApplicationStatePersistenceStrategy.getIfExists is used > (SessionApplicationStatePersistenceStrategy is a superclass for > EntityApplicationStatePersistenceStrategy), which > [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75] > instanceof PersistedEntity Class to Entity-class. This is incorrect and > gives ClassCastException in [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15]. > In other words, get makes back transformation, getIfExists - not. This is the > root of problem. > +Fix proposal+ > The best solution IMHO will be [restore > getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57] > in EntityApplicationStatePersistenceStrategy, may be with some optimizations > from TAP5-2478. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2739) Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and org.apache.tapestry5.ioc.internal.util.DummyLock
[ https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740917#comment-17740917 ] ASF subversion and git services commented on TAP5-2739: --- Commit 2ce6ca9a38848d903c15c6f35765541f5a6ee47f in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2ce6ca9a3 ] TAP5-2739: fix import > Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and > org.apache.tapestry5.ioc.internal.util.DummyLock > --- > > Key: TAP5-2739 > URL: https://issues.apache.org/jira/browse/TAP5-2739 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-ioc >Affects Versions: 5.8.2 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > > The class is a remnant from 5.3->5.4 / Java 5->6 transition. > Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is > outdated und Java 1.6 is required for Tapestry 5.4+. > In relatity, Java 8 is needed, so it makes no longer sense to have the check. > > The other method of the class, > createLockForThreadLocalCreation()), isnt used at all in Tapestry itself. > The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is > deprecated since 5.4 > > Both classes should be removed, because they don't serve any purpose. > Being in an internal package should make the removal not an issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2537) ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)
[
https://issues.apache.org/jira/browse/TAP5-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740904#comment-17740904
]
ASF subversion and git services commented on TAP5-2537:
---
Commit 0b1437fcaa26c5401e29a0f0e36cec7d886aea73 in tapestry-5's branch
refs/heads/TAP5-2741 from Volker Lamp
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0b1437fca ]
TAP5-2537: Added integration test to show this bug is fixed.
> ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on
> Jetty, at least)
>
>
> Key: TAP5-2537
> URL: https://issues.apache.org/jira/browse/TAP5-2537
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: I D
>Assignee: Volker Lamp
>Priority: Major
> Fix For: 5.4.1
>
>
> An IllegalStateException is thrown when calling
> ApplicationStateManagerImpl.getIfExists() on an invalid session. I would
> expect the method to catch the exception and return null in this case.
> Stack trace (top only):
> {code:java}
> -
> org.eclipse.jetty.server.session.AbstractSession.checkValid(AbstractSession.java:106)
> -
> org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:459)
> -
> org.apache.tapestry5.internal.services.SessionImpl.getAttribute(SessionImpl.java:52)
> -
> org.apache.tapestry5.internal.services.SessionApplicationStatePersistenceStrategy.exists(SessionApplicationStatePersistenceStrategy.java:80)
> - $ApplicationStatePersistenceStrategy_b43cfdb8299.exists(Unknown Source)
> -
> org.apache.tapestry5.internal.services.ApplicationStateManagerImpl$ApplicationStateAdapter.exists(ApplicationStateManagerImpl.java:60)
> -
> org.apache.tapestry5.internal.services.ApplicationStateManagerImpl.getIfExists(ApplicationStateManagerImpl.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2745) Tree component with empty list of root nodes causes NullPointerException
[
https://issues.apache.org/jira/browse/TAP5-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740912#comment-17740912
]
ASF subversion and git services commented on TAP5-2745:
---
Commit 83c24a77eeea6e79b8fbccaec465a56c535d39a8 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=83c24a77e ]
TAP5-2745: Tree component supports empty TreeModel
> Tree component with empty list of root nodes causes NullPointerException
>
>
> Key: TAP5-2745
> URL: https://issues.apache.org/jira/browse/TAP5-2745
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.2
>Reporter: Robert Hailey
>Assignee: Ben Weidig
>Priority: Major
> Labels: patch
> Fix For: 5.8.3
>
> Attachments: TAP5-2745-suggested-fix.patch
>
>
> An edge case, perhaps, but it seems as though attempting to create a Tree
> component with no root nodes does not produce an empty list, but throws a
> null pointer exception.
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.tapestry5.tree.TreeNode.getValue()" because "this.val$node" is
> null
> at org.apache.tapestry5.corelib.components.Tree$4.render(Tree.java:169)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:79)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:121)
> ~[tapestry-core-5.8.2.jar:?]
> {noformat}
> To the best of my understanding, the fix is straight forward:
> {noformat}
> ---
> a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> +++
> b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> @@ -265,7 +265,12 @@ public class Tree
> writer.element("ul");
> queue.push(RENDER_CLOSE_TAG);
>
> - queue.push(toRenderCommand(nodes.first(), true));
> + TreeNode first = nodes.first();
> +
> + if (first != null)
> + {
> + queue.push(toRenderCommand(first, true));
> + }
>
> nodes.rest().each(new Worker()
> {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2744) Selenium 3.141 can't seem to start FF 102+
[ https://issues.apache.org/jira/browse/TAP5-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740906#comment-17740906 ] ASF subversion and git services commented on TAP5-2744: --- Commit 48938d9a64239df37cbb7e2ad3c39ba196d1345e in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=48938d9a6 ] TAP5-2742: smarter page cache invalidation TAP5-2742: Initial work on smarter page cache invalidation TAP5-2742: more tests and code improvements TAP5-2742: page cache invalidation on template change working plus some additional logging for when invalidations are done and page instances created TAP5-2742: refactoring URLChangeTracker to make it parameterized TAP5-2742: work in progress for page invalidation on message file change TAP5-2742: smart page cache invalidation for message (i18n) files TAP5-2742: fixing ComponentMessagesSourceImplTest TAP5-2742: JavaDoc fixes TAP5-2744: upgrading Selenium and fixing integration tests TAP5-2744: upgrading Selenium TAP5-2744: upgrading Selenium again TAP5-2744: explicitly choosing Firefox for Selenium TAP5-2744: fixing tapestry-webresources build TAP5-2742: fixing NPE when production mode is off TAP5-2742: manual invalidation of cached pages and some error handling TAP5-2742: smarter @Import asset caching invalidation TAP5-2742: fixing changes in PageLoaderImpl, plus other changes in ComponentClassCache and PropertyConduitSourceImpl TAP5-2742: handling @InjectComponent, @InjectPage and @Component as proper dependencies between components TAP5-2742: fixing JavaDoc and NPE in ResourceChangeTrackerImpl TAP5-2742: fixing NPE in ResourceChangeTrackerImpl Trying to fix failing tests where Selenium doesn't find a link which is actually there. Attempt to get Firefox tests run on Linux with and without Snap TAP5-2742: fixing CoreBehaviorsTest.reload_from_nested_page Adding a bit of test code for our tests Adding a bit of test code for our tests (again) TAP5-2744: bug fix in ComponentClassCacheImpl TAP5-2744: better exception message parsing in RequestErrorFilter TAP5-2744: last commit before introducing a classloader tree TAP5-2744: first pass at page dependency graph TAP5-2744: eliminating a infinite recursion TAP5-2744: finished Graphviz component and PageDependencyGraph page TAP5-2744: storing component dependency information TAP5-2742: first pass at multiple classloader support for live class reloading Partial work commit for better page invalidation part 2 TAP-2742: live class reloading works, production mode doesn'r TAP-2742: production mode fixed, PageCatalog too TAP-2742: fixing JavaDoc errors Trying to fix build failure Temporarily removing tapestry-breanvalidator from the build Fixing syntax error on settings.gradle TAP-2742: fixing PageSourceImpl Reinstating tapestry-beanvalidator. TAP-2742: fixing tests in ComponentDependencyRegistryImplTest TAP-2742: code cleanup Fixing syntax error on settings.gradle again (:facepalm:) TAP-2742: fixing better class invalidation TAP-2742: fixing some Tapestry-IoC tests Trying to fix TapestryBeanValidationIntegrationTests.client_validation() TAP5-2742: fixes service implementation live class reloading Disabling WebDriver trace debugging level Turning off PageClassLoaderContextManager log at debug level TAP5-2742: fixes problems with page classes with subclasses Temporary change to a tapestry-beanvalidation TAP5-2742: forces pages to never rendered from the unknwon context TAP5-2742: fixing NestedBeanEditor test TAP5-2742: introducingtypes of dependencies Fixing a couple of tests in FormsTests Temporarily disabling the tapestry-beanvalidation build More test code improving (or workaround-ing) TAP5-2742: making method public so it works with smarter page invalidation TAP5-2742: fixing possible NPE when PCLC depends on the root context TAP5-2742: handling page dependencies better (or at least trying) TAP5-2742: specific stylig for superclass and inject page dependencies TAP5-2742: showing all dependencies, not just the already loaded pages TAP5-2742: fixing dependency file saving and loading TAP5-2742: removing commented-out code TAP5-2742: preprocessing page classloader context when possible TAP5-2742: PageClassloaderContext -> PageClassLoaderContext TAP5-2742: creating multiple classloader mode TAP5-2742: reenabling resource -> class tracking TAP5-2742: reenabling tapestry-beanvalidator TAP5-2742: component dependency and page classloader context preloading > Selenium 3.141 can't seem to start FF 102+ > -- > > Key: TAP5-2744 > URL: https://issues.apache.org/jira/browse/TAP5-2744 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-test >Reporter: Ben
[jira] [Commented] (TAP5-2757) Missing BeanModel-related migrations
[ https://issues.apache.org/jira/browse/TAP5-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740913#comment-17740913 ] ASF subversion and git services commented on TAP5-2757: --- Commit 65ed227e7f92ea076fc13408c5073f89409dad0e in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=65ed227e7 ] TAP5-2757: Missing BeanModel-related migrations > Missing BeanModel-related migrations > > > Key: TAP5-2757 > URL: https://issues.apache.org/jira/browse/TAP5-2757 > Project: Tapestry 5 > Issue Type: Bug > Components: commons, tapestry-beanmodel >Affects Versions: 5.7.0, 5.7.1, 5.7.2, 5.7.3, 5.8.0, 5.8.1, 5.8.2 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.3 > > > Thanks Christopher Dodunski for spotting this! > org.apache.tapestry5.beaneditor.BeanModel to > org.apache.tapestry5.beanmodel.BeanModel > org.apache.tapestry5.services.BeanModelSource to > org.apache.tapestry5.beanmodel.services.BeanModelSource > org.apache.tapestry5.internal.beaneditor.BeanModelUtils to > org.apache.tapestry5.beanmodel.BeanModelUtils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2742) Smarter page cache invalidation
[ https://issues.apache.org/jira/browse/TAP5-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740905#comment-17740905 ] ASF subversion and git services commented on TAP5-2742: --- Commit 48938d9a64239df37cbb7e2ad3c39ba196d1345e in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=48938d9a6 ] TAP5-2742: smarter page cache invalidation TAP5-2742: Initial work on smarter page cache invalidation TAP5-2742: more tests and code improvements TAP5-2742: page cache invalidation on template change working plus some additional logging for when invalidations are done and page instances created TAP5-2742: refactoring URLChangeTracker to make it parameterized TAP5-2742: work in progress for page invalidation on message file change TAP5-2742: smart page cache invalidation for message (i18n) files TAP5-2742: fixing ComponentMessagesSourceImplTest TAP5-2742: JavaDoc fixes TAP5-2744: upgrading Selenium and fixing integration tests TAP5-2744: upgrading Selenium TAP5-2744: upgrading Selenium again TAP5-2744: explicitly choosing Firefox for Selenium TAP5-2744: fixing tapestry-webresources build TAP5-2742: fixing NPE when production mode is off TAP5-2742: manual invalidation of cached pages and some error handling TAP5-2742: smarter @Import asset caching invalidation TAP5-2742: fixing changes in PageLoaderImpl, plus other changes in ComponentClassCache and PropertyConduitSourceImpl TAP5-2742: handling @InjectComponent, @InjectPage and @Component as proper dependencies between components TAP5-2742: fixing JavaDoc and NPE in ResourceChangeTrackerImpl TAP5-2742: fixing NPE in ResourceChangeTrackerImpl Trying to fix failing tests where Selenium doesn't find a link which is actually there. Attempt to get Firefox tests run on Linux with and without Snap TAP5-2742: fixing CoreBehaviorsTest.reload_from_nested_page Adding a bit of test code for our tests Adding a bit of test code for our tests (again) TAP5-2744: bug fix in ComponentClassCacheImpl TAP5-2744: better exception message parsing in RequestErrorFilter TAP5-2744: last commit before introducing a classloader tree TAP5-2744: first pass at page dependency graph TAP5-2744: eliminating a infinite recursion TAP5-2744: finished Graphviz component and PageDependencyGraph page TAP5-2744: storing component dependency information TAP5-2742: first pass at multiple classloader support for live class reloading Partial work commit for better page invalidation part 2 TAP-2742: live class reloading works, production mode doesn'r TAP-2742: production mode fixed, PageCatalog too TAP-2742: fixing JavaDoc errors Trying to fix build failure Temporarily removing tapestry-breanvalidator from the build Fixing syntax error on settings.gradle TAP-2742: fixing PageSourceImpl Reinstating tapestry-beanvalidator. TAP-2742: fixing tests in ComponentDependencyRegistryImplTest TAP-2742: code cleanup Fixing syntax error on settings.gradle again (:facepalm:) TAP-2742: fixing better class invalidation TAP-2742: fixing some Tapestry-IoC tests Trying to fix TapestryBeanValidationIntegrationTests.client_validation() TAP5-2742: fixes service implementation live class reloading Disabling WebDriver trace debugging level Turning off PageClassLoaderContextManager log at debug level TAP5-2742: fixes problems with page classes with subclasses Temporary change to a tapestry-beanvalidation TAP5-2742: forces pages to never rendered from the unknwon context TAP5-2742: fixing NestedBeanEditor test TAP5-2742: introducingtypes of dependencies Fixing a couple of tests in FormsTests Temporarily disabling the tapestry-beanvalidation build More test code improving (or workaround-ing) TAP5-2742: making method public so it works with smarter page invalidation TAP5-2742: fixing possible NPE when PCLC depends on the root context TAP5-2742: handling page dependencies better (or at least trying) TAP5-2742: specific stylig for superclass and inject page dependencies TAP5-2742: showing all dependencies, not just the already loaded pages TAP5-2742: fixing dependency file saving and loading TAP5-2742: removing commented-out code TAP5-2742: preprocessing page classloader context when possible TAP5-2742: PageClassloaderContext -> PageClassLoaderContext TAP5-2742: creating multiple classloader mode TAP5-2742: reenabling resource -> class tracking TAP5-2742: reenabling tapestry-beanvalidator TAP5-2742: component dependency and page classloader context preloading > Smarter page cache invalidation > --- > > Key: TAP5-2742 > URL: https://issues.apache.org/jira/browse/TAP5-2742 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Thiago Henrique De Paula Figueiredo >
[jira] [Commented] (TAP5-2755) Selenium tests don't run on Linux and snap-provided Firefox
[ https://issues.apache.org/jira/browse/TAP5-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740907#comment-17740907 ] ASF subversion and git services commented on TAP5-2755: --- Commit 114e31fa685471ca8381988ac50d194285ac6c0d in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=114e31fa6 ] TAP5-2755: fix running tests on sandboxed Firefox > Selenium tests don't run on Linux and snap-provided Firefox > --- > > Key: TAP5-2755 > URL: https://issues.apache.org/jira/browse/TAP5-2755 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.3 > > > When trying to run Selenium tests on Linux and you have Firefox provided > through snap, which runs in a sandbox without access to most other folders, > the tests fail due to not finding a Firefox profile. More information at > https://forums.parasoft.com/discussion/5682/using-selenium-with-firefox-snap-ubuntu > . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2757) Missing BeanModel-related migrations
[ https://issues.apache.org/jira/browse/TAP5-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738656#comment-17738656 ] ASF subversion and git services commented on TAP5-2757: --- Commit 65ed227e7f92ea076fc13408c5073f89409dad0e in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=65ed227e7 ] TAP5-2757: Missing BeanModel-related migrations > Missing BeanModel-related migrations > > > Key: TAP5-2757 > URL: https://issues.apache.org/jira/browse/TAP5-2757 > Project: Tapestry 5 > Issue Type: Bug > Components: commons, tapestry-beanmodel >Affects Versions: 5.7.0, 5.7.1, 5.7.2, 5.7.3, 5.8.0, 5.8.1, 5.8.2 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.3 > > > Thanks Christopher Dodunski for spotting this! > org.apache.tapestry5.beaneditor.BeanModel to > org.apache.tapestry5.beanmodel.BeanModel > org.apache.tapestry5.services.BeanModelSource to > org.apache.tapestry5.beanmodel.services.BeanModelSource > org.apache.tapestry5.internal.beaneditor.BeanModelUtils to > org.apache.tapestry5.beanmodel.BeanModelUtils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2730) Misspelt ‘ComnpressedModules’ object id
[ https://issues.apache.org/jira/browse/TAP5-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738658#comment-17738658 ] ASF subversion and git services commented on TAP5-2730: --- Commit d9ceb10d2f0618d818831a5d220a777d91939059 in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=d9ceb10d2 ] TAP5-2730: Contribution id 'ComnpressedModules' fixed > Misspelt ‘ComnpressedModules’ object id > --- > > Key: TAP5-2730 > URL: https://issues.apache.org/jira/browse/TAP5-2730 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Volker Lamp >Assignee: Ben Weidig >Priority: Trivial > > in JavaScriptModule.java:289 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2708) CssCompressor update/optimizations
[ https://issues.apache.org/jira/browse/TAP5-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738653#comment-17738653 ] ASF subversion and git services commented on TAP5-2708: --- Commit 14098e6f772fd211a590247b6c8a9af8b622fc7d in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14098e6f7 ] TAP5-2708: simplified CssCompressorSpec, added test for TAP5-2600 > CssCompressor update/optimizations > -- > > Key: TAP5-2708 > URL: https://issues.apache.org/jira/browse/TAP5-2708 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-webresources >Affects Versions: 5.8.0 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > Fix For: 5.8.3 > > Time Spent: 20m > Remaining Estimate: 0h > > CssCompressor used by Tapestry is a copy of the YUI Compresser for CSS. > Minification breaks/outputs wrong content for some edge cases, and the code > in general code be optimized, like pre-compiled Patterns. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2756) Allow developers define whether a page should be cached as a soft reference or not
[
https://issues.apache.org/jira/browse/TAP5-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738651#comment-17738651
]
ASF subversion and git services commented on TAP5-2756:
---
Commit 2c75fdbf2cb07ca926144541a41e572a48bc878c in tapestry-5's branch
refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2c75fdbf2 ]
TAP5-2756: allow non-soft references in the page cache
> Allow developers define whether a page should be cached as a soft reference
> or not
> --
>
> Key: TAP5-2756
> URL: https://issues.apache.org/jira/browse/TAP5-2756
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Minor
> Fix For: 5.8.3
>
>
> This ticket is the result of a discussion on the Tapestry mailing list about
> the consequences of caching page instances using soft references instead of
> regular ones:
> https://lists.apache.org/thread/5qbyg0mfscg9qj6jho9899rh4r0kz97z. The goal
> here is to allow the developer to define which pages should be cached as soft
> references (the default) or regular ones.
> Usage example
> public static void contributePageCachingReferenceTypeService(
> OrderedConfiguration configuration) {
> configuration.add("VeryLarge", p -> p.equals("VeryLarge") ?
> ReferenceType.STRONG : null);
> }
> This would cause the page named VeryLarge to be cached using a
> regular, strong, non-garbage-collectable reference while leaving all
> other pages cached with a soft, garbage-collectable reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2745) Tree component with empty list of root nodes causes NullPointerException
[
https://issues.apache.org/jira/browse/TAP5-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738655#comment-17738655
]
ASF subversion and git services commented on TAP5-2745:
---
Commit 83c24a77eeea6e79b8fbccaec465a56c535d39a8 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=83c24a77e ]
TAP5-2745: Tree component supports empty TreeModel
> Tree component with empty list of root nodes causes NullPointerException
>
>
> Key: TAP5-2745
> URL: https://issues.apache.org/jira/browse/TAP5-2745
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.2
>Reporter: Robert Hailey
>Assignee: Ben Weidig
>Priority: Major
> Labels: patch
> Fix For: 5.8.3
>
> Attachments: TAP5-2745-suggested-fix.patch
>
>
> An edge case, perhaps, but it seems as though attempting to create a Tree
> component with no root nodes does not produce an empty list, but throws a
> null pointer exception.
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.tapestry5.tree.TreeNode.getValue()" because "this.val$node" is
> null
> at org.apache.tapestry5.corelib.components.Tree$4.render(Tree.java:169)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:79)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:121)
> ~[tapestry-core-5.8.2.jar:?]
> {noformat}
> To the best of my understanding, the fix is straight forward:
> {noformat}
> ---
> a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> +++
> b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> @@ -265,7 +265,12 @@ public class Tree
> writer.element("ul");
> queue.push(RENDER_CLOSE_TAG);
>
> - queue.push(toRenderCommand(nodes.first(), true));
> + TreeNode first = nodes.first();
> +
> + if (first != null)
> + {
> + queue.push(toRenderCommand(first, true));
> + }
>
> nodes.rest().each(new Worker()
> {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2745) Tree component with empty list of root nodes causes NullPointerException
[
https://issues.apache.org/jira/browse/TAP5-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738657#comment-17738657
]
ASF subversion and git services commented on TAP5-2745:
---
Commit 0124d8c0493c4458bad307d0c37418613d5e0397 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0124d8c04 ]
Merge branch 'TAP5-2745'
> Tree component with empty list of root nodes causes NullPointerException
>
>
> Key: TAP5-2745
> URL: https://issues.apache.org/jira/browse/TAP5-2745
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.2
>Reporter: Robert Hailey
>Assignee: Ben Weidig
>Priority: Major
> Labels: patch
> Fix For: 5.8.3
>
> Attachments: TAP5-2745-suggested-fix.patch
>
>
> An edge case, perhaps, but it seems as though attempting to create a Tree
> component with no root nodes does not produce an empty list, but throws a
> null pointer exception.
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.tapestry5.tree.TreeNode.getValue()" because "this.val$node" is
> null
> at org.apache.tapestry5.corelib.components.Tree$4.render(Tree.java:169)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:79)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:121)
> ~[tapestry-core-5.8.2.jar:?]
> {noformat}
> To the best of my understanding, the fix is straight forward:
> {noformat}
> ---
> a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> +++
> b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> @@ -265,7 +265,12 @@ public class Tree
> writer.element("ul");
> queue.push(RENDER_CLOSE_TAG);
>
> - queue.push(toRenderCommand(nodes.first(), true));
> + TreeNode first = nodes.first();
> +
> + if (first != null)
> + {
> + queue.push(toRenderCommand(first, true));
> + }
>
> nodes.rest().each(new Worker()
> {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738661#comment-17738661 ] ASF subversion and git services commented on TAP5-2741: --- Commit aa4a57a57c866a54902345d095157fc6d79a6de2 in tapestry-5's branch refs/heads/TAP5-2741 from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=aa4a57a57 ] TAP5-2741: First progress towards a more flexible build setup. > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2739) Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and org.apache.tapestry5.ioc.internal.util.DummyLock
[ https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738660#comment-17738660 ] ASF subversion and git services commented on TAP5-2739: --- Commit 2ce6ca9a38848d903c15c6f35765541f5a6ee47f in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2ce6ca9a3 ] TAP5-2739: fix import > Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and > org.apache.tapestry5.ioc.internal.util.DummyLock > --- > > Key: TAP5-2739 > URL: https://issues.apache.org/jira/browse/TAP5-2739 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-ioc >Affects Versions: 5.8.2 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > > The class is a remnant from 5.3->5.4 / Java 5->6 transition. > Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is > outdated und Java 1.6 is required for Tapestry 5.4+. > In relatity, Java 8 is needed, so it makes no longer sense to have the check. > > The other method of the class, > createLockForThreadLocalCreation()), isnt used at all in Tapestry itself. > The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is > deprecated since 5.4 > > Both classes should be removed, because they don't serve any purpose. > Being in an internal package should make the removal not an issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2600) CSS minification breaks transition statement
[
https://issues.apache.org/jira/browse/TAP5-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738654#comment-17738654
]
ASF subversion and git services commented on TAP5-2600:
---
Commit 14098e6f772fd211a590247b6c8a9af8b622fc7d in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14098e6f7 ]
TAP5-2708: simplified CssCompressorSpec, added test for TAP5-2600
> CSS minification breaks transition statement
>
>
> Key: TAP5-2600
> URL: https://issues.apache.org/jira/browse/TAP5-2600
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-webresources
>Affects Versions: 5.4.3
>Reporter: Svein
>Assignee: Ben Weidig
>Priority: Major
> Fix For: 5.8.3
>
>
> {code:java}
> transition: all 500ms ease 0s;
> {code}
> is turned into
>
> {code:java}
> transition: all 500ms ease 0;
> {code}
> This does work in Chrome, Firefox...
>
>
> I think "transition:" need to be excluded in:
> CssCompressor:328
>
> {code:java}
> css =
> css.replaceAll("(?i)(^|[^0-9])(?:0?\\.)?0(?:px|em|in|cm|mm|pc|pt|ex|deg|g?rad|m?s|k?hz)",
> "$10");
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2741) Update to Jakarta EE 9
[ https://issues.apache.org/jira/browse/TAP5-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738662#comment-17738662 ] ASF subversion and git services commented on TAP5-2741: --- Commit a98ba7e6ced9c20a304e4d5e77b8fc44c1d9c4b5 in tapestry-5's branch refs/heads/TAP5-2741 from Volker Lamp [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=a98ba7e6c ] Merge branch 'TAP5-2741' of g...@github.com:apache/tapestry-5.git into TAP5-2741 > Update to Jakarta EE 9 > -- > > Key: TAP5-2741 > URL: https://issues.apache.org/jira/browse/TAP5-2741 > Project: Tapestry 5 > Issue Type: Dependency upgrade >Reporter: Christian Köberl >Assignee: Volker Lamp >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Tomcat and Jetty will only support Jakarta EE in their new versions. > Tapestry should also switch to the new APIs to support the new versions of > the Servlet containers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2708) CssCompressor update/optimizations
[ https://issues.apache.org/jira/browse/TAP5-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738652#comment-17738652 ] ASF subversion and git services commented on TAP5-2708: --- Commit 4ffc309fc6c0b7f5c16235b2aa5a8aa1aeaada93 in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=4ffc309fc ] TAP5-2708/2753: CssCompressor updates and CSS variable fixes (#40) The CssCompressor in tapestry-webresources is now based on the latest YUI commit cf0497e. To make the original code work it needed some error fixing: - Duplicate variable declaration of "oldCss" - Faulty non-escaped regex - zeros.css test failed I'm not 100% sure the CssCompressor behaves 100% as before, but it's a necessary trade-off so it can be improved further, as the original YUI project is dead. All the pre-existing tests from YUI are now run directly in Tapestry, and we can add our own tests easily. Furthermore, the code was cleaned up with pre-compiled Patterns, and no longer converting between Strings/Readers/Writers. Co-authored-by: Volker Lamp > CssCompressor update/optimizations > -- > > Key: TAP5-2708 > URL: https://issues.apache.org/jira/browse/TAP5-2708 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-webresources >Affects Versions: 5.8.0 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > Fix For: 5.8.3 > > Time Spent: 20m > Remaining Estimate: 0h > > CssCompressor used by Tapestry is a copy of the YUI Compresser for CSS. > Minification breaks/outputs wrong content for some edge cases, and the code > in general code be optimized, like pre-compiled Patterns. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2739) Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and org.apache.tapestry5.ioc.internal.util.DummyLock
[ https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738659#comment-17738659 ] ASF subversion and git services commented on TAP5-2739: --- Commit 14864a28b20542e2b57d74e226919a0f66ed3092 in tapestry-5's branch refs/heads/TAP5-2741 from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14864a28b ] TAP5-2739: tapestry-ioc JDKUtils and DummyLock removed Both classes are special considerations for Java 1.5 which isn't supported since Tapestry 5.3+. Even if someone still uses the internal JDKUtils to create a lock for ThreadLocal creation, it makes sense to remove it as the DummyLock does actually nothing. > Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and > org.apache.tapestry5.ioc.internal.util.DummyLock > --- > > Key: TAP5-2739 > URL: https://issues.apache.org/jira/browse/TAP5-2739 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-ioc >Affects Versions: 5.8.2 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > > The class is a remnant from 5.3->5.4 / Java 5->6 transition. > Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is > outdated und Java 1.6 is required for Tapestry 5.4+. > In relatity, Java 8 is needed, so it makes no longer sense to have the check. > > The other method of the class, > createLockForThreadLocalCreation()), isnt used at all in Tapestry itself. > The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is > deprecated since 5.4 > > Both classes should be removed, because they don't serve any purpose. > Being in an internal package should make the removal not an issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2742) Smarter page cache invalidation
[ https://issues.apache.org/jira/browse/TAP5-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738648#comment-17738648 ] ASF subversion and git services commented on TAP5-2742: --- Commit 48938d9a64239df37cbb7e2ad3c39ba196d1345e in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=48938d9a6 ] TAP5-2742: smarter page cache invalidation TAP5-2742: Initial work on smarter page cache invalidation TAP5-2742: more tests and code improvements TAP5-2742: page cache invalidation on template change working plus some additional logging for when invalidations are done and page instances created TAP5-2742: refactoring URLChangeTracker to make it parameterized TAP5-2742: work in progress for page invalidation on message file change TAP5-2742: smart page cache invalidation for message (i18n) files TAP5-2742: fixing ComponentMessagesSourceImplTest TAP5-2742: JavaDoc fixes TAP5-2744: upgrading Selenium and fixing integration tests TAP5-2744: upgrading Selenium TAP5-2744: upgrading Selenium again TAP5-2744: explicitly choosing Firefox for Selenium TAP5-2744: fixing tapestry-webresources build TAP5-2742: fixing NPE when production mode is off TAP5-2742: manual invalidation of cached pages and some error handling TAP5-2742: smarter @Import asset caching invalidation TAP5-2742: fixing changes in PageLoaderImpl, plus other changes in ComponentClassCache and PropertyConduitSourceImpl TAP5-2742: handling @InjectComponent, @InjectPage and @Component as proper dependencies between components TAP5-2742: fixing JavaDoc and NPE in ResourceChangeTrackerImpl TAP5-2742: fixing NPE in ResourceChangeTrackerImpl Trying to fix failing tests where Selenium doesn't find a link which is actually there. Attempt to get Firefox tests run on Linux with and without Snap TAP5-2742: fixing CoreBehaviorsTest.reload_from_nested_page Adding a bit of test code for our tests Adding a bit of test code for our tests (again) TAP5-2744: bug fix in ComponentClassCacheImpl TAP5-2744: better exception message parsing in RequestErrorFilter TAP5-2744: last commit before introducing a classloader tree TAP5-2744: first pass at page dependency graph TAP5-2744: eliminating a infinite recursion TAP5-2744: finished Graphviz component and PageDependencyGraph page TAP5-2744: storing component dependency information TAP5-2742: first pass at multiple classloader support for live class reloading Partial work commit for better page invalidation part 2 TAP-2742: live class reloading works, production mode doesn'r TAP-2742: production mode fixed, PageCatalog too TAP-2742: fixing JavaDoc errors Trying to fix build failure Temporarily removing tapestry-breanvalidator from the build Fixing syntax error on settings.gradle TAP-2742: fixing PageSourceImpl Reinstating tapestry-beanvalidator. TAP-2742: fixing tests in ComponentDependencyRegistryImplTest TAP-2742: code cleanup Fixing syntax error on settings.gradle again (:facepalm:) TAP-2742: fixing better class invalidation TAP-2742: fixing some Tapestry-IoC tests Trying to fix TapestryBeanValidationIntegrationTests.client_validation() TAP5-2742: fixes service implementation live class reloading Disabling WebDriver trace debugging level Turning off PageClassLoaderContextManager log at debug level TAP5-2742: fixes problems with page classes with subclasses Temporary change to a tapestry-beanvalidation TAP5-2742: forces pages to never rendered from the unknwon context TAP5-2742: fixing NestedBeanEditor test TAP5-2742: introducingtypes of dependencies Fixing a couple of tests in FormsTests Temporarily disabling the tapestry-beanvalidation build More test code improving (or workaround-ing) TAP5-2742: making method public so it works with smarter page invalidation TAP5-2742: fixing possible NPE when PCLC depends on the root context TAP5-2742: handling page dependencies better (or at least trying) TAP5-2742: specific stylig for superclass and inject page dependencies TAP5-2742: showing all dependencies, not just the already loaded pages TAP5-2742: fixing dependency file saving and loading TAP5-2742: removing commented-out code TAP5-2742: preprocessing page classloader context when possible TAP5-2742: PageClassloaderContext -> PageClassLoaderContext TAP5-2742: creating multiple classloader mode TAP5-2742: reenabling resource -> class tracking TAP5-2742: reenabling tapestry-beanvalidator TAP5-2742: component dependency and page classloader context preloading > Smarter page cache invalidation > --- > > Key: TAP5-2742 > URL: https://issues.apache.org/jira/browse/TAP5-2742 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Thiago Henrique De Paula Figueiredo >
[jira] [Commented] (TAP5-2744) Selenium 3.141 can't seem to start FF 102+
[ https://issues.apache.org/jira/browse/TAP5-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738649#comment-17738649 ] ASF subversion and git services commented on TAP5-2744: --- Commit 48938d9a64239df37cbb7e2ad3c39ba196d1345e in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=48938d9a6 ] TAP5-2742: smarter page cache invalidation TAP5-2742: Initial work on smarter page cache invalidation TAP5-2742: more tests and code improvements TAP5-2742: page cache invalidation on template change working plus some additional logging for when invalidations are done and page instances created TAP5-2742: refactoring URLChangeTracker to make it parameterized TAP5-2742: work in progress for page invalidation on message file change TAP5-2742: smart page cache invalidation for message (i18n) files TAP5-2742: fixing ComponentMessagesSourceImplTest TAP5-2742: JavaDoc fixes TAP5-2744: upgrading Selenium and fixing integration tests TAP5-2744: upgrading Selenium TAP5-2744: upgrading Selenium again TAP5-2744: explicitly choosing Firefox for Selenium TAP5-2744: fixing tapestry-webresources build TAP5-2742: fixing NPE when production mode is off TAP5-2742: manual invalidation of cached pages and some error handling TAP5-2742: smarter @Import asset caching invalidation TAP5-2742: fixing changes in PageLoaderImpl, plus other changes in ComponentClassCache and PropertyConduitSourceImpl TAP5-2742: handling @InjectComponent, @InjectPage and @Component as proper dependencies between components TAP5-2742: fixing JavaDoc and NPE in ResourceChangeTrackerImpl TAP5-2742: fixing NPE in ResourceChangeTrackerImpl Trying to fix failing tests where Selenium doesn't find a link which is actually there. Attempt to get Firefox tests run on Linux with and without Snap TAP5-2742: fixing CoreBehaviorsTest.reload_from_nested_page Adding a bit of test code for our tests Adding a bit of test code for our tests (again) TAP5-2744: bug fix in ComponentClassCacheImpl TAP5-2744: better exception message parsing in RequestErrorFilter TAP5-2744: last commit before introducing a classloader tree TAP5-2744: first pass at page dependency graph TAP5-2744: eliminating a infinite recursion TAP5-2744: finished Graphviz component and PageDependencyGraph page TAP5-2744: storing component dependency information TAP5-2742: first pass at multiple classloader support for live class reloading Partial work commit for better page invalidation part 2 TAP-2742: live class reloading works, production mode doesn'r TAP-2742: production mode fixed, PageCatalog too TAP-2742: fixing JavaDoc errors Trying to fix build failure Temporarily removing tapestry-breanvalidator from the build Fixing syntax error on settings.gradle TAP-2742: fixing PageSourceImpl Reinstating tapestry-beanvalidator. TAP-2742: fixing tests in ComponentDependencyRegistryImplTest TAP-2742: code cleanup Fixing syntax error on settings.gradle again (:facepalm:) TAP-2742: fixing better class invalidation TAP-2742: fixing some Tapestry-IoC tests Trying to fix TapestryBeanValidationIntegrationTests.client_validation() TAP5-2742: fixes service implementation live class reloading Disabling WebDriver trace debugging level Turning off PageClassLoaderContextManager log at debug level TAP5-2742: fixes problems with page classes with subclasses Temporary change to a tapestry-beanvalidation TAP5-2742: forces pages to never rendered from the unknwon context TAP5-2742: fixing NestedBeanEditor test TAP5-2742: introducingtypes of dependencies Fixing a couple of tests in FormsTests Temporarily disabling the tapestry-beanvalidation build More test code improving (or workaround-ing) TAP5-2742: making method public so it works with smarter page invalidation TAP5-2742: fixing possible NPE when PCLC depends on the root context TAP5-2742: handling page dependencies better (or at least trying) TAP5-2742: specific stylig for superclass and inject page dependencies TAP5-2742: showing all dependencies, not just the already loaded pages TAP5-2742: fixing dependency file saving and loading TAP5-2742: removing commented-out code TAP5-2742: preprocessing page classloader context when possible TAP5-2742: PageClassloaderContext -> PageClassLoaderContext TAP5-2742: creating multiple classloader mode TAP5-2742: reenabling resource -> class tracking TAP5-2742: reenabling tapestry-beanvalidator TAP5-2742: component dependency and page classloader context preloading > Selenium 3.141 can't seem to start FF 102+ > -- > > Key: TAP5-2744 > URL: https://issues.apache.org/jira/browse/TAP5-2744 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-test >Reporter: Ben
[jira] [Commented] (TAP5-2755) Selenium tests don't run on Linux and snap-provided Firefox
[ https://issues.apache.org/jira/browse/TAP5-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738650#comment-17738650 ] ASF subversion and git services commented on TAP5-2755: --- Commit 114e31fa685471ca8381988ac50d194285ac6c0d in tapestry-5's branch refs/heads/TAP5-2741 from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=114e31fa6 ] TAP5-2755: fix running tests on sandboxed Firefox > Selenium tests don't run on Linux and snap-provided Firefox > --- > > Key: TAP5-2755 > URL: https://issues.apache.org/jira/browse/TAP5-2755 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Thiago Henrique De Paula Figueiredo >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.3 > > > When trying to run Selenium tests on Linux and you have Firefox provided > through snap, which runs in a sandbox without access to most other folders, > the tests fail due to not finding a Firefox profile. More information at > https://forums.parasoft.com/discussion/5682/using-selenium-with-firefox-snap-ubuntu > . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2537) ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)
[
https://issues.apache.org/jira/browse/TAP5-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738647#comment-17738647
]
ASF subversion and git services commented on TAP5-2537:
---
Commit 0b1437fcaa26c5401e29a0f0e36cec7d886aea73 in tapestry-5's branch
refs/heads/TAP5-2741 from Volker Lamp
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0b1437fca ]
TAP5-2537: Added integration test to show this bug is fixed.
> ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on
> Jetty, at least)
>
>
> Key: TAP5-2537
> URL: https://issues.apache.org/jira/browse/TAP5-2537
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: I D
>Assignee: Volker Lamp
>Priority: Major
> Fix For: 5.4.1
>
>
> An IllegalStateException is thrown when calling
> ApplicationStateManagerImpl.getIfExists() on an invalid session. I would
> expect the method to catch the exception and return null in this case.
> Stack trace (top only):
> {code:java}
> -
> org.eclipse.jetty.server.session.AbstractSession.checkValid(AbstractSession.java:106)
> -
> org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:459)
> -
> org.apache.tapestry5.internal.services.SessionImpl.getAttribute(SessionImpl.java:52)
> -
> org.apache.tapestry5.internal.services.SessionApplicationStatePersistenceStrategy.exists(SessionApplicationStatePersistenceStrategy.java:80)
> - $ApplicationStatePersistenceStrategy_b43cfdb8299.exists(Unknown Source)
> -
> org.apache.tapestry5.internal.services.ApplicationStateManagerImpl$ApplicationStateAdapter.exists(ApplicationStateManagerImpl.java:60)
> -
> org.apache.tapestry5.internal.services.ApplicationStateManagerImpl.getIfExists(ApplicationStateManagerImpl.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[ https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738646#comment-17738646 ] ASF subversion and git services commented on TAP5-2749: --- Commit dca4fd046fc222ed27af9f599c8149908c9f7657 in tapestry-5's branch refs/heads/TAP5-2741 from Vladimir V. Bychkov [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=dca4fd046 ] TAP5-2749: Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy (#36) * TAP5-2749: fixing incorrect behavior of getIfExists in subclasses of SessionApplicationStatePersistenceStrategy * TAP5-2749: add integration test * TAP5-2749: use existing test aplication instead of creating new one * TAP5-2749: Simplified test. * TAP5-2749: Removed obsolete runTestApp7 task. - Co-authored-by: Volker Lamp > Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy > -- > > Key: TAP5-2749 > URL: https://issues.apache.org/jira/browse/TAP5-2749 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-jpa >Affects Versions: 5.5.0, 5.8.2 >Reporter: Vladimir V. Bychkov >Assignee: Volker Lamp >Priority: Major > Fix For: 5.8.3 > > Time Spent: 40m > Remaining Estimate: 0h > > +Error description+ > Test [project > demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error > which was added during optimization TAP5-2478. > Methods > [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57] > and > [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67] > in ApplicationStateManager work different for JPA-Entities: first works > correct, second gives ClassCastException. > +Reason+ > By invoking > [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87] > method EntityApplicationStatePersistenceStrategy.set is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70] > instanceof Entity-class to instance of PersistedEntity Class. > By Invoking ApplicationStateManager.get method > EntityApplicationStatePersistenceStrategy.get is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44] > instanceof PersistedEntity Class back to Entity-class. Therefore [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14] > works correct. > By Invoking ApplicationStateManager.getIfExists method > SessionApplicationStatePersistenceStrategy.getIfExists is used > (SessionApplicationStatePersistenceStrategy is a superclass for > EntityApplicationStatePersistenceStrategy), which > [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75] > instanceof PersistedEntity Class to Entity-class. This is incorrect and > gives ClassCastException in [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15]. > In other words, get makes back transformation, getIfExists - not. This is the > root of problem. > +Fix proposal+ > The best solution IMHO will be [restore > getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57] > in EntityApplicationStatePersistenceStrategy, may be with some optimizations > from TAP5-2478. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2743) PerThreadValue should provide more convenience methods
[
https://issues.apache.org/jira/browse/TAP5-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738645#comment-17738645
]
ASF subversion and git services commented on TAP5-2743:
---
Commit 9501c0fe2b983ed20de2dcd6e1dd9b612af9f877 in tapestry-5's branch
refs/heads/TAP5-2741 from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=9501c0fe2 ]
TAP5-2743: PerThreadValue convenience methods
> PerThreadValue should provide more convenience methods
> -
>
> Key: TAP5-2743
> URL: https://issues.apache.org/jira/browse/TAP5-2743
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Trivial
> Fix For: 5.8.3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The type org.apache.tapestry5.ioc.services.PerThreadValue should provide
> more convenience methods like Map does, e. g.:
> * {{T computeIfAbsent(Supplier fn)}}
> * {{T }}{{computeIfPresent(Function fn)}}
> * {{{}T compute{}}}{{{}(Function fn){}}}{{{}{}}}
> I believe these methods would simplify using PerThreadValue and they should
> be implementable with default methods directly on the interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2739) Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and org.apache.tapestry5.ioc.internal.util.DummyLock
[ https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738481#comment-17738481 ] ASF subversion and git services commented on TAP5-2739: --- Commit 2ce6ca9a38848d903c15c6f35765541f5a6ee47f in tapestry-5's branch refs/heads/master from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=2ce6ca9a3 ] TAP5-2739: fix import > Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and > org.apache.tapestry5.ioc.internal.util.DummyLock > --- > > Key: TAP5-2739 > URL: https://issues.apache.org/jira/browse/TAP5-2739 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-ioc >Affects Versions: 5.8.2 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > > The class is a remnant from 5.3->5.4 / Java 5->6 transition. > Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is > outdated und Java 1.6 is required for Tapestry 5.4+. > In relatity, Java 8 is needed, so it makes no longer sense to have the check. > > The other method of the class, > createLockForThreadLocalCreation()), isnt used at all in Tapestry itself. > The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is > deprecated since 5.4 > > Both classes should be removed, because they don't serve any purpose. > Being in an internal package should make the removal not an issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2730) Misspelt ‘ComnpressedModules’ object id
[ https://issues.apache.org/jira/browse/TAP5-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738459#comment-17738459 ] ASF subversion and git services commented on TAP5-2730: --- Commit d9ceb10d2f0618d818831a5d220a777d91939059 in tapestry-5's branch refs/heads/master from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=d9ceb10d2 ] TAP5-2730: Contribution id 'ComnpressedModules' fixed > Misspelt ‘ComnpressedModules’ object id > --- > > Key: TAP5-2730 > URL: https://issues.apache.org/jira/browse/TAP5-2730 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Volker Lamp >Assignee: Ben Weidig >Priority: Trivial > > in JavaScriptModule.java:289 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2739) Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and org.apache.tapestry5.ioc.internal.util.DummyLock
[ https://issues.apache.org/jira/browse/TAP5-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738460#comment-17738460 ] ASF subversion and git services commented on TAP5-2739: --- Commit 14864a28b20542e2b57d74e226919a0f66ed3092 in tapestry-5's branch refs/heads/master from Ben Weidig [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=14864a28b ] TAP5-2739: tapestry-ioc JDKUtils and DummyLock removed Both classes are special considerations for Java 1.5 which isn't supported since Tapestry 5.3+. Even if someone still uses the internal JDKUtils to create a lock for ThreadLocal creation, it makes sense to remove it as the DummyLock does actually nothing. > Remove org.apache.tapestry5.ioc.internal.util.JDKUtils and > org.apache.tapestry5.ioc.internal.util.DummyLock > --- > > Key: TAP5-2739 > URL: https://issues.apache.org/jira/browse/TAP5-2739 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-ioc >Affects Versions: 5.8.2 >Reporter: Ben Weidig >Assignee: Ben Weidig >Priority: Minor > > The class is a remnant from 5.3->5.4 / Java 5->6 transition. > Right now, it's only used in RegistryImpl to inform the user that JDK 1.5 is > outdated und Java 1.6 is required for Tapestry 5.4+. > In relatity, Java 8 is needed, so it makes no longer sense to have the check. > > The other method of the class, > createLockForThreadLocalCreation()), isnt used at all in Tapestry itself. > The Dummy related org.apache.tapestry5.ioc.internal.util.DummyLock is > deprecated since 5.4 > > Both classes should be removed, because they don't serve any purpose. > Being in an internal package should make the removal not an issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2745) Tree component with empty list of root nodes causes NullPointerException
[
https://issues.apache.org/jira/browse/TAP5-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736999#comment-17736999
]
ASF subversion and git services commented on TAP5-2745:
---
Commit 0124d8c0493c4458bad307d0c37418613d5e0397 in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=0124d8c04 ]
Merge branch 'TAP5-2745'
> Tree component with empty list of root nodes causes NullPointerException
>
>
> Key: TAP5-2745
> URL: https://issues.apache.org/jira/browse/TAP5-2745
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.2
>Reporter: Robert Hailey
>Assignee: Ben Weidig
>Priority: Major
> Labels: patch
> Attachments: TAP5-2745-suggested-fix.patch
>
>
> An edge case, perhaps, but it seems as though attempting to create a Tree
> component with no root nodes does not produce an empty list, but throws a
> null pointer exception.
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.tapestry5.tree.TreeNode.getValue()" because "this.val$node" is
> null
> at org.apache.tapestry5.corelib.components.Tree$4.render(Tree.java:169)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:79)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:121)
> ~[tapestry-core-5.8.2.jar:?]
> {noformat}
> To the best of my understanding, the fix is straight forward:
> {noformat}
> ---
> a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> +++
> b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> @@ -265,7 +265,12 @@ public class Tree
> writer.element("ul");
> queue.push(RENDER_CLOSE_TAG);
>
> - queue.push(toRenderCommand(nodes.first(), true));
> + TreeNode first = nodes.first();
> +
> + if (first != null)
> + {
> + queue.push(toRenderCommand(first, true));
> + }
>
> nodes.rest().each(new Worker()
> {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2745) Tree component with empty list of root nodes causes NullPointerException
[
https://issues.apache.org/jira/browse/TAP5-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736998#comment-17736998
]
ASF subversion and git services commented on TAP5-2745:
---
Commit 83c24a77eeea6e79b8fbccaec465a56c535d39a8 in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=83c24a77e ]
TAP5-2745: Tree component supports empty TreeModel
> Tree component with empty list of root nodes causes NullPointerException
>
>
> Key: TAP5-2745
> URL: https://issues.apache.org/jira/browse/TAP5-2745
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.2
>Reporter: Robert Hailey
>Assignee: Ben Weidig
>Priority: Major
> Labels: patch
> Attachments: TAP5-2745-suggested-fix.patch
>
>
> An edge case, perhaps, but it seems as though attempting to create a Tree
> component with no root nodes does not produce an empty list, but throws a
> null pointer exception.
> {noformat}
> java.lang.NullPointerException: Cannot invoke
> "org.apache.tapestry5.tree.TreeNode.getValue()" because "this.val$node" is
> null
> at org.apache.tapestry5.corelib.components.Tree$4.render(Tree.java:169)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:79)
> ~[tapestry-core-5.8.2.jar:?]
> at
> org.apache.tapestry5.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:121)
> ~[tapestry-core-5.8.2.jar:?]
> {noformat}
> To the best of my understanding, the fix is straight forward:
> {noformat}
> ---
> a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> +++
> b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
> @@ -265,7 +265,12 @@ public class Tree
> writer.element("ul");
> queue.push(RENDER_CLOSE_TAG);
>
> - queue.push(toRenderCommand(nodes.first(), true));
> + TreeNode first = nodes.first();
> +
> + if (first != null)
> + {
> + queue.push(toRenderCommand(first, true));
> + }
>
> nodes.rest().each(new Worker()
> {
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
