[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808988#comment-13808988 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - Hi, Lenny! Tapestry-JQuery datafield is a good component, but that's very different from saying that it is a good replacement for Tapestry's DateField because it would break backward compatibility in the worst way possible: only in runtime. TAP5-1845, TAP5-1998 and TAP5-2144 (which isn't actually related to DateField JS, but server-side) look easy to fix. TAP5-2203 and TAP-2003 will need a little more effort. TAP5-805 is probably fixed in 5.4 due to the way the validation works now. TAP5-2173 is a duplicate of TAP5-1998. TAP5-1799 seems already fixed in 5.4. The localization one described by Lenny in the comment above doesn't look hard to fix at first. I have no objections against having a JQueryDateField component in Tapestry out-of-the-box. What I object would be it replacing the current DateField component due to reasons I've already wrote here. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809268#comment-13809268 ] Lenny Primak commented on TAP5-2211: I just found a good one: https://issues.apache.org/jira/browse/TAP5-1845 If you look at the last comment, even Howard says that we should move to JQuery datepicker. Yes, some bugs mentioned above are closed, but they have clones / related ones that are not. I don't think any of these are indeed completely fixed in T5.4 There are lots of individual issues here, but they are all trivial to fix though. Anyway, I am willing to start by fixing all little bugs mentioned with the existing datefield, and then think about moving to the JQuery one. In the FlowLogix library, I have patches that fix all the issues for T5.3, but with T5.4 the patches no longer work, plus some of the bugs mentioned above are regressions from 5.3 http://code.google.com/p/flowlogix/wiki/TLCalendarPopupPatch Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809306#comment-13809306 ] Barry Books commented on TAP5-2211: --- I would keep an eye on this project http://angular-ui.github.io/bootstrap/ Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809425#comment-13809425 ] Lenny Primak commented on TAP5-2211: Barry, this is it! This date picker does what it needs to do: - it works well - doesn't add much after-the-fact via JavaScript - has lots of options, easy to configure - works in form-horizontal (which JQueryDatepicker doesn't) I think you've stumbled on a gold mine here Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808252#comment-13808252 ] Lenny Primak commented on TAP5-2211: Examples of this being done already are here: http://tapestry5-jquery.com/core/docsdatefield And Here: https://github.com/trsvax/tapestry-datepicker Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808338#comment-13808338 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - jQuery-UI's date picker is a good choice, but that would either 1) only be present when using the jQuery stack or 2) force the inclusion of jQuery in the Prototype stack when the DatePicker component is used. Both aren't good solutions IMHO. Is there any other good JS date picker which isn't tied to a given JS framework? Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808366#comment-13808366 ] Lenny Primak commented on TAP5-2211: I see #1 being the best option. It's not ideal but I think it's the best that can be hoped for. #2 isn't a good option to be the Tapestry default. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808428#comment-13808428 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - What I was saying was that #1 and #2 are bad solutions and that the best one would be to find a good framework-agnostic JS date picker IMHO. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808456#comment-13808456 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - I've just realized that the Autocomplete mixin already uses jQuery even when using the Prototype stack, so my opinion has changed. We still need to check whether jQuery UI's date picker supports everything the current one does, specially internationalization. If someone already did this, please let us know. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808476#comment-13808476 ] Lenny Primak commented on TAP5-2211: Quick google search revealed this: http://stackoverflow.com/questions/494958/how-do-i-localize-the-jquery-ui-datepicker Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808518#comment-13808518 ] Barry Books commented on TAP5-2211: --- I don't think it's possible to build a datepicker component that uses the jQuery datapicker and is compatible with the current Tapestry datepicker. The current datepicker makes a call back to the java side to validate the date while the jQuery datepicker does this on the client side. The current datepicker takes a DateFormat as a parameter and this causes at least two problems. First is DateFormat does not have a method to get the format string and the second is even if it did the jQuery datapicker does not use the same format as Java. Given that what's the next step? While it seems simple to build a datepicker the reality is it's complicated and even more so if you include localization. How do you get the localized date format string for both Java and jQuery datepicker? If you swap the jQuery datepicker for another one should it still work? From what I can tell different javascript datapickers have different date formats. Should it support input type='date' and work? This introduces other issues since it does not appear the date format is specified by the W3. IMHO the correct way to implement this is with textField and a mixin where the mixin provides the Javascript. The one thing that keeps this from really working is the mixin cannot set the translator in the textfield because it has a default value which makes it read only. If you could set the translator then you could do something like t:textfield t:mixins='jQueryDatePicker' data-date-format='-MM-DD' value='date'/ and make it work. I would be a big fan of allowing a mixin to overwrite a default value in a component Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808531#comment-13808531 ] Lenny Primak commented on TAP5-2211: Barry, I don't think that the problem that you mentioned here is unsolvable at all. There can be a mapping between Java and JavaScript DateFormat, and there can be a subclass of DateFormat that returns the format. The whole reason to replace Datepicker in Tapestry is so there is a modern, supported datepicker that's maintained by someone else (JQuery team) and it won't get stale or obsolete soon Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808602#comment-13808602 ] Barry Books commented on TAP5-2211: --- I'm not sure how a subclass would solve the problem. DateFormat is an interface and has no method for getting the format. As far as mapping goes I think some cases would map but I don't think you could create a general purpose mapping function. Also TextField works just fine in BeanEditor https://github.com/trsvax/tapestry-datepicker/blob/master/src/main/java/com/trsvax/datepicker/pages/AppPropertyEditBlocks.java I'm in favor of the jQuery datepicker but I don't think it's possible to build a drop in replacement with it. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808619#comment-13808619 ] Lenny Primak commented on TAP5-2211: I am not convinced that this is an unsolvable problem. Another approach is JQDateField or something like that, and have a symbol that switches the default. The current datefield situation in Tapestry now isn't workable (at least in our projects) Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808624#comment-13808624 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - Barry brings some good points, specially the component vs mixin approach one. Implementing a mapping between the SimpleDateFormat and JS date formats (which I think it would actually be the jQuery UI DatePicker one) would be another support nightmare, with probable many filed JIRA in the future. It would be solving a problem by creating another. Anyway, you're not obligated to use Tapestry's DatePicker and it's easy to override the edition block for Date fields to use whatever way of editing dates you want, as the tapestry-datepicker project source linked above proves. Maybe the better solution is to fix the Tapestry's current DatePicker instead of replacing it, but I really don't know what's the best solution for sure. Barry, actually, DateFormat is an abstract class and I guess almost all instances of it are SimpleDateFormat ones, which do have a field for getting the format (pattern). /pedantic Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808627#comment-13808627 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - I like the native browser support for date fields: http://www.html5tutorial.info/html5-date.php. There's a polyfill which provides this feature in JS if the browser itself doesn't provide it: http://afarkas.github.io/webshim/demos/demos/webforms.html. WebShim and Modernizr are both MIT-licensed, which I guess is compatible with the ASL. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808633#comment-13808633 ] Lenny Primak commented on TAP5-2211: I think in any case, tying Tapestry to a legacy datepicker that's unsupported is not the best approach. If tying a framework to a datepicker, a supported JQuery datepicker is a good way to go. At least when there are issues filed against it then JQuery people could fix it. The API for this is pretty stable as well, so that's wouldn't be an issues. I've tried using Barry's datepicker library, and it does work as advertised, but it doesn't integrate well in all cases and all layouts in bootstrap. I won't go into it further (maybe later offline) but all these problems are too complicated for ordinary users to grasp, so this should be fixed in tapestry one way or another. I do have an alternative set of issues that can make the current datepicker work, but I would prefer to fix the root of the problem and go with JQuery Datepicker. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808652#comment-13808652 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - Lenny, I don't think you understood my and Barry's point. Replacing the current date picker, bad as it is, by jQuery UI's one, good as it is, would cause a different set of problems, but we would still have problems (the Tapestry's DateField component wouldn't be backward-compatible, we'd need to work a lot on error-prone date format conversions, etc). The problem lies in in integration, not in jQuery UI's date picker itself. Again, it's trying to fix a set of problems to end up with another one. If tying Tapestry to a date picker is a problem, why don't we deprecate the current one with no out-of-the-box replacement, but some recommendations, instead? Or just fix the problems you found in tapestry-datepicker but didn't describe? This last option seems to be the best one for me so far. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808661#comment-13808661 ] Thiago H. de Paula Figueiredo commented on TAP5-2211: - Now my favorite option is native browser input type=date + Modernizr + polyfill option, which I described in https://issues.apache.org/jira/browse/TAP5-2211?focusedCommentId=13808627page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13808627. It has some advantages: it delegates our problems to the browsers who have native support and to WebShim for the ones who don't yet, and all them will do in the future, plus bringing Modernizr and polyfills (maybe some others too) to Tapestry out-of-the-box. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808701#comment-13808701 ] Barry Books commented on TAP5-2211: --- I looked at using modernizer and I don't think it supports that yet, but I think that's a good direction to head. From modernizr docs: These types can enable native datepickers, colorpickers, URL validation, and so on. If a browser doesn’t support a given type, it will be rendered as a text field. Modernizr cannot detect that date inputs create a datepicker, the color input create a colorpicker, and so on—it will detect that the input values are sanitized based on the spec. In the case of WebKit, we have received confirmation that sanitization will not be added without the UI widgets being in place. There is an issue with the jQuery datepicker and the calendar button. Ideally you could use the Bootstrap calendar icon but the jQuery datepicker does not support that. Any other problems I'd be interesting in hearing about. Just create a github issue. The datepicker I wrote is very different than the one included in Tapestry. It's much better if you want every datepicker on your site to be the same because it's more difficult to add format types. I've found this to be a feature but it's not obvious when you first use it. Oddly enough it does work better with BeanEditForm because you can easily customize it in your AppModule. You can also create datatypes that map to formats which is also a nice feature. The only real drawback is if you want to create date formats at runtime and that problem could be solved if a mixing could override the textfield translator. At this point I think Thiago's suggestion my be the best one. Deprecate the current datepicker and provide recommendations to create your own. I'm not sure it's possible to create a one size fits all datepicker. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808725#comment-13808725 ] Lenny Primak commented on TAP5-2211: Barry, Thiago, all are valid points, but from the user's perspective, it would be needlessly removing functionality, and it's not that easy, especially for a novice to figure out how to built AppBlocks, etc. Native browser date + morernizr is a fabulous idea, but the objections that were raised to JQuery date picker also apply here. Tapestry-JQuery datefield doesn't have any insurmountable problems like this, so I don't see why any of these are such a big deal. Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TAP5-2211) Replace DatePicker with JQueryUI DatePicker
[ https://issues.apache.org/jira/browse/TAP5-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808727#comment-13808727 ] Lenny Primak commented on TAP5-2211: As far as fixing old DateField, (which I could accept as an option) isn't that difficult either. Perhaps we could start with that as well There are showstopper datefield issues: https://issues.apache.org/jira/browse/TAP5-1845 https://issues.apache.org/jira/browse/TAP5-2203 https://issues.apache.org/jira/browse/TAP5-2003 https://issues.apache.org/jira/browse/TAP5-805 https://issues.apache.org/jira/browse/TAP5-1998 https://issues.apache.org/jira/browse/TAP5-2173 https://issues.apache.org/jira/browse/TAP5-2144 Plus one more (localization) to show September 2013 as opposed to 2013 September in the title: http://code.google.com/p/flowlogix/wiki/TLCalendarPopupPatch Replace DatePicker with JQueryUI DatePicker --- Key: TAP5-2211 URL: https://issues.apache.org/jira/browse/TAP5-2211 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.4 Reporter: Lenny Primak Assignee: Thiago H. de Paula Figueiredo Labels: datefield, datepicker The current 3rd party datepicker used by Tapestry is very old, and isn't very good. It's time to update it to one of the better currently-available datepickers. There are about 15 unresolved issues opened against Datepicker that can all be solved by just replacing it. I suggest JQueryUI datepicker (if JQuery is included as the default stack) The current datepicker can be left alone is prototype is chosen. By default, JQueryUI datepicker should be used with the button-to-activate option so that it looks similar to the current datepicker. It should also work properly in BeanEditor and friends and even look good with form-horizontal version of BeanEditor -- This message was sent by Atlassian JIRA (v6.1#6144)
