[jira] [Commented] (TAP5-2553) Support pseudo nested JPA transactions, injectable entity listeners and pre/post commit hooks

2017-03-29 Thread Jochen Kemnade (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948463#comment-15948463
 ] 

Jochen Kemnade commented on TAP5-2553:
--

[~kaosko], can we close this?

> Support pseudo nested JPA transactions, injectable entity listeners and 
> pre/post commit hooks
> -
>
> Key: TAP5-2553
> URL: https://issues.apache.org/jira/browse/TAP5-2553
> Project: Tapestry 5
>  Issue Type: New Feature
>  Components: tapestry-jpa
>Affects Versions: 5.4.1
>Reporter: Kalle Korhonen
>Assignee: Kalle Korhonen
>  Labels: jpa
> Fix For: 5.5.0
>
>
> Plain JPA does not support nested transaction but by keeping track of 
> @CommitAfter stack, we can support "pseudo nested" transactions. The concept 
> was first demonstrated in 
> https://github.com/satago/tapestry-jpa-transactions. @kaosko started an 
> effort to merge the codebase to T5 
> (https://github.com/satago/tapestry-jpa-transactions/pull/5) but because of 
> fundamental limitations in the original design (no support for multiple 
> persistence units, pre/post commit hooks were only available for the last 
> transaction), @kaosko refactored the implementation for more general use 
> (https://github.com/kaosko/tapestry-jpa-transactions). The original code was 
> under Apache license with support from the original authors to merge the 
> codebase to T5 and the refactored implementation was solely made by @kaosko. 
> This issue is about merging the refactored implementation to T5.5 and 
> replacing the existing JPA classes (mainly class workers, advisors) by the 
> those provided by the new implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (TAP5-2553) Support pseudo nested JPA transactions, injectable entity listeners and pre/post commit hooks

2016-06-08 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321092#comment-15321092
 ] 

Hudson commented on TAP5-2553:
--

FAILURE: Integrated in tapestry-trunk-freestyle #1577 (See 
[https://builds.apache.org/job/tapestry-trunk-freestyle/1577/])
TAP5-2553: Support pseudo nested JPA transactions etc. (kaosko: rev 
5047220cfe9a6f8a640fb10f0e3de266af51630f)
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/CommitAfterWorker.java
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/entities/ThingOne.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/NoopCreationalContext.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/NoopBeanManager.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaInternalUtils.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityTransactionManagerImpl.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/NoopInjectionTarget.java
* tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/CommitCounter.java
* tapestry-jpa/src/main/java/org/apache/tapestry5/jpa/modules/JpaModule.java
* tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/JpaTestModule.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImpl.java
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/NestedServiceImpl.java
* tapestry-jpa/src/test/java/org/example/app6/services/UserDAO.java
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/entities/VersionedThing.java
* tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/JpaTest.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/CommitAfterMethodAdvice.java
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImplTest.java
* tapestry-jpa/build.gradle
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/PersistenceContextSpecificEntityTransactionManager.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/NoopAnnotatedType.java
* tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/TopLevelService.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/TapestryCDIBeanManagerForJPAEntityListeners.java
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/TopLevelServiceImpl.java
* 
tapestry-jpa/src/main/java/org/apache/tapestry5/jpa/EntityTransactionManager.java
* tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/NestedService.java
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/entities/ThingTwo.java


> Support pseudo nested JPA transactions, injectable entity listeners and 
> pre/post commit hooks
> -
>
> Key: TAP5-2553
> URL: https://issues.apache.org/jira/browse/TAP5-2553
> Project: Tapestry 5
>  Issue Type: New Feature
>  Components: tapestry-jpa
>Affects Versions: 5.4.1
>Reporter: Kalle Korhonen
>Assignee: Kalle Korhonen
>  Labels: jpa
> Fix For: 5.5.0
>
>
> Plain JPA does not support nested transaction but by keeping track of 
> @CommitAfter stack, we can support "pseudo nested" transactions. The concept 
> was first demonstrated in 
> https://github.com/satago/tapestry-jpa-transactions. @kaosko started an 
> effort to merge the codebase to T5 
> (https://github.com/satago/tapestry-jpa-transactions/pull/5) but because of 
> fundamental limitations in the original design (no support for multiple 
> persistence units, pre/post commit hooks were only available for the last 
> transaction), @kaosko refactored the implementation for more general use 
> (https://github.com/kaosko/tapestry-jpa-transactions). The original code was 
> under Apache license with support from the original authors to merge the 
> codebase to T5 and the refactored implementation was solely made by @kaosko. 
> This issue is about merging the refactored implementation to T5.5 and 
> replacing the existing JPA classes (mainly class workers, advisors) by the 
> those provided by the new implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TAP5-2553) Support pseudo nested JPA transactions, injectable entity listeners and pre/post commit hooks

2016-06-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320940#comment-15320940
 ] 

ASF subversion and git services commented on TAP5-2553:
---

Commit 5047220cfe9a6f8a640fb10f0e3de266af51630f in tapestry-5's branch 
refs/heads/master from kaosko
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=5047220 ]

TAP5-2553: Support pseudo nested JPA transactions etc.

- add all classes from
https://github.com/kaosko/tapestry-jpa-transactions
- rename packages from net.satago.tapestry5.. to org.apache.tapestry5...
- replace code contents of all advice and worker related classes
(CommitAfterMethodAdvice, CommitAfterWorker, JpaTransactionAdvisorImpl)
with the new implementation
- manually merge relevant code from TransactionUnitsModule to JpaModule
- add new dependencies
- remove remaining net.satago. classes
- I could only make the 
JpaIntegrationTestWithAnnotationsInServiceImplementation test succeeded by 
adding the @PersistenceContext
annotations to the app6.UserDAO interface, why is that?
- reformat code according to Tapestry guidelines


> Support pseudo nested JPA transactions, injectable entity listeners and 
> pre/post commit hooks
> -
>
> Key: TAP5-2553
> URL: https://issues.apache.org/jira/browse/TAP5-2553
> Project: Tapestry 5
>  Issue Type: New Feature
>  Components: tapestry-jpa
>Affects Versions: 5.4.1
>Reporter: Kalle Korhonen
>Assignee: Kalle Korhonen
>  Labels: jpa
> Fix For: 5.5.0
>
>
> Plain JPA does not support nested transaction but by keeping track of 
> @CommitAfter stack, we can support "pseudo nested" transactions. The concept 
> was first demonstrated in 
> https://github.com/satago/tapestry-jpa-transactions. @kaosko started an 
> effort to merge the codebase to T5 
> (https://github.com/satago/tapestry-jpa-transactions/pull/5) but because of 
> fundamental limitations in the original design (no support for multiple 
> persistence units, pre/post commit hooks were only available for the last 
> transaction), @kaosko refactored the implementation for more general use 
> (https://github.com/kaosko/tapestry-jpa-transactions). The original code was 
> under Apache license with support from the original authors to merge the 
> codebase to T5 and the refactored implementation was solely made by @kaosko. 
> This issue is about merging the refactored implementation to T5.5 and 
> replacing the existing JPA classes (mainly class workers, advisors) by the 
> those provided by the new implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)