[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459603#comment-17459603 ] Hudson commented on TAP5-2690: -- SUCCESS: Integrated in Jenkins build Tapestry » tapestry-trunk-freestyle #114 (See [https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/114/]) TAP5-2690: upgrading log4j version in Quickstart (thiago: rev 7a6863875a821dd4ddaf6b5ec2b8855940bc1016) * (edit) quickstart/build.gradle > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.0 > > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459586#comment-17459586 ] Thiago Henrique De Paula Figueiredo commented on TAP5-2690: --- Great catch, [~dtimcummings]! I've just committed the version change from 2.14.1 to 2.16.0. > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.0 > > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459585#comment-17459585 ] ASF subversion and git services commented on TAP5-2690: --- Commit 7a6863875a821dd4ddaf6b5ec2b8855940bc1016 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=7a68638 ] TAP5-2690: upgrading log4j version in Quickstart to pick up the fix for the log4shell vulnerability > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.0 > > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459564#comment-17459564 ] D Tim Cummings commented on TAP5-2690: -- This quickstart uses log4j 2.14.1 which has the very serious log4shell vulnerability. Please update log4j to at least 2.16.0. > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Assignee: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.8.0 > > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436171#comment-17436171 ] Hudson commented on TAP5-2690: -- SUCCESS: Integrated in Jenkins build Tapestry » tapestry-trunk-freestyle #102 (See [https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/102/]) TAP5-2690: Spring Boot optional for quickstart (thanks @pico.dev!) (thiago: rev 28ac1aebdf09d27611d111c702266b12e10b074c) * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff2 * (edit) quickstart/src/main/resources/archetype-resources/src/main/java/pages/Error404.java * (edit) quickstart/src/main/resources/archetype-resources/src/main/resources/pages/About.tml * (edit) quickstart/src/main/resources/archetype-resources/src/main/resources/pages/Error404.tml * (add) quickstart/src/main/resources/archetype-resources/src/main/java/spring/App.java * (edit) quickstart/src/main/resources/archetype-resources/src/main/resources/components/Layout.tml * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.ttf * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/popover.js * (edit) quickstart/src/main/resources/META-INF/maven/plugin.xml * (add) quickstart/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/web.xml * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/button.js * (delete) quickstart/src/main/resources/archetype-resources/src/main/resources/application.yml * (delete) quickstart/src/main/resources/archetype-resources/src/test/groovy/tapestry/functional/LoginSpec.groovy * (delete) quickstart/src/main/resources/archetype-resources/src/test/groovy/IndexSpec.groovy * (edit) quickstart/src/main/resources/archetype-resources/src/main/resources/pages/Index.tml * (add) quickstart/src/main/resources/archetype-resources/src/test/java/tapestry/integration/pages/NavigationTest.java * (edit) quickstart/src/main/resources/archetype-resources/src/main/resources/pages/Login.tml * (add) quickstart/src/main/resources-filtered/archetype-resources/build-spring-boot.gradle * (edit) quickstart/src/main/resources/archetype-resources/src/main/java/services/AppModule.java * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.woff * (delete) quickstart/src/main/resources/archetype-resources/src/main/java/App.java * (add) quickstart/src/main/resources-filtered/archetype-resources/pom-spring-boot.xml * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/css/bootstrap.css * (add) quickstart/src/main/resources/archetype-resources/src/test/java/unit/ClassTest.java * (edit) quickstart/src/main/resources/archetype-resources/src/main/java/pages/About.java * (edit) quickstart/build.gradle * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/modal.js * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.svg * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/collapse.js * (add) quickstart/src/main/resources/archetype-resources/src/main/java/spring/AppConfiguration.java * (delete) quickstart/src/main/resources/archetype-resources/src/test/groovy/tapestry/unit/pages/NavigationSpec.groovy * (edit) quickstart/src/main/resources/archetype-resources/src/main/webapp/favicon.ico * (edit) quickstart/src/main/resources/archetype-resources/src/main/java/components/Layout.java * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/transition.js * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/alert.js * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/tab.js * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/app.properties * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/fonts/glyphicons-halflings-regular.eot * (delete) quickstart/src/main/resources/archetype-resources/src/test/groovy/tapestry/unit/pages/LoginSpec.groovy * (edit) quickstart/src/main/resources/archetype-resources/src/main/resources/pages/Index.properties * (edit) quickstart/src/main/resources-filtered/archetype-resources/build.gradle * (edit) quickstart/src/main/resources/archetype-resources/src/main/java/services/DevelopmentModule.java * (delete) quickstart/src/main/resources/archetype-resources/src/main/webapp/mybootstrap/js/scrollspy.js * (edit) quickstart/src/main/resources/archetype-resources/src/main/java/services/QaModule.java * (delete)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436142#comment-17436142 ] ASF subversion and git services commented on TAP5-2690: --- Commit 28ac1aebdf09d27611d111c702266b12e10b074c in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=28ac1ae ] TAP5-2690: Spring Boot optional for quickstart (thanks @pico.dev!) > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Priority: Minor > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409247#comment-17409247 ] D Tim Cummings commented on TAP5-2690: -- Thanks for the changes. All looks good to me. > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Priority: Minor > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408711#comment-17408711 ] picodotdev commented on TAP5-2690: -- Nice review. Updated: * Fixed the Index.tml text * Removed javax.json dependency * Get rid of the warnings about duplicate jars from jetty * Used mainClass instead deprecated mainClassName * Added UTF-8 * Included maven-enforcer-plugin * Used -release compiler option instead -source and -target https://docs.oracle.com/en/java/javase/11/tools/javac.html At the moment I dont know how to resolve Gradle warning "Specifying custom build file location has been deprecated." Provided new patch and screenshots. > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Priority: Minor > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt, > mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png, > quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408626#comment-17408626
]
D Tim Cummings commented on TAP5-2690:
--
Some more notes about pom.xml:
1. When building and running I am getting warnings about builds being platform
dependent. This can be fixed by adding the following property into
{code:java}
UTF-8
{code}
2. I notice in properties that you have but you didn't use it in
the maven-compiler-plugin. Perhaps that plugin should be configured using the
following:
{code:java}
${java.version}
${java.version}
{code}
3. I ran "mvn versions:display-plugin-updates" and got several warnings and an
error. The error said the minimum maven version should be specified and that
required by plugins is 3.5.0. This can be done using maven-enforcer-plugin.
{code:java}
org.apache.maven.plugins
maven-enforcer-plugin
1.4.1
enforce-maven
enforce
3.5.0
{code}
All in all, what you have created is looking really good. I don't know how to
get rid of the warnings about "JavaScriptModule.CoreJavaScriptStack Could not
add object with duplicate id 'tapestry.css'."
Thanks
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out.txt,
> gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt,
> mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png,
> quickstart-screenshot.png, tree.out.txt
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408577#comment-17408577
]
D Tim Cummings commented on TAP5-2690:
--
To get rid of the warnings about duplicate jars from jetty I create exclusions
in my pom.xml
{code:java}
org.apache.tapestry
tapestry-core
${tapestry-version}
compile
javax.xml.bind
jaxb-api
javax.xml.ws
jaxws-api
javax.annotation
javax.annotation-api
{code}
I also remove totally
{code:java}
{code}
You probably understand better than me whether this is a good thing to do.
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out.txt,
> gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt,
> mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png,
> quickstart-screenshot.png, tree.out.txt
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408535#comment-17408535
]
D Tim Cummings commented on TAP5-2690:
--
I am also getting deprecation warning about using -b build-spring-boot.gradle in
{code:java}
./gradlew -b build-spring-boot.gradle test{code}
but I am not sure what to do about it.
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out.txt,
> gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt,
> mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png,
> quickstart-screenshot.png, tree.out.txt
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408532#comment-17408532
]
D Tim Cummings commented on TAP5-2690:
--
Deprecation warning in 'build-spring-boot.gradle'
{code:java}
mainClass.Name = 'com.example.spring.App'{code}
should be
{code:java}
mainClass.set('com.example.spring.App'){code}
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out.txt,
> gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt,
> mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png,
> quickstart-screenshot.png, tree.out.txt
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408525#comment-17408525
]
D Tim Cummings commented on TAP5-2690:
--
While we are fixing things, text in Index.tml
{code:java}
Clink the bottom link and the page refresh with event{code}
should be
{code:java}
Click the link below and the page will refresh with event{code}
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out.txt,
> gradlew-spring-boot-run.out.txt, mvn-archetype-generate.out.txt,
> mvn-jetty-run.out.txt, quickstart-screenshot-no-browser.png,
> quickstart-screenshot.png, tree.out.txt
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[ https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408080#comment-17408080 ] picodotdev commented on TAP5-2690: -- Thanks for the review and comments. Updated: * Updated to Jetty 10 and fixed the configuration * Set Java 11 as minimun source compatibility * Fixed the test packages * Configured 404 error handler Updated de patch and output files. > Update quickstart to make Spring Boot optional > -- > > Key: TAP5-2690 > URL: https://issues.apache.org/jira/browse/TAP5-2690 > Project: Tapestry 5 > Issue Type: Improvement > Components: quickstart >Affects Versions: 5.7.3 >Reporter: picodotdev >Priority: Minor > Attachments: TAP5-2690.patch, gradlew-appRun.out.txt, > mvn-archetype-generate.out.txt, mvn-jetty-run.out.txt, > quickstart-screenshot-no-browser.png, quickstart-screenshot.png, tree.out.txt > > > On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608 > the generated app was updated to use Spring Boot. > Spring Boot is preferred to be optional, use Jetty or Tomcat as default > option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407967#comment-17407967
]
D Tim Cummings commented on TAP5-2690:
--
Jetty configuration doesn't look correct. I think is for Jetty 10 or 11
and is for jetty 8 and 9.4. Also for jetty 9.4 and 10 to
specify a port number use httpConnector
{code:java}
8080
...
{code}
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out,
> mvn-archetype-generate.out, mvn-jetty-run.out,
> quickstart-screenshot-no-browser.png, quickstart-screenshot.png, tree.out
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407900#comment-17407900
]
D Tim Cummings commented on TAP5-2690:
--
Thanks for these excellent instructions. I think you left a backslash off the
end of the line
{quote} mvn archetype:generate -B
{quote}
As I mentioned on the mailing list, I think this quickstart should be for java
11 and jetty 10, not java 8 and jetty 9.
After building the newapp project I noticed that IndexTest.java was in a folder
"com.example.tapestry.unit.pages" but the first line was "package
com.example.pages". Similarly LoginTest.java and NavigationTest.java were in
"com.example.tapestry.integration.pages" but had "package com.example.pages"
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
> Attachments: TAP5-2690.patch, gradlew-appRun.out,
> mvn-archetype-generate.out, mvn-jetty-run.out,
> quickstart-screenshot-no-browser.png, quickstart-screenshot.png, tree.out
>
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2690) Update quickstart to make Spring Boot optional
[
https://issues.apache.org/jira/browse/TAP5-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407225#comment-17407225
]
picodotdev commented on TAP5-2690:
--
Changes in the provided patch:
* Use org.eclipse.jetty:jetty-maven-plugin for start the generated app with
Maven. Uses Jetty 9 server.
* Use org.springframework.boot:spring-boot-maven-plugin for start the generated
app with Maven and Spring Boot. Uses Tomcat 9 server.
* Use org.gretty plugin for start the generated app with Gradle (in both cases,
Spring Boot and no Spring Boot). Uses Tomcat 9 (can be changed to use Jetty 9).
* Provided tow versions of pom.xml and build.gradle file, one versions does not
uses Spring Boot and the other uses Spring Boot (pom-spring-boot.xml,
build-spring-boot.gradle).
* Changed the test cases as documented in [unit-testing] and
[integration-testing] documentation pages. Droped the use of Testify, Tapestry
XPath, Groovy, Spock y Geb for example tests.
* Updated dependencies versions Gradle 7.2, Spring Boot 2.5.4 and others.
* Used Tapestry module Bootstrap4Module and removed some Bootstrap context
resources.
* Generated quickstart application is started at http://localhost:8080/.
* Provide a Maven command (mvn archetype:generate) command without require
interactivity.
* Tested with Java 11.0.12-open and Java 8.0.302-open.
* Updated Tapestry logotype image.
* tree command output provided with the directories and files generated.
[getting-started] documentation page should be updated. I attached the
quickstart commands, commands output and screenshot to update Getting Started
Guide documentation page.
There some warnings starting mvn jetty:run "javax.annotation.Generated scanned
from multiple locations" and "CoreJavaScriptStack Could not add object with
duplicate id 'tapestry.css'. The duplicate object has been ignored."
Command to generate quickstart:
{noformat}
./gradlew quickstart:build && \
mvn install:install-file -Dfile=quickstart/build/libs/quickstart-5.7.4.jar \
-DgroupId=org.apache.tapestry \
-DartifactId=quickstart \
-Dversion=5.7.4 \
-Dpackaging=jar
{noformat}
Command to use quickstart Maven archetype without interaction:
{noformat}
mvn archetype:generate -B
-DarchetypeGroupId=org.apache.tapestry \
-DarchetypeArtifactId=quickstart \
-DarchetypeVersion=5.7.4 \
-DgroupId=com.example \
-DartifactId=newapp \
-Dversion=1.0
{noformat}
Command to run quickstart app and tests with Maven:
{noformat}
mvn jetty:run
mvn test
{noformat}
Command to run quickstart app and tests with Maven and Spring Boot:
{noformat}
mvn -f pom-spring-boot.xml spring-boot:run
mvn -f pom-spring-boot.xml test
{noformat}
Command to run quickstart app and tests with Gradle:
{noformat}
chmod +x ./gradlew
./gradlew appRun
./gradlew test
./gradlew testUnitTapestry
./gradlew testIntegrationTapestry
{noformat}
Command to run quickstart app and tests with Gradle and Spring Boot:
{noformat}
chmod +x ./gradlew
./gradlew -b build-spring-boot.gradle run
./gradlew -b build-spring-boot.gradle test
./gradlew -b build-spring-boot.gradle testUnitTapestry
./gradlew -b build-spring-boot.gradle testIntegrationTapestry
{noformat}
[unit-testing]:
https://tapestry.apache.org/unit-testing-pages-or-components.html
[integration-testing]: https://tapestry.apache.org/integration-testing.html
[getting-started]: https://tapestry.apache.org/getting-started.html
> Update quickstart to make Spring Boot optional
> --
>
> Key: TAP5-2690
> URL: https://issues.apache.org/jira/browse/TAP5-2690
> Project: Tapestry 5
> Issue Type: Improvement
> Components: quickstart
>Affects Versions: 5.7.3
>Reporter: picodotdev
>Priority: Minor
>
> On the update to quickstart https://issues.apache.org/jira/browse/TAP5-2608
> the generated app was updated to use Spring Boot.
> Spring Boot is preferred to be optional, use Jetty or Tomcat as default
> option.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
