[jira] [Reopened] (TAP5-1973) :443 added to URLs when using the Link.toAbsoluteURI(true)
[
https://issues.apache.org/jira/browse/TAP5-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship reopened TAP5-1973:
Assignee: Howard M. Lewis Ship (was: Kalle Korhonen)
:443 added to URLs when using the Link.toAbsoluteURI(true)
--
Key: TAP5-1973
URL: https://issues.apache.org/jira/browse/TAP5-1973
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3.4, 5.4
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
Labels: fixed-in-5.4-js-rewrite
Fix For: 5.3.5, 5.4
An error in the code means that when secure is true and the port is set to
443, then :443 is appended:
int port = secure ? secureHostPort : hostPort;
String portSuffix = ;
if (port = 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? : : + port;
}
else if (secure port != 443) portSuffix = : + port;
else if (port != 80) portSuffix = : + port;
String hostname = .equals(this.hostname) ? request.getServerName()
: this.hostname.startsWith($) ? System.getenv(this.hostname.substring(1)) :
this.hostname;
return String.format(%s://%s%s, secure ? https : http,
hostname, portSuffix);
secure == true port != 443 is false, so
port != 80 is evaluated, it true, so
:443 is appended.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Reopened] (TAP5-1973) :443 added to URLs when using the Link.toAbsoluteURI(true)
[
https://issues.apache.org/jira/browse/TAP5-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kalle Korhonen reopened TAP5-1973:
--
Assignee: Kalle Korhonen (was: Howard M. Lewis Ship)
:443 added to URLs when using the Link.toAbsoluteURI(true)
--
Key: TAP5-1973
URL: https://issues.apache.org/jira/browse/TAP5-1973
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3.4, 5.4
Reporter: Howard M. Lewis Ship
Assignee: Kalle Korhonen
Labels: fixed-in-5.4-js-rewrite
Fix For: 5.3.5, 5.4
An error in the code means that when secure is true and the port is set to
443, then :443 is appended:
int port = secure ? secureHostPort : hostPort;
String portSuffix = ;
if (port = 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? : : + port;
}
else if (secure port != 443) portSuffix = : + port;
else if (port != 80) portSuffix = : + port;
String hostname = .equals(this.hostname) ? request.getServerName()
: this.hostname.startsWith($) ? System.getenv(this.hostname.substring(1)) :
this.hostname;
return String.format(%s://%s%s, secure ? https : http,
hostname, portSuffix);
secure == true port != 443 is false, so
port != 80 is evaluated, it true, so
:443 is appended.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
