Repository: tapestry-5 Updated Branches: refs/heads/master 030899832 -> 48d1f6409
Layout and UI improvements on the default ExceptionReport page Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/48d1f640 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/48d1f640 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/48d1f640 Branch: refs/heads/master Commit: 48d1f640911faf0116c30015f67ec359e8326f66 Parents: 0308998 Author: Howard M. Lewis Ship <hls...@apache.org> Authored: Wed Dec 31 10:55:34 2014 -0800 Committer: Howard M. Lewis Ship <hls...@apache.org> Committed: Wed Dec 31 10:55:34 2014 -0800 ---------------------------------------------------------------------- .../corelib/pages/ExceptionReport.java | 2 +- .../META-INF/assets/core/ExceptionReport.css | 4 ++++ .../tapestry5/corelib/pages/ExceptionReport.tml | 25 +++++++++----------- 3 files changed, 16 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/48d1f640/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java ---------------------------------------------------------------------- diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java index 98d0b21..8bdaf9e 100644 --- a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java +++ b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ExceptionReport.java @@ -134,7 +134,7 @@ public class ExceptionReport extends AbstractInternalPage implements ExceptionRe public boolean isShowActions() { - return failurePage != null && !request.isXHR(); + return ! productionMode && failurePage != null && !request.isXHR(); } public void reportException(Throwable exception) http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/48d1f640/tapestry-core/src/main/resources/META-INF/assets/core/ExceptionReport.css ---------------------------------------------------------------------- diff --git a/tapestry-core/src/main/resources/META-INF/assets/core/ExceptionReport.css b/tapestry-core/src/main/resources/META-INF/assets/core/ExceptionReport.css index 87fdab6..023d210 100644 --- a/tapestry-core/src/main/resources/META-INF/assets/core/ExceptionReport.css +++ b/tapestry-core/src/main/resources/META-INF/assets/core/ExceptionReport.css @@ -13,4 +13,8 @@ table.exception-report-threads tr th:last-child { table.exception-report-threads tr.active-thread { font-weight: bold; +} + +table.exception-report-threads { + font-size: small; } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/48d1f640/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/ExceptionReport.tml ---------------------------------------------------------------------- diff --git a/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/ExceptionReport.tml b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/ExceptionReport.tml index 9bd1f25..0f6dbac 100644 --- a/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/ExceptionReport.tml +++ b/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/ExceptionReport.tml @@ -40,7 +40,7 @@ <div class="panel-footer"> - <div class="btn-toolbar col-md-12"> + <div class="btn-toolbar btn-group-xs"> <t:if test="failurePage"> <t:pagelink page="prop:failurePage" class="btn btn-default">Go to page @@ -62,21 +62,19 @@ </t:actionLink> </div> </div> + <t:if test="showActions"> + <div class="panel-footer"> + <p><strong>with reload</strong>: Force a reload of component + classes. This is often necessary + after fixing a class that previously failed to compile due to errors. + </p> + </div> + </t:if> </t:if> </div> <t:if test="! productionMode"> - <t:if test="showActions"> - - <p class="help-text col-md-12"><strong>with reload</strong>: Force a reload of component - classes. This is - often - necessary - after fixing a class that previously failed to compile due to errors. - </p> - </t:if> - <t:exceptiondisplay exception="rootException"/> <h3>Request</h3> @@ -97,16 +95,15 @@ <h3>Threads</h3> <table class="table table-condensed table-hover table-striped exception-report-threads"> - <thread> + <thead> <tr> <th>Thread Name</th> <th>Group Name</th> <th>State</th> <th>Flags</th> </tr> - </thread> + </thead> <tbody> - <tr t:type="loop" source="threads" value="thread" class="${thread.className}"> <td class="thread-name">${thread.name}</td> <td>${thread.group?.name}</td>