[jira] Commented: (TAP5-566) Error in documentation for TextField component.

2009-03-10 Thread Borut Bolcina (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680423#action_12680423
 ] 

Borut Bolcina commented on TAP5-566:


But there is no 

@Property
private String cardNumber;

in the example. 

It is confusing if the Flags says Required, and the explanation says ...if not 
bound then...

 Error in documentation for TextField component.
 ---

 Key: TAP5-566
 URL: https://issues.apache.org/jira/browse/TAP5-566
 Project: Tapestry 5
  Issue Type: Bug
  Components: documentation
Affects Versions: 5.0.18
Reporter: Borut Bolcina

 At 
 http://tapestry.apache.org/tapestry5/tapestry-core/ref/org/apache/tapestry5/corelib/components/TextField.html
  there is an example for Payment.tml
 t:label for=cardNumber/:
 t:textfield t:id=cardNumber  validate=required,regexp 
 size=20/
 It is missing the required parameter value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (TAP5-557) Provide support for URL rewriting

2009-03-10 Thread Thiago H. de Paula Figueiredo (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thiago H. de Paula Figueiredo reopened TAP5-557:



Reopened because it needs to handle page link generation too. Thanks Andreas 
Andreou for warning me.

 Provide support for URL rewriting
 -

 Key: TAP5-557
 URL: https://issues.apache.org/jira/browse/TAP5-557
 Project: Tapestry 5
  Issue Type: New Feature
Affects Versions: 5.1.0.1, 5.0.18
Reporter: Thiago H. de Paula Figueiredo
Assignee: Thiago H. de Paula Figueiredo
 Fix For: 5.1.0.1


 Tapestry should provide some way, configured via Tapestry-IoC, to provide URL 
 rewriting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (TAP5-566) Error in documentation for TextField component.

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680469#action_12680469
 ] 

Howard M. Lewis Ship commented on TAP5-566:
---

It is still required, but we're saying that Tapestry can attempt to bind it for 
you. That won't always work, in which case it is an error if you neither you 
nor Tapestry can bind the parameter.

 Error in documentation for TextField component.
 ---

 Key: TAP5-566
 URL: https://issues.apache.org/jira/browse/TAP5-566
 Project: Tapestry 5
  Issue Type: Bug
  Components: documentation
Affects Versions: 5.0.18
Reporter: Borut Bolcina

 At 
 http://tapestry.apache.org/tapestry5/tapestry-core/ref/org/apache/tapestry5/corelib/components/TextField.html
  there is an example for Payment.tml
 t:label for=cardNumber/:
 t:textfield t:id=cardNumber  validate=required,regexp 
 size=20/
 It is missing the required parameter value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (TAP5-567) Create a FilesystemResource class and make AssetFactory handle it

2009-03-10 Thread Andy Pahne (JIRA)
Create a FilesystemResource class and make AssetFactory handle it
-

 Key: TAP5-567
 URL: https://issues.apache.org/jira/browse/TAP5-567
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.1.0.1
Reporter: Andy Pahne
Priority: Minor



I think T5 is missing an easy way to use filesytem resources as assets. Compare 
the thread on the mailing list:

http://markmail.org/search/?q=T5%3A+How+to+load+image+Asset+from+filesystem#query:T5%3A%20How%20to%20load%20image%20Asset%20from%20filesystem+page:1+mid:2aags27qvtzher7z+state:results

Just a suggestion: maybe it's easiest to create a Resource of type 
FilesystemResource (analogues to ContextResource and ClasspathResource) and let 
AssetFactory handle it. That way it would be possible to:

  @Inject @FilesystemProvider 
  private AssetFactory assetFactory;

  public Asset getAsset() {
 Resource iconResource = new ClasspathResource(BASE_PATH + src); 
 return  assetFactory.createAsset(iconResource); 
  }


  Or what do you think?



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (TAP5-554) NPE when click addRow within AjaxFormLoop

2009-03-10 Thread Thiago H. de Paula Figueiredo (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680501#action_12680501
 ] 

Thiago H. de Paula Figueiredo commented on TAP5-554:


A very similar exception happens when doing an AJAX form submit, so I guess 
this is not a problem just with AjaxFormLoop, but with AJAX rendering itself.

 NPE when click addRow within AjaxFormLoop
 -

 Key: TAP5-554
 URL: https://issues.apache.org/jira/browse/TAP5-554
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.1.0.0, 5.1.0.1
Reporter: Yunhua Sang
Priority: Minor

 On the screen:
 Ajax failure: Status 500 for 
 /tapestry/forminjectordemo.loop.rowinjector:inject/1236217007110?t:ac=FakePageActivationContextValuet:formcomponentid=FormInjectorDemo:formt:formid=form:
  java.lang.NullPointerException
 In console:
 ERROR] RequestExceptionHandler Processing of request failed with uncaught 
 exception: java.lang.NullPointerException
 java.lang.NullPointerException
   at 
 org.apache.tapestry5.dom.Element.createNamespaceURIToPrefix(Element.java:678)
   at org.apache.tapestry5.dom.Element.toMarkup(Element.java:335)
   at org.apache.tapestry5.dom.Element.writeChildMarkup(Element.java:872)
   at org.apache.tapestry5.dom.Element.getChildMarkup(Element.java:885)
   at 
 org.apache.tapestry5.internal.services.PageRenderQueueImpl.renderPartial(PageRenderQueueImpl.java:163)
   at 
 $PageRenderQueue_11fd441d050.renderPartial($PageRenderQueue_11fd441d050.java)
   at 
 $PageRenderQueue_11fd441d04f.renderPartial($PageRenderQueue_11fd441d04f.java)
   at 
 org.apache.tapestry5.internal.services.PartialMarkupRendererTerminator.renderMarkup(PartialMarkupRendererTerminator.java:39)
   at 
 org.apache.tapestry5.services.TapestryModule$31.renderMarkup(TapestryModule.java:1821)
   at 
 $PartialMarkupRenderer_11fd441d129.renderMarkup($PartialMarkupRenderer_11fd441d129.java)
   at 
 org.apache.tapestry5.services.TapestryModule$30.renderMarkup(TapestryModule.java:1802)
   at 
 $PartialMarkupRenderer_11fd441d129.renderMarkup($PartialMarkupRenderer_11fd441d129.java)
   at 
 org.apache.tapestry5.services.TapestryModule$29.renderMarkup(TapestryModule.java:1784)
   at 
 $PartialMarkupRenderer_11fd441d129.renderMarkup($PartialMarkupRenderer_11fd441d129.java)
   at 
 org.apache.tapestry5.services.TapestryModule$28.renderMarkup(TapestryModule.java:1766)
   at 
 $PartialMarkupRenderer_11fd441d129.renderMarkup($PartialMarkupRenderer_11fd441d129.java)
   at 
 org.apache.tapestry5.services.TapestryModule$27.renderMarkup(TapestryModule.java:1740)
   at 
 $PartialMarkupRenderer_11fd441d129.renderMarkup($PartialMarkupRenderer_11fd441d129.java)
   at 
 $PartialMarkupRenderer_11fd441d128.renderMarkup($PartialMarkupRenderer_11fd441d128.java)
   at 
 org.apache.tapestry5.internal.services.AjaxPartialResponseRendererImpl.renderPartialPageMarkup(AjaxPartialResponseRendererImpl.java:79)
   at 
 $AjaxPartialResponseRenderer_11fd441d126.renderPartialPageMarkup($AjaxPartialResponseRenderer_11fd441d126.java)
   at 
 org.apache.tapestry5.internal.services.AjaxComponentEventRequestHandler.handle(AjaxComponentEventRequestHandler.java:118)
   at 
 $ComponentEventRequestHandler_11fd441d123.handle($ComponentEventRequestHandler_11fd441d123.java)
   at 
 org.apache.tapestry5.internal.services.AjaxFilter.handle(AjaxFilter.java:42)
   at 
 $ComponentEventRequestHandler_11fd441d125.handle($ComponentEventRequestHandler_11fd441d125.java)
   at 
 org.apache.tapestry5.services.TapestryModule$35.handle(TapestryModule.java:2109)
   at 
 $ComponentEventRequestHandler_11fd441d125.handle($ComponentEventRequestHandler_11fd441d125.java)
   at 
 $ComponentEventRequestHandler_11fd441cffd.handle($ComponentEventRequestHandler_11fd441cffd.java)
   at 
 org.apache.tapestry5.internal.services.ComponentRequestHandlerTerminator.handleComponentEvent(ComponentRequestHandlerTerminator.java:43)
   at 
 $ComponentRequestHandler_11fd441cff6.handleComponentEvent($ComponentRequestHandler_11fd441cff6.java)
   at 
 org.apache.tapestry5.internal.services.ComponentEventDispatcher.dispatch(ComponentEventDispatcher.java:138)
   at $Dispatcher_11fd441cff7.dispatch($Dispatcher_11fd441cff7.java)
   at $Dispatcher_11fd441cfed.dispatch($Dispatcher_11fd441cfed.java)
   at 
 org.apache.tapestry5.services.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:246)
   at 
 org.apache.tapestry5.internal.services.RequestErrorFilter.service(RequestErrorFilter.java:26)
   at $RequestHandler_11fd441cfee.service($RequestHandler_11fd441cfee.java)
   at 
 

[jira] Closed: (TAP5-74) Provide a way that a component sub-class can merge its template with that of its container

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-74.


   Resolution: Fixed
Fix Version/s: 5.1.0.1

 Provide a way that a component sub-class can merge its template with that of 
 its container
 --

 Key: TAP5-74
 URL: https://issues.apache.org/jira/browse/TAP5-74
 Project: Tapestry 5
  Issue Type: New Feature
Affects Versions: 5.0.15
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
 Fix For: 5.1.0.1


 This is an idea I've picked up from Wicket; which has a special element, 
 similar to Tapestry t:body, but used to indicate where the child component's 
 template should go.  In Wicket, pages are often given a common LF not by the 
 use of a common component, but by extending a common base class, and mixing 
 the base class' template with the sub-class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (TAP5-568) javascript is not nor showing nor being rendered within the .html. we have a prototype and implemented the same things?

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680556#action_12680556
 ] 

Howard M. Lewis Ship commented on TAP5-568:
---

Oops.  This is a Tapestry 4 bug!


 javascript is not nor showing nor being rendered within the .html. we have a 
 prototype and implemented the same things?
 ---

 Key: TAP5-568
 URL: https://issues.apache.org/jira/browse/TAP5-568
 Project: Tapestry 5
  Issue Type: Bug
  Components: JavaScript
 Environment: OS: WindowsXP
 Server: JBoss
 IDE: Eclipse
 Tapestry: version 3.0.3
 Java: J2re1.4.2_16
Reporter: Frederick Gaetos
   Original Estimate: 120h
  Remaining Estimate: 120h

 Here's what happened:
 We're going to implement a component based javascript within our tapestry 
 project (big project).
 We have two projects.
 1.)Prototype HelloWorld Tapestry project that was able to produce Hello 
 World message that is invoked by javascript. (this thing worked!)
 2.) Second was a project where we are going to implement the same scenario 
 wherein a button will invoke a page. And when the said page is rendered, it 
 will also display a Hello World since it has the same javascript 
 implementation similar with project number one (Prototype HelloWorld 
 Tapestry Project).
 The Prototype HelloWorld Tapestry project is made for the purpose of 
 implementing component based javascript within an expert system project.
 ...However, for some reasons it did NOT worked... 
 Thus, No script tag was rendered within the second scenario/ Project.
 Please see more of the details and explanation below.
 here's the prototype:
 html 
 codes:==
 !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN 
 http://www.w3.org/TR/html4/strict.dtd; 
 html
   head 
   script jwcid=searchScript language=JavaScript 
 type=text/javascript/
   titleWelcome to Tapestry!/title 
   /head 
   body onload=Javascript:Hello() topmargin=0
   h2Welcome to Tapestry!/h2 
   form action= jwcid=loginForm 
   p   User Name: input type=text jwcid=uname / 
   br/ Password: input type=password jwcid=password /
   br/ input type=submit value=Let me in!//p 
   /form 
   /body 
 /html
 Home.page 
 codes:=
 ?xml version=1.0 encoding=UTF-8?
 !DOCTYPE page-specification PUBLIC
   -//Apache Software Foundation//Tapestry Specification 3.0//EN
   http://jakarta.apache.org/tapestry/dtd/Tapestry_3_0.dtd;
 !-- generated by Spindle, http://spindle.sourceforge.net --
 page-specification class=com.scc.mytapestry.Home
 descriptionLogin page/description
 property-specification name=uname type=java.lang.String/
 property-specification name=password type=java.lang.String/
component id=loginForm type=Form 
  binding name=listener expression=listeners.onFormSubmit/ 
/component 
component id=uname type=TextField 
  binding name=value expression=uname/ 
/component 
component id=password type=TextField 
  binding name=value expression=password/ 
  static-binding name=hidden value=true/ 
/component 
  context-asset name=search_js path=/script/searchForm.js/
  component id=searchScript type=Any
   static-binding name=element value=script/
 binding name=src expression=assets.search_js/
  /component
 /page-specification
 =
 HelloWorld.js 
 codes:=
 onload=function(){
   alert('Hello World');
 }
 =
 Here is how our page has been 
 rendered:==
 !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN 
http://www.w3.org/TR/html4/strict.dtd; 
 html 
   head 
   script src=/Login/script/searchForm.js language=JavaScript 
 type=text/javascript/script
   titleWelcome to Tapestry!/title 
   /head 
 body onload=Javascript:Hello() topmargin=0
   h2Welcome to Tapestry!/h2 form method=post name=Form0 
 action=/Login/app
   input type=hidden name=service value=direct/0/Home/loginForm/
   input type=hidden name=sp value=S0/
   input type=hidden name=Form0 value=uname,password/
   pUser Name: input type=text name=uname/br/ 
   Password: input type=password name=password/br/ 
   input type=submit value=Let me in!//p /form
   /body 
 /html
 

svn commit: r752192 - /tapestry/tapestry5/trunk/pom.xml

2009-03-10 Thread hlship
Author: hlship
Date: Tue Mar 10 17:55:47 2009
New Revision: 752192

URL: http://svn.apache.org/viewvc?rev=752192view=rev
Log:
Remove the tapestry-webflow module until 5.2.

Modified:
tapestry/tapestry5/trunk/pom.xml

Modified: tapestry/tapestry5/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/pom.xml?rev=752192r1=752191r2=752192view=diff
==
--- tapestry/tapestry5/trunk/pom.xml (original)
+++ tapestry/tapestry5/trunk/pom.xml Tue Mar 10 17:55:47 2009
@@ -159,7 +159,10 @@
 !-- Tutorials --
 
 moduletapestry-tutorial1/module
+
+!-- Temporarily removed until 5.2
 moduletapestry-webflow/module
+--
 
 /modules
 




[jira] Commented: (TAP5-59) Tracking issue for Tapestry/Spring Web Flow integration

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680564#action_12680564
 ] 

Howard M. Lewis Ship commented on TAP5-59:
--

This is on hold until 5.2.

 Tracking issue for Tapestry/Spring Web Flow integration
 ---

 Key: TAP5-59
 URL: https://issues.apache.org/jira/browse/TAP5-59
 Project: Tapestry 5
  Issue Type: New Feature
Affects Versions: 5.0.15
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship

 This will encompass a new module, tapestry-webflow  (not tapestry-swf, since 
 that looks like it's related to Flash).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (TAP5-418) More flexible Link URI manipulation for use in LinkCreationListener

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship reassigned TAP5-418:
-

Assignee: Howard M. Lewis Ship

 More flexible Link URI manipulation for use in LinkCreationListener
 ---

 Key: TAP5-418
 URL: https://issues.apache.org/jira/browse/TAP5-418
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.1
Reporter: Joost Schouten
Assignee: Howard M. Lewis Ship

 I would like to propose an extension of the Link interface with a 
 setAbsoluteURI(String absoluteURI) method, or something alike. This will give 
 more flexibility when handling the link in the LinkCreationListener.
 In my usecase, where I need the locale of the browser displayed as the first 
 part of the URI (eg http://domain.com/en_US/myPage), I use a dispatcher to 
 detect the locale (or change to it), and have to completely copy the 
 LinkFactoryImpl into my own LocaleAwareLinkFactory (which gets contributed as 
 an alias) to be able to set the URI to what I want on Link instantiation. If 
 I can change the URI at a later stage I only need to add my own 
 LinkCreationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (TAP5-418) Control over creation of page render and component event requests should be encapsulated into an overridable service

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship updated TAP5-418:
--

Summary: Control over creation of page render and component event requests 
should be encapsulated into an overridable service  (was: More flexible Link 
URI manipulation for use in LinkCreationListener)

A new public service that encapsulates building the component event request 
path and the page render request path and parsing an incoming request path to 
extract the necessary details.

 Control over creation of page render and component event requests should be 
 encapsulated into an overridable service
 

 Key: TAP5-418
 URL: https://issues.apache.org/jira/browse/TAP5-418
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.1
Reporter: Joost Schouten
Assignee: Howard M. Lewis Ship

 I would like to propose an extension of the Link interface with a 
 setAbsoluteURI(String absoluteURI) method, or something alike. This will give 
 more flexibility when handling the link in the LinkCreationListener.
 In my usecase, where I need the locale of the browser displayed as the first 
 part of the URI (eg http://domain.com/en_US/myPage), I use a dispatcher to 
 detect the locale (or change to it), and have to completely copy the 
 LinkFactoryImpl into my own LocaleAwareLinkFactory (which gets contributed as 
 an alias) to be able to set the URI to what I want on Link instantiation. If 
 I can change the URI at a later stage I only need to add my own 
 LinkCreationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r752313 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/internal/services/ main/java/org/apache/tapestry5/services/ main/java/org/apache/tapestry5/urlrewri

2009-03-10 Thread thiagohp
Author: thiagohp
Date: Wed Mar 11 00:16:27 2009
New Revision: 752313

URL: http://svn.apache.org/viewvc?rev=752313view=rev
Log:
TAP5-557: some refactorings and copyright fixes.

Added:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilter.java
   (contents, props changed)
  - copied, changed from r751937, 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilter.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilterTest.java
   (contents, props changed)
  - copied, changed from r751937, 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilterTest.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/services/DelegatingRequest.java
Removed:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilter.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilterTest.java
Modified:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/SimpleRequestWrapper.java

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/URLRewriterRule.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app3/pages/URLRewriteSuccess.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/urlrewriter/IntegrationTests.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/urlrewriter/SimpleRequestWrapperTest.java

Copied: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilter.java
 (from r751937, 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilter.java)
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilter.java?p2=tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilter.javap1=tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilter.javar1=751937r2=752313rev=752313view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/urlrewriter/URLRewriterRequestFilter.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilter.java
 Wed Mar 11 00:16:27 2009
@@ -1,4 +1,4 @@
-// Copyright 2006, 2007, 2008, 2009 The Apache Software Foundation
+// Copyright 2009 The Apache Software Foundation
 //
 // Licensed under the Apache License, Version 2.0 (the License);
 // you may not use this file except in compliance with the License.
@@ -11,7 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-package org.apache.tapestry5.urlrewriter;
+package org.apache.tapestry5.internal.services;
 
 import java.io.IOException;
 import java.util.List;
@@ -21,6 +21,7 @@
 import org.apache.tapestry5.services.RequestFilter;
 import org.apache.tapestry5.services.RequestHandler;
 import org.apache.tapestry5.services.Response;
+import org.apache.tapestry5.urlrewriter.URLRewriterRule;
 
 /**
  * codeRequestFilter/code that applies the URL rewriting rules to requests.
@@ -54,8 +55,8 @@
 request = rule.process(request);
 if (request == null) 
 { 
-throw new RuntimeException(
-URLRewriterRule.process() returned null); 
+throw new NullPointerException(
+URLRewriterRule.process() returned null.); 
 }
 
 }

Propchange: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/URLRewriterRequestFilter.java
--
svn:mergeinfo = 

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=752313r1=752312r2=752313view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
 (original)
+++ 

[jira] Closed: (TAP5-418) Control over creation of page render and component event requests should be encapsulated into an overridable service

2009-03-10 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-418.
-

   Resolution: Fixed
Fix Version/s: 5.1.0.1

 Control over creation of page render and component event requests should be 
 encapsulated into an overridable service
 

 Key: TAP5-418
 URL: https://issues.apache.org/jira/browse/TAP5-418
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.1
Reporter: Joost Schouten
Assignee: Howard M. Lewis Ship
 Fix For: 5.1.0.1


 I would like to propose an extension of the Link interface with a 
 setAbsoluteURI(String absoluteURI) method, or something alike. This will give 
 more flexibility when handling the link in the LinkCreationListener.
 In my usecase, where I need the locale of the browser displayed as the first 
 part of the URI (eg http://domain.com/en_US/myPage), I use a dispatcher to 
 detect the locale (or change to it), and have to completely copy the 
 LinkFactoryImpl into my own LocaleAwareLinkFactory (which gets contributed as 
 an alias) to be able to set the URI to what I want on Link instantiation. If 
 I can change the URI at a later stage I only need to add my own 
 LinkCreationListener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r752328 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/services/DelegatingRequest.java test/java/org/apache/tapestry5/services/DelegatingRequest.java

2009-03-10 Thread thiagohp
Author: thiagohp
Date: Wed Mar 11 00:55:11 2009
New Revision: 752328

URL: http://svn.apache.org/viewvc?rev=752328view=rev
Log:
TAP5-557: moved DelegatingRequest from src/test to src/main.

Added:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/DelegatingRequest.java
   (props changed)
  - copied unchanged from r752313, 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/services/DelegatingRequest.java
Removed:

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/services/DelegatingRequest.java

Propchange: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/DelegatingRequest.java
--
svn:mergeinfo =