thrift git commit: THRIFT-4130: Release connection back to managed pool. Client: C++

[jking]

Repository: thrift
Updated Branches:
  refs/heads/master 847fae938 -> 6c08ac72c


THRIFT-4130: Release connection back to managed pool.
Client: C++

This closes #1212


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/6c08ac72
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/6c08ac72
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/6c08ac72

Branch: refs/heads/master
Commit: 6c08ac72c6ce9faf66bf28ee75cbb87413daa6aa
Parents: 847fae9
Author: Jonathan Pearlin 
Authored: Sat Mar 11 09:46:03 2017 -0800
Committer: James E. King, III 
Committed: Wed Mar 22 20:33:20 2017 -0400

--
 lib/java/src/org/apache/thrift/transport/THttpClient.java | 3 +++
 1 file changed, 3 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/thrift/blob/6c08ac72/lib/java/src/org/apache/thrift/transport/THttpClient.java
--
diff --git a/lib/java/src/org/apache/thrift/transport/THttpClient.java 
b/lib/java/src/org/apache/thrift/transport/THttpClient.java
index 5a5b37c..c3063fe 100644
--- a/lib/java/src/org/apache/thrift/transport/THttpClient.java
+++ b/lib/java/src/org/apache/thrift/transport/THttpClient.java
@@ -304,6 +304,9 @@ public class THttpClient extends TTransport {
   throw new TTransportException(ioe);
 }
   }
+  if (post != null) {
+post.releaseConnection();
+  }
 }
   }
 

thrift git commit: THRIFT-3959: document that the go simple server is not simple Client: go Patch: JodeZer <jeffery1...@hotmail.com>

[jking]

Repository: thrift
Updated Branches:
  refs/heads/master bf9b6970b -> 847fae938


THRIFT-3959: document that the go simple server is not simple
Client: go
Patch: JodeZer 

This closes #1213


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/847fae93
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/847fae93
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/847fae93

Branch: refs/heads/master
Commit: 847fae9388048aa9e09d5ed042e34f5452638248
Parents: bf9b697
Author: James E. King, III 
Authored: Wed Mar 22 15:17:30 2017 -0400
Committer: James E. King, III 
Committed: Wed Mar 22 15:17:30 2017 -0400

--
 lib/go/thrift/simple_server.go | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/thrift/blob/847fae93/lib/go/thrift/simple_server.go
--
diff --git a/lib/go/thrift/simple_server.go b/lib/go/thrift/simple_server.go
index 4097c4a..5d05c5b 100644
--- a/lib/go/thrift/simple_server.go
+++ b/lib/go/thrift/simple_server.go
@@ -25,7 +25,11 @@ import (
"sync"
 )
 
-// Simple, non-concurrent server for testing.
+/*
+ * This is not a typical TSimpleServer as it is not blocked after accept a 
socket.
+ * It is more like a TThreadedServer that can handle different connections in 
different goroutines.
+ * This will work if golang user implements a conn-pool like thing in client 
side.
+ */
 type TSimpleServer struct {
quit chan struct{}
 

[1/2] thrift git commit: THRIFT-4129: Fix fd leak when failing to dispatch new connections Client: C++

[jking]

Repository: thrift
Updated Branches:
  refs/heads/master e576b26e3 -> bf9b6970b


THRIFT-4129: Fix fd leak when failing to dispatch new connections
Client: C++

This closes #1210


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/75386db8
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/75386db8
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/75386db8

Branch: refs/heads/master
Commit: 75386db8c0eaba39ec5ad374cba27e039d2493e2
Parents: e576b26
Author: Changli Gao 
Authored: Fri Mar 10 13:15:37 2017 +0800
Committer: James E. King, III 
Committed: Wed Mar 22 15:03:37 2017 -0400

--
 lib/cpp/src/thrift/server/TNonblockingServer.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/thrift/blob/75386db8/lib/cpp/src/thrift/server/TNonblockingServer.cpp
--
diff --git a/lib/cpp/src/thrift/server/TNonblockingServer.cpp 
b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
index d4418bd..2cf64f8 100644
--- a/lib/cpp/src/thrift/server/TNonblockingServer.cpp
+++ b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
@@ -1004,7 +1004,7 @@ void TNonblockingServer::handleEvent(THRIFT_SOCKET fd, 
short which) {
 } else {
   if (!clientConnection->notifyIOThread()) {
 GlobalOutput.perror("[ERROR] notifyIOThread failed on fresh 
connection, closing", errno);
-returnConnection(clientConnection);
+clientConnection->close();
   }
 }
 

[2/2] thrift git commit: THRIFT-4081 broke compiling with gcc 4.6.x

[jking]

THRIFT-4081 broke compiling with gcc 4.6.x


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/bf9b6970
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/bf9b6970
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/bf9b6970

Branch: refs/heads/master
Commit: bf9b6970ba3e30d0a13eca358335508b3f788e33
Parents: 75386db
Author: James E. King, III 
Authored: Wed Mar 22 15:07:23 2017 -0400
Committer: James E. King, III 
Committed: Wed Mar 22 15:07:23 2017 -0400

--
 build/cmake/DefinePlatformSpecifc.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/thrift/blob/bf9b6970/build/cmake/DefinePlatformSpecifc.cmake
--
diff --git a/build/cmake/DefinePlatformSpecifc.cmake 
b/build/cmake/DefinePlatformSpecifc.cmake
index 28cc5c2..e8479bc 100644
--- a/build/cmake/DefinePlatformSpecifc.cmake
+++ b/build/cmake/DefinePlatformSpecifc.cmake
@@ -100,7 +100,7 @@ endif()
 
 # GCC and Clang: use C++11
 if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR 
CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "4.6")
+  if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "4.6.4")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
   endif()
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O2 -Wall -Wextra -pedantic")