tinkerpop git commit: TINKERPOP-1831 Refactored EventStrategy
Repository: tinkerpop
Updated Branches:
refs/heads/TINKERPOP-1831 [created] 7963fdfb4
TINKERPOP-1831 Refactored EventStrategy
Removed deprecated method. Used VertexProperty.empty() and Property.empty() to
represent the "old" value for new property events. Created a enum for
configuring detachment on the EventStrategy builder.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/7963fdfb
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/7963fdfb
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/7963fdfb
Branch: refs/heads/TINKERPOP-1831
Commit: 7963fdfb4407347a37ff35d40f5efdd1ba5f039f
Parents: ae2f304
Author: Stephen Mallette
Authored: Thu Jun 7 09:10:47 2018 -0400
Committer: Stephen Mallette
Committed: Thu Jun 7 09:10:47 2018 -0400
--
CHANGELOG.asciidoc | 3 +
docs/src/upgrade/release-3.4.x.asciidoc | 22 +++
.../bulkloading/BulkLoaderVertexProgram.java| 6 -
.../step/sideEffect/AddPropertyStep.java| 6 +-
.../util/event/ConsoleMutationListener.java | 5 -
.../step/util/event/MutationListener.java | 11 +-
.../strategy/decoration/EventStrategy.java | 108 +-
.../strategy/decoration/EventStrategyTest.java | 1 -
.../decoration/EventStrategyProcessTest.java| 197 ---
9 files changed, 130 insertions(+), 229 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/7963fdfb/CHANGELOG.asciidoc
--
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index e886107..7317aeb 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -37,6 +37,9 @@ This release also includes changes from <>.
* Changed the order of `select()` scopes. The order is now: maps,
side-effects, paths.
* Removed previously deprecated Credentials DSL infrastructure.
* Moved `TraversalEngine` to `gremlin-test` as it has long been only used in
testing infrastructure.
+* Events from `EventStrategy`raised from "new" mutations will now return a
true "empty" property from `VertexProperty.empty()` or `Property.empty()` as is
appropriate.
+* `MutationListener#vertexPropertyChanged(Vertex, VertexProperty, Object,
Object...)` no longer has a default implementation.
+* Removed previously deprecated
`MutationListener#vertexPropertyChanged(Vertex, Property, Object, Object...)`.
* Removed previously deprecated `OpSelectorHandler` constructor.
* Removed previously deprecated `close()` from `GremlinGroovyScriptEngine`
which no longer implements `AutoCloseable`.
* Removed previously deprecated `getGraphInputFormat()` and
`getGraphOutputFormat()` from `HadoopConfiguration`.
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/7963fdfb/docs/src/upgrade/release-3.4.x.asciidoc
--
diff --git a/docs/src/upgrade/release-3.4.x.asciidoc
b/docs/src/upgrade/release-3.4.x.asciidoc
index 851d458..68e0c51 100644
--- a/docs/src/upgrade/release-3.4.x.asciidoc
+++ b/docs/src/upgrade/release-3.4.x.asciidoc
@@ -113,6 +113,27 @@ gremlin> g.V().values('name').max()
==>vadas
+ EventStrategy API
+
+There were some minor modifications to how `EventStrategy` is constructed and
what can be expected from events raised
+from the addition of new properties.
+
+With respect to the change in terms of `EventStrategy` construction, the
`detach()` builder method formerly took a
+`Class` as an argument and that `Class` was meant to be one of the various
"detachment factories" or `null`. That
+approach was a bit confusing, so that signature has changed to
`detach(EventStrategy.Detachment)` where the argument
+is a more handy enum of detachment options.
+
+As for the changes related to events themselves, it is first worth noting that
the previously deprecated
+`vertexPropertyChanged(Vertex, Property, Object, Object...)` on
`MutationListener` has been removed for what should
+have originally been the correct signature of `vertexPropertyChanged(Vertex,
VertexProperty, Object, Object...)`. In
+prior versions when this method and its related `edgePropertyChanged()` and
`vertexPropertyPropertyChanged()` were
+triggered by way of the addition of a new property a "fake" property was
included with a `null` value for the
+"oldValue" argument to these methods (as it did not exist prior to this
event). That was a bit awkward to reason about
+when dealing with that event. To make this easier, the event now raises with a
`VertexProperty.empty()` or
+`Property.empty()` instance, which can be evaluated with `equals()` easily to
determine if the property is new or not.
+
+link:https://issues.apache.org/jira/browse/TINKERPOP-1831[TINKERPOP-1831]
+
Deprecation Removal
The
tinkerpop git commit: Removed gmavenplus plugin from hadoop-gremlin
Repository: tinkerpop Updated Branches: refs/heads/tp32 962093e66 -> e8e22af43 Removed gmavenplus plugin from hadoop-gremlin Not building any groovy here or running any scripts so there doesn't seem to be a need for it. CTR Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/e8e22af4 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/e8e22af4 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/e8e22af4 Branch: refs/heads/tp32 Commit: e8e22af4332e33d12067ed3e12237284067871aa Parents: 962093e Author: Stephen Mallette Authored: Thu Jun 7 07:34:08 2018 -0400 Committer: Stephen Mallette Committed: Thu Jun 7 07:34:08 2018 -0400 -- hadoop-gremlin/pom.xml | 18 -- 1 file changed, 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e8e22af4/hadoop-gremlin/pom.xml -- diff --git a/hadoop-gremlin/pom.xml b/hadoop-gremlin/pom.xml index b094470..489502d 100644 --- a/hadoop-gremlin/pom.xml +++ b/hadoop-gremlin/pom.xml @@ -218,24 +218,6 @@ limitations under the License. org.apache.maven.plugins maven-failsafe-plugin - -org.codehaus.gmavenplus -gmavenplus-plugin - - - -addSources -addTestSources -generateStubs -compile -generateTestStubs -compileTests -removeStubs -removeTestStubs - - - - \ No newline at end of file
[2/2] tinkerpop git commit: Merge branch 'tp32' into tp33
Merge branch 'tp32' into tp33 Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/55fcbdc4 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/55fcbdc4 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/55fcbdc4 Branch: refs/heads/tp33 Commit: 55fcbdc45bf3c6a78d7ecbbe2b13fe24fbb5ba1c Parents: a0b7ce5 e8e22af Author: Stephen Mallette Authored: Thu Jun 7 07:37:35 2018 -0400 Committer: Stephen Mallette Committed: Thu Jun 7 07:37:35 2018 -0400 -- hadoop-gremlin/pom.xml | 18 -- 1 file changed, 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/55fcbdc4/hadoop-gremlin/pom.xml --
[1/2] tinkerpop git commit: Removed gmavenplus plugin from hadoop-gremlin
Repository: tinkerpop Updated Branches: refs/heads/tp33 a0b7ce517 -> 55fcbdc45 Removed gmavenplus plugin from hadoop-gremlin Not building any groovy here or running any scripts so there doesn't seem to be a need for it. CTR Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/e8e22af4 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/e8e22af4 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/e8e22af4 Branch: refs/heads/tp33 Commit: e8e22af4332e33d12067ed3e12237284067871aa Parents: 962093e Author: Stephen Mallette Authored: Thu Jun 7 07:34:08 2018 -0400 Committer: Stephen Mallette Committed: Thu Jun 7 07:34:08 2018 -0400 -- hadoop-gremlin/pom.xml | 18 -- 1 file changed, 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e8e22af4/hadoop-gremlin/pom.xml -- diff --git a/hadoop-gremlin/pom.xml b/hadoop-gremlin/pom.xml index b094470..489502d 100644 --- a/hadoop-gremlin/pom.xml +++ b/hadoop-gremlin/pom.xml @@ -218,24 +218,6 @@ limitations under the License. org.apache.maven.plugins maven-failsafe-plugin - -org.codehaus.gmavenplus -gmavenplus-plugin - - - -addSources -addTestSources -generateStubs -compile -generateTestStubs -compileTests -removeStubs -removeTestStubs - - - - \ No newline at end of file
[1/3] tinkerpop git commit: Removed gmavenplus plugin from hadoop-gremlin
Repository: tinkerpop Updated Branches: refs/heads/master a3677e2e8 -> ae2f304d4 Removed gmavenplus plugin from hadoop-gremlin Not building any groovy here or running any scripts so there doesn't seem to be a need for it. CTR Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/e8e22af4 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/e8e22af4 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/e8e22af4 Branch: refs/heads/master Commit: e8e22af4332e33d12067ed3e12237284067871aa Parents: 962093e Author: Stephen Mallette Authored: Thu Jun 7 07:34:08 2018 -0400 Committer: Stephen Mallette Committed: Thu Jun 7 07:34:08 2018 -0400 -- hadoop-gremlin/pom.xml | 18 -- 1 file changed, 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e8e22af4/hadoop-gremlin/pom.xml -- diff --git a/hadoop-gremlin/pom.xml b/hadoop-gremlin/pom.xml index b094470..489502d 100644 --- a/hadoop-gremlin/pom.xml +++ b/hadoop-gremlin/pom.xml @@ -218,24 +218,6 @@ limitations under the License. org.apache.maven.plugins maven-failsafe-plugin - -org.codehaus.gmavenplus -gmavenplus-plugin - - - -addSources -addTestSources -generateStubs -compile -generateTestStubs -compileTests -removeStubs -removeTestStubs - - - - \ No newline at end of file
[3/3] tinkerpop git commit: Merge branch 'tp33'
Merge branch 'tp33' Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/ae2f304d Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/ae2f304d Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/ae2f304d Branch: refs/heads/master Commit: ae2f304d47a0c9280ec7894ce53d32ad270b157f Parents: a3677e2 55fcbdc Author: Stephen Mallette Authored: Thu Jun 7 07:37:44 2018 -0400 Committer: Stephen Mallette Committed: Thu Jun 7 07:37:44 2018 -0400 -- hadoop-gremlin/pom.xml | 18 -- 1 file changed, 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/ae2f304d/hadoop-gremlin/pom.xml --
[2/3] tinkerpop git commit: Merge branch 'tp32' into tp33
Merge branch 'tp32' into tp33 Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/55fcbdc4 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/55fcbdc4 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/55fcbdc4 Branch: refs/heads/master Commit: 55fcbdc45bf3c6a78d7ecbbe2b13fe24fbb5ba1c Parents: a0b7ce5 e8e22af Author: Stephen Mallette Authored: Thu Jun 7 07:37:35 2018 -0400 Committer: Stephen Mallette Committed: Thu Jun 7 07:37:35 2018 -0400 -- hadoop-gremlin/pom.xml | 18 -- 1 file changed, 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/55fcbdc4/hadoop-gremlin/pom.xml --
