[tinkerpop] branch TINKERPOP-2059 updated: Got rid of now deprecated `valueMap()` overload in `AddVertexTest`.
This is an automated email from the ASF dual-hosted git repository.
dkuppitz pushed a commit to branch TINKERPOP-2059
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/TINKERPOP-2059 by this push:
new e4f978d Got rid of now deprecated `valueMap()` overload in
`AddVertexTest`.
e4f978d is described below
commit e4f978d56b8296bd6957ebc4a40f724865192833
Author: Daniel Kuppitz
AuthorDate: Tue Nov 6 14:57:30 2018 -0700
Got rid of now deprecated `valueMap()` overload in `AddVertexTest`.
---
gremlin-test/features/map/AddVertex.feature| 25 --
.../process/traversal/step/map/AddVertexTest.java | 22 ---
2 files changed, 47 deletions(-)
diff --git a/gremlin-test/features/map/AddVertex.feature
b/gremlin-test/features/map/AddVertex.feature
index 1bb3ce1..a60fefb 100644
--- a/gremlin-test/features/map/AddVertex.feature
+++ b/gremlin-test/features/map/AddVertex.feature
@@ -336,31 +336,6 @@ Feature: Step - addV()
| marko |
And the graph should return 2 for count of "g.V().has(\"name\",\"marko\")"
- Scenario:
g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMapXtrueX
-Given the empty graph
-And the graph initializer of
- """
- g.addV("person").property(T.id, 1).property("name",
"marko").property("age", 29).as("marko").
-addV("person").property(T.id, 2).property("name",
"vadas").property("age", 27).as("vadas").
-addV("software").property(T.id, 3).property("name",
"lop").property("lang", "java").as("lop").
-addV("person").property(T.id,
4).property("name","josh").property("age", 32).as("josh").
-addV("software").property(T.id, 5).property("name",
"ripple").property("lang", "java").as("ripple").
-addV("person").property(T.id, 6).property("name",
"peter").property("age", 35).as('peter').
-addE("knows").from("marko").to("vadas").property(T.id,
7).property("weight", 0.5).
-addE("knows").from("marko").to("josh").property(T.id,
8).property("weight", 1.0).
-addE("created").from("marko").to("lop").property(T.id,
9).property("weight", 0.4).
-addE("created").from("josh").to("ripple").property(T.id,
10).property("weight", 1.0).
-addE("created").from("josh").to("lop").property(T.id,
11).property("weight", 0.4).
-addE("created").from("peter").to("lop").property(T.id,
12).property("weight", 0.2)
- """
-And the traversal of
- """
- g.V().as("a").has("name",
"marko").out("created").as("b").addV(__.select("a").label()).property("test",
__.select("b").label()).valueMap(true)
- """
-When iterated to list
-Then the result should have a count of 1
-And the graph should return 1 for count of
"g.V().has(\"person\",\"test\",\"software\")"
-
Scenario:
g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMap_withXtokensX
Given the empty graph
And the graph initializer of
diff --git
a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddVertexTest.java
b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddVertexTest.java
index 858f979..21fbb8c 100644
---
a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddVertexTest.java
+++
b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddVertexTest.java
@@ -74,8 +74,6 @@ public abstract class AddVertexTest extends
AbstractGremlinTest {
public abstract Traversal
get_g_withSideEffectXa_nameX_addV_propertyXselectXaX_markoX_name();
-public abstract Traversal>
get_g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMapXtrueX();
-
public abstract Traversal>
get_g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMap_withXtokensX();
@Test
@@ -288,21 +286,6 @@ public abstract class AddVertexTest extends
AbstractGremlinTest {
@LoadGraphWith(MODERN)
@FeatureRequirement(featureClass = Graph.Features.VertexFeatures.class,
feature = Graph.Features.VertexFeatures.FEATURE_ADD_VERTICES)
@FeatureRequirement(featureClass = Graph.Features.VertexFeatures.class,
feature = Graph.Features.VertexFeatures.FEATURE_ADD_PROPERTY)
-public void
g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMapXtrueX()
{
-final Traversal> traversal =
get_g_V_asXaX_hasXname_markoX_outXcreatedX_asXbX_addVXselectXaX_labelX_propertyXtest_selectXbX_labelX_valueMapXtrueX();
-printTraversalForm(traversal);
-final Map map = traversal.next();
-assertFalse(traversal.hasNext());
-assertEquals("person",map.get(T.label));
-
[GitHub] dkuppitz commented on a change in pull request #988: TINKERPOP-2050 Added :bytecode command
dkuppitz commented on a change in pull request #988: TINKERPOP-2050 Added
:bytecode command
URL: https://github.com/apache/tinkerpop/pull/988#discussion_r231305367
##
File path: docs/src/upgrade/release-3.3.x.asciidoc
##
@@ -27,6 +27,29 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
Please see the
link:https://github.com/apache/tinkerpop/blob/3.3.5/CHANGELOG.asciidoc#release-3-3-5[changelog]
for a complete list of all the modifications that are part of this release.
+=== Upgrading for Users
+
+ Bytecode Command
+
+The Gremlin Console now has a new `:bytecode` command to help users work more
directly with Gremlin bytecode. The
+command is more of a debugging tool than something that would be used for
every day purposes. It is sometimes helpful
+to look at Gremlin bytecode directly and the process for viewing it in human
readable format is not a single step
+process. It is also not immediately clear how to convert bytecode to a Gremlin
string. The `:bytecode` command aims to
+help with both of these issues:
+
+[source,text]
+
+gremlin> g = TinkerFactory.createModern().traversal()
+==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
+gremlin> :bytecode from g.V().out('knows') <1>
Review comment:
The callouts `<1>` and `<2>` have no description.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] spmallette opened a new pull request #988: TINKERPOP-2050 Added :bytecode command
spmallette opened a new pull request #988: TINKERPOP-2050 Added :bytecode
command
URL: https://github.com/apache/tinkerpop/pull/988
https://issues.apache.org/jira/browse/TINKERPOP-2050
Command options are as follows:
```text
gremlin> :bytecode from g.V().out('knows')
==>{"@type":"g:Bytecode","@value":{"step":[["V"],["out","knows"]]}}
gremlin> :bytecode translate g
{"@type":"g:Bytecode","@value":{"step":[["V"],["out","knows"]]}}
==>g.V().out("knows")
```
VOTE +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[tinkerpop] branch TINKERPOP-2050 updated: TINKERPOP-2050 Removed the eval/submit options on :bytecode
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-2050
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/TINKERPOP-2050 by this push:
new 40c5896 TINKERPOP-2050 Removed the eval/submit options on :bytecode
40c5896 is described below
commit 40c5896bd7afcabd6329c43e820d618d24604758
Author: Stephen Mallette
AuthorDate: Tue Nov 6 14:56:14 2018 -0500
TINKERPOP-2050 Removed the eval/submit options on :bytecode
These options didn't really support the nature of what this change was
about, so they were removed.
---
docs/src/reference/gremlin-applications.asciidoc | 12
.../gremlin/console/commands/BytecodeCommand.groovy | 12 +---
.../gremlin/console/commands/BytecodeCommand.properties | 2 +-
3 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/docs/src/reference/gremlin-applications.asciidoc
b/docs/src/reference/gremlin-applications.asciidoc
index d47b236..472d147 100644
--- a/docs/src/reference/gremlin-applications.asciidoc
+++ b/docs/src/reference/gremlin-applications.asciidoc
@@ -167,26 +167,14 @@ could use some additional explanation. The following code
shows example usage:
[source,text]
-gremlin> g = TinkerFactory.createModern().traversal()
-==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> :bytecode from g.V().out('knows') <1>
==>{"@type":"g:Bytecode","@value":{"step":[["V"],["out","knows"]]}}
gremlin> :bytecode translate g
{"@type":"g:Bytecode","@value":{"step":[["V"],["out","knows"]]}} <2>
==>g.V().out("knows")
-gremlin> :bytecode eval g
{"@type":"g:Bytecode","@value":{"step":[["V"],["out","knows"]]}} <3>
-==>v[2]
-==>v[4]
-gremlin> :remote connect tinkerpop.server conf/remote.yaml
-==>Configured localhost/127.0.0.1:8182
-gremlin> :bytecode submit g
{"@type":"g:Bytecode","@value":{"step":[["V"],["out","knows"]]}} <4>
-==>v[2]
-==>v[4]
<1> Generates a GraphSON 3.0 representation of the traversal as bytecode.
<2> Converts bytecode in GraphSON 3.0 format to a traversal string.
-<3> Converts bytecode in GraphSON 3.0 format to a traversal string which is
evaluated against "g" where "g" should be a valid graph instance.
-<4> Converts bytecode in GraphSON 3.0 format to a traversal string and submits
it remotely as a string to the current `:remote`.
[[console-preferences]]
=== Console Preferences
diff --git
a/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.groovy
b/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.groovy
index b55fe2f..d2455cc 100644
---
a/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.groovy
+++
b/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.groovy
@@ -40,7 +40,7 @@ class BytecodeCommand extends ComplexCommandSupport {
private final ObjectMapper mapper =
GraphSONMapper.build().version(GraphSONVersion.V3_0).create().createMapper()
public BytecodeCommand(final Groovysh shell, final Mediator mediator) {
-super(shell, ":bytecode", ":bc", ["eval", "from", "submit",
"translate"])
+super(shell, ":bytecode", ":bc", ["from", "translate"])
this.mediator = mediator
}
@@ -54,16 +54,6 @@ class BytecodeCommand extends ComplexCommandSupport {
mediator.showShellEvaluationOutput(true)
return mapper.writeValueAsString(traversal.asAdmin().bytecode)
}
-
-def Object do_eval = { List arguments ->
-return shell.execute(do_translate(arguments))
-}
-
-def Object do_submit = { List arguments ->
-if (mediator.remotes.size() == 0) return "No remotes are configured.
Use :remote command."
-return mediator.currentRemote().submit([do_translate(arguments)])
-}
-
def Object do_translate = { List arguments ->
def g = arguments[0]
diff --git
a/gremlin-console/src/main/resources/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.properties
b/gremlin-console/src/main/resources/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.properties
index 07506dc..d31bea8 100644
---
a/gremlin-console/src/main/resources/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.properties
+++
b/gremlin-console/src/main/resources/org/apache/tinkerpop/gremlin/console/commands/BytecodeCommand.properties
@@ -16,5 +16,5 @@
# under the License.
command.description=Gremlin bytecode helper commands
-command.usage=[eval |from |submit <
|translate ]
+command.usage=[from |translate ]
command.help=Gremlin bytecode helper commands
\ No newline at end of file
[tinkerpop] 01/01: Added failing tests for TINKERPOP-1643.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-1643
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 8a82659e925ffd6c92ac8e4d9d2b1ac295b5452e
Author: Daniel Kuppitz
AuthorDate: Thu Mar 2 12:41:48 2017 +0100
Added failing tests for TINKERPOP-1643.
Also simplified a few test queries and tweaked the assertions so that they
should now work in STANDARD and COMPUTER mode.
---
gremlin-test/features/branch/Repeat.feature| 66 +
.../process/traversal/step/branch/RepeatTest.java | 165 +
2 files changed, 203 insertions(+), 28 deletions(-)
diff --git a/gremlin-test/features/branch/Repeat.feature
b/gremlin-test/features/branch/Repeat.feature
index 6175519..447c2d6 100644
--- a/gremlin-test/features/branch/Repeat.feature
+++ b/gremlin-test/features/branch/Repeat.feature
@@ -244,3 +244,69 @@ Feature: Step - repeat()
| loop |
| loop |
| loop |
+
+ Scenario: g_V_asXvX_emit_repeatXboth_asXvX_dedupX_selectXvX_count
+Given the modern graph
+And the traversal of
+ """
+ g.V().as("v").emit().repeat(both().as("v").dedup()).select("v").count()
+ """
+When iterated next
+Then the result should be unordered
+ | result |
+ | d[12].l |
+
+ Scenario:
g_V_asXvX_emit_repeatXboth_asXvX_dedupX_selectXall_vX_order_byXcountXlocalXX_byXlimitXlocal_1X_idX_byXtailXlocal_1X_idX
+Given the modern graph
+And the traversal of
+ """
+ g.V().as("v").emit().repeat(both().as("v").dedup()).select(Pop.all,
"v").order().by(count(local)).by(limit(local, 1).id()).by(tail(local, 1).id());
+ """
+When iterated next
+Then the result should be unordered
+ | result |
+ | l[v[marko]] |
+ | l[v[vadas]] |
+ | l[v[lop]] |
+ | l[v[josh]] |
+ | l[v[ripple]] |
+ | l[v[peter]] |
+ | l[v[marko], v[vadas]] |
+ | l[v[marko], v[lop]] |
+ | l[v[marko], v[josh]] |
+ | l[v[vadas], v[marko]] |
+ | l[v[lop], v[ripple]] |
+ | l[v[josh], v[peter]] |
+
+ Scenario: g_V_emit_repeatXboth_dedupX_count
+Given the modern graph
+And the traversal of
+ """
+ g.V().emit().repeat(both().dedup()).count()
+ """
+When iterated next
+Then the result should be unordered
+ | result |
+ | d[12].l |
+
+ Scenario: g_V_emit_repeatXboth_dedupX_order_byXcountXlocalXX
+Given the modern graph
+And the traversal of
+ """
+ g.V().emit().repeat(both().dedup()).order().by(count(local))
+ """
+When iterated next
+Then the result should be unordered
+ | result |
+ | v[1] |
+ | v[1] |
+ | v[2] |
+ | v[2] |
+ | v[3] |
+ | v[3] |
+ | v[4] |
+ | v[4] |
+ | v[5] |
+ | v[5] |
+ | v[6] |
+ | v[6] |
diff --git
a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
index 6d90687..55c897f 100644
---
a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
+++
b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
@@ -22,6 +22,8 @@ import org.apache.tinkerpop.gremlin.LoadGraphWith;
import org.apache.tinkerpop.gremlin.process.AbstractGremlinProcessTest;
import org.apache.tinkerpop.gremlin.process.GremlinProcessRunner;
import org.apache.tinkerpop.gremlin.process.traversal.Path;
+import org.apache.tinkerpop.gremlin.process.traversal.Pop;
+import org.apache.tinkerpop.gremlin.process.traversal.Scope;
import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__;
import org.apache.tinkerpop.gremlin.process.traversal.step.util.MapHelper;
@@ -39,12 +41,15 @@ import java.util.Map;
import static org.apache.tinkerpop.gremlin.LoadGraphWith.GraphData.MODERN;
import static org.apache.tinkerpop.gremlin.LoadGraphWith.GraphData.SINK;
import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.both;
+import static
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.count;
import static
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.groupCount;
import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.has;
import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.in;
+import static
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.limit;
import static
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.loops;
import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.out;
import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.outE;
+import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.tail;
import static
[GitHub] papa-pep commented on issue #903: Gremlin.Net: Add ConnectionPool min and max sizes TINKERPOP-1774
papa-pep commented on issue #903: Gremlin.Net: Add ConnectionPool min and max sizes TINKERPOP-1774 URL: https://github.com/apache/tinkerpop/pull/903#issuecomment-436311573 Is this slated for 3.4.0? Periodically I'm seeing requests being held open for unusually long times until an exception is thrown: System.Net.Sockets.SocketException An internal WebSocket error occurred. Please see the innerException, if present, for more details. Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. An existing connection was forcibly closed by the remote host Do you think this would help alleviate that issue? I'm currently using 3.4.0rc2 in order to return necessary request attributes from CosmosDb to monitor performance. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch tp33 updated (5343880 -> 0b1e6e1)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch tp33 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 5343880 Fixed formatting in provider docs in protocol section CTR add a8fba32 TINKERPOP-2084 Display remote stacktrace in gremlin console add 0b1e6e1 Merge branch 'TINKERPOP-2084' into tp33 No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 2 ++ .../tinkerpop/gremlin/console/Console.groovy | 8 +++- .../console/jsr223/DriverRemoteAcceptor.java | 9 +--- .../gremlin/jsr223/console/RemoteException.java| 24 -- 4 files changed, 37 insertions(+), 6 deletions(-)
[tinkerpop] branch master updated (0852a66 -> afb289d)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 0852a66 Merge branch 'tp33' add a8fba32 TINKERPOP-2084 Display remote stacktrace in gremlin console new 0b1e6e1 Merge branch 'TINKERPOP-2084' into tp33 new afb289d Merge branch 'tp33' The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 2 ++ .../tinkerpop/gremlin/console/Console.groovy | 8 +++- .../console/jsr223/DriverRemoteAcceptor.java | 9 +--- .../gremlin/jsr223/console/RemoteException.java| 24 -- 4 files changed, 37 insertions(+), 6 deletions(-)
[tinkerpop] 02/02: Merge branch 'tp33'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit afb289d0aaad8c5af0cd05a76f8b8105b7f8a417 Merge: 0852a66 0b1e6e1 Author: Stephen Mallette AuthorDate: Tue Nov 6 08:27:40 2018 -0500 Merge branch 'tp33' CHANGELOG.asciidoc | 2 ++ .../tinkerpop/gremlin/console/Console.groovy | 8 +++- .../console/jsr223/DriverRemoteAcceptor.java | 9 +--- .../gremlin/jsr223/console/RemoteException.java| 24 -- 4 files changed, 37 insertions(+), 6 deletions(-)
[GitHub] spmallette closed pull request #981: TINKERPOP-2084 Display remote stacktrace in gremlin console
spmallette closed pull request #981: TINKERPOP-2084 Display remote stacktrace in gremlin console URL: https://github.com/apache/tinkerpop/pull/981 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] 01/02: Merge branch 'TINKERPOP-2084' into tp33
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 0b1e6e1a09d42aa21440a52843108e791d888ff1 Merge: 5343880 a8fba32 Author: Stephen Mallette AuthorDate: Tue Nov 6 08:27:29 2018 -0500 Merge branch 'TINKERPOP-2084' into tp33 Conflicts: CHANGELOG.asciidoc CHANGELOG.asciidoc | 2 ++ .../tinkerpop/gremlin/console/Console.groovy | 8 +++- .../console/jsr223/DriverRemoteAcceptor.java | 9 +--- .../gremlin/jsr223/console/RemoteException.java| 24 -- 4 files changed, 37 insertions(+), 6 deletions(-) diff --cc CHANGELOG.asciidoc index e13e71c,e09eeb0..14bbc5d --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@@ -26,8 -26,8 +26,10 @@@ image::https://raw.githubusercontent.co This release also includes changes from <>. * Fixed `PersistedOutputRDD` to eager persist RDD by adding `count()` action calls. + * gremlin-python: the graphson deserializer for g:Set should return a python set + * Display the remote stack trace in the Gremlin Console when scripts sent to the server fail. +* Changed behavior of GraphSON deserializer in gremlin-python such that `g:Set` returns a Python `Set`. +* Changed behavior of `iterate()` in Python, Javascript and .NET to send `none()` thus avoiding unnecessary results being returned. [[release-3-3-4]] === TinkerPop 3.3.4 (Release Date: October 15, 2018)
[GitHub] spmallette commented on issue #968: TINKERPOP-2078 Added AnonymousTraversalSource
spmallette commented on issue #968: TINKERPOP-2078 Added AnonymousTraversalSource URL: https://github.com/apache/tinkerpop/pull/968#issuecomment-436250679 @jorgebay i tried to put `traversal()` in process for python and js. in python i ran into some cyclic dependency problems. in js i had other issues (that i'd assumed were similar to python). That's why the `traversal()` method is where it is in those cases. I just attempted to move it again for js and keep getting weird errors i don't understand. I really shouldn't spend any more time floundering around on this one - could you please take a look at moving it for me (just push the fix right to the branch)? If you get it working, i'll look at what i can do in python to move it, even if it means creating an `AnonymousTraversalSource` sort of py file to do it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch TINKERPOP-2078 updated (05a0715 -> 8a8db50)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2078 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 05a0715 TINKERPOP-2078 Fixed broken XML comment in .NET add 8a8db50 TINKERPOP-2078 Added missing import No new revisions were added by this update. Summary of changes: gremlin-dotnet/src/Gremlin.Net/Structure/Graph.cs | 1 + 1 file changed, 1 insertion(+)
[GitHub] spmallette opened a new pull request #987: TINKERPOP-1984 Enable GraphSON serializers to no longer conflict
spmallette opened a new pull request #987: TINKERPOP-1984 Enable GraphSON serializers to no longer conflict URL: https://github.com/apache/tinkerpop/pull/987 https://issues.apache.org/jira/browse/TINKERPOP-1984 Making `GraphSONMessageSerializerV2d0` handle both typed and untyped formats allows it to be used in a fashion where users can choose to add serializers with `application/json` at the same time for HTTP use cases. It also generally seemed to make more sense than how it was before. Not sure what changed to allow this now and not in the past. Note the upgrade docs for why this is considered a breaking change - fairly minor I think. All tests pass with `docker/build.sh -t -i` VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] 01/01: TINKERPOP-1984 Enable GraphSON serializers to no longer conflict
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch TINKERPOP-1984 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 4cf426be5f3e12ede12e242d0241935daf0e81f6 Author: Stephen Mallette AuthorDate: Mon Nov 5 16:14:31 2018 -0500 TINKERPOP-1984 Enable GraphSON serializers to no longer conflict Making GraphSONMessageSerializerV2d0 handle both typed and untyped formats allows it to be used in a fashion where users can choose to add both serializers at the same time for HTTP use cases. It also generally seemed to make more sense than how it was before. Not sure what changed to allow this now and not in the past. --- CHANGELOG.asciidoc | 1 + .../gremlin-language-variants/index.asciidoc | 2 - docs/src/upgrade/release-3.4.x.asciidoc| 16 ++ .../console/jsr223/gremlin-server-integration.yaml | 6 +- .../ser/GraphSONMessageSerializerGremlinV2d0.java | 4 +- .../driver/ser/GraphSONMessageSerializerV2d0.java | 4 +- .../driver/ser/GraphSONMessageSerializerV3d0.java | 2 +- .../tinkerpop/gremlin/driver/ser/Serializers.java | 2 +- .../gremlin/server/AbstractChannelizer.java| 2 +- .../server/GremlinServerHttpIntegrateTest.java | 64 -- .../gremlin/server/gremlin-server-integration.yaml | 4 +- 11 files changed, 90 insertions(+), 17 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index b92fb8b..0b60ddb 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -70,6 +70,7 @@ This release also includes changes from <>. * Nested loop support added allowing `repeat()` steps to be nested. * Events from `EventStrategy` raised from "new" mutations will now return a `KeyedVertexProperty` or `KeyedProperty` as is appropriate. * `MutationListener#vertexPropertyChanged(Vertex, VertexProperty, Object, Object...)` no longer has a default implementation. +* Deprecated `GraphSONMessageSerializerV2d0` as it is now analogous to `GraphSONMessageSerializerGremlinV2d0`. * Removed previously deprecated methods in `SubgraphStrategy` and `PartitionStrategy` builders. * Removed previously deprecated Credentials DSL infrastructure. * Removed previously deprecated `MutationListener#vertexPropertyChanged(Vertex, Property, Object, Object...)`. diff --git a/docs/src/tutorials/gremlin-language-variants/index.asciidoc b/docs/src/tutorials/gremlin-language-variants/index.asciidoc index ebc988f..065657a 100644 --- a/docs/src/tutorials/gremlin-language-variants/index.asciidoc +++ b/docs/src/tutorials/gremlin-language-variants/index.asciidoc @@ -534,8 +534,6 @@ $ bin/gremlin-server.sh conf/gremlin-server-modern-py.yaml [INFO] Logger$info - Executed once at startup of Gremlin Server. [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+gryo with org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV3d0 [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+gryo-stringd with org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV3d0 -[INFO] AbstractChannelizer - Configured application/vnd.gremlin-v1.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0 -[INFO] AbstractChannelizer - Configured application/vnd.gremlin-v2.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV2d0 [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0 [INFO] AbstractChannelizer - Configured application/json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0 [INFO] GremlinServer$1 - Gremlin Server configured with worker thread pool of 1, gremlin pool of 4 and boss thread pool of 1. diff --git a/docs/src/upgrade/release-3.4.x.asciidoc b/docs/src/upgrade/release-3.4.x.asciidoc index d412fda..b931c1a 100644 --- a/docs/src/upgrade/release-3.4.x.asciidoc +++ b/docs/src/upgrade/release-3.4.x.asciidoc @@ -388,6 +388,22 @@ link:https://issues.apache.org/jira/browse/TINKERPOP-1707[TINKERPOP-1707], link:https://issues.apache.org/jira/browse/TINKERPOP-1954[TINKERPOP-1954], link:https://issues.apache.org/jira/browse/TINKERPOP-1986[TINKERPOP-1986] + Deprecated GraphSONMessageSerializerGremlinV2d0 + +The `GraphSONMessageSerializerGremlinV2d0` serializer is now analogous to `GraphSONMessageSerializerV2d0` and therefore +redundant. It has technically always been equivalent in terms of functionality as both serialized to the same format +(i.e. GraphSON 2.0 with embedded types). It is no longer clear why these two classes were established this way, but +it does carry the negative effect where multiple serializer versions could not be bound to Gremlin Server's HTTP +endpoint as the MIME types conflicted on `application/json`. By simply making both message serializers support +`application/json` and
[tinkerpop] branch TINKERPOP-1984 updated (7457cad -> 4cf426b)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-1984 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 7457cad TINKERPOP-1984 Enable GraphSON serializers to no longer conflict new 4cf426b TINKERPOP-1984 Enable GraphSON serializers to no longer conflict This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (7457cad) \ N -- N -- N refs/heads/TINKERPOP-1984 (4cf426b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 2 +- docs/src/upgrade/release-3.3.x.asciidoc | 14 -- docs/src/upgrade/release-3.4.x.asciidoc | 16 .../driver/ser/GraphSONMessageSerializerGremlinV2d0.java | 2 +- 4 files changed, 18 insertions(+), 16 deletions(-)
[tinkerpop] branch TINKERPOP-1984 updated (f0dac2a -> 7457cad)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-1984 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard f0dac2a TINKERPOP-1984 Enable GraphSON serializers to no longer conflict add 0c10921 Bump to 3.4.0-SNAPSHOT CTR add 12e7f7e Updated changelog for 3.4.0-SNAPSHOT CTR add 1b7fba3 Added upgrade docs CTR add c99ac1f Merge branch 'tp33' add 05c1c04 Updated .net/js to 3.4.0-SNAPSHOT add df3e834 Merge branch 'tp33' add a418226 Updated gremlin console location to 3.4.0-SNAPSHOT CTR add 773d510 Merge branch 'tp33' add e48e834 Merge branch 'tp33' add c722cda Merge branch 'tp33' add b31e27d Merge branch 'tp33' add cef13dd Merge branch 'tp33' add 5ec7774 Merge branch 'tp32' into tp33 add 5d36ec1 Merge branch 'tp33' add 4e8d63c Merge branch 'tp33' add a8bfabd Merge branch 'tp33' add 18ba893 Merge branch 'tp33' add 32b39d3 Merge branch 'tp33' add 3858818 This closes #801 add 4579a0e Merge branch 'tp33' add 4113f0e Merge branch 'tp33' add cb1de60 Merge branch 'tp33' add 44253e6 Merge branch 'tp33' add 92ec0ab Merge branch 'tp33' add 51f4771 Merge branch 'tp33' add 62299a1 Merge branch 'tp33' add 512a4b8 Added some notes about certain Structure API bits for 4.x CTR add 5914aa1 TINKERPOP-1885 Add Gremlin.Net to Query Languages section CTR add 137f1e5 Merge branch 'tp33' add 3201442 Fixed the behavior of `min()`, `max()`, `mean()` and `sum()`. If no input is given, these steps will now throw a `FastNoElementException`. add 7149f8e Updated release docs add b6501ca added Jira link in upgrade docs. add a35f009 Merge branch 'TINKERPOP-1777' add 24f629b Changed order of `select()` scopes. Maps (local objects) come firstm then side-effects, then paths. add 5535e5b added new test case to verify new select scope order add 26684e3 updated CHANGELOG add abc11c8 added a note in upgrade docs regarding the change of order of select scopes add 26c7c1f Merge branch 'tp33' add 25ae1a1 Merge branch 'tp33' add cfa5c50 Merge branch 'tp33' add 7433ffb Merge branch 'local/tp33' into local/master add 9627214 Merge branch 'tp33' add c559679 Merge branch 'tp33' add b4013a2 Merge branch 'tp33' add da63965 Merge branch 'tp33' add 22000e4 Merge branch 'tp33' add 3bbdbde Merge branch 'tp33' add 0ac6ccf Merge branch 'tp33' add 98ed875 Merge branch 'tp33' add c7bf69d TINKERPOP-1446 Added standard string representation for Path objects add c6c3f0f Merge branch 'TINKERPOP-1446' add bf58b63 Merge branch 'tp33' add 116d743 Merge branch 'tp33' add 6e0ccd8 Merge branch 'tp33' add 764824f Merge branch 'tp33' add 345d81a Merge branch 'tp33' add 5ae66ed Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tinkerpop add 3e00a64 Merge branch 'tp33' add c0571df Merge branch 'tp33' add cb322ac Merge branch 'tp33' add e80cd57 Merge branch 'tp33' add f2f0cbd Merge branch 'tp33' add a33c5ca Merge branch 'tp33' add 04b7d4d Merge branch 'tp33' add f7da641 Merge branch 'tp33' add 011044e Merge branch 'tp33' add 83f40a5 Merge branch 'tp33' add 281c278 Merge branch 'tp33' add c8f5559 Merge branch 'tp33' add fa9fa0d Merge branch 'tp33' add a9c0e0b Added cypher-to-gremlin to index listing CTR add 754eb79 Merge branch 'tp33' add 8b17ab7 Merge branch 'tp33' add fc18e3e Merge branch 'tp33' add dfeefe6 Merge branch 'tp33' add 91a5301 Merge branch 'tp33' add 23919b4 Merge branch 'tp33' add ea611c5 Merge branch 'tp33' add f532f9e Merge branch 'tp33' add 7d75111 Merge branch 'tp33' add fc0ed43 Merge branch 'tp33' add ead0eda Merge branch 'tp33' add ba91545 update index.asciidoc add 79dc2cd fix format add 0996419 Added a section on Serialization add 32a0372 Merge branch 'tp33' add 23ca117 Temporarily disable revapi checker add 034a3be Merge branch 'tp33' add 1e950fc Merge branch 'tp33' add 234bc34 Re-enable revapi add a8889be Merge branch 'tp33' add 3be8f72 Merge branch 'tp33' add 986588b Merge branch 'tp33' add 33bfe54 TINKERPOP-1930 Remove Giraph add 0cfda44 Merge branch 'TINKERPOP-1930' add 5fa154a This closes #828 add 439eea6 Merge branch 'tp33' add 65f1529 Merge branch 'tp33' add c14aa30 Merge branch 'tp33' add 4455a1d Merge branch 'tp32' into tp33 add 9a70e69 Merge branch 'tp32' into tp33 add 2656b64 Bump to 3.3.3-SNAPSHOT add f83350a Merge branch 'tp33' add 61cf047 Merge branch 'tp33' add 8d0b286 Added copyright to /site add 5945f4e Moved
[tinkerpop] 01/01: TINKERPOP-1984 Enable GraphSON serializers to no longer conflict
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch TINKERPOP-1984 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 7457cadea9a97f9f4b0c2b83b0286a55bc59191d Author: Stephen Mallette AuthorDate: Mon Nov 5 16:14:31 2018 -0500 TINKERPOP-1984 Enable GraphSON serializers to no longer conflict Making GraphSONMessageSerializerV2d0 handle both typed and untyped formats allows it to be used in a fashion where users can choose to add both serializers at the same time for HTTP use cases. It also generally seemed to make more sense than how it was before. Not sure what changed to allow this now and not in the past. --- CHANGELOG.asciidoc | 1 + .../gremlin-language-variants/index.asciidoc | 2 - docs/src/upgrade/release-3.3.x.asciidoc| 14 + .../console/jsr223/gremlin-server-integration.yaml | 6 +- .../ser/GraphSONMessageSerializerGremlinV2d0.java | 4 +- .../driver/ser/GraphSONMessageSerializerV2d0.java | 4 +- .../driver/ser/GraphSONMessageSerializerV3d0.java | 2 +- .../tinkerpop/gremlin/driver/ser/Serializers.java | 2 +- .../gremlin/server/AbstractChannelizer.java| 2 +- .../server/GremlinServerHttpIntegrateTest.java | 64 -- .../gremlin/server/gremlin-server-integration.yaml | 4 +- 11 files changed, 88 insertions(+), 17 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index b92fb8b..249700e 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -95,6 +95,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima This release also includes changes from <>. +* Deprecated `GraphSONMessageSerializerV2d0` as it is now analogous to `GraphSONMessageSerializerGremlinV2d0`. * Fixed `PersistedOutputRDD` to eager persist RDD by adding `count()` action calls. * Changed behavior of GraphSON deserializer in gremlin-python such that `g:Set` returns a Python `Set`. * Changed behavior of `iterate()` in Python, Javascript and .NET to send `none()` thus avoiding unnecessary results being returned. diff --git a/docs/src/tutorials/gremlin-language-variants/index.asciidoc b/docs/src/tutorials/gremlin-language-variants/index.asciidoc index ebc988f..065657a 100644 --- a/docs/src/tutorials/gremlin-language-variants/index.asciidoc +++ b/docs/src/tutorials/gremlin-language-variants/index.asciidoc @@ -534,8 +534,6 @@ $ bin/gremlin-server.sh conf/gremlin-server-modern-py.yaml [INFO] Logger$info - Executed once at startup of Gremlin Server. [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+gryo with org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV3d0 [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+gryo-stringd with org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV3d0 -[INFO] AbstractChannelizer - Configured application/vnd.gremlin-v1.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0 -[INFO] AbstractChannelizer - Configured application/vnd.gremlin-v2.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV2d0 [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0 [INFO] AbstractChannelizer - Configured application/json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0 [INFO] GremlinServer$1 - Gremlin Server configured with worker thread pool of 1, gremlin pool of 4 and boss thread pool of 1. diff --git a/docs/src/upgrade/release-3.3.x.asciidoc b/docs/src/upgrade/release-3.3.x.asciidoc index 1cb2dbf..6787229 100644 --- a/docs/src/upgrade/release-3.3.x.asciidoc +++ b/docs/src/upgrade/release-3.3.x.asciidoc @@ -27,6 +27,20 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima Please see the link:https://github.com/apache/tinkerpop/blob/3.3.5/CHANGELOG.asciidoc#release-3-3-5[changelog] for a complete list of all the modifications that are part of this release. +=== Upgrading for Users + + Deprecated GraphSONMessageSerializerGremlinV2d0 + +The `GraphSONMessageSerializerGremlinV2d0` serializer is now analogous to `GraphSONMessageSerializerV2d0` and therefore +redundant. It has technically always been equivalent in terms of functionality as both serialized to the same format +(i.e. GraphSON 2.0 with embedded types). It is no longer clear why these two classes were established this way, but +it does carry the negative effect where multiple serializer versions could not be bound to Gremlin Server's HTTP +endpoint as the MIME types conflicted on `application/json`. By simply making both message serializers support +`application/json` and `application/vnd.gremlin-v2.0+json`, it then became possible to overcome that limitation. In +short, prefer use of `GraphSONMessageSerializerV2d0`
[tinkerpop] 01/01: TINKERPOP-1984 Enable GraphSON serializers to no longer conflict
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch TINKERPOP-1984 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit f0dac2a6e1e6319cdd3234e9ac4b3c527f931906 Author: Stephen Mallette AuthorDate: Mon Nov 5 16:14:31 2018 -0500 TINKERPOP-1984 Enable GraphSON serializers to no longer conflict Making GraphSONMessageSerializerV2d0 handle both typed and untyped formats allows it to be used in a fashion where users can choose to add both serializers at the same time for HTTP use cases. It also generally seemed to make more sense than how it was before. Not sure what changed to allow this now and not in the past. --- CHANGELOG.asciidoc | 1 + .../gremlin-language-variants/index.asciidoc | 2 - docs/src/upgrade/release-3.3.x.asciidoc| 14 + .../console/jsr223/gremlin-server-integration.yaml | 6 +- .../ser/GraphSONMessageSerializerGremlinV2d0.java | 4 +- .../driver/ser/GraphSONMessageSerializerV2d0.java | 4 +- .../driver/ser/GraphSONMessageSerializerV3d0.java | 2 +- .../tinkerpop/gremlin/driver/ser/Serializers.java | 2 +- .../gremlin/server/AbstractChannelizer.java| 2 +- .../server/GremlinServerHttpIntegrateTest.java | 64 -- .../gremlin/server/gremlin-server-integration.yaml | 4 +- 11 files changed, 88 insertions(+), 17 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index e13e71c..0262171 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -25,6 +25,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima This release also includes changes from <>. +* Deprecated `GraphSONMessageSerializerV2d0` as it is now analogous to `GraphSONMessageSerializerGremlinV2d0`. * Fixed `PersistedOutputRDD` to eager persist RDD by adding `count()` action calls. * Changed behavior of GraphSON deserializer in gremlin-python such that `g:Set` returns a Python `Set`. * Changed behavior of `iterate()` in Python, Javascript and .NET to send `none()` thus avoiding unnecessary results being returned. diff --git a/docs/src/tutorials/gremlin-language-variants/index.asciidoc b/docs/src/tutorials/gremlin-language-variants/index.asciidoc index ebc988f..065657a 100644 --- a/docs/src/tutorials/gremlin-language-variants/index.asciidoc +++ b/docs/src/tutorials/gremlin-language-variants/index.asciidoc @@ -534,8 +534,6 @@ $ bin/gremlin-server.sh conf/gremlin-server-modern-py.yaml [INFO] Logger$info - Executed once at startup of Gremlin Server. [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+gryo with org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV3d0 [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+gryo-stringd with org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV3d0 -[INFO] AbstractChannelizer - Configured application/vnd.gremlin-v1.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0 -[INFO] AbstractChannelizer - Configured application/vnd.gremlin-v2.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV2d0 [INFO] AbstractChannelizer - Configured application/vnd.gremlin-v3.0+json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0 [INFO] AbstractChannelizer - Configured application/json with org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV3d0 [INFO] GremlinServer$1 - Gremlin Server configured with worker thread pool of 1, gremlin pool of 4 and boss thread pool of 1. diff --git a/docs/src/upgrade/release-3.3.x.asciidoc b/docs/src/upgrade/release-3.3.x.asciidoc index 1cb2dbf..6787229 100644 --- a/docs/src/upgrade/release-3.3.x.asciidoc +++ b/docs/src/upgrade/release-3.3.x.asciidoc @@ -27,6 +27,20 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima Please see the link:https://github.com/apache/tinkerpop/blob/3.3.5/CHANGELOG.asciidoc#release-3-3-5[changelog] for a complete list of all the modifications that are part of this release. +=== Upgrading for Users + + Deprecated GraphSONMessageSerializerGremlinV2d0 + +The `GraphSONMessageSerializerGremlinV2d0` serializer is now analogous to `GraphSONMessageSerializerV2d0` and therefore +redundant. It has technically always been equivalent in terms of functionality as both serialized to the same format +(i.e. GraphSON 2.0 with embedded types). It is no longer clear why these two classes were established this way, but +it does carry the negative effect where multiple serializer versions could not be bound to Gremlin Server's HTTP +endpoint as the MIME types conflicted on `application/json`. By simply making both message serializers support +`application/json` and `application/vnd.gremlin-v2.0+json`, it then became possible to overcome that limitation. In +short, prefer use of `GraphSONMessageSerializerV2d0`
[tinkerpop] branch TINKERPOP-1984 created (now f0dac2a)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-1984 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at f0dac2a TINKERPOP-1984 Enable GraphSON serializers to no longer conflict This branch includes the following new commits: new f0dac2a TINKERPOP-1984 Enable GraphSON serializers to no longer conflict The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource
jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added
AnonymousTraversalSource
URL: https://github.com/apache/tinkerpop/pull/968#discussion_r231037790
##
File path: gremlin-javascript/src/main/javascript/gremlin-javascript/index.js
##
@@ -72,7 +72,8 @@ module.exports = {
GraphTraversal: gt.GraphTraversal,
GraphTraversalSource: gt.GraphTraversalSource,
statics: gt.statics,
-Translator
+Translator,
+traversal: gt.traversal
Review comment:
This is `undefined`, its currently exposed under `./lib/structure/graph`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource
jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added
AnonymousTraversalSource
URL: https://github.com/apache/tinkerpop/pull/968#discussion_r231031448
##
File path: docs/src/reference/gremlin-variants.asciidoc
##
@@ -477,24 +485,23 @@ in Gremlin-Java. The `GraphTraversalSource` requires a
RemoteConnection implemen
[source,javascript]
const gremlin = require('gremlin');
-const Graph = gremlin.structure.Graph;
+const traversal = gremlin.structure.Graph.traversal;
Review comment:
This should be exposed at:`gremlin.process.traversal`, to match java's
`org.apache.tinkerpop.gremlin.process.traversal`
```suggestion
const traversal = gremlin.process.traversal;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource
jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added
AnonymousTraversalSource
URL: https://github.com/apache/tinkerpop/pull/968#discussion_r231038276
##
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js
##
@@ -158,11 +159,20 @@ function areEqual(obj1, obj2) {
return false;
}
+/**
+* Returns an anonymous traversal source.
+* @returns {GraphTraversalSource}
+*/
+function traversal() {
Review comment:
This method is being implemented on `./lib/structure/graph.js` when it
should be under `lib/process` directory.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource
jorgebay commented on a change in pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource URL: https://github.com/apache/tinkerpop/pull/968#discussion_r231031690 ## File path: docs/src/reference/gremlin-variants.asciidoc ## @@ -100,7 +100,7 @@ Gremlin-Python users will typically make use of the following classes. [source,python] >>> from gremlin_python import statics ->>> from gremlin_python.structure.graph import Graph +>>> from gremlin_python.structure.graph import traversal Review comment: To match java/C#/javascript, I think we should expose it under `process` not `structure`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jorgebay commented on issue #981: TINKERPOP-2084 Display remote stacktrace in gremlin console
jorgebay commented on issue #981: TINKERPOP-2084 Display remote stacktrace in gremlin console URL: https://github.com/apache/tinkerpop/pull/981#issuecomment-436164243 Thats super useful, VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
