[GitHub] [tinkerpop] spmallette commented on issue #1245: TINKERPOP-2338 Fix bug in drop() of edge/meta properties
spmallette commented on issue #1245: TINKERPOP-2338 Fix bug in drop() of edge/meta properties URL: https://github.com/apache/tinkerpop/pull/1245#issuecomment-585847902 Not sure what's wrong with travis - both are failing due to the docker portion of the build and are related to the python portion of things. The error specifies a missing python module but it builds fine for me locally with a standard maven build as well as a the very docker build being executed in travis. For now let's assume the problem is environmental/travis and not let it get in the way of the review. I'll keep trying to re-run the job periodically and see if i can get it to pass. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] mmadoo opened a new pull request #1246: TINKERPOP-2337 In upgrade guide for 3.4.2, the option RemoteConnection.PER_REQUEST_TIMEOUT does not exist
mmadoo opened a new pull request #1246: TINKERPOP-2337 In upgrade guide for 3.4.2, the option RemoteConnection.PER_REQUEST_TIMEOUT does not exist URL: https://github.com/apache/tinkerpop/pull/1246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch TINKERPOP-2338 updated (ba05a7d -> 0b06800)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2338 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard ba05a7d TINKERPOP-2338 Updated changelog and upgrade docs discard 4ccc557 TINKERPOP-2338 Fix gherkin test runner for .NET discard 780153e TINKERPOP-2338 Fixed bug in drop() of edge/meta properties add 0b06800 TINKERPOP-2338 Fixed bug in drop() of edge/meta properties This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ba05a7d) \ N -- N -- N refs/heads/TINKERPOP-2338 (0b06800) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
[tinkerpop] branch TINKERPOP-2338 updated (9d2f68c -> ba05a7d)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2338 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. discard 9d2f68c TINKERPOP-2338 Updated changelog and upgrade docs discard 3775925 TINKERPOP-2338 Fix gherkin test runner for .NET discard d317339 TINKERPOP-2338 wip add 780153e TINKERPOP-2338 Fixed bug in drop() of edge/meta properties add 4ccc557 TINKERPOP-2338 Fix gherkin test runner for .NET add ba05a7d TINKERPOP-2338 Updated changelog and upgrade docs This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9d2f68c) \ N -- N -- N refs/heads/TINKERPOP-2338 (ba05a7d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
[tinkerpop] branch TINKERPOP-2338 updated (3775925 -> 9d2f68c)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2338 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 3775925 TINKERPOP-2338 Fix gherkin test runner for .NET add 9d2f68c TINKERPOP-2338 Updated changelog and upgrade docs No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 2 +- docs/src/upgrade/release-3.4.x.asciidoc | 12 2 files changed, 13 insertions(+), 1 deletion(-)
[GitHub] [tinkerpop] spmallette opened a new pull request #1245: Tinkerpop 2338
spmallette opened a new pull request #1245: Tinkerpop 2338 URL: https://github.com/apache/tinkerpop/pull/1245 https://issues.apache.org/jira/browse/TINKERPOP-2338 wip This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch TINKERPOP-2338 updated: TINKERPOP-2338 Fix gherkin test runner for .NET
This is an automated email from the ASF dual-hosted git repository.
jorgebg pushed a commit to branch TINKERPOP-2338
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/TINKERPOP-2338 by this push:
new 3775925 TINKERPOP-2338 Fix gherkin test runner for .NET
3775925 is described below
commit 377592519f3d8cbb0c959769c490ddc38f97c5ee
Author: Jorge Bay Gondra
AuthorDate: Thu Feb 13 12:34:18 2020 +0100
TINKERPOP-2338 Fix gherkin test runner for .NET
Default to object for Properties() method generic param
---
.../test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs | 2 +-
.../Gherkin/TraversalEvaluation/ModernGraphTypeInformation.cs | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
index 621ec8e..59fd11e 100644
---
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
+++
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
@@ -41,7 +41,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
new Dictionary
{
// Add here the name of scenarios to ignore and the reason,
e.g.:
-{ "g_V_properties_propertiesXstartTimeX_drop",
IgnoreReason.NoReason },
+//{ "g_V_properties_propertiesXstartTimeX_drop",
IgnoreReason.NoReason },
};
private static class Keywords
diff --git
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/ModernGraphTypeInformation.cs
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/ModernGraphTypeInformation.cs
index 77ed4eb..d77ec5e 100644
---
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/ModernGraphTypeInformation.cs
+++
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/ModernGraphTypeInformation.cs
@@ -61,6 +61,7 @@ namespace
Gremlin.Net.IntegrationTest.Gherkin.TraversalEvaluation
switch (method.Name)
{
case nameof(GraphTraversal.Properties):
+return typeof(object);
case nameof(GraphTraversal.Values) when
parameterValues.Length == 1:
// The parameter contains the element property names
var properties = ((IEnumerable)
parameterValues[parameterValues.Length - 1]).Cast();
[tinkerpop] branch TINKERPOP-2338 created (now d317339)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2338 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at d317339 TINKERPOP-2338 wip This branch includes the following new commits: new d317339 TINKERPOP-2338 wip The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[tinkerpop] 01/01: TINKERPOP-2338 wip
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-2338
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit d31733952dfdbc727055c3d51b2ed35a4013f0c0
Author: Stephen Mallette
AuthorDate: Thu Feb 13 06:07:49 2020 -0500
TINKERPOP-2338 wip
---
.../strategy/optimization/LazyBarrierStrategy.java | 5 +++
.../optimization/LazyBarrierStrategyTest.java | 9 -
.../Gherkin/GherkinTestRunner.cs | 2 +-
.../src/main/jython/radish/feature_steps.py| 2 +
gremlin-test/features/filter/Drop.feature | 43 +-
.../process/traversal/step/filter/DropTest.java| 37 +++
6 files changed, 95 insertions(+), 3 deletions(-)
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
index 7a4b17d..1e2257f 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
@@ -23,6 +23,7 @@ import
org.apache.tinkerpop.gremlin.process.traversal.Traversal;
import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy;
import org.apache.tinkerpop.gremlin.process.traversal.step.Barrier;
import org.apache.tinkerpop.gremlin.process.traversal.step.PathProcessor;
+import org.apache.tinkerpop.gremlin.process.traversal.step.filter.DropStep;
import org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasStep;
import org.apache.tinkerpop.gremlin.process.traversal.step.filter.NoneStep;
import org.apache.tinkerpop.gremlin.process.traversal.step.map.FlatMapStep;
@@ -74,7 +75,11 @@ public final class LazyBarrierStrategy extends
AbstractTraversalStrategy traversal) {
+// drop() is a problem for bulked edge/meta properties because of
Property equality changes in TINKERPOP-2318
+// which made it so that a Property is equal if the key/value is
equal. as a result, they bulk together which
+// is fine for almost all cases except when you wish to drop the
property.
if (TraversalHelper.onGraphComputer(traversal) ||
+TraversalHelper.hasStepOfAssignableClass(DropStep.class,
traversal) ||
traversal.getTraverserRequirements().contains(TraverserRequirement.PATH) ||
(IS_TESTING &&
((TraversalHelper.hasStepOfAssignableClass(ProfileStep.class,
TraversalHelper.getRootTraversal(traversal)) ||
TraversalHelper.hasStepOfAssignableClass(ProfileSideEffectStep.class,
TraversalHelper.getRootTraversal(traversal)) // necessary cause ProfileTest
analyzes counts
diff --git
a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategyTest.java
b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategyTest.java
index b2bbd94..100ba8b 100644
---
a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategyTest.java
+++
b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategyTest.java
@@ -100,7 +100,14 @@ public class LazyBarrierStrategyTest {
{__.out().as("a").out().as("b").in().where(P.neq("a")).out().select("b").out(),
__.out().as("a").out().as("b").in().where(P.neq("a")).barrier(PATH_SIZE).out().select("b").barrier(PATH_SIZE).out(),
Collections.singletonList(PathRetractionStrategy.instance())},
{__.out().as("a").out().as("b").in().where(P.neq("a")).out().select("b").out().out(),
__.out().as("a").out().as("b").in().where(P.neq("a")).barrier(PATH_SIZE).out().select("b").barrier(PATH_SIZE).out().barrier(LAZY_SIZE).out(),
Collections.singletonList(PathRetractionStrategy.instance())},
{__.V().out().out().groupCount().by(__.out().out().out()).out(),
__.V().out().barrier(LAZY_SIZE).out().groupCount().by(__.out().out().barrier(LAZY_SIZE).out()).out(),
Collections.emptyList()},
-
{__.V().out().out().groupCount().by(__.out().out().out()).out().as("a"),
__.V().out().barrier(LAZY_SIZE).out().groupCount().by(__.out().out().barrier(LAZY_SIZE).out()).out().as("a"),
Collections.emptyList()}
+
{__.V().out().out().groupCount().by(__.out().out().out()).out().as("a"),
__.V().out().barrier(LAZY_SIZE).out().groupCount().by(__.out().out().barrier(LAZY_SIZE).out()).out().as("a"),
Collections.emptyList()},
+{__.out().drop(), __.out().drop(), Collections.emptyList()},
+{__.out().properties().drop(), __.out().properties().drop(),
