[GitHub] [tinkerpop] spmallette merged pull request #1284: TINKERPOP-1682 by-modulator optimization strategy
spmallette merged pull request #1284: URL: https://github.com/apache/tinkerpop/pull/1284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[tinkerpop] branch master updated (965b9d3 -> de29e8c)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 965b9d3 Merge branch '3.4-dev' add 99e52e9 Implemented `ByModulatorOptimizationStrategy` which replaces certain standard traversals w/ optimized traversals (e.g. `TokenTraversal`). add 563f13c Reordered TraversalStategies add 4de98a3 Added new tests as suggested by @okram. add ebf854c replaced TraversalRing's setTraversal() with replaceTraversal() add 3795443 Made sure that the barrier step and the reducing operator are reevaluated when the value traversal is being replaced. add 05ee281 Registered ByModulatorOptimizationStrategy in GraphSON and Gryo serializers and added it to the core imports. Thanks @okram for pointing that out. add 2826f13 Registered ByModulatorOptimizationStrategy with Gremlin-Python. add dd1be69 Fixed rebase conflicts and added missing Gherkin tests add 6266385 Updated CHANGELOG add 45e54d3 Fixed minor issues. Thanks @robertdale add 2cebde5 TINKERPOP-1682 Rebased on master - fixed compilation/test issues add 1f33554 TINKERPOP-1682 Account for value traversal in group() with by() optimization add 8ee1ffd TINKERPOP-1682 cleaned up documentation around this change add 12a6ef0 TINKERPOP-1682 Support by(T) on Property new de29e8c Merge branch 'TINKERPOP-1682' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 4 + docs/src/recipes/anti-patterns.asciidoc| 39 + docs/src/upgrade/release-3.5.x.asciidoc| 37 .../tinkerpop/gremlin/jsr223/CoreImports.java | 4 +- .../process/traversal/TraversalStrategies.java | 2 + .../process/traversal/lambda/TokenTraversal.java | 19 ++- .../gremlin/process/traversal/step/Grouping.java | 100 +++ .../process/traversal/step/TraversalParent.java| 5 +- .../traversal/step/filter/DedupGlobalStep.java | 6 + .../traversal/step/filter/PathFilterStep.java | 7 + .../traversal/step/filter/SampleGlobalStep.java| 6 + .../traversal/step/filter/WherePredicateStep.java | 8 +- .../process/traversal/step/map/GroupCountStep.java | 6 + .../process/traversal/step/map/GroupStep.java | 94 -- .../traversal/step/map/OrderGlobalStep.java| 13 ++ .../process/traversal/step/map/OrderLocalStep.java | 13 ++ .../process/traversal/step/map/PathStep.java | 7 + .../process/traversal/step/map/ProjectStep.java| 7 + .../process/traversal/step/map/SelectOneStep.java | 6 + .../process/traversal/step/map/SelectStep.java | 7 + .../process/traversal/step/map/TreeStep.java | 8 +- .../step/sideEffect/AggregateGlobalStep.java | 6 + .../step/sideEffect/AggregateLocalStep.java| 6 + .../step/sideEffect/GroupCountSideEffectStep.java | 6 + .../step/sideEffect/GroupSideEffectStep.java | 47 +++-- .../process/traversal/step/sideEffect/IoStep.java | 2 +- .../traversal/step/sideEffect/SackValueStep.java | 6 + .../step/sideEffect/TreeSideEffectStep.java| 7 + .../ByModulatorOptimizationStrategy.java | 139 +++ .../process/traversal/util/TraversalRing.java | 10 ++ .../structure/io/graphml/GraphMLWriter.java| 1 - .../structure/io/graphson/GraphSONModule.java | 13 +- .../gremlin/structure/io/gryo/GryoVersion.java | 11 +- .../traversal/lambda/TokenTraversalTest.java | 78 + .../ByModulatorOptimizationStrategyTest.java | 189 + .../optimization/PathProcessorStrategyTest.java| 2 +- .../traversal/util/TraversalExplanationTest.java | 3 +- .../python/gremlin_python/process/strategies.py| 16 +- gremlin-test/features/map/Select.feature | 24 +++ gremlin-test/features/sideEffect/Group.feature | 22 +++ .../process/traversal/step/map/OrderTest.java | 46 + .../process/traversal/step/map/SelectTest.java | 32 +++- .../traversal/step/sideEffect/GroupTest.java | 40 + 43 files changed, 969 insertions(+), 135 deletions(-) create mode 100644 gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/Grouping.java create mode 100644 gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/ByModulatorOptimizationStrategy.java create mode 100644 gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/lambda/TokenTraversalTest.java create mode 100644 gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/ByModulatorOpti
[tinkerpop] 01/01: Merge branch 'TINKERPOP-1682'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit de29e8c88c3f7db9d62d2c08335801c21f8e023e Merge: 965b9d3 12a6ef0 Author: Stephen Mallette AuthorDate: Thu May 14 08:16:45 2020 -0400 Merge branch 'TINKERPOP-1682' CHANGELOG.asciidoc | 4 + docs/src/recipes/anti-patterns.asciidoc| 39 + docs/src/upgrade/release-3.5.x.asciidoc| 37 .../tinkerpop/gremlin/jsr223/CoreImports.java | 4 +- .../process/traversal/TraversalStrategies.java | 2 + .../process/traversal/lambda/TokenTraversal.java | 19 ++- .../gremlin/process/traversal/step/Grouping.java | 100 +++ .../process/traversal/step/TraversalParent.java| 5 +- .../traversal/step/filter/DedupGlobalStep.java | 6 + .../traversal/step/filter/PathFilterStep.java | 7 + .../traversal/step/filter/SampleGlobalStep.java| 6 + .../traversal/step/filter/WherePredicateStep.java | 8 +- .../process/traversal/step/map/GroupCountStep.java | 6 + .../process/traversal/step/map/GroupStep.java | 94 -- .../traversal/step/map/OrderGlobalStep.java| 13 ++ .../process/traversal/step/map/OrderLocalStep.java | 13 ++ .../process/traversal/step/map/PathStep.java | 7 + .../process/traversal/step/map/ProjectStep.java| 7 + .../process/traversal/step/map/SelectOneStep.java | 6 + .../process/traversal/step/map/SelectStep.java | 7 + .../process/traversal/step/map/TreeStep.java | 8 +- .../step/sideEffect/AggregateGlobalStep.java | 6 + .../step/sideEffect/AggregateLocalStep.java| 6 + .../step/sideEffect/GroupCountSideEffectStep.java | 6 + .../step/sideEffect/GroupSideEffectStep.java | 47 +++-- .../process/traversal/step/sideEffect/IoStep.java | 2 +- .../traversal/step/sideEffect/SackValueStep.java | 6 + .../step/sideEffect/TreeSideEffectStep.java| 7 + .../ByModulatorOptimizationStrategy.java | 139 +++ .../process/traversal/util/TraversalRing.java | 10 ++ .../structure/io/graphml/GraphMLWriter.java| 1 - .../structure/io/graphson/GraphSONModule.java | 13 +- .../gremlin/structure/io/gryo/GryoVersion.java | 11 +- .../traversal/lambda/TokenTraversalTest.java | 78 + .../ByModulatorOptimizationStrategyTest.java | 189 + .../optimization/PathProcessorStrategyTest.java| 2 +- .../traversal/util/TraversalExplanationTest.java | 3 +- .../python/gremlin_python/process/strategies.py| 16 +- gremlin-test/features/map/Select.feature | 24 +++ gremlin-test/features/sideEffect/Group.feature | 22 +++ .../process/traversal/step/map/OrderTest.java | 46 + .../process/traversal/step/map/SelectTest.java | 32 +++- .../traversal/step/sideEffect/GroupTest.java | 40 + 43 files changed, 969 insertions(+), 135 deletions(-)
[GitHub] [tinkerpop] spmallette commented on pull request #1285: Tinkerpop-1641 Kerberos authentication for gremlin-python
spmallette commented on pull request #1285: URL: https://github.com/apache/tinkerpop/pull/1285#issuecomment-628593510 Sorry, it took me a bit to get to this: > This feature (Kerberos for gremlin-python) turned out to have a pretty large footprint because of the need to make the KDC server available in both gremlin-test and the gremlin-server-test docker container. yep - that spun out of control quickly :) > I am not entirely sure whether the gremlin-test jar-with-dependencies is the cleanest way to make the KDC available in the Docker container. That struck me as well in review. My initial reaction was that I'd like to keep `gremlin-test` isolated to Gremlin provider testing and to move re-usable test components somewhere else. I think we have other odds and ends like this KDC fixture. I'll need to think about that a bit more. > Because of the sheer complexity of Kerberos configs and error messages I thought it useful to document the transcripts of the manual connections made against the gremlin-server-test docker container. If reviewers feel the same, please state what is the best location for it (possibly not the current location docker/gremlin-server/docker-entrypoint.sh). I liked that bit of documentation actually. I was content with where you put it for now, but I will think so more on it. > Does anyone with knowledge of gremlin-dotnet see what is the matter? All earlier travis builds (red crosses above) only failed on gremlin-python, so if gremlin-dotnet builds are consistent, the current failure suggests the addition of the gcc and python3.6-dev packages would somehow interfere with dotnet. > If no ideas pop up, I will revert and reapply the gcc and python3.6-dev changes later this week and see what happens. > What is there to do to stop travis whining? Travis is flakey and I don't think it's our tests that cause the trouble. The environment fails for all sorts of reasons (e.g. internet connections die, VMs randomly timeout for no reason, etc). I've yet to see a pattern of failure that involves anything we can fix on our end unfortunately. I pretty much just look for clear test failures in Travis as things to worry about and just re-run tests as needed that failed to get a green run. I also mostly rely on my own local build. If i get a clean build with `mvn` and a good docker build locally it should be pretty solid. Travis seems happier now so whatever was the matter seems resolved. There was a failure with spark as of your last commit but I assume that's nothing. I restarted it and seems happy now I'll start thinking about the items I mentioned above to see what changes I might suggest. Thanks for the work on this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[tinkerpop] branch 3.4-dev updated (f609ccc -> c197ad6)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.4-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from f609ccc TINKERPOP-2368: Make sure JAVA_OPTIONS are properly expanded in gremlin-console add 0627717 Removed duplicate entry in changelog CTR add c197ad6 Merge branch '3.3-dev' into 3.4-dev No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 - 1 file changed, 1 deletion(-)
[tinkerpop] branch 3.3-dev updated (4cc4d8f -> 0627717)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.3-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 4cc4d8f Merge branch 'TINKERPOP-2365' into 3.3-dev add 0627717 Removed duplicate entry in changelog CTR No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 - 1 file changed, 1 deletion(-)
[tinkerpop] branch master updated (22ed856 -> 965b9d3)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 22ed856 Merge branch '3.4-dev' add 0627717 Removed duplicate entry in changelog CTR add c197ad6 Merge branch '3.3-dev' into 3.4-dev add 965b9d3 Merge branch '3.4-dev' No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 - 1 file changed, 1 deletion(-)
[GitHub] [tinkerpop] vtslab commented on pull request #1285: Tinkerpop-1641 Kerberos authentication for gremlin-python
vtslab commented on pull request #1285: URL: https://github.com/apache/tinkerpop/pull/1285#issuecomment-628524956 What is there to do to stop travis whining? - gremlin-dotnet now builds without any changes with respect to the earlier failing build - latest build now fails on network issues (Could not transfer artifact org.codehaus.groovy:groovy:jar:2.5.11 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)) I leave it at that and just wait until the PR review is complete (no hurry). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
