Re: [PR] Improved contains check for bulkset with elements [tinkerpop]
steigma commented on PR #2425: URL: https://github.com/apache/tinkerpop/pull/2425#issuecomment-1877243020 javascript build errors seem unrelated: ``` Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-npm (install node and npm) on project gremlin-javascript: Could not download Node.js: Got error code 522 from the server. -> [Help 1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @testing-library/jest-dom from 6.1.0 to 6.2.0 in /docs/gremlint [tinkerpop]
codecov-commenter commented on PR #2426: URL: https://github.com/apache/tinkerpop/pull/2426#issuecomment-1877228057 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`e8b9532`)](https://app.codecov.io/gh/apache/tinkerpop/commit/e8b9532fc0ec811460e97ebf5e00b8b9ec9192ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 76.18% compared to head [(`8fc1209`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2426?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 76.18%. Additional details and impacted files ```diff @@Coverage Diff@@ ## master#2426 +/- ## = Coverage 76.18% 76.18% - Complexity1313913140+1 = Files 1084 1084 Lines 6504465044 Branches 7264 7264 = + Hits 4955249557+5 + Misses1279812794-4 + Partials 2694 2693-1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2426?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/testing-library/jest-dom-6.2.0 created (now 8fc1209c04)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/testing-library/jest-dom-6.2.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 8fc1209c04 Bump @testing-library/jest-dom from 6.1.0 to 6.2.0 in /docs/gremlint No new revisions were added by this update.
[PR] Bump @testing-library/jest-dom from 6.1.0 to 6.2.0 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2426: URL: https://github.com/apache/tinkerpop/pull/2426 Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.1.0 to 6.2.0. Release notes Sourced from https://github.com/testing-library/jest-dom/releases";>@testing-library/jest-dom's releases. v6.2.0 https://github.com/testing-library/jest-dom/compare/v6.1.6...v6.2.0";>6.2.0 (2024-01-03) Features toHaveAccessibleDescription supports aria-description (https://redirect.github.com/testing-library/jest-dom/issues/565";>#565) (https://github.com/testing-library/jest-dom/commit/1fb156c2b544e0069c56a72a2f1909fe04850f6c";>1fb156c) v6.1.6 https://github.com/testing-library/jest-dom/compare/v6.1.5...v6.1.6";>6.1.6 (2023-12-27) Bug Fixes Upgrade @adobe/css-tools to v4.3.2 (https://redirect.github.com/testing-library/jest-dom/issues/553";>#553) (https://github.com/testing-library/jest-dom/commit/b64b953f76170f282c73329ee3479ede13610713";>b64b953) v6.1.5 https://github.com/testing-library/jest-dom/compare/v6.1.4...v6.1.5";>6.1.5 (2023-11-30) Bug Fixes support uppercase custom props in toHaveStyle (https://redirect.github.com/testing-library/jest-dom/issues/552";>#552) (https://github.com/testing-library/jest-dom/commit/b7b7c6a9652f259434d13a22e4319826a4bd4d8b";>b7b7c6a) v6.1.4 https://github.com/testing-library/jest-dom/compare/v6.1.3...v6.1.4";>6.1.4 (2023-10-12) Bug Fixes upgrade @adobe/css-tools to 4.3.1 to address vulnerability (https://redirect.github.com/testing-library/jest-dom/issues/532";>#532) (https://github.com/testing-library/jest-dom/commit/44f1eabc79b848f45daffac21c5f7383424e893c";>44f1eab) v6.1.3 https://github.com/testing-library/jest-dom/compare/v6.1.2...v6.1.3";>6.1.3 (2023-09-06) Bug Fixes proper @jest/globals import (https://redirect.github.com/testing-library/jest-dom/issues/530";>#530) (https://github.com/testing-library/jest-dom/commit/5b492ace23d52b7cb7d3f91913ed0b5311905a26";>5b492ac) v6.1.2 https://github.com/testing-library/jest-dom/compare/v6.1.1...v6.1.2";>6.1.2 (2023-08-24) Bug Fixes bump @adobe/css-tools for ESM support (https://redirect.github.com/testing-library/jest-dom/issues/525";>#525) (https://github.com/testing-library/jest-dom/commit/b959a681386164bf5d64f5b2b9c8bf891301bc12";>b959a68) v6.1.1 https://github.com/testing-library/jest-dom/compare/v6.1.0...v6.1.1";>6.1.1 (2023-08-23) ... (truncated) Commits https://github.com/testing-library/jest-dom/commit/1fb156c2b544e0069c56a72a2f1909fe04850f6c";>1fb156c feat: toHaveAccessibleDescription supports aria-description (https://redirect.github.com/testing-library/jest-dom/issues/565";>#565) https://github.com/testing-library/jest-dom/commit/b64b953f76170f282c73329ee3479ede13610713";>b64b953 fix: Upgrade @adobe/css-tools to v4.3.2 (https://redirect.github.com/testing-library/jest-dom/issues/553";>#553) https://github.com/testing-library/jest-dom/commit/746c6ca59a7bd10ab0a42a8fecf0001e80eeb647";>746c6ca docs: Fix typo at toHaveStyle function description (https://redirect.github.com/testing-library/jest-dom/issues/558";>#558) https://github.com/testing-library/jest-dom/commit/b7b7c6a9652f259434d13a22e4319826a4bd4d8b";>b7b7c6a fix: support uppercase custom props in toHaveStyle (https://redirect.github.com/testing-library/jest-dom/issues/552";>#552) https://github.com/testing-library/jest-dom/commit/4ae0231be83f3ca79ae3ff735cf6c0ceb399fea4";>4ae0231 docs: Add missing hr to README.md (https://redirect.github.com/testing-library/jest-dom/issues/550";>#550) https://github.com/testing-library/jest-dom/commit/44f1eabc79b848f45daffac21c5f7383424e893c";>44f1eab fix: upgrade @adobe/css-tools to 4.3.1 to address vulnerability (https://redirect.github.com/testing-library/jest-dom/issues/532";>#532) https://github.com/testing-library/jest-dom/commit/6d659995665076d78b9f874bec75545bfc56e5ab";>6d65999 chore: add jest/vitest version to bug report template (https://redirect.github.com/testing-library/jest-dom/issues/526";>#526) https://github.com/testing-library/jest-dom/commit/5b492ace23d52b7cb7d3f91913ed0b5311905a26";>5b492ac fix: proper @jest/globals import (https://redirect.github.com/testing-library/jest-dom/issues/530";>#530) https://github.com/testing-library/jest-dom/commit/b959a681386164bf5d64f5b2b9c8bf891301bc12";>b959a68 fix: bump @adobe/css-tools for ESM support (https://redirect.github.com/testing-library/jest-dom/issues/525";>#525) https://github.com/testing-library/jest-dom/commit/853a3e51ba6757a34780e32953525b6142eadcf9";>853a3e5 fix(package.json): update main and module file paths (https://redirect.github.com/testing-library/jest-dom/issues/523";>#523) See full diff in https://github.com/testing-library/jest-dom/compare/v6.1.0...v6.2.0";>compare view [![D
[PR] Improved contains check for bulkset with elements [tinkerpop]
steigma opened a new pull request, #2425:
URL: https://github.com/apache/tinkerpop/pull/2425
Improved within test check for bulkset with elements (i.e., Vertex, Edge,
VertexProperty) by using contains method. Due to changes w.r.t. Gremlin
comparison semantics (cf.
https://tinkerpop.apache.org/docs/3.7.0/dev/provider/#gremlin-semantics-concepts)
this check was no longer done efficiently, which led to some regressions (see
query/example below). In some cases, we can however ensure that the contains of
the bulkset (using hash code and Object.equals) leads to the same results as
the GremlinValueComparator.COMPARABILITY.equals. In fact, for elements, both
checks are only be done with the ids of these elements.
This change re-enables an efficient check for elements (if the bulkset also
contains these elements and only contains these kind of elements). This is
realized via a transient attribute (allContainedElementsSameClass) in the
bulkset class that represents whether all elements are of same type/class,
which is checked by the within test method. Tje attribute is computed lazily
when accessed to avoid overhead if the information is not required.
Pseudo code for sample data:
```
final Vertex x1 = G.addVertex(T.id, "x1", T.label, "person", "age", 27,
"name", "x1");
// many friends for x1
for (int i = 1; i < 1; ++i) {
final Vertex x1fi = G.addVertex(T.id, "f"+i, T.label, "person", "age",
27, "name", "f"+i);
x1.addEdge("knows", x1fi, T.id, "e-x1-f"+i, "weight", 0.5);
}
// one special friend that also has many other friends
final Vertex x1f0 = G.addVertex(T.id, "f0", T.label, "person", "age", 27,
"name", "f0");
x1.addEdge("knows", x1f0, T.id, "e-x1-f0", "weight", 0.5);
// adding these many other friends, so friends of friends for x1
for (int i = 1; i < 1; ++i) {
final Vertex x1f0ofi = G.addVertex(T.id, "fof"+i, T.label, "person",
"age", 27, "name", "fof"+i);
x1f0.addEdge("knows", x1f0ofi, T.id, "e-f0-f"+i, "weight", 0.5);
}
```
Sample query (which is very inefficiently executed without this change):
```
g.V("x1").as("root").aggregate("directFriends")
.select("root").out().aggregate("directFriends")
.select("directFriends").limit(1).unfold().out().where(without("directFriends"))
```
The query is obviously not optimally formulated, but reproduces the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-3029 Fix enumeration for .NET 8 [tinkerpop]
FlorianHockmann commented on code in PR #2424:
URL: https://github.com/apache/tinkerpop/pull/2424#discussion_r1441466689
##
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs:
##
@@ -82,21 +82,22 @@ public bool MoveNext()
}
private bool MoveNextInternal()
-{
+{
if (_fetchedNext) return _nextAvailable;
+
+if (!_nextAvailable || _nextAvailable &&
TraverserEnumerator.Current?.Bulk == 0)
Review Comment:
@EricSites sure, but `DefaultTraversal` is an `IEnumerator` itself so
`GetCurrent()` just forwards to `TraverserEnumerator.Current`. If it's illegal
to call `TraverserEnumerator.Current` before calling
`TraverserEnumerator.MoveNext()`, then it's also illegal to call `GetCurrent()`
before calling `MoveNext()`.
We could of course use a flag to check whether enumeration has been started
in `GetCurrent()` and return `null` otherwise, but I don't think it's a good
idea to deviate from the default behavior of .NET enumerators.
Did you see `GetCurrent()` in any stack trace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
