Re: [PR] TINKERPOP-3063 Fix bug in Gremlin.Net authentication for parallel requests [tinkerpop]
Cole-Greer commented on PR #2522: URL: https://github.com/apache/tinkerpop/pull/2522#issuecomment-2019172365 @FlorianHockmann Do you have any thoughts on the server side solution by @tien in https://github.com/apache/tinkerpop/pull/2525? If the server fix fully addresses the issue, then it should make the changes here as well as equivalent GLV changes unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3061] fix: failing authentication when multiple initially requests are executed concurrently [tinkerpop]
Cole-Greer commented on PR #2525: URL: https://github.com/apache/tinkerpop/pull/2525#issuecomment-2019163528 I agree with @kenhuuu that an additional test is warranted here to ensure that the server will always send a response to every request. We are now entering code freeze week in preparation for the 3.6.7 and 3.7.2 releases. I believe it is fair to grant an exception for a few days to give some time for such a test to be implemented and to ensure this PR can be included in the release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated (2dbdd31039 -> 8b51edae3f)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 2dbdd31039 Merge branch '3.7-dev' add 7776458585 Allow aliased client to pass along options (#2524) add 0b8b7ec4c5 Temporary fix to failing JDK8 test (#2529) add c5c9baa86b Merge branch '3.6-dev' into 3.7-dev new 8b51edae3f Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 +- .../apache/tinkerpop/gremlin/driver/Client.java| 5 +- .../tinkerpop/gremlin/driver/RequestOptions.java | 30 .../driver/remote/DriverRemoteConnection.java | 27 +-- .../driver/remote/DriverRemoteConnectionTest.java | 5 +- gremlin-go/driver/cucumber/gremlin.go | 2 +- .../gremlin-javascript/test/cucumber/gremlin.js| 2 +- gremlin-python/src/main/python/radish/gremlin.py | 2 +- .../server/ClientWithOptionsIntegrateTest.java | 87 ++ .../gremlin/test/features/map/Select.feature | 2 +- 11 files changed, 130 insertions(+), 35 deletions(-) create mode 100644 gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/ClientWithOptionsIntegrateTest.java
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 8b51edae3f858e518dbaa3b2ffd348bc82cee593 Merge: 2dbdd31039 c5c9baa86b Author: Cole-Greer AuthorDate: Mon Mar 25 15:53:02 2024 -0700 Merge branch '3.7-dev' CHANGELOG.asciidoc | 1 + .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 +- .../apache/tinkerpop/gremlin/driver/Client.java| 5 +- .../tinkerpop/gremlin/driver/RequestOptions.java | 30 .../driver/remote/DriverRemoteConnection.java | 27 +-- .../driver/remote/DriverRemoteConnectionTest.java | 5 +- gremlin-go/driver/cucumber/gremlin.go | 2 +- .../gremlin-javascript/test/cucumber/gremlin.js| 2 +- gremlin-python/src/main/python/radish/gremlin.py | 2 +- .../server/ClientWithOptionsIntegrateTest.java | 87 ++ .../gremlin/test/features/map/Select.feature | 2 +- 11 files changed, 130 insertions(+), 35 deletions(-)
(tinkerpop) 01/01: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit c5c9baa86b355d11808e80a380c5076580a32bf6
Merge: e39ef4fcce 0b8b7ec4c5
Author: Cole-Greer
AuthorDate: Mon Mar 25 15:26:49 2024 -0700
Merge branch '3.6-dev' into 3.7-dev
CHANGELOG.asciidoc | 1 +
.../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 +-
.../apache/tinkerpop/gremlin/driver/Client.java| 5 +-
.../tinkerpop/gremlin/driver/RequestOptions.java | 30
.../driver/remote/DriverRemoteConnection.java | 27 +--
.../driver/remote/DriverRemoteConnectionTest.java | 5 +-
gremlin-go/driver/cucumber/gremlin.go | 2 +-
.../gremlin-javascript/test/cucumber/gremlin.js| 2 +-
gremlin-python/src/main/python/radish/gremlin.py | 2 +-
.../server/ClientWithOptionsIntegrateTest.java | 87 ++
.../gremlin/test/features/map/Select.feature | 2 +-
11 files changed, 130 insertions(+), 35 deletions(-)
diff --cc gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
index e520b2b328,bf7e01c810..b10a2db7ab
--- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
+++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
@@@ -1164,7 -892,7 +1164,7 @@@ namespace Gremlin.Net.IntegrationTest.G
{"g_withStrategiesXProductiveByStrategyX_V_asXaX_selectXaX_byXageX", new
List, ITraversal>>
{(g,p) =>g.WithStrategies(new ProductiveByStrategy(productiveKeys: new
List {})).V().As("a").Select("a").By("age")}},
{"g_withSideEffectXk_nullX_injectXxX_selectXkX", new
List, ITraversal>>
{(g,p) =>g.WithSideEffect("k",null).Inject("x").Select("k")}},
{"g_V_out_in_selectXall_a_a_aX_byXunfold_name_foldX", new
List, ITraversal>>
{(g,p)
=>g.AddV("A").Property("name","a1").As("a1").AddV("A").Property("name","a2").As("a2").AddV("A").Property("name","a3").As("a3").AddV("B").Property("name","b1").As("b1").AddV("B").Property("name","b2").As("b2").AddV("B").Property("name","b3").As("b3").AddE("ab").From("a1").To("b1").AddE("ab").From("a2").To("b2").AddE("ab").From("a3").To(
[...]
-- {"g_V_asXlabelX_aggregateXlocal_xX_selectXxX_selectXlabelX",
new List, ITraversal>>
{(g,p)
=>g.V().As("label").Aggregate(Scope.Local,"x").Select("x").Select("label")}},
++ {"g_V_asXlabelX_aggregateXlocal_xX_selectXxX_selectXlabelX",
new List, ITraversal>>
{(g,p)
=>g.V().As("label").Aggregate(Scope.Local,"x").Barrier().Select("x").Select("label")}},
{"g_V_shortestPath", new List, ITraversal>> {(g,p)
=>g.V().Identity().ShortestPath()}},
{"g_V_both_dedup_shortestPath", new
List, ITraversal>>
{(g,p) =>g.V().Both().Dedup().ShortestPath()}},
{"g_V_shortestPath_edgesIncluded", new
List, ITraversal>>
{(g,p)
=>g.V().Identity().ShortestPath().With("~tinkerpop.shortestPath.includeEdges")}},
diff --cc
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
index 63d7dad91a,cd5c2b68e0..f439157999
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
@@@ -18,13 -18,22 +18,23 @@@
*/
package org.apache.tinkerpop.gremlin.driver;
-import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
+import org.apache.tinkerpop.gremlin.util.message.RequestMessage;
+ import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+ import
org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.OptionsStrategy;
+ import org.apache.tinkerpop.gremlin.process.traversal.util.BytecodeHelper;
import java.util.HashMap;
+ import java.util.Iterator;
import java.util.Map;
import java.util.Optional;
import java.util.UUID;
-import static org.apache.tinkerpop.gremlin.driver.Tokens.ARGS_BATCH_SIZE;
-import static org.apache.tinkerpop.gremlin.driver.Tokens.ARGS_EVAL_TIMEOUT;
-import static org.apache.tinkerpop.gremlin.driver.Tokens.ARGS_USER_AGENT;
-import static org.apache.tinkerpop.gremlin.driver.Tokens.REQUEST_ID;
++import static org.apache.tinkerpop.gremlin.util.Tokens.ARGS_BATCH_SIZE;
++import static org.apache.tinkerpop.gremlin.util.Tokens.ARGS_EVAL_TIMEOUT;
++import static
org.apache.tinkerpop.gremlin.util.Tokens.ARGS_MATERIALIZE_PROPERTIES;
++import static org.apache.tinkerpop.gremlin.util.Tokens.ARGS_USER_AGENT;
++import static org.apache.tinkerpop.gremlin.util.Tokens.REQUEST_ID;
+
/**
* Options that can be supplied on a per request basis.
*
@@@ -88,6 -93,24 +98,26 @@@ public final class RequestOptions
return new Builder();
}
+ public static RequestOptions getRequestOptions(final Bytecode bytecode) {
+ final Iterator itty =
BytecodeHelper.findStrategies(bytecode, Op
(tinkerpop) branch 3.7-dev updated (e39ef4fcce -> c5c9baa86b)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from e39ef4fcce Merge branch '3.6-dev' into 3.7-dev add 7776458585 Allow aliased client to pass along options (#2524) add 0b8b7ec4c5 Temporary fix to failing JDK8 test (#2529) new c5c9baa86b Merge branch '3.6-dev' into 3.7-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 +- .../apache/tinkerpop/gremlin/driver/Client.java| 5 +- .../tinkerpop/gremlin/driver/RequestOptions.java | 30 .../driver/remote/DriverRemoteConnection.java | 27 +-- .../driver/remote/DriverRemoteConnectionTest.java | 5 +- gremlin-go/driver/cucumber/gremlin.go | 2 +- .../gremlin-javascript/test/cucumber/gremlin.js| 2 +- gremlin-python/src/main/python/radish/gremlin.py | 2 +- .../server/ClientWithOptionsIntegrateTest.java | 87 ++ .../gremlin/test/features/map/Select.feature | 2 +- 11 files changed, 130 insertions(+), 35 deletions(-) create mode 100644 gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/ClientWithOptionsIntegrateTest.java
(tinkerpop) branch 3.6-dev updated: Temporary fix to failing JDK8 test (#2529)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.6-dev by this push:
new 0b8b7ec4c5 Temporary fix to failing JDK8 test (#2529)
0b8b7ec4c5 is described below
commit 0b8b7ec4c5b57095f16464565e86c8f00c1f274f
Author: Ryan Tan <65996005+r...@users.noreply.github.com>
AuthorDate: Mon Mar 25 15:17:36 2024 -0700
Temporary fix to failing JDK8 test (#2529)
A new SelectStep test is failing in JDK8 tests due to a difference in
hashing between Java 8 and 11. In Java 8, the hash used to identify the
traverser to be removed from the no-op barrier is recomputed at removal, and
can't find a match due to other traversal branches having added vertices to the
bulkset, thus changing its potential hash value. Java 11 simply uses the hash
field stored at creation instead of recomputing it which avoids this problem.
This additional barrier step is a temporary fix that helps the query wait
until all the vertices have been added to the bulkset before adding traversals
to the no-op barrier so that hashing stays consistent.
---
.../org/apache/tinkerpop/gremlin/test/features/map/Select.feature | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
index b2f8ef8dc5..6229fa1935 100644
---
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
+++
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature
@@ -906,7 +906,7 @@ Feature: Step - select()
Given the modern graph
And the traversal of
"""
- g.V().as("label").aggregate(local,"x").select("x").select("label")
+
g.V().as("label").aggregate(local,"x").barrier().select("x").select("label")
"""
When iterated to list
Then the result should be unordered
Re: [PR] Temporary fix to failing JDK8 test [tinkerpop]
Cole-Greer merged PR #2529: URL: https://github.com/apache/tinkerpop/pull/2529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated: Allow aliased client to pass along options (#2524)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.6-dev by this push:
new 7776458585 Allow aliased client to pass along options (#2524)
7776458585 is described below
commit 777645858590475b8d612d6c1d4cdf63443cde3b
Author: Ryan Tan <65996005+r...@users.noreply.github.com>
AuthorDate: Mon Mar 25 15:16:59 2024 -0700
Allow aliased client to pass along options (#2524)
Refactored DriverRemoteConnection.getRequestOptions() to be a public static
method in RequestOptions so that Client.submitAsync() can get and pass along
options with it. This fixes the issue where aliased clients submitting
traversals containing with() configurations would ignore sending these options
as part of the request in https://issues.apache.org/jira/browse/TINKERPOP-3039.
---
CHANGELOG.asciidoc | 1 +
.../apache/tinkerpop/gremlin/driver/Client.java| 9 ++-
.../tinkerpop/gremlin/driver/RequestOptions.java | 27 +++
.../driver/remote/DriverRemoteConnection.java | 28 +--
.../driver/remote/DriverRemoteConnectionTest.java | 5 +-
.../server/ClientWithOptionsIntegrateTest.java | 87 ++
6 files changed, 124 insertions(+), 33 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index eceb847c17..a41951c2c1 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -37,6 +37,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
* Fixed bug in `EarlyLimitStrategy` which was too aggressive when promoting
`limit()` before `map()`.
* Prevented mid-traversal `mergeE()` and `mergeV()` from operating on an
incoming `Traverser` that contains an `Element`.
* Improved performance of the application of `FilterRankingStrategy` for large
traversals with deeply nested traversals by improving the cache operation.
+* Updated aliased client to pass along options via `with()` when submitting
traversals.
[[release-3-6-6]]
=== TinkerPop 3.6.6 (November 20, 2023)
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
index 513ec92096..415edde664 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
@@ -19,8 +19,6 @@
package org.apache.tinkerpop.gremlin.driver;
import org.apache.commons.lang3.exception.ExceptionUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.apache.tinkerpop.gremlin.driver.exception.ConnectionException;
import org.apache.tinkerpop.gremlin.driver.exception.NoHostAvailableException;
import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
@@ -30,6 +28,8 @@ import
org.apache.tinkerpop.gremlin.process.traversal.TraversalSource;
import org.apache.tinkerpop.gremlin.process.traversal.Traverser;
import org.apache.tinkerpop.gremlin.structure.Graph;
import org.apache.tinkerpop.gremlin.util.iterator.IteratorUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import javax.net.ssl.SSLException;
import java.net.ConnectException;
@@ -51,7 +51,8 @@ import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Consumer;
import java.util.stream.Collectors;
-import java.util.stream.IntStream;
+
+import static
org.apache.tinkerpop.gremlin.driver.RequestOptions.getRequestOptions;
/**
* A {@code Client} is constructed from a {@link Cluster} and represents a way
to send messages to Gremlin Server.
@@ -642,7 +643,7 @@ public abstract class Client {
@Override
public CompletableFuture submitAsync(final Bytecode
bytecode) {
-return submitAsync(bytecode, RequestOptions.EMPTY);
+return submitAsync(bytecode, getRequestOptions(bytecode));
}
@Override
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
index ac923f99ed..cd5c2b68e0 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
@@ -19,12 +19,21 @@
package org.apache.tinkerpop.gremlin.driver;
import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
+import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+import
org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.OptionsStrategy;
+import org.apache.tinkerpop.gremlin.process.traversal.util.BytecodeHelper;
import java.util.HashMap;
+import java.util.Iterator;
import java.util.Map;
import java.util.Opt
Re: [PR] Allow aliased client to pass along options when submitting traversals [tinkerpop]
Cole-Greer merged PR #2524: URL: https://github.com/apache/tinkerpop/pull/2524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3061] fix: failing authentication when multiple initially requests are executed concurrently [tinkerpop]
kenhuuu commented on PR #2525: URL: https://github.com/apache/tinkerpop/pull/2525#issuecomment-2018983365 Could you also add a test where the authentication fails and you check that all requests get the proper exception in that case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow aliased client to pass along options when submitting traversals [tinkerpop]
kenhuuu commented on PR #2524: URL: https://github.com/apache/tinkerpop/pull/2524#issuecomment-2018835412 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3061] fix: failing authentication when multiple initially requests are executed concurrently [tinkerpop]
Cole-Greer commented on PR #2525: URL: https://github.com/apache/tinkerpop/pull/2525#issuecomment-2018796622 Thanks @tien, looks great. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Temporary fix to failing JDK8 test [tinkerpop]
Cole-Greer commented on PR #2529: URL: https://github.com/apache/tinkerpop/pull/2529#issuecomment-2018786545 Thanks Ryan! LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow aliased client to pass along options when submitting traversals [tinkerpop]
ryn5 commented on code in PR #2524:
URL: https://github.com/apache/tinkerpop/pull/2524#discussion_r1538112999
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java:
##
@@ -914,6 +922,26 @@ public Settings create() {
}
}
+public static class ClientUtil {
Review Comment:
Moved method to RequestOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Temporary fix to failing JDK8 test [tinkerpop]
codecov-commenter commented on PR #2529: URL: https://github.com/apache/tinkerpop/pull/2529#issuecomment-2018704719 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2529?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 75.42%. Comparing base [(`d9e34fb`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d9e34fb4678c29ffa167066de45a9fa7329a319a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c373368`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2529?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 29 commits behind head on 3.6-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.6-dev#2529 +/- ## = + Coverage 75.14% 75.42% +0.28% - Complexity 1234612372 +26 = Files 1058 1033 -25 Lines 6361059900-3710 Branches6962 6974 +12 = - Hits 4780145182-2619 + Misses 1322512325 -900 + Partials2584 2393 -191 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2529?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Temporary fix to failing JDK8 test [tinkerpop]
ryn5 opened a new pull request, #2529: URL: https://github.com/apache/tinkerpop/pull/2529 A new SelectStep test is failing in JDK8 tests due to a difference in hashing between Java 8 and 11. In Java 8, the hash used to identify the traverser to be removed from the no-op barrier is recomputed at removal, and can't find a match due to other traversal branches having added vertices to the bulkset, thus changing its potential hash value. Java 11 simply uses the hash field stored at creation instead of recomputing it which avoids this problem. This additional barrier step is a temporary fix that helps the query wait until all the vertices have been added to the bulkset before adding traversals to the no-op barrier so that hashing stays consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
